Re-added "po_to_json" in jh's patch
What does this MR do and why?
What
Related issue: #2906 (comment 2432239)
通过使 gettext:po_to_json
命令适配 Jihu,解决 locale/en/app.js
等文件缺失的问题。这里都是 revert 掉之前的 commit,并没有新增的代码。
Why
在 SaaS 部署过程中,执行了 bundle exec rake gitlab:assets:compile
命令来生成 app.js 等文件,其中的核心代码是
Gitlab::TaskHelpers.invoke_and_time_task('gettext:po_to_json')
该命令之前有对 Jihu 的适配,但在最近的 MR 中被误删除了,导致不再生成 locale/en/app.js
等 Jihu 特有的文件。
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
- 手动删除
locale/en/app.js
$ rm app/assets/javascripts/locale/en/app.js
- 执行命令
rake gitlab:assets:compile
, 期望重新生成app.js
$ rake gitlab:assets:compile $ ls app/assets/javascripts/locale/en/app.js
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
由 路志远 编辑于