Job Failed #1716437587 - Skip all tests of one spec for temp
Job #1716437587 failed for 90ea5be4:
solution
We need skip all tests of one spec for temp since skip by line caused offset affected by upstream new tests that jobs failed again.
See https://gitlab.com/gitlab-jh/gitlab/-/jobs/1716437587#L1508
rspec ./spec/features/users/terms_spec.rb:14 # Users > Terms shows the terms
rspec ./spec/features/users/terms_spec.rb:20 # Users > Terms does not show buttons to accept, decline or sign out
rspec ./spec/features/users/terms_spec.rb:36 # Users > Terms when user is a project bot auto accepts the terms
rspec ./spec/features/users/terms_spec.rb:52 # Users > Terms when signed in declining the terms returns the user to the app
and https://gitlab.com/gitlab-jh/gitlab/-/blob/main-jh/jh/spec/skip_specs/list#L24-26
spec/features/users/terms_spec.rb:63
spec/features/users/terms_spec.rb:78
spec/features/users/terms_spec.rb:96
So change them as below for temp
spec/features/users/terms_spec.rb
To make pipeline pass, same as other tests, so as to avoid similar situation recently.
Updates
Found that this caused by the refactor of terms https://gitlab.com/gitlab-org/gitlab/-/merge_requests/72325#note_714728947
So just skip the tests in terms related
由 Qian Zhang (Gary) 编辑于