When a user has a comment draft saved in localstorage, we do not
indicate that on page load at all; the user can only see their comment
draft by clicking reply and seeing the draft populated into the markdown
editor.

This MR changes the noteable_discussion component's behavior such that
it exposes the markdown editor with the user's comment draft on page
load if there is a saved draft for the comment in localstorage.

Changelog: fixed

We are moving away from VueX in favour of Vue
and ApolloClient. We want to ling against new
VueX imports to make sure to warn developers
not to introduce new stores.

Changelog: changed

Changelog: fixed

- When there is a validation error when adding
a new note or replying to a discussion, display the
error message on top of the note in question, instead
of at the top of the viewing window
- Remove the placeholder note and return context
to the note-form

Changelog: fixed

This change is a refactor to not leave "bad examples" in the test
code wrongly restoring `window.gon` to its previous states
unnecessarily.

Andrei Zubov 创作于 2 years ago ，Vitaly Slobodin 提交于 2 years ago

* update @gitlab/eslint-plugin to the 18.2.0
* enable vtu-no-explicit-wrapper-destroy rule for spec files

No user facing changes

* act on @vue/test-utils 1.x deprecations to prepare for Vue3 upgrade

Renames comment button title in discussion reply
form to `Reply` when note is public, for internal
notes, it remains `Reply internally`.

Changelog: changed

This change fixes a bug where only "Markdown is supported" instead of
"Markdown" and "quick actions are supported" links are shown when
editing issue descriptions and comments

Changelog: fixed

This reverts commit c76dc705, reversing
changes made to e7a39d48.

When you scroll a discussion halfway up the page, the
Jump To Next Unresolved Discussion button will go to the
discussion after that one.

When you scroll the page such that a discussion scrolls down
through the middle of the page and below it, the Jump button
considers that discussion the "next" in line to be seen, and
will scroll to it.

Changelog: added

- spec/frontend/monitoring
- spec/frontend/notebook
- spec/frontend/notes

This fixes a bug where merge requests imported from GitHub
would cause the reply button to throw a JS error
because the discussion has no diff_refs.

Changelog: fixed

Closes https://gitlab.com/gitlab-org/gitlab/-/issues/332574

Added in 13.6

loadJSONFixtures and preloadFixtures aren't used in jest specs.
- Update eslint config
- Remove preloadFixtures calls from the jest specs
- Remove preloadFixtures and loadJSONFixtures from test_setup.js

In discussion threads there is a "Reply..." button styled to look like
a textarea which, when clicked, will open up a full GFM discussion
form with a textarea element. This changes this button into an actual
textarea to improve accessibility.

See https://gitlab.com/gitlab-org/frontend/eslint-plugin/-/issues/18
for more information.

`@vue/test-utils` 1.x deprecate `setMethods`

Part of our prettier migration; changing the arrow-parens style.

Closes https://gitlab.com/gitlab-org/gitlab/-/issues/235529

We follow this imports order:
// 1. "external" modules
import _ from 'lodash';
import chalk from 'chalk';
// 2. "internal" and aliased modules
import foo from 'src/foo';
// 3. modules from a "parent" directory
import foo from '../foo';
import qux from '../../foo/qux';
// 4. "sibling" modules from the same or a sibling's directory
import bar from './bar';
import baz from './bar/baz';
// 5. "index" of the current directory
import main from './';

See https://gitlab.com/gitlab-org/gitlab/-/issues/202172

This is part of multiple merge requests in order to reduce the risk of
breaking master

We are migrating all specs in javascripts/notes to frontend/notes

Move jump logic into mixin.
Remove logic from consuming components.

This commit removes { sync: false } accross entire codebase
This is useless since upgrade to @vue/test-utils 1.0.0.beta-30

Login or register widget used to be displayed if user cannot reply
which is not always right, as for instance when project is archived or
perhaps issue is locked and user cannot post a comment.

Fix karma violations with vue test utils by ensuring components are
mounted correctly

Since the Noteable Discussion already had pretty robust test 
coverage of the header, this is basically just moving the code 
for the component and the tests that cover it to a 
separate file.

- Show if user can_resolve all of the notes

- all commits squashed to make danger review happy