As part of Vue 3 migration
overriding method behavior and
direct data manipulation
should be avoided

Andrei Zubov 创作于 2 years ago ，Vitaly Slobodin 提交于 2 years ago

* update @gitlab/eslint-plugin to the 18.2.0
* enable vtu-no-explicit-wrapper-destroy rule for spec files

RFC: https://gitlab.com/gitlab-org/frontend/rfcs/-/issues/47

Changelog: added

Closes https://gitlab.com/gitlab-org/gitlab/-/issues/341809

Epic: https://gitlab.com/gitlab-org/gitlab/-/issues/220482

This is a follow-up of
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/63878.

Either `setWindowLocation` or `useMockLocationHelper` has been used, as
appropriate.

Assigning directly to `location.hash` has _not_ been migrated
everywhere, as that [works as expected in Jest/jsdom][1].

[1]: https://github.com/jsdom/jsdom/blob/16.4.0/lib/jsdom/living/window/navigation.js#L76

Jest/JSDOM provides a more robust and simple way of setting the mocked
`window.location`, which preserves all the expected behaviours and
properties of `window.location`.

By using it, we can get rid of hacks which attempt to recreate
behaviours of `window.location` that we lost by mutating it ourselves
(for instance, adding a `toString` method).

This fixes a bug where viewing a commit in a single commit
merge request would throw a JavaScript error and not
display the merge request controls.

Closes https://gitlab.com/gitlab-org/gitlab/-/issues/326801

This also sets up some integration test
helpers for diffs which will be helpful
in the long run

When reviewing an MR commit by commit, there are `Prev` and `Next`
buttons next to the commit message to jump to the neighbor
commits. These are helpful, but they slide outside of view when
scrolling to the bottom.

These buttons were initially introduced in [1].

This changes moves these buttons to the sticky Merge Request controls
bar. This bar remains visible at all times, making the neighbor commit
buttons accessible even when scrolled to the bottom.

1. ee921003 (Add buttons to the Commit Item to navigate among MR
   commits, 2020-05-12)

See https://gitlab.com/gitlab-org/frontend/eslint-plugin/-/issues/18
for more information.

Sort JavaScript imports in the CE specs
to match our future ESLint configuration.

- Also improves empty state text

https://gitlab.com/gitlab-org/gitlab/-/merge_requests/43467

Part of our prettier migration; changing the arrow-parens style.

- is-active class was missing
- added data selectors for QA / functional tests

Ensure the number of files displayed in the
 tab counter is the same the diff stats.

Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/33849

We're splitting `compare_versions_dropdown` into 3 separate components
A "layout" component and two "higher order" compoments

This should greatly simplify the code, and testing.

- implement restyle minus the components shared by web IDE
- https://gitlab.com/gitlab-org/gitlab/-/merge_requests/23665

This reverts commit 5b9bdbb0, reversing
changes made to 65a22395.

- Part of the zen code review initiative
- Add file icons
- Change search text
- Add modification in file header

attachToDocument property is not needed

Update actions to return data
Remove diffFilesLength getter
Use local state and props for diffFilesLength
Update tests

This commit removes { sync: false } accross entire codebase
This is useless since upgrade to @vue/test-utils 1.0.0.beta-30

gitlab-ui tooltip component is based on bootstrap-vue tooltip
component. Starting with bootstrap-vue 2.0, testing Vue components
that use BV tooltip requires to attach the component under test to the
document object using vue-test-utils attachToDocument mounting option.
It also requires setting the `sync` option to true.

This change affected a significant amount of unit tests in GitLab
codebase. These effects impede GitLab from upgrading to
bootstrap-vue 2.0. To address this problem we first attempted to fix
all the affected tests. The list is broken tests is located in
https://gitlab.com/gitlab-org/gitlab/merge_requests/18913.

Over time, more tests appeared broken as they were using the tooltip
directive too. The goal to fix broken tests became a moving target,
so we desisted. This new approach mocks the tooltip directive and
tooltip component to decouple the unit tests from the bootstrap-vue
dependency.

Migrated some diffs specs from Karma to Jest + VTU, this will help with
the BootrstrapVue upgrade.