From fbb03b27610d78cdba8f6e6b02a303140a002f98 Mon Sep 17 00:00:00 2001
From: Doug Stull <dstull@gitlab.com>
Date: Tue, 21 Nov 2023 19:59:37 +0000
Subject: [PATCH] Add back the group label matching yml for saas feature yml
- removed during initial deployment for backfilling, see
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/133236#note_1600494778
---
danger/saas_feature/Dangerfile | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/danger/saas_feature/Dangerfile b/danger/saas_feature/Dangerfile
index 38ca87fb5fd0..159201f8904c 100644
--- a/danger/saas_feature/Dangerfile
+++ b/danger/saas_feature/Dangerfile
@@ -13,7 +13,11 @@ SUGGEST_COMMENT
def check_yaml(saas_feature)
mr_group_label = helper.group_label
- message_for_missing_group!(saas_feature: saas_feature, mr_group_label: mr_group_label) if saas_feature.group.nil?
+ if saas_feature.group.nil?
+ message_for_missing_group!(saas_feature: saas_feature, mr_group_label: mr_group_label)
+ else
+ message_for_group!(saas_feature: saas_feature, mr_group_label: mr_group_label)
+ end
rescue Psych::Exception
# YAML could not be parsed, fail the build.
fail "#{helper.html_link(saas_feature.path)} isn't valid YAML! #{SEE_DOC.capitalize}"
--
GitLab