From fb67b4be4a3e6aa996c05615ceeef87b452a2cea Mon Sep 17 00:00:00 2001 From: gdk <gdk@example.com> Date: Sun, 27 Oct 2024 23:24:48 +0000 Subject: [PATCH] Finalize migration BackfillDastScannerProfilesBuildsProjectId This migration was finished at `2024-10-10 02:02:03 UTC`, you can confirm the status using our [batched background migration chatops commands](https://docs.gitlab.com/ee/development/database/batched_background_migrations.html#monitor-the-progress-and-status-of-a-batched-background-migration). To confirm it is finished you can run: ``` /chatops run batched_background_migrations status 1000723 ``` The last time this background migration was triggered was in [db/post_migrate/20240930135301_queue_backfill_dast_scanner_profiles_builds_project_id.rb](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/post_migrate/20240930135301_queue_backfill_dast_scanner_profiles_builds_project_id.rb) You can read more about the process for finalizing batched background migrations in https://docs.gitlab.com/ee/development/database/batched_background_migrations.html . As part of our process we want to ensure all batched background migrations have had at least one [required stop](https://docs.gitlab.com/ee/development/database/required_stops.html) to process the migration. Therefore we can finalize any batched background migration that was added before the last required stop. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::OverdueFinalizeBackgroundMigration keep. To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other --- ...ast_scanner_profiles_builds_project_id.yml | 5 +++-- ...dast_scanner_profiles_builds_project_id.rb | 21 +++++++++++++++++++ db/schema_migrations/20241027232438 | 1 + 3 files changed, 25 insertions(+), 2 deletions(-) create mode 100644 db/post_migrate/20241027232438_finalize_backfill_dast_scanner_profiles_builds_project_id.rb create mode 100644 db/schema_migrations/20241027232438 diff --git a/db/docs/batched_background_migrations/backfill_dast_scanner_profiles_builds_project_id.yml b/db/docs/batched_background_migrations/backfill_dast_scanner_profiles_builds_project_id.yml index 80da079846a7f..cbbb7a688a01a 100644 --- a/db/docs/batched_background_migrations/backfill_dast_scanner_profiles_builds_project_id.yml +++ b/db/docs/batched_background_migrations/backfill_dast_scanner_profiles_builds_project_id.yml @@ -1,8 +1,9 @@ --- migration_job_name: BackfillDastScannerProfilesBuildsProjectId -description: Backfills sharding key `dast_scanner_profiles_builds.project_id` from `dast_scanner_profiles`. +description: Backfills sharding key `dast_scanner_profiles_builds.project_id` from + `dast_scanner_profiles`. feature_category: dynamic_application_security_testing introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167626 milestone: '17.5' queued_migration_version: 20240930135301 -finalized_by: # version of the migration that finalized this BBM +finalized_by: '20241027232438' diff --git a/db/post_migrate/20241027232438_finalize_backfill_dast_scanner_profiles_builds_project_id.rb b/db/post_migrate/20241027232438_finalize_backfill_dast_scanner_profiles_builds_project_id.rb new file mode 100644 index 0000000000000..014c4e3ad3359 --- /dev/null +++ b/db/post_migrate/20241027232438_finalize_backfill_dast_scanner_profiles_builds_project_id.rb @@ -0,0 +1,21 @@ +# frozen_string_literal: true + +class FinalizeBackfillDastScannerProfilesBuildsProjectId < Gitlab::Database::Migration[2.2] + milestone '17.6' + + disable_ddl_transaction! + + restrict_gitlab_migration gitlab_schema: :gitlab_sec + + def up + ensure_batched_background_migration_is_finished( + job_class_name: 'BackfillDastScannerProfilesBuildsProjectId', + table_name: :dast_scanner_profiles_builds, + column_name: :ci_build_id, + job_arguments: [:project_id, :dast_scanner_profiles, :project_id, :dast_scanner_profile_id], + finalize: true + ) + end + + def down; end +end diff --git a/db/schema_migrations/20241027232438 b/db/schema_migrations/20241027232438 new file mode 100644 index 0000000000000..79a991180c588 --- /dev/null +++ b/db/schema_migrations/20241027232438 @@ -0,0 +1 @@ +bf583f1f7f53e25e861091a8afdf962d2fcc701f294620bbd9d4c3c9b8c12ae1 \ No newline at end of file -- GitLab