From fb06aca117ab018a50c0f11eadeadb9b9221bf61 Mon Sep 17 00:00:00 2001
From: gdk <gdk@example.com>
Date: Tue, 1 Oct 2024 23:21:02 +0000
Subject: [PATCH] Finalize migration BackfillApprovalsProjectId

This migration was finished at `2024-08-04 04:00:02 UTC`, you can confirm
the status using our
[batched background migration chatops commands](https://docs.gitlab.com/ee/development/database/batched_background_migrations.html#monitor-the-progress-and-status-of-a-batched-background-migration).
  To confirm it is finished you can run:

  ```
/chatops run batched_background_migrations status 1000629
```

The last time this background migration was triggered was in [db/post_migrate/20240719090631_queue_backfill_approvals_project_id.rb](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/post_migrate/20240719090631_queue_backfill_approvals_project_id.rb)

  You can read more about the process for finalizing batched background migrations in
https://docs.gitlab.com/ee/development/database/batched_background_migrations.html .

  As part of our process we want to ensure all batched background migrations have had at least one
[required stop](https://docs.gitlab.com/ee/development/database/required_stops.html)
to process the migration. Therefore we can finalize any batched background migration that was added before the
last required stop.

This change was generated by
[gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper)
using the Keeps::OverdueFinalizeBackgroundMigration keep.

To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the
label ~"GitLab Housekeeper" and consider pinging the author of this keep.

Changelog: other
---
 .../backfill_approvals_project_id.yml         |  2 +-
 ..._finalize_backfill_approvals_project_id.rb | 21 +++++++++++++++++++
 db/schema_migrations/20241001232051           |  1 +
 3 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 db/post_migrate/20241001232051_finalize_backfill_approvals_project_id.rb
 create mode 100644 db/schema_migrations/20241001232051

diff --git a/db/docs/batched_background_migrations/backfill_approvals_project_id.yml b/db/docs/batched_background_migrations/backfill_approvals_project_id.yml
index 27cd0428744ee..73fecd5304cb0 100644
--- a/db/docs/batched_background_migrations/backfill_approvals_project_id.yml
+++ b/db/docs/batched_background_migrations/backfill_approvals_project_id.yml
@@ -5,4 +5,4 @@ feature_category: code_review_workflow
 introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/160035
 milestone: '17.3'
 queued_migration_version: 20240719090631
-finalized_by: # version of the migration that finalized this BBM
+finalized_by: '20241001232051'
diff --git a/db/post_migrate/20241001232051_finalize_backfill_approvals_project_id.rb b/db/post_migrate/20241001232051_finalize_backfill_approvals_project_id.rb
new file mode 100644
index 0000000000000..7f29d61b1a3f0
--- /dev/null
+++ b/db/post_migrate/20241001232051_finalize_backfill_approvals_project_id.rb
@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+class FinalizeBackfillApprovalsProjectId < Gitlab::Database::Migration[2.2]
+  milestone '17.5'
+
+  disable_ddl_transaction!
+
+  restrict_gitlab_migration gitlab_schema: :gitlab_main_cell
+
+  def up
+    ensure_batched_background_migration_is_finished(
+      job_class_name: 'BackfillApprovalsProjectId',
+      table_name: :approvals,
+      column_name: :id,
+      job_arguments: [:project_id, :merge_requests, :target_project_id, :merge_request_id],
+      finalize: true
+    )
+  end
+
+  def down; end
+end
diff --git a/db/schema_migrations/20241001232051 b/db/schema_migrations/20241001232051
new file mode 100644
index 0000000000000..660ce528a5d5b
--- /dev/null
+++ b/db/schema_migrations/20241001232051
@@ -0,0 +1 @@
+18a0a5880415bbc6d9b4376b4d5d9733d9d3c9f9b0ce44f0236edcc218e0402b
\ No newline at end of file
-- 
GitLab