From f52900d7b38399494433fc148be672d576d1de1e Mon Sep 17 00:00:00 2001 From: gdk <gdk@example.com> Date: Sun, 2 Mar 2025 23:19:05 +0000 Subject: [PATCH] Finalize migration BackfillMlCandidateParamsProjectId This migration was finished at `2024-09-11 04:51:07 UTC`, you can confirm the status using our [batched background migration chatops commands](https://docs.gitlab.com/ee/development/database/batched_background_migrations.html#monitor-the-progress-and-status-of-a-batched-background-migration). To confirm it is finished you can run: ``` /chatops run batched_background_migrations status 1000663 ``` The last time this background migration was triggered was in [db/post_migrate/20240906131415_queue_backfill_ml_candidate_params_project_id.rb](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/post_migrate/20240906131415_queue_backfill_ml_candidate_params_project_id.rb) You can read more about the process for finalizing batched background migrations in https://docs.gitlab.com/ee/development/database/batched_background_migrations.html . As part of our process we want to ensure all batched background migrations have had at least one [required stop](https://docs.gitlab.com/ee/development/database/required_stops.html) to process the migration. Therefore we can finalize any batched background migration that was added before the last required stop. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::OverdueFinalizeBackgroundMigration keep. To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other --- ...ackfill_ml_candidate_params_project_id.yml | 2 +- ...backfill_ml_candidate_params_project_id.rb | 21 +++++++++++++++++++ db/schema_migrations/20250302231854 | 1 + 3 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 db/post_migrate/20250302231854_finalize_hk_backfill_ml_candidate_params_project_id.rb create mode 100644 db/schema_migrations/20250302231854 diff --git a/db/docs/batched_background_migrations/backfill_ml_candidate_params_project_id.yml b/db/docs/batched_background_migrations/backfill_ml_candidate_params_project_id.yml index cc28b212f17ec..f2936fc8cace3 100644 --- a/db/docs/batched_background_migrations/backfill_ml_candidate_params_project_id.yml +++ b/db/docs/batched_background_migrations/backfill_ml_candidate_params_project_id.yml @@ -5,4 +5,4 @@ feature_category: mlops introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/165336 milestone: '17.4' queued_migration_version: 20240906131415 -finalized_by: # version of the migration that finalized this BBM +finalized_by: '20250302231854' diff --git a/db/post_migrate/20250302231854_finalize_hk_backfill_ml_candidate_params_project_id.rb b/db/post_migrate/20250302231854_finalize_hk_backfill_ml_candidate_params_project_id.rb new file mode 100644 index 0000000000000..e5232b796e90f --- /dev/null +++ b/db/post_migrate/20250302231854_finalize_hk_backfill_ml_candidate_params_project_id.rb @@ -0,0 +1,21 @@ +# frozen_string_literal: true + +class FinalizeHkBackfillMlCandidateParamsProjectId < Gitlab::Database::Migration[2.2] + milestone '17.10' + + disable_ddl_transaction! + + restrict_gitlab_migration gitlab_schema: :gitlab_main_cell + + def up + ensure_batched_background_migration_is_finished( + job_class_name: 'BackfillMlCandidateParamsProjectId', + table_name: :ml_candidate_params, + column_name: :id, + job_arguments: [:project_id, :ml_candidates, :project_id, :candidate_id], + finalize: true + ) + end + + def down; end +end diff --git a/db/schema_migrations/20250302231854 b/db/schema_migrations/20250302231854 new file mode 100644 index 0000000000000..f30afb90a2486 --- /dev/null +++ b/db/schema_migrations/20250302231854 @@ -0,0 +1 @@ +200a96d5653c314ed9005d8e8027b7ec378ddd2ce76156c9fba450fe741881dd \ No newline at end of file -- GitLab