diff --git a/config/feature_flags/gitlab_com_derisk/go_get_handle_401_error.yml b/config/feature_flags/gitlab_com_derisk/go_get_handle_401_error.yml deleted file mode 100644 index 237eaaaf5888e988c2f689dea710a2d051ed3f5e..0000000000000000000000000000000000000000 --- a/config/feature_flags/gitlab_com_derisk/go_get_handle_401_error.yml +++ /dev/null @@ -1,9 +0,0 @@ ---- -name: go_get_handle_401_error -feature_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/493732 -introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167640 -rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/496539 -milestone: '17.5' -group: group::source code -type: gitlab_com_derisk -default_enabled: false diff --git a/lib/gitlab/middleware/go.rb b/lib/gitlab/middleware/go.rb index f61c612acf5728c1a31ff688d208f47617f6a935..04b03aea08e9a9fc064999ac0c0f5d623754abb7 100644 --- a/lib/gitlab/middleware/go.rb +++ b/lib/gitlab/middleware/go.rb @@ -130,10 +130,7 @@ def project_for_path(path_info) # can_read_project? checks if the request's credentials have read access to the project def can_read_project?(request, project) return true if project.public? - - if Feature.enabled?(:go_get_handle_401_error, Feature.current_request) && !has_basic_credentials?(request) - return false - end + return false unless has_basic_credentials?(request) login, password = user_name_and_password(request) auth_result = Gitlab::Auth.find_for_git_client(login, password, project: project, request: request) diff --git a/spec/lib/gitlab/middleware/go_spec.rb b/spec/lib/gitlab/middleware/go_spec.rb index ace21ba91338df88556a332c9fa6e2e7aa03ddca..584bcebd5ce83f46587f9e7bea3a1c1a77cd920f 100644 --- a/spec/lib/gitlab/middleware/go_spec.rb +++ b/spec/lib/gitlab/middleware/go_spec.rb @@ -69,17 +69,6 @@ it 'returns the 2-segment path' do expect_response_with_path(go, enabled_protocol, project.full_path) end - - context 'when "go_get_handle_401_error" feature flag disabled' do - before do - stub_feature_flags(go_get_handle_401_error: false) - end - - it 'returns 401 error response' do - response = go - expect(response[0]).to eq(401) - end - end end end