From f07f135458e2180a1cb4a10e806f0ec2c87ae557 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Coutable?= <remy@rymai.me> Date: Mon, 15 Apr 2024 17:29:40 +0200 Subject: [PATCH] Quarantine a flaky test The `Packages::TerraformModule::Metadata::ExtractFilesService#execute when processing a tar archive with a wrong entry size raises an ExtractionError` test has been reported as flaky more then 1000 times. This MR quarantines the test. This is a discussion starting point to let the responsible group know about the flakiness so that they can take action: - accept the merge request and schedule to improve the test - close the merge request in favor of another merge request to delete the test Related to https://gitlab.com/gitlab-org/gitlab/-/issues/446108. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::QuarantineFlakyTests keep. To provide feedback on your experience with `gitlab-housekeeper` please comment in <https://gitlab.com/gitlab-org/gitlab/-/issues/442003>. Changelog: other --- .../terraform_module/metadata/extract_files_service_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/services/packages/terraform_module/metadata/extract_files_service_spec.rb b/spec/services/packages/terraform_module/metadata/extract_files_service_spec.rb index 73fe491623a62..27e3b242d187c 100644 --- a/spec/services/packages/terraform_module/metadata/extract_files_service_spec.rb +++ b/spec/services/packages/terraform_module/metadata/extract_files_service_spec.rb @@ -27,7 +27,7 @@ allow(File).to receive(:size).and_return(described_class::MAX_FILE_SIZE + 1) end - it 'raises an ExtractionError' do + it 'raises an ExtractionError', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/446108' do expect do service.execute end.to raise_error(described_class::ExtractionError, /metadata file has the wrong entry size/) -- GitLab