diff --git a/.rubocop_todo/layout/space_inside_block_braces.yml b/.rubocop_todo/layout/space_inside_block_braces.yml
index 85c980c6509d87444aa2b047e7f502e5be766b48..7911a99169f9acaf9ea15a0466854e73a3df7289 100644
--- a/.rubocop_todo/layout/space_inside_block_braces.yml
+++ b/.rubocop_todo/layout/space_inside_block_braces.yml
@@ -78,34 +78,6 @@ Layout/SpaceInsideBlockBraces:
- 'ee/spec/helpers/projects/on_demand_scans_helper_spec.rb'
- 'ee/spec/mailers/credentials_inventory_mailer_spec.rb'
- 'ee/spec/migrations/geo/migrate_job_artifact_registry_spec.rb'
- - 'ee/spec/models/analytics/devops_adoption/enabled_namespace_spec.rb'
- - 'ee/spec/models/analytics/devops_adoption/snapshot_spec.rb'
- - 'ee/spec/models/approval_project_rule_spec.rb'
- - 'ee/spec/models/approval_state_spec.rb'
- - 'ee/spec/models/approvals/scan_finding_wrapped_rule_set_spec.rb'
- - 'ee/spec/models/ci/minutes/limit_spec.rb'
- - 'ee/spec/models/compliance_management/framework_spec.rb'
- - 'ee/spec/models/concerns/ee/clusters/agents/authorization_config_scopes_spec.rb'
- - 'ee/spec/models/concerns/elastic/issue_spec.rb'
- - 'ee/spec/models/dast/profile_schedule_spec.rb'
- - 'ee/spec/models/ee/audit_event_spec.rb'
- - 'ee/spec/models/ee/ci/build_dependencies_spec.rb'
- - 'ee/spec/models/ee/iteration_spec.rb'
- - 'ee/spec/models/ee/namespace/root_storage_size_spec.rb'
- - 'ee/spec/models/ee/namespace_limit_spec.rb'
- - 'ee/spec/models/environment_spec.rb'
- - 'ee/spec/models/epic_spec.rb'
- - 'ee/spec/models/gitlab/seat_link_data_spec.rb'
- - 'ee/spec/models/gitlab_subscription_spec.rb'
- - 'ee/spec/models/member_spec.rb'
- - 'ee/spec/models/milestone_release_spec.rb'
- - 'ee/spec/models/project_member_spec.rb'
- - 'ee/spec/models/protected_environment_spec.rb'
- - 'ee/spec/models/push_rule_spec.rb'
- - 'ee/spec/models/requirements_management/test_report_spec.rb'
- - 'ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb'
- - 'ee/spec/models/vulnerabilities/feedback_spec.rb'
- - 'ee/spec/models/vulnerabilities/finding_spec.rb'
- 'ee/spec/presenters/epic_issue_presenter_spec.rb'
- 'ee/spec/serializers/member_user_entity_spec.rb'
- 'ee/spec/serializers/merge_request_poll_widget_entity_spec.rb'
@@ -226,53 +198,6 @@ Layout/SpaceInsideBlockBraces:
- 'spec/migrations/reset_job_token_scope_enabled_spec.rb'
- 'spec/migrations/reset_severity_levels_to_new_default_spec.rb'
- 'spec/migrations/schedule_copy_ci_builds_columns_to_security_scans2_spec.rb'
- - 'spec/models/active_session_spec.rb'
- - 'spec/models/aws/role_spec.rb'
- - 'spec/models/ci/build_dependencies_spec.rb'
- - 'spec/models/ci/build_runner_session_spec.rb'
- - 'spec/models/ci/build_spec.rb'
- - 'spec/models/ci/daily_build_group_report_result_spec.rb'
- - 'spec/models/ci/job_artifact_spec.rb'
- - 'spec/models/ci/pipeline_schedule_spec.rb'
- - 'spec/models/ci/pipeline_spec.rb'
- - 'spec/models/ci/runner_spec.rb'
- - 'spec/models/clusters/cluster_spec.rb'
- - 'spec/models/commit_status_spec.rb'
- - 'spec/models/concerns/chronic_duration_attribute_spec.rb'
- - 'spec/models/concerns/counter_attribute_spec.rb'
- - 'spec/models/concerns/nullify_if_blank_spec.rb'
- - 'spec/models/concerns/reactive_caching_spec.rb'
- - 'spec/models/concerns/token_authenticatable_spec.rb'
- - 'spec/models/container_expiration_policy_spec.rb'
- - 'spec/models/container_repository_spec.rb'
- - 'spec/models/environment_spec.rb'
- - 'spec/models/event_spec.rb'
- - 'spec/models/group_spec.rb'
- - 'spec/models/hooks/web_hook_log_spec.rb'
- - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb'
- - 'spec/models/issue_spec.rb'
- - 'spec/models/jira_import_state_spec.rb'
- - 'spec/models/merge_request_spec.rb'
- - 'spec/models/namespace/root_storage_statistics_spec.rb'
- - 'spec/models/namespace_spec.rb'
- - 'spec/models/note_spec.rb'
- - 'spec/models/onboarding_progress_spec.rb'
- - 'spec/models/packages/conan/metadatum_spec.rb'
- - 'spec/models/packages/package_file_spec.rb'
- - 'spec/models/packages/package_spec.rb'
- - 'spec/models/postgresql/replication_slot_spec.rb'
- - 'spec/models/preloaders/labels_preloader_spec.rb'
- - 'spec/models/preloaders/user_max_access_level_in_groups_preloader_spec.rb'
- - 'spec/models/project_spec.rb'
- - 'spec/models/release_spec.rb'
- - 'spec/models/releases/link_spec.rb'
- - 'spec/models/remote_mirror_spec.rb'
- - 'spec/models/repository_spec.rb'
- - 'spec/models/snippet_input_action_collection_spec.rb'
- - 'spec/models/snippet_spec.rb'
- - 'spec/models/user_spec.rb'
- - 'spec/models/users/calloutable_spec.rb'
- - 'spec/models/wiki_page/meta_spec.rb'
- 'spec/policies/clusters/agent_policy_spec.rb'
- 'spec/policies/group_member_policy_spec.rb'
- 'spec/policies/issue_policy_spec.rb'
diff --git a/ee/spec/models/analytics/devops_adoption/enabled_namespace_spec.rb b/ee/spec/models/analytics/devops_adoption/enabled_namespace_spec.rb
index 8d371a6f42a686313182e46a8cfa54f71ae76147..5f95cb6e6b4fc7388dc2cb38df0a48d9fce560a1 100644
--- a/ee/spec/models/analytics/devops_adoption/enabled_namespace_spec.rb
+++ b/ee/spec/models/analytics/devops_adoption/enabled_namespace_spec.rb
@@ -35,7 +35,7 @@
let_it_be(:enabled_namespace1) { create(:devops_adoption_enabled_namespace) }
let_it_be(:enabled_namespace2) { create(:devops_adoption_enabled_namespace) }
let_it_be(:enabled_namespace3) { create(:devops_adoption_enabled_namespace) }
- let_it_be(:namespaces) { [enabled_namespace1.namespace, enabled_namespace2.namespace]}
+ let_it_be(:namespaces) { [enabled_namespace1.namespace, enabled_namespace2.namespace] }
it 'selects enabled_namespaces for given namespaces only' do
expect(enabled_namespaces).to match_array([enabled_namespace1, enabled_namespace2])
@@ -48,7 +48,7 @@
let_it_be(:enabled_namespace1) { create(:devops_adoption_enabled_namespace) }
let_it_be(:enabled_namespace2) { create(:devops_adoption_enabled_namespace) }
let_it_be(:enabled_namespace3) { create(:devops_adoption_enabled_namespace) }
- let_it_be(:namespaces) { [enabled_namespace1.display_namespace, enabled_namespace2.display_namespace]}
+ let_it_be(:namespaces) { [enabled_namespace1.display_namespace, enabled_namespace2.display_namespace] }
it 'selects enabled_namespaces for given namespaces only' do
expect(enabled_namespaces).to match_array([enabled_namespace1, enabled_namespace2])
diff --git a/ee/spec/models/analytics/devops_adoption/snapshot_spec.rb b/ee/spec/models/analytics/devops_adoption/snapshot_spec.rb
index ab527cda389965460c138992fab0721ce8d44400..b9201fd23248dde28f5e653a133f705b63809cc8 100644
--- a/ee/spec/models/analytics/devops_adoption/snapshot_spec.rb
+++ b/ee/spec/models/analytics/devops_adoption/snapshot_spec.rb
@@ -59,9 +59,9 @@
describe '.for_timespan' do
let_it_be(:first_date) { DateTime.parse('2021-05-10').end_of_month }
- let_it_be(:snapshot1) { create(:devops_adoption_snapshot, recorded_at: 1.day.ago, end_time: first_date)}
- let_it_be(:snapshot2) { create(:devops_adoption_snapshot, recorded_at: 1.day.ago, end_time: first_date + 1.month)}
- let_it_be(:snapshot3) { create(:devops_adoption_snapshot, recorded_at: 1.day.ago, end_time: first_date + 2.months)}
+ let_it_be(:snapshot1) { create(:devops_adoption_snapshot, recorded_at: 1.day.ago, end_time: first_date) }
+ let_it_be(:snapshot2) { create(:devops_adoption_snapshot, recorded_at: 1.day.ago, end_time: first_date + 1.month) }
+ let_it_be(:snapshot3) { create(:devops_adoption_snapshot, recorded_at: 1.day.ago, end_time: first_date + 2.months) }
it 'returns snapshots for given timespan', :aggregate_failures do
expect(described_class.for_timespan(to: first_date + 1.week)).to match_array([snapshot1])
diff --git a/ee/spec/models/approval_project_rule_spec.rb b/ee/spec/models/approval_project_rule_spec.rb
index c678c0afa37016541af60252d4c24a9138293bc4..35d41349ab28d1c405a3026b68f2f3596dc250c5 100644
--- a/ee/spec/models/approval_project_rule_spec.rb
+++ b/ee/spec/models/approval_project_rule_spec.rb
@@ -320,7 +320,7 @@
describe "#audit_creation after approval rule is created" do
let(:action!) { create(:approval_project_rule, approvals_required: 1) }
- let(:message) {'Added approval rule with number of required approvals of 1'}
+ let(:message) { 'Added approval rule with number of required approvals of 1' }
it_behaves_like 'audit event queue'
end
diff --git a/ee/spec/models/approval_state_spec.rb b/ee/spec/models/approval_state_spec.rb
index 328f8e2930b554ec06061deb0427c3bb2c11ebd6..8859ffa16295df3785801191ab93c0aaadebd5ad 100644
--- a/ee/spec/models/approval_state_spec.rb
+++ b/ee/spec/models/approval_state_spec.rb
@@ -175,8 +175,8 @@ def create_project_member(role, user_attrs = {})
context 'with multiple scan_finding rules' do
before do
- 2.times {create_rule({ rule_type: :report_approver, report_type: :scan_finding })}
- 2.times {create_rule({ rule_type: :report_approver, report_type: :scan_finding, orchestration_policy_idx: 1 })}
+ 2.times { create_rule({ rule_type: :report_approver, report_type: :scan_finding }) }
+ 2.times { create_rule({ rule_type: :report_approver, report_type: :scan_finding, orchestration_policy_idx: 1 }) }
end
it 'returns one rule for each orchestration_policy_idx' do
diff --git a/ee/spec/models/ci/minutes/limit_spec.rb b/ee/spec/models/ci/minutes/limit_spec.rb
index dcaa7f37510d879bea3ecfe8fdc62b29dca0429c..593b819ca7c2016d8e65b6594ce0338d3482f4fc 100644
--- a/ee/spec/models/ci/minutes/limit_spec.rb
+++ b/ee/spec/models/ci/minutes/limit_spec.rb
@@ -61,7 +61,7 @@
end
describe '#monthly' do
- subject { limit.monthly}
+ subject { limit.monthly }
where(:namespace_monthly_limit, :application_monthly_limit, :result) do
20 | 100 | 20
diff --git a/ee/spec/models/compliance_management/framework_spec.rb b/ee/spec/models/compliance_management/framework_spec.rb
index f79d85f32acf4a0f2d2220046201e0e5b4163266..360968754cc6a83fa27c0a2669735be38d3734ef 100644
--- a/ee/spec/models/compliance_management/framework_spec.rb
+++ b/ee/spec/models/compliance_management/framework_spec.rb
@@ -49,7 +49,7 @@
describe 'color' do
context 'with whitespace' do
- subject { create(:compliance_framework, color: ' #ABC123 ')}
+ subject { create(:compliance_framework, color: ' #ABC123 ') }
it 'strips whitespace' do
expect(subject.color).to eq('#ABC123')
diff --git a/ee/spec/models/concerns/ee/clusters/agents/authorization_config_scopes_spec.rb b/ee/spec/models/concerns/ee/clusters/agents/authorization_config_scopes_spec.rb
index b04352e62442a2815cf62f50cc84e005886bfcb1..4e0deb2fea5d1a0de3c994073f45dd5c0951515d 100644
--- a/ee/spec/models/concerns/ee/clusters/agents/authorization_config_scopes_spec.rb
+++ b/ee/spec/models/concerns/ee/clusters/agents/authorization_config_scopes_spec.rb
@@ -15,9 +15,9 @@
subject { Clusters::Agents::ProjectAuthorization.with_available_ci_access_fields(project) }
- it { is_expected.not_to include(ci_job_authorization)}
- it { is_expected.not_to include(ci_user_authorization)}
- it { is_expected.not_to include(impersonate_authorization)}
+ it { is_expected.not_to include(ci_job_authorization) }
+ it { is_expected.not_to include(ci_user_authorization) }
+ it { is_expected.not_to include(impersonate_authorization) }
context 'with :cluster_agents_ci_impersonation' do
before do
diff --git a/ee/spec/models/concerns/elastic/issue_spec.rb b/ee/spec/models/concerns/elastic/issue_spec.rb
index 2816513c8823e32aa2619b83bb030e3bafc1660f..e984ac265e1771461499b95f6e9d3a6765f6adf0 100644
--- a/ee/spec/models/concerns/elastic/issue_spec.rb
+++ b/ee/spec/models/concerns/elastic/issue_spec.rb
@@ -12,7 +12,7 @@
context 'when limited indexing is on' do
let_it_be(:project) { create :project, name: 'test1' }
- let_it_be(:issue) { create :issue, project: project}
+ let_it_be(:issue) { create :issue, project: project }
before do
stub_ee_application_setting(elasticsearch_limit_indexing: true)
diff --git a/ee/spec/models/dast/profile_schedule_spec.rb b/ee/spec/models/dast/profile_schedule_spec.rb
index b6752380fcb3b46d4838a8bdd4ca142a1d290bc6..0e11d229ad37bce23e10ef084c4f8ad04d48e3d0 100644
--- a/ee/spec/models/dast/profile_schedule_spec.rb
+++ b/ee/spec/models/dast/profile_schedule_spec.rb
@@ -148,7 +148,7 @@
end
context 'when there are no runnable schedules' do
- let!(:profile_schedule) { }
+ let!(:profile_schedule) {}
it 'returns an empty array' do
is_expected.to be_empty
diff --git a/ee/spec/models/ee/audit_event_spec.rb b/ee/spec/models/ee/audit_event_spec.rb
index 9284864e6ad3813657ce186c97a9673e3d37cb65..37497226d006deaeed3260c9073cab6617bac2c6 100644
--- a/ee/spec/models/ee/audit_event_spec.rb
+++ b/ee/spec/models/ee/audit_event_spec.rb
@@ -360,7 +360,7 @@
end
describe '#formatted_details' do
- subject(:event) { create(:group_audit_event, details: { change: 'membership_lock', from: false, to: true, ip_address: '127.0.0.1' })}
+ subject(:event) { create(:group_audit_event, details: { change: 'membership_lock', from: false, to: true, ip_address: '127.0.0.1' }) }
it 'converts value of `to` and `from` in `details` to string' do
expect(event.formatted_details[:to]).to eq('true')
diff --git a/ee/spec/models/ee/ci/build_dependencies_spec.rb b/ee/spec/models/ee/ci/build_dependencies_spec.rb
index 893b7a2b58f9bdfaa76d586f5b9ef6fa0736ad3a..4a279e5dc6216af0fedae03c94c45c4a92d3dc6b 100644
--- a/ee/spec/models/ee/ci/build_dependencies_spec.rb
+++ b/ee/spec/models/ee/ci/build_dependencies_spec.rb
@@ -6,7 +6,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:project, refind: true) { create(:project, :repository) }
- let(:dependencies) { }
+ let(:dependencies) {}
let(:pipeline) do
create(:ci_pipeline,
diff --git a/ee/spec/models/ee/iteration_spec.rb b/ee/spec/models/ee/iteration_spec.rb
index e3e5d0bd50140aec3c411899f098bf9e89bf93d5..b5c7c643e3d7cd169fb62849c95370f6ce065682 100644
--- a/ee/spec/models/ee/iteration_spec.rb
+++ b/ee/spec/models/ee/iteration_spec.rb
@@ -621,10 +621,10 @@
let_it_be(:plan_cadence) { create(:iterations_cadence, title: 'plan cadence', group: group1) }
let_it_be(:product_cadence) { create(:iterations_cadence, title: 'product management', group: subgroup) }
let_it_be(:cadence) { create(:iterations_cadence, title: 'cadence', group: group2) }
- let_it_be(:plan_iteration1) { create(:iteration, :with_due_date, title: "Iteration 1", iterations_cadence: plan_cadence, start_date: 1.week.ago)}
- let_it_be(:plan_iteration2) { create(:iteration, :with_due_date, title: "My iteration", iterations_cadence: plan_cadence, start_date: 2.weeks.ago)}
- let_it_be(:product_iteration) { create(:iteration, :with_due_date, title: "Iteration 2", iterations_cadence: product_cadence, start_date: 1.week.from_now)}
- let_it_be(:cadence_iteration) { create(:iteration, :with_due_date, iterations_cadence: cadence, start_date: Date.today)}
+ let_it_be(:plan_iteration1) { create(:iteration, :with_due_date, title: "Iteration 1", iterations_cadence: plan_cadence, start_date: 1.week.ago) }
+ let_it_be(:plan_iteration2) { create(:iteration, :with_due_date, title: "My iteration", iterations_cadence: plan_cadence, start_date: 2.weeks.ago) }
+ let_it_be(:product_iteration) { create(:iteration, :with_due_date, title: "Iteration 2", iterations_cadence: product_cadence, start_date: 1.week.from_now) }
+ let_it_be(:cadence_iteration) { create(:iteration, :with_due_date, iterations_cadence: cadence, start_date: Date.today) }
shared_examples "search returns correct records" do
it { is_expected.to contain_exactly(*expected_iterations) }
@@ -853,7 +853,7 @@
context 'when dates for an existing iteration change' do
context 'when iteration dates go from future to past' do
- let(:iteration) { create(:iteration, group: iterations_cadence.group, iterations_cadence: iterations_cadence, start_date: 2.weeks.from_now.utc.to_date, due_date: 3.weeks.from_now.utc.to_date)}
+ let(:iteration) { create(:iteration, group: iterations_cadence.group, iterations_cadence: iterations_cadence, start_date: 2.weeks.from_now.utc.to_date, due_date: 3.weeks.from_now.utc.to_date) }
it 'sets state to closed' do
expect(iteration.state).to eq('upcoming')
@@ -867,7 +867,7 @@
end
context 'when iteration dates go from past to future' do
- let(:iteration) { create(:iteration, group: iterations_cadence.group, iterations_cadence: iterations_cadence, start_date: 2.weeks.ago.utc.to_date, due_date: 1.week.ago.utc.to_date)}
+ let(:iteration) { create(:iteration, group: iterations_cadence.group, iterations_cadence: iterations_cadence, start_date: 2.weeks.ago.utc.to_date, due_date: 1.week.ago.utc.to_date) }
it 'sets state to upcoming' do
expect(iteration.state).to eq('closed')
diff --git a/ee/spec/models/ee/namespace/root_storage_size_spec.rb b/ee/spec/models/ee/namespace/root_storage_size_spec.rb
index ad0fcc6b041acd3299d874f251b852041fd2dd23..cf209eaa32b84d512ab100a1efdb11aac291ca14 100644
--- a/ee/spec/models/ee/namespace/root_storage_size_spec.rb
+++ b/ee/spec/models/ee/namespace/root_storage_size_spec.rb
@@ -9,7 +9,7 @@
let(:namespace) { create(:namespace) }
let(:current_size) { 50.megabytes }
let(:model) { described_class.new(namespace) }
- let(:create_statistics) { create(:namespace_root_storage_statistics, namespace: namespace, storage_size: current_size)}
+ let(:create_statistics) { create(:namespace_root_storage_statistics, namespace: namespace, storage_size: current_size) }
let_it_be(:ultimate_plan, reload: true) { create(:ultimate_plan) }
let_it_be(:plan_limits, reload: true) { create(:plan_limits, plan: ultimate_plan, storage_size_limit: 100) }
diff --git a/ee/spec/models/ee/namespace_limit_spec.rb b/ee/spec/models/ee/namespace_limit_spec.rb
index 013d55b713de7bb6f0f2f8a632fc25f74c038115..32aab7d9f7ca9f14b3c50e17ff3a63be2e15183e 100644
--- a/ee/spec/models/ee/namespace_limit_spec.rb
+++ b/ee/spec/models/ee/namespace_limit_spec.rb
@@ -99,7 +99,7 @@
it { is_expected.to validate_presence_of(:namespace) }
context 'namespace_is_root_namespace' do
- let(:namespace_limit) { build(:namespace_limit, namespace: namespace)}
+ let(:namespace_limit) { build(:namespace_limit, namespace: namespace) }
context 'when associated namespace is root' do
let(:namespace) { build(:group, parent: nil) }
diff --git a/ee/spec/models/environment_spec.rb b/ee/spec/models/environment_spec.rb
index 21738ed364988262e9e71817c7d20c223b58ab2c..19648c63e52e84365184eff468d679bc4e1f2357 100644
--- a/ee/spec/models/environment_spec.rb
+++ b/ee/spec/models/environment_spec.rb
@@ -114,7 +114,7 @@
end
context 'when the user is nil' do
- let(:user) { }
+ let(:user) {}
it { is_expected.to be_truthy }
end
@@ -167,7 +167,7 @@
end
context 'when the user is nil' do
- let(:user) { }
+ let(:user) {}
it { is_expected.to be_falsy }
end
@@ -385,7 +385,7 @@
let_it_be(:protected_environment) { create(:protected_environment, name: environment.name, project: project) }
let(:user) { qa_user }
- let(:represented_as) { }
+ let(:represented_as) {}
before_all do
qa_group.add_developer(qa_user)
diff --git a/ee/spec/models/epic_spec.rb b/ee/spec/models/epic_spec.rb
index a73f38972ddca4900e487fa5a462f7513f901e5d..aad1a4507e6198da3fee05e11cfa2d0160820a19 100644
--- a/ee/spec/models/epic_spec.rb
+++ b/ee/spec/models/epic_spec.rb
@@ -325,7 +325,7 @@ def epics(order_by)
let_it_be(:parent_epic) { create(:epic, group: group, parent: root_epic) }
let(:epic) { build(:epic, group: group) }
- let(:child_epic1) { create(:epic, group: group, parent: epic)}
+ let(:child_epic1) { create(:epic, group: group, parent: epic) }
it 'returns true when total depth after adding will not exceed limit' do
epic.parent = parent_epic
@@ -568,9 +568,9 @@ def epics(order_by)
let(:project2) { create(:project, group: group) }
let!(:epic) { create(:epic, group: group) }
- let!(:issue) { create(:issue, project: project)}
- let!(:lone_issue) { create(:issue, project: project)}
- let!(:other_issue) { create(:issue, project: project2)}
+ let!(:issue) { create(:issue, project: project) }
+ let!(:lone_issue) { create(:issue, project: project) }
+ let!(:other_issue) { create(:issue, project: project2) }
let!(:epic_issues) do
[
create(:epic_issue, epic: epic, issue: issue),
@@ -883,7 +883,7 @@ def as_item(item)
stub_licensed_features(epics: true)
end
- let(:epics) { [visible_epic]}
+ let(:epics) { [visible_epic] }
context 'with an admin when admin mode is enabled', :enable_admin_mode do
let(:user) { build(:user, admin: true) }
diff --git a/ee/spec/models/gitlab/seat_link_data_spec.rb b/ee/spec/models/gitlab/seat_link_data_spec.rb
index e45eda5b57b965662375442b24df50ef1af893cf..c65534e71e19359d8499c7a8791865ff06dea4c6 100644
--- a/ee/spec/models/gitlab/seat_link_data_spec.rb
+++ b/ee/spec/models/gitlab/seat_link_data_spec.rb
@@ -20,7 +20,7 @@
describe '#initialize' do
let_it_be(:utc_time) { Time.utc(2020, 3, 12, 12, 00) }
let_it_be(:license_start_date) { utc_time.to_date - 1.month }
- let_it_be(:current_license) { create_current_license(starts_at: license_start_date)}
+ let_it_be(:current_license) { create_current_license(starts_at: license_start_date) }
let_it_be(:max_before_today) { 15 }
let_it_be(:yesterday_billable_users_count) { 12 }
diff --git a/ee/spec/models/gitlab_subscription_spec.rb b/ee/spec/models/gitlab_subscription_spec.rb
index d327473e1434183cc95370906f20d008f059c736..cc527ad1eef82bb82f1ee4ef043c15c898690763 100644
--- a/ee/spec/models/gitlab_subscription_spec.rb
+++ b/ee/spec/models/gitlab_subscription_spec.rb
@@ -943,7 +943,7 @@
end
context 'when a subscription was purchased after the EoA rollout date' do
- let(:start_date) { eoa_rollout_date + 1.day}
+ let(:start_date) { eoa_rollout_date + 1.day }
it { is_expected.to be_falsey }
end
diff --git a/ee/spec/models/member_spec.rb b/ee/spec/models/member_spec.rb
index c8ab10078f7a3b28791ba791573bb7db753faba6..82fadcd1b22808f812a2f61fad1fedbecf5d02a0 100644
--- a/ee/spec/models/member_spec.rb
+++ b/ee/spec/models/member_spec.rb
@@ -130,7 +130,7 @@
describe 'for project members' do
context 'when project is nested in a group' do
let(:group) { create(:group) }
- let(:project) { create(:project, namespace: group)}
+ let(:project) { create(:project, namespace: group) }
let(:member) { create :project_member, source: project }
subject(:group_saml_identity) { member.group_saml_identity }
@@ -139,16 +139,16 @@
end
context 'when project is nested in a subgroup' do
- let(:parent_group) { create(:group)}
+ let(:parent_group) { create(:group) }
let(:group) { create(:group, parent: parent_group) }
- let(:project) { create(:project, namespace: group)}
+ let(:project) { create(:project, namespace: group) }
let(:member) { create :project_member, source: project }
it_behaves_like 'member with group saml identity on the top level'
end
context 'when project is nested in a personal namespace' do
- let(:project) { create(:project, namespace: create(:user).namespace )}
+ let(:project) { create(:project, namespace: create(:user).namespace ) }
let(:member) { create :project_member, source: project }
it 'returns nothing' do
@@ -165,7 +165,7 @@
end
let_it_be(:subgroup) { create(:group, parent: group) }
- let_it_be(:project, refind: true) { create(:project, namespace: group)}
+ let_it_be(:project, refind: true) { create(:project, namespace: group) }
let_it_be(:user) { create(:user) }
before_all do
@@ -278,7 +278,7 @@
context 'check if free user cap has been reached', :saas do
let_it_be(:group, refind: true) { create(:group_with_plan, plan: :free_plan) }
let_it_be(:subgroup) { create(:group, parent: group) }
- let_it_be(:project, refind: true) { create(:project, namespace: group)}
+ let_it_be(:project, refind: true) { create(:project, namespace: group) }
let_it_be(:user) { create(:user) }
before_all do
@@ -448,7 +448,7 @@
let(:member) { group.members.last }
let_it_be(:group, refind: true) { create(:group_with_plan, plan: :free_plan) }
- let_it_be(:project, refind: true) { create(:project, namespace: group)}
+ let_it_be(:project, refind: true) { create(:project, namespace: group) }
let_it_be(:active_user) { create(:user) }
let_it_be(:active_member) { create(:group_member, :maintainer, group: group, user: active_user) }
let_it_be(:user) { create(:user) }
diff --git a/ee/spec/models/milestone_release_spec.rb b/ee/spec/models/milestone_release_spec.rb
index e5e7e0847e9c9adcbe875001eaddfe059c3339d4..0012fe487a5be9fc2b16d34fd3e99b3e9162be07 100644
--- a/ee/spec/models/milestone_release_spec.rb
+++ b/ee/spec/models/milestone_release_spec.rb
@@ -30,7 +30,7 @@
context 'when group and release have the same project' do
let(:group) { create(:group) }
- let(:project) { create(:project, group: group)}
+ let(:project) { create(:project, group: group) }
context 'when it is licenced' do
before do
diff --git a/ee/spec/models/project_member_spec.rb b/ee/spec/models/project_member_spec.rb
index 9126a55fbab72c057fcd9899f6bca59a7e756282..0eb6ea55b4ecc924cb7ffa1f4f686bf0e2a45082 100644
--- a/ee/spec/models/project_member_spec.rb
+++ b/ee/spec/models/project_member_spec.rb
@@ -5,12 +5,12 @@
it { is_expected.to include_module(EE::ProjectMember) }
it_behaves_like 'member validations' do
- let(:entity) { create(:project, group: group)}
+ let(:entity) { create(:project, group: group) }
end
context 'validates GMA enforcement' do
let(:group) { create(:group_with_managed_accounts, :private) }
- let(:entity) { create(:project, namespace: group)}
+ let(:entity) { create(:project, namespace: group) }
before do
stub_feature_flags(group_managed_accounts: true)
diff --git a/ee/spec/models/protected_environment_spec.rb b/ee/spec/models/protected_environment_spec.rb
index 0ead3dac68be1cc252338bf26365f76eac745e1a..c8b57764ac708437320eb0450583c458f23685ac 100644
--- a/ee/spec/models/protected_environment_spec.rb
+++ b/ee/spec/models/protected_environment_spec.rb
@@ -156,7 +156,7 @@
end
context 'when user is nil' do
- let(:user) { }
+ let(:user) {}
it { is_expected.to eq(Gitlab::Access::NO_ACCESS) }
end
@@ -215,7 +215,7 @@
subject(:protected_environments) { described_class.sorted_by_name }
it "sorts protected environments by name" do
- %w(staging production development).each {|name| create(:protected_environment, name: name)}
+ %w(staging production development).each { |name| create(:protected_environment, name: name) }
expect(protected_environments.map(&:name)).to eq %w(development production staging)
end
@@ -232,8 +232,8 @@
removed_environment = create(:protected_environment, project: project, name: 'removed environment')
expect(protected_environments).to match_array [production, removed_environment]
- expect(protected_environments.find {|e| e.name == 'production'}.environment_id).to eq environment.id
- expect(protected_environments.find {|e| e.name == 'removed environment'}.environment_id).to be_nil
+ expect(protected_environments.find { |e| e.name == 'production' }.environment_id).to eq environment.id
+ expect(protected_environments.find { |e| e.name == 'removed environment' }.environment_id).to be_nil
end
end
@@ -336,7 +336,7 @@
end
context 'when environment does not exist' do
- let!(:environment) { }
+ let!(:environment) {}
it 'raises an error' do
expect { subject }.to raise_error(ArgumentError)
@@ -389,7 +389,7 @@
end
context 'when project-level protection does not exist' do
- let!(:protected_environment) { }
+ let!(:protected_environment) {}
it 'has only group-level protection' do
is_expected.to match_array([group_protected_environment])
diff --git a/ee/spec/models/push_rule_spec.rb b/ee/spec/models/push_rule_spec.rb
index c328105310aa665e71dbe0692755e89cc45eabcb..ab5d272860fe917e3212f6c6551c89f05935e6ef 100644
--- a/ee/spec/models/push_rule_spec.rb
+++ b/ee/spec/models/push_rule_spec.rb
@@ -41,7 +41,7 @@
end
describe '#branch_name_allowed?' do
- subject(:push_rule) { create(:push_rule, branch_name_regex: '\d+\-.*')}
+ subject(:push_rule) { create(:push_rule, branch_name_regex: '\d+\-.*') }
it 'checks branch against regex' do
expect(subject.branch_name_allowed?('123-feature')).to be true
@@ -90,7 +90,7 @@
end
describe '#commit_message_allowed?' do
- subject(:push_rule) { create(:push_rule, commit_message_regex: '^Signed-off-by')}
+ subject(:push_rule) { create(:push_rule, commit_message_regex: '^Signed-off-by') }
it 'uses multiline regex' do
commit_message = "Some git commit feature\n\nSigned-off-by: Someone"
@@ -100,7 +100,7 @@
end
describe '#commit_message_blocked?' do
- subject(:push_rule) { create(:push_rule, commit_message_negative_regex: 'commit')}
+ subject(:push_rule) { create(:push_rule, commit_message_negative_regex: 'commit') }
it 'uses multiline regex' do
commit_message = "Some git commit feature\n\nSigned-off-by: Someone"
diff --git a/ee/spec/models/requirements_management/test_report_spec.rb b/ee/spec/models/requirements_management/test_report_spec.rb
index 801f383462d7c1bea5ebdb597e0607e65abd0f87..5ad1082c0ecdd54fe6dd2b7456adfd58815df5c2 100644
--- a/ee/spec/models/requirements_management/test_report_spec.rb
+++ b/ee/spec/models/requirements_management/test_report_spec.rb
@@ -128,7 +128,7 @@
let_it_be(:user) { create(:user) }
let_it_be(:build_author) { create(:user) }
let_it_be(:build) { create(:ci_build, author: build_author) }
- let_it_be(:requirement_issue) { create(:requirement_issue)}
+ let_it_be(:requirement_issue) { create(:requirement_issue) }
let(:now) { Time.current }
diff --git a/ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb b/ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb
index 24b14a6500ab7aa9fcdbce339797807177c4a9f5..ebe7dd5d2dedcae44211b158f151e224b6b4afe5 100644
--- a/ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb
+++ b/ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb
@@ -46,7 +46,7 @@
end
context 'when there are no runnable schedules' do
- let!(:policy_rule_schedule) { }
+ let!(:policy_rule_schedule) {}
it 'returns an empty array' do
is_expected.to be_empty
diff --git a/ee/spec/models/vulnerabilities/feedback_spec.rb b/ee/spec/models/vulnerabilities/feedback_spec.rb
index 322eab250e4993307f923558aeb9fa428f581f57..309225094d3b7f6d4aa3670e2b3098ad1be8d314 100644
--- a/ee/spec/models/vulnerabilities/feedback_spec.rb
+++ b/ee/spec/models/vulnerabilities/feedback_spec.rb
@@ -129,7 +129,7 @@
end
it 'does not raise an error' do
- expect {subject}.not_to raise_error
+ expect { subject }.not_to raise_error
end
end
end
diff --git a/ee/spec/models/vulnerabilities/finding_spec.rb b/ee/spec/models/vulnerabilities/finding_spec.rb
index be8941e36c51cfadb9851d89447c8a2233610897..dddbe87ba3ec4108b178ff0c25abd2f75b51fc66 100644
--- a/ee/spec/models/vulnerabilities/finding_spec.rb
+++ b/ee/spec/models/vulnerabilities/finding_spec.rb
@@ -169,7 +169,7 @@
end
context 'without found record' do
- let(:param) { ::Enums::Vulnerability.report_types['container_scanning']}
+ let(:param) { ::Enums::Vulnerability.report_types['container_scanning'] }
it 'returns empty collection' do
is_expected.to be_empty
@@ -492,7 +492,7 @@
let(:vulnerability) { create(:vulnerability, findings: [finding]) }
context 'when there is issue link present' do
- let!(:issue_link) { create(:vulnerabilities_issue_link, vulnerability: vulnerability, issue: issue)}
+ let!(:issue_link) { create(:vulnerabilities_issue_link, vulnerability: vulnerability, issue: issue) }
it 'returns associated feedback' do
expect(finding.issue_feedback).to eq(issue_feedback)
@@ -1047,7 +1047,7 @@
let(:same_hash) { false }
let(:same_location) { false }
let(:create_scope_offset) { false }
- let(:same_scope_offset) { false}
+ let(:same_scope_offset) { false }
let(:create_signatures) do
signature1_hash = create(
diff --git a/spec/models/active_session_spec.rb b/spec/models/active_session_spec.rb
index 751d31ad95a747fd9dad0afecdb3676af204c542..5d316f7cff248678acaf2870082ad2778e73d959 100644
--- a/spec/models/active_session_spec.rb
+++ b/spec/models/active_session_spec.rb
@@ -175,7 +175,7 @@ def make_session(id)
expect(Gitlab::Redis::Sessions).to receive(:with).and_yield(redis)
sessions = %w[session-a session-b]
- mget_responses = sessions.map { |session| [Marshal.dump(session)]}
+ mget_responses = sessions.map { |session| [Marshal.dump(session)] }
expect(redis).to receive(:mget).twice.times.and_return(*mget_responses)
expect(ActiveSession.sessions_from_ids([1, 2])).to eql(sessions)
diff --git a/spec/models/aws/role_spec.rb b/spec/models/aws/role_spec.rb
index ee93c9d6fad8ddb1cf42c6d59212c9d092169a81..f23f18ab44fa2e6faaeea391a439eb2ef1b0deb2 100644
--- a/spec/models/aws/role_spec.rb
+++ b/spec/models/aws/role_spec.rb
@@ -31,7 +31,7 @@
end
context 'ARN is nil' do
- let(:role_arn) { }
+ let(:role_arn) {}
it { is_expected.to be_truthy }
end
diff --git a/spec/models/ci/build_dependencies_spec.rb b/spec/models/ci/build_dependencies_spec.rb
index 91048cae06419bdd1f2010bf685245b6d5c8182f..737348765d9c8f8d621c20409d9a3cf4f92c601b 100644
--- a/spec/models/ci/build_dependencies_spec.rb
+++ b/spec/models/ci/build_dependencies_spec.rb
@@ -76,8 +76,8 @@
end
describe 'jobs from specified dependencies' do
- let(:dependencies) { }
- let(:needs) { }
+ let(:dependencies) {}
+ let(:needs) {}
let!(:job) do
scheduling_type = needs.present? ? :dag : :stage
diff --git a/spec/models/ci/build_runner_session_spec.rb b/spec/models/ci/build_runner_session_spec.rb
index 601c6ad26f97bda13d3fb1c1137875254decc328..ed5ed456d7b8893b464efd4138a412e54fc52415 100644
--- a/spec/models/ci/build_runner_session_spec.rb
+++ b/spec/models/ci/build_runner_session_spec.rb
@@ -65,7 +65,7 @@
end
describe '#service_specification' do
- let(:service) { 'foo'}
+ let(:service) { 'foo' }
let(:port) { 80 }
let(:path) { 'path' }
let(:subprotocols) { nil }
diff --git a/spec/models/ci/build_spec.rb b/spec/models/ci/build_spec.rb
index 6f1865d8703496cf834b9a8d4a8b78314067ac09..c3ccd96ead501f091c97a431b6b493826c82e3da 100644
--- a/spec/models/ci/build_spec.rb
+++ b/spec/models/ci/build_spec.rb
@@ -1289,7 +1289,7 @@
let(:subject) { build.hide_secrets(data) }
context 'hide runners token' do
- let(:data) { "new #{project.runners_token} data"}
+ let(:data) { "new #{project.runners_token} data" }
it { is_expected.to match(/^new x+ data$/) }
@@ -1303,7 +1303,7 @@
end
context 'hide build token' do
- let(:data) { "new #{build.token} data"}
+ let(:data) { "new #{build.token} data" }
it { is_expected.to match(/^new x+ data$/) }
@@ -1709,7 +1709,7 @@
end
context 'with a dynamic value' do
- let(:namespace) { 'deploy-$CI_COMMIT_REF_NAME'}
+ let(:namespace) { 'deploy-$CI_COMMIT_REF_NAME' }
it { is_expected.to eq 'deploy-master' }
end
@@ -2643,7 +2643,7 @@
build.update_columns(token_encrypted: nil)
end
- it { is_expected.to be_nil}
+ it { is_expected.to be_nil }
end
end
@@ -3534,8 +3534,8 @@
context 'when gitlab-deploy-token does not exist for project' do
it 'does not include deploy token variables' do
- expect(subject.find { |v| v[:key] == 'CI_DEPLOY_USER'}).to be_nil
- expect(subject.find { |v| v[:key] == 'CI_DEPLOY_PASSWORD'}).to be_nil
+ expect(subject.find { |v| v[:key] == 'CI_DEPLOY_USER' }).to be_nil
+ expect(subject.find { |v| v[:key] == 'CI_DEPLOY_PASSWORD' }).to be_nil
end
context 'when gitlab-deploy-token exists for group' do
@@ -3553,8 +3553,8 @@
end
it 'does not include deploy token variables' do
- expect(subject.find { |v| v[:key] == 'CI_DEPLOY_USER'}).to be_nil
- expect(subject.find { |v| v[:key] == 'CI_DEPLOY_PASSWORD'}).to be_nil
+ expect(subject.find { |v| v[:key] == 'CI_DEPLOY_USER' }).to be_nil
+ expect(subject.find { |v| v[:key] == 'CI_DEPLOY_PASSWORD' }).to be_nil
end
end
end
@@ -3585,10 +3585,10 @@
context 'when harbor_integration does not exist' do
it 'does not include harbor variables' do
- expect(subject.find { |v| v[:key] == 'HARBOR_URL'}).to be_nil
- expect(subject.find { |v| v[:key] == 'HARBOR_PROJECT_NAME'}).to be_nil
- expect(subject.find { |v| v[:key] == 'HARBOR_USERNAME'}).to be_nil
- expect(subject.find { |v| v[:key] == 'HARBOR_PASSWORD'}).to be_nil
+ expect(subject.find { |v| v[:key] == 'HARBOR_URL' }).to be_nil
+ expect(subject.find { |v| v[:key] == 'HARBOR_PROJECT_NAME' }).to be_nil
+ expect(subject.find { |v| v[:key] == 'HARBOR_USERNAME' }).to be_nil
+ expect(subject.find { |v| v[:key] == 'HARBOR_PASSWORD' }).to be_nil
end
end
end
diff --git a/spec/models/ci/daily_build_group_report_result_spec.rb b/spec/models/ci/daily_build_group_report_result_spec.rb
index 43ba4c32477f5b85efe7c9b07d807da4491e4692..d0141a1469e3778689f927e29a9e37bb633c9e1f 100644
--- a/spec/models/ci/daily_build_group_report_result_spec.rb
+++ b/spec/models/ci/daily_build_group_report_result_spec.rb
@@ -3,7 +3,7 @@
require 'spec_helper'
RSpec.describe Ci::DailyBuildGroupReportResult do
- let(:daily_build_group_report_result) { build(:ci_daily_build_group_report_result)}
+ let(:daily_build_group_report_result) { build(:ci_daily_build_group_report_result) }
describe 'associations' do
it { is_expected.to belong_to(:last_pipeline) }
diff --git a/spec/models/ci/job_artifact_spec.rb b/spec/models/ci/job_artifact_spec.rb
index b9cac6c3f9963025c98835bdf9db6c0392f58e4a..516c18d42140eb4db85d5a6e687d88bfade38584 100644
--- a/spec/models/ci/job_artifact_spec.rb
+++ b/spec/models/ci/job_artifact_spec.rb
@@ -193,7 +193,7 @@
it { is_expected.to be_truthy }
context 'when the job does have archived trace' do
- let!(:artifact) { }
+ let!(:artifact) {}
it { is_expected.to be_falsy }
end
diff --git a/spec/models/ci/pipeline_schedule_spec.rb b/spec/models/ci/pipeline_schedule_spec.rb
index 3c295fb345be4613c7e8acf08f085a7aa3d89d98..b28b61e2b39717aeaba238aabaed65307b8b9485 100644
--- a/spec/models/ci/pipeline_schedule_spec.rb
+++ b/spec/models/ci/pipeline_schedule_spec.rb
@@ -73,7 +73,7 @@
end
context 'when there are no runnable schedules' do
- let!(:pipeline_schedule) { }
+ let!(:pipeline_schedule) {}
it 'returns an empty array' do
is_expected.to be_empty
diff --git a/spec/models/ci/pipeline_spec.rb b/spec/models/ci/pipeline_spec.rb
index 5713e322a8e865d976c45c401ed2f62853b39261..9880fbae77c2d601e50b36b1a6b48dfa779ec788 100644
--- a/spec/models/ci/pipeline_spec.rb
+++ b/spec/models/ci/pipeline_spec.rb
@@ -3652,7 +3652,7 @@ def stub_first_cancel_call_fails
end
context 'when pipeline is a triggered pipeline' do
- let!(:upstream) { create(:ci_pipeline, project: create(:project), upstream_of: pipeline)}
+ let!(:upstream) { create(:ci_pipeline, project: create(:project), upstream_of: pipeline) }
it 'returns self id' do
expect(subject).to contain_exactly(pipeline.id)
diff --git a/spec/models/ci/runner_spec.rb b/spec/models/ci/runner_spec.rb
index ec0bc900280f90ceb157deb23a839a46ad9624d1..a822e613860c13ea2bdef0cf474a97c5516d4fa4 100644
--- a/spec/models/ci/runner_spec.rb
+++ b/spec/models/ci/runner_spec.rb
@@ -489,7 +489,7 @@
let!(:runner3) { create(:ci_runner, :instance, contacted_at: 1.month.ago, created_at: 2.months.ago) }
let!(:runner4) { create(:ci_runner, :instance, contacted_at: 1.month.ago, created_at: 3.months.ago) }
- it { is_expected.to eq([runner1, runner3, runner4])}
+ it { is_expected.to eq([runner1, runner3, runner4]) }
end
describe '.active' do
@@ -866,7 +866,7 @@ def stub_redis_runner_contacted_at(value)
describe '#status' do
let(:runner) { build(:ci_runner, :instance, created_at: 4.months.ago) }
- let(:legacy_mode) { }
+ let(:legacy_mode) {}
subject { runner.status(legacy_mode) }
@@ -1795,7 +1795,7 @@ def does_db_update
end
context ':recommended' do
- let(:upgrade_status) { :recommended}
+ let(:upgrade_status) { :recommended }
it 'returns runners whose version is assigned :recommended' do
is_expected.to contain_exactly(runner_14_1_0)
diff --git a/spec/models/clusters/cluster_spec.rb b/spec/models/clusters/cluster_spec.rb
index 65ead01a2bdc0b9a0f22cfe143cb182328fcb3dd..73cd7bb907521e206a8bdf2a92acb27f18f3d697 100644
--- a/spec/models/clusters/cluster_spec.rb
+++ b/spec/models/clusters/cluster_spec.rb
@@ -1278,14 +1278,14 @@
context 'generic timeout' do
let(:connection_status) { { connection_status: :unreachable, connection_error: :http_error } }
- let(:error_message) { 'Timed out connecting to server'}
+ let(:error_message) { 'Timed out connecting to server' }
it { is_expected.to eq(**connection_status, **expected_nodes) }
end
context 'gateway timeout' do
let(:connection_status) { { connection_status: :unreachable, connection_error: :http_error } }
- let(:error_message) { '504 Gateway Timeout for GET https://kubernetes.example.com/api/v1'}
+ let(:error_message) { '504 Gateway Timeout for GET https://kubernetes.example.com/api/v1' }
it { is_expected.to eq(**connection_status, **expected_nodes) }
end
diff --git a/spec/models/commit_status_spec.rb b/spec/models/commit_status_spec.rb
index 3cccc41a892039647470871f07e7aa422183fec6..78d4d9de84efd0176a1c01700e137e34c0a68c7c 100644
--- a/spec/models/commit_status_spec.rb
+++ b/spec/models/commit_status_spec.rb
@@ -747,7 +747,7 @@ def create_status(**opts)
end
context 'when failure_reason is nil' do
- let(:reason) { }
+ let(:reason) {}
let(:failure_reason) { 'unknown_failure' }
it { is_expected.to be_unknown_failure }
diff --git a/spec/models/concerns/chronic_duration_attribute_spec.rb b/spec/models/concerns/chronic_duration_attribute_spec.rb
index 00e28e19bd522396d81f8b187d402ef4fb9bbc64..61b86455840bbbcbbc9cebe15d05a1094be09e47 100644
--- a/spec/models/concerns/chronic_duration_attribute_spec.rb
+++ b/spec/models/concerns/chronic_duration_attribute_spec.rb
@@ -95,8 +95,8 @@
RSpec.describe 'ChronicDurationAttribute' do
context 'when default value is not set' do
- let(:source_field) {:maximum_timeout}
- let(:virtual_field) {:maximum_timeout_human_readable}
+ let(:source_field) { :maximum_timeout }
+ let(:virtual_field) { :maximum_timeout_human_readable }
let(:default_value) { nil }
subject { create(:ci_runner) }
@@ -106,8 +106,8 @@
end
context 'when default value is set' do
- let(:source_field) {:build_timeout}
- let(:virtual_field) {:build_timeout_human_readable}
+ let(:source_field) { :build_timeout }
+ let(:virtual_field) { :build_timeout_human_readable }
let(:default_value) { 3600 }
subject { create(:project) }
@@ -118,8 +118,8 @@
end
RSpec.describe 'ChronicDurationAttribute - reader' do
- let(:source_field) {:timeout}
- let(:virtual_field) {:timeout_human_readable}
+ let(:source_field) { :timeout }
+ let(:virtual_field) { :timeout_human_readable }
subject { create(:ci_build).ensure_metadata }
diff --git a/spec/models/concerns/counter_attribute_spec.rb b/spec/models/concerns/counter_attribute_spec.rb
index a19fbae3cfb1a9bc2ea3f64f2eaa62fd2458940d..8d32ef14f47984e300af7e83dbeaab29c3114b12 100644
--- a/spec/models/concerns/counter_attribute_spec.rb
+++ b/spec/models/concerns/counter_attribute_spec.rb
@@ -13,7 +13,7 @@
end
describe 'after_flush callbacks' do
- let(:attribute) { model.class.counter_attributes.first}
+ let(:attribute) { model.class.counter_attributes.first }
subject { model.flush_increments_to_database!(attribute) }
diff --git a/spec/models/concerns/nullify_if_blank_spec.rb b/spec/models/concerns/nullify_if_blank_spec.rb
index 2d1bdba39ddccc43b7f9ef03388790c0a269581d..b0e229f4c918d0334f09c937c8681dcb4d444806 100644
--- a/spec/models/concerns/nullify_if_blank_spec.rb
+++ b/spec/models/concerns/nullify_if_blank_spec.rb
@@ -31,7 +31,7 @@
context 'attribute is nil' do
let(:name) { nil }
- it { is_expected.to be_nil}
+ it { is_expected.to be_nil }
end
context 'attribute is not blank' do
diff --git a/spec/models/concerns/reactive_caching_spec.rb b/spec/models/concerns/reactive_caching_spec.rb
index 5468699f9ddf0bf6ce89a22550474f14d566b036..cb9bb676ede51f9ae511a4156cfbd535cf090999 100644
--- a/spec/models/concerns/reactive_caching_spec.rb
+++ b/spec/models/concerns/reactive_caching_spec.rb
@@ -320,7 +320,7 @@ def self.from_cache(*args); end
stub_reactive_cache(instance, "preexisting")
end
- let(:calculation) { -> { raise "foo"} }
+ let(:calculation) { -> { raise "foo" } }
it 'leaves the cache untouched' do
expect { go! }.to raise_error("foo")
diff --git a/spec/models/concerns/token_authenticatable_spec.rb b/spec/models/concerns/token_authenticatable_spec.rb
index 338742fb4d44a58ccfbea9082d09f60d9073cd61..3f6bbe795cc64a2b3f7e83d23be2a49edade4ff8 100644
--- a/spec/models/concerns/token_authenticatable_spec.rb
+++ b/spec/models/concerns/token_authenticatable_spec.rb
@@ -102,7 +102,7 @@
subject { described_class.send(:add_authentication_token_field, :runners_registration_token) }
it 'raises error' do
- expect {subject}.to raise_error(ArgumentError)
+ expect { subject }.to raise_error(ArgumentError)
end
end
end
diff --git a/spec/models/container_expiration_policy_spec.rb b/spec/models/container_expiration_policy_spec.rb
index 191913ed454781e7cc0242f9bb820a0e141c50e4..b88eddf19dcbfacdc201bf59505bcfca0aeb82fe 100644
--- a/spec/models/container_expiration_policy_spec.rb
+++ b/spec/models/container_expiration_policy_spec.rb
@@ -131,7 +131,7 @@
end
context 'when there are no runnable schedules' do
- let!(:policy) { }
+ let!(:policy) {}
it 'returns an empty array' do
is_expected.to be_empty
diff --git a/spec/models/container_repository_spec.rb b/spec/models/container_repository_spec.rb
index e35788b1848447e3b86829d35ecdc2a4411ccc60..d85edf5595bf614107caebc1e4aa751c3d05380f 100644
--- a/spec/models/container_repository_spec.rb
+++ b/spec/models/container_repository_spec.rb
@@ -1195,7 +1195,7 @@ def repository_creation_race(path)
described_class::MIGRATION_STATES.each do |state|
context "when in #{state} migration_state" do
- let(:container_repository) { create(:container_repository, state.to_sym)}
+ let(:container_repository) { create(:container_repository, state.to_sym) }
it { is_expected.to eq(state == 'importing' || state == 'pre_importing') }
end
@@ -1207,7 +1207,7 @@ def repository_creation_race(path)
described_class::MIGRATION_STATES.each do |state|
context "when in #{state} migration_state" do
- let(:container_repository) { create(:container_repository, state.to_sym)}
+ let(:container_repository) { create(:container_repository, state.to_sym) }
it { is_expected.to eq(state == 'importing') }
end
@@ -1219,7 +1219,7 @@ def repository_creation_race(path)
described_class::MIGRATION_STATES.each do |state|
context "when in #{state} migration_state" do
- let(:container_repository) { create(:container_repository, state.to_sym)}
+ let(:container_repository) { create(:container_repository, state.to_sym) }
it { is_expected.to eq(state == 'pre_importing') }
end
diff --git a/spec/models/environment_spec.rb b/spec/models/environment_spec.rb
index 16e56f92b6ac8d3574597feaf2355a689cef1b8e..573e69799246020dc5e15fd7908def73fdb5f8e9 100644
--- a/spec/models/environment_spec.rb
+++ b/spec/models/environment_spec.rb
@@ -236,7 +236,7 @@
end
context 'when query is nil' do
- let(:query) { }
+ let(:query) {}
it 'raises an error' do
expect { subject }.to raise_error(NoMethodError)
@@ -849,8 +849,8 @@
describe '#actions_for' do
let(:deployment) { create(:deployment, :success, environment: environment) }
let(:pipeline) { deployment.deployable.pipeline }
- let!(:review_action) { create(:ci_build, :manual, name: 'review-apps', pipeline: pipeline, environment: 'review/$CI_COMMIT_REF_NAME' )}
- let!(:production_action) { create(:ci_build, :manual, name: 'production', pipeline: pipeline, environment: 'production' )}
+ let!(:review_action) { create(:ci_build, :manual, name: 'review-apps', pipeline: pipeline, environment: 'review/$CI_COMMIT_REF_NAME' ) }
+ let!(:production_action) { create(:ci_build, :manual, name: 'production', pipeline: pipeline, environment: 'production' ) }
it 'returns a list of actions with matching environment' do
expect(environment.actions_for('review/master')).to contain_exactly(review_action)
diff --git a/spec/models/event_spec.rb b/spec/models/event_spec.rb
index 2c1bbfcb35f26986680e4ec8a01a11716bd4d2cc..e94e3ef84a45ed0afdf99434f3ab6feaa4fbb22b 100644
--- a/spec/models/event_spec.rb
+++ b/spec/models/event_spec.rb
@@ -947,7 +947,7 @@ def visible_to_all_except(*roles)
let_it_be(:user) { create(:user) }
let_it_be(:note_on_project_snippet) { create(:note_on_project_snippet, author: user) }
let_it_be(:note_on_personal_snippet) { create(:note_on_personal_snippet, author: user) }
- let_it_be(:other_note) { create(:note_on_issue, author: user)}
+ let_it_be(:other_note) { create(:note_on_issue, author: user) }
let_it_be(:personal_snippet_event) { create(:event, :commented, project: nil, target: note_on_personal_snippet, author: user) }
let_it_be(:project_snippet_event) { create(:event, :commented, project: note_on_project_snippet.project, target: note_on_project_snippet, author: user) }
let_it_be(:other_event) { create(:event, :commented, project: other_note.project, target: other_note, author: user) }
diff --git a/spec/models/group_spec.rb b/spec/models/group_spec.rb
index 83ec4a5585d065f50b3ae0cd812336c34fe0c46f..5b0466c46a2802be91505d6f45d1934609bc8341 100644
--- a/spec/models/group_spec.rb
+++ b/spec/models/group_spec.rb
@@ -359,7 +359,7 @@
context 'parent is updated' do
let(:new_parent) { create(:group) }
- subject {group.update!(parent: new_parent, name: 'new name') }
+ subject { group.update!(parent: new_parent, name: 'new name') }
it_behaves_like 'update on column', :traversal_ids
end
@@ -2848,7 +2848,7 @@ def define_cache_expectations(cache_key)
end
context 'for subgroup project' do
- let_it_be(:subgroup) { create(:group, :private, parent: group)}
+ let_it_be(:subgroup) { create(:group, :private, parent: group) }
let_it_be(:project) { create(:project, group: subgroup, service_desk_enabled: true) }
it { is_expected.to eq(true) }
diff --git a/spec/models/integrations/chat_message/wiki_page_message_spec.rb b/spec/models/integrations/chat_message/wiki_page_message_spec.rb
index 4aa96c7e03153afdbc87f815cefd0dd82e51ad71..16659311c5235d2e87fe1a4cdb670c5630dbe514 100644
--- a/spec/models/integrations/chat_message/wiki_page_message_spec.rb
+++ b/spec/models/integrations/chat_message/wiki_page_message_spec.rb
@@ -9,7 +9,7 @@
let(:username) { 'test.user' }
let(:avatar_url) { 'http://someavatar.com' }
let(:project_name) { 'project_name' }
- let(:project_url) {'http://somewhere.com' }
+ let(:project_url) { 'http://somewhere.com' }
let(:url) { 'http://url.com' }
let(:diff_url) { 'http://url.com/diff?version_id=1234' }
let(:wiki_page_title) { 'Wiki page title' }
diff --git a/spec/models/integrations/harbor_spec.rb b/spec/models/integrations/harbor_spec.rb
index 2671f0358894a02efbc18137b9b6a072f6dad202..3952495119aade5381eb00c9d95eeb66920f0e97 100644
--- a/spec/models/integrations/harbor_spec.rb
+++ b/spec/models/integrations/harbor_spec.rb
@@ -24,7 +24,7 @@
it { is_expected.not_to allow_value('https://192.168.1.1').for(:url) }
it { is_expected.not_to allow_value('https://127.0.0.1').for(:url) }
- it { is_expected.to allow_value('https://demo.goharbor.io').for(:url)}
+ it { is_expected.to allow_value('https://demo.goharbor.io').for(:url) }
end
describe '#fields' do
diff --git a/spec/models/issue_spec.rb b/spec/models/issue_spec.rb
index 8079854fbfe24ac89f2f4a5429816fdbbb096550..a28b91d463f295cf15eb67b55b1c9a90f3cb50b2 100644
--- a/spec/models/issue_spec.rb
+++ b/spec/models/issue_spec.rb
@@ -591,7 +591,7 @@
let_it_be(:authorized_issue_a) { create(:issue, project: authorized_project) }
let_it_be(:authorized_issue_b) { create(:issue, project: authorized_project) }
let_it_be(:authorized_issue_c) { create(:issue, project: authorized_project2) }
- let_it_be(:authorized_incident_a) { create(:incident, project: authorized_project )}
+ let_it_be(:authorized_incident_a) { create(:incident, project: authorized_project ) }
let_it_be(:unauthorized_issue) { create(:issue, project: unauthorized_project) }
@@ -648,7 +648,7 @@
subject { issue.can_move?(user) }
context 'user is not a member of project issue belongs to' do
- it { is_expected.to eq false}
+ it { is_expected.to eq false }
end
context 'user is reporter in project issue belongs to' do
@@ -1172,7 +1172,7 @@
end
context 'when issue is moved to a private project' do
- let(:private_project) { build(:project, :private)}
+ let(:private_project) { build(:project, :private) }
before do
issue.update!(project: private_project) # move issue to private project
diff --git a/spec/models/jira_import_state_spec.rb b/spec/models/jira_import_state_spec.rb
index a272d001429a854ff58161a03eabb3000c988d3c..95e9594f8856d28ba240b291d6a29e35ced02463 100644
--- a/spec/models/jira_import_state_spec.rb
+++ b/spec/models/jira_import_state_spec.rb
@@ -25,25 +25,25 @@
let(:project) { create(:project) }
context 'when project has an initial jira_import' do
- let!(:jira_import) { create(:jira_import_state, project: project)}
+ let!(:jira_import) { create(:jira_import_state, project: project) }
it_behaves_like 'multiple running imports not allowed'
end
context 'when project has a scheduled jira_import' do
- let!(:jira_import) { create(:jira_import_state, :scheduled, project: project)}
+ let!(:jira_import) { create(:jira_import_state, :scheduled, project: project) }
it_behaves_like 'multiple running imports not allowed'
end
context 'when project has a started jira_import' do
- let!(:jira_import) { create(:jira_import_state, :started, project: project)}
+ let!(:jira_import) { create(:jira_import_state, :started, project: project) }
it_behaves_like 'multiple running imports not allowed'
end
context 'when project has a failed jira_import' do
- let!(:jira_import) { create(:jira_import_state, :failed, project: project)}
+ let!(:jira_import) { create(:jira_import_state, :failed, project: project) }
it 'returns valid' do
new_import = build(:jira_import_state, project: project)
@@ -54,7 +54,7 @@
end
context 'when project has a finished jira_import' do
- let!(:jira_import) { create(:jira_import_state, :finished, project: project)}
+ let!(:jira_import) { create(:jira_import_state, :finished, project: project) }
it 'returns valid' do
new_import = build(:jira_import_state, project: project)
@@ -83,40 +83,40 @@
let(:project) { create(:project) }
context 'when jira import is in initial state' do
- let!(:jira_import) { build(:jira_import_state, project: project)}
+ let!(:jira_import) { build(:jira_import_state, project: project) }
it_behaves_like 'can transition', [:schedule, :do_fail]
it_behaves_like 'cannot transition', [:start, :finish]
end
context 'when jira import is in scheduled state' do
- let!(:jira_import) { build(:jira_import_state, :scheduled, project: project)}
+ let!(:jira_import) { build(:jira_import_state, :scheduled, project: project) }
it_behaves_like 'can transition', [:start, :do_fail]
it_behaves_like 'cannot transition', [:finish]
end
context 'when jira import is in started state' do
- let!(:jira_import) { build(:jira_import_state, :started, project: project)}
+ let!(:jira_import) { build(:jira_import_state, :started, project: project) }
it_behaves_like 'can transition', [:finish, :do_fail]
it_behaves_like 'cannot transition', [:schedule]
end
context 'when jira import is in failed state' do
- let!(:jira_import) { build(:jira_import_state, :failed, project: project)}
+ let!(:jira_import) { build(:jira_import_state, :failed, project: project) }
it_behaves_like 'cannot transition', [:schedule, :finish, :do_fail]
end
context 'when jira import is in finished state' do
- let!(:jira_import) { build(:jira_import_state, :finished, project: project)}
+ let!(:jira_import) { build(:jira_import_state, :finished, project: project) }
it_behaves_like 'cannot transition', [:schedule, :do_fail, :start]
end
context 'after transition to scheduled' do
- let!(:jira_import) { build(:jira_import_state, project: project)}
+ let!(:jira_import) { build(:jira_import_state, project: project) }
it 'triggers the import job' do
expect(Gitlab::JiraImport::Stage::StartImportWorker).to receive(:perform_async).and_return('some-job-id')
@@ -129,7 +129,7 @@
end
context 'after transition to finished' do
- let!(:jira_import) { build(:jira_import_state, :started, jid: 'some-other-jid', project: project)}
+ let!(:jira_import) { build(:jira_import_state, :started, jid: 'some-other-jid', project: project) }
subject { jira_import.finish }
@@ -172,7 +172,7 @@
end
context 'when jira import has no error_message' do
- let(:jira_import) { build(:jira_import_state, project: project)}
+ let(:jira_import) { build(:jira_import_state, project: project) }
it 'does not run the callback', :aggregate_failures do
expect { jira_import.save! }.to change { JiraImportState.count }.by(1)
@@ -181,7 +181,7 @@
end
context 'when jira import error_message does not exceed the limit' do
- let(:jira_import) { build(:jira_import_state, project: project, error_message: 'error')}
+ let(:jira_import) { build(:jira_import_state, project: project, error_message: 'error') }
it 'does not run the callback', :aggregate_failures do
expect { jira_import.save! }.to change { JiraImportState.count }.by(1)
@@ -190,7 +190,7 @@
end
context 'when error_message exceeds limit' do
- let(:jira_import) { build(:jira_import_state, project: project, error_message: 'error message longer than the limit')}
+ let(:jira_import) { build(:jira_import_state, project: project, error_message: 'error message longer than the limit') }
it 'truncates error_message to the limit', :aggregate_failures do
expect { jira_import.save! }.to change { JiraImportState.count }.by(1)
diff --git a/spec/models/merge_request_spec.rb b/spec/models/merge_request_spec.rb
index d13a725a44b70ac8a8fcd558194b5a87e667cb08..bd35b5140965199ce81a4960b66f86894d513d22 100644
--- a/spec/models/merge_request_spec.rb
+++ b/spec/models/merge_request_spec.rb
@@ -114,10 +114,10 @@
let_it_be(:user1) { create(:user) }
let_it_be(:user2) { create(:user) }
- let_it_be(:merge_request1) { create(:merge_request, :unique_branches, reviewers: [user1])}
- let_it_be(:merge_request2) { create(:merge_request, :unique_branches, reviewers: [user2])}
- let_it_be(:merge_request3) { create(:merge_request, :unique_branches, reviewers: [])}
- let_it_be(:merge_request4) { create(:merge_request, :draft_merge_request)}
+ let_it_be(:merge_request1) { create(:merge_request, :unique_branches, reviewers: [user1]) }
+ let_it_be(:merge_request2) { create(:merge_request, :unique_branches, reviewers: [user2]) }
+ let_it_be(:merge_request3) { create(:merge_request, :unique_branches, reviewers: []) }
+ let_it_be(:merge_request4) { create(:merge_request, :draft_merge_request) }
describe '.review_requested' do
it 'returns MRs that have any review requests' do
@@ -145,8 +145,8 @@
end
describe '.attention' do
- let_it_be(:merge_request5) { create(:merge_request, :unique_branches, assignees: [user2])}
- let_it_be(:merge_request6) { create(:merge_request, :unique_branches, assignees: [user2])}
+ let_it_be(:merge_request5) { create(:merge_request, :unique_branches, assignees: [user2]) }
+ let_it_be(:merge_request6) { create(:merge_request, :unique_branches, assignees: [user2]) }
before do
assignee = merge_request6.find_assignee(user2)
@@ -2056,7 +2056,7 @@ def set_compare(merge_request)
context 'when failed to find an actual head pipeline' do
before do
- allow(merge_request).to receive(:find_actual_head_pipeline) { }
+ allow(merge_request).to receive(:find_actual_head_pipeline) {}
end
it 'does not update the current head pipeline' do
diff --git a/spec/models/namespace/root_storage_statistics_spec.rb b/spec/models/namespace/root_storage_statistics_spec.rb
index d2ee0b40ed669066aa05062a934539ca93006742..14ac08b545adb263a1030a1cbf7295dd41df42a0 100644
--- a/spec/models/namespace/root_storage_statistics_spec.rb
+++ b/spec/models/namespace/root_storage_statistics_spec.rb
@@ -100,8 +100,8 @@
it_behaves_like 'does not include personal snippets'
context 'with subgroups' do
- let(:subgroup1) { create(:group, parent: namespace)}
- let(:subgroup2) { create(:group, parent: subgroup1)}
+ let(:subgroup1) { create(:group, parent: namespace) }
+ let(:subgroup2) { create(:group, parent: subgroup1) }
let(:project1) { create(:project, namespace: subgroup1) }
let(:project2) { create(:project, namespace: subgroup2) }
diff --git a/spec/models/namespace_spec.rb b/spec/models/namespace_spec.rb
index 695cd98fa29e8caaa932b871da46fe6213d3b8dd..2a5794b31d2336ebcbd8a92567776ad7ad7456d1 100644
--- a/spec/models/namespace_spec.rb
+++ b/spec/models/namespace_spec.rb
@@ -1548,7 +1548,7 @@ def expect_project_directories_at(namespace_path, with_pages: true)
describe '#share_with_group_lock with subgroups' do
context 'when creating a subgroup' do
- let(:subgroup) { create(:group, parent: root_group )}
+ let(:subgroup) { create(:group, parent: root_group ) }
context 'under a parent with "Share with group lock" enabled' do
let(:root_group) { create(:group, share_with_group_lock: true) }
@@ -1569,7 +1569,7 @@ def expect_project_directories_at(namespace_path, with_pages: true)
context 'when enabling the parent group "Share with group lock"' do
let(:root_group) { create(:group) }
- let!(:subgroup) { create(:group, parent: root_group )}
+ let!(:subgroup) { create(:group, parent: root_group ) }
it 'the subgroup "Share with group lock" becomes enabled' do
root_group.update!(share_with_group_lock: true)
@@ -1582,7 +1582,7 @@ def expect_project_directories_at(namespace_path, with_pages: true)
let(:root_group) { create(:group, share_with_group_lock: true) }
context 'and the subgroup "Share with group lock" is enabled' do
- let(:subgroup) { create(:group, parent: root_group, share_with_group_lock: true )}
+ let(:subgroup) { create(:group, parent: root_group, share_with_group_lock: true ) }
it 'the subgroup "Share with group lock" does not change' do
root_group.update!(share_with_group_lock: false)
@@ -1592,7 +1592,7 @@ def expect_project_directories_at(namespace_path, with_pages: true)
end
context 'but the subgroup "Share with group lock" is disabled' do
- let(:subgroup) { create(:group, parent: root_group )}
+ let(:subgroup) { create(:group, parent: root_group ) }
it 'the subgroup "Share with group lock" does not change' do
root_group.update!(share_with_group_lock: false)
@@ -1607,7 +1607,7 @@ def expect_project_directories_at(namespace_path, with_pages: true)
let(:root_group) { create(:group, share_with_group_lock: true) }
context 'when the subgroup "Share with group lock" is enabled' do
- let(:subgroup) { create(:group, share_with_group_lock: true )}
+ let(:subgroup) { create(:group, share_with_group_lock: true ) }
it 'the subgroup "Share with group lock" does not change' do
subgroup.parent = root_group
@@ -1618,7 +1618,7 @@ def expect_project_directories_at(namespace_path, with_pages: true)
end
context 'when the subgroup "Share with group lock" is disabled' do
- let(:subgroup) { create(:group)}
+ let(:subgroup) { create(:group) }
it 'the subgroup "Share with group lock" becomes enabled' do
subgroup.parent = root_group
@@ -1633,7 +1633,7 @@ def expect_project_directories_at(namespace_path, with_pages: true)
let(:root_group) { create(:group) }
context 'when the subgroup "Share with group lock" is enabled' do
- let(:subgroup) { create(:group, share_with_group_lock: true )}
+ let(:subgroup) { create(:group, share_with_group_lock: true ) }
it 'the subgroup "Share with group lock" does not change' do
subgroup.parent = root_group
@@ -1644,7 +1644,7 @@ def expect_project_directories_at(namespace_path, with_pages: true)
end
context 'when the subgroup "Share with group lock" is disabled' do
- let(:subgroup) { create(:group)}
+ let(:subgroup) { create(:group) }
it 'the subgroup "Share with group lock" does not change' do
subgroup.parent = root_group
@@ -2019,7 +2019,7 @@ def expect_project_directories_at(namespace_path, with_pages: true)
end
with_them do
- let(:namespace) { build(:namespace, shared_runners_enabled: shared_runners_enabled, allow_descendants_override_disabled_shared_runners: allow_descendants_override_disabled_shared_runners)}
+ let(:namespace) { build(:namespace, shared_runners_enabled: shared_runners_enabled, allow_descendants_override_disabled_shared_runners: allow_descendants_override_disabled_shared_runners) }
it 'returns the result' do
expect(namespace.shared_runners_setting).to eq(shared_runners_setting)
@@ -2043,7 +2043,7 @@ def expect_project_directories_at(namespace_path, with_pages: true)
end
with_them do
- let(:namespace) { build(:namespace, shared_runners_enabled: shared_runners_enabled, allow_descendants_override_disabled_shared_runners: allow_descendants_override_disabled_shared_runners)}
+ let(:namespace) { build(:namespace, shared_runners_enabled: shared_runners_enabled, allow_descendants_override_disabled_shared_runners: allow_descendants_override_disabled_shared_runners) }
it 'returns the result' do
expect(namespace.shared_runners_setting_higher_than?(other_setting)).to eq(result)
diff --git a/spec/models/note_spec.rb b/spec/models/note_spec.rb
index fc6f7832c2c639d370eba6c6acc2f90ab95548a5..b18adc9813215fef8c290b47bccc11b0eec284d4 100644
--- a/spec/models/note_spec.rb
+++ b/spec/models/note_spec.rb
@@ -823,14 +823,14 @@ def retrieve_participants
end
context 'with :label action' do
- let!(:metadata) {create(:system_note_metadata, note: note, action: :label)}
+ let!(:metadata) { create(:system_note_metadata, note: note, action: :label) }
it_behaves_like 'system_note_metadata includes note action'
it { expect(note.system_note_with_references?).to be_falsy }
context 'with cross reference label note' do
- let(:label) { create(:label, project: issue.project)}
+ let(:label) { create(:label, project: issue.project) }
let(:note) { create(:system_note, note: "added #{label.to_reference} label", noteable: issue, project: issue.project) }
it { expect(note.system_note_with_references?).to be_truthy }
@@ -838,14 +838,14 @@ def retrieve_participants
end
context 'with :milestone action' do
- let!(:metadata) {create(:system_note_metadata, note: note, action: :milestone)}
+ let!(:metadata) { create(:system_note_metadata, note: note, action: :milestone) }
it_behaves_like 'system_note_metadata includes note action'
it { expect(note.system_note_with_references?).to be_falsy }
context 'with cross reference milestone note' do
- let(:milestone) { create(:milestone, project: issue.project)}
+ let(:milestone) { create(:milestone, project: issue.project) }
let(:note) { create(:system_note, note: "added #{milestone.to_reference} milestone", noteable: issue, project: issue.project) }
it { expect(note.system_note_with_references?).to be_truthy }
@@ -1130,7 +1130,7 @@ def retrieve_participants
end
describe '#cache_markdown_field' do
- let(:html) { '<p>some html</p>'}
+ let(:html) { '<p>some html</p>' }
before do
allow(Banzai::Renderer).to receive(:cacheless_render_field).and_call_original
diff --git a/spec/models/onboarding_progress_spec.rb b/spec/models/onboarding_progress_spec.rb
index 80a39404d10741c6d3da57c1ab642acbb19fb970..9688dd01c719bd8a326b8774cb452550ff65147e 100644
--- a/spec/models/onboarding_progress_spec.rb
+++ b/spec/models/onboarding_progress_spec.rb
@@ -12,7 +12,7 @@
describe 'validations' do
describe 'namespace_is_root_namespace' do
- subject(:onboarding_progress) { build(:onboarding_progress, namespace: namespace)}
+ subject(:onboarding_progress) { build(:onboarding_progress, namespace: namespace) }
context 'when associated namespace is root' do
it { is_expected.to be_valid }
diff --git a/spec/models/packages/conan/metadatum_spec.rb b/spec/models/packages/conan/metadatum_spec.rb
index d00723e8e431a0f0dc6cf12ed15a17664e047d64..92c8b1266395f61318b2a65728a58afe8443ccb4 100644
--- a/spec/models/packages/conan/metadatum_spec.rb
+++ b/spec/models/packages/conan/metadatum_spec.rb
@@ -10,7 +10,7 @@
end
describe 'validations' do
- let(:fifty_one_characters) { 'f_a' * 17}
+ let(:fifty_one_characters) { 'f_a' * 17 }
it { is_expected.to validate_presence_of(:package) }
it { is_expected.to validate_presence_of(:package_username) }
diff --git a/spec/models/packages/package_file_spec.rb b/spec/models/packages/package_file_spec.rb
index 82f5b44f38f882da6bd8f8b7d23370eb65e9a76a..9554fc3bb1bb974df2295f519544a50ea06c4971 100644
--- a/spec/models/packages/package_file_spec.rb
+++ b/spec/models/packages/package_file_spec.rb
@@ -126,7 +126,7 @@
describe '.with_conan_package_reference' do
let_it_be(:non_matching_package_file) { create(:package_file, :nuget) }
let_it_be(:metadatum) { create(:conan_file_metadatum, :package_file) }
- let_it_be(:reference) { metadatum.conan_package_reference}
+ let_it_be(:reference) { metadatum.conan_package_reference }
it 'returns matching packages' do
expect(described_class.with_conan_package_reference(reference))
@@ -150,8 +150,8 @@
context 'Debian scopes' do
let_it_be(:debian_changes) { debian_package.package_files.last }
- let_it_be(:debian_deb) { create(:debian_package_file, package: debian_package)}
- let_it_be(:debian_udeb) { create(:debian_package_file, :udeb, package: debian_package)}
+ let_it_be(:debian_deb) { create(:debian_package_file, package: debian_package) }
+ let_it_be(:debian_udeb) { create(:debian_package_file, :udeb, package: debian_package) }
let_it_be(:debian_contrib) do
create(:debian_package_file, package: debian_package).tap do |pf|
diff --git a/spec/models/packages/package_spec.rb b/spec/models/packages/package_spec.rb
index 06f02f021cf56d880a0d080f2b8bff1811434047..526c57d08b0a36c749e3943406ecc1bd08ee79d3 100644
--- a/spec/models/packages/package_spec.rb
+++ b/spec/models/packages/package_spec.rb
@@ -131,7 +131,7 @@
context 'conan package' do
subject { build_stubbed(:conan_package) }
- let(:fifty_one_characters) {'f_b' * 17}
+ let(:fifty_one_characters) { 'f_b' * 17 }
it { is_expected.to allow_value('foo+bar').for(:name) }
it { is_expected.to allow_value('foo_bar').for(:name) }
@@ -243,7 +243,7 @@
context 'conan package' do
subject { build_stubbed(:conan_package) }
- let(:fifty_one_characters) {'1.2' * 17}
+ let(:fifty_one_characters) { '1.2' * 17 }
it { is_expected.to allow_value('1.2').for(:version) }
it { is_expected.to allow_value('1.2.3-beta').for(:version) }
@@ -441,7 +441,7 @@
context 'npm package' do
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, namespace: group) }
- let_it_be(:second_project) { create(:project, namespace: group)}
+ let_it_be(:second_project) { create(:project, namespace: group) }
let(:package) { build(:npm_package, project: project, name: name) }
diff --git a/spec/models/postgresql/replication_slot_spec.rb b/spec/models/postgresql/replication_slot_spec.rb
index 63a19541ab5e18f5da91228cf22528b7cdddfe2c..35c166ab0640a620293aa8c665b35421517c634d 100644
--- a/spec/models/postgresql/replication_slot_spec.rb
+++ b/spec/models/postgresql/replication_slot_spec.rb
@@ -116,7 +116,7 @@
describe '#slots_retained_bytes' do
it 'returns the number of retained bytes' do
- slot = described_class.slots_retained_bytes.find {|x| x['slot_name'] == 'test_slot' }
+ slot = described_class.slots_retained_bytes.find { |x| x['slot_name'] == 'test_slot' }
expect(slot).not_to be_nil
expect(slot['retained_bytes']).to be_nil
diff --git a/spec/models/preloaders/labels_preloader_spec.rb b/spec/models/preloaders/labels_preloader_spec.rb
index 94de00bb94cea739085e8b4579e092caed2f9a51..86e64d114c76881aacfaeb91a659fbc9656bbe31 100644
--- a/spec/models/preloaders/labels_preloader_spec.rb
+++ b/spec/models/preloaders/labels_preloader_spec.rb
@@ -6,7 +6,7 @@
let_it_be(:user) { create(:user) }
shared_examples 'an efficient database query' do
- let(:subscriptions) { labels.each { |l| create(:subscription, subscribable: l, project: l.project, user: user) }}
+ let(:subscriptions) { labels.each { |l| create(:subscription, subscribable: l, project: l.project, user: user) } }
it 'does not make n+1 queries' do
first_label = labels_with_preloaded_data.first
diff --git a/spec/models/preloaders/user_max_access_level_in_groups_preloader_spec.rb b/spec/models/preloaders/user_max_access_level_in_groups_preloader_spec.rb
index 2060e6cd44a801f7d9850436885cca1875703dd2..5e2aaa8b4566d72061aea7c855ce4dfa273fad76 100644
--- a/spec/models/preloaders/user_max_access_level_in_groups_preloader_spec.rb
+++ b/spec/models/preloaders/user_max_access_level_in_groups_preloader_spec.rb
@@ -29,7 +29,7 @@
context 'when the preloader is used', :request_store do
context 'when user has indirect access to groups' do
- let_it_be(:child_maintainer) { create(:group, :private, parent: group1).tap {|g| g.add_maintainer(user)} }
+ let_it_be(:child_maintainer) { create(:group, :private, parent: group1).tap { |g| g.add_maintainer(user) } }
let_it_be(:child_indirect_access) { create(:group, :private, parent: group1) }
let(:groups) { [group1, group2, group3, child_maintainer, child_indirect_access] }
diff --git a/spec/models/project_spec.rb b/spec/models/project_spec.rb
index 7870326c29a749aaf9cf94a2975382083c5a91bd..2525b167d085f3037d46555a87fd2afb00c3d681 100644
--- a/spec/models/project_spec.rb
+++ b/spec/models/project_spec.rb
@@ -7473,7 +7473,7 @@ def has_external_wiki
end
with_them do
- it { is_expected.to eq expected_result}
+ it { is_expected.to eq expected_result }
end
end
@@ -7490,7 +7490,7 @@ def has_external_wiki
end
with_them do
- it { is_expected.to eq expected_result}
+ it { is_expected.to eq expected_result }
end
context 'for a different package type' do
@@ -7513,7 +7513,7 @@ def has_external_wiki
end
with_them do
- it { is_expected.to eq expected_result}
+ it { is_expected.to eq expected_result }
end
end
end
@@ -8435,7 +8435,7 @@ def has_external_wiki
expect do
project.destroy_deployment_by_id(project.deployments.first.id)
- end.to change {project.deployments.count }.by(-1)
+ end.to change { project.deployments.count }.by(-1)
expect(project.deployments).to match_array([old_deployment])
end
diff --git a/spec/models/release_spec.rb b/spec/models/release_spec.rb
index 83d7596ff517f5e7e83caf8a24cf991fd31b0c1e..180a76ff59304e5396c06127d01703abf5251270 100644
--- a/spec/models/release_spec.rb
+++ b/spec/models/release_spec.rb
@@ -233,6 +233,6 @@
let_it_be(:milestone_2) { create(:milestone, project: project, title: 'Milestone 2') }
let_it_be(:release) { create(:release, project: project, milestones: [milestone_1, milestone_2]) }
- it { expect(release.milestone_titles).to eq("#{milestone_1.title}, #{milestone_2.title}")}
+ it { expect(release.milestone_titles).to eq("#{milestone_1.title}, #{milestone_2.title}") }
end
end
diff --git a/spec/models/releases/link_spec.rb b/spec/models/releases/link_spec.rb
index 74ef38f482b4ecc546be7aaac3f12547e04f7425..4910de61c226b06238cb5055ca8c56026717c6d6 100644
--- a/spec/models/releases/link_spec.rb
+++ b/spec/models/releases/link_spec.rb
@@ -127,7 +127,7 @@
describe 'FILEPATH_REGEX with table' do
using RSpec::Parameterized::TableSyntax
- let(:link) { build(:release_link)}
+ let(:link) { build(:release_link) }
where(:reason, :filepath, :result) do
'cannot contain `//`' | '/https//www.example.com' | be_invalid
diff --git a/spec/models/remote_mirror_spec.rb b/spec/models/remote_mirror_spec.rb
index 62f50dc287451216c750784386f56d2884b8e30e..429ad5506266e54b72337ae46d56bad01f79e79c 100644
--- a/spec/models/remote_mirror_spec.rb
+++ b/spec/models/remote_mirror_spec.rb
@@ -219,7 +219,7 @@
end
describe '#hard_retry!' do
- let(:remote_mirror) { create(:remote_mirror).tap {|mirror| mirror.update_column(:url, 'invalid') } }
+ let(:remote_mirror) { create(:remote_mirror).tap { |mirror| mirror.update_column(:url, 'invalid') } }
it 'transitions an invalid mirror to the to_retry state' do
remote_mirror.hard_retry!('Invalid')
@@ -230,7 +230,7 @@
end
describe '#hard_fail!' do
- let(:remote_mirror) { create(:remote_mirror).tap {|mirror| mirror.update_column(:url, 'invalid') } }
+ let(:remote_mirror) { create(:remote_mirror).tap { |mirror| mirror.update_column(:url, 'invalid') } }
it 'transitions an invalid mirror to the failed state' do
remote_mirror.hard_fail!('Invalid')
diff --git a/spec/models/repository_spec.rb b/spec/models/repository_spec.rb
index b3fbe75a52628777094276ac68ee7ccc3bfc6838..2e9bdb5c4d77f967fa25dd09a8b544c3bd63520e 100644
--- a/spec/models/repository_spec.rb
+++ b/spec/models/repository_spec.rb
@@ -3123,7 +3123,7 @@ def expect_contributors(*contributors)
it 'after_create is not executed' do
expect(repository).not_to receive(:after_create)
- expect {repository.create_from_bundle(valid_bundle_path)}.to raise_error(::Gitlab::Git::BundleFile::InvalidBundleError)
+ expect { repository.create_from_bundle(valid_bundle_path) }.to raise_error(::Gitlab::Git::BundleFile::InvalidBundleError)
end
end
end
diff --git a/spec/models/snippet_input_action_collection_spec.rb b/spec/models/snippet_input_action_collection_spec.rb
index 3ec206bd0318f75997efa9b148bbcdf2dbef0507..269a9e1c787dfa3364a42d55c8064c7cba4b494a 100644
--- a/spec/models/snippet_input_action_collection_spec.rb
+++ b/spec/models/snippet_input_action_collection_spec.rb
@@ -12,7 +12,7 @@
it { is_expected.to delegate_method(:[]).to(:actions) }
describe '#to_commit_actions' do
- subject { described_class.new(data).to_commit_actions}
+ subject { described_class.new(data).to_commit_actions }
it 'translates all actions to commit actions' do
transformed_action = action.merge(action: action_name.to_sym)
@@ -22,14 +22,14 @@
end
describe '#valid?' do
- subject { described_class.new(data).valid?}
+ subject { described_class.new(data).valid? }
it 'returns true' do
expect(subject).to be true
end
context 'when any of the actions is invalid' do
- let(:data) { [action, { action: 'foo' }, action]}
+ let(:data) { [action, { action: 'foo' }, action] }
it 'returns false' do
expect(subject).to be false
diff --git a/spec/models/snippet_spec.rb b/spec/models/snippet_spec.rb
index a54edc8510ed8bb4dfc1f8b355b917c41011f103..38bd189f6f47b365649e8f35c1f064a74ef8004c 100644
--- a/spec/models/snippet_spec.rb
+++ b/spec/models/snippet_spec.rb
@@ -571,8 +571,8 @@
context 'when some blobs are not retrievable from repository' do
let(:snippet) { create(:snippet, :repository) }
let(:container) { double(:container) }
- let(:retrievable_filename) { 'retrievable_file'}
- let(:unretrievable_filename) { 'unretrievable_file'}
+ let(:retrievable_filename) { 'retrievable_file' }
+ let(:unretrievable_filename) { 'unretrievable_file' }
before do
allow(snippet).to receive(:list_files).and_return([retrievable_filename, unretrievable_filename])
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb
index d9031b9ecf894b9a923719e176bf3501dad05590..12029b4151d35864374a559d7fef37db2febb4fb 100644
--- a/spec/models/user_spec.rb
+++ b/spec/models/user_spec.rb
@@ -6392,7 +6392,7 @@ def compare_bcrypt_password(user, password)
end
context 'when password_automatically_set is true' do
- let(:user) { create(:omniauth_user, provider: 'ldap')}
+ let(:user) { create(:omniauth_user, provider: 'ldap') }
it_behaves_like 'password expired not applicable'
end
diff --git a/spec/models/users/calloutable_spec.rb b/spec/models/users/calloutable_spec.rb
index 01603d8bbd6369951d5a7df689ed383ccd524c41..791fe1c1bc4b7b57a081a487ba9c04fb23d2e750 100644
--- a/spec/models/users/calloutable_spec.rb
+++ b/spec/models/users/calloutable_spec.rb
@@ -15,8 +15,8 @@
describe '#dismissed_after?' do
let(:some_feature_name) { Users::Callout.feature_names.keys.second }
- let(:callout_dismissed_month_ago) { create(:callout, feature_name: some_feature_name, dismissed_at: 1.month.ago )}
- let(:callout_dismissed_day_ago) { create(:callout, feature_name: some_feature_name, dismissed_at: 1.day.ago )}
+ let(:callout_dismissed_month_ago) { create(:callout, feature_name: some_feature_name, dismissed_at: 1.month.ago ) }
+ let(:callout_dismissed_day_ago) { create(:callout, feature_name: some_feature_name, dismissed_at: 1.day.ago ) }
it 'returns whether a callout dismissed after specified date' do
expect(callout_dismissed_month_ago.dismissed_after?(15.days.ago)).to eq(false)
diff --git a/spec/models/wiki_page/meta_spec.rb b/spec/models/wiki_page/meta_spec.rb
index 37a282657d93bb910e34a65d7630f080ae0d1bb3..4d1a2dc1c989b351eda6b534371fe86378e15a53 100644
--- a/spec/models/wiki_page/meta_spec.rb
+++ b/spec/models/wiki_page/meta_spec.rb
@@ -89,7 +89,7 @@
shared_examples 'canonical_slug setting examples' do
# Constant overhead of two queries for the transaction
let(:upper_query_limit) { query_limit + 2 }
- let(:lower_query_limit) { [upper_query_limit - 1, 0].max}
+ let(:lower_query_limit) { [upper_query_limit - 1, 0].max }
let(:other_slug) { generate(:sluggified_title) }
it 'changes it to the correct value' do