diff --git a/app/controllers/projects/notes_controller.rb b/app/controllers/projects/notes_controller.rb index 7fcdf220bd2fc1a5cb4011b33203b04d524d3e05..3d8a787afcb446503cc294089e7635c659d3ab52 100644 --- a/app/controllers/projects/notes_controller.rb +++ b/app/controllers/projects/notes_controller.rb @@ -14,8 +14,7 @@ class Projects::NotesController < Projects::ApplicationController feature_category :team_planning, [:index, :create, :update, :destroy, :delete_attachment, :toggle_award_emoji] feature_category :code_review_workflow, [:resolve, :unresolve, :outdated_line_change] - urgency :medium, [:index] - urgency :low, [:create, :update, :destroy, :resolve, :unresolve, :toggle_award_emoji, :outdated_line_change] + urgency :low override :feature_category def feature_category diff --git a/spec/controllers/projects/notes_controller_spec.rb b/spec/controllers/projects/notes_controller_spec.rb index 500fab471ef85ab2f64708ff2328df518661bbdb..35aa01cdfad823bf2b900bcdbfcaae047c662e81 100644 --- a/spec/controllers/projects/notes_controller_spec.rb +++ b/spec/controllers/projects/notes_controller_spec.rb @@ -40,7 +40,7 @@ request.headers['X-Last-Fetched-At'] = microseconds(last_fetched_at) end - specify { expect(get(:index, params: request_params)).to have_request_urgency(:medium) } + specify { expect(get(:index, params: request_params)).to have_request_urgency(:low) } it 'sets the correct feature category' do get :index, params: request_params diff --git a/spec/lib/gitlab/etag_caching/middleware_spec.rb b/spec/lib/gitlab/etag_caching/middleware_spec.rb index d25511843ffd9475bdfcebd9a8e3ec45fe8d0849..1825aedefb7262f892914dfa1632f23cbaa221ae 100644 --- a/spec/lib/gitlab/etag_caching/middleware_spec.rb +++ b/spec/lib/gitlab/etag_caching/middleware_spec.rb @@ -124,8 +124,8 @@ method: 'GET', path: enabled_path, status: status_code, - request_urgency: :medium, - target_duration_s: 0.5, + request_urgency: :low, + target_duration_s: 5, metadata: a_hash_including( { 'meta.caller_id' => 'Projects::NotesController#index', diff --git a/spec/requests/projects/noteable_notes_spec.rb b/spec/requests/projects/noteable_notes_spec.rb index a490e0596807bb283e8fd244d11073d114a43c52..f3a61527c6fdd785f4ebadf581331ff6c40c93c1 100644 --- a/spec/requests/projects/noteable_notes_spec.rb +++ b/spec/requests/projects/noteable_notes_spec.rb @@ -45,7 +45,7 @@ expect(Gitlab::Metrics::RailsSlis.request_apdex).to( receive(:increment).with( labels: { - request_urgency: :medium, + request_urgency: :low, feature_category: "team_planning", endpoint_id: "Projects::NotesController#index" }, @@ -59,8 +59,8 @@ 'process_action.action_controller', a_hash_including( { - request_urgency: :medium, - target_duration_s: 0.5, + request_urgency: :low, + target_duration_s: 5, metadata: a_hash_including({ 'meta.feature_category' => 'team_planning', 'meta.caller_id' => "Projects::NotesController#index"