From ed17acf23ec004f4b6e7655fa39848a2d92b7de1 Mon Sep 17 00:00:00 2001
From: Nao Hashizume <nhashizume@gitlab.com>
Date: Fri, 17 May 2024 19:19:28 +0000
Subject: [PATCH] Upgrade `gitlab-styles` to 12.0.1
---
.rubocop_todo/cop/gem_fetcher.yml | 5 +
.rubocop_todo/graphql/extract_type.yml | 111 +++
.rubocop_todo/graphql/field_definitions.yml | 1 +
.rubocop_todo/graphql/field_method.yml | 1 +
.rubocop_todo/graphql/graphql_name.yml | 137 +++
.rubocop_todo/graphql/ordered_fields.yml | 6 +
.../graphql/unnecessary_field_alias.yml | 21 +
.rubocop_todo/layout/class_structure.yml | 527 +++++++++++
.rubocop_todo/layout/extra_spacing.yml | 28 +
.../layout/line_break_after_final_mixin.yml | 168 ++++
...e_end_string_concatenation_indentation.yml | 869 ++++++++++++++----
.../lint/redundant_safe_navigation.yml | 8 +
.rubocop_todo/lint/self_assignment.yml | 7 +
.rubocop_todo/lint/symbol_conversion.yml | 131 ++-
.rubocop_todo/performance/map_compact.yml | 13 +-
.../string_identifier_argument.yml | 242 +++++
.rubocop_todo/performance/string_include.yml | 6 +
.rubocop_todo/rails/pluck.yml | 15 +-
.rubocop_todo/rspec/example_wording.yml | 84 ++
.../factory_bot/excessive_create_list.yml | 2 +-
.rubocop_todo/style/arguments_forwarding.yml | 319 ++++---
.rubocop_todo/style/hash_each_methods.yml | 67 +-
.rubocop_todo/style/next.yml | 6 +
.rubocop_todo/style/redundant_parentheses.yml | 42 +
.rubocop_todo/style/redundant_return.yml | 8 +-
.rubocop_todo/style/self_assignment.yml | 6 +
Gemfile | 2 +-
Gemfile.checksum | 18 +-
Gemfile.lock | 46 +-
app/views/projects/blob/_editor.html.haml | 2 +-
.../_commit_message_container.html.haml | 2 +-
.../layouts/nav/_ask_duo_button.html.haml | 2 +-
.../pipelines/user_sees_security_tab_spec.rb | 2 +-
.../environments/environments_folder_spec.rb | 4 +-
34 files changed, 2528 insertions(+), 380 deletions(-)
create mode 100644 .rubocop_todo/cop/gem_fetcher.yml
create mode 100644 .rubocop_todo/graphql/extract_type.yml
create mode 100644 .rubocop_todo/graphql/graphql_name.yml
create mode 100644 .rubocop_todo/graphql/ordered_fields.yml
create mode 100644 .rubocop_todo/graphql/unnecessary_field_alias.yml
create mode 100644 .rubocop_todo/layout/class_structure.yml
create mode 100644 .rubocop_todo/layout/extra_spacing.yml
create mode 100644 .rubocop_todo/layout/line_break_after_final_mixin.yml
create mode 100644 .rubocop_todo/lint/redundant_safe_navigation.yml
create mode 100644 .rubocop_todo/lint/self_assignment.yml
create mode 100644 .rubocop_todo/performance/string_identifier_argument.yml
create mode 100644 .rubocop_todo/performance/string_include.yml
create mode 100644 .rubocop_todo/rspec/example_wording.yml
create mode 100644 .rubocop_todo/style/next.yml
create mode 100644 .rubocop_todo/style/redundant_parentheses.yml
create mode 100644 .rubocop_todo/style/self_assignment.yml
diff --git a/.rubocop_todo/cop/gem_fetcher.yml b/.rubocop_todo/cop/gem_fetcher.yml
new file mode 100644
index 0000000000000..7fabf418c818b
--- /dev/null
+++ b/.rubocop_todo/cop/gem_fetcher.yml
@@ -0,0 +1,5 @@
+---
+Cop/GemFetcher:
+ Details: grace period
+ Exclude:
+ - 'Gemfile'
diff --git a/.rubocop_todo/graphql/extract_type.yml b/.rubocop_todo/graphql/extract_type.yml
new file mode 100644
index 0000000000000..c361434f3865e
--- /dev/null
+++ b/.rubocop_todo/graphql/extract_type.yml
@@ -0,0 +1,111 @@
+---
+GraphQL/ExtractType:
+ Details: grace period
+ Exclude:
+ - 'app/graphql/mutations/ci/job_artifact/bulk_destroy.rb'
+ - 'app/graphql/mutations/ci/runner/bulk_delete.rb'
+ - 'app/graphql/types/access_levels/user_type.rb'
+ - 'app/graphql/types/achievements/user_achievement_type.rb'
+ - 'app/graphql/types/analytics/cycle_analytics/value_streams/stage_type.rb'
+ - 'app/graphql/types/audit_events/definition_type.rb'
+ - 'app/graphql/types/blame/commit_data_type.rb'
+ - 'app/graphql/types/board_type.rb'
+ - 'app/graphql/types/branch_protections/base_access_level_type.rb'
+ - 'app/graphql/types/ci/analytics_type.rb'
+ - 'app/graphql/types/ci/catalog/resource_type.rb'
+ - 'app/graphql/types/ci/config/include_type.rb'
+ - 'app/graphql/types/ci/freeze_period_type.rb'
+ - 'app/graphql/types/ci/inherited_ci_variable_type.rb'
+ - 'app/graphql/types/ci/job_token_scope_type.rb'
+ - 'app/graphql/types/ci/job_type.rb'
+ - 'app/graphql/types/ci/pipeline_schedule_type.rb'
+ - 'app/graphql/types/ci/pipeline_type.rb'
+ - 'app/graphql/types/ci/runner_type.rb'
+ - 'app/graphql/types/ci/test_suite_summary_type.rb'
+ - 'app/graphql/types/ci/test_suite_type.rb'
+ - 'app/graphql/types/clusters/agent_token_type.rb'
+ - 'app/graphql/types/clusters/agent_type.rb'
+ - 'app/graphql/types/commit_signatures/gpg_signature_type.rb'
+ - 'app/graphql/types/commit_type.rb'
+ - 'app/graphql/types/container_expiration_policy_type.rb'
+ - 'app/graphql/types/container_registry/protection/rule_type.rb'
+ - 'app/graphql/types/container_repository_type.rb'
+ - 'app/graphql/types/diff_type.rb'
+ - 'app/graphql/types/environment_type.rb'
+ - 'app/graphql/types/error_tracking/sentry_detailed_error_type.rb'
+ - 'app/graphql/types/error_tracking/sentry_error_type.rb'
+ - 'app/graphql/types/group_type.rb'
+ - 'app/graphql/types/incident_management/timeline_event_type.rb'
+ - 'app/graphql/types/issue_type.rb'
+ - 'app/graphql/types/jira_import_type.rb'
+ - 'app/graphql/types/jira_user_type.rb'
+ - 'app/graphql/types/kas/agent_metadata_type.rb'
+ - 'app/graphql/types/merge_request_type.rb'
+ - 'app/graphql/types/namespace/package_settings_type.rb'
+ - 'app/graphql/types/namespace_type.rb'
+ - 'app/graphql/types/notes/diff_position_type.rb'
+ - 'app/graphql/types/notes/note_type.rb'
+ - 'app/graphql/types/packages/conan/file_metadatum_type.rb'
+ - 'app/graphql/types/packages/conan/metadatum_type.rb'
+ - 'app/graphql/types/packages/maven/metadatum_type.rb'
+ - 'app/graphql/types/packages/package_base_type.rb'
+ - 'app/graphql/types/packages/package_details_type.rb'
+ - 'app/graphql/types/packages/package_file_type.rb'
+ - 'app/graphql/types/packages/protection/rule_type.rb'
+ - 'app/graphql/types/project_type.rb'
+ - 'app/graphql/types/projects/detailed_import_status_type.rb'
+ - 'app/graphql/types/query_type.rb'
+ - 'app/graphql/types/release_asset_link_type.rb'
+ - 'app/graphql/types/release_links_type.rb'
+ - 'app/graphql/types/release_type.rb'
+ - 'app/graphql/types/repository/blob_type.rb'
+ - 'app/graphql/types/root_storage_statistics_type.rb'
+ - 'app/graphql/types/snippets/blob_type.rb'
+ - 'app/graphql/types/subscription_type.rb'
+ - 'app/graphql/types/terraform/state_type.rb'
+ - 'app/graphql/types/terraform/state_version_type.rb'
+ - 'app/graphql/types/tree/blob_type.rb'
+ - 'app/graphql/types/tree/tree_entry_type.rb'
+ - 'app/graphql/types/user_merge_request_interaction_type.rb'
+ - 'app/graphql/types/work_items/linked_item_type.rb'
+ - 'app/graphql/types/work_items/widgets/description_type.rb'
+ - 'ee/app/graphql/mutations/projects/product_analytics_project_settings_update.rb'
+ - 'ee/app/graphql/types/ai/prompt/explain_vulnerability_prompt_type.rb'
+ - 'ee/app/graphql/types/analytics/ai_metrics.rb'
+ - 'ee/app/graphql/types/analytics/contribution_analytics/contribution_metadata_type.rb'
+ - 'ee/app/graphql/types/analytics/devops_adoption/snapshot_type.rb'
+ - 'ee/app/graphql/types/app_sec/fuzzing/api/ci_configuration_type.rb'
+ - 'ee/app/graphql/types/boards/epic_board_type.rb'
+ - 'ee/app/graphql/types/burnup_chart_daily_totals_type.rb'
+ - 'ee/app/graphql/types/ci/runner_usage_by_project_type.rb'
+ - 'ee/app/graphql/types/ci/runner_usage_type.rb'
+ - 'ee/app/graphql/types/compliance_management/compliance_framework_type.rb'
+ - 'ee/app/graphql/types/dast/profile_type.rb'
+ - 'ee/app/graphql/types/dast_site_profile_type.rb'
+ - 'ee/app/graphql/types/dependency_proxy/packages/setting_type.rb'
+ - 'ee/app/graphql/types/deployments/approval_summary_type.rb'
+ - 'ee/app/graphql/types/epic_descendant_count_type.rb'
+ - 'ee/app/graphql/types/epic_descendant_weight_sum_type.rb'
+ - 'ee/app/graphql/types/epic_health_status_type.rb'
+ - 'ee/app/graphql/types/epic_type.rb'
+ - 'ee/app/graphql/types/geo/geo_node_type.rb'
+ - 'ee/app/graphql/types/group_release_stats_type.rb'
+ - 'ee/app/graphql/types/incident_management/issuable_resource_link_type.rb'
+ - 'ee/app/graphql/types/incident_management/oncall_participant_type.rb'
+ - 'ee/app/graphql/types/instance_security_dashboard_type.rb'
+ - 'ee/app/graphql/types/iteration_type.rb'
+ - 'ee/app/graphql/types/member_roles/customizable_permission_type.rb'
+ - 'ee/app/graphql/types/metric_image_type.rb'
+ - 'ee/app/graphql/types/pipeline_security_report_finding_type.rb'
+ - 'ee/app/graphql/types/remote_development/workspace_type.rb'
+ - 'ee/app/graphql/types/requirements_management/requirement_type.rb'
+ - 'ee/app/graphql/types/security/finding_reports_comparer/report_type.rb'
+ - 'ee/app/graphql/types/security_report_summary_section_type.rb'
+ - 'ee/app/graphql/types/vulnerability_details/file_location_type.rb'
+ - 'ee/app/graphql/types/vulnerability_identifier_type.rb'
+ - 'ee/app/graphql/types/vulnerability_location/coverage_fuzzing_type.rb'
+ - 'ee/app/graphql/types/vulnerability_location/sast_type.rb'
+ - 'ee/app/graphql/types/vulnerability_location/secret_detection_type.rb'
+ - 'ee/app/graphql/types/vulnerability_scanner_type.rb'
+ - 'ee/app/graphql/types/vulnerability_type.rb'
+ - 'ee/app/graphql/types/work_items/widgets/rolledup_dates_type.rb'
diff --git a/.rubocop_todo/graphql/field_definitions.yml b/.rubocop_todo/graphql/field_definitions.yml
index fa230afc8d01b..15f18be23825c 100644
--- a/.rubocop_todo/graphql/field_definitions.yml
+++ b/.rubocop_todo/graphql/field_definitions.yml
@@ -2,4 +2,5 @@
# Cop supports --autocorrect.
GraphQL/FieldDefinitions:
Exclude:
+ - 'app/graphql/types/resolvable_interface.rb'
- 'ee/app/graphql/types/vulnerability_type.rb'
diff --git a/.rubocop_todo/graphql/field_method.yml b/.rubocop_todo/graphql/field_method.yml
index f9e9f46e7d658..387e89951afac 100644
--- a/.rubocop_todo/graphql/field_method.yml
+++ b/.rubocop_todo/graphql/field_method.yml
@@ -3,3 +3,4 @@
GraphQL/FieldMethod:
Exclude:
- 'app/graphql/types/packages/package_details_type.rb'
+ - 'app/graphql/types/projects/service_type.rb'
diff --git a/.rubocop_todo/graphql/graphql_name.yml b/.rubocop_todo/graphql/graphql_name.yml
new file mode 100644
index 0000000000000..7d93cedbfe97c
--- /dev/null
+++ b/.rubocop_todo/graphql/graphql_name.yml
@@ -0,0 +1,137 @@
+---
+GraphQL/GraphqlName:
+ Details: grace period
+ Exclude:
+ - 'app/graphql/mutations/alert_management/base.rb'
+ - 'app/graphql/mutations/alert_management/http_integration/http_integration_base.rb'
+ - 'app/graphql/mutations/alert_management/prometheus_integration/prometheus_integration_base.rb'
+ - 'app/graphql/mutations/award_emojis/base.rb'
+ - 'app/graphql/mutations/base_mutation.rb'
+ - 'app/graphql/mutations/boards/lists/base_create.rb'
+ - 'app/graphql/mutations/boards/lists/base_update.rb'
+ - 'app/graphql/mutations/ci/catalog/resources/base.rb'
+ - 'app/graphql/mutations/ci/job/base.rb'
+ - 'app/graphql/mutations/ci/pipeline/base.rb'
+ - 'app/graphql/mutations/ci/pipeline_schedule/base.rb'
+ - 'app/graphql/mutations/commits/create.rb'
+ - 'app/graphql/mutations/container_repositories/destroy_base.rb'
+ - 'app/graphql/mutations/customer_relations/contacts/base.rb'
+ - 'app/graphql/mutations/design_management/base.rb'
+ - 'app/graphql/mutations/incident_management/timeline_event/base.rb'
+ - 'app/graphql/mutations/incident_management/timeline_event_tag/base.rb'
+ - 'app/graphql/mutations/issues/base.rb'
+ - 'app/graphql/mutations/members/bulk_update_base.rb'
+ - 'app/graphql/mutations/merge_requests/base.rb'
+ - 'app/graphql/mutations/ml/models/base.rb'
+ - 'app/graphql/mutations/notes/base.rb'
+ - 'app/graphql/mutations/notes/create/base.rb'
+ - 'app/graphql/mutations/notes/update/base.rb'
+ - 'app/graphql/mutations/organizations/base.rb'
+ - 'app/graphql/mutations/pages/base.rb'
+ - 'app/graphql/mutations/releases/base.rb'
+ - 'app/graphql/mutations/saved_replies/base.rb'
+ - 'app/graphql/mutations/saved_replies/create.rb'
+ - 'app/graphql/mutations/saved_replies/destroy.rb'
+ - 'app/graphql/mutations/saved_replies/update.rb'
+ - 'app/graphql/mutations/security/ci_configuration/base_security_analyzer.rb'
+ - 'app/graphql/mutations/snippets/base.rb'
+ - 'app/graphql/mutations/terraform/state/base.rb'
+ - 'app/graphql/mutations/timelogs/base.rb'
+ - 'app/graphql/mutations/work_items/linked_items/base.rb'
+ - 'app/graphql/types/base_argument.rb'
+ - 'app/graphql/types/base_edge.rb'
+ - 'app/graphql/types/base_enum.rb'
+ - 'app/graphql/types/base_field.rb'
+ - 'app/graphql/types/base_input_object.rb'
+ - 'app/graphql/types/base_object.rb'
+ - 'app/graphql/types/base_scalar.rb'
+ - 'app/graphql/types/base_union.rb'
+ - 'app/graphql/types/boards/board_issuable_input_base_type.rb'
+ - 'app/graphql/types/boards/board_issue_input_base_type.rb'
+ - 'app/graphql/types/boards/negated_board_issue_input_type.rb'
+ - 'app/graphql/types/branch_protections/base_access_level_input_type.rb'
+ - 'app/graphql/types/branch_protections/base_access_level_type.rb'
+ - 'app/graphql/types/branch_rules/branch_protection_input_type.rb'
+ - 'app/graphql/types/ci/group_environment_scope_connection_type.rb'
+ - 'app/graphql/types/ci/group_variable_connection_type.rb'
+ - 'app/graphql/types/ci/job_base_field.rb'
+ - 'app/graphql/types/ci/job_need_union.rb'
+ - 'app/graphql/types/ci/pipeline_config_source_enum.rb'
+ - 'app/graphql/types/ci/pipeline_scope_enum.rb'
+ - 'app/graphql/types/ci/pipeline_status_enum.rb'
+ - 'app/graphql/types/ci/project_variable_connection_type.rb'
+ - 'app/graphql/types/ci/runner_countable_connection_type.rb'
+ - 'app/graphql/types/ci/runner_web_url_edge.rb'
+ - 'app/graphql/types/commit_action_type.rb'
+ - 'app/graphql/types/container_expiration_policy_cadence_enum.rb'
+ - 'app/graphql/types/container_expiration_policy_keep_enum.rb'
+ - 'app/graphql/types/container_expiration_policy_older_than_enum.rb'
+ - 'app/graphql/types/countable_connection_type.rb'
+ - 'app/graphql/types/data_transfer/base_type.rb'
+ - 'app/graphql/types/data_transfer/egress_node_type.rb'
+ - 'app/graphql/types/diff_paths_input_type.rb'
+ - 'app/graphql/types/issue_connection_type.rb'
+ - 'app/graphql/types/limited_countable_connection_type.rb'
+ - 'app/graphql/types/merge_request_connection_type.rb'
+ - 'app/graphql/types/merge_strategy_enum.rb'
+ - 'app/graphql/types/notes/diff_position_base_input_type.rb'
+ - 'app/graphql/types/packages/package_type_enum.rb'
+ - 'app/graphql/types/permission_types/base_permission_type.rb'
+ - 'app/graphql/types/range_input_type.rb'
+ - 'app/graphql/types/saved_reply_type.rb'
+ - 'app/graphql/types/snippets/blob_connection_type.rb'
+ - 'app/graphql/types/snippets/type_enum.rb'
+ - 'app/graphql/types/snippets/visibility_scopes_enum.rb'
+ - 'app/graphql/types/time_tracking/timelog_connection_type.rb'
+ - 'app/graphql/types/todo_action_enum.rb'
+ - 'app/graphql/types/todo_state_enum.rb'
+ - 'app/graphql/types/todo_target_enum.rb'
+ - 'app/graphql/types/untrusted_regexp.rb'
+ - 'app/graphql/types/visibility_levels_enum.rb'
+ - 'ee/app/graphql/mutations/ai/agents/base.rb'
+ - 'ee/app/graphql/mutations/audit_events/amazon_s3_configurations/base.rb'
+ - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/base.rb'
+ - 'ee/app/graphql/mutations/audit_events/google_cloud_logging_configurations/base.rb'
+ - 'ee/app/graphql/mutations/audit_events/group/audit_event_streaming_destinations/base.rb'
+ - 'ee/app/graphql/mutations/audit_events/group/namespace_filters/base.rb'
+ - 'ee/app/graphql/mutations/audit_events/instance/amazon_s3_configurations/base.rb'
+ - 'ee/app/graphql/mutations/audit_events/instance/audit_event_streaming_destinations/base.rb'
+ - 'ee/app/graphql/mutations/audit_events/instance/google_cloud_logging_configurations/base.rb'
+ - 'ee/app/graphql/mutations/audit_events/instance_external_audit_event_destinations/base.rb'
+ - 'ee/app/graphql/mutations/audit_events/streaming/base_event_type_filters/base_create.rb'
+ - 'ee/app/graphql/mutations/audit_events/streaming/base_event_type_filters/base_destroy.rb'
+ - 'ee/app/graphql/mutations/audit_events/streaming/http/namespace_filters/base.rb'
+ - 'ee/app/graphql/mutations/audit_events/streaming/instance_headers/base.rb'
+ - 'ee/app/graphql/mutations/boards/epic_boards/base.rb'
+ - 'ee/app/graphql/mutations/epics/base.rb'
+ - 'ee/app/graphql/mutations/incident_management/escalation_policy/base.rb'
+ - 'ee/app/graphql/mutations/incident_management/issuable_resource_link/base.rb'
+ - 'ee/app/graphql/mutations/incident_management/oncall_rotation/base.rb'
+ - 'ee/app/graphql/mutations/incident_management/oncall_schedule/oncall_schedule_base.rb'
+ - 'ee/app/graphql/mutations/member_roles/base.rb'
+ - 'ee/app/graphql/mutations/requirements_management/base_requirement.rb'
+ - 'ee/app/graphql/types/ai/base_method_input_type.rb'
+ - 'ee/app/graphql/types/analytics/ai_metrics.rb'
+ - 'ee/app/graphql/types/analytics/cycle_analytics/aggregation_status_type.rb'
+ - 'ee/app/graphql/types/analytics/value_stream_analytics_type.rb'
+ - 'ee/app/graphql/types/boards/board_epic_input_type.rb'
+ - 'ee/app/graphql/types/compliance_management/compliance_framework_filter_input_base_type.rb'
+ - 'ee/app/graphql/types/dast_scan_type_enum.rb'
+ - 'ee/app/graphql/types/dast_site_profile_validation_status_enum.rb'
+ - 'ee/app/graphql/types/dast_site_validation_status_enum.rb'
+ - 'ee/app/graphql/types/dast_site_validation_strategy_enum.rb'
+ - 'ee/app/graphql/types/dast_target_type_enum.rb'
+ - 'ee/app/graphql/types/epics/negated_epic_filter_input_type.rb'
+ - 'ee/app/graphql/types/geo/registrable_type.rb'
+ - 'ee/app/graphql/types/geo/replication_state_enum.rb'
+ - 'ee/app/graphql/types/geo/verification_state_enum.rb'
+ - 'ee/app/graphql/types/gitlab_subscriptions/preview_billable_user_change_type.rb'
+ - 'ee/app/graphql/types/protected_environments/authorizable_type.rb'
+ - 'ee/app/graphql/types/sbom/license_type.rb'
+ - 'ee/app/graphql/types/sbom/location_type.rb'
+ - 'ee/app/graphql/types/scan_status_enum.rb'
+ - 'ee/app/graphql/types/vulnerabilities/dismissal_reason_enum.rb'
+ - 'ee/app/graphql/types/vulnerability/external_issue_link_type_enum.rb'
+ - 'ee/app/graphql/types/vulnerability_identifier_input_type.rb'
+ - 'ee/app/graphql/types/vulnerability_scanner_input_type.rb'
+ - 'ee/app/graphql/types/vulnerability_scanner_vendor_input_type.rb'
diff --git a/.rubocop_todo/graphql/ordered_fields.yml b/.rubocop_todo/graphql/ordered_fields.yml
new file mode 100644
index 0000000000000..5d3b3d3a25474
--- /dev/null
+++ b/.rubocop_todo/graphql/ordered_fields.yml
@@ -0,0 +1,6 @@
+---
+# Cop supports --autocorrect.
+GraphQL/OrderedFields:
+ Details: grace period
+ Exclude:
+ - 'app/graphql/types/merge_request_type.rb'
diff --git a/.rubocop_todo/graphql/unnecessary_field_alias.yml b/.rubocop_todo/graphql/unnecessary_field_alias.yml
new file mode 100644
index 0000000000000..28e7f68eee761
--- /dev/null
+++ b/.rubocop_todo/graphql/unnecessary_field_alias.yml
@@ -0,0 +1,21 @@
+---
+# Cop supports --autocorrect.
+GraphQL/UnnecessaryFieldAlias:
+ Details: grace period
+ Exclude:
+ - 'app/graphql/types/ci/pipeline_type.rb'
+ - 'app/graphql/types/ci/runner_manager_type.rb'
+ - 'app/graphql/types/ci/runner_type.rb'
+ - 'app/graphql/types/deployment_tag_type.rb'
+ - 'app/graphql/types/issue_type.rb'
+ - 'app/graphql/types/ml/model_version_links_type.rb'
+ - 'app/graphql/types/projects/fork_details_type.rb'
+ - 'app/graphql/types/repository/blob_type.rb'
+ - 'ee/app/graphql/ee/types/project_type.rb'
+ - 'ee/app/graphql/types/admin/cloud_licenses/current_license_type.rb'
+ - 'ee/app/graphql/types/approval_rule_type.rb'
+ - 'ee/app/graphql/types/dast/profile_type.rb'
+ - 'ee/app/graphql/types/dora/performance_score_connection_type.rb'
+ - 'ee/app/graphql/types/group_release_stats_type.rb'
+ - 'ee/app/graphql/types/merge_requests/review_llm_summary_type.rb'
+ - 'ee/app/graphql/types/requirements_management/requirement_type.rb'
diff --git a/.rubocop_todo/layout/class_structure.yml b/.rubocop_todo/layout/class_structure.yml
new file mode 100644
index 0000000000000..b5adc566ce222
--- /dev/null
+++ b/.rubocop_todo/layout/class_structure.yml
@@ -0,0 +1,527 @@
+---
+# Cop supports --autocorrect.
+Layout/ClassStructure:
+ Details: grace period
+ Exclude:
+ - 'app/components/pajamas/accordion_item_component.rb'
+ - 'app/components/pajamas/alert_component.rb'
+ - 'app/components/pajamas/avatar_component.rb'
+ - 'app/components/pajamas/badge_component.rb'
+ - 'app/components/pajamas/banner_component.rb'
+ - 'app/components/pajamas/button_component.rb'
+ - 'app/components/pajamas/progress_component.rb'
+ - 'app/components/pajamas/spinner_component.rb'
+ - 'app/controllers/jira_connect/app_descriptor_controller.rb'
+ - 'app/controllers/projects/environments_controller.rb'
+ - 'app/finders/ci/group_variables_finder.rb'
+ - 'app/finders/clusters/knative_services_finder.rb'
+ - 'app/finders/group_members_finder.rb'
+ - 'app/finders/groups/environment_scopes_finder.rb'
+ - 'app/finders/issuable_finder.rb'
+ - 'app/graphql/mutations/base_mutation.rb'
+ - 'app/graphql/resolvers/analytics/cycle_analytics/base_count_resolver.rb'
+ - 'app/graphql/resolvers/base_resolver.rb'
+ - 'app/graphql/resolvers/board_list_issues_resolver.rb'
+ - 'app/graphql/resolvers/design_management/design_at_version_resolver.rb'
+ - 'app/graphql/resolvers/design_management/design_resolver.rb'
+ - 'app/graphql/resolvers/design_management/version/design_at_version_resolver.rb'
+ - 'app/graphql/resolvers/design_management/version_in_collection_resolver.rb'
+ - 'app/graphql/resolvers/group_issues_resolver.rb'
+ - 'app/graphql/resolvers/group_merge_requests_resolver.rb'
+ - 'app/graphql/resolvers/group_resolver.rb'
+ - 'app/graphql/resolvers/namespace_projects_resolver.rb'
+ - 'app/graphql/resolvers/namespace_resolver.rb'
+ - 'app/graphql/resolvers/project_pipeline_resolver.rb'
+ - 'app/graphql/resolvers/project_resolver.rb'
+ - 'app/graphql/resolvers/releases_resolver.rb'
+ - 'app/graphql/resolvers/work_items/work_item_discussions_resolver.rb'
+ - 'app/graphql/types/base_object.rb'
+ - 'app/mailers/notify.rb'
+ - 'app/models/abuse_report.rb'
+ - 'app/models/active_session.rb'
+ - 'app/models/alert_management/http_integration.rb'
+ - 'app/models/analytics/cycle_analytics/aggregation.rb'
+ - 'app/models/analytics/cycle_analytics/stage.rb'
+ - 'app/models/analytics/cycle_analytics/value_stream.rb'
+ - 'app/models/application_record.rb'
+ - 'app/models/application_setting.rb'
+ - 'app/models/audit_event.rb'
+ - 'app/models/award_emoji.rb'
+ - 'app/models/batched_git_ref_updates/deletion.rb'
+ - 'app/models/blob_viewer/base.rb'
+ - 'app/models/board.rb'
+ - 'app/models/bulk_import.rb'
+ - 'app/models/ci/bridge.rb'
+ - 'app/models/ci/build.rb'
+ - 'app/models/ci/build_metadata.rb'
+ - 'app/models/ci/external_pull_request.rb'
+ - 'app/models/ci/group.rb'
+ - 'app/models/ci/group_variable.rb'
+ - 'app/models/ci/job_artifact.rb'
+ - 'app/models/ci/processable.rb'
+ - 'app/models/ci/runner_manager.rb'
+ - 'app/models/clusters/agent_token.rb'
+ - 'app/models/commit.rb'
+ - 'app/models/commit_signatures/gpg_signature.rb'
+ - 'app/models/concerns/token_authenticatable_strategies/base.rb'
+ - 'app/models/concerns/where_composite.rb'
+ - 'app/models/container_repository.rb'
+ - 'app/models/customer_relations/contact.rb'
+ - 'app/models/deploy_key.rb'
+ - 'app/models/deployment.rb'
+ - 'app/models/design_management/design.rb'
+ - 'app/models/design_management/design_at_version.rb'
+ - 'app/models/design_management/version.rb'
+ - 'app/models/diff_note.rb'
+ - 'app/models/diff_note_position.rb'
+ - 'app/models/diff_viewer/base.rb'
+ - 'app/models/discussion.rb'
+ - 'app/models/draft_note.rb'
+ - 'app/models/environment_status.rb'
+ - 'app/models/error_tracking/project_error_tracking_setting.rb'
+ - 'app/models/gpg_key.rb'
+ - 'app/models/hooks/web_hook.rb'
+ - 'app/models/identity.rb'
+ - 'app/models/instance_metadata/kas.rb'
+ - 'app/models/integration.rb'
+ - 'app/models/integrations/base_chat_notification.rb'
+ - 'app/models/integrations/base_ci.rb'
+ - 'app/models/integrations/base_issue_tracker.rb'
+ - 'app/models/integrations/base_slack_notification.rb'
+ - 'app/models/integrations/base_slash_commands.rb'
+ - 'app/models/integrations/buildkite.rb'
+ - 'app/models/integrations/clickup.rb'
+ - 'app/models/integrations/confluence.rb'
+ - 'app/models/integrations/datadog.rb'
+ - 'app/models/integrations/diffblue_cover.rb'
+ - 'app/models/integrations/discord.rb'
+ - 'app/models/integrations/drone_ci.rb'
+ - 'app/models/integrations/ewm.rb'
+ - 'app/models/integrations/external_wiki.rb'
+ - 'app/models/integrations/gitlab_slack_application.rb'
+ - 'app/models/integrations/hangouts_chat.rb'
+ - 'app/models/integrations/harbor.rb'
+ - 'app/models/integrations/jenkins.rb'
+ - 'app/models/integrations/jira.rb'
+ - 'app/models/integrations/mattermost.rb'
+ - 'app/models/integrations/mattermost_slash_commands.rb'
+ - 'app/models/integrations/microsoft_teams.rb'
+ - 'app/models/integrations/phorge.rb'
+ - 'app/models/integrations/pipelines_email.rb'
+ - 'app/models/integrations/prometheus.rb'
+ - 'app/models/integrations/pumble.rb'
+ - 'app/models/integrations/teamcity.rb'
+ - 'app/models/integrations/unify_circuit.rb'
+ - 'app/models/integrations/webex_teams.rb'
+ - 'app/models/integrations/youtrack.rb'
+ - 'app/models/integrations/zentao.rb'
+ - 'app/models/issue.rb'
+ - 'app/models/jira_connect/public_key.rb'
+ - 'app/models/lfs_object.rb'
+ - 'app/models/loose_foreign_keys/deleted_record.rb'
+ - 'app/models/merge_request.rb'
+ - 'app/models/merge_request/metrics.rb'
+ - 'app/models/milestone.rb'
+ - 'app/models/ml/model.rb'
+ - 'app/models/namespace/root_storage_statistics.rb'
+ - 'app/models/namespace/traversal_hierarchy.rb'
+ - 'app/models/namespace_statistics.rb'
+ - 'app/models/notification_setting.rb'
+ - 'app/models/oauth_access_token.rb'
+ - 'app/models/packages/conan/metadatum.rb'
+ - 'app/models/packages/debian/group_architecture.rb'
+ - 'app/models/packages/debian/group_component.rb'
+ - 'app/models/packages/debian/group_component_file.rb'
+ - 'app/models/packages/debian/group_distribution.rb'
+ - 'app/models/packages/debian/group_distribution_key.rb'
+ - 'app/models/packages/debian/project_architecture.rb'
+ - 'app/models/packages/debian/project_component.rb'
+ - 'app/models/packages/debian/project_component_file.rb'
+ - 'app/models/packages/debian/project_distribution.rb'
+ - 'app/models/packages/debian/project_distribution_key.rb'
+ - 'app/models/packages/sem_ver.rb'
+ - 'app/models/personal_access_token.rb'
+ - 'app/models/project_statistics.rb'
+ - 'app/models/protected_branch.rb'
+ - 'app/models/release.rb'
+ - 'app/models/release_highlight.rb'
+ - 'app/models/repository.rb'
+ - 'app/models/resource_label_event.rb'
+ - 'app/models/snippet.rb'
+ - 'app/models/spam_log.rb'
+ - 'app/models/ssh_host_key.rb'
+ - 'app/models/state_note.rb'
+ - 'app/models/timelog.rb'
+ - 'app/models/user.rb'
+ - 'app/models/users/phone_number_validation.rb'
+ - 'app/models/users/saved_reply.rb'
+ - 'app/models/wiki_page.rb'
+ - 'app/models/wiki_page/slug.rb'
+ - 'app/models/work_items/type.rb'
+ - 'app/models/work_items/widgets/base.rb'
+ - 'app/models/work_items/widgets/hierarchy.rb'
+ - 'app/presenters/ci/build_runner_presenter.rb'
+ - 'app/services/auth/container_registry_authentication_service.rb'
+ - 'app/services/ci/pipeline_processing/atomic_processing_service/status_collection.rb'
+ - 'app/services/ci/pipeline_trigger_service.rb'
+ - 'app/services/ci/pipelines/add_job_service.rb'
+ - 'app/services/clusters/kubernetes/create_or_update_service_account_service.rb'
+ - 'app/services/dependency_proxy/auth_token_service.rb'
+ - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file_s3.rb'
+ - 'app/services/import_csv/base_service.rb'
+ - 'app/services/integrations/slack_interactions/incident_management/incident_modal_opened_service.rb'
+ - 'app/services/issuable/callbacks/base.rb'
+ - 'app/services/issuable_base_service.rb'
+ - 'app/services/issues/base_service.rb'
+ - 'app/services/merge_requests/base_service.rb'
+ - 'app/services/notification_recipients/builder/default.rb'
+ - 'app/services/notification_service.rb'
+ - 'app/services/projects/cleanup_service.rb'
+ - 'app/services/projects/count_service.rb'
+ - 'app/services/projects/forks_count_service.rb'
+ - 'app/services/projects/open_issues_count_service.rb'
+ - 'app/services/projects/open_merge_requests_count_service.rb'
+ - 'app/services/projects/prometheus/alerts/notify_service.rb'
+ - 'app/services/projects/schedule_bulk_repository_shard_moves_service.rb'
+ - 'app/services/snippets/schedule_bulk_repository_shard_moves_service.rb'
+ - 'app/services/spam/spam_params.rb'
+ - 'app/services/system_notes/design_management_service.rb'
+ - 'app/services/system_notes/issuables_service.rb'
+ - 'app/services/web_hook_service.rb'
+ - 'app/services/work_items/import_csv_service.rb'
+ - 'app/uploaders/file_uploader.rb'
+ - 'app/validators/addressable_url_validator.rb'
+ - 'app/validators/html_safety_validator.rb'
+ - 'app/workers/analytics/usage_trends/counter_job_worker.rb'
+ - 'app/workers/cluster_update_app_worker.rb'
+ - 'app/workers/gitlab_service_ping_worker.rb'
+ - 'app/workers/jira_connect/sync_deployments_worker.rb'
+ - 'app/workers/mail_scheduler/notification_service_worker.rb'
+ - 'app/workers/ml/experiment_tracking/associate_ml_candidate_to_package_worker.rb'
+ - 'app/workers/namespaces/process_outdated_namespace_descendants_cron_worker.rb'
+ - 'app/workers/object_storage/migrate_uploads_worker.rb'
+ - 'app/workers/repository_update_remote_mirror_worker.rb'
+ - 'ee/app/components/namespaces/free_user_cap/base_alert_component.rb'
+ - 'ee/app/controllers/projects/integrations/jira/issues_controller.rb'
+ - 'ee/app/controllers/subscriptions_controller.rb'
+ - 'ee/app/finders/autocomplete/vulnerabilities_autocomplete_finder.rb'
+ - 'ee/app/finders/namespaces/billed_users_finder.rb'
+ - 'ee/app/finders/namespaces/free_user_cap/users_without_added_members_finder.rb'
+ - 'ee/app/graphql/mutations/gitlab_subscriptions/user_add_on_assignments/bulk_create.rb'
+ - 'ee/app/graphql/mutations/gitlab_subscriptions/user_add_on_assignments/bulk_remove.rb'
+ - 'ee/app/graphql/mutations/iterations/update.rb'
+ - 'ee/app/graphql/mutations/vulnerabilities/bulk_dismiss.rb'
+ - 'ee/app/graphql/mutations/vulnerabilities/confirm.rb'
+ - 'ee/app/graphql/mutations/vulnerabilities/dismiss.rb'
+ - 'ee/app/graphql/mutations/vulnerabilities/resolve.rb'
+ - 'ee/app/graphql/mutations/vulnerabilities/revert_to_detected.rb'
+ - 'ee/app/graphql/representation/vulnerability_scanner_entry.rb'
+ - 'ee/app/graphql/resolvers/epics_resolver.rb'
+ - 'ee/app/graphql/resolvers/incident_management/oncall_shifts_resolver.rb'
+ - 'ee/app/graphql/resolvers/vulnerabilities/details_resolver.rb'
+ - 'ee/app/graphql/types/ci/runner_google_cloud_provisioning_type.rb'
+ - 'ee/app/models/approval_merge_request_rule.rb'
+ - 'ee/app/models/approval_state.rb'
+ - 'ee/app/models/boards/epic_board.rb'
+ - 'ee/app/models/ci/finished_build_ch_sync_event.rb'
+ - 'ee/app/models/ci/minutes/namespace_monthly_usage.rb'
+ - 'ee/app/models/dast/site_profile_secret_variable.rb'
+ - 'ee/app/models/dast_site_profile.rb'
+ - 'ee/app/models/dast_site_validation.rb'
+ - 'ee/app/models/elastic/migration_record.rb'
+ - 'ee/app/models/epic_issue.rb'
+ - 'ee/app/models/geo/secondary_usage_data.rb'
+ - 'ee/app/models/geo_node_status.rb'
+ - 'ee/app/models/groups/saved_reply.rb'
+ - 'ee/app/models/integrations/github.rb'
+ - 'ee/app/models/integrations/github/status_message.rb'
+ - 'ee/app/models/integrations/google_cloud_platform/artifact_registry.rb'
+ - 'ee/app/models/integrations/google_cloud_platform/workload_identity_federation.rb'
+ - 'ee/app/models/namespaces/free_user_cap/enforcement.rb'
+ - 'ee/app/models/package_metadata/advisory.rb'
+ - 'ee/app/models/package_metadata/package.rb'
+ - 'ee/app/models/product_analytics/dashboard.rb'
+ - 'ee/app/models/product_analytics/visualization.rb'
+ - 'ee/app/models/projects/saved_reply.rb'
+ - 'ee/app/models/protected_branch/unprotect_access_level.rb'
+ - 'ee/app/models/sbom/occurrence.rb'
+ - 'ee/app/models/search/zoekt/task.rb'
+ - 'ee/app/models/vulnerabilities/finding.rb'
+ - 'ee/app/models/vulnerabilities/identifier.rb'
+ - 'ee/app/models/vulnerabilities/projects_grade.rb'
+ - 'ee/app/models/work_items/widgets/rolledup_dates.rb'
+ - 'ee/app/replicators/geo/ci_secure_file_replicator.rb'
+ - 'ee/app/replicators/geo/dependency_proxy_blob_replicator.rb'
+ - 'ee/app/replicators/geo/dependency_proxy_manifest_replicator.rb'
+ - 'ee/app/replicators/geo/job_artifact_replicator.rb'
+ - 'ee/app/replicators/geo/lfs_object_replicator.rb'
+ - 'ee/app/replicators/geo/merge_request_diff_replicator.rb'
+ - 'ee/app/replicators/geo/pages_deployment_replicator.rb'
+ - 'ee/app/replicators/geo/pipeline_artifact_replicator.rb'
+ - 'ee/app/replicators/geo/terraform_state_version_replicator.rb'
+ - 'ee/app/services/ai/store_repository_xray_service.rb'
+ - 'ee/app/services/analytics/value_stream_dashboard/top_level_group_counter_service.rb'
+ - 'ee/app/services/app_sec/dast/scan_configs/build_service.rb'
+ - 'ee/app/services/click_house/data_ingestion/ci_finished_builds_sync_service.rb'
+ - 'ee/app/services/gitlab_subscriptions/trials/base_create_service.rb'
+ - 'ee/app/services/groups/schedule_bulk_repository_shard_moves_service.rb'
+ - 'ee/app/services/incident_management/create_incident_sla_exceeded_label_service.rb'
+ - 'ee/app/services/package_metadata/ingestion/advisory/advisory_ingestion_task.rb'
+ - 'ee/app/services/package_metadata/ingestion/advisory/affected_package_ingestion_task.rb'
+ - 'ee/app/services/package_metadata/ingestion/compressed_package/license_ingestion_task.rb'
+ - 'ee/app/services/package_metadata/ingestion/compressed_package/package_ingestion_task.rb'
+ - 'ee/app/services/path_locks/lock_service.rb'
+ - 'ee/app/services/path_locks/unlock_service.rb'
+ - 'ee/app/services/personal_access_tokens/rotation_verifier_service.rb'
+ - 'ee/app/services/search/zoekt/callback_service.rb'
+ - 'ee/app/services/search/zoekt/indexing_task_service.rb'
+ - 'ee/app/services/search/zoekt/routing_service.rb'
+ - 'ee/app/services/search/zoekt/scheduling_service.rb'
+ - 'ee/app/services/search/zoekt/task_presenter_service.rb'
+ - 'ee/app/services/search/zoekt/task_serializer_service.rb'
+ - 'ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb'
+ - 'ee/app/services/security/security_orchestration_policies/on_demand_scan_pipeline_configuration_service.rb'
+ - 'ee/app/services/security/training_providers/base_url_service.rb'
+ - 'ee/app/validators/password/complexity_validator.rb'
+ - 'ee/app/workers/analytics/cycle_analytics/reaggregation_worker.rb'
+ - 'ee/app/workers/app_sec/container_scanning/scan_image_worker.rb'
+ - 'ee/app/workers/compliance_management/framework_export_mailer_worker.rb'
+ - 'ee/app/workers/compliance_management/project_framework_export_mailer_worker.rb'
+ - 'ee/app/workers/compliance_management/standards_adherence_export_mailer_worker.rb'
+ - 'ee/app/workers/compliance_management/violation_export_mailer_worker.rb'
+ - 'ee/app/workers/elastic_wiki_indexer_worker.rb'
+ - 'ee/app/workers/geo/secondary_usage_data_cron_worker.rb'
+ - 'ee/app/workers/namespaces/free_user_cap/group_over_limit_notification_worker.rb'
+ - 'ee/app/workers/repository_update_mirror_worker.rb'
+ - 'ee/app/workers/search/wiki/elastic_delete_group_wiki_worker.rb'
+ - 'ee/app/workers/security/orchestration_policy_rule_schedule_namespace_worker.rb'
+ - 'ee/app/workers/zoekt/indexer_worker.rb'
+ - 'ee/lib/code_suggestions/tasks/base.rb'
+ - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb'
+ - 'ee/lib/gitlab/analytics/cycle_analytics/stage_events/label_based_stage_event.rb'
+ - 'ee/lib/gitlab/analytics/cycle_analytics/summary/base_time.rb'
+ - 'ee/lib/gitlab/analytics/cycle_analytics/summary/cycle_time.rb'
+ - 'ee/lib/gitlab/analytics/cycle_analytics/summary/lead_time.rb'
+ - 'ee/lib/gitlab/analytics/cycle_analytics/summary/time_to_merge.rb'
+ - 'ee/lib/gitlab/auth/group_saml/response_check.rb'
+ - 'ee/lib/gitlab/ci/reports/license_scanning/license.rb'
+ - 'ee/lib/gitlab/ci/runners_availability_builder.rb'
+ - 'ee/lib/gitlab/elastic/search_results.rb'
+ - 'ee/lib/gitlab/expiring_subscription_message.rb'
+ - 'ee/lib/gitlab/geo/git_ssh_proxy.rb'
+ - 'ee/lib/gitlab/license_scanning/base_scanner.rb'
+ - 'ee/lib/gitlab/license_scanning/package_licenses.rb'
+ - 'ee/lib/gitlab/llm/chain/agents/zero_shot/executor.rb'
+ - 'ee/lib/gitlab/llm/chain/tools/tool.rb'
+ - 'ee/lib/gitlab/llm/chat_storage.rb'
+ - 'ee/lib/gitlab/llm/vertex_ai/configuration.rb'
+ - 'ee/lib/gitlab/package_metadata/connector/csv_data_file.rb'
+ - 'ee/lib/gitlab/package_metadata/connector/ndjson_data_file.rb'
+ - 'ee/lib/gitlab/spdx/catalogue.rb'
+ - 'ee/lib/gitlab/spdx/license.rb'
+ - 'ee/lib/gitlab/timebox/burnchart_data_point.rb'
+ - 'ee/lib/gitlab/usage/metrics/instrumentations/count_ci_builds_metric.rb'
+ - 'ee/lib/gitlab/usage/metrics/instrumentations/count_users_creating_ci_builds_metric.rb'
+ - 'ee/lib/gitlab/vulnerability_scanning/advisory_scanner.rb'
+ - 'ee/lib/gitlab/vulnerability_scanning/container_scanning/affected_version_range_matcher.rb'
+ - 'ee/lib/gitlab/vulnerability_scanning/finding_builder.rb'
+ - 'ee/lib/gitlab/vulnerability_scanning/possibly_affected_component.rb'
+ - 'ee/lib/langsmith/client.rb'
+ - 'ee/lib/omni_auth/strategies/group_saml.rb'
+ - 'ee/lib/remote_development/workspaces/reconcile/output/devfile_parser.rb'
+ - 'ee/lib/remote_development/workspaces/reconcile/output/devfile_parser_v2.rb'
+ - 'ee/lib/system_check/app/advanced_search_migrations_check.rb'
+ - 'ee/lib/system_check/geo/license_check.rb'
+ - 'lib/api/support/git_access_actor.rb'
+ - 'lib/atlassian/jira_connect/serializers/feature_flag_entity.rb'
+ - 'lib/backup/database_configuration.rb'
+ - 'lib/banzai/filter/asset_proxy_filter.rb'
+ - 'lib/banzai/filter/emoji_filter.rb'
+ - 'lib/banzai/filter/math_filter.rb'
+ - 'lib/banzai/filter/references/abstract_reference_filter.rb'
+ - 'lib/banzai/filter/references/commit_range_reference_filter.rb'
+ - 'lib/bitbucket/representation/base.rb'
+ - 'lib/bitbucket_server/representation/base.rb'
+ - 'lib/carrier_wave_string_file.rb'
+ - 'lib/click_house/migration.rb'
+ - 'lib/click_house/models/audit_event.rb'
+ - 'lib/click_house/models/base_model.rb'
+ - 'lib/feature.rb'
+ - 'lib/gitlab/analytics/cycle_analytics/stage_events/stage_event.rb'
+ - 'lib/gitlab/api_authentication/token_locator.rb'
+ - 'lib/gitlab/audit/type/definition.rb'
+ - 'lib/gitlab/auth.rb'
+ - 'lib/gitlab/auth/activity.rb'
+ - 'lib/gitlab/auth/ldap/dn.rb'
+ - 'lib/gitlab/auth/result.rb'
+ - 'lib/gitlab/background_migration/backfill_branch_protection_namespace_setting.rb'
+ - 'lib/gitlab/background_migration/backfill_default_branch_protection_namespace_setting.rb'
+ - 'lib/gitlab/background_migration/job_coordinator.rb'
+ - 'lib/gitlab/background_migration/migrate_remediations_for_vulnerability_findings.rb'
+ - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb'
+ - 'lib/gitlab/background_task.rb'
+ - 'lib/gitlab/backup_logger.rb'
+ - 'lib/gitlab/checks/container_moved.rb'
+ - 'lib/gitlab/checks/post_push_message.rb'
+ - 'lib/gitlab/checks/project_created.rb'
+ - 'lib/gitlab/ci/ansi2html.rb'
+ - 'lib/gitlab/ci/build/status/reason.rb'
+ - 'lib/gitlab/ci/config/entry/job.rb'
+ - 'lib/gitlab/ci/config/entry/jobs.rb'
+ - 'lib/gitlab/ci/config/entry/pages.rb'
+ - 'lib/gitlab/ci/config/external/context.rb'
+ - 'lib/gitlab/ci/config/external/rules.rb'
+ - 'lib/gitlab/ci/config/interpolation/config.rb'
+ - 'lib/gitlab/ci/config/interpolation/context.rb'
+ - 'lib/gitlab/ci/config/yaml/tags/base.rb'
+ - 'lib/gitlab/ci/parsers/security/validators/schema_validator.rb'
+ - 'lib/gitlab/ci/pipeline/expression/lexeme/and.rb'
+ - 'lib/gitlab/ci/pipeline/expression/lexeme/base.rb'
+ - 'lib/gitlab/ci/pipeline/expression/lexeme/equals.rb'
+ - 'lib/gitlab/ci/pipeline/expression/lexeme/logical_operator.rb'
+ - 'lib/gitlab/ci/pipeline/expression/lexeme/matches.rb'
+ - 'lib/gitlab/ci/pipeline/expression/lexeme/not_equals.rb'
+ - 'lib/gitlab/ci/pipeline/expression/lexeme/not_matches.rb'
+ - 'lib/gitlab/ci/pipeline/expression/lexeme/null.rb'
+ - 'lib/gitlab/ci/pipeline/expression/lexeme/or.rb'
+ - 'lib/gitlab/ci/pipeline/expression/lexeme/pattern.rb'
+ - 'lib/gitlab/ci/pipeline/expression/lexeme/string.rb'
+ - 'lib/gitlab/ci/pipeline/expression/lexeme/variable.rb'
+ - 'lib/gitlab/ci/pipeline/expression/lexer.rb'
+ - 'lib/gitlab/ci/pipeline/expression/parser.rb'
+ - 'lib/gitlab/ci/queue/metrics.rb'
+ - 'lib/gitlab/ci/reports/security/flag.rb'
+ - 'lib/gitlab/ci/runner/metrics.rb'
+ - 'lib/gitlab/ci/status/bridge/play.rb'
+ - 'lib/gitlab/ci/status/build/action.rb'
+ - 'lib/gitlab/ci/status/build/cancelable.rb'
+ - 'lib/gitlab/ci/status/build/canceled.rb'
+ - 'lib/gitlab/ci/status/build/canceling.rb'
+ - 'lib/gitlab/ci/status/build/created.rb'
+ - 'lib/gitlab/ci/status/build/erased.rb'
+ - 'lib/gitlab/ci/status/build/failed.rb'
+ - 'lib/gitlab/ci/status/build/failed_allowed.rb'
+ - 'lib/gitlab/ci/status/build/failed_unmet_prerequisites.rb'
+ - 'lib/gitlab/ci/status/build/pending.rb'
+ - 'lib/gitlab/ci/status/build/play.rb'
+ - 'lib/gitlab/ci/status/build/preparing.rb'
+ - 'lib/gitlab/ci/status/build/retried.rb'
+ - 'lib/gitlab/ci/status/build/retryable.rb'
+ - 'lib/gitlab/ci/status/build/scheduled.rb'
+ - 'lib/gitlab/ci/status/build/skipped.rb'
+ - 'lib/gitlab/ci/status/build/stop.rb'
+ - 'lib/gitlab/ci/status/build/unschedule.rb'
+ - 'lib/gitlab/ci/status/extended.rb'
+ - 'lib/gitlab/ci/status/factory.rb'
+ - 'lib/gitlab/ci/status/pipeline/blocked.rb'
+ - 'lib/gitlab/ci/status/pipeline/delayed.rb'
+ - 'lib/gitlab/ci/status/processable/waiting_for_resource.rb'
+ - 'lib/gitlab/ci/status/stage/play_manual.rb'
+ - 'lib/gitlab/ci/status/success_warning.rb'
+ - 'lib/gitlab/ci/trace/metrics.rb'
+ - 'lib/gitlab/ci/variables/collection/item.rb'
+ - 'lib/gitlab/ci/yaml_processor/dag.rb'
+ - 'lib/gitlab/cleanup/orphan_job_artifact_files_batch.rb'
+ - 'lib/gitlab/cleanup/project_uploads.rb'
+ - 'lib/gitlab/color.rb'
+ - 'lib/gitlab/config/entry/node.rb'
+ - 'lib/gitlab/config/entry/simplifiable.rb'
+ - 'lib/gitlab/config/entry/validator.rb'
+ - 'lib/gitlab/config/loader/yaml.rb'
+ - 'lib/gitlab/counters/buffered_counter.rb'
+ - 'lib/gitlab/daemon.rb'
+ - 'lib/gitlab/database/background_migration/prometheus_metrics.rb'
+ - 'lib/gitlab/database/bulk_update.rb'
+ - 'lib/gitlab/database/dictionary.rb'
+ - 'lib/gitlab/database/migration.rb'
+ - 'lib/gitlab/database/migrations/version.rb'
+ - 'lib/gitlab/database/sha_attribute.rb'
+ - 'lib/gitlab/database/unidirectional_copy_trigger.rb'
+ - 'lib/gitlab/diff/file_collection/base.rb'
+ - 'lib/gitlab/diff/file_collection/merge_request_diff_base.rb'
+ - 'lib/gitlab/diff/line.rb'
+ - 'lib/gitlab/doctor/secrets.rb'
+ - 'lib/gitlab/error_tracking/error_collection.rb'
+ - 'lib/gitlab/error_tracking/error_repository/open_api_strategy.rb'
+ - 'lib/gitlab/event_store/event.rb'
+ - 'lib/gitlab/git/commit.rb'
+ - 'lib/gitlab/git/diff.rb'
+ - 'lib/gitlab/git/repository.rb'
+ - 'lib/gitlab/git_access.rb'
+ - 'lib/gitlab/gitaly_client/diff.rb'
+ - 'lib/gitlab/gitaly_client/wiki_page.rb'
+ - 'lib/gitlab/graphql/deprecations/deprecation.rb'
+ - 'lib/gitlab/graphql/lazy.rb'
+ - 'lib/gitlab/highlight.rb'
+ - 'lib/gitlab/import_export/base/relation_factory.rb'
+ - 'lib/gitlab/issues/rebalancing/state.rb'
+ - 'lib/gitlab/kubernetes/rollout_status.rb'
+ - 'lib/gitlab/merge_requests/message_generator.rb'
+ - 'lib/gitlab/metrics/requests_rack_middleware.rb'
+ - 'lib/gitlab/metrics/subscribers/active_record.rb'
+ - 'lib/gitlab/metrics/subscribers/load_balancing.rb'
+ - 'lib/gitlab/middleware/organizations/current.rb'
+ - 'lib/gitlab/middleware/same_site_cookies.rb'
+ - 'lib/gitlab/multi_destination_logger.rb'
+ - 'lib/gitlab/pagination/keyset/order.rb'
+ - 'lib/gitlab/prometheus_client.rb'
+ - 'lib/gitlab/query_limiting/transaction.rb'
+ - 'lib/gitlab/repository_cache.rb'
+ - 'lib/gitlab/sidekiq_daemon/monitor.rb'
+ - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb'
+ - 'lib/gitlab/slash_commands/base_command.rb'
+ - 'lib/gitlab/sql/set_operator.rb'
+ - 'lib/gitlab/suggestions/commit_message.rb'
+ - 'lib/gitlab/untrusted_regexp.rb'
+ - 'lib/gitlab/utils/safe_inline_hash.rb'
+ - 'lib/gitlab/web_hooks/recursion_detection/uuid.rb'
+ - 'lib/gitlab/wiki_pages/front_matter_parser.rb'
+ - 'lib/gitlab/workhorse.rb'
+ - 'lib/gitlab/x509/certificate.rb'
+ - 'lib/json_web_token/hmac_token.rb'
+ - 'lib/json_web_token/rsa_token.rb'
+ - 'lib/omni_auth/strategies/jwt.rb'
+ - 'lib/pager_duty/webhook_payload_parser.rb'
+ - 'lib/peek/views/click_house.rb'
+ - 'lib/peek/views/elasticsearch.rb'
+ - 'lib/peek/views/external_http.rb'
+ - 'lib/peek/views/zoekt.rb'
+ - 'lib/release_highlights/validator.rb'
+ - 'lib/result.rb'
+ - 'lib/sbom/package_url.rb'
+ - 'lib/system_check/base_check.rb'
+ - 'lib/uploaded_file.rb'
+ - 'qa/qa/ee/scenario/test/geo.rb'
+ - 'qa/qa/git/repository.rb'
+ - 'qa/qa/page/base.rb'
+ - 'qa/qa/page/dashboard/projects.rb'
+ - 'qa/qa/page/dashboard/welcome.rb'
+ - 'qa/qa/page/main/login.rb'
+ - 'qa/qa/page/mattermost/login.rb'
+ - 'qa/qa/page/view.rb'
+ - 'qa/qa/resource/project.rb'
+ - 'qa/qa/resource/protected_branch.rb'
+ - 'qa/qa/resource/user.rb'
+ - 'qa/qa/runtime/address.rb'
+ - 'qa/qa/runtime/api/client.rb'
+ - 'qa/qa/runtime/browser.rb'
+ - 'qa/qa/runtime/release.rb'
+ - 'qa/qa/service/cluster_provider/gcloud.rb'
+ - 'qa/qa/service/docker_run/saml_idp.rb'
+ - 'qa/qa/service/docker_run/smocker.rb'
+ - 'qa/qa/support/parallel_pipeline_jobs.rb'
+ - 'qa/qa/tools/ci/test_metrics.rb'
+ - 'qa/qa/tools/migrate_influx_data_to_gcs.rb'
+ - 'qa/qa/tools/reliable_report.rb'
+ - 'rubocop/cop/migration/ensure_factory_for_table.rb'
+ - 'rubocop/cop/rails/migration_timestamp.rb'
+ - 'rubocop/cop_todo.rb'
+ - 'rubocop/formatter/graceful_formatter.rb'
+ - 'rubocop/formatter/todo_formatter.rb'
+ - 'scripts/download-downstream-artifact.rb'
+ - 'scripts/static-analysis'
+ - 'scripts/trigger-build.rb'
+ - 'spec/support/helpers/database/duplicate_indexes.rb'
+ - 'spec/support/helpers/graphql/arguments.rb'
+ - 'spec/support/helpers/graphql/field_selection.rb'
+ - 'spec/support/rspec_order.rb'
diff --git a/.rubocop_todo/layout/extra_spacing.yml b/.rubocop_todo/layout/extra_spacing.yml
new file mode 100644
index 0000000000000..00844b3831407
--- /dev/null
+++ b/.rubocop_todo/layout/extra_spacing.yml
@@ -0,0 +1,28 @@
+---
+# Cop supports --autocorrect.
+Layout/ExtraSpacing:
+ Details: grace period
+ Exclude:
+ - 'app/finders/admin/plans_finder.rb'
+ - 'app/finders/autocomplete/users_finder.rb'
+ - 'app/graphql/mutations/commits/create.rb'
+ - 'app/graphql/types/ci/job_artifact_file_type_enum.rb'
+ - 'db/post_migrate/20230528203340_drop_message_from_vulnerability_occurrences.rb'
+ - 'ee/app/graphql/mutations/geo/registries/update.rb'
+ - 'ee/app/models/epic_issue.rb'
+ - 'ee/app/models/merge_request/predictions.rb'
+ - 'ee/app/models/search/namespace_index_assignment.rb'
+ - 'ee/app/services/dependencies/export_serializers/group_dependencies_service.rb'
+ - 'ee/app/workers/pull_mirrors/reenable_configuration_worker.rb'
+ - 'ee/elastic/migrate/20230702000000_backfill_existing_group_wiki.rb'
+ - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb'
+ - 'ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb'
+ - 'ee/spec/controllers/projects/settings/merge_requests_controller_spec.rb'
+ - 'ee/spec/elastic/migrate/20230821123542_backfill_archived_field_in_blob_spec.rb'
+ - 'ee/spec/requests/api/internal/base_spec.rb'
+ - 'ee/spec/services/app_sec/fuzzing/api/ci_configuration_create_service_spec.rb'
+ - 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb'
+ - 'spec/lib/api/helpers/packages/npm_spec.rb'
+ - 'spec/lib/gitlab/database/background_migration/batch_optimizer_spec.rb'
+ - 'spec/lib/gitlab/database/no_new_tables_with_gitlab_main_schema_spec.rb'
+ - 'spec/lib/gitlab/database/reindexing/index_selection_spec.rb'
diff --git a/.rubocop_todo/layout/line_break_after_final_mixin.yml b/.rubocop_todo/layout/line_break_after_final_mixin.yml
new file mode 100644
index 0000000000000..be9081588bdc2
--- /dev/null
+++ b/.rubocop_todo/layout/line_break_after_final_mixin.yml
@@ -0,0 +1,168 @@
+---
+# Cop supports --autocorrect.
+Layout/LineBreakAfterFinalMixin:
+ Details: grace period
+ Exclude:
+ - 'app/controllers/admin/clusters_controller.rb'
+ - 'app/controllers/admin/dashboard_controller.rb'
+ - 'app/controllers/projects/deploy_keys_controller.rb'
+ - 'app/controllers/snippets/blobs_controller.rb'
+ - 'app/graphql/mutations/integrations/exclusions/create.rb'
+ - 'app/graphql/resolvers/integrations/exclusions_resolver.rb'
+ - 'app/graphql/resolvers/project_pipeline_statistics_resolver.rb'
+ - 'app/graphql/resolvers/projects/deploy_key_resolver.rb'
+ - 'app/models/alert_management/metric_image.rb'
+ - 'app/models/ci/pipeline.rb'
+ - 'app/models/container_registry/protection/rule.rb'
+ - 'app/models/integrations/pushover.rb'
+ - 'app/models/integrations/telegram.rb'
+ - 'app/models/plan_limits.rb'
+ - 'app/models/project_feature_usage.rb'
+ - 'app/models/protected_branch/merge_access_level.rb'
+ - 'app/models/protected_branch/push_access_level.rb'
+ - 'app/policies/project_member_policy.rb'
+ - 'app/serializers/cluster_serializer.rb'
+ - 'app/serializers/container_repositories_serializer.rb'
+ - 'app/serializers/feature_flag_serializer.rb'
+ - 'app/serializers/pipeline_serializer.rb'
+ - 'app/services/authorized_project_update/project_recalculate_service.rb'
+ - 'app/services/batched_git_ref_updates/cleanup_scheduler_service.rb'
+ - 'app/services/jira_connect_subscriptions/create_service.rb'
+ - 'app/services/merge_requests/refresh_service.rb'
+ - 'app/services/projects/transfer_service.rb'
+ - 'app/services/users/update_service.rb'
+ - 'app/workers/admin_email_worker.rb'
+ - 'app/workers/ci/delete_unit_tests_worker.rb'
+ - 'app/workers/ci/pipeline_artifacts/expire_artifacts_worker.rb'
+ - 'app/workers/ci/schedule_delete_objects_cron_worker.rb'
+ - 'app/workers/ci/schedule_unlock_pipelines_in_queue_cron_worker.rb'
+ - 'app/workers/ci/stuck_builds/drop_canceling_worker.rb'
+ - 'app/workers/ci/stuck_builds/drop_running_worker.rb'
+ - 'app/workers/ci/stuck_builds/drop_scheduled_worker.rb'
+ - 'app/workers/ci/update_locked_unknown_artifacts_worker.rb'
+ - 'app/workers/concurrency_limit/resume_worker.rb'
+ - 'app/workers/expire_build_artifacts_worker.rb'
+ - 'app/workers/gitlab/export/prune_project_export_jobs_worker.rb'
+ - 'app/workers/import_export_project_cleanup_worker.rb'
+ - 'app/workers/members/expiring_worker.rb'
+ - 'app/workers/metrics/global_metrics_update_worker.rb'
+ - 'app/workers/namespaces/process_outdated_namespace_descendants_cron_worker.rb'
+ - 'app/workers/object_storage/delete_stale_direct_uploads_worker.rb'
+ - 'app/workers/prune_old_events_worker.rb'
+ - 'app/workers/purge_dependency_proxy_cache_worker.rb'
+ - 'app/workers/remove_unreferenced_lfs_objects_worker.rb'
+ - 'app/workers/repository_archive_cache_worker.rb'
+ - 'app/workers/stuck_ci_jobs_worker.rb'
+ - 'app/workers/stuck_export_jobs_worker.rb'
+ - 'app/workers/user_status_cleanup/batch_worker.rb'
+ - 'app/workers/users/create_statistics_worker.rb'
+ - 'db/migrate/20240213223630_add_duo_features_enabled_cascading_setting.rb'
+ - 'db/post_migrate/20231017064317_swap_columns_for_ci_pipeline_variables_pipeline_id_bigint.rb'
+ - 'db/post_migrate/20231122111935_drop_index_web_hook_logs_part_on_web_hook_id.rb'
+ - 'db/post_migrate/20240122071840_ensure_backfill_for_ci_builds_integer_columns_is_finished.rb'
+ - 'db/post_migrate/20240419122328_swap_vulnerability_feedback_pipeline_id_convert_to_bigint.rb'
+ - 'db/post_migrate/20240419131607_swap_packages_build_infos_pipeline_id_convert_to_bigint.rb'
+ - 'db/post_migrate/20240422080018_swap_merge_trains_pipeline_id_convert_to_bigint.rb'
+ - 'db/post_migrate/20240424111535_swap_merge_request_metrics_pipeline_id_convert_to_bigint.rb'
+ - 'db/post_migrate/20240513111937_swap_columns_for_p_ci_builds_trigger_request_and_erased_by.rb'
+ - 'db/post_migrate/20240514081440_swap_vulnerability_occurrence_pipelines_pipeline_id_convert_to_bigint.rb'
+ - 'ee/app/controllers/explore/dependencies_controller.rb'
+ - 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb'
+ - 'ee/app/graphql/resolvers/remote_development/workspaces_for_query_root_resolver.rb'
+ - 'ee/app/graphql/subscriptions/ai_completion_response.rb'
+ - 'ee/app/models/approval_project_rules_protected_branch.rb'
+ - 'ee/app/models/approval_rules/approval_group_rule.rb'
+ - 'ee/app/models/approval_rules/approval_group_rules_protected_branch.rb'
+ - 'ee/app/models/ldap_group_link.rb'
+ - 'ee/app/models/namespace_limit.rb'
+ - 'ee/app/models/vulnerabilities/scanner.rb'
+ - 'ee/app/models/vulnerabilities/statistic.rb'
+ - 'ee/app/services/ci/runners/get_usage_by_project_service.rb'
+ - 'ee/app/services/ci/runners/get_usage_service.rb'
+ - 'ee/app/services/ee/ip_restrictions/update_service.rb'
+ - 'ee/app/services/gitlab_subscriptions/duo_pro/bulk_assign_service.rb'
+ - 'ee/app/services/gitlab_subscriptions/trials/base_apply_trial_service.rb'
+ - 'ee/app/services/incident_management/oncall_rotations/edit_service.rb'
+ - 'ee/app/services/incident_management/oncall_rotations/remove_participant_service.rb'
+ - 'ee/app/services/llm/generate_description_service.rb'
+ - 'ee/app/services/product_analytics/initialize_stack_service.rb'
+ - 'ee/app/services/remote_development/workspaces/update_service.rb'
+ - 'ee/app/services/vulnerabilities/bulk_dismiss_service.rb'
+ - 'ee/app/workers/active_user_count_threshold_worker.rb'
+ - 'ee/app/workers/analytics/cycle_analytics/consistency_worker.rb'
+ - 'ee/app/workers/analytics/cycle_analytics/incremental_worker.rb'
+ - 'ee/app/workers/analytics/cycle_analytics/reaggregation_worker.rb'
+ - 'ee/app/workers/analytics/value_stream_dashboard/count_worker.rb'
+ - 'ee/app/workers/arkose/blocked_users_report_worker.rb'
+ - 'ee/app/workers/elastic_indexing_control_worker.rb'
+ - 'ee/app/workers/emails/abandoned_trial_emails_cron_worker.rb'
+ - 'ee/app/workers/geo/metrics_update_worker.rb'
+ - 'ee/app/workers/geo/sidekiq_cron_config_worker.rb'
+ - 'ee/app/workers/gitlab_subscriptions/notify_seats_exceeded_batch_worker.rb'
+ - 'ee/app/workers/historical_data_worker.rb'
+ - 'ee/app/workers/ldap_all_groups_sync_worker.rb'
+ - 'ee/app/workers/okrs/checkin_reminder_emails_cron_worker.rb'
+ - 'ee/app/workers/security/create_orchestration_policy_worker.rb'
+ - 'ee/app/workers/sync_seat_link_worker.rb'
+ - 'ee/app/workers/vulnerabilities/historical_statistics/deletion_worker.rb'
+ - 'ee/app/workers/vulnerabilities/statistics/schedule_worker.rb'
+ - 'ee/app/workers/work_items/rolledup_dates/update_rolledup_dates_worker.rb'
+ - 'ee/lib/api/dependency_proxy/packages/maven.rb'
+ - 'ee/lib/api/resource_iteration_events.rb'
+ - 'ee/lib/api/resource_weight_events.rb'
+ - 'ee/lib/duo_pro/bulk_user_assignment.rb'
+ - 'ee/lib/ee/api/entities/project_push_rule.rb'
+ - 'ee/lib/ee/gitlab/background_migration/create_compliance_standards_adherence.rb'
+ - 'ee/lib/ee/gitlab/background_migration/create_vulnerability_links.rb'
+ - 'ee/lib/ee/gitlab/background_migration/delete_orphaned_transferred_project_approval_rules.rb'
+ - 'ee/lib/ee/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition.rb'
+ - 'ee/lib/gitlab/auth/group_saml/identity_linker.rb'
+ - 'ee/lib/gitlab/llm/chain/tools/explain_code/prompts/anthropic.rb'
+ - 'ee/lib/gitlab/search/zoekt/client.rb'
+ - 'ee/lib/gitlab/status_page/storage/s3_multipart_upload.rb'
+ - 'ee/lib/remote_development/agent_config/main.rb'
+ - 'ee/lib/remote_development/agent_config/updater.rb'
+ - 'ee/lib/remote_development/settings/main.rb'
+ - 'ee/lib/remote_development/workspaces/create/main.rb'
+ - 'ee/lib/remote_development/workspaces/reconcile/main.rb'
+ - 'ee/lib/remote_development/workspaces/update/main.rb'
+ - 'ee/lib/search/zoekt/query.rb'
+ - 'lib/api/discussions.rb'
+ - 'lib/api/events.rb'
+ - 'lib/api/group_labels.rb'
+ - 'lib/api/issues.rb'
+ - 'lib/api/labels.rb'
+ - 'lib/api/notes.rb'
+ - 'lib/api/project_events.rb'
+ - 'lib/api/remote_mirrors.rb'
+ - 'lib/api/resource_label_events.rb'
+ - 'lib/api/resource_milestone_events.rb'
+ - 'lib/api/resource_state_events.rb'
+ - 'lib/api/rubygem_packages.rb'
+ - 'lib/api/terraform/modules/v1/namespace_packages.rb'
+ - 'lib/api/terraform/modules/v1/project_packages.rb'
+ - 'lib/banzai/filter/references/design_reference_filter.rb'
+ - 'lib/feature.rb'
+ - 'lib/gitlab/auth/current_user_mode.rb'
+ - 'lib/gitlab/auth/otp/strategies/forti_token_cloud.rb'
+ - 'lib/gitlab/background_migration/backfill_draft_status_on_merge_requests_with_corrected_regex.rb'
+ - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb'
+ - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb'
+ - 'lib/gitlab/ci/config/interpolation/config.rb'
+ - 'lib/gitlab/cluster/rack_timeout_observer.rb'
+ - 'lib/gitlab/etag_caching/router/graphql.rb'
+ - 'lib/gitlab/git_post_receive.rb'
+ - 'lib/gitlab/prometheus_client.rb'
+ - 'lib/gitlab/spamcheck/result.rb'
+ - 'lib/gitlab/user_access_snippet.rb'
+ - 'lib/gitlab/view/presenter/delegated.rb'
+ - 'lib/system_check/incoming_email/mail_room_enabled_check.rb'
+ - 'lib/system_check/incoming_email/mail_room_running_check.rb'
+ - 'qa/qa/ee/page/workspace/new.rb'
+ - 'qa/qa/ee/scenario/test/integration/group_saml.rb'
+ - 'qa/qa/page/organization/new.rb'
+ - 'qa/qa/page/organization/show.rb'
+ - 'qa/qa/page/project/issue/show.rb'
+ - 'qa/qa/page/project/snippet/new.rb'
+ - 'qa/qa/resource/base.rb'
+ - 'qa/qa/scenario/test/instance/airgapped.rb'
diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml
index 90b005512acb7..c29b80f47e770 100644
--- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml
+++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml
@@ -1,300 +1,833 @@
---
# Cop supports --autocorrect.
Layout/LineEndStringConcatenationIndentation:
+ Details: grace period
Exclude:
- - 'app/controllers/admin/application_settings_controller.rb'
- - 'app/finders/snippets_finder.rb'
- - 'app/graphql/mutations/ci/project_ci_cd_settings_update.rb'
- - 'app/graphql/mutations/ci/runner/bulk_delete.rb'
- - 'app/graphql/mutations/environments/canary_ingress/update.rb'
- - 'app/graphql/resolvers/ci/runner_projects_resolver.rb'
- - 'app/graphql/resolvers/projects_resolver.rb'
- - 'app/graphql/types/ci/ci_cd_setting_type.rb'
+ - 'app/components/diffs/overflow_warning_component.rb'
+ - 'app/controllers/concerns/controller_with_cross_project_access_check.rb'
+ - 'app/controllers/import/github_controller.rb'
+ - 'app/controllers/projects/google_cloud/databases_controller.rb'
+ - 'app/controllers/projects/merge_requests/conflicts_controller.rb'
+ - 'app/graphql/gitlab_schema.rb'
+ - 'app/graphql/mutations/achievements/update_user_achievement_priorities.rb'
+ - 'app/graphql/mutations/award_emojis/toggle.rb'
+ - 'app/graphql/mutations/boards/issues/issue_move_list.rb'
+ - 'app/graphql/mutations/ci/job_token_scope/add_project.rb'
+ - 'app/graphql/mutations/concerns/mutations/validate_time_estimate.rb'
+ - 'app/graphql/mutations/container_registry/protection/rule/create.rb'
+ - 'app/graphql/mutations/container_registry/protection/rule/delete.rb'
+ - 'app/graphql/mutations/container_registry/protection/rule/update.rb'
+ - 'app/graphql/mutations/design_management/upload.rb'
+ - 'app/graphql/mutations/issues/bulk_update.rb'
+ - 'app/graphql/mutations/issues/update.rb'
+ - 'app/graphql/mutations/members/projects/bulk_update.rb'
+ - 'app/graphql/mutations/merge_requests/update.rb'
+ - 'app/graphql/mutations/packages/protection/rule/create.rb'
+ - 'app/graphql/mutations/packages/protection/rule/delete.rb'
+ - 'app/graphql/mutations/packages/protection/rule/update.rb'
+ - 'app/graphql/mutations/todos/mark_all_done.rb'
+ - 'app/graphql/resolvers/analytics/cycle_analytics/value_streams/stage_metrics_resolver.rb'
+ - 'app/graphql/resolvers/ci/all_jobs_resolver.rb'
+ - 'app/graphql/resolvers/ci/config_resolver.rb'
+ - 'app/graphql/resolvers/ci/runners_resolver.rb'
+ - 'app/graphql/resolvers/ci/template_resolver.rb'
+ - 'app/graphql/resolvers/concerns/project_search_arguments.rb'
+ - 'app/graphql/resolvers/design_management/designs_resolver.rb'
+ - 'app/graphql/resolvers/groups_resolver.rb'
+ - 'app/graphql/resolvers/issues/base_resolver.rb'
+ - 'app/graphql/resolvers/work_items/linked_items_resolver.rb'
+ - 'app/graphql/types/analytics/cycle_analytics/value_streams/stage_metrics_type.rb'
+ - 'app/graphql/types/audit_events/definition_type.rb'
+ - 'app/graphql/types/ci/catalog/resource_type.rb'
+ - 'app/graphql/types/ci/catalog/resources/version_type.rb'
- 'app/graphql/types/ci/config/include_type.rb'
+ - 'app/graphql/types/ci/detailed_status_type.rb'
+ - 'app/graphql/types/ci/job_token_scope/direction_enum.rb'
+ - 'app/graphql/types/ci/job_token_scope_type.rb'
+ - 'app/graphql/types/ci/job_trace_type.rb'
+ - 'app/graphql/types/ci/job_type.rb'
- 'app/graphql/types/ci/runner_membership_filter_enum.rb'
- - 'app/graphql/types/ci/runner_status_enum.rb'
+ - 'app/graphql/types/ci/runner_type.rb'
+ - 'app/graphql/types/commit_type.rb'
+ - 'app/graphql/types/container_registry/protection/rule_type.rb'
+ - 'app/graphql/types/deployment_type.rb'
+ - 'app/graphql/types/design_management/design_at_version_type.rb'
+ - 'app/graphql/types/design_management/design_fields.rb'
+ - 'app/graphql/types/environment_type.rb'
+ - 'app/graphql/types/global_id_type.rb'
+ - 'app/graphql/types/group_type.rb'
+ - 'app/graphql/types/issue_type_enum.rb'
+ - 'app/graphql/types/label_type.rb'
+ - 'app/graphql/types/namespace_type.rb'
+ - 'app/graphql/types/notes/diff_position_base_input_type.rb'
+ - 'app/graphql/types/packages/package_base_type.rb'
+ - 'app/graphql/types/packages/protection/rule_type.rb'
+ - 'app/graphql/types/permission_types/ci/pipeline_schedules.rb'
+ - 'app/graphql/types/project_type.rb'
+ - 'app/graphql/types/query_type.rb'
+ - 'app/graphql/types/root_storage_statistics_type.rb'
- 'app/graphql/types/user_interface.rb'
+ - 'app/graphql/types/work_items/widgets/time_tracking/timelog_input_type.rb'
- 'app/helpers/application_settings_helper.rb'
- 'app/helpers/members_helper.rb'
- - 'app/helpers/preferences_helper.rb'
- 'app/helpers/projects/project_members_helper.rb'
- - 'app/helpers/projects_helper.rb'
+ - 'app/helpers/storage_helper.rb'
+ - 'app/helpers/tags_helper.rb'
+ - 'app/helpers/tree_helper.rb'
+ - 'app/helpers/visibility_level_helper.rb'
- 'app/mailers/emails/projects.rb'
- - 'app/models/application_setting.rb'
- - 'app/models/concerns/bulk_insert_safe.rb'
+ - 'app/models/abuse_report.rb'
+ - 'app/models/bulk_imports/entity.rb'
+ - 'app/models/clusters/agent.rb'
+ - 'app/models/clusters/agents/authorizations/user_access/group_authorization.rb'
+ - 'app/models/clusters/agents/authorizations/user_access/project_authorization.rb'
+ - 'app/models/concerns/integrations/slack_mattermost_fields.rb'
- 'app/models/concerns/spammable.rb'
- - 'app/models/environment.rb'
+ - 'app/models/concerns/taskable.rb'
+ - 'app/models/integrations/bamboo.rb'
+ - 'app/models/integrations/base_third_party_wiki.rb'
+ - 'app/models/integrations/diffblue_cover.rb'
+ - 'app/models/integrations/gitlab_slack_application.rb'
+ - 'app/models/integrations/hangouts_chat.rb'
+ - 'app/models/integrations/irker.rb'
+ - 'app/models/integrations/jira.rb'
- 'app/models/integrations/pivotaltracker.rb'
- - 'app/models/merge_request_diff_commit.rb'
- - 'app/models/postgresql/replication_slot.rb'
- - 'app/services/commits/change_service.rb'
+ - 'app/models/integrations/teamcity.rb'
+ - 'app/models/work_items/parent_link.rb'
+ - 'app/presenters/ci/pipeline_presenter.rb'
+ - 'app/serializers/import/github_failure_entity.rb'
+ - 'app/services/ci/components/fetch_service.rb'
- 'app/services/concerns/ci/job_token_scope/edit_scope_validations.rb'
- 'app/services/feature_flags/update_service.rb'
+ - 'app/services/import/github_service.rb'
+ - 'app/services/integrations/slack_interactions/incident_management/incident_modal_submit_service.rb'
+ - 'app/services/issues/build_service.rb'
+ - 'app/services/issues/convert_to_ticket_service.rb'
+ - 'app/services/jira_connect_subscriptions/create_service.rb'
+ - 'app/services/merge_requests/merge_service.rb'
+ - 'app/services/packages/debian/process_package_file_service.rb'
+ - 'app/services/packages/nuget/odata_package_entry_service.rb'
- 'app/services/projects/after_rename_service.rb'
- - 'app/services/repositories/changelog_service.rb'
+ - 'app/services/security/ci_configuration/base_create_service.rb'
+ - 'app/services/uploads/destroy_service.rb'
+ - 'app/services/users/deactivate_service.rb'
+ - 'app/services/users/email_verification/update_email_service.rb'
- 'app/services/users/email_verification/validate_token_service.rb'
+ - 'app/workers/clusters/applications/deactivate_integration_worker.rb'
+ - 'app/workers/integrations/irker_worker.rb'
+ - 'app/workers/issuable/related_links_create_worker.rb'
- 'app/workers/run_pipeline_schedule_worker.rb'
- - 'config/initializers/validate_database_config.rb'
- - 'config/initializers/wikicloth_disable_lua_patch.rb'
- - 'config/initializers/wikicloth_redos_patch.rb'
- - 'config/initializers/wikicloth_ruby_3_patch.rb'
- - 'danger/database/Dangerfile'
+ - 'config/initializers/check_forced_decomposition.rb'
+ - 'config/initializers/direct_upload_support.rb'
+ - 'config/initializers/safe_session_store_patch.rb'
+ - 'config/initializers/sidekiq.rb'
+ - 'danger/clickhouse/Dangerfile'
+ - 'danger/experiments/Dangerfile'
+ - 'danger/feature_flag/Dangerfile'
+ - 'db/post_migrate/20231124133015_drop_idx_projects_id_created_at_disable_overriding_approvers_false_for_gitlab_com.rb'
+ - 'ee/app/components/namespaces/block_seat_overages/alert_component.rb'
+ - 'ee/app/components/namespaces/combined_storage_users/base_alert_component.rb'
+ - 'ee/app/components/namespaces/combined_storage_users/non_owner_alert_component.rb'
+ - 'ee/app/components/namespaces/combined_storage_users/owner_alert_component.rb'
+ - 'ee/app/components/namespaces/free_user_cap/enforcement_alert_component.rb'
+ - 'ee/app/components/namespaces/free_user_cap/enforcement_at_limit_alert_component.rb'
- 'ee/app/components/namespaces/free_user_cap/usage_quota_alert_component.rb'
- - 'ee/app/controllers/admin/licenses_controller.rb'
+ - 'ee/app/components/namespaces/free_user_cap/usage_quota_trial_alert_component.rb'
+ - 'ee/app/components/namespaces/storage/limit_alert_component.rb'
+ - 'ee/app/components/namespaces/storage/pre_enforcement_alert_component.rb'
+ - 'ee/app/components/namespaces/storage/repository_limit_alert_component.rb'
+ - 'ee/app/components/namespaces/storage/user_pre_enforcement_alert_component.rb'
- 'ee/app/controllers/concerns/insights_actions.rb'
- 'ee/app/controllers/ee/ldap/omniauth_callbacks_controller.rb'
+ - 'ee/app/controllers/subscriptions/trials/duo_pro_controller.rb'
- 'ee/app/finders/geo/framework_registry_finder.rb'
+ - 'ee/app/graphql/ee/mutations/ci/project_ci_cd_settings_update.rb'
+ - 'ee/app/graphql/ee/mutations/issues/create.rb'
+ - 'ee/app/graphql/ee/mutations/merge_requests/update.rb'
+ - 'ee/app/graphql/ee/resolvers/ci/all_jobs_resolver.rb'
+ - 'ee/app/graphql/ee/types/deployment_type.rb'
+ - 'ee/app/graphql/ee/types/group_type.rb'
+ - 'ee/app/graphql/ee/types/merge_request_type.rb'
+ - 'ee/app/graphql/ee/types/namespace_type.rb'
+ - 'ee/app/graphql/ee/types/permission_types/deployment.rb'
+ - 'ee/app/graphql/ee/types/project_statistics_type.rb'
+ - 'ee/app/graphql/ee/types/project_type.rb'
+ - 'ee/app/graphql/ee/types/query_type.rb'
+ - 'ee/app/graphql/ee/types/root_storage_statistics_type.rb'
+ - 'ee/app/graphql/mutations/app_sec/dast/site_profiles/shared_arguments.rb'
+ - 'ee/app/graphql/mutations/audit_events/amazon_s3_configurations/base.rb'
+ - 'ee/app/graphql/mutations/audit_events/google_cloud_logging_configurations/base.rb'
+ - 'ee/app/graphql/mutations/audit_events/google_cloud_logging_configurations/common_update.rb'
+ - 'ee/app/graphql/mutations/audit_events/google_cloud_logging_configurations/create.rb'
+ - 'ee/app/graphql/mutations/audit_events/instance/amazon_s3_configurations/base.rb'
+ - 'ee/app/graphql/mutations/audit_events/instance/google_cloud_logging_configurations/base.rb'
+ - 'ee/app/graphql/mutations/audit_events/instance/google_cloud_logging_configurations/create.rb'
+ - 'ee/app/graphql/mutations/audit_events/streaming/http/namespace_filters/base.rb'
+ - 'ee/app/graphql/mutations/boards/epic_boards/epic_move_list.rb'
+ - 'ee/app/graphql/mutations/dast/profiles/update.rb'
- 'ee/app/graphql/mutations/dast_scanner_profiles/create.rb'
+ - 'ee/app/graphql/mutations/dast_scanner_profiles/update.rb'
+ - 'ee/app/graphql/mutations/dependency_proxy/packages/settings/update.rb'
+ - 'ee/app/graphql/mutations/deployments/deployment_approve.rb'
+ - 'ee/app/graphql/mutations/gitlab_subscriptions/user_add_on_assignments/bulk_create.rb'
+ - 'ee/app/graphql/mutations/gitlab_subscriptions/user_add_on_assignments/bulk_remove.rb'
- 'ee/app/graphql/mutations/issues/set_epic.rb'
- 'ee/app/graphql/mutations/issues/set_escalation_policy.rb'
- 'ee/app/graphql/mutations/issues/set_weight.rb'
- - 'ee/app/graphql/mutations/requirements_management/export_requirements.rb'
- 'ee/app/graphql/mutations/security_policy/assign_security_policy_project.rb'
+ - 'ee/app/graphql/mutations/vulnerabilities/bulk_dismiss.rb'
+ - 'ee/app/graphql/mutations/vulnerabilities/remove_all_from_project.rb'
- 'ee/app/graphql/resolvers/analytics/contribution_analytics/contributions_resolver.rb'
+ - 'ee/app/graphql/resolvers/analytics/value_stream_dashboard/count_resolver.rb'
+ - 'ee/app/graphql/resolvers/ci/runner_usage_by_project_resolver.rb'
+ - 'ee/app/graphql/resolvers/ci/runner_usage_resolver.rb'
+ - 'ee/app/graphql/resolvers/google_cloud/artifact_registry/artifact_resolver.rb'
+ - 'ee/app/graphql/resolvers/pipeline_security_report_findings_resolver.rb'
- 'ee/app/graphql/resolvers/security_orchestration/scan_execution_policy_resolver.rb'
- - 'ee/app/graphql/types/pipeline_security_report_finding_type.rb'
+ - 'ee/app/graphql/resolvers/vulnerabilities_resolver.rb'
+ - 'ee/app/graphql/resolvers/vulnerability_severities_count_resolver.rb'
+ - 'ee/app/graphql/types/ai/prompt/explain_vulnerability_prompt_type.rb'
+ - 'ee/app/graphql/types/ai/prompt/explain_vulnerability_prompt_type/presubmission_check_results_type.rb'
+ - 'ee/app/graphql/types/ai/summarize_new_merge_request_input_type.rb'
+ - 'ee/app/graphql/types/analytics/cycle_analytics/aggregation_status_type.rb'
+ - 'ee/app/graphql/types/analytics/value_stream_dashboard/metric_enum.rb'
+ - 'ee/app/graphql/types/audit_events/google_cloud_logging_configuration_type.rb'
+ - 'ee/app/graphql/types/audit_events/group/namespace_filter_type.rb'
+ - 'ee/app/graphql/types/audit_events/instance/google_cloud_logging_configuration_type.rb'
+ - 'ee/app/graphql/types/audit_events/streaming/http/namespace_filter_type.rb'
+ - 'ee/app/graphql/types/ci/runner_cloud_provisioning_step_type.rb'
+ - 'ee/app/graphql/types/dast/profile_type.rb'
+ - 'ee/app/graphql/types/dast/site_profile_auth_input_type.rb'
+ - 'ee/app/graphql/types/dast/site_profile_auth_type.rb'
+ - 'ee/app/graphql/types/dast_scanner_profile_type.rb'
+ - 'ee/app/graphql/types/dast_site_profile_type.rb'
+ - 'ee/app/graphql/types/epic_type.rb'
+ - 'ee/app/graphql/types/geo/geo_node_type.rb'
+ - 'ee/app/graphql/types/google_cloud/artifact_registry/repository_type.rb'
+ - 'ee/app/graphql/types/protected_environment_type.rb'
+ - 'ee/app/graphql/types/requirements_management/requirement_type.rb'
+ - 'ee/app/graphql/types/sbom/location_type.rb'
+ - 'ee/app/graphql/types/security/finding_reports_comparer/finding_type.rb'
+ - 'ee/app/graphql/types/security_orchestration/policy_any_merge_request_violation_type.rb'
+ - 'ee/app/graphql/types/security_orchestration/policy_violation_error_type_enum.rb'
+ - 'ee/app/graphql/types/security_orchestration/security_policy_relation_type_enum.rb'
+ - 'ee/app/graphql/types/vulnerability_state_enum.rb'
+ - 'ee/app/graphql/types/vulnerability_type.rb'
+ - 'ee/app/helpers/ee/members_helper.rb'
+ - 'ee/app/helpers/groups/trial_discover_page_helper.rb'
+ - 'ee/app/helpers/namespaces/free_user_cap_helper.rb'
- 'ee/app/helpers/push_rules_helper.rb'
- - 'ee/app/models/app_sec/fuzzing/api/ci_configuration.rb'
+ - 'ee/app/helpers/users/identity_verification_helper.rb'
+ - 'ee/app/mailers/ci_minutes_usage_mailer.rb'
- 'ee/app/models/ci/minutes/notification.rb'
- - 'ee/app/models/ee/group_group_link.rb'
+ - 'ee/app/models/concerns/audit_events/gcp_externally_destinationable.rb'
+ - 'ee/app/models/ee/member.rb'
+ - 'ee/app/models/ee/merge_request.rb'
+ - 'ee/app/models/ee/namespace.rb'
- 'ee/app/models/ee/vulnerability.rb'
+ - 'ee/app/models/incident_management/oncall_shift.rb'
+ - 'ee/app/models/integrations/google_cloud_platform/artifact_registry.rb'
+ - 'ee/app/models/members/member_role.rb'
+ - 'ee/app/models/namespaces/block_seat_overages/enforcement.rb'
+ - 'ee/app/models/protected_environment.rb'
+ - 'ee/app/services/audit_events/protected_branch_audit_event_service.rb'
- 'ee/app/services/boards/epic_lists/destroy_service.rb'
- 'ee/app/services/ee/admin/set_feature_flag_service.rb'
- 'ee/app/services/ee/auth/container_registry_authentication_service.rb'
- - 'ee/app/services/ee/issues/move_service.rb'
+ - 'ee/app/services/ee/groups/group_links/create_service.rb'
+ - 'ee/app/services/ee/groups/group_links/destroy_service.rb'
+ - 'ee/app/services/ee/groups/group_links/update_service.rb'
- 'ee/app/services/ee/resource_access_tokens/revoke_service.rb'
- - 'ee/app/services/merge_trains/create_pipeline_service.rb'
+ - 'ee/app/services/epics/epic_links/create_service.rb'
+ - 'ee/app/services/group_saml/saml_group_links/create_service.rb'
+ - 'ee/app/services/groups/sync_service.rb'
+ - 'ee/app/services/phone_verification/telesign_client/base_service.rb'
+ - 'ee/app/services/phone_verification/telesign_client/risk_score_service.rb'
+ - 'ee/app/services/phone_verification/users/send_verification_code_service.rb'
+ - 'ee/app/services/phone_verification/users/verify_code_service.rb'
+ - 'ee/app/services/search/rake_task_executor_service.rb'
+ - 'ee/app/services/security/orchestration/assign_service.rb'
+ - 'ee/app/services/security/token_revocation_service.rb'
- 'ee/app/services/system_notes/epics_service.rb'
- - 'ee/app/workers/concerns/elastic/migration_obsolete.rb'
- - 'ee/lib/api/experiments.rb'
- - 'ee/lib/api/ldap_group_links.rb'
+ - 'ee/app/workers/requirements_management/process_requirements_reports_worker.rb'
+ - 'ee/bin/custom-ability'
+ - 'ee/db/fixtures/development/90_productivity_analytics.rb'
+ - 'ee/elastic/migrate/20230405500000_backfill_wiki_permissions_in_main_index.rb'
+ - 'ee/elastic/migrate/20230415500000_migrate_wikis_to_separate_index.rb'
+ - 'ee/elastic/migrate/20230503064300_backfill_project_permissions_in_blobs_using_permutations.rb'
+ - 'ee/elastic/migrate/20230518064300_backfill_project_permissions_in_blobs.rb'
+ - 'ee/elastic/migrate/20230530500000_migrate_projects_to_separate_index.rb'
+ - 'ee/lib/api/geo_sites.rb'
+ - 'ee/lib/api/iterations.rb'
+ - 'ee/lib/api/protected_environments.rb'
+ - 'ee/lib/api/vulnerability_findings.rb'
+ - 'ee/lib/audit/merge_request_before_destroy_auditor.rb'
+ - 'ee/lib/audit/protected_environment_authorization_rule_changes_auditor.rb'
+ - 'ee/lib/ee/api/features.rb'
+ - 'ee/lib/ee/api/helpers/groups_helpers.rb'
- 'ee/lib/ee/gitlab/auth/ldap/access.rb'
+ - 'ee/lib/ee/gitlab/auth/o_auth/user.rb'
- 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb'
+ - 'ee/lib/ee/gitlab/ci/yaml_processor.rb'
- 'ee/lib/ee/gitlab/git_access.rb'
- - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb'
+ - 'ee/lib/ee/gitlab/namespace_storage_size_error_message.rb'
+ - 'ee/lib/ee/gitlab/pages/deployment_validations.rb'
+ - 'ee/lib/gitlab/checks/secrets_check.rb'
+ - 'ee/lib/gitlab/email/message/account_validation.rb'
+ - 'ee/lib/gitlab/licenses/submit_license_usage_data_banner.rb'
+ - 'ee/lib/gitlab/llm/chain/tools/epic_reader/executor.rb'
+ - 'ee/lib/gitlab/llm/chain/tools/explain_code/executor.rb'
+ - 'ee/lib/gitlab/llm/chain/tools/issue_reader/executor.rb'
+ - 'ee/lib/gitlab/llm/chain/tools/refactor_code/executor.rb'
+ - 'ee/lib/gitlab/llm/chain/tools/summarize_comments/executor.rb'
+ - 'ee/lib/gitlab/llm/chain/tools/write_tests/executor.rb'
+ - 'ee/lib/gitlab/llm/completions/explain_vulnerability.rb'
+ - 'ee/lib/gitlab/llm/completions/resolve_vulnerability.rb'
+ - 'ee/lib/gitlab/status_page/storage.rb'
+ - 'ee/lib/google_cloud/base_client.rb'
+ - 'ee/lib/remote_development/unmatched_result_error.rb'
+ - 'ee/lib/remote_development/workspaces/reconcile/input/agent_infos_observer.rb'
+ - 'ee/lib/security/scan_result_policies/detailed_policy_violation_comment.rb'
+ - 'ee/lib/security/scan_result_policies/policy_violation_details.rb'
+ - 'ee/lib/system_check/geo/clocks_synchronization_check.rb'
+ - 'ee/lib/system_check/geo/ssh_port_check.rb'
+ - 'ee/lib/tasks/gitlab/custom_roles/check_docs_task.rb'
+ - 'ee/lib/tasks/gitlab/elastic.rake'
- 'ee/lib/tasks/gitlab/geo.rake'
- - 'ee/spec/controllers/admin/licenses_controller_spec.rb'
- - 'ee/spec/controllers/groups/group_members_controller_spec.rb'
+ - 'ee/spec/components/namespaces/block_seat_overages/alert_component_spec.rb'
+ - 'ee/spec/components/namespaces/combined_storage_users/non_owner_alert_component_spec.rb'
+ - 'ee/spec/components/namespaces/combined_storage_users/owner_alert_component_spec.rb'
+ - 'ee/spec/components/namespaces/free_user_cap/enforcement_alert_component_spec.rb'
+ - 'ee/spec/components/namespaces/free_user_cap/enforcement_at_limit_alert_component_spec.rb'
+ - 'ee/spec/components/namespaces/free_user_cap/usage_quota_alert_component_spec.rb'
+ - 'ee/spec/components/namespaces/free_user_cap/usage_quota_trial_alert_component_spec.rb'
+ - 'ee/spec/controllers/projects/deploy_keys_controller_spec.rb'
- 'ee/spec/features/admin/admin_emails_spec.rb'
- 'ee/spec/features/admin/licenses/admin_adds_license_spec.rb'
- 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb'
+ - 'ee/spec/features/gitlab_subscriptions/seat_count_alert_spec.rb'
+ - 'ee/spec/features/groups/contribution_analytics_spec.rb'
- 'ee/spec/features/groups/group_overview_spec.rb'
- - 'ee/spec/features/groups/members/manage_groups_spec.rb'
- - 'ee/spec/features/groups_spec.rb'
- - 'ee/spec/features/pending_group_memberships_spec.rb'
+ - 'ee/spec/features/groups/usage_quotas/code_suggestions_usage_tab_spec.rb'
+ - 'ee/spec/features/merge_request/user_merges_with_namespace_storage_limits_spec.rb'
+ - 'ee/spec/features/projects/google_cloud/artifact_registry_spec.rb'
+ - 'ee/spec/features/projects/members/import_project_members_spec.rb'
- 'ee/spec/features/projects/members/manage_groups_spec.rb'
- - 'ee/spec/features/registrations/email_confirmation_spec.rb'
+ - 'ee/spec/features/projects/quality/test_case_show_spec.rb'
+ - 'ee/spec/features/projects/settings/access_tokens_spec.rb'
+ - 'ee/spec/features/projects/show_project_spec.rb'
+ - 'ee/spec/features/protected_branches_spec.rb'
+ - 'ee/spec/features/protected_tags_spec.rb'
- 'ee/spec/graphql/mutations/audit_events/streaming/event_type_filters/destroy_spec.rb'
- 'ee/spec/graphql/mutations/audit_events/streaming/headers/destroy_spec.rb'
- - 'ee/spec/graphql/mutations/boards/lists/update_limit_metrics_spec.rb'
- - 'ee/spec/helpers/ee/labels_helper_spec.rb'
- - 'ee/spec/helpers/push_rules_helper_spec.rb'
- - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb'
+ - 'ee/spec/graphql/mutations/deployments/deployment_approve_spec.rb'
+ - 'ee/spec/graphql/mutations/requirements_management/export_requirements_spec.rb'
+ - 'ee/spec/helpers/ee/groups_helper_spec.rb'
+ - 'ee/spec/helpers/ee/profiles_helper_spec.rb'
+ - 'ee/spec/helpers/routing/pseudonymization_helper_spec.rb'
+ - 'ee/spec/helpers/users/identity_verification_helper_spec.rb'
+ - 'ee/spec/lib/audit/merge_request_before_destroy_auditor_spec.rb'
+ - 'ee/spec/lib/audit/merge_request_destroy_auditor_spec.rb'
+ - 'ee/spec/lib/audit/protected_environment_authorization_rule_changes_auditor_spec.rb'
+ - 'ee/spec/lib/banzai/filter/issuable_reference_expansion_filter_spec.rb'
- 'ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
- 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/ci/status/build/manual_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/namespace_storage_size_error_message_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/config/entry/secret_spec.rb'
- 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/api_security_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/api_security_latest_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/container_scanning_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/container_scanning_latest_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_latest_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/dast_api_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/dast_api_latest_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/dast_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/dast_latest_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/dependency_scanning_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/dependency_scanning_latest_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/sast_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/sast_iac_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/sast_latest_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/secret_detection_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/ci/templates/secret_detection_latest_gitlab_ci_yaml_spec.rb'
- - 'ee/spec/lib/gitlab/manual_quarterly_co_term_banner_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/Security/bas_latest_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/templates/api_discovery_gitlab_ci_yaml_spec.rb'
+ - 'ee/spec/lib/gitlab/ci/yaml_processor_spec.rb'
+ - 'ee/spec/lib/gitlab/database/desired_sharding_key_spec.rb'
+ - 'ee/spec/lib/gitlab/geo/every_repository_type_replicated_spec.rb'
+ - 'ee/spec/lib/gitlab/git_access_spec.rb'
+ - 'ee/spec/lib/gitlab/licenses/submit_license_usage_data_banner_spec.rb'
+ - 'ee/spec/lib/gitlab/llm/chain/agents/zero_shot/qa_evaluation_spec.rb'
+ - 'ee/spec/lib/gitlab/llm/chain/tools/refactor_code/executor_spec.rb'
+ - 'ee/spec/lib/gitlab/llm/chain/tools/summarize_comments/executor_spec.rb'
+ - 'ee/spec/lib/gitlab/llm/completions/chat_real_requests_spec.rb'
+ - 'ee/spec/lib/gitlab/package_metadata/connector/base_data_file_spec.rb'
+ - 'ee/spec/lib/gitlab/subscription_portal/clients/graphql_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_deployment_approvals_metric_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environments_required_approvals_average_metric_spec.rb'
- - 'ee/spec/mailers/ee/emails/identity_verification_spec.rb'
- - 'ee/spec/requests/api/analytics/product_analytics_spec.rb'
+ - 'ee/spec/lib/gitlab/vulnerability_scanning/security_report_builder_spec.rb'
+ - 'ee/spec/lib/remote_development/namespace_cluster_agent_mappings/create/main_integration_spec.rb'
+ - 'ee/spec/lib/remote_development/rd_fast_spec_helper.rb'
+ - 'ee/spec/lib/remote_development/workspaces/create/devfile_flattener_spec.rb'
+ - 'ee/spec/lib/remote_development/workspaces/create/workspace_creator_spec.rb'
+ - 'ee/spec/lib/remote_development/workspaces/reconcile/input/agent_infos_observer_spec.rb'
+ - 'ee/spec/lib/security/scan_result_policies/detailed_policy_violation_comment_spec.rb'
+ - 'ee/spec/lib/security/scan_result_policies/policy_violation_details_spec.rb'
+ - 'ee/spec/mailers/emails/abandoned_trial_notification_spec.rb'
+ - 'ee/spec/mailers/emails/block_seat_overages_spec.rb'
+ - 'ee/spec/models/dependency_proxy/packages/setting_spec.rb'
+ - 'ee/spec/models/members/member_role_spec.rb'
+ - 'ee/spec/models/product_analytics/dashboard_spec.rb'
+ - 'ee/spec/models/product_analytics/visualization_spec.rb'
+ - 'ee/spec/models/sbom/occurrence_spec.rb'
+ - 'ee/spec/presenters/ci/build_presenter_spec.rb'
+ - 'ee/spec/requests/api/gitlab_subscriptions/add_on_purchases_spec.rb'
+ - 'ee/spec/requests/api/graphql/ai_messages_spec.rb'
+ - 'ee/spec/requests/api/graphql/audit_events/instance/event_type_filters/delete_spec.rb'
+ - 'ee/spec/requests/api/graphql/audit_events/streaming/http/namespace_filters/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/audit_events/streaming/http/namespace_filters/delete_spec.rb'
+ - 'ee/spec/requests/api/graphql/audit_events/streaming/instance_event_type_filters/destroy_spec.rb'
+ - 'ee/spec/requests/api/graphql/ci/runner_usage_by_project_spec.rb'
+ - 'ee/spec/requests/api/graphql/ci/runner_usage_spec.rb'
+ - 'ee/spec/requests/api/graphql/environments/deployments_spec.rb'
+ - 'ee/spec/requests/api/graphql/gitlab_subscriptions/add_on_eligible_users_spec.rb'
+ - 'ee/spec/requests/api/graphql/gitlab_subscriptions/self_managed/add_on_eligible_users_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/audit_events/amazon_s3_configurations/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/audit_events/amazon_s3_configurations/delete_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/audit_events/google_cloud_logging_configurations/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/audit_events/google_cloud_logging_configurations/destroy_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/audit_events/instance/amazon_s3_configurations/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/audit_events/instance/amazon_s3_configurations/delete_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/audit_events/instance/google_cloud_logging_configurations/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/audit_events/instance/google_cloud_logging_configurations/destroy_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/boards/lists/update_limit_metrics_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/boards/update_epic_user_preferences_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/ci/project_subscriptions/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/ci/project_subscriptions/delete_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/ci/runners/export_usage_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/dast_on_demand_scans/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/dast_site_profiles/delete_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/dast_site_profiles/update_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/epics/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/epics/update_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/issues/bulk_update_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/issues/promote_to_epic_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/issues/set_epic_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/issues/set_weight_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/iterations/cadences/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/destroy_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/iterations/cadences/update_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/iterations/delete_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/iterations/update_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/member_role/create_member_role_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/projects/initialize_product_analytics_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/projects/product_analytics_project_settings_update_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/projects/set_compliance_framework_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/quality_management/test_cases/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/remote_development/namespace_cluster_agent_mappings/create_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/remote_development/namespace_cluster_agent_mappings/delete_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/requirements_management/create_requirement_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/security/finding/create_issue_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/users/abuse/namespace_bans/destroy_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/bulk_dismiss_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/create_issue_link_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/destroy_external_issue_link_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/work_items/convert_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/work_items/update_spec.rb'
+ - 'ee/spec/requests/api/graphql/product_analytics/visualizations_spec.rb'
+ - 'ee/spec/requests/api/graphql/project/google_cloud/artifact_registry/docker_images_spec.rb'
+ - 'ee/spec/requests/api/graphql/vulnerabilities/fields_spec.rb'
+ - 'ee/spec/requests/api/internal/base_spec.rb'
+ - 'ee/spec/requests/api/invitations_spec.rb'
+ - 'ee/spec/requests/api/member_roles_spec.rb'
+ - 'ee/spec/requests/api/members_spec.rb'
+ - 'ee/spec/requests/api/projects_spec.rb'
+ - 'ee/spec/requests/groups/protected_environments_controller_spec.rb'
+ - 'ee/spec/requests/subscriptions/trials/duo_pro_controller_spec.rb'
+ - 'ee/spec/requests/subscriptions/trials_controller_spec.rb'
+ - 'ee/spec/requests/users/registrations_identity_verification_controller_spec.rb'
+ - 'ee/spec/serializers/integrations/field_entity_spec.rb'
+ - 'ee/spec/services/ai/store_repository_xray_service_spec.rb'
- 'ee/spec/services/boards/epic_lists/destroy_service_spec.rb'
+ - 'ee/spec/services/ci/destroy_pipeline_service_spec.rb'
+ - 'ee/spec/services/clusters/agent_tokens/create_service_audit_log_spec.rb'
+ - 'ee/spec/services/clusters/agent_tokens/revoke_service_audit_log_spec.rb'
- 'ee/spec/services/ee/auth/container_registry_authentication_service_spec.rb'
- - 'ee/spec/services/ee/resource_events/merge_into_notes_service_spec.rb'
+ - 'ee/spec/services/ee/commits/create_service_spec.rb'
+ - 'ee/spec/services/ee/groups/group_links/update_service_spec.rb'
+ - 'ee/spec/services/ee/members/import_project_team_service_spec.rb'
+ - 'ee/spec/services/ee/members/invite_service_spec.rb'
+ - 'ee/spec/services/ee/post_receive_service_spec.rb'
+ - 'ee/spec/services/ee/work_items/related_work_item_links/create_service_spec.rb'
+ - 'ee/spec/services/epic_issues/create_service_spec.rb'
- 'ee/spec/services/epics/epic_links/create_service_spec.rb'
- 'ee/spec/services/geo/container_repository_sync_spec.rb'
+ - 'ee/spec/services/gitlab_subscriptions/add_on_purchases/create_service_spec.rb'
+ - 'ee/spec/services/gitlab_subscriptions/add_on_purchases/update_service_spec.rb'
+ - 'ee/spec/services/llm/git_command_service_spec.rb'
+ - 'ee/spec/services/merge_requests/merge_service_spec.rb'
- 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb'
- - 'ee/spec/services/users/abuse/git_abuse/application_throttle_service_spec.rb'
- - 'ee/spec/support/shared_examples/finders/geo/framework_registry_finder_shared_examples.rb'
- - 'ee/spec/support/shared_examples/graphql/geo/geo_registries_resolver_shared_examples.rb'
- - 'ee/spec/support/shared_examples/models/license_shared_examples.rb'
+ - 'ee/spec/services/package_metadata/advisory_data_object_spec.rb'
+ - 'ee/spec/services/package_metadata/data_object_fabricator_spec.rb'
+ - 'ee/spec/services/phone_verification/telesign_client/risk_score_service_spec.rb'
+ - 'ee/spec/services/phone_verification/telesign_client/send_verification_code_service_spec.rb'
+ - 'ee/spec/services/phone_verification/users/send_verification_code_service_spec.rb'
+ - 'ee/spec/services/phone_verification/users/verify_code_service_spec.rb'
+ - 'ee/spec/services/product_analytics/cube_data_query_service_spec.rb'
+ - 'ee/spec/services/protected_environments/update_service_spec.rb'
+ - 'ee/spec/services/security/security_orchestration_policies/ci_action/custom_spec.rb'
+ - 'ee/spec/services/security/security_orchestration_policies/ci_action/template_spec.rb'
+ - 'ee/spec/services/security/token_revocation_service_spec.rb'
+ - 'ee/spec/support/llm.rb'
+ - 'ee/spec/support/shared_contexts/code_suggestions/programming_language_shared_context.rb'
+ - 'ee/spec/support/shared_examples/lib/gitlab/llm/chain/slash_command_tool_shared_examples.rb'
+ - 'ee/spec/support/shared_examples/lib/gitlab/secrets_check_shared_examples.rb'
+ - 'ee/spec/support/shared_examples/requests/api/graphql/ci/queueing_history_shared_examples.rb'
+ - 'ee/spec/support/shared_examples/requests/identity_verification_shared_examples.rb'
+ - 'ee/spec/support/shared_examples/services/audit_events/streaming/headers_operations_shared_examples.rb'
+ - 'ee/spec/tasks/duo_pro/bulk_user_assignment_spec.rb'
+ - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb'
+ - 'ee/spec/uploaders/every_gitlab_uploader_spec.rb'
+ - 'ee/spec/views/admin/application_settings/_ee_package_registry.html.haml_spec.rb'
- 'ee/spec/views/groups/billings/index.html.haml_spec.rb'
- - 'ee/spec/workers/ee/issuable_export_csv_worker_spec.rb'
+ - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb'
+ - 'ee/spec/views/subscriptions/trials/duo_pro/_advantages_list.html.haml_spec.rb'
+ - 'ee/spec/workers/groups/enterprise_users/bulk_associate_by_domain_worker_spec.rb'
+ - 'ee/spec/workers/vulnerabilities/mark_dropped_as_resolved_worker_spec.rb'
+ - 'lib/api/ci/job_artifacts.rb'
+ - 'lib/api/ci/runner.rb'
- 'lib/api/ci/runners.rb'
- - 'lib/api/dependency_proxy.rb'
- - 'lib/api/error_tracking/client_keys.rb'
- 'lib/api/error_tracking/project_settings.rb'
- - 'lib/api/go_proxy.rb'
- - 'lib/api/helpers/pagination_strategies.rb'
+ - 'lib/api/feature_flags_user_lists.rb'
+ - 'lib/api/features.rb'
+ - 'lib/api/freeze_periods.rb'
+ - 'lib/api/groups.rb'
- 'lib/api/issue_links.rb'
+ - 'lib/api/metadata.rb'
- 'lib/api/metrics/dashboard/annotations.rb'
+ - 'lib/api/ml/mlflow/registered_models.rb'
+ - 'lib/api/ml/mlflow/runs.rb'
+ - 'lib/api/releases.rb'
+ - 'lib/api/validations/validators/bulk_imports.rb'
- 'lib/backup/manager.rb'
+ - 'lib/backup/remote_storage.rb'
+ - 'lib/banzai/filter/dollar_math_pre_legacy_filter.rb'
- 'lib/banzai/filter/spaced_link_filter.rb'
+ - 'lib/bulk_imports/error.rb'
- 'lib/feature/definition.rb'
- - 'lib/gitlab/audit/type/definition.rb'
- - 'lib/gitlab/auth.rb'
- - 'lib/gitlab/background_migration/populate_operation_visibility_permissions_from_operations.rb'
- - 'lib/gitlab/changelog/config.rb'
+ - 'lib/feature/shared.rb'
+ - 'lib/generators/gitlab/analytics/internal_events_generator.rb'
+ - 'lib/gitlab/audit/auditor.rb'
+ - 'lib/gitlab/auth/ldap/access.rb'
+ - 'lib/gitlab/auth/user_access_denied_reason.rb'
+ - 'lib/gitlab/background_migration/backfill_partitioned_table.rb'
+ - 'lib/gitlab/checks/tag_check.rb'
+ - 'lib/gitlab/ci/build/rules/rule/clause/exists.rb'
+ - 'lib/gitlab/ci/config/entry/default.rb'
+ - 'lib/gitlab/ci/config/external/mapper/matcher.rb'
+ - 'lib/gitlab/ci/config/interpolation/functions_stack.rb'
- 'lib/gitlab/ci/parsers/security/validators/schema_validator.rb'
- - 'lib/gitlab/ci/pipeline/chain/populate.rb'
- - 'lib/gitlab/ci/pipeline/seed/build.rb'
- - 'lib/gitlab/database/load_balancing/sidekiq_server_middleware.rb'
- - 'lib/gitlab/database/migration_helpers.rb'
- - 'lib/gitlab/database/migration_helpers/restrict_gitlab_schema.rb'
- - 'lib/gitlab/database/migrations/background_migration_helpers.rb'
- - 'lib/gitlab/database/migrations/batched_background_migration_helpers.rb'
- - 'lib/gitlab/database/partitioning/partition_manager.rb'
+ - 'lib/gitlab/ci/status/build/scheduled.rb'
+ - 'lib/gitlab/ci/yaml_processor.rb'
+ - 'lib/gitlab/config/entry/node.rb'
+ - 'lib/gitlab/config_checker/external_database_checker.rb'
+ - 'lib/gitlab/database/background_migration/batched_migration_runner.rb'
+ - 'lib/gitlab/database/decomposition/migrate.rb'
+ - 'lib/gitlab/database/dictionary.rb'
+ - 'lib/gitlab/database/gitlab_schema.rb'
+ - 'lib/gitlab/database/migration_helpers/wraparound_vacuum_helpers.rb'
+ - 'lib/gitlab/database/migrations/pg_backend_pid.rb'
+ - 'lib/gitlab/database/migrations/sidekiq_helpers.rb'
- 'lib/gitlab/database/partitioning/sliding_list_strategy.rb'
- - 'lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table.rb'
- - 'lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers.rb'
- - 'lib/gitlab/database/partitioning_migration_helpers/index_helpers.rb'
- - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb'
- - 'lib/gitlab/database/schema_helpers.rb'
- - 'lib/gitlab/database/shared_model.rb'
+ - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb'
+ - 'lib/gitlab/database/query_analyzers/restrict_allowed_schemas.rb'
- 'lib/gitlab/github_import/importer/events/changed_reviewer.rb'
- - 'lib/gitlab/graphql/authorize/authorize_resource.rb'
+ - 'lib/gitlab/hook_data/base_builder.rb'
- 'lib/gitlab/i18n/po_linter.rb'
- - 'lib/gitlab/import_export/project/import_task.rb'
+ - 'lib/gitlab/internal_events.rb'
+ - 'lib/gitlab/mailgun/webhook_processors/member_invites.rb'
+ - 'lib/gitlab/pages/deployment_validations.rb'
- 'lib/gitlab/path_regex.rb'
- - 'lib/gitlab/reference_counter.rb'
- 'lib/gitlab/regex.rb'
- - 'lib/gitlab/seeders/ci/runner/runner_fleet_seeder.rb'
- - 'lib/gitlab/slash_commands/presenters/run.rb'
- - 'lib/gitlab/tracking/standard_context.rb'
- - 'lib/tasks/gitlab/db/validate_config.rake'
- - 'qa/qa/ee/page/project/settings/services/jira.rb'
- - 'qa/qa/specs/features/api/4_verify/api_variable_inheritance_with_forward_pipeline_variables_spec.rb'
+ - 'lib/gitlab/security/features.rb'
+ - 'lib/gitlab/sidekiq_config/worker_router.rb'
+ - 'lib/gitlab/sidekiq_signals.rb'
+ - 'lib/gitlab/slash_commands/presenters/deploy.rb'
+ - 'lib/gitlab/slash_commands/verify_request.rb'
+ - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb'
+ - 'lib/peek/views/memory.rb'
+ - 'lib/result.rb'
+ - 'lib/slack/block_kit/app_home_opened.rb'
+ - 'lib/slack/manifest.rb'
+ - 'lib/tasks/gitlab/audit_event_types/check_docs_task.rb'
+ - 'lib/tasks/gitlab/click_house/migration.rake'
+ - 'lib/tasks/gitlab/tw/codeowners.rake'
+ - 'lib/tasks/migrate/schema_check.rake'
+ - 'lib/users/internal.rb'
+ - 'qa/qa/ee/flow/product_analytics.rb'
+ - 'qa/qa/ee/page/project/analyze/analytics_dashboards/dashboard.rb'
+ - 'qa/qa/ee/page/project/analyze/analytics_dashboards/setup.rb'
+ - 'qa/qa/ee/page/project/analyze/dashboard_setup.rb'
+ - 'qa/qa/ee/page/project/secure/new_on_demand_scan.rb'
+ - 'qa/qa/ee/page/project/secure/pipeline_security.rb'
+ - 'qa/qa/ee/page/project/secure/vulnerability_details.rb'
+ - 'qa/qa/ee/resource/license.rb'
+ - 'qa/qa/ee/scenario/test/geo.rb'
+ - 'qa/qa/page/admin/overview/users/index.rb'
+ - 'qa/qa/page/base.rb'
+ - 'qa/qa/page/sub_menus/super_sidebar/global_search_modal.rb'
+ - 'qa/qa/scenario/shared_attributes.rb'
+ - 'qa/qa/service/docker_run/product_analytics/browser_sdk_app.rb'
+ - 'qa/qa/service/docker_run/product_analytics/dotnet_sdk_app.rb'
+ - 'qa/qa/service/docker_run/webgoat.rb'
+ - 'qa/qa/specs/features/ee/api/10_govern/compliance_pipeline_spec.rb'
+ - 'qa/qa/specs/features/ee/api/9_data_stores/elasticsearch/nightly_elasticsearch_test_spec.rb'
+ - 'qa/qa/specs/features/ee/browser_ui/10_govern/export_vulnerability_report_spec.rb'
+ - 'qa/qa/specs/features/ee/browser_ui/9_data_stores/elasticsearch/elasticsearch_reindexing_spec.rb'
+ - 'qa/qa/support/audit_event_streaming_service.rb'
+ - 'qa/qa/support/formatters/test_metrics_formatter.rb'
- 'qa/qa/support/system_logs/kibana.rb'
+ - 'qa/qa/tools/reliable_report.rb'
- 'qa/qa/tools/revoke_user_personal_access_tokens.rb'
+ - 'qa/qa/tools/test_resources_handler.rb'
+ - 'qa/spec/resource/user_spec.rb'
- 'qa/spec/support/page_error_checker_spec.rb'
- 'qa/spec/support/system_logs/kibana_spec.rb'
- - 'rubocop/cop/active_record_association_reload.rb'
- - 'rubocop/cop/api/grape_array_missing_coerce.rb'
- - 'rubocop/cop/avoid_becomes.rb'
- - 'rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb'
- - 'rubocop/cop/database/establish_connection.rb'
- - 'rubocop/cop/destroy_all.rb'
- - 'rubocop/cop/gitlab/avoid_feature_get.rb'
- - 'rubocop/cop/gitlab/change_timezone.rb'
- - 'rubocop/cop/gitlab/keys_first_and_values_first.rb'
- - 'rubocop/cop/gitlab/rails_logger.rb'
+ - 'rubocop/check_graceful_task.rb'
+ - 'rubocop/cop/api/base.rb'
+ - 'rubocop/cop/background_migration/avoid_silent_rescue_exceptions.rb'
+ - 'rubocop/cop/background_migration/feature_category.rb'
+ - 'rubocop/cop/database/avoid_using_pluck_without_limit.rb'
+ - 'rubocop/cop/gitlab/avoid_current_organization.rb'
+ - 'rubocop/cop/gitlab/avoid_gitlab_instance_checks.rb'
+ - 'rubocop/cop/gitlab/doc_url.rb'
+ - 'rubocop/cop/gitlab/license_available_usage.rb'
+ - 'rubocop/cop/gitlab/rails/safe_format.rb'
- 'rubocop/cop/gitlab/rspec/avoid_setup.rb'
- - 'rubocop/cop/graphql/descriptions.rb'
- - 'rubocop/cop/graphql/resolver_type.rb'
- - 'rubocop/cop/group_public_or_visible_to_user.rb'
+ - 'rubocop/cop/gitlab/token_without_prefix.rb'
+ - 'rubocop/cop/graphql/authorize_types.rb'
+ - 'rubocop/cop/graphql/enum_values.rb'
+ - 'rubocop/cop/graphql/graphql_name_position.rb'
+ - 'rubocop/cop/graphql/json_type.rb'
- 'rubocop/cop/inject_enterprise_edition_module.rb'
- - 'rubocop/cop/migration/add_concurrent_index.rb'
+ - 'rubocop/cop/migration/add_columns_to_wide_tables.rb'
- 'rubocop/cop/migration/add_limit_to_text_columns.rb'
- - 'rubocop/cop/migration/create_table_with_foreign_keys.rb'
- - 'rubocop/cop/migration/prevent_strings.rb'
- - 'rubocop/cop/migration/remove_concurrent_index.rb'
- - 'rubocop/cop/migration/with_lock_retries_with_change.rb'
- - 'rubocop/cop/performance/active_record_subtransaction_methods.rb'
- - 'rubocop/cop/performance/active_record_subtransactions.rb'
+ - 'rubocop/cop/migration/avoid_finalize_background_migration.rb'
+ - 'rubocop/cop/migration/background_migrations.rb'
+ - 'rubocop/cop/migration/change_column_null_on_high_traffic_table.rb'
+ - 'rubocop/cop/migration/prevent_index_creation.rb'
+ - 'rubocop/cop/migration/prevent_single_statement_with_disable_ddl_transaction.rb'
+ - 'rubocop/cop/migration/versioned_migration_class.rb'
- 'rubocop/cop/performance/ar_count_each.rb'
- 'rubocop/cop/performance/ar_exists_and_present_blank.rb'
- - 'rubocop/cop/performance/readlines_each.rb'
- - 'rubocop/cop/project_path_helper.rb'
- - 'rubocop/cop/redis_queue_usage.rb'
- - 'rubocop/cop/rspec/factory_bot/inline_association.rb'
- - 'rubocop/cop/rspec/factory_bot/strategy_in_callback.rb'
+ - 'rubocop/cop/rspec/avoid_conditional_statements.rb'
+ - 'rubocop/cop/rspec/avoid_test_prof.rb'
+ - 'rubocop/cop/rspec/expect_gitlab_tracking.rb'
+ - 'rubocop/cop/rspec/have_gitlab_http_status.rb'
+ - 'rubocop/cop/scalability/file_uploads.rb'
- 'rubocop/cop/sidekiq_api_usage.rb'
- - 'rubocop/cop/user_admin.rb'
- - 'scripts/lib/glfm/parse_examples.rb'
+ - 'rubocop/cop/sidekiq_load_balancing/worker_data_consistency.rb'
+ - 'rubocop/feature_categories.rb'
+ - 'scripts/failed_tests.rb'
+ - 'scripts/flaky_examples/prune-old-flaky-examples'
+ - 'scripts/generate_rspec_pipeline.rb'
+ - 'scripts/internal_events/cli.rb'
+ - 'scripts/internal_events/cli/event_definer.rb'
- 'scripts/lib/glfm/update_example_snapshots.rb'
- 'scripts/lib/glfm/update_specification.rb'
- 'scripts/lib/glfm/verify_all_generated_files_are_up_to_date.rb'
- - 'scripts/packages/automated_cleanup.rb'
+ - 'scripts/lint-docs-redirects.rb'
+ - 'scripts/process_custom_semgrep_results.rb'
+ - 'scripts/qa/testcases-check'
+ - 'scripts/trigger-build.rb'
+ - 'spec/contracts/provider_specs/helpers/provider/contract_source_helper_spec.rb'
+ - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb'
- 'spec/controllers/graphql_controller_spec.rb'
- - 'spec/controllers/projects/deploy_keys_controller_spec.rb'
+ - 'spec/controllers/import/github_controller_spec.rb'
+ - 'spec/controllers/projects/artifacts_controller_spec.rb'
+ - 'spec/controllers/projects/jobs_controller_spec.rb'
+ - 'spec/controllers/user_settings/profiles_controller_spec.rb'
+ - 'spec/features/groups/show_spec.rb'
+ - 'spec/features/invites_spec.rb'
+ - 'spec/features/issues/create_issue_for_single_discussion_in_merge_request_spec.rb'
+ - 'spec/features/merge_request/user_sees_merge_widget_spec.rb'
- 'spec/features/projects/files/user_browses_files_spec.rb'
- 'spec/features/projects/files/user_creates_directory_spec.rb'
- 'spec/features/projects/files/user_creates_files_spec.rb'
- 'spec/features/projects/files/user_deletes_files_spec.rb'
+ - 'spec/features/projects/files/user_edits_files_spec.rb'
- 'spec/features/projects/files/user_replaces_files_spec.rb'
- 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb'
+ - 'spec/features/projects/jobs_spec.rb'
+ - 'spec/features/projects/members/import_project_members_spec.rb'
- 'spec/features/projects/pipelines/pipeline_spec.rb'
- - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb'
- - 'spec/helpers/markup_helper_spec.rb'
+ - 'spec/features/user_settings/active_sessions_spec.rb'
+ - 'spec/features/users/email_verification_on_login_spec.rb'
+ - 'spec/features/users/login_spec.rb'
+ - 'spec/graphql/mutations/environments/canary_ingress/update_spec.rb'
+ - 'spec/graphql/mutations/merge_requests/update_spec.rb'
+ - 'spec/graphql/resolvers/timelog_resolver_spec.rb'
+ - 'spec/graphql/types/ci/job_trace_type_spec.rb'
+ - 'spec/graphql/types/project_type_spec.rb'
+ - 'spec/helpers/appearances_helper_spec.rb'
+ - 'spec/helpers/application_settings_helper_spec.rb'
+ - 'spec/helpers/emails_helper_spec.rb'
+ - 'spec/helpers/form_helper_spec.rb'
+ - 'spec/lib/banzai/filter/issuable_reference_expansion_filter_spec.rb'
- 'spec/lib/banzai/filter/truncate_visible_filter_spec.rb'
- - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb'
+ - 'spec/lib/bulk_imports/projects/pipelines/design_bundle_pipeline_spec.rb'
+ - 'spec/lib/bulk_imports/projects/pipelines/repository_bundle_pipeline_spec.rb'
+ - 'spec/lib/click_house/query_builder_spec.rb'
+ - 'spec/lib/error_tracking/sentry_client/issue_spec.rb'
+ - 'spec/lib/feature/definition_spec.rb'
+ - 'spec/lib/gitlab/audit/auditor_spec.rb'
+ - 'spec/lib/gitlab/auth/ldap/access_spec.rb'
+ - 'spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb'
+ - 'spec/lib/gitlab/checks/tag_check_spec.rb'
- 'spec/lib/gitlab/ci/ansi2html_spec.rb'
- - 'spec/lib/gitlab/ci/parsers/sbom/validators/cyclonedx_schema_validator_spec.rb'
+ - 'spec/lib/gitlab/ci/build/rules/rule/clause/exists_spec.rb'
+ - 'spec/lib/gitlab/ci/components/usages/aggregators/cursor_spec.rb'
+ - 'spec/lib/gitlab/ci/config/external/file/remote_spec.rb'
+ - 'spec/lib/gitlab/ci/config/interpolation/interpolator_spec.rb'
+ - 'spec/lib/gitlab/ci/config/yaml/loader_spec.rb'
- 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb'
- - 'spec/lib/gitlab/ci/pipeline/chain/populate_spec.rb'
- 'spec/lib/gitlab/ci/status/bridge/factory_spec.rb'
- - 'spec/lib/gitlab/ci/templates/Jobs/code_quality_gitlab_ci_yaml_spec.rb'
- - 'spec/lib/gitlab/ci/templates/Jobs/sast_iac_gitlab_ci_yaml_spec.rb'
- - 'spec/lib/gitlab/ci/templates/Jobs/sast_iac_latest_gitlab_ci_yaml_spec.rb'
- - 'spec/lib/gitlab/ci/templates/Jobs/test_gitlab_ci_yaml_spec.rb'
- - 'spec/lib/gitlab/ci/templates/npm_spec.rb'
- - 'spec/lib/gitlab/ci/templates/themekit_gitlab_ci_yaml_spec.rb'
+ - 'spec/lib/gitlab/ci/status/build/manual_spec.rb'
+ - 'spec/lib/gitlab/ci/status/stage/play_manual_spec.rb'
+ - 'spec/lib/gitlab/ci/templates/terraform_latest_gitlab_ci_yaml_spec.rb'
+ - 'spec/lib/gitlab/ci/trace/stream_spec.rb'
+ - 'spec/lib/gitlab/ci/variables/downstream/generator_spec.rb'
+ - 'spec/lib/gitlab/closing_issue_extractor_spec.rb'
+ - 'spec/lib/gitlab/config_checker/external_database_checker_spec.rb'
- 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb'
+ - 'spec/lib/gitlab/database/dictionary_spec.rb'
+ - 'spec/lib/gitlab/database/gitlab_schema_spec.rb'
+ - 'spec/lib/gitlab/database/migration_helpers/automatic_lock_writes_on_tables_spec.rb'
+ - 'spec/lib/gitlab/database/migration_helpers_spec.rb'
- 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb'
+ - 'spec/lib/gitlab/database/no_cross_db_foreign_keys_spec.rb'
+ - 'spec/lib/gitlab/database/no_overrides_for_through_associations_spec.rb'
+ - 'spec/lib/gitlab/database/sharding_key_spec.rb'
+ - 'spec/lib/gitlab/diff/char_diff_spec.rb'
+ - 'spec/lib/gitlab/git_access_spec.rb'
+ - 'spec/lib/gitlab/github_import/importer/single_endpoint_issue_events_importer_spec.rb'
- 'spec/lib/gitlab/github_import/markdown_text_spec.rb'
- - 'spec/lib/gitlab/github_import/representation/issue_event_spec.rb'
+ - 'spec/lib/gitlab/import_export/group/relation_tree_restorer_spec.rb'
- 'spec/lib/gitlab/insecure_key_fingerprint_spec.rb'
- - 'spec/lib/gitlab/redis/multi_store_spec.rb'
- - 'spec/lib/gitlab/reference_counter_spec.rb'
+ - 'spec/lib/gitlab/query_limiting/transaction_spec.rb'
+ - 'spec/lib/gitlab/security/scan_configuration_spec.rb'
+ - 'spec/lib/gitlab/ssh_public_key_spec.rb'
- 'spec/lib/gitlab/usage/metrics/instrumentations/count_bulk_imports_entities_metric_spec.rb'
- 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_metric_spec.rb'
- 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric_spec.rb'
- 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_direct_installations_count_metric_spec.rb'
- 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_proxy_installations_count_metric_spec.rb'
- 'spec/lib/gitlab/utils/gzip_spec.rb'
- - 'spec/mailers/emails/identity_verification_spec.rb'
- - 'spec/mailers/emails/projects_spec.rb'
- - 'spec/models/active_session_spec.rb'
- - 'spec/models/integrations/chat_message/note_message_spec.rb'
- - 'spec/models/integrations/chat_message/pipeline_message_spec.rb'
- - 'spec/models/integrations/chat_message/push_message_spec.rb'
- - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb'
- - 'spec/models/member_spec.rb'
- - 'spec/models/operations/feature_flags_client_spec.rb'
+ - 'spec/lib/rouge/formatters/html_gitlab_spec.rb'
+ - 'spec/lib/slack/manifest_spec.rb'
+ - 'spec/lib/system_check/incoming_email/imap_authentication_check_spec.rb'
+ - 'spec/mailers/notify_spec.rb'
+ - 'spec/models/application_setting_spec.rb'
+ - 'spec/models/ci/catalog/resources/component_spec.rb'
+ - 'spec/models/diff_note_spec.rb'
+ - 'spec/models/integrations/chat_message/group_mention_message_spec.rb'
+ - 'spec/models/integrations/chat_message/merge_message_spec.rb'
+ - 'spec/models/integrations/gitlab_slack_application_spec.rb'
+ - 'spec/models/integrations/teamcity_spec.rb'
+ - 'spec/models/integrations/youtrack_spec.rb'
+ - 'spec/models/issue_spec.rb'
+ - 'spec/models/key_spec.rb'
+ - 'spec/models/note_spec.rb'
+ - 'spec/models/project_spec.rb'
- 'spec/models/ssh_host_key_spec.rb'
- 'spec/presenters/ci/pipeline_presenter_spec.rb'
- - 'spec/presenters/deploy_key_presenter_spec.rb'
- - 'spec/presenters/key_presenter_spec.rb'
+ - 'spec/presenters/commit_status_presenter_spec.rb'
+ - 'spec/presenters/deployments/deployment_presenter_spec.rb'
- 'spec/presenters/releases/link_presenter_spec.rb'
- - 'spec/requests/api/graphql/mutations/clusters/agents/delete_spec.rb'
+ - 'spec/requests/api/bulk_imports_spec.rb'
+ - 'spec/requests/api/ci/job_artifacts_spec.rb'
+ - 'spec/requests/api/graphql/mutations/achievements/update_user_achievement_priorities_spec.rb'
+ - 'spec/requests/api/graphql/mutations/ci/runner/create_spec.rb'
+ - 'spec/requests/api/graphql/mutations/clusters/agent_tokens/agent_tokens/create_spec.rb'
+ - 'spec/requests/api/graphql/mutations/container_registry/protection/rule/create_spec.rb'
+ - 'spec/requests/api/graphql/mutations/issues/bulk_update_spec.rb'
+ - 'spec/requests/api/graphql/mutations/merge_requests/set_milestone_spec.rb'
+ - 'spec/requests/api/graphql/mutations/ml/models/delete_spec.rb'
+ - 'spec/requests/api/graphql/mutations/uploads/delete_spec.rb'
+ - 'spec/requests/api/graphql/mutations/work_items/export_spec.rb'
+ - 'spec/requests/api/graphql/mutations/work_items/linked_items/add_spec.rb'
+ - 'spec/requests/api/graphql/mutations/work_items/update_spec.rb'
+ - 'spec/requests/api/graphql/project/environments_spec.rb'
+ - 'spec/requests/api/group_labels_spec.rb'
+ - 'spec/requests/api/groups_spec.rb'
+ - 'spec/requests/api/import_github_spec.rb'
+ - 'spec/requests/api/labels_spec.rb'
+ - 'spec/requests/api/maven_packages_spec.rb'
+ - 'spec/requests/api/projects_spec.rb'
- 'spec/requests/api/releases_spec.rb'
- - 'spec/requests/api/users_spec.rb'
+ - 'spec/requests/projects/google_cloud/databases_controller_spec.rb'
+ - 'spec/requests/pwa_controller_spec.rb'
+ - 'spec/requests/verifies_with_email_spec.rb'
- 'spec/rubocop/cop/api/grape_array_missing_coerce_spec.rb'
- 'spec/rubocop/cop/group_public_or_visible_to_user_spec.rb'
- 'spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb'
+ - 'spec/rubocop/cop/rspec/avoid_test_prof_spec.rb'
+ - 'spec/scripts/generate_rspec_pipeline_spec.rb'
- 'spec/scripts/lib/glfm/update_example_snapshots_spec.rb'
- - 'spec/serializers/pipeline_serializer_spec.rb'
+ - 'spec/serializers/integrations/field_entity_spec.rb'
+ - 'spec/serializers/profile/event_entity_spec.rb'
- 'spec/services/alert_management/alerts/update_service_spec.rb'
- - 'spec/services/ci/create_downstream_pipeline_service_spec.rb'
- - 'spec/services/ci/create_pipeline_service/rules_spec.rb'
- - 'spec/services/ci/create_pipeline_service_spec.rb'
- - 'spec/services/ci/job_artifacts/delete_service_spec.rb'
- - 'spec/services/preview_markdown_service_spec.rb'
+ - 'spec/services/bulk_imports/create_service_spec.rb'
+ - 'spec/services/ci/catalog/resources/release_service_spec.rb'
+ - 'spec/services/ci/catalog/resources/validate_service_spec.rb'
+ - 'spec/services/ci/catalog/verify_namespace_service_spec.rb'
+ - 'spec/services/ci/components/fetch_service_spec.rb'
+ - 'spec/services/feature_flags/update_service_spec.rb'
+ - 'spec/services/import/github_service_spec.rb'
+ - 'spec/services/integrations/slack_interactions/incident_management/incident_modal_submit_service_spec.rb'
+ - 'spec/services/issues/build_service_spec.rb'
+ - 'spec/services/members/invite_service_spec.rb'
+ - 'spec/services/merge_requests/merge_service_spec.rb'
+ - 'spec/services/packages/maven/find_or_create_package_service_spec.rb'
+ - 'spec/services/packages/terraform_module/metadata/extract_files_service_spec.rb'
+ - 'spec/services/projects/group_links/update_service_spec.rb'
+ - 'spec/services/projects/transfer_service_spec.rb'
+ - 'spec/services/projects/update_pages_service_spec.rb'
+ - 'spec/services/releases/create_service_spec.rb'
+ - 'spec/services/security/ci_configuration/sast_create_service_spec.rb'
- 'spec/services/snippets/create_service_spec.rb'
+ - 'spec/services/uploads/destroy_service_spec.rb'
+ - 'spec/services/users/email_verification/update_email_service_spec.rb'
- 'spec/services/users/email_verification/validate_token_service_spec.rb'
- - 'spec/services/work_items/parent_links/create_service_spec.rb'
- - 'spec/support/helpers/database/multiple_databases_helpers.rb'
+ - 'spec/services/users/migrate_records_to_ghost_user_service_spec.rb'
+ - 'spec/services/web_hook_service_spec.rb'
+ - 'spec/services/work_items/related_work_item_links/destroy_service_spec.rb'
+ - 'spec/support/database/prevent_cross_joins.rb'
+ - 'spec/support/helpers/grafana_api_helpers.rb'
+ - 'spec/support/helpers/graphql/subscriptions/action_cable/mock_action_cable.rb'
+ - 'spec/support/helpers/graphql/subscriptions/action_cable/mock_gitlab_schema.rb'
- 'spec/support/helpers/redis_without_keys.rb'
+ - 'spec/support/helpers/require_migration.rb'
+ - 'spec/support/helpers/service_ping_helpers.rb'
+ - 'spec/support/helpers/stub_gitlab_calls.rb'
- 'spec/support/matchers/have_gitlab_http_status.rb'
- - 'spec/support/memory_instrumentation_helper.rb'
+ - 'spec/support/permissions_check.rb'
+ - 'spec/support/rspec_run_time.rb'
+ - 'spec/support/shared_examples/features/inviting_members_shared_examples.rb'
- 'spec/support/shared_examples/features/project_upload_files_shared_examples.rb'
+ - 'spec/support/shared_examples/features/value_streams_dashboard_shared_examples.rb'
+ - 'spec/support/shared_examples/harbor/artifacts_controller_shared_examples.rb'
+ - 'spec/support/shared_examples/harbor/tags_controller_shared_examples.rb'
- 'spec/support/shared_examples/lib/email/email_shared_examples.rb'
+ - 'spec/support/shared_examples/models/concerns/avatarable_shared_examples.rb'
+ - 'spec/support/shared_examples/models/diff_note_after_commit_shared_examples.rb'
+ - 'spec/support/shared_examples/models/disable_sti_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/diff_discussions_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/discussions_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/graphql/mutations/subscription_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/notes_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/resolvable_discussions_shared_examples.rb'
+ - 'spec/support/shared_examples/services/security/ci_configuration/create_service_shared_examples.rb'
+ - 'spec/support/shared_examples/views/nav_sidebar_shared_examples.rb'
+ - 'spec/support/shared_examples/workers/background_migration_worker_shared_examples.rb'
+ - 'spec/tasks/gitlab/db/decomposition/connection_status_rake_spec.rb'
+ - 'spec/tooling/lib/tooling/job_metrics_spec.rb'
- 'spec/uploaders/file_mover_spec.rb'
- - 'spec/views/devise/shared/_signup_box.html.haml_spec.rb'
+ - 'spec/views/layouts/_head.html.haml_spec.rb'
+ - 'spec/views/profiles/preferences/show.html.haml_spec.rb'
+ - 'spec/views/projects/commit/_commit_box.html.haml_spec.rb'
+ - 'spec/views/projects/issues/show.html.haml_spec.rb'
- 'spec/views/projects/pages/show.html.haml_spec.rb'
- - 'spec/workers/integrations/irker_worker_spec.rb'
+ - 'spec/views/user_settings/profiles/show.html.haml_spec.rb'
+ - 'spec/workers/issuable/related_links_create_worker_spec.rb'
+ - 'tooling/danger/change_column_default.rb'
+ - 'tooling/danger/ci_templates.rb'
diff --git a/.rubocop_todo/lint/redundant_safe_navigation.yml b/.rubocop_todo/lint/redundant_safe_navigation.yml
new file mode 100644
index 0000000000000..ffc1ec8e125ac
--- /dev/null
+++ b/.rubocop_todo/lint/redundant_safe_navigation.yml
@@ -0,0 +1,8 @@
+---
+# Cop supports --autocorrect.
+Lint/RedundantSafeNavigation:
+ Details: grace period
+ Exclude:
+ - 'app/presenters/packages/nuget/version_helpers.rb'
+ - 'lib/gitlab/ci/jwt_v2/claim_mapper.rb'
+ - 'lib/security/ci_configuration/sast_build_action.rb'
diff --git a/.rubocop_todo/lint/self_assignment.yml b/.rubocop_todo/lint/self_assignment.yml
new file mode 100644
index 0000000000000..8b40af0c8d008
--- /dev/null
+++ b/.rubocop_todo/lint/self_assignment.yml
@@ -0,0 +1,7 @@
+---
+Lint/SelfAssignment:
+ Details: grace period
+ Exclude:
+ - 'app/models/remote_mirror.rb'
+ - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb'
+ - 'spec/models/ci/build_metadata_spec.rb'
diff --git a/.rubocop_todo/lint/symbol_conversion.yml b/.rubocop_todo/lint/symbol_conversion.yml
index 7bf74bd90e069..7c11d4014fec4 100644
--- a/.rubocop_todo/lint/symbol_conversion.yml
+++ b/.rubocop_todo/lint/symbol_conversion.yml
@@ -2,22 +2,78 @@
# Cop supports --autocorrect.
Lint/SymbolConversion:
Exclude:
+ - 'app/controllers/admin/application_settings_controller.rb'
+ - 'app/controllers/groups_controller.rb'
+ - 'app/controllers/projects/issues_controller.rb'
+ - 'app/controllers/projects_controller.rb'
+ - 'app/controllers/uploads_controller.rb'
+ - 'app/graphql/mutations/members/bulk_update_base.rb'
+ - 'app/graphql/mutations/snippets/base.rb'
+ - 'app/graphql/resolvers/award_emoji/base_votes_count_resolver.rb'
+ - 'app/graphql/resolvers/environments/last_deployment_resolver.rb'
+ - 'app/graphql/resolvers/user_discussions_count_resolver.rb'
+ - 'app/graphql/resolvers/user_notes_count_resolver.rb'
- 'app/helpers/breadcrumbs_helper.rb'
- - 'app/helpers/environments_helper.rb'
+ - 'app/helpers/notifications_helper.rb'
+ - 'app/helpers/projects_helper.rb'
+ - 'app/models/application_record.rb'
+ - 'app/models/concerns/cache_markdown_field.rb'
+ - 'app/models/concerns/featurable.rb'
+ - 'app/models/concerns/file_store_mounter.rb'
+ - 'app/models/concerns/packages/debian/component_file.rb'
+ - 'app/models/concerns/packages/debian/distribution.rb'
+ - 'app/models/concerns/participable.rb'
+ - 'app/models/packages/conan/metadatum.rb'
+ - 'app/models/packages/debian/file_entry.rb'
+ - 'app/models/work_items/widgets/assignees.rb'
+ - 'app/models/work_items/widgets/base.rb'
+ - 'app/presenters/snippet_presenter.rb'
- 'app/services/cloud_seed/google_cloud/create_cloudsql_instance_service.rb'
- - 'config/puma.rb'
+ - 'app/services/concerns/deploy_token_methods.rb'
+ - 'app/services/concerns/rate_limited_service.rb'
+ - 'app/services/container_expiration_policies/cleanup_service.rb'
+ - 'app/services/labels/find_or_create_service.rb'
+ - 'app/services/merge_requests/update_service.rb'
+ - 'app/services/notification_recipients/builder/default.rb'
+ - 'app/services/notification_service.rb'
+ - 'app/workers/project_export_worker.rb'
- 'ee/app/components/billing/plan_component.rb'
- 'ee/app/controllers/projects/security/scanned_resources_controller.rb'
+ - 'ee/app/graphql/ee/resolvers/projects/branch_rules_resolver.rb'
+ - 'ee/app/graphql/types/ci/jobs_duration_statistics_type.rb'
+ - 'ee/app/models/concerns/ee/protected_branch.rb'
+ - 'ee/app/models/geo_node_status.rb'
+ - 'ee/app/policies/ee/group_policy.rb'
+ - 'ee/app/policies/ee/project_policy.rb'
- 'ee/app/serializers/integrations/zentao_serializers/issue_entity.rb'
+ - 'ee/app/serializers/report_list_entity.rb'
+ - 'ee/app/services/security/security_orchestration_policies/ci_action/base.rb'
+ - 'ee/app/services/vulnerabilities/manually_create_service.rb'
+ - 'ee/app/workers/security/store_scans_worker.rb'
- 'ee/db/fixtures/development/35_merge_request_predictions.rb'
- - 'ee/lib/api/analytics/product_analytics.rb'
- - 'ee/lib/ee/gitlab/scim/attribute_transform.rb'
+ - 'ee/lib/api/concerns/dependency_proxy/packages_helpers.rb'
+ - 'ee/lib/ee/api/helpers.rb'
- 'ee/lib/elastic/latest/note_class_proxy.rb'
- 'ee/lib/gitlab/applied_ml/suggested_reviewers/client.rb'
+ - 'ee/lib/gitlab/elastic/search_results.rb'
+ - 'ee/lib/gitlab/geo/replicator.rb'
+ - 'ee/lib/gitlab/graphql/aggregations/epics/epic_node.rb'
+ - 'ee/lib/search/zoekt/search_results.rb'
- 'ee/spec/controllers/admin/audit_logs_controller_spec.rb'
- 'ee/spec/controllers/groups/audit_events_controller_spec.rb'
- 'ee/spec/controllers/projects/audit_events_controller_spec.rb'
+ - 'ee/spec/factories/ci/builds.rb'
+ - 'ee/spec/factories/ci/pipelines.rb'
+ - 'ee/spec/features/groups/analytics/cycle_analytics/charts_spec.rb'
+ - 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb'
+ - 'ee/spec/features/groups/analytics/cycle_analytics/multiple_value_streams_spec.rb'
+ - 'ee/spec/helpers/billing_plans_helper_spec.rb'
+ - 'ee/spec/helpers/push_rules_helper_spec.rb'
+ - 'ee/spec/models/concerns/elastic/repository_spec.rb'
+ - 'ee/spec/models/plan_spec.rb'
+ - 'ee/spec/models/project_feature_spec.rb'
- 'ee/spec/requests/api/analytics/product_analytics_spec.rb'
+ - 'ee/spec/requests/api/dependency_proxy/packages/npm_spec.rb'
- 'ee/spec/requests/api/graphql/audit_events/streaming/headers/create_spec.rb'
- 'ee/spec/requests/api/graphql/audit_events/streaming/headers/destroy_spec.rb'
- 'ee/spec/requests/api/graphql/audit_events/streaming/headers/update_spec.rb'
@@ -27,18 +83,56 @@ Lint/SymbolConversion:
- 'ee/spec/requests/api/scim/group_scim_spec.rb'
- 'ee/spec/requests/api/scim/instance_scim_spec.rb'
- 'ee/spec/services/elastic/data_migration_service_spec.rb'
+ - 'ee/spec/services/phone_verification/users/send_verification_code_service_spec.rb'
+ - 'ee/spec/services/security/security_orchestration_policies/scan_pipeline_service_spec.rb'
- 'ee/spec/services/security/token_revocation_service_spec.rb'
- 'ee/spec/support/helpers/subscription_portal_helpers.rb'
- - 'ee/spec/workers/deployments/approval_worker_spec.rb'
+ - 'ee/spec/support/matchers/ee/epic_aggregate_matchers.rb'
+ - 'ee/spec/support/shared_examples/google_cloud_platform/artifact_registry/services_shared_examples.rb'
+ - 'ee/spec/support/shared_examples/status_page/image_post_process_examples.rb'
+ - 'lib/api/entities/entity_helpers.rb'
+ - 'lib/api/helpers/notes_helpers.rb'
+ - 'lib/api/time_tracking_endpoints.rb'
+ - 'lib/api/todos.rb'
+ - 'lib/banzai/filter/references/abstract_reference_filter.rb'
+ - 'lib/banzai/filter/references/reference_cache.rb'
+ - 'lib/banzai/reference_parser/issuable_parser.rb'
+ - 'lib/gitlab/application_rate_limiter.rb'
+ - 'lib/gitlab/auth/activity.rb'
+ - 'lib/gitlab/auth/o_auth/user.rb'
+ - 'lib/gitlab/ci/ansi2html.rb'
+ - 'lib/gitlab/ci/artifacts/metrics.rb'
+ - 'lib/gitlab/ci/config/external/mapper/base.rb'
+ - 'lib/gitlab/database/migration_helpers/cascading_namespace_settings.rb'
+ - 'lib/gitlab/database/query_analyzers/base.rb'
+ - 'lib/gitlab/graphql/markdown_field.rb'
+ - 'lib/gitlab/import_export/project/relation_factory.rb'
+ - 'lib/gitlab/kubernetes/kube_client.rb'
+ - 'lib/gitlab/legacy_github_import/importer.rb'
+ - 'lib/gitlab/mail_room/authenticator.rb'
+ - 'lib/gitlab/metrics.rb'
+ - 'lib/gitlab/metrics/subscribers/active_record.rb'
+ - 'lib/gitlab/metrics/transaction.rb'
+ - 'lib/gitlab/usage_data/topology.rb'
+ - 'lib/gitlab/usage_data_counters/base_counter.rb'
+ - 'lib/gitlab/usage_data_counters/note_counter.rb'
+ - 'lib/peek/views/detailed_view.rb'
+ - 'qa/qa/ee/page/workspace/action.rb'
+ - 'qa/qa/ee/page/workspace/list.rb'
+ - 'qa/qa/ee/resource/group_web_hook.rb'
+ - 'qa/qa/page/admin/applications.rb'
+ - 'qa/qa/resource/project_web_hook.rb'
+ - 'rubocop/cop/usage_data/large_table.rb'
+ - 'spec/controllers/concerns/check_rate_limit_spec.rb'
- 'spec/controllers/jira_connect/branches_controller_spec.rb'
+ - 'spec/controllers/projects_controller_spec.rb'
- 'spec/factories/ci/reports/codequality_degradations.rb'
- 'spec/factories/evidences.rb'
+ - 'spec/factories/integrations.rb'
- 'spec/features/file_uploads/graphql_add_design_spec.rb'
- 'spec/features/projects/new_project_spec.rb'
- 'spec/graphql/mutations/ci/job_token_scope/remove_project_spec.rb'
- 'spec/helpers/application_settings_helper_spec.rb'
- - 'spec/helpers/auth_helper_spec.rb'
- - 'spec/helpers/environments_helper_spec.rb'
- 'spec/helpers/form_helper_spec.rb'
- 'spec/initializers/sawyer_patch_spec.rb'
- 'spec/lib/api/entities/nuget/dependency_group_spec.rb'
@@ -46,6 +140,7 @@ Lint/SymbolConversion:
- 'spec/lib/api/entities/nuget/metadatum_spec.rb'
- 'spec/lib/api/entities/nuget/package_metadata_catalog_entry_spec.rb'
- 'spec/lib/api/entities/nuget/search_result_spec.rb'
+ - 'spec/lib/api/helpers/rate_limiter_spec.rb'
- 'spec/lib/bulk_imports/projects/pipelines/project_feature_pipeline_spec.rb'
- 'spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb'
- 'spec/lib/constraints/group_url_constrainer_spec.rb'
@@ -64,15 +159,37 @@ Lint/SymbolConversion:
- 'spec/lib/gitlab/ci/yaml_processor_spec.rb'
- 'spec/lib/google_api/cloud_platform/client_spec.rb'
- 'spec/lib/service_ping/devops_report_spec.rb'
+ - 'spec/models/appearance_spec.rb'
+ - 'spec/models/concerns/file_store_mounter_spec.rb'
+ - 'spec/models/concerns/project_features_compatibility_spec.rb'
- 'spec/models/integrations/prometheus_spec.rb'
- 'spec/models/merge_request_diff_commit_spec.rb'
+ - 'spec/models/plan_spec.rb'
+ - 'spec/models/project_feature_spec.rb'
+ - 'spec/policies/project_policy_spec.rb'
- 'spec/requests/api/admin/plan_limits_spec.rb'
- 'spec/requests/api/ci/job_artifacts_spec.rb'
- 'spec/requests/api/ci/runner/jobs_put_spec.rb'
- 'spec/requests/api/feature_flags_spec.rb'
- 'spec/requests/api/group_debian_distributions_spec.rb'
- 'spec/requests/api/integrations_spec.rb'
+ - 'spec/requests/api/maven_packages_spec.rb'
- 'spec/requests/api/project_debian_distributions_spec.rb'
- 'spec/requests/api/terraform/state_spec.rb'
- 'spec/requests/mailgun/webhooks_controller_spec.rb'
- 'spec/requests/users_controller_spec.rb'
+ - 'spec/services/ci/job_artifacts/expire_project_build_artifacts_service_spec.rb'
+ - 'spec/services/concerns/rate_limited_service_spec.rb'
+ - 'spec/services/design_management/copy_design_collection/copy_service_spec.rb'
+ - 'spec/support/helpers/integrations/test_helpers.rb'
+ - 'spec/support/helpers/stub_configuration.rb'
+ - 'spec/support/shared_examples/features/project_features_apply_to_issuables_shared_examples.rb'
+ - 'spec/support/shared_examples/lib/gitlab/usage_data_counters/a_redis_counter_shared_examples.rb'
+ - 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb'
+ - 'spec/support/shared_examples/models/concerns/cascading_namespace_setting_shared_examples.rb'
+ - 'spec/support/shared_examples/models/concerns/cascading_project_setting_shared_examples.rb'
+ - 'spec/support/shared_examples/models/concerns/counter_attribute_shared_examples.rb'
+ - 'spec/support/shared_examples/models/concerns/featurable_shared_examples.rb'
+ - 'spec/support/shared_examples/models/concerns/signature_type_shared_examples.rb'
+ - 'spec/support/shared_examples/services/migrate_to_ghost_user_service_shared_examples.rb'
+ - 'spec/support/shared_examples/workers/concerns/dependency_proxy/cleanup_worker_shared_examples.rb'
diff --git a/.rubocop_todo/performance/map_compact.yml b/.rubocop_todo/performance/map_compact.yml
index 2345b8cdd0111..f5948edc9f645 100644
--- a/.rubocop_todo/performance/map_compact.yml
+++ b/.rubocop_todo/performance/map_compact.yml
@@ -24,14 +24,12 @@ Performance/MapCompact:
- 'app/models/snippet_repository.rb'
- 'app/models/web_ide_terminal.rb'
- 'app/presenters/packages/conan/package_presenter.rb'
- - 'app/presenters/packages/nuget/packages_metadata_presenter.rb'
- - 'app/presenters/packages/nuget/search_results_presenter.rb'
- 'app/serializers/analytics/cycle_analytics/event_entity.rb'
- 'app/services/auth/container_registry_authentication_service.rb'
+ - 'app/services/cloud_seed/google_cloud/fetch_google_ip_list_service.rb'
- 'app/services/events/render_service.rb'
- 'app/services/feature_flags/update_service.rb'
- 'app/services/git/base_hooks_service.rb'
- - 'app/services/cloud_seed/google_cloud/fetch_google_ip_list_service.rb'
- 'app/services/jira_import/start_import_service.rb'
- 'app/services/jira_import/users_mapper_service.rb'
- 'app/services/labels/available_labels_service.rb'
@@ -40,7 +38,6 @@ Performance/MapCompact:
- 'app/services/merge_requests/update_service.rb'
- 'app/services/packages/maven/find_or_create_package_service.rb'
- 'app/services/projects/container_repository/third_party/delete_tags_service.rb'
- - 'app/services/projects/update_statistics_service.rb'
- 'app/services/quick_actions/interpret_service.rb'
- 'app/services/repositories/changelog_service.rb'
- 'app/services/todos/allowed_target_filter_service.rb'
@@ -48,6 +45,7 @@ Performance/MapCompact:
- 'config/initializers/wikicloth_redos_patch.rb'
- 'ee/app/finders/security/findings_finder.rb'
- 'ee/app/graphql/ee/types/issue_connection_type.rb'
+ - 'ee/app/graphql/resolvers/geo/registries_resolver.rb'
- 'ee/app/models/app_sec/fuzzing/api/ci_configuration.rb'
- 'ee/app/models/burndown.rb'
- 'ee/app/models/concerns/ee/project_security_scanners_information.rb'
@@ -56,14 +54,12 @@ Performance/MapCompact:
- 'ee/app/models/sca/license_compliance.rb'
- 'ee/app/services/app_sec/dast/profiles/create_associations_service.rb'
- 'ee/app/services/app_sec/dast/scan_configs/fetch_service.rb'
- - 'ee/app/services/epic_issues/create_service.rb'
- 'ee/app/services/members/activate_service.rb'
- 'ee/app/services/security/override_uuids_service.rb'
- 'ee/app/services/security/store_scan_service.rb'
- 'ee/app/services/upcoming_reconciliations/update_service.rb'
- 'ee/app/services/vulnerabilities/findings/find_or_create_from_security_finding_service.rb'
- 'ee/app/workers/geo/scheduler/scheduler_worker.rb'
- - 'ee/db/fixtures/development/30_customizable_cycle_analytics.rb'
- 'ee/lib/banzai/filter/references/iteration_reference_filter.rb'
- 'ee/lib/ee/api/entities/experiment.rb'
- 'ee/lib/ee/gitlab/auth/ldap/person.rb'
@@ -75,7 +71,6 @@ Performance/MapCompact:
- 'ee/lib/gitlab/ci/reports/metrics/reports_comparer.rb'
- 'ee/lib/gitlab/search/aggregation_parser.rb'
- 'ee/spec/models/ee/member_spec.rb'
- - 'ee/spec/requests/api/audit_events_spec.rb'
- 'ee/spec/requests/api/search_spec.rb'
- 'haml_lint/linter/no_plain_nodes.rb'
- 'lib/api/entities/feature.rb'
@@ -86,7 +81,6 @@ Performance/MapCompact:
- 'lib/banzai/filter/image_link_filter.rb'
- 'lib/banzai/filter/references/design_reference_filter.rb'
- 'lib/banzai/filter/references/label_reference_filter.rb'
- - 'lib/banzai/filter/references/milestone_reference_filter.rb'
- 'lib/banzai/reference_parser/issuable_parser.rb'
- 'lib/error_tracking/sentry_client/pagination_parser.rb'
- 'lib/gitaly/server.rb'
@@ -103,11 +97,9 @@ Performance/MapCompact:
- 'lib/gitlab/git/conflict/file.rb'
- 'lib/gitlab/sql/pattern.rb'
- 'qa/qa/page/component/issuable/sidebar.rb'
- - 'qa/qa/support/formatters/test_metrics_formatter.rb'
- 'qa/qa/tools/ci/ff_changes.rb'
- 'scripts/lint_templates_bash.rb'
- 'spec/controllers/every_controller_spec.rb'
- - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb'
- 'spec/lib/api/every_api_endpoint_spec.rb'
- 'spec/lib/banzai/pipeline/plain_markdown_pipeline_spec.rb'
- 'spec/lib/gitlab/conflict/file_spec.rb'
@@ -116,7 +108,6 @@ Performance/MapCompact:
- 'spec/models/network/graph_spec.rb'
- 'spec/models/repository_spec.rb'
- 'spec/requests/api/commits_spec.rb'
- - 'spec/requests/api/groups_spec.rb'
- 'spec/requests/lfs_http_spec.rb'
- 'spec/serializers/diff_file_entity_spec.rb'
- 'spec/services/projects/container_repository/third_party/cleanup_tags_service_spec.rb'
diff --git a/.rubocop_todo/performance/string_identifier_argument.yml b/.rubocop_todo/performance/string_identifier_argument.yml
new file mode 100644
index 0000000000000..dfb545ade9165
--- /dev/null
+++ b/.rubocop_todo/performance/string_identifier_argument.yml
@@ -0,0 +1,242 @@
+---
+# Cop supports --autocorrect.
+Performance/StringIdentifierArgument:
+ Details: grace period
+ Exclude:
+ - 'app/controllers/concerns/import/github_oauth.rb'
+ - 'app/controllers/import/github_controller.rb'
+ - 'app/graphql/types/project_type.rb'
+ - 'app/helpers/namespaces_helper.rb'
+ - 'app/models/concerns/atomic_internal_id.rb'
+ - 'app/models/concerns/cache_markdown_field.rb'
+ - 'app/models/concerns/cascading_namespace_setting_attribute.rb'
+ - 'app/models/concerns/cascading_project_setting_attribute.rb'
+ - 'app/models/concerns/chronic_duration_attribute.rb'
+ - 'app/models/concerns/counter_attribute.rb'
+ - 'app/models/concerns/diff_positionable_note.rb'
+ - 'app/models/concerns/featurable.rb'
+ - 'app/models/concerns/file_store_mounter.rb'
+ - 'app/models/concerns/integrations/reset_secret_fields.rb'
+ - 'app/models/concerns/mirror_authentication.rb'
+ - 'app/models/concerns/redactable.rb'
+ - 'app/models/concerns/routable.rb'
+ - 'app/models/concerns/sanitizable.rb'
+ - 'app/models/concerns/signature_type.rb'
+ - 'app/models/concerns/token_authenticatable.rb'
+ - 'app/models/concerns/token_authenticatable_strategies/base.rb'
+ - 'app/models/integrations/base_third_party_wiki.rb'
+ - 'app/models/integrations/field.rb'
+ - 'app/models/namespace_statistics.rb'
+ - 'app/models/packages/debian/file_entry.rb'
+ - 'app/models/project.rb'
+ - 'app/models/project_statistics.rb'
+ - 'app/models/protectable_dropdown.rb'
+ - 'app/models/snippet_input_action.rb'
+ - 'app/presenters/label_presenter.rb'
+ - 'app/serializers/analytics_build_entity.rb'
+ - 'app/serializers/analytics_issue_entity.rb'
+ - 'app/serializers/ci/job_entity.rb'
+ - 'app/serializers/group_child_entity.rb'
+ - 'app/services/concerns/audit_event_save_type.rb'
+ - 'app/services/issuable_base_service.rb'
+ - 'app/services/packages/rpm/parse_package_service.rb'
+ - 'app/services/verify_pages_domain_service.rb'
+ - 'app/validators/addressable_url_validator.rb'
+ - 'app/validators/ip_address_validator.rb'
+ - 'config/initializers/sawyer_patch.rb'
+ - 'config/initializers/wikicloth_redos_patch.rb'
+ - 'config/routes.rb'
+ - 'ee/app/finders/geo/framework_registry_finder.rb'
+ - 'ee/app/graphql/ee/types/group_type.rb'
+ - 'ee/app/graphql/types/ci/jobs_duration_statistics_type.rb'
+ - 'ee/app/helpers/ee/gitlab_routing_helper.rb'
+ - 'ee/app/models/ee/namespace_setting.rb'
+ - 'ee/app/models/ee/project.rb'
+ - 'ee/app/models/geo_node_status.rb'
+ - 'ee/app/models/license.rb'
+ - 'ee/app/services/incident_management/pending_escalations/process_service.rb'
+ - 'ee/lib/gitlab/graphql/aggregations/issuables/lazy_links_aggregate.rb'
+ - 'ee/spec/controllers/groups/iterations_controller_spec.rb'
+ - 'ee/spec/controllers/groups/security/policies_controller_spec.rb'
+ - 'ee/spec/factories/protected_branches.rb'
+ - 'ee/spec/graphql/mutations/groups/update_spec.rb'
+ - 'ee/spec/helpers/push_rules_helper_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/hook_data/merge_request_builder_spec.rb'
+ - 'ee/spec/lib/ee/sidebars/projects/menus/packages_registries_menu_spec.rb'
+ - 'ee/spec/lib/gitlab/background_migration/create_vulnerability_links_spec.rb'
+ - 'ee/spec/lib/gitlab/insights/reducers/count_per_period_reducer_spec.rb'
+ - 'ee/spec/models/concerns/elastic/projects_search_spec.rb'
+ - 'ee/spec/models/concerns/elastic/repositories_search_spec.rb'
+ - 'ee/spec/models/ee/namespace_spec.rb'
+ - 'ee/spec/models/ee/project_spec.rb'
+ - 'ee/spec/models/gitlab_subscription_spec.rb'
+ - 'ee/spec/models/namespace_setting_spec.rb'
+ - 'ee/spec/models/project_feature_spec.rb'
+ - 'ee/spec/models/project_import_data_spec.rb'
+ - 'ee/spec/models/project_import_state_spec.rb'
+ - 'ee/spec/policies/audit_events/group/namespace_filter_policy_spec.rb'
+ - 'ee/spec/policies/project_policy_spec.rb'
+ - 'ee/spec/requests/api/dependency_proxy/packages/maven_spec.rb'
+ - 'ee/spec/requests/api/graphql/google_cloud/artifact_registry/docker_image_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/dependency_proxy/packages/settings/update_spec.rb'
+ - 'ee/spec/requests/api/issues_spec.rb'
+ - 'ee/spec/requests/ee/omniauth_callbacks_controller_spec.rb'
+ - 'ee/spec/services/dependency_proxy/packages/settings/update_service_spec.rb'
+ - 'ee/spec/services/elastic/process_initial_bookkeeping_service_spec.rb'
+ - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb'
+ - 'ee/spec/support/helpers/search_results_helpers.rb'
+ - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb'
+ - 'ee/spec/support/shared_examples/google_cloud_platform/artifact_registry/services_shared_examples.rb'
+ - 'ee/spec/support/shared_examples/lib/gitlab/elastic/search_results_shared_examples.rb'
+ - 'ee/spec/support/shared_examples/policies/monitor_feature_visibility_shared_examples.rb'
+ - 'ee/spec/workers/concerns/elastic/migration_options_spec.rb'
+ - 'ee/spec/workers/elastic_namespace_rollout_worker_spec.rb'
+ - 'lib/api/ci/runners.rb'
+ - 'lib/api/helpers/members_helpers.rb'
+ - 'lib/api/helpers/notes_helpers.rb'
+ - 'lib/api/resource_access_tokens.rb'
+ - 'lib/banzai/object_renderer.rb'
+ - 'lib/feature/definition.rb'
+ - 'lib/gitlab/application_context.rb'
+ - 'lib/gitlab/auth/activity.rb'
+ - 'lib/gitlab/ci/ansi2html.rb'
+ - 'lib/gitlab/ci/ansi2json/parser.rb'
+ - 'lib/gitlab/ci/matching/build_matcher.rb'
+ - 'lib/gitlab/ci/matching/runner_matcher.rb'
+ - 'lib/gitlab/ci/reports/test_report.rb'
+ - 'lib/gitlab/ci/reports/test_suite.rb'
+ - 'lib/gitlab/config/entry/attributable.rb'
+ - 'lib/gitlab/config/entry/configurable.rb'
+ - 'lib/gitlab/database/load_balancing/setup.rb'
+ - 'lib/gitlab/database/migrations/batched_background_migration_helpers.rb'
+ - 'lib/gitlab/doctor/reset_tokens.rb'
+ - 'lib/gitlab/error_tracking/processor/sanitizer_processor.rb'
+ - 'lib/gitlab/fake_application_settings.rb'
+ - 'lib/gitlab/git/blob.rb'
+ - 'lib/gitlab/git/commit.rb'
+ - 'lib/gitlab/git/tag.rb'
+ - 'lib/gitlab/git/tree.rb'
+ - 'lib/gitlab/gitaly_client/attributes_bag.rb'
+ - 'lib/gitlab/health_checks/redis.rb'
+ - 'lib/gitlab/markdown_cache/redis/extension.rb'
+ - 'lib/gitlab/rack_attack/request.rb'
+ - 'lib/gitlab/reference_extractor.rb'
+ - 'lib/gitlab/repository_cache_adapter.rb'
+ - 'lib/gitlab/runtime.rb'
+ - 'lib/gitlab/search/abuse_detection.rb'
+ - 'lib/gitlab/throttle.rb'
+ - 'lib/gitlab/utils/lazy_attributes.rb'
+ - 'lib/kramdown/parser/atlassian_document_format.rb'
+ - 'lib/sidebars/context.rb'
+ - 'qa/qa/flow/purchase.rb'
+ - 'qa/qa/page/component/ci_icon.rb'
+ - 'qa/qa/page/component/note.rb'
+ - 'qa/qa/resource/base.rb'
+ - 'qa/qa/resource/integrations/web_hook/smockerable.rb'
+ - 'qa/qa/runtime/address.rb'
+ - 'qa/qa/specs/features/browser_ui/10_govern/login/login_via_oauth_and_oidc_with_gitlab_as_idp_spec.rb'
+ - 'qa/qa/specs/features/ee/browser_ui/9_data_stores/group/prevent_forking_outside_group_spec.rb'
+ - 'qa/qa/support/matchers/have_matcher.rb'
+ - 'scripts/perf/gc/print_gc_stats.rb'
+ - 'spec/config/inject_enterprise_edition_module_spec.rb'
+ - 'spec/controllers/groups/settings/applications_controller_spec.rb'
+ - 'spec/controllers/import/github_controller_spec.rb'
+ - 'spec/controllers/repositories/lfs_storage_controller_spec.rb'
+ - 'spec/finders/concerns/packages/finder_helper_spec.rb'
+ - 'spec/finders/packages/group_packages_finder_spec.rb'
+ - 'spec/graphql/mutations/container_expiration_policies/update_spec.rb'
+ - 'spec/graphql/mutations/container_repositories/destroy_spec.rb'
+ - 'spec/graphql/mutations/container_repositories/destroy_tags_spec.rb'
+ - 'spec/graphql/mutations/dependency_proxy/group_settings/update_spec.rb'
+ - 'spec/graphql/mutations/dependency_proxy/image_ttl_group_policy/update_spec.rb'
+ - 'spec/graphql/mutations/groups/update_spec.rb'
+ - 'spec/graphql/mutations/namespace/package_settings/update_spec.rb'
+ - 'spec/helpers/avatars_helper_spec.rb'
+ - 'spec/helpers/packages_helper_spec.rb'
+ - 'spec/lib/api/helpers/packages_helpers_spec.rb'
+ - 'spec/lib/gitlab/ci/reports/test_report_spec.rb'
+ - 'spec/lib/gitlab/ci/reports/test_suite_spec.rb'
+ - 'spec/lib/gitlab/error_tracking/processor/sanitizer_processor_spec.rb'
+ - 'spec/lib/gitlab/hook_data/merge_request_builder_spec.rb'
+ - 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb'
+ - 'spec/lib/gitlab/runtime_spec.rb'
+ - 'spec/migrations/20240124043507_migrate_sidekiq_queued_and_future_jobs_spec.rb'
+ - 'spec/models/appearance_spec.rb'
+ - 'spec/models/badge_spec.rb'
+ - 'spec/models/badges/project_badge_spec.rb'
+ - 'spec/models/bulk_imports/export_upload_spec.rb'
+ - 'spec/models/concerns/chronic_duration_attribute_spec.rb'
+ - 'spec/models/concerns/project_features_compatibility_spec.rb'
+ - 'spec/models/concerns/resolvable_discussion_spec.rb'
+ - 'spec/models/concerns/token_authenticatable_spec.rb'
+ - 'spec/models/import_export_upload_spec.rb'
+ - 'spec/models/integration_spec.rb'
+ - 'spec/models/integrations/field_spec.rb'
+ - 'spec/models/packages/package_file_spec.rb'
+ - 'spec/models/project_spec.rb'
+ - 'spec/policies/container_expiration_policy_policy_spec.rb'
+ - 'spec/policies/project_policy_spec.rb'
+ - 'spec/requests/api/alert_management_alerts_spec.rb'
+ - 'spec/requests/api/deploy_tokens_spec.rb'
+ - 'spec/requests/api/generic_packages_spec.rb'
+ - 'spec/requests/api/graphql/mutations/container_expiration_policy/update_spec.rb'
+ - 'spec/requests/api/graphql/mutations/container_repository/destroy_spec.rb'
+ - 'spec/requests/api/graphql/mutations/container_repository/destroy_tags_spec.rb'
+ - 'spec/requests/api/graphql/mutations/ml/model_versions/delete_spec.rb'
+ - 'spec/requests/api/graphql/mutations/ml/models/delete_spec.rb'
+ - 'spec/requests/api/graphql/mutations/ml/models/destroy_spec.rb'
+ - 'spec/requests/api/graphql/mutations/namespace/package_settings/update_spec.rb'
+ - 'spec/requests/api/graphql/mutations/packages/bulk_destroy_spec.rb'
+ - 'spec/requests/api/graphql/mutations/packages/cleanup/policy/update_spec.rb'
+ - 'spec/requests/api/graphql/mutations/packages/destroy_file_spec.rb'
+ - 'spec/requests/api/graphql/mutations/packages/destroy_files_spec.rb'
+ - 'spec/requests/api/graphql/mutations/packages/destroy_spec.rb'
+ - 'spec/requests/api/graphql/project/packages_spec.rb'
+ - 'spec/requests/api/ml_model_packages_spec.rb'
+ - 'spec/requests/api/npm_group_packages_spec.rb'
+ - 'spec/requests/api/project_packages_spec.rb'
+ - 'spec/requests/api/pypi_packages_spec.rb'
+ - 'spec/requests/api/rpm_project_packages_spec.rb'
+ - 'spec/requests/api/rubygem_packages_spec.rb'
+ - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb'
+ - 'spec/services/clusters/integrations/create_service_spec.rb'
+ - 'spec/services/concerns/ci/job_token_scope/edit_scope_validations_spec.rb'
+ - 'spec/services/container_expiration_policies/update_service_spec.rb'
+ - 'spec/services/dependency_proxy/group_settings/update_service_spec.rb'
+ - 'spec/services/dependency_proxy/image_ttl_group_policies/update_service_spec.rb'
+ - 'spec/services/namespaces/package_settings/update_service_spec.rb'
+ - 'spec/services/packages/cleanup/update_policy_service_spec.rb'
+ - 'spec/services/packages/maven/metadata/sync_service_spec.rb'
+ - 'spec/services/packages/nuget/sync_metadatum_service_spec.rb'
+ - 'spec/support/helpers/redis_helpers.rb'
+ - 'spec/support/redis.rb'
+ - 'spec/support/shared_contexts/requests/api/debian_repository_shared_context.rb'
+ - 'spec/support/shared_examples/banzai/filters/reference_filter_shared_examples.rb'
+ - 'spec/support/shared_examples/ci/jwt_shared_examples.rb'
+ - 'spec/support/shared_examples/controllers/application_settings_shared_examples.rb'
+ - 'spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb'
+ - 'spec/support/shared_examples/database_health_status_indicators/prometheus_alert_based_shared_examples.rb'
+ - 'spec/support/shared_examples/graphql/container_expiration_policy_shared_examples.rb'
+ - 'spec/support/shared_examples/models/active_record_enum_shared_examples.rb'
+ - 'spec/support/shared_examples/models/application_setting_shared_examples.rb'
+ - 'spec/support/shared_examples/models/concerns/cascading_namespace_setting_shared_examples.rb'
+ - 'spec/support/shared_examples/models/concerns/cascading_project_setting_shared_examples.rb'
+ - 'spec/support/shared_examples/models/concerns/integrations/reset_secret_fields_shared_examples.rb'
+ - 'spec/support/shared_examples/models/concerns/update_namespace_statistics_shared_examples.rb'
+ - 'spec/support/shared_examples/models/email_format_shared_examples.rb'
+ - 'spec/support/shared_examples/models/project_ci_cd_settings_shared_examples.rb'
+ - 'spec/support/shared_examples/policies/project_policy_shared_examples.rb'
+ - 'spec/support/shared_examples/quick_actions/issuable/close_quick_action_shared_examples.rb'
+ - 'spec/support/shared_examples/quick_actions/issuable/time_tracking_quick_action_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/composer_packages_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/graphql/projects/branch_protections/access_level_request_examples.rb'
+ - 'spec/support/shared_examples/requests/api/helm_packages_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/npm_packages_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/nuget_packages_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/pypi_packages_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb'
+ - 'spec/support/shared_examples/requests/api/terraform/modules/v1/packages_shared_examples.rb'
+ - 'spec/workers/packages/maven/metadata/sync_worker_spec.rb'
+ - 'tooling/danger/database_dictionary.rb'
+ - 'tooling/danger/feature_flag.rb'
+ - 'tooling/danger/saas_feature.rb'
diff --git a/.rubocop_todo/performance/string_include.yml b/.rubocop_todo/performance/string_include.yml
new file mode 100644
index 0000000000000..1acfbfa10ac8d
--- /dev/null
+++ b/.rubocop_todo/performance/string_include.yml
@@ -0,0 +1,6 @@
+---
+# Cop supports --autocorrect.
+Performance/StringInclude:
+ Details: grace period
+ Exclude:
+ - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb'
diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml
index 8ad66c1395a07..7a84b71cc5923 100644
--- a/.rubocop_todo/rails/pluck.yml
+++ b/.rubocop_todo/rails/pluck.yml
@@ -1,6 +1,7 @@
---
# Cop supports --autocorrect.
Rails/Pluck:
+ Details: grace period
Exclude:
- 'app/controllers/ldap/omniauth_callbacks_controller.rb'
- 'app/finders/merge_requests/oldest_per_commit_finder.rb'
@@ -25,8 +26,6 @@ Rails/Pluck:
- 'ee/lib/banzai/filter/references/iteration_reference_filter.rb'
- 'ee/lib/ee/gitlab/auth/ldap/person.rb'
- 'ee/lib/ee/gitlab/background_migration/delete_invalid_epic_issues.rb'
- - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb'
- - 'ee/lib/elastic/latest/custom_language_analyzers.rb'
- 'ee/lib/gitlab/search/index_curator.rb'
- 'ee/spec/controllers/autocomplete_controller_spec.rb'
- 'ee/spec/controllers/countries_controller_spec.rb'
@@ -95,36 +94,32 @@ Rails/Pluck:
- 'ee/spec/support/shared_examples/requests/api/graphql/incident_management/escalation_policies_shared_examples.rb'
- 'lib/atlassian/jira_connect/client.rb'
- 'lib/banzai/filter/references/label_reference_filter.rb'
- - 'lib/banzai/filter/references/milestone_reference_filter.rb'
- 'lib/banzai/renderer.rb'
- 'lib/gitlab/access.rb'
- 'lib/gitlab/analytics/cycle_analytics/default_stages.rb'
+ - 'lib/gitlab/auth/ldap/config.rb'
- 'lib/gitlab/bullet/exclusions.rb'
- 'lib/gitlab/checks/lfs_check.rb'
- 'lib/gitlab/ci/pipeline/chain/build/associations.rb'
- 'lib/gitlab/ci/pipeline/chain/validate/external.rb'
- 'lib/gitlab/ci/variables/collection/sort.rb'
- - 'lib/gitlab/config/entry/validators.rb'
- 'lib/gitlab/cycle_analytics/updater.rb'
- 'lib/gitlab/database/migration_helpers.rb'
- 'lib/gitlab/database/partitioning_migration_helpers/index_helpers.rb'
- 'lib/gitlab/git_access.rb'
- 'lib/gitlab/github_import/representation/issue.rb'
- - 'lib/gitlab/jira_import/metadata_collector.rb'
- 'lib/gitlab/merge_requests/message_generator.rb'
- 'lib/gitlab/sidekiq_config/cli_methods.rb'
- 'lib/gitlab/sql/pattern.rb'
- 'lib/gitlab/usage_data_counters/hll_redis_counter.rb'
- 'lib/gitlab/zentao/client.rb'
+ - 'lib/security/ci_configuration/sast_build_action.rb'
- 'lib/tasks/gitlab/info.rake'
- - 'qa/qa/specs/features/api/1_manage/migration/gitlab_migration_mr_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/integrations/jira/jira_basic_integration_spec.rb'
- 'qa/qa/tools/ci/qa_changes.rb'
- - 'qa/qa/tools/delete_projects.rb'
- - 'qa/qa/tools/delete_test_snippets.rb'
- 'qa/qa/tools/delete_test_ssh_keys.rb'
- 'qa/qa/tools/delete_test_users.rb'
- - 'qa/qa/tools/delete_user_projects.rb'
+ - 'scripts/internal_events/cli/helpers/metric_options.rb'
- 'scripts/perf/query_limiting_report.rb'
- 'spec/config/mail_room_spec.rb'
- 'spec/controllers/autocomplete_controller_spec.rb'
@@ -245,7 +240,6 @@ Rails/Pluck:
- 'spec/requests/api/users_spec.rb'
- 'spec/requests/groups/autocomplete_sources_spec.rb'
- 'spec/requests/groups/milestones_controller_spec.rb'
- - 'spec/requests/jwks_controller_spec.rb'
- 'spec/requests/lfs_http_spec.rb'
- 'spec/serializers/ci/dag_pipeline_entity_spec.rb'
- 'spec/serializers/ci/pipeline_entity_spec.rb'
@@ -256,6 +250,7 @@ Rails/Pluck:
- 'spec/services/issues/export_csv_service_spec.rb'
- 'spec/services/projects/participants_service_spec.rb'
- 'spec/support/helpers/api_helpers.rb'
+ - 'spec/support/helpers/dns_helpers.rb'
- 'spec/support/helpers/graphql_helpers.rb'
- 'spec/support/matchers/background_migrations_matchers.rb'
- 'spec/tooling/docs/deprecation_handling_spec.rb'
diff --git a/.rubocop_todo/rspec/example_wording.yml b/.rubocop_todo/rspec/example_wording.yml
new file mode 100644
index 0000000000000..712e7ae8d6968
--- /dev/null
+++ b/.rubocop_todo/rspec/example_wording.yml
@@ -0,0 +1,84 @@
+---
+# Cop supports --autocorrect.
+RSpec/ExampleWording:
+ Details: grace period
+ Exclude:
+ - 'ee/spec/controllers/projects/pipelines_controller_spec.rb'
+ - 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb'
+ - 'ee/spec/features/groups/group_settings_spec.rb'
+ - 'ee/spec/features/merge_request/user_creates_merge_request_spec.rb'
+ - 'ee/spec/features/projects/mirror_spec.rb'
+ - 'ee/spec/graphql/mutations/projects/product_analytics_project_settings_update_spec.rb'
+ - 'ee/spec/graphql/mutations/projects/project_settings_update_spec.rb'
+ - 'ee/spec/lib/code_suggestions/programming_language_spec.rb'
+ - 'ee/spec/lib/gitlab/llm/chain/utils/prompt_spec.rb'
+ - 'ee/spec/lib/product_analytics/settings_spec.rb'
+ - 'ee/spec/models/incident_management/issuable_resource_link_spec.rb'
+ - 'ee/spec/models/merge_request_spec.rb'
+ - 'ee/spec/models/namespace_setting_spec.rb'
+ - 'ee/spec/requests/api/graphql/mutations/projects/project_settings_update_spec.rb'
+ - 'ee/spec/requests/api/graphql/project/product_analytics/product_analytics_spec.rb'
+ - 'ee/spec/requests/api/groups_spec.rb'
+ - 'ee/spec/requests/projects/security/scanned_resources_controller_spec.rb'
+ - 'ee/spec/services/ai/store_repository_xray_service_spec.rb'
+ - 'ee/spec/services/ci/minutes/update_project_and_namespace_usage_service_spec.rb'
+ - 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb'
+ - 'ee/spec/services/merge_requests/reset_approvals_service_spec.rb'
+ - 'ee/spec/services/quick_actions/interpret_service_spec.rb'
+ - 'ee/spec/services/security/ingestion/schedule_mark_dropped_as_resolved_service_spec.rb'
+ - 'ee/spec/services/security/security_orchestration_policies/ci_action/custom_spec.rb'
+ - 'ee/spec/workers/ai/store_repository_xray_worker_spec.rb'
+ - 'qa/spec/specs/helpers/context_selector_spec.rb'
+ - 'spec/controllers/projects/milestones_controller_spec.rb'
+ - 'spec/features/groups/merge_requests_spec.rb'
+ - 'spec/features/issues/user_creates_issue_spec.rb'
+ - 'spec/features/issues/user_edits_issue_spec.rb'
+ - 'spec/features/profiles/user_edit_profile_spec.rb'
+ - 'spec/finders/user_group_notification_settings_finder_spec.rb'
+ - 'spec/graphql/types/global_id_type_spec.rb'
+ - 'spec/helpers/avatars_helper_spec.rb'
+ - 'spec/lib/backup/targets/database_spec.rb'
+ - 'spec/lib/banzai/reference_parser/base_parser_spec.rb'
+ - 'spec/lib/gitlab/application_setting_fetcher_spec.rb'
+ - 'spec/lib/gitlab/auth/current_user_mode_spec.rb'
+ - 'spec/lib/gitlab/database/batch_count_spec.rb'
+ - 'spec/lib/gitlab/database/bump_sequences_spec.rb'
+ - 'spec/lib/gitlab/database/migrations/sidekiq_helpers_spec.rb'
+ - 'spec/lib/gitlab/database/partitioning/partition_manager_spec.rb'
+ - 'spec/lib/gitlab/git/diff_spec.rb'
+ - 'spec/models/concerns/issuable_spec.rb'
+ - 'spec/models/deployment_spec.rb'
+ - 'spec/models/packages/debian/publication_spec.rb'
+ - 'spec/models/packages/maven/metadatum_spec.rb'
+ - 'spec/models/packages/package_spec.rb'
+ - 'spec/models/packages/pypi/metadatum_spec.rb'
+ - 'spec/models/packages/rpm/metadatum_spec.rb'
+ - 'spec/models/project_spec.rb'
+ - 'spec/models/releases/link_spec.rb'
+ - 'spec/models/user_spec.rb'
+ - 'spec/requests/api/deployments_spec.rb'
+ - 'spec/requests/api/environments_spec.rb'
+ - 'spec/requests/projects/releases_controller_spec.rb'
+ - 'spec/requests/users_controller_spec.rb'
+ - 'spec/rubocop/cop/background_migration/feature_category_spec.rb'
+ - 'spec/serializers/build_details_entity_spec.rb'
+ - 'spec/services/merge_requests/squash_service_spec.rb'
+ - 'spec/services/notification_service_spec.rb'
+ - 'spec/services/quick_actions/interpret_service_spec.rb'
+ - 'spec/services/users/destroy_service_spec.rb'
+ - 'spec/services/users/migrate_records_to_ghost_user_service_spec.rb'
+ - 'spec/support/shared_examples/graphql/mutations/members/bulk_update_shared_examples.rb'
+ - 'spec/support/shared_examples/namespaces/hierarchy_examples.rb'
+ - 'spec/support/shared_examples/quick_actions/issuable/max_issuable_examples.rb'
+ - 'spec/support/shared_examples/services/migrate_to_ghost_user_service_shared_examples.rb'
+ - 'spec/support/shared_examples/uploaders/upload_type_shared_examples.rb'
+ - 'spec/tasks/gitlab/db/cells/bump_cell_sequences_rake_spec.rb'
+ - 'spec/tasks/gitlab/db/decomposition/rollback/bump_ci_sequences_rake_spec.rb'
+ - 'spec/tooling/lib/tooling/api/job_spec.rb'
+ - 'spec/uploaders/dependency_proxy/file_uploader_spec.rb'
+ - 'spec/views/projects/jobs/_build.html.haml_spec.rb'
+ - 'spec/views/projects/jobs/_generic_commit_status.html.haml_spec.rb'
+ - 'spec/views/shared/projects/_list.html.haml_spec.rb'
+ - 'spec/workers/container_registry/delete_container_repository_worker_spec.rb'
+ - 'spec/workers/container_registry/record_data_repair_detail_worker_spec.rb'
+ - 'spec/workers/schedule_migrate_external_diffs_worker_spec.rb'
diff --git a/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml b/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml
index e896efc1c3dfd..090758a9abc24 100644
--- a/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml
+++ b/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml
@@ -1,5 +1,5 @@
---
-RSpec/FactoryBot/ExcessiveCreateList:
+FactoryBot/ExcessiveCreateList:
Exclude:
- 'ee/spec/controllers/groups/hooks_controller_spec.rb'
- 'ee/spec/features/search/elastic/global_search_spec.rb'
diff --git a/.rubocop_todo/style/arguments_forwarding.yml b/.rubocop_todo/style/arguments_forwarding.yml
index 8dc61c2c0dd10..2ad20f04fb222 100644
--- a/.rubocop_todo/style/arguments_forwarding.yml
+++ b/.rubocop_todo/style/arguments_forwarding.yml
@@ -3,167 +3,212 @@
Style/ArgumentsForwarding:
Details: grace period
Exclude:
- - 'app/controllers/chaos_controller.rb'
- - 'app/finders/clusters/knative_services_finder.rb'
- - 'app/finders/group_finder.rb'
- - 'app/graphql/mutations/ci/runner/create.rb'
- - 'app/graphql/mutations/design_management/move.rb'
- - 'app/graphql/mutations/todos/mark_all_done.rb'
- - 'app/graphql/resolvers/concerns/caching_array_resolver.rb'
- - 'app/helpers/emoji_helper.rb'
- - 'app/helpers/issuables_helper.rb'
- - 'app/helpers/namespaces_helper.rb'
- - 'app/helpers/notify_helper.rb'
- - 'app/helpers/routing/groups/members_helper.rb'
- - 'app/helpers/routing/pipeline_schedules_helper.rb'
- - 'app/helpers/routing/projects/members_helper.rb'
- - 'app/helpers/routing/projects_helper.rb'
- - 'app/helpers/routing/snippets_helper.rb'
- - 'app/helpers/wiki_helper.rb'
- - 'app/helpers/workhorse_helper.rb'
+ - 'app/controllers/admin/users_controller.rb'
+ - 'app/controllers/application_controller.rb'
+ - 'app/controllers/concerns/product_analytics_tracking.rb'
+ - 'app/controllers/concerns/sessionless_authentication.rb'
+ - 'app/controllers/oauth/applications_controller.rb'
+ - 'app/controllers/repositories/git_http_client_controller.rb'
+ - 'app/graphql/types/permission_types/base_permission_type.rb'
+ - 'app/helpers/application_helper.rb'
+ - 'app/helpers/merge_requests_helper.rb'
+ - 'app/mailers/application_mailer.rb'
- 'app/models/application_record.rb'
- - 'app/models/ci/build.rb'
+ - 'app/models/ci/build_trace_chunk.rb'
+ - 'app/models/ci/partition.rb'
+ - 'app/models/ci/runner.rb'
+ - 'app/models/ci/unlock_pipeline_request.rb'
- 'app/models/commit.rb'
- 'app/models/commit_collection.rb'
- - 'app/models/concerns/as_cte.rb'
- - 'app/models/concerns/async_devise_email.rb'
- - 'app/models/concerns/optionally_search.rb'
- - 'app/models/concerns/presentable.rb'
- - 'app/models/concerns/prometheus_adapter.rb'
- - 'app/models/concerns/reactive_caching.rb'
- - 'app/models/merge_request.rb'
- - 'app/models/merge_request_context_commit.rb'
- - 'app/models/merge_request_context_commit_diff_file.rb'
+ - 'app/models/concerns/after_commit_queue.rb'
+ - 'app/models/concerns/cross_database_ignored_tables.rb'
+ - 'app/models/concerns/redis_cacheable.rb'
- 'app/models/network/commit.rb'
+ - 'app/models/project.rb'
+ - 'app/models/system/broadcast_message.rb'
+ - 'app/models/wiki.rb'
- 'app/presenters/gitlab/blame_presenter.rb'
- - 'app/services/ci/prometheus_metrics/observe_histograms_service.rb'
- - 'app/services/concerns/rate_limited_service.rb'
- - 'app/services/issuable_base_service.rb'
- - 'app/services/members/creator_service.rb'
- - 'app/services/notification_recipients/build_service.rb'
- - 'app/services/notification_service.rb'
+ - 'app/services/base_count_service.rb'
+ - 'app/services/concerns/projects/remove_refs.rb'
+ - 'app/services/packages/terraform_module/process_package_file_service.rb'
+ - 'app/services/projects/forks/sync_service.rb'
+ - 'app/services/projects/lfs_pointers/lfs_download_link_list_service.rb'
+ - 'app/services/projects/lfs_pointers/lfs_download_service.rb'
+ - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb'
+ - 'app/services/protected_branches/cache_service.rb'
+ - 'app/services/user_project_access_changed_service.rb'
- 'app/services/users/update_service.rb'
- - 'app/workers/authorized_keys_worker.rb'
- - 'app/workers/concerns/limited_capacity/worker.rb'
- - 'app/workers/concerns/reactive_cacheable_worker.rb'
- - 'app/workers/concerns/reenqueuer.rb'
- - 'app/workers/pages_worker.rb'
+ - 'app/workers/authorized_project_update/user_refresh_from_replica_worker.rb'
+ - 'app/workers/concerns/limited_capacity/job_tracker.rb'
+ - 'app/workers/container_expiration_policies/cleanup_container_repository_worker.rb'
+ - 'app/workers/container_expiration_policy_worker.rb'
+ - 'app/workers/dependency_proxy/image_ttl_group_policy_worker.rb'
+ - 'app/workers/gitlab_performance_bar_stats_worker.rb'
+ - 'app/workers/packages/cleanup/delete_orphaned_dependencies_worker.rb'
+ - 'app/workers/packages/cleanup_package_registry_worker.rb'
+ - 'app/workers/projects/inactive_projects_deletion_cron_worker.rb'
- 'config/initializers/6_labkit_middleware.rb'
- - 'config/initializers/active_record_table_definition.rb'
- - 'config/initializers/postgresql_cte.rb'
- - 'ee/app/controllers/groups/analytics/application_controller.rb'
- - 'ee/app/helpers/ee/gitlab_routing_helper.rb'
- - 'ee/app/helpers/ee/saml_providers_helper.rb'
+ - 'config/initializers/mail_starttls_patch.rb'
+ - 'ee/app/controllers/ee/application_controller.rb'
+ - 'ee/app/models/ai/job_failure_analysis.rb'
+ - 'ee/app/models/ci/instance_runner_failed_jobs.rb'
+ - 'ee/app/models/dast_site_profile.rb'
- 'ee/app/models/ee/group.rb'
- 'ee/app/models/elastic/migration_record.rb'
- 'ee/app/models/license.rb'
- - 'ee/app/services/search/reindexing_service.rb'
- - 'ee/db/geo/migrate/20210504143244_add_verification_to_merge_request_diff_registry.rb'
- - 'ee/lib/analytics/forecasting/holt_winters_optimizer.rb'
- - 'ee/lib/analytics/merge_request_metrics_refresh.rb'
- - 'ee/lib/ee/gitlab/url_builder.rb'
- - 'ee/lib/elastic/latest/application_class_proxy.rb'
- - 'ee/lib/elastic/latest/query_context.rb'
- - 'ee/lib/elastic/latest/wiki_class_proxy.rb'
+ - 'ee/app/models/security/orchestration_policy_configuration.rb'
+ - 'ee/app/services/elastic/indexing_control_service.rb'
+ - 'ee/app/services/elastic/process_bookkeeping_service.rb'
+ - 'ee/app/services/external_status_checks/base_service.rb'
+ - 'ee/app/services/vulnerability_exports/exporters/csv_service.rb'
+ - 'ee/app/workers/compliance_management/merge_requests/compliance_violations_consistency_worker.rb'
+ - 'ee/lib/ee/gitlab/auth/ldap/user.rb'
+ - 'ee/lib/gitlab/elastic/document_reference.rb'
+ - 'ee/lib/gitlab/elastic/elasticsearch_enabled_cache.rb'
- 'ee/lib/gitlab/elastic/expr_name.rb'
- - 'ee/lib/gitlab/geo/replicator.rb'
- - 'ee/lib/gitlab/insights/reducers/base_reducer.rb'
- - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb'
- - 'ee/spec/lib/gitlab/auth/saml/membership_updater_spec.rb'
- - 'ee/spec/lib/gitlab/status_page/storage/s3_client_spec.rb'
- - 'ee/spec/models/protected_environment_spec.rb'
- - 'ee/spec/requests/api/graphql/boards/epic_lists_query_spec.rb'
- - 'ee/spec/services/status_page/publish_service_spec.rb'
- - 'lib/api/helpers.rb'
- - 'lib/api/helpers/caching.rb'
- - 'lib/api/helpers/pagination.rb'
- - 'lib/atlassian/jira_connect/jwt/asymmetric.rb'
- - 'lib/error_tracking/sentry_client/issue.rb'
- - 'lib/gitlab/auth/ldap/adapter.rb'
+ - 'ee/lib/gitlab/license_scanning/package_licenses.rb'
+ - 'ee/lib/gitlab/llm/chain/concerns/ai_dependent.rb'
+ - 'ee/lib/gitlab/llm/chain/tools/summarize_comments/executor.rb'
+ - 'ee/lib/gitlab/llm/chain/tools/tool.rb'
+ - 'ee/lib/gitlab/llm/chat_storage.rb'
+ - 'ee/lib/gitlab/llm/concerns/exponential_backoff.rb'
+ - 'ee/lib/gitlab/llm/tanuki_bot.rb'
+ - 'ee/lib/gitlab/package_metadata/connector/gcp.rb'
+ - 'ee/lib/search/zoekt/cache.rb'
+ - 'ee/lib/security/scan_result_policies/policy_violation_comment.rb'
+ - 'lib/api/helpers/internal_helpers.rb'
+ - 'lib/backup/targets/database.rb'
+ - 'lib/banzai/reference_parser/base_parser.rb'
+ - 'lib/bitbucket/exponential_backoff.rb'
+ - 'lib/bitbucket_server/retry_with_delay.rb'
+ - 'lib/bulk_imports/clients/http.rb'
+ - 'lib/error_tracking/sentry_client.rb'
+ - 'lib/gitlab/application_context.rb'
+ - 'lib/gitlab/application_rate_limiter/base_strategy.rb'
- 'lib/gitlab/auth/ldap/dn.rb'
- - 'lib/gitlab/cache.rb'
- - 'lib/gitlab/ci/parsers.rb'
- - 'lib/gitlab/ci/pipeline/expression/token.rb'
- - 'lib/gitlab/config/entry/configurable.rb'
+ - 'lib/gitlab/avatar_cache.rb'
+ - 'lib/gitlab/background_migration/job_coordinator.rb'
+ - 'lib/gitlab/cache/ci/project_pipeline_status.rb'
+ - 'lib/gitlab/cache/import/caching.rb'
+ - 'lib/gitlab/changes_list.rb'
+ - 'lib/gitlab/ci/config/interpolation/config.rb'
+ - 'lib/gitlab/ci/pipeline/logger.rb'
+ - 'lib/gitlab/ci/secure_files/migration_helper.rb'
+ - 'lib/gitlab/ci/trace.rb'
+ - 'lib/gitlab/ci/variables/collection.rb'
+ - 'lib/gitlab/ci/variables/collection/sort.rb'
+ - 'lib/gitlab/ci/yaml_processor/dag.rb'
+ - 'lib/gitlab/circuit_breaker.rb'
+ - 'lib/gitlab/circuit_breaker/store.rb'
+ - 'lib/gitlab/cluster/lifecycle_events.rb'
+ - 'lib/gitlab/color_modes.rb'
+ - 'lib/gitlab/color_schemes.rb'
- 'lib/gitlab/config/entry/simplifiable.rb'
+ - 'lib/gitlab/container_repository/tags/cache.rb'
+ - 'lib/gitlab/counters/buffered_counter.rb'
- 'lib/gitlab/current_settings.rb'
+ - 'lib/gitlab/database/async_indexes/index_creator.rb'
+ - 'lib/gitlab/database/async_indexes/index_destructor.rb'
+ - 'lib/gitlab/database/background_migration/batch_metrics.rb'
+ - 'lib/gitlab/database/consistency.rb'
- 'lib/gitlab/database/load_balancing/connection_proxy.rb'
- - 'lib/gitlab/database/migration_helpers.rb'
- - 'lib/gitlab/git/diff.rb'
- - 'lib/gitlab/git/repository.rb'
+ - 'lib/gitlab/database/load_balancing/load_balancer.rb'
+ - 'lib/gitlab/database/load_balancing/session.rb'
+ - 'lib/gitlab/database/load_balancing/sticking.rb'
+ - 'lib/gitlab/database/lock_writes_manager.rb'
+ - 'lib/gitlab/database/migrations/background_migration_helpers.rb'
+ - 'lib/gitlab/database/migrations/lock_retry_mixin.rb'
+ - 'lib/gitlab/database/migrations/runner_backoff/communicator.rb'
+ - 'lib/gitlab/database/migrations/test_batched_background_runner.rb'
+ - 'lib/gitlab/database/partitioning/detached_partition_dropper.rb'
+ - 'lib/gitlab/database/partitioning/list/locking_configuration.rb'
+ - 'lib/gitlab/database/partitioning/partition_manager.rb'
+ - 'lib/gitlab/database/partitioning/sliding_list_strategy.rb'
+ - 'lib/gitlab/database/partitioning_migration_helpers/index_helpers.rb'
+ - 'lib/gitlab/database/postgres_partitioned_table.rb'
+ - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb'
+ - 'lib/gitlab/database/tables_locker.rb'
+ - 'lib/gitlab/database/tables_sorted_by_foreign_keys.rb'
+ - 'lib/gitlab/diff/highlight_cache.rb'
+ - 'lib/gitlab/diff/position_collection.rb'
+ - 'lib/gitlab/discussions_diff/file_collection.rb'
+ - 'lib/gitlab/discussions_diff/highlight_cache.rb'
+ - 'lib/gitlab/encrypted_configuration.rb'
+ - 'lib/gitlab/etag_caching/store.rb'
+ - 'lib/gitlab/external_authorization/cache.rb'
+ - 'lib/gitlab/git/cross_repo.rb'
+ - 'lib/gitlab/git/diff_collection.rb'
+ - 'lib/gitlab/git/diff_stats_collection.rb'
+ - 'lib/gitlab/gitaly_client/cleanup_service.rb'
- 'lib/gitlab/gitaly_client/storage_settings.rb'
- - 'lib/gitlab/gitaly_client/with_feature_flag_actors.rb'
- - 'lib/gitlab/github_import/client.rb'
- - 'lib/gitlab/gon_helper.rb'
- - 'lib/gitlab/graphql/authorize/authorize_resource.rb'
- - 'lib/gitlab/graphql/mount_mutation.rb'
- - 'lib/gitlab/import_export/attribute_cleaner.rb'
- - 'lib/gitlab/import_export/base/relation_factory.rb'
- - 'lib/gitlab/import_export/file_importer.rb'
- - 'lib/gitlab/import_export/json/ndjson_reader.rb'
- - 'lib/gitlab/import_export/json/ndjson_writer.rb'
- - 'lib/gitlab/import_export/saver.rb'
- - 'lib/gitlab/import_export/version_checker.rb'
- - 'lib/gitlab/jira/http_client.rb'
- - 'lib/gitlab/kubernetes/kubeconfig/template.rb'
+ - 'lib/gitlab/gpg.rb'
+ - 'lib/gitlab/graphql/laziness.rb'
+ - 'lib/gitlab/graphql/lazy.rb'
+ - 'lib/gitlab/health_checks/base_abstract_check.rb'
+ - 'lib/gitlab/http.rb'
+ - 'lib/gitlab/i18n.rb'
+ - 'lib/gitlab/import_export/json/streaming_serializer.rb'
+ - 'lib/gitlab/issues/rebalancing/state.rb'
+ - 'lib/gitlab/kubernetes/node.rb'
- 'lib/gitlab/legacy_github_import/client.rb'
+ - 'lib/gitlab/markdown_cache/redis/store.rb'
- 'lib/gitlab/memory/watchdog/configuration.rb'
- - 'lib/gitlab/metrics/prometheus.rb'
- - 'lib/gitlab/quick_actions/dsl.rb'
+ - 'lib/gitlab/merge_requests/mergeability/redis_interface.rb'
+ - 'lib/gitlab/metrics/transaction.rb'
+ - 'lib/gitlab/namespaced_session_store.rb'
+ - 'lib/gitlab/pagination/keyset/in_operator_optimization/order_by_columns.rb'
+ - 'lib/gitlab/popen.rb'
- 'lib/gitlab/rack_attack.rb'
+ - 'lib/gitlab/rack_attack/store.rb'
- 'lib/gitlab/redis/multi_store.rb'
+ - 'lib/gitlab/repository_archive_rate_limiter.rb'
- 'lib/gitlab/repository_cache.rb'
- - 'lib/gitlab/tracking.rb'
- - 'lib/gitlab/url_builder.rb'
- - 'lib/gitlab/usage/metrics/query.rb'
- - 'lib/gitlab_settings/settings.rb'
- - 'lib/kramdown/parser/atlassian_document_format.rb'
+ - 'lib/gitlab/repository_hash_cache.rb'
+ - 'lib/gitlab/repository_set_cache.rb'
+ - 'lib/gitlab/safe_request_loader.rb'
+ - 'lib/gitlab/search/recent_items.rb'
+ - 'lib/gitlab/set_cache.rb'
+ - 'lib/gitlab/shard_health_cache.rb'
+ - 'lib/gitlab/sidekiq_middleware/concurrency_limit/client.rb'
+ - 'lib/gitlab/sidekiq_middleware/concurrency_limit/concurrency_limit_service.rb'
+ - 'lib/gitlab/sidekiq_middleware/concurrency_limit/server.rb'
+ - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/client.rb'
+ - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb'
+ - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/server.rb'
+ - 'lib/gitlab/sidekiq_middleware/pause_control/client.rb'
+ - 'lib/gitlab/sidekiq_middleware/pause_control/pause_control_service.rb'
+ - 'lib/gitlab/sidekiq_middleware/pause_control/server.rb'
+ - 'lib/gitlab/sidekiq_middleware/pause_control/strategy_handler.rb'
+ - 'lib/gitlab/sidekiq_middleware/worker_context.rb'
+ - 'lib/gitlab/terraform/state_migration_helper.rb'
+ - 'lib/gitlab/themes.rb'
+ - 'lib/gitlab/utils/measuring.rb'
+ - 'lib/gitlab/workhorse.rb'
+ - 'lib/gitlab_settings.rb'
+ - 'lib/mattermost/client.rb'
+ - 'lib/object_storage/pending_direct_upload.rb'
- 'lib/uploaded_file.rb'
- - 'metrics_server/metrics_server.rb'
- - 'qa/qa/ee/resource/audit_events.rb'
- - 'qa/qa/ee/runtime/path.rb'
+ - 'lib/users/internal.rb'
+ - 'qa/qa/ee/page/insights/show.rb'
+ - 'qa/qa/ee/page/operations_dashboard.rb'
+ - 'qa/qa/page/admin/overview/users/show.rb'
- 'qa/qa/page/base.rb'
- - 'qa/qa/page/view.rb'
- - 'qa/qa/resource/api_fabricator.rb'
- - 'qa/qa/resource/base.rb'
- - 'qa/qa/resource/group_base.rb'
- - 'qa/qa/resource/group_runner.rb'
- - 'qa/qa/resource/project.rb'
- - 'qa/qa/resource/project_runner.rb'
- - 'qa/qa/resource/sandbox.rb'
- - 'qa/qa/runtime/feature.rb'
- - 'qa/qa/runtime/path.rb'
- - 'qa/qa/runtime/release.rb'
+ - 'qa/qa/page/component/blob_content.rb'
+ - 'qa/qa/page/component/snippet.rb'
+ - 'qa/qa/page/project/web_ide/vscode.rb'
+ - 'qa/qa/resource/protected_branch.rb'
+ - 'qa/qa/runtime/browser.rb'
- 'qa/qa/scenario/actable.rb'
- - 'qa/qa/scenario/template.rb'
- - 'qa/qa/specs/helpers/rspec.rb'
- - 'qa/qa/support/matchers/have_text.rb'
- - 'qa/qa/support/page/logging.rb'
- - 'qa/qa/tools/delete_subgroups.rb'
- - 'spec/features/projects/environments/environments_spec.rb'
- - 'spec/graphql/features/authorization_spec.rb'
- - 'spec/helpers/application_helper_spec.rb'
- - 'spec/helpers/timeboxes_helper_spec.rb'
- - 'spec/lib/gitlab/ci/build/artifacts/metadata_spec.rb'
- - 'spec/lib/gitlab/ci/status/bridge/factory_spec.rb'
- - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb'
- - 'spec/lib/gitlab/graphql/markdown_field_spec.rb'
- - 'spec/lib/gitlab/import_export/group/tree_saver_spec.rb'
+ - 'rubocop/code_reuse_helpers.rb'
- 'spec/lib/gitlab/pagination/offset_pagination_spec.rb'
- - 'spec/models/concerns/cache_markdown_field_spec.rb'
- - 'spec/requests/api/go_proxy_spec.rb'
- - 'spec/requests/api/graphql/project/error_tracking/sentry_errors_request_spec.rb'
- - 'spec/services/ci/expire_pipeline_cache_service_spec.rb'
- - 'spec/services/ci/retry_pipeline_service_spec.rb'
- - 'spec/support/factory_bot.rb'
- - 'spec/support/helpers/api_helpers.rb'
- - 'spec/support/helpers/database/trigger_helpers.rb'
- - 'spec/support/helpers/fast_rails_root.rb'
- - 'spec/support/helpers/features/dom_helpers.rb'
+ - 'spec/support/database/prevent_cross_database_modification.rb'
+ - 'spec/support/helpers/form_builder_helpers.rb'
- 'spec/support/helpers/git_http_helpers.rb'
- 'spec/support/helpers/graphql_helpers.rb'
- - 'spec/support/helpers/harbor_helper.rb'
- - 'spec/support/helpers/login_helpers.rb'
- - 'spec/support/helpers/merge_request_diff_helpers.rb'
- - 'spec/support/helpers/reactive_caching_helpers.rb'
- - 'spec/support/shared_examples/features/2fa_shared_examples.rb'
+ - 'spec/support/helpers/query_recorder.rb'
+ - 'spec/support/helpers/redis_commands/recorder.rb'
+ - 'spec/support/helpers/routes_helpers.rb'
+ - 'spec/support/helpers/stub_method_calls.rb'
+ - 'spec/support/matchers/internal_events_cli_matchers.rb'
+ - 'spec/support/protected_branch_helpers.rb'
+ - 'spec/support/sidekiq_middleware.rb'
diff --git a/.rubocop_todo/style/hash_each_methods.yml b/.rubocop_todo/style/hash_each_methods.yml
index 03be8f07ee713..8f7d98914e441 100644
--- a/.rubocop_todo/style/hash_each_methods.yml
+++ b/.rubocop_todo/style/hash_each_methods.yml
@@ -5,6 +5,7 @@ Style/HashEachMethods:
- 'app/graphql/resolvers/concerns/caching_array_resolver.rb'
- 'app/graphql/types/alert_management/severity_enum.rb'
- 'app/graphql/types/availability_enum.rb'
+ - 'app/graphql/types/ci/catalog/resources/verification_level_enum.rb'
- 'app/graphql/types/ci/code_quality_degradation_severity_enum.rb'
- 'app/graphql/types/ci/job_artifact_file_type_enum.rb'
- 'app/graphql/types/ci/pipeline_config_source_enum.rb'
@@ -27,53 +28,115 @@ Style/HashEachMethods:
- 'app/graphql/types/user_callout_feature_name_enum.rb'
- 'app/helpers/routing/pseudonymization_helper.rb'
- 'app/models/application_setting.rb'
+ - 'app/models/ci/pipeline.rb'
+ - 'app/models/concerns/bulk_insertable_associations.rb'
+ - 'app/services/packages/debian/process_package_file_service.rb'
- 'app/services/security/merge_reports_service.rb'
- 'config/initializers/6_validations.rb'
- 'config/initializers/8_gitaly.rb'
+ - 'db/post_migrate/20230905091059_sync_index_for_ci_stages_pipeline_id_bigint.rb'
+ - 'db/post_migrate/20230906102738_sync_index_for_ci_sources_pipelines_pipeline_id_bigint.rb'
+ - 'db/post_migrate/20240422070036_swap_ci_pipelines_pk_with_bigint_p_ci_builds_p_ci_stages.rb'
- 'ee/app/graphql/types/compliance_management/merge_requests/compliance_violation_reason_enum.rb'
- 'ee/app/graphql/types/compliance_management/merge_requests/compliance_violation_severity_enum.rb'
+ - 'ee/app/graphql/types/health_status_enum.rb'
- 'ee/app/graphql/types/incident_management/issuable_resource_link_type_enum.rb'
- 'ee/app/graphql/types/incident_management/oncall_rotation_length_unit_enum.rb'
- 'ee/app/graphql/types/security_report_summary_type.rb'
- 'ee/app/graphql/types/vulnerabilities_count_by_day_type.rb'
- 'ee/app/graphql/types/vulnerability/external_issue_link_external_tracker_enum.rb'
- - 'ee/app/graphql/types/vulnerability/external_issue_link_type_enum.rb'
- 'ee/app/graphql/types/vulnerability/issue_link_type_enum.rb'
- 'ee/app/graphql/types/vulnerability_grade_enum.rb'
- 'ee/app/graphql/types/vulnerability_report_type_enum.rb'
- 'ee/app/graphql/types/vulnerability_severities_count_type.rb'
- 'ee/app/graphql/types/vulnerability_severity_enum.rb'
- 'ee/app/models/geo/secondary_usage_data.rb'
+ - 'ee/app/services/elastic/cluster_reindexing_service.rb'
+ - 'ee/app/services/elastic/process_bookkeeping_service.rb'
+ - 'ee/app/services/security/security_orchestration_policies/ci_action/template.rb'
- 'ee/db/fixtures/development/32_compliance_report_violations.rb'
+ - 'ee/lib/gitlab/checks/secrets_check.rb'
+ - 'ee/lib/gitlab/code_owners/file.rb'
+ - 'ee/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate.rb'
+ - 'ee/lib/remote_development/workspaces/create/post_flatten_devfile_validator.rb'
+ - 'ee/spec/controllers/projects_controller_spec.rb'
- 'ee/spec/factories/vulnerabilities.rb'
- 'ee/spec/factories/vulnerabilities/findings.rb'
- 'ee/spec/helpers/application_helper_spec.rb'
+ - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb'
+ - 'ee/spec/lib/gitlab/database/desired_sharding_key_spec.rb'
- 'ee/spec/lib/gitlab/geo_spec.rb'
+ - 'ee/spec/lib/gitlab/insights/project_insights_config_spec.rb'
+ - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_secure_pipelines_metric_spec.rb'
+ - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_security_scans_metric_spec.rb'
+ - 'ee/spec/models/ee/namespace_spec.rb'
+ - 'ee/spec/models/package_metadata/sync_configuration_spec.rb'
+ - 'ee/spec/models/vulnerabilities/feedback_spec.rb'
+ - 'ee/spec/services/approval_rules/finalize_service_spec.rb'
+ - 'ee/spec/services/package_metadata/sync_service_spec.rb'
+ - 'ee/spec/workers/product_analytics/sync_funnels_worker_spec.rb'
+ - 'keeps/remove_duplicated_indexes.rb'
- 'lib/api/todos.rb'
+ - 'lib/backup/targets/database.rb'
+ - 'lib/feature/definition.rb'
- 'lib/gitlab/changelog/release.rb'
- 'lib/gitlab/ci/parsers.rb'
- 'lib/gitlab/ci/reports/test_suite.rb'
+ - 'lib/gitlab/config/entry/configurable.rb'
+ - 'lib/gitlab/database/load_balancing/configuration.rb'
+ - 'lib/gitlab/database/load_balancing/service_discovery/sampler.rb'
+ - 'lib/gitlab/dependency_linker/podspec_json_linker.rb'
+ - 'lib/gitlab/internal_events.rb'
+ - 'lib/gitlab/language_data.rb'
- 'lib/gitlab/metrics/samplers/ruby_sampler.rb'
- 'lib/gitlab/metrics/subscribers/active_record.rb'
- 'lib/gitlab/metrics/subscribers/load_balancing.rb'
- 'lib/gitlab/middleware/multipart.rb'
+ - 'lib/gitlab/repo_path.rb'
+ - 'lib/gitlab/seeder.rb'
+ - 'lib/gitlab/sidekiq_config.rb'
+ - 'lib/gitlab/utils/batch_loader.rb'
+ - 'lib/tasks/gitlab/db.rake'
+ - 'lib/tasks/gitlab/setup.rake'
+ - 'qa/qa/specs/features/api/3_create/repository/project_archive_compare_spec.rb'
+ - 'qa/qa/specs/features/ee/browser_ui/10_govern/change_vulnerability_status_spec.rb'
+ - 'qa/qa/tools/reliable_report.rb'
+ - 'qa/spec/specs/runner_spec.rb'
+ - 'scripts/generate_rspec_pipeline.rb'
+ - 'spec/config/settings_spec.rb'
- 'spec/controllers/projects_controller_spec.rb'
- 'spec/factories/ci/reports/codequality_degradations.rb'
- 'spec/finders/packages/group_packages_finder_spec.rb'
- 'spec/helpers/application_helper_spec.rb'
+ - 'spec/initializers/secret_token_spec.rb'
+ - 'spec/lib/gitlab/ci/parsers/terraform/tfplan_spec.rb'
- 'spec/lib/gitlab/ci/status/build/failed_spec.rb'
+ - 'spec/lib/gitlab/database/load_balancing/setup_spec.rb'
+ - 'spec/lib/gitlab/database/migrations/reestablished_connection_stack_spec.rb'
- 'spec/lib/gitlab/metrics/samplers/ruby_sampler_spec.rb'
+ - 'spec/lib/gitlab/tracking/incident_management_spec.rb'
+ - 'spec/models/ci/build_spec.rb'
- 'spec/models/ci/job_artifact_spec.rb'
- - 'spec/models/clusters/cluster_spec.rb'
+ - 'spec/models/deployment_spec.rb'
+ - 'spec/models/network/graph_spec.rb'
- 'spec/models/packages/package_spec.rb'
- 'spec/models/project_spec.rb'
+ - 'spec/models/state_note_spec.rb'
- 'spec/models/user_spec.rb'
- 'spec/presenters/ci/pipeline_presenter_spec.rb'
- 'spec/presenters/commit_status_presenter_spec.rb'
+ - 'spec/requests/api/project_templates_spec.rb'
- 'spec/services/system_notes/incident_service_spec.rb'
+ - 'spec/support/helpers/database/multiple_databases_helpers.rb'
- 'spec/support/helpers/multipart_helpers.rb'
- 'spec/support/helpers/reactive_caching_helpers.rb'
+ - 'spec/support/helpers/repo_helpers.rb'
- 'spec/support/import_export/project_tree_expectations.rb'
+ - 'spec/support/shared_examples/lib/gitlab/database/reestablished_connection_stack_shared_examples.rb'
+ - 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/npm_packages_shared_examples.rb'
- 'spec/support/shared_examples/services/packages_shared_examples.rb'
+ - 'spec/tooling/lib/tooling/find_codeowners_spec.rb'
+ - 'tooling/danger/analytics_instrumentation.rb'
- 'tooling/graphql/docs/helper.rb'
+ - 'tooling/lib/tooling/find_codeowners.rb'
diff --git a/.rubocop_todo/style/next.yml b/.rubocop_todo/style/next.yml
new file mode 100644
index 0000000000000..30a8f91220fce
--- /dev/null
+++ b/.rubocop_todo/style/next.yml
@@ -0,0 +1,6 @@
+---
+# Cop supports --autocorrect.
+Style/Next:
+ Details: grace period
+ Exclude:
+ - 'lib/gitlab/tracking/event_definition.rb'
diff --git a/.rubocop_todo/style/redundant_parentheses.yml b/.rubocop_todo/style/redundant_parentheses.yml
new file mode 100644
index 0000000000000..2e1664f532f3d
--- /dev/null
+++ b/.rubocop_todo/style/redundant_parentheses.yml
@@ -0,0 +1,42 @@
+---
+# Cop supports --autocorrect.
+Style/RedundantParentheses:
+ Details: grace period
+ Exclude:
+ - 'app/graphql/resolvers/concerns/caching_array_resolver.rb'
+ - 'app/graphql/resolvers/tree_resolver.rb'
+ - 'app/models/abuse/trust_score.rb'
+ - 'app/models/ci/build_metadata.rb'
+ - 'app/models/concerns/has_wiki_page_meta_attributes.rb'
+ - 'app/services/lfs/file_transformer.rb'
+ - 'app/services/members/invite_service.rb'
+ - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb'
+ - 'config/initializers/8_devise.rb'
+ - 'config/initializers/zz_metrics.rb'
+ - 'ee/app/controllers/groups/billings_controller.rb'
+ - 'ee/app/helpers/ee/projects_helper.rb'
+ - 'ee/app/models/push_rule.rb'
+ - 'ee/app/models/search/index.rb'
+ - 'ee/app/services/concerns/approval_rules/updater.rb'
+ - 'ee/app/services/merge_trains/refresh_service.rb'
+ - 'ee/lib/ee/gitlab/git_access.rb'
+ - 'ee/lib/ee/gitlab/scim/params_parser.rb'
+ - 'ee/lib/elastic/latest/git_class_proxy.rb'
+ - 'ee/spec/requests/lfs_locks_api_spec.rb'
+ - 'lib/api/appearance.rb'
+ - 'lib/file_size_validator.rb'
+ - 'lib/gitlab/database/query_analyzers/prevent_set_operator_mismatch/targets.rb'
+ - 'lib/gitlab/favicon.rb'
+ - 'lib/gitlab/github_import/importer/pull_requests/review_importer.rb'
+ - 'lib/gitlab/pagination/keyset/cursor_based_request_context.rb'
+ - 'lib/gitlab/usage/metrics/instrumentations/database_metric.rb'
+ - 'lib/gitlab/usage/time_frame.rb'
+ - 'lib/gitlab/utils/override.rb'
+ - 'qa/qa/page/base.rb'
+ - 'spec/lib/gitlab/usage/service_ping_report_spec.rb'
+ - 'spec/models/wiki_page_spec.rb'
+ - 'spec/requests/lfs_locks_api_spec.rb'
+ - 'spec/spec_helper.rb'
+ - 'spec/support/helpers/database/duplicate_indexes.rb'
+ - 'spec/support/helpers/login_helpers.rb'
+ - 'tooling/lib/tooling/helm3_client.rb'
diff --git a/.rubocop_todo/style/redundant_return.yml b/.rubocop_todo/style/redundant_return.yml
index eddbe3e4302bd..1fa9eab9b3188 100644
--- a/.rubocop_todo/style/redundant_return.yml
+++ b/.rubocop_todo/style/redundant_return.yml
@@ -3,17 +3,14 @@
Style/RedundantReturn:
Details: grace period
Exclude:
- - 'app/controllers/sent_notifications_controller.rb'
- 'app/controllers/snippets/notes_controller.rb'
- 'app/helpers/profiles_helper.rb'
- 'app/models/clusters/cluster.rb'
- 'app/models/concerns/cascading_namespace_setting_attribute.rb'
- - 'app/models/namespace.rb'
- 'app/models/namespaces/randomized_suffix_path.rb'
- 'app/models/notification_recipient.rb'
- 'app/models/packages/debian/publication.rb'
- 'app/models/releases/link.rb'
- - 'app/models/work_items/widgets/hierarchy.rb'
- 'app/presenters/packages/nuget/service_index_presenter.rb'
- 'app/presenters/packages/nuget/version_helpers.rb'
- 'app/services/boards/base_item_move_service.rb'
@@ -38,7 +35,6 @@ Style/RedundantReturn:
- 'ee/app/controllers/projects/vulnerability_feedback_controller.rb'
- 'ee/app/helpers/ee/application_helper.rb'
- 'ee/app/helpers/ee/boards_helper.rb'
- - 'ee/app/helpers/ee/personal_access_tokens_helper.rb'
- 'ee/app/models/geo/upload_registry.rb'
- 'ee/app/serializers/vulnerabilities/feedback_entity.rb'
- 'ee/app/serializers/vulnerabilities/finding_entity.rb'
@@ -46,16 +42,16 @@ Style/RedundantReturn:
- 'ee/app/serializers/vulnerabilities/merge_request_link_entity.rb'
- 'ee/app/services/audit_events/streaming/headers/base.rb'
- 'ee/app/services/ee/post_receive_service.rb'
- - 'ee/app/services/security/orchestration/assign_service.rb'
- 'ee/app/services/vulnerabilities/manually_create_service.rb'
- 'ee/app/workers/ee/repository_check/batch_worker.rb'
- 'ee/app/workers/ee/repository_check/single_repository_worker.rb'
- - 'ee/lib/api/dependency_proxy/packages/maven.rb'
- 'ee/lib/ee/api/entities/billable_member.rb'
+ - 'ee/lib/ee/gitlab/checks/diff_check.rb'
- 'lib/api/nuget_project_packages.rb'
- 'lib/api/pagination_params.rb'
- 'lib/feature/gitaly.rb'
- 'lib/gitlab/auth/database/authentication.rb'
+ - 'lib/gitlab/checks/diff_check.rb'
- 'lib/gitlab/ci/parsers/coverage/sax_document.rb'
- 'lib/gitlab/database/health_status/indicators/prometheus_alert_indicator.rb'
- 'lib/gitlab/graphql/queries.rb'
diff --git a/.rubocop_todo/style/self_assignment.yml b/.rubocop_todo/style/self_assignment.yml
new file mode 100644
index 0000000000000..830bcc7d4bfc4
--- /dev/null
+++ b/.rubocop_todo/style/self_assignment.yml
@@ -0,0 +1,6 @@
+---
+# Cop supports --autocorrect.
+Style/SelfAssignment:
+ Details: grace period
+ Exclude:
+ - 'app/serializers/entity_date_helper.rb'
diff --git a/Gemfile b/Gemfile
index 9285728f6f18a..9c3c9253b2dc3 100644
--- a/Gemfile
+++ b/Gemfile
@@ -470,7 +470,7 @@ group :development, :test do
gem 'spring', '~> 4.1.0' # rubocop:todo Gemfile/MissingFeatureCategory
gem 'spring-commands-rspec', '~> 1.0.4' # rubocop:todo Gemfile/MissingFeatureCategory
- gem 'gitlab-styles', '~> 11.0.0', feature_category: :tooling
+ gem 'gitlab-styles', '~> 12.0.1', feature_category: :tooling
gem 'haml_lint', '~> 0.57', feature_category: :tooling
gem 'bundler-audit', '~> 0.9.1', require: false # rubocop:todo Gemfile/MissingFeatureCategory
diff --git a/Gemfile.checksum b/Gemfile.checksum
index c3aed2477e52d..084b61c36e1f2 100644
--- a/Gemfile.checksum
+++ b/Gemfile.checksum
@@ -225,7 +225,7 @@
{"name":"gitlab-markup","version":"1.9.0","platform":"ruby","checksum":"7eda045a08ec2d110084252fa13a8c9eac8bdac0e302035ca7db4b82bcbd7ed4"},
{"name":"gitlab-net-dns","version":"0.9.2","platform":"ruby","checksum":"f726d978479d43810819f12a45c0906d775a07e34df111bbe693fffbbef3059d"},
{"name":"gitlab-sdk","version":"0.3.0","platform":"ruby","checksum":"22260f148451155c2e7bdfa1ea9f3e50061a7c31700cb80f8859713560b88903"},
-{"name":"gitlab-styles","version":"11.0.0","platform":"ruby","checksum":"0dd8ec066ce9955ac51d3616c6bfded30f75bb526f39ff392ece6f43d5b9406b"},
+{"name":"gitlab-styles","version":"12.0.1","platform":"ruby","checksum":"d8a302b0ab0e1f18e2d11501760f1b85c5e70b5e5ca628828a0786c7984ed133"},
{"name":"gitlab_chronic_duration","version":"0.12.0","platform":"ruby","checksum":"0d766944d415b5c831f176871ee8625783fc0c5bfbef2d79a3a616f207ffc16d"},
{"name":"gitlab_omniauth-ldap","version":"2.2.0","platform":"ruby","checksum":"bb4d20acb3b123ed654a8f6a47d3fac673ece7ed0b6992edb92dca14bad2838c"},
{"name":"gitlab_quality-test_tooling","version":"1.25.0","platform":"ruby","checksum":"5ca220140cbdb012e1c2e8094d6e1218fb8f6faa214bc4c19ab8aab4b16d97bc"},
@@ -588,14 +588,14 @@
{"name":"rspec-support","version":"3.12.0","platform":"ruby","checksum":"dd4d44b247ff679b95b5607ac5641d197a5f9b1d33f916123cb98fc5f917c58b"},
{"name":"rspec_junit_formatter","version":"0.6.0","platform":"ruby","checksum":"40dde674e6ae4e6cc0ff560da25497677e34fefd2338cc467a8972f602b62b15"},
{"name":"rspec_profiling","version":"0.0.9","platform":"ruby","checksum":"6199be2daeaa14bac3d10d704dbb0a8df052cf046332c505603263aea24f7590"},
-{"name":"rubocop","version":"1.57.2","platform":"ruby","checksum":"8f679dfe42d7821dc61dafb17d14b1294343157a197b9f8a23720ca17fb9161b"},
-{"name":"rubocop-ast","version":"1.29.0","platform":"ruby","checksum":"d1da2ab279a074baefc81758ac430c5768a8da8c7438dd4e5819ce5984d00ba1"},
-{"name":"rubocop-capybara","version":"2.19.0","platform":"ruby","checksum":"fa329e0f185be313fa5dabd6056f83a718db7f4a259aa97fc287a40254899ccb"},
-{"name":"rubocop-factory_bot","version":"2.24.0","platform":"ruby","checksum":"3018d350315277200c31c98a5297c9d19463536c04bdeba0a75a512e3975e9f8"},
-{"name":"rubocop-graphql","version":"0.19.0","platform":"ruby","checksum":"ba4b2fc91c9f0fda47e0870a6ae15a1e5525d6caffcb150dc88b00caaacc3e43"},
-{"name":"rubocop-performance","version":"1.19.1","platform":"ruby","checksum":"52664172d944eb45d478ed6d04c8b02c36cf0ee15726fabb6c90a95ca5cdfadf"},
-{"name":"rubocop-rails","version":"2.22.1","platform":"ruby","checksum":"db673cdb6321d8bb7627cd6cfb2cb36114acaa0e89581e4694b7304ce2acbd46"},
-{"name":"rubocop-rspec","version":"2.25.0","platform":"ruby","checksum":"083f8a0481dbb9969b2a9eae85670a454fe91d46812e6ec97b34e7f6227b99f3"},
+{"name":"rubocop","version":"1.62.1","platform":"ruby","checksum":"aeb1ec501aef5833617b3b6a1512303806218c349c28ce5b3ea72e3782ad4a35"},
+{"name":"rubocop-ast","version":"1.31.2","platform":"ruby","checksum":"7c206fb094553779923eca862aceece3913ce384f1bf85730208228e884578ec"},
+{"name":"rubocop-capybara","version":"2.20.0","platform":"ruby","checksum":"2a6844b942921f230ee3ab8c94fe77f41a9406096a140245270c0e11624bb938"},
+{"name":"rubocop-factory_bot","version":"2.25.1","platform":"ruby","checksum":"62751bde7af789878b8a31cbd2a82e69515ce7b23a2ad1820cb0fcc3e0150134"},
+{"name":"rubocop-graphql","version":"1.5.1","platform":"ruby","checksum":"9502d602a8e1ce73f996739ea3e8e248cf09da4d35e69b5560892af1972082eb"},
+{"name":"rubocop-performance","version":"1.20.2","platform":"ruby","checksum":"1bb1fa8c427fac7ba3c8dd2decb9860f23cb2d6c40350bedc88538de8875c731"},
+{"name":"rubocop-rails","version":"2.24.1","platform":"ruby","checksum":"03edf766954947468f3686cedb69142fae4f10e2007287f89cc0ea7072eeac19"},
+{"name":"rubocop-rspec","version":"2.27.1","platform":"ruby","checksum":"2f27ce04700be75db65afe83d7993a36e0fafd07ec062222f4b3cc10137a7a9e"},
{"name":"ruby-fogbugz","version":"0.3.0","platform":"ruby","checksum":"5e04cde474648f498a71cf1e1a7ab42c66b953862fbe224f793ec0a7a1d5f657"},
{"name":"ruby-lsp","version":"0.16.6","platform":"ruby","checksum":"eefd337ca6ff51b5ccf8a6b82161fde1477a36e75d78295ad6294318db5495cc"},
{"name":"ruby-lsp-rails","version":"0.3.5","platform":"ruby","checksum":"01e0410acb4ef4069716725e441857b2877776d5a4cd8959537d8a22bc7ce0b0"},
diff --git a/Gemfile.lock b/Gemfile.lock
index b42bc8d09601e..8e0554ce1003a 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -724,12 +724,13 @@ GEM
activesupport (>= 5.2.0)
rake (~> 13.0)
snowplow-tracker (~> 0.8.0)
- gitlab-styles (11.0.0)
- rubocop (~> 1.57.1)
- rubocop-graphql (~> 0.18)
- rubocop-performance (~> 1.15)
- rubocop-rails (~> 2.17)
- rubocop-rspec (~> 2.22)
+ gitlab-styles (12.0.1)
+ rubocop (~> 1.62.1)
+ rubocop-factory_bot (~> 2.25.1)
+ rubocop-graphql (~> 1.5.0)
+ rubocop-performance (~> 1.20.2)
+ rubocop-rails (~> 2.24.0)
+ rubocop-rspec (~> 2.27.1)
gitlab_chronic_duration (0.12.0)
numerizer (~> 0.2)
gitlab_omniauth-ldap (2.2.0)
@@ -1569,33 +1570,34 @@ GEM
activerecord
get_process_mem
rails
- rubocop (1.57.2)
+ rubocop (1.62.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
- parser (>= 3.2.2.4)
+ parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
- rubocop-ast (>= 1.28.1, < 2.0)
+ rubocop-ast (>= 1.31.1, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
- rubocop-ast (1.29.0)
- parser (>= 3.2.1.0)
- rubocop-capybara (2.19.0)
+ rubocop-ast (1.31.2)
+ parser (>= 3.3.0.4)
+ rubocop-capybara (2.20.0)
rubocop (~> 1.41)
- rubocop-factory_bot (2.24.0)
- rubocop (~> 1.33)
- rubocop-graphql (0.19.0)
- rubocop (>= 0.87, < 2)
- rubocop-performance (1.19.1)
- rubocop (>= 1.7.0, < 2.0)
- rubocop-ast (>= 0.4.0)
- rubocop-rails (2.22.1)
+ rubocop-factory_bot (2.25.1)
+ rubocop (~> 1.41)
+ rubocop-graphql (1.5.1)
+ rubocop (>= 0.90, < 2)
+ rubocop-performance (1.20.2)
+ rubocop (>= 1.48.1, < 2.0)
+ rubocop-ast (>= 1.30.0, < 2.0)
+ rubocop-rails (2.24.1)
activesupport (>= 4.2.0)
rack (>= 1.1)
rubocop (>= 1.33.0, < 2.0)
- rubocop-rspec (2.25.0)
+ rubocop-ast (>= 1.31.1, < 2.0)
+ rubocop-rspec (2.27.1)
rubocop (~> 1.40)
rubocop-capybara (~> 2.17)
rubocop-factory_bot (~> 2.22)
@@ -2013,7 +2015,7 @@ DEPENDENCIES
gitlab-sdk (~> 0.3.0)
gitlab-secret_detection!
gitlab-sidekiq-fetcher!
- gitlab-styles (~> 11.0.0)
+ gitlab-styles (~> 12.0.1)
gitlab-utils!
gitlab_chronic_duration (~> 0.12)
gitlab_omniauth-ldap (~> 2.2.0)
diff --git a/app/views/projects/blob/_editor.html.haml b/app/views/projects/blob/_editor.html.haml
index 211b8ecc78b1f..170eb3c388bb3 100644
--- a/app/views/projects/blob/_editor.html.haml
+++ b/app/views/projects/blob/_editor.html.haml
@@ -13,7 +13,7 @@
%span#editor_path
= params[:id]
- if current_action?(:edit, :update)
- - input_options = { id: 'file_path', name: 'file_path', value: (params[:file_path] || @path), class: 'new-file-path js-file-path-name-input' }
+ - input_options = { id: 'file_path', name: 'file_path', value: params[:file_path] || @path, class: 'new-file-path js-file-path-name-input' }
= render 'filepath_form', input_options: input_options
- if current_action?(:new, :create)
diff --git a/app/views/shared/_commit_message_container.html.haml b/app/views/shared/_commit_message_container.html.haml
index f420f176a11a8..53ea746f6c448 100644
--- a/app/views/shared/_commit_message_container.html.haml
+++ b/app/views/shared/_commit_message_container.html.haml
@@ -11,7 +11,7 @@
placeholder: local_assigns[:placeholder],
data: descriptions,
'data-testid': 'commit-message-field',
- required: true, rows: (local_assigns[:rows] || 3),
+ required: true, rows: local_assigns[:rows] || 3,
id: "commit_message-#{nonce}"
- if local_assigns[:hint]
%p.hint
diff --git a/ee/app/views/layouts/nav/_ask_duo_button.html.haml b/ee/app/views/layouts/nav/_ask_duo_button.html.haml
index 0fb891548fe0a..c20a10ce8d5cb 100644
--- a/ee/app/views/layouts/nav/_ask_duo_button.html.haml
+++ b/ee/app/views/layouts/nav/_ask_duo_button.html.haml
@@ -1,4 +1,4 @@
-- if ::Gitlab::Llm::TanukiBot.show_breadcrumbs_entry_point?(user: current_user, container: (@group || @project))
+- if ::Gitlab::Llm::TanukiBot.show_breadcrumbs_entry_point?(user: current_user, container: @group || @project)
- label = s_('DuoChat|GitLab Duo Chat')
= render Pajamas::ButtonComponent.new(variant: :default,
category: :secondary,
diff --git a/ee/spec/features/projects/pipelines/user_sees_security_tab_spec.rb b/ee/spec/features/projects/pipelines/user_sees_security_tab_spec.rb
index 82d0eb40bac07..027b2bec170c0 100644
--- a/ee/spec/features/projects/pipelines/user_sees_security_tab_spec.rb
+++ b/ee/spec/features/projects/pipelines/user_sees_security_tab_spec.rb
@@ -31,7 +31,7 @@
let!(:security_finding) do
create_list(
:security_finding,
- 21, # rubocop:disable RSpec/FactoryBot/ExcessiveCreateList -- see note above
+ 21, # rubocop:disable FactoryBot/ExcessiveCreateList -- see note above
:with_finding_data,
scanner: vulnerabilities_scanner,
scan: security_scan,
diff --git a/spec/features/environments/environments_folder_spec.rb b/spec/features/environments/environments_folder_spec.rb
index da9de6fba0c38..1deadf5bf8305 100644
--- a/spec/features/environments/environments_folder_spec.rb
+++ b/spec/features/environments/environments_folder_spec.rb
@@ -101,10 +101,10 @@ def redeploy_environment(environment)
end
describe 'pagination' do
- # rubocop:disable RSpec/FactoryBot/ExcessiveCreateList -- need >20 items to test pagination
+ # rubocop:disable FactoryBot/ExcessiveCreateList -- need >20 items to test pagination
let!(:envs) { create_list(:environment, 25, :with_folders, project: project, folder: folder_name) }
- # rubocop:enable RSpec/FactoryBot/ExcessiveCreateList
+ # rubocop:enable FactoryBot/ExcessiveCreateList
it 'shows pagination' do
pagination = find('.pagination')
--
GitLab