From ea2dceb7e49708dd2964ddf85c4d2c4c860366b8 Mon Sep 17 00:00:00 2001 From: gdk <gdk@example.com> Date: Sun, 3 Nov 2024 23:21:25 +0000 Subject: [PATCH] Finalize migration BackfillWorkItemParentLinksNamespaceId This migration was finished at `2024-04-30 18:45:05 UTC`, you can confirm the status using our [batched background migration chatops commands](https://docs.gitlab.com/ee/development/database/batched_background_migrations.html#monitor-the-progress-and-status-of-a-batched-background-migration). To confirm it is finished you can run: ``` /chatops run batched_background_migrations status 1000505 ``` The last time this background migration was triggered was in [db/post_migrate/20240419035508_queue_backfill_work_item_parent_links_namespace_id.rb](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/post_migrate/20240419035508_queue_backfill_work_item_parent_links_namespace_id.rb) You can read more about the process for finalizing batched background migrations in https://docs.gitlab.com/ee/development/database/batched_background_migrations.html . As part of our process we want to ensure all batched background migrations have had at least one [required stop](https://docs.gitlab.com/ee/development/database/required_stops.html) to process the migration. Therefore we can finalize any batched background migration that was added before the last required stop. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::OverdueFinalizeBackgroundMigration keep. To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other --- ...ll_work_item_parent_links_namespace_id.yml | 2 +- ...ill_work_item_parent_links_namespace_id.rb | 21 +++++++++++++++++++ db/schema_migrations/20241103232115 | 1 + 3 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 db/post_migrate/20241103232115_finalize_backfill_work_item_parent_links_namespace_id.rb create mode 100644 db/schema_migrations/20241103232115 diff --git a/db/docs/batched_background_migrations/backfill_work_item_parent_links_namespace_id.yml b/db/docs/batched_background_migrations/backfill_work_item_parent_links_namespace_id.yml index c8736c2c71151..a6895f85c6c1f 100644 --- a/db/docs/batched_background_migrations/backfill_work_item_parent_links_namespace_id.yml +++ b/db/docs/batched_background_migrations/backfill_work_item_parent_links_namespace_id.yml @@ -5,4 +5,4 @@ feature_category: team_planning introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/150075 milestone: '17.0' queued_migration_version: 20240419035508 -finalized_by: # version of the migration that finalized this BBM +finalized_by: '20241103232115' diff --git a/db/post_migrate/20241103232115_finalize_backfill_work_item_parent_links_namespace_id.rb b/db/post_migrate/20241103232115_finalize_backfill_work_item_parent_links_namespace_id.rb new file mode 100644 index 0000000000000..2af37e7d4ffd7 --- /dev/null +++ b/db/post_migrate/20241103232115_finalize_backfill_work_item_parent_links_namespace_id.rb @@ -0,0 +1,21 @@ +# frozen_string_literal: true + +class FinalizeBackfillWorkItemParentLinksNamespaceId < Gitlab::Database::Migration[2.2] + milestone '17.6' + + disable_ddl_transaction! + + restrict_gitlab_migration gitlab_schema: :gitlab_main_cell + + def up + ensure_batched_background_migration_is_finished( + job_class_name: 'BackfillWorkItemParentLinksNamespaceId', + table_name: :work_item_parent_links, + column_name: :id, + job_arguments: [:namespace_id, :issues, :namespace_id, :work_item_id], + finalize: true + ) + end + + def down; end +end diff --git a/db/schema_migrations/20241103232115 b/db/schema_migrations/20241103232115 new file mode 100644 index 0000000000000..ac61dc63d8173 --- /dev/null +++ b/db/schema_migrations/20241103232115 @@ -0,0 +1 @@ +067cfb58537fd6238feda2d20eab221b06ab4c45e7802714be6afb55aca20f09 \ No newline at end of file -- GitLab