diff --git a/.rubocop_todo/gitlab/documentation_links/link.yml b/.rubocop_todo/gitlab/documentation_links/link.yml index aea9ca22fe9c55ba7556152b0d152aeef38f0d6a..4920b53760bbef0f8e9cdc9293ee3fb53b971a3f 100644 --- a/.rubocop_todo/gitlab/documentation_links/link.yml +++ b/.rubocop_todo/gitlab/documentation_links/link.yml @@ -13,5 +13,4 @@ Gitlab/DocumentationLinks/Link: - 'ee/spec/support/shared_contexts/secrets_check_shared_contexts.rb' - 'lib/backup/tasks/database.rb' - 'lib/system_check/helpers.rb' - - 'spec/mailers/emails/pages_domains_spec.rb' - 'spec/presenters/commit_status_presenter_spec.rb' diff --git a/spec/mailers/emails/pages_domains_spec.rb b/spec/mailers/emails/pages_domains_spec.rb index 22f5c745654b6732c7f29480c16c099760f62ee0..db57d194e1dbc3bc0b65bc75fa822395dd801e55 100644 --- a/spec/mailers/emails/pages_domains_spec.rb +++ b/spec/mailers/emails/pages_domains_spec.rb @@ -35,7 +35,7 @@ it 'has the expected content' do is_expected.to have_body_text domain.url - is_expected.to have_body_text help_page_url('user/project/pages/custom_domains_ssl_tls_certification/_index.md', anchor: link_anchor) + is_expected.to have_body_text docs_url end end @@ -62,7 +62,7 @@ describe '#pages_domain_enabled_email' do let(:email_subject) { "#{project.name} | GitLab Pages domain '#{domain.domain}' has been enabled" } - let(:link_anchor) { 'steps' } + let(:docs_url) { help_page_url('user/project/pages/custom_domains_ssl_tls_certification/_index.md', anchor: 'steps') } subject { Notify.pages_domain_enabled_email(domain, user) } @@ -72,7 +72,7 @@ describe '#pages_domain_disabled_email' do let(:email_subject) { "#{project.name} | GitLab Pages domain '#{domain.domain}' has been disabled" } - let(:link_anchor) { '4-verify-the-domains-ownership' } + let(:docs_url) { help_page_url('user/project/pages/custom_domains_ssl_tls_certification/_index.md', anchor: '4-verify-the-domains-ownership') } subject { Notify.pages_domain_disabled_email(domain, user) } @@ -85,7 +85,7 @@ describe '#pages_domain_verification_succeeded_email' do let(:email_subject) { "#{project.name} | Verification succeeded for GitLab Pages domain '#{domain.domain}'" } - let(:link_anchor) { 'steps' } + let(:docs_url) { help_page_url('user/project/pages/custom_domains_ssl_tls_certification/_index.md', anchor: 'steps') } subject { Notify.pages_domain_verification_succeeded_email(domain, user) } @@ -96,7 +96,7 @@ describe '#pages_domain_verification_failed_email' do let(:email_subject) { "#{project.name} | ACTION REQUIRED: Verification failed for GitLab Pages domain '#{domain.domain}'" } - let(:link_anchor) { 'steps' } + let(:docs_url) { help_page_url('user/project/pages/custom_domains_ssl_tls_certification/_index.md', anchor: 'steps') } subject { Notify.pages_domain_verification_failed_email(domain, user) }