From e93ab0cd1e1533f9f70771e230d08748fde025fd Mon Sep 17 00:00:00 2001 From: dfrazao-gitlab <dfrazao@gitlab.com> Date: Fri, 10 Nov 2023 12:21:32 +0100 Subject: [PATCH] Remove `index_on_projects_path` index Remove duplicated index. Relates to: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/135366 Changelog: performance --- ...83355_remove_projects_duplicated_indexes.rb | 18 ++++++++++++++++++ db/schema_migrations/20231027083355 | 1 + db/structure.sql | 2 -- .../helpers/database/duplicate_indexes.yml | 5 ----- 4 files changed, 19 insertions(+), 7 deletions(-) create mode 100644 db/post_migrate/20231027083355_remove_projects_duplicated_indexes.rb create mode 100644 db/schema_migrations/20231027083355 diff --git a/db/post_migrate/20231027083355_remove_projects_duplicated_indexes.rb b/db/post_migrate/20231027083355_remove_projects_duplicated_indexes.rb new file mode 100644 index 000000000000..7911a60df3f0 --- /dev/null +++ b/db/post_migrate/20231027083355_remove_projects_duplicated_indexes.rb @@ -0,0 +1,18 @@ +# frozen_string_literal: true + +class RemoveProjectsDuplicatedIndexes < Gitlab::Database::Migration[2.2] + disable_ddl_transaction! + + milestone '16.6' + + INDEX_NAME = :index_on_projects_path + TABLE_NAME = :projects + + def up + remove_concurrent_index_by_name TABLE_NAME, INDEX_NAME + end + + def down + add_concurrent_index TABLE_NAME, :path, name: INDEX_NAME + end +end diff --git a/db/schema_migrations/20231027083355 b/db/schema_migrations/20231027083355 new file mode 100644 index 000000000000..2ceb53370679 --- /dev/null +++ b/db/schema_migrations/20231027083355 @@ -0,0 +1 @@ +ce4863f02f807498da9c3cf7b49d85a2e5a296903fe0673bfa6f40d50c8a51b5 \ No newline at end of file diff --git a/db/structure.sql b/db/structure.sql index ab1bf35fc90d..88b3952be9aa 100644 --- a/db/structure.sql +++ b/db/structure.sql @@ -33587,8 +33587,6 @@ CREATE UNIQUE INDEX index_on_project_id_escalation_policy_name_unique ON inciden CREATE INDEX index_on_projects_lower_path ON projects USING btree (lower((path)::text)); -CREATE INDEX index_on_projects_path ON projects USING btree (path); - CREATE INDEX index_on_routes_lower_path ON routes USING btree (lower((path)::text)); CREATE INDEX index_on_sbom_sources_package_manager_name ON sbom_sources USING btree ((((source -> 'package_manager'::text) ->> 'name'::text))); diff --git a/spec/support/helpers/database/duplicate_indexes.yml b/spec/support/helpers/database/duplicate_indexes.yml index 57ce762bbdac..1ebc45a9d817 100644 --- a/spec/support/helpers/database/duplicate_indexes.yml +++ b/spec/support/helpers/database/duplicate_indexes.yml @@ -167,11 +167,6 @@ project_repositories: project_topics: index_project_topics_on_project_id_and_topic_id: - index_project_topics_on_project_id -projects: - index_projects_api_path_id_desc: - - index_on_projects_path - index_projects_on_path_and_id: - - index_on_projects_path protected_environments: index_protected_environments_on_project_id_and_name: - index_protected_environments_on_project_id -- GitLab