From e4616cabbb8dd1031f8efa286e1fbb87978805a9 Mon Sep 17 00:00:00 2001
From: Tiger <twatson@gitlab.com>
Date: Tue, 16 Jan 2024 09:35:07 +0800
Subject: [PATCH] Change db/docs Roulette category to database
These dictionary entries have evolved to include more than
just documentation (for example, defining sharding keys),
so changes should now require a database review.
---
spec/tooling/danger/project_helper_spec.rb | 1 +
tooling/danger/project_helper.rb | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/spec/tooling/danger/project_helper_spec.rb b/spec/tooling/danger/project_helper_spec.rb
index 90409ff55597..0b7bb18bcc3e 100644
--- a/spec/tooling/danger/project_helper_spec.rb
+++ b/spec/tooling/danger/project_helper_spec.rb
@@ -120,6 +120,7 @@
'db/schema.rb' | [:database]
'db/structure.sql' | [:database]
+ 'db/docs/example.yml' | [:database]
'db/migrate/foo' | [:database]
'db/post_migrate/foo' | [:database]
'ee/db/geo/migrate/foo' | [:database]
diff --git a/tooling/danger/project_helper.rb b/tooling/danger/project_helper.rb
index bf2dba640659..5cfc92b1625d 100644
--- a/tooling/danger/project_helper.rb
+++ b/tooling/danger/project_helper.rb
@@ -35,7 +35,6 @@ module ProjectHelper
%r{\Adoc/.*(\.(md|png|gif|jpg|yml))\z} => :docs,
%r{\A(CONTRIBUTING|LICENSE|MAINTENANCE|PHILOSOPHY|PROCESS|README)(\.md)?\z} => :docs,
%r{\Adata/whats_new/} => :docs,
- %r{\Adb/docs/.+\.yml\z} => :docs,
%r{\Adata/deprecations/} => :none,
%r{\Adata/removals/} => :none,
@@ -100,6 +99,7 @@ module ProjectHelper
%r{\A((ee|jh)/)?db/(geo/)?(?!click_house|fixtures)[^/]+} => [:database],
%r{\A((ee|jh)/)?db/[^/]+\z} => [:database], # db/ root files
+ %r{\Adb/docs/.+\.yml\z} => [:database],
%r{\A((ee|jh)/)?lib/(ee/)?gitlab/(database|background_migration|sql)(/|\.rb)} => [:database, :backend],
%r{\A(app/services/authorized_project_update/find_records_due_for_refresh_service)(/|\.rb)} => [:database, :backend],
%r{\A(app/models/project_authorization|app/services/users/refresh_authorized_projects_service)(/|\.rb)} => [:database, :backend],
--
GitLab