diff --git a/.rubocop.yml b/.rubocop.yml index 5948fe9aff1a068f30b93eb3d8515e16234851c1..b6f7bd3da8cb188d8c287d9a0c0daaafffa24d3f 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -369,7 +369,6 @@ RSpec/LeakyConstantDeclaration: - 'spec/services/clusters/applications/check_installation_progress_service_spec.rb' - 'spec/services/clusters/applications/check_uninstall_progress_service_spec.rb' - 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb' - - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' RSpec/EmptyLineAfterHook: Enabled: false diff --git a/changelogs/unreleased/leaky-constant-fix-3.yml b/changelogs/unreleased/leaky-constant-fix-3.yml new file mode 100644 index 0000000000000000000000000000000000000000..3ad8fd7a15f09f97f819b2fbb3d2aa70b441cb7e --- /dev/null +++ b/changelogs/unreleased/leaky-constant-fix-3.yml @@ -0,0 +1,5 @@ +--- +title: Add class stubs and fix leaky constant alert in query limit helper spec +merge_request: 31949 +author: Rajendra Kadam +type: fixed diff --git a/spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb b/spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb index 3b15d804d7c450216012f1735fc75d9be87fd6d7..4a711b43d9aa2cdb25ee18deb2d539046fe23c8f 100644 --- a/spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb +++ b/spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb @@ -3,16 +3,21 @@ require 'spec_helper' describe ExceedQueryLimitHelpers do - class TestQueries < ActiveRecord::Base - self.table_name = 'schema_migrations' - end + before do + stub_const('TestQueries', Class.new(ActiveRecord::Base)) + stub_const('TestMatcher', Class.new) + + TestQueries.class_eval do + self.table_name = 'schema_migrations' + end - class TestMatcher - include ExceedQueryLimitHelpers + TestMatcher.class_eval do + include ExceedQueryLimitHelpers - def expected - ActiveRecord::QueryRecorder.new do - 2.times { TestQueries.count } + def expected + ActiveRecord::QueryRecorder.new do + 2.times { TestQueries.count } + end end end end