diff --git a/spec/models/protectable_dropdown_spec.rb b/spec/models/protectable_dropdown_spec.rb index aca3df9fdde0e9e2e8dcf5081aa77989ebb7992c..c51197234ca2d62259a36d8f18a79691d8237d7b 100644 --- a/spec/models/protectable_dropdown_spec.rb +++ b/spec/models/protectable_dropdown_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ProtectableDropdown do +RSpec.describe ProtectableDropdown do let(:project) { create(:project, :repository) } let(:subject) { described_class.new(project, :branches) } diff --git a/spec/models/protected_branch/merge_access_level_spec.rb b/spec/models/protected_branch/merge_access_level_spec.rb index 39dd586b1570d3064218b1d947adc44352cdb99d..b6c2d527d1bc5f68708d89f2f3fec55d6ff3fdd5 100644 --- a/spec/models/protected_branch/merge_access_level_spec.rb +++ b/spec/models/protected_branch/merge_access_level_spec.rb @@ -2,6 +2,6 @@ require 'spec_helper' -describe ProtectedBranch::MergeAccessLevel do +RSpec.describe ProtectedBranch::MergeAccessLevel do it { is_expected.to validate_inclusion_of(:access_level).in_array([Gitlab::Access::MAINTAINER, Gitlab::Access::DEVELOPER, Gitlab::Access::NO_ACCESS]) } end diff --git a/spec/models/protected_branch/push_access_level_spec.rb b/spec/models/protected_branch/push_access_level_spec.rb index 628c8d29ecd61ba9e102b9399b3bb468684164fe..77fe9814c863bf8570b8d1d0f68809805832c8c1 100644 --- a/spec/models/protected_branch/push_access_level_spec.rb +++ b/spec/models/protected_branch/push_access_level_spec.rb @@ -2,6 +2,6 @@ require 'spec_helper' -describe ProtectedBranch::PushAccessLevel do +RSpec.describe ProtectedBranch::PushAccessLevel do it { is_expected.to validate_inclusion_of(:access_level).in_array([Gitlab::Access::MAINTAINER, Gitlab::Access::DEVELOPER, Gitlab::Access::NO_ACCESS]) } end diff --git a/spec/models/protected_branch_spec.rb b/spec/models/protected_branch_spec.rb index 30fce1cd5c4cdf4a371567f9e8ec1cf046224308..a89f8778780f8dd98ca49491a0afe285b91910af 100644 --- a/spec/models/protected_branch_spec.rb +++ b/spec/models/protected_branch_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ProtectedBranch do +RSpec.describe ProtectedBranch do subject { build_stubbed(:protected_branch) } describe 'Associations' do diff --git a/spec/models/protected_tag_spec.rb b/spec/models/protected_tag_spec.rb index 79120d17d3934f4a1944f3f85d528082271b6318..7bc62b1d0e7f4daad47a9c1816a93fc61ba332fe 100644 --- a/spec/models/protected_tag_spec.rb +++ b/spec/models/protected_tag_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ProtectedTag do +RSpec.describe ProtectedTag do describe 'Associations' do it { is_expected.to belong_to(:project) } end diff --git a/spec/models/push_event_payload_spec.rb b/spec/models/push_event_payload_spec.rb index 6b59ee5ee5764a6b0300bd91305d782392d50bca..32415ef4719971d10314de4a932fbd57a72243ba 100644 --- a/spec/models/push_event_payload_spec.rb +++ b/spec/models/push_event_payload_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe PushEventPayload do +RSpec.describe PushEventPayload do it_behaves_like 'having unique enum values' describe 'saving payloads' do diff --git a/spec/models/push_event_spec.rb b/spec/models/push_event_spec.rb index 5c1802669c197184efa82dc590e18f61fbf0813d..61e31e7c4e3a98823507b783b6661905f2cefa74 100644 --- a/spec/models/push_event_spec.rb +++ b/spec/models/push_event_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe PushEvent do +RSpec.describe PushEvent do let(:payload) { PushEventPayload.new } let(:event) do diff --git a/spec/models/readme_blob_spec.rb b/spec/models/readme_blob_spec.rb index 34182fa413fe5ae7afacc3a3e63e872b830fed38..95622d5525454b27f279749ad7d99f9707a69812 100644 --- a/spec/models/readme_blob_spec.rb +++ b/spec/models/readme_blob_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ReadmeBlob do +RSpec.describe ReadmeBlob do include FakeBlobHelpers describe 'policy' do diff --git a/spec/models/redirect_route_spec.rb b/spec/models/redirect_route_spec.rb index b9b2873f8f2edffe31b523da4ca4ee73bc624f2a..c6e35923b898b2a3ff09f4024bc84a801c3a0b77 100644 --- a/spec/models/redirect_route_spec.rb +++ b/spec/models/redirect_route_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe RedirectRoute do +RSpec.describe RedirectRoute do let(:group) { create(:group) } let!(:redirect_route) { group.redirect_routes.create(path: 'gitlabb') } diff --git a/spec/models/releases/evidence_spec.rb b/spec/models/releases/evidence_spec.rb index 927e2e9bbe6f494714ab7118f9dc47ea5d321a48..ca5d4b67b59049721de23cb38da7be4a552141e5 100644 --- a/spec/models/releases/evidence_spec.rb +++ b/spec/models/releases/evidence_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Releases::Evidence do +RSpec.describe Releases::Evidence do let_it_be(:project) { create(:project) } let(:release) { create(:release, project: project) } diff --git a/spec/models/releases/link_spec.rb b/spec/models/releases/link_spec.rb index 7533d1e6e5cecf74d8fb77e60b627d5d56cc7c02..4dc1e53d59ea626652d8d28bc82b58c55317b2d7 100644 --- a/spec/models/releases/link_spec.rb +++ b/spec/models/releases/link_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Releases::Link do +RSpec.describe Releases::Link do let(:release) { create(:release, project: project) } let(:project) { create(:project) } diff --git a/spec/models/releases/source_spec.rb b/spec/models/releases/source_spec.rb index d7af6fd90a6ec9b609f3fdfd608effe6f2c2a3b8..d10b2140550f02c6c6d580e275e4959f82c0bd49 100644 --- a/spec/models/releases/source_spec.rb +++ b/spec/models/releases/source_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Releases::Source do +RSpec.describe Releases::Source do let_it_be(:project) { create(:project, :repository, name: 'finance-cal') } let(:tag_name) { 'v1.0' } diff --git a/spec/models/remote_mirror_spec.rb b/spec/models/remote_mirror_spec.rb index 6d163a16e637d8a39caec7e3883d04a27d919be9..ebc9760ab14dcb3a0e045178d84f7e6f0a16da89 100644 --- a/spec/models/remote_mirror_spec.rb +++ b/spec/models/remote_mirror_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe RemoteMirror, :mailer do +RSpec.describe RemoteMirror, :mailer do include GitHelpers describe 'URL validation' do diff --git a/spec/models/repository_language_spec.rb b/spec/models/repository_language_spec.rb index 13a4cd1e7cfd60676bc0ea75265021743e27a573..8cf5e17086de5e2fa5a3abf962a0dddedf53e1e5 100644 --- a/spec/models/repository_language_spec.rb +++ b/spec/models/repository_language_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe RepositoryLanguage do +RSpec.describe RepositoryLanguage do let(:repository_language) { build(:repository_language) } describe 'associations' do diff --git a/spec/models/repository_spec.rb b/spec/models/repository_spec.rb index e2a148165ab1ae95bec24e63fcd75df1903d89c9..f373fcbc06273967d291003153ce7441a61e3d64 100644 --- a/spec/models/repository_spec.rb +++ b/spec/models/repository_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Repository do +RSpec.describe Repository do include RepoHelpers include GitHelpers diff --git a/spec/models/resource_milestone_event_spec.rb b/spec/models/resource_milestone_event_spec.rb index 66686ec77d09f7c1bf36cf19debae582d71c233a..76ffb358d806b7a00a3f8635b23d6953cf472bc0 100644 --- a/spec/models/resource_milestone_event_spec.rb +++ b/spec/models/resource_milestone_event_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ResourceMilestoneEvent, type: :model do +RSpec.describe ResourceMilestoneEvent, type: :model do it_behaves_like 'a resource event' it_behaves_like 'a resource event for issues' it_behaves_like 'a resource event for merge requests' diff --git a/spec/models/resource_state_event_spec.rb b/spec/models/resource_state_event_spec.rb index 986a13cbd0dda32074ec9ad8defa3e0c5cbfc5e4..1381b45cf9ea1a1a38d524cb52bbf7de06fa4287 100644 --- a/spec/models/resource_state_event_spec.rb +++ b/spec/models/resource_state_event_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ResourceStateEvent, type: :model do +RSpec.describe ResourceStateEvent, type: :model do subject { build(:resource_state_event, issue: issue) } let(:issue) { create(:issue) } diff --git a/spec/models/review_spec.rb b/spec/models/review_spec.rb index 9dd8b90feee3b6cf431e9ca6ddec63af24931228..2683dc93a4b54e6d68edc77a4ee84638ec009bb3 100644 --- a/spec/models/review_spec.rb +++ b/spec/models/review_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Review do +RSpec.describe Review do describe 'associations' do it { is_expected.to belong_to(:author).class_name('User').with_foreign_key(:author_id).inverse_of(:reviews) } it { is_expected.to belong_to(:merge_request).inverse_of(:reviews).touch(false) } diff --git a/spec/models/route_spec.rb b/spec/models/route_spec.rb index 20289afbeb5bc7a7f26f023a0353b5faacea2eaa..0f1637016d6c708e64b91e49b095e912c0676c3f 100644 --- a/spec/models/route_spec.rb +++ b/spec/models/route_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Route do +RSpec.describe Route do let(:group) { create(:group, path: 'git_lab', name: 'git_lab') } let(:route) { group.route } diff --git a/spec/models/sent_notification_spec.rb b/spec/models/sent_notification_spec.rb index 087bc95737328695591df18eea0cc7f71dd7c43f..aeafb49f8b54803ddd497f738fdada2ea6223cff 100644 --- a/spec/models/sent_notification_spec.rb +++ b/spec/models/sent_notification_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SentNotification do +RSpec.describe SentNotification do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project) } diff --git a/spec/models/sentry_issue_spec.rb b/spec/models/sentry_issue_spec.rb index b4c1cf57761ad90a1aa47776c60aa06cdde2fedd..33654bf5e1a3d047c40bc1349c4af8b0ef8b260d 100644 --- a/spec/models/sentry_issue_spec.rb +++ b/spec/models/sentry_issue_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SentryIssue do +RSpec.describe SentryIssue do describe 'associations' do it { is_expected.to belong_to(:issue) } end diff --git a/spec/models/serverless/domain_cluster_spec.rb b/spec/models/serverless/domain_cluster_spec.rb index f5e1eb304a111bf7f9a52fa5e2e4022b0a8e20db..fdae0483c19f9b0c5bfa1cdaa914cf219fa24ccf 100644 --- a/spec/models/serverless/domain_cluster_spec.rb +++ b/spec/models/serverless/domain_cluster_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ::Serverless::DomainCluster do +RSpec.describe ::Serverless::DomainCluster do subject { create(:serverless_domain_cluster) } describe 'validations' do diff --git a/spec/models/serverless/domain_spec.rb b/spec/models/serverless/domain_spec.rb index ba54e05b4e3ff5f7e1c819e2c8c85c061ae2feaf..f997b28b149315c9f5200be1cdff9261f2f03023 100644 --- a/spec/models/serverless/domain_spec.rb +++ b/spec/models/serverless/domain_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ::Serverless::Domain do +RSpec.describe ::Serverless::Domain do let(:function_name) { 'test-function' } let(:pages_domain_name) { 'serverless.gitlab.io' } let(:pages_domain) { create(:pages_domain, :instance_serverless, domain: pages_domain_name) } diff --git a/spec/models/serverless/function_spec.rb b/spec/models/serverless/function_spec.rb index 810d4409a341607c84ebfe51d005b7c1783c880c..632f5eba5c340323b441c3c1c1dcc3d0aa763842 100644 --- a/spec/models/serverless/function_spec.rb +++ b/spec/models/serverless/function_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ::Serverless::Function do +RSpec.describe ::Serverless::Function do let(:project) { create(:project) } let(:func) { described_class.new(project, 'test', 'test-ns') } diff --git a/spec/models/shard_spec.rb b/spec/models/shard_spec.rb index 4da86858b54f40422060e5597b503f86fcf2e17f..a9d11f4290c32bd7a5ab7c1ccd4a95076030ab39 100644 --- a/spec/models/shard_spec.rb +++ b/spec/models/shard_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Shard do +RSpec.describe Shard do describe '.populate!' do it 'creates shards based on the config file' do expect(described_class.all).to be_empty diff --git a/spec/models/snippet_blob_spec.rb b/spec/models/snippet_blob_spec.rb index 88441e39d45749fe16ecdd58b3fd1f1a54a8f084..19b985f66ee41b4b742d205b749c94533414ca4c 100644 --- a/spec/models/snippet_blob_spec.rb +++ b/spec/models/snippet_blob_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SnippetBlob do +RSpec.describe SnippetBlob do let(:snippet) { create(:snippet) } subject { described_class.new(snippet) } diff --git a/spec/models/snippet_input_action_collection_spec.rb b/spec/models/snippet_input_action_collection_spec.rb index ef18ab5a810194f4b804da62165facb6b0bbbe4a..3ec206bd0318f75997efa9b148bbcdf2dbef0507 100644 --- a/spec/models/snippet_input_action_collection_spec.rb +++ b/spec/models/snippet_input_action_collection_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SnippetInputActionCollection do +RSpec.describe SnippetInputActionCollection do let(:action_name) { 'create' } let(:action) { { action: action_name, file_path: 'foo', content: 'bar', previous_path: 'foobar' } } let(:data) { [action, action] } diff --git a/spec/models/snippet_input_action_spec.rb b/spec/models/snippet_input_action_spec.rb index 87ce2dac8ba265db8a6e68329070b0862674d469..43c2919735b5286515936c4f265234d4a3e56f68 100644 --- a/spec/models/snippet_input_action_spec.rb +++ b/spec/models/snippet_input_action_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SnippetInputAction do +RSpec.describe SnippetInputAction do describe 'validations' do using RSpec::Parameterized::TableSyntax diff --git a/spec/models/snippet_repository_spec.rb b/spec/models/snippet_repository_spec.rb index b86a6f82f0725a05c1fe1770b6da962d48eafc39..8c25d713c0a7c63aeba753aca47cf383c9db15d0 100644 --- a/spec/models/snippet_repository_spec.rb +++ b/spec/models/snippet_repository_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SnippetRepository do +RSpec.describe SnippetRepository do let_it_be(:user) { create(:user) } let(:snippet) { create(:personal_snippet, :repository, author: user) } let(:snippet_repository) { snippet.snippet_repository } diff --git a/spec/models/snippet_spec.rb b/spec/models/snippet_spec.rb index 4d6586c1df4d593cb53703c16d1d0b2e9571634b..e50207f48583773825ab1ed4d54de1e8cca3b30c 100644 --- a/spec/models/snippet_spec.rb +++ b/spec/models/snippet_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Snippet do +RSpec.describe Snippet do describe 'modules' do subject { described_class } diff --git a/spec/models/spam_log_spec.rb b/spec/models/spam_log_spec.rb index 8d0f247b5d6785d0c1b110964814c5524ca9ef9f..97a0dc27f17bb71a793468299cead231e7eed7b4 100644 --- a/spec/models/spam_log_spec.rb +++ b/spec/models/spam_log_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SpamLog do +RSpec.describe SpamLog do let_it_be(:admin) { create(:admin) } describe 'associations' do diff --git a/spec/models/ssh_host_key_spec.rb b/spec/models/ssh_host_key_spec.rb index a17cd8ba3458796167330b031143af40229e28ff..4d729d5585f7b0c7d609054b31f01b70834a945b 100644 --- a/spec/models/ssh_host_key_spec.rb +++ b/spec/models/ssh_host_key_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SshHostKey do +RSpec.describe SshHostKey do using RSpec::Parameterized::TableSyntax include ReactiveCachingHelpers diff --git a/spec/models/state_note_spec.rb b/spec/models/state_note_spec.rb index d3409315e4173444145ddc9db1ce83a12e9ec45c..5249c1be9cae4cbe40e2b7772919e2a2538b4f86 100644 --- a/spec/models/state_note_spec.rb +++ b/spec/models/state_note_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe StateNote do +RSpec.describe StateNote do describe '.from_event' do let_it_be(:author) { create(:user) } let_it_be(:project) { create(:project, :repository) } diff --git a/spec/models/subscription_spec.rb b/spec/models/subscription_spec.rb index 41bd48810b253a0375757faea669c6d053adb6c9..be85e6e10f40c1d854504d5b4c30cc9153ff24cb 100644 --- a/spec/models/subscription_spec.rb +++ b/spec/models/subscription_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Subscription do +RSpec.describe Subscription do describe 'relationships' do it { is_expected.to belong_to(:project) } it { is_expected.to belong_to(:subscribable) } diff --git a/spec/models/suggestion_spec.rb b/spec/models/suggestion_spec.rb index 2ac3ae0a5ad226079c6e895b3471eb2693680605..6a7e187f4f497a950eac463441459d3aa901b104 100644 --- a/spec/models/suggestion_spec.rb +++ b/spec/models/suggestion_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Suggestion do +RSpec.describe Suggestion do let(:suggestion) { create(:suggestion) } describe 'associations' do diff --git a/spec/models/system_note_metadata_spec.rb b/spec/models/system_note_metadata_spec.rb index 801f139355bd6a856c4207cc62e4731893c173e0..9a6b57afb97e94869ccf202fefe46f00ad82f885 100644 --- a/spec/models/system_note_metadata_spec.rb +++ b/spec/models/system_note_metadata_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SystemNoteMetadata do +RSpec.describe SystemNoteMetadata do describe 'associations' do it { is_expected.to belong_to(:note) } it { is_expected.to belong_to(:description_version) } diff --git a/spec/models/term_agreement_spec.rb b/spec/models/term_agreement_spec.rb index 42a48048b673c3aea4b7c1d1f26746aa8eb06df8..98c7a2daaddd40ea91849f5315e317cb47cd22a9 100644 --- a/spec/models/term_agreement_spec.rb +++ b/spec/models/term_agreement_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe TermAgreement do +RSpec.describe TermAgreement do describe 'validations' do it { is_expected.to validate_presence_of(:term) } it { is_expected.to validate_presence_of(:user) } diff --git a/spec/models/terraform/state_spec.rb b/spec/models/terraform/state_spec.rb index 3cd15e23ee2983cf5fe1ff0a815079de6bb924f9..00e67ad70db011ae940169968c56e7a1d33d2fbb 100644 --- a/spec/models/terraform/state_spec.rb +++ b/spec/models/terraform/state_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Terraform::State do +RSpec.describe Terraform::State do subject { create(:terraform_state, :with_file) } let(:terraform_state_file) { fixture_file('terraform/terraform.tfstate') } diff --git a/spec/models/todo_spec.rb b/spec/models/todo_spec.rb index bda89fc01f3ea99577653052046773110df22ce5..44e81455a6730a6eb27e5cc5d01ab26cc8dcf697 100644 --- a/spec/models/todo_spec.rb +++ b/spec/models/todo_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Todo do +RSpec.describe Todo do let(:issue) { create(:issue) } describe 'relationships' do diff --git a/spec/models/tree_spec.rb b/spec/models/tree_spec.rb index 7dde8459f9a148c45163d1c682dc3bfdc74b9309..1522d836f760f4c9675c47b756d787e49c1d06fc 100644 --- a/spec/models/tree_spec.rb +++ b/spec/models/tree_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Tree do +RSpec.describe Tree do let(:repository) { create(:project, :repository).repository } let(:sha) { repository.root_ref } diff --git a/spec/models/trending_project_spec.rb b/spec/models/trending_project_spec.rb index 39f5d686eb42ac7c6685410d517c0053ae56d0fb..802f8befbcd8eff7b4ffc807ffb003af306475eb 100644 --- a/spec/models/trending_project_spec.rb +++ b/spec/models/trending_project_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe TrendingProject do +RSpec.describe TrendingProject do let(:user) { create(:user) } let(:public_project1) { create(:project, :public, :repository) } let(:public_project2) { create(:project, :public, :repository) } diff --git a/spec/models/upload_spec.rb b/spec/models/upload_spec.rb index 8a64948d5704e7bb59fe1e019420c09c943bde88..18388b4cd83e0961b76f6929ff2a03d68ed8b314 100644 --- a/spec/models/upload_spec.rb +++ b/spec/models/upload_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Upload do +RSpec.describe Upload do describe 'associations' do it { is_expected.to belong_to(:model) } end diff --git a/spec/models/uploads/fog_spec.rb b/spec/models/uploads/fog_spec.rb index 72a169280af74c343a2fc8b918f10542bd52301c..899e6f2064c70641ca4f2f202361f3167ecb1a5c 100644 --- a/spec/models/uploads/fog_spec.rb +++ b/spec/models/uploads/fog_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Uploads::Fog do +RSpec.describe Uploads::Fog do let(:data_store) { described_class.new } before do diff --git a/spec/models/uploads/local_spec.rb b/spec/models/uploads/local_spec.rb index 374c3019edc9cb92c5e5acc268fb2bc7937fde25..d354b252b3934500179716bcb9a9ca28a7b27e8c 100644 --- a/spec/models/uploads/local_spec.rb +++ b/spec/models/uploads/local_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Uploads::Local do +RSpec.describe Uploads::Local do let(:data_store) { described_class.new } before do diff --git a/spec/models/user_agent_detail_spec.rb b/spec/models/user_agent_detail_spec.rb index 5c28511b44624692cbb1cbf097262cf516a5b767..e3f3d9c342b9f1f708a1c14627137c4379a44865 100644 --- a/spec/models/user_agent_detail_spec.rb +++ b/spec/models/user_agent_detail_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe UserAgentDetail do +RSpec.describe UserAgentDetail do describe '.submittable?' do it 'is submittable when not already submitted' do detail = build(:user_agent_detail) diff --git a/spec/models/user_callout_spec.rb b/spec/models/user_callout_spec.rb index a084b1ac66226fe655fa006dab625f69929810ad..cdf70dd519065418f256a58ad8d36de5ad26547f 100644 --- a/spec/models/user_callout_spec.rb +++ b/spec/models/user_callout_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe UserCallout do +RSpec.describe UserCallout do let!(:callout) { create(:user_callout) } it_behaves_like 'having unique enum values' diff --git a/spec/models/user_canonical_email_spec.rb b/spec/models/user_canonical_email_spec.rb index 54a4e96803363768d9e7ecc72a3907d9c0d30c84..8e26f68c09bc3759c51dfb7f1838e76bfa72686b 100644 --- a/spec/models/user_canonical_email_spec.rb +++ b/spec/models/user_canonical_email_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe UserCanonicalEmail do +RSpec.describe UserCanonicalEmail do it { is_expected.to belong_to(:user) } describe 'validations' do diff --git a/spec/models/user_custom_attribute_spec.rb b/spec/models/user_custom_attribute_spec.rb index d0981b2d771f035ceffe7897b1d9450f23a0286f..1a51ad662b01b4a5e647a6898e53c74b6a4b391b 100644 --- a/spec/models/user_custom_attribute_spec.rb +++ b/spec/models/user_custom_attribute_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe UserCustomAttribute do +RSpec.describe UserCustomAttribute do describe 'assocations' do it { is_expected.to belong_to(:user) } end diff --git a/spec/models/user_detail_spec.rb b/spec/models/user_detail_spec.rb index 2b2bfff7be240369dc58c86ac1fe428e573df824..407b82a7ac3871f96d4b1ffaaed028a170206e80 100644 --- a/spec/models/user_detail_spec.rb +++ b/spec/models/user_detail_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe UserDetail do +RSpec.describe UserDetail do it { is_expected.to belong_to(:user) } describe 'validations' do diff --git a/spec/models/user_highest_role_spec.rb b/spec/models/user_highest_role_spec.rb index b3c795f662349e231276188c04aee660b53eb401..3ae672cf7f77fdaacdeee46ce1f2feec91dcb9fa 100644 --- a/spec/models/user_highest_role_spec.rb +++ b/spec/models/user_highest_role_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe UserHighestRole do +RSpec.describe UserHighestRole do describe 'associations' do it { is_expected.to belong_to(:user).required } end diff --git a/spec/models/user_interacted_project_spec.rb b/spec/models/user_interacted_project_spec.rb index 83c66bf19698a6e755c7460a884b63297eddc9ae..2fec8be76e8f3077af75d190200f91e32041f0c1 100644 --- a/spec/models/user_interacted_project_spec.rb +++ b/spec/models/user_interacted_project_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe UserInteractedProject do +RSpec.describe UserInteractedProject do describe '.track' do subject { described_class.track(event) } diff --git a/spec/models/user_mentions/commit_user_mention_spec.rb b/spec/models/user_mentions/commit_user_mention_spec.rb index ebad3902d6b773672eabb99890616d7e734c2b92..91d28241650d4809dde104537195fab8040fc28e 100644 --- a/spec/models/user_mentions/commit_user_mention_spec.rb +++ b/spec/models/user_mentions/commit_user_mention_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe CommitUserMention do +RSpec.describe CommitUserMention do describe 'associations' do it { is_expected.to belong_to(:note) } end diff --git a/spec/models/user_mentions/issue_user_mention_spec.rb b/spec/models/user_mentions/issue_user_mention_spec.rb index ac29f3084b442d04a12140fbcd4b94d306115445..6faf598ee36271d97a176a8aaf2096f09f0e9446 100644 --- a/spec/models/user_mentions/issue_user_mention_spec.rb +++ b/spec/models/user_mentions/issue_user_mention_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe IssueUserMention do +RSpec.describe IssueUserMention do describe 'associations' do it { is_expected.to belong_to(:issue) } it { is_expected.to belong_to(:note) } diff --git a/spec/models/user_mentions/merge_request_user_mention_spec.rb b/spec/models/user_mentions/merge_request_user_mention_spec.rb index c5c7cebfaa50a07760e6402765b777245d8e8f24..10fcb126965a235ce02428431bf3a8da6c994ed3 100644 --- a/spec/models/user_mentions/merge_request_user_mention_spec.rb +++ b/spec/models/user_mentions/merge_request_user_mention_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MergeRequestUserMention do +RSpec.describe MergeRequestUserMention do describe 'associations' do it { is_expected.to belong_to(:merge_request) } it { is_expected.to belong_to(:note) } diff --git a/spec/models/user_mentions/snippet_user_mention_spec.rb b/spec/models/user_mentions/snippet_user_mention_spec.rb index 0e34a2dd5a1cc17e8f7baa0a3372f1e998b75447..0762e731a53ba673fa5785bad2b2cc1db12e61bc 100644 --- a/spec/models/user_mentions/snippet_user_mention_spec.rb +++ b/spec/models/user_mentions/snippet_user_mention_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SnippetUserMention do +RSpec.describe SnippetUserMention do describe 'associations' do it { is_expected.to belong_to(:snippet) } it { is_expected.to belong_to(:note) } diff --git a/spec/models/user_preference_spec.rb b/spec/models/user_preference_spec.rb index cf32d4eeca7480d6e673916f380294ed46fb97d8..27ddaea763d13bb4ed609b66c279e2dcdbed5ddc 100644 --- a/spec/models/user_preference_spec.rb +++ b/spec/models/user_preference_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe UserPreference do +RSpec.describe UserPreference do let(:user_preference) { create(:user_preference) } describe 'notes filters global keys' do diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index 3180651309e4887d92de523315230aec6138d5c8..01a908a34d7fb30e8902490a86323288ba9b174b 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe User do +RSpec.describe User do include ProjectForksHelper include TermsHelper include ExclusiveLeaseHelpers diff --git a/spec/models/user_status_spec.rb b/spec/models/user_status_spec.rb index fcc01cdae3db43a95358529d2a57c18263862fce..2c0664bd165e80daeb660125a433b808eb0c381a 100644 --- a/spec/models/user_status_spec.rb +++ b/spec/models/user_status_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe UserStatus do +RSpec.describe UserStatus do it { is_expected.to validate_presence_of(:user) } it { is_expected.to allow_value('smirk').for(:emoji) } diff --git a/spec/models/users_statistics_spec.rb b/spec/models/users_statistics_spec.rb index 4437a5469c619b304beba9bfa654df57481d3e86..b4b7ddb7c63a1d50eae3eb8be9d165b9b700968c 100644 --- a/spec/models/users_statistics_spec.rb +++ b/spec/models/users_statistics_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe UsersStatistics do +RSpec.describe UsersStatistics do let(:users_statistics) { build(:users_statistics) } describe 'scopes' do diff --git a/spec/models/web_ide_terminal_spec.rb b/spec/models/web_ide_terminal_spec.rb index 4103a26c75a1b4caca006d6f710539d6d6731b89..149fce33f43fb0594991e4579b9894b2567e2945 100644 --- a/spec/models/web_ide_terminal_spec.rb +++ b/spec/models/web_ide_terminal_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe WebIdeTerminal do +RSpec.describe WebIdeTerminal do let(:build) { create(:ci_build) } subject { described_class.new(build) } diff --git a/spec/models/wiki_page/meta_spec.rb b/spec/models/wiki_page/meta_spec.rb index 0255dd802cff1088af930ad2f265636970d60253..aaac72cbc684d2f027d8028729d94676b2d28048 100644 --- a/spec/models/wiki_page/meta_spec.rb +++ b/spec/models/wiki_page/meta_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe WikiPage::Meta do +RSpec.describe WikiPage::Meta do let_it_be(:project) { create(:project, :wiki_repo) } let_it_be(:other_project) { create(:project) } diff --git a/spec/models/wiki_page/slug_spec.rb b/spec/models/wiki_page/slug_spec.rb index 324dea6b3203eb5f6ea3da88339ffb631c5700d0..cf256c67277942b0114da75062d699543a66e93f 100644 --- a/spec/models/wiki_page/slug_spec.rb +++ b/spec/models/wiki_page/slug_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe WikiPage::Slug do +RSpec.describe WikiPage::Slug do let_it_be(:meta) { create(:wiki_page_meta) } describe 'Associations' do diff --git a/spec/models/wiki_page_spec.rb b/spec/models/wiki_page_spec.rb index 8f2da8ff9a1d74054217cf996e0efc108affdcd3..68446db7a108e509a63add42cc59cdee536def93 100644 --- a/spec/models/wiki_page_spec.rb +++ b/spec/models/wiki_page_spec.rb @@ -2,7 +2,7 @@ require "spec_helper" -describe WikiPage do +RSpec.describe WikiPage do let_it_be(:user) { create(:user) } let(:container) { create(:project, :wiki_repo) } let(:wiki) { Wiki.for_container(container, user) } diff --git a/spec/models/zoom_meeting_spec.rb b/spec/models/zoom_meeting_spec.rb index 3dad957a1ce221276d60ff57e156e06211af6214..00a0f92e848f45fb73181cb3510c51f6d48aa4d6 100644 --- a/spec/models/zoom_meeting_spec.rb +++ b/spec/models/zoom_meeting_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ZoomMeeting do +RSpec.describe ZoomMeeting do let(:project) { build(:project) } describe 'Factory' do diff --git a/spec/policies/alert_management/alert_policy_spec.rb b/spec/policies/alert_management/alert_policy_spec.rb index 0d7624a0142febefe2a2a7deb5931efd5586b315..3e08d8b4ccc52f46fe67d4aeab5ae225b6c211b9 100644 --- a/spec/policies/alert_management/alert_policy_spec.rb +++ b/spec/policies/alert_management/alert_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AlertManagement::AlertPolicy, :models do +RSpec.describe AlertManagement::AlertPolicy, :models do let(:alert) { create(:alert_management_alert) } let(:project) { alert.project } let(:user) { create(:user) } diff --git a/spec/policies/application_setting/term_policy_spec.rb b/spec/policies/application_setting/term_policy_spec.rb index 2b5b9758ec277d78d8af6277e00cc4a2d2b96028..00b48402fa6096df0b03d4ead3ad3c72b0b55a03 100644 --- a/spec/policies/application_setting/term_policy_spec.rb +++ b/spec/policies/application_setting/term_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ApplicationSetting::TermPolicy do +RSpec.describe ApplicationSetting::TermPolicy do include TermsHelper let_it_be(:term) { create(:term) } diff --git a/spec/policies/award_emoji_policy_spec.rb b/spec/policies/award_emoji_policy_spec.rb index 2e3693c58d7755e39e2378a586073bf07971ba65..bd34a656e12afa3437225842bbbf5c2c52a99f6b 100644 --- a/spec/policies/award_emoji_policy_spec.rb +++ b/spec/policies/award_emoji_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AwardEmojiPolicy do +RSpec.describe AwardEmojiPolicy do let(:user) { create(:user) } let(:award_emoji) { create(:award_emoji, awardable: awardable) } diff --git a/spec/policies/base_policy_spec.rb b/spec/policies/base_policy_spec.rb index 67f7452528a60a499e03cb8c003aafc27bdd794b..103f2e9bc39f9e5f0e4257ca7a87b3a985dff5cf 100644 --- a/spec/policies/base_policy_spec.rb +++ b/spec/policies/base_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe BasePolicy do +RSpec.describe BasePolicy do include ExternalAuthorizationServiceHelpers include AdminModeHelper diff --git a/spec/policies/blob_policy_spec.rb b/spec/policies/blob_policy_spec.rb index e48dd751a8fe45d1d65133bd0565e169dc0ff94a..fc46b25f25ccbbddee45017896ae939d866619a4 100644 --- a/spec/policies/blob_policy_spec.rb +++ b/spec/policies/blob_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe BlobPolicy, :enable_admin_mode do +RSpec.describe BlobPolicy, :enable_admin_mode do include_context 'ProjectPolicyTable context' include ProjectHelpers using RSpec::Parameterized::TableSyntax diff --git a/spec/policies/board_policy_spec.rb b/spec/policies/board_policy_spec.rb index 35eac8a02c435212903cc51786f22c1de3f09363..6940e75ec37e74f73a266e5ff79fe7afcb199ece 100644 --- a/spec/policies/board_policy_spec.rb +++ b/spec/policies/board_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe BoardPolicy do +RSpec.describe BoardPolicy do let(:user) { create(:user) } let(:project) { create(:project, :private) } let(:group) { create(:group, :private) } diff --git a/spec/policies/ci/build_policy_spec.rb b/spec/policies/ci/build_policy_spec.rb index 5857369a55005330f51cb54521b7c6b3b657d5df..d25473388553e9d863447ea04dd17b45e34f84d0 100644 --- a/spec/policies/ci/build_policy_spec.rb +++ b/spec/policies/ci/build_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::BuildPolicy do +RSpec.describe Ci::BuildPolicy do let(:user) { create(:user) } let(:build) { create(:ci_build, pipeline: pipeline) } let(:pipeline) { create(:ci_empty_pipeline, project: project) } diff --git a/spec/policies/ci/pipeline_policy_spec.rb b/spec/policies/ci/pipeline_policy_spec.rb index 293fe1fc5b95114ff050c83aa74516153d4e5c74..fcd96bc66532f4fe21ae471f7f603d029095ac92 100644 --- a/spec/policies/ci/pipeline_policy_spec.rb +++ b/spec/policies/ci/pipeline_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::PipelinePolicy, :models do +RSpec.describe Ci::PipelinePolicy, :models do let(:user) { create(:user) } let(:pipeline) { create(:ci_empty_pipeline, project: project) } diff --git a/spec/policies/ci/pipeline_schedule_policy_spec.rb b/spec/policies/ci/pipeline_schedule_policy_spec.rb index d503401f7cf70ef5789822d2308bc9948e005c02..b455384d17a84288bde45c935c0e5747a372e361 100644 --- a/spec/policies/ci/pipeline_schedule_policy_spec.rb +++ b/spec/policies/ci/pipeline_schedule_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::PipelineSchedulePolicy, :models do +RSpec.describe Ci::PipelineSchedulePolicy, :models do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project, :repository) } let_it_be(:pipeline_schedule, reload: true) { create(:ci_pipeline_schedule, :nightly, project: project) } diff --git a/spec/policies/ci/trigger_policy_spec.rb b/spec/policies/ci/trigger_policy_spec.rb index 28e5a2b2cd63747a5c6b14be58b853b3e3fb0e24..b8b54e57035e09ca1b10c93526a4456a0de2234f 100644 --- a/spec/policies/ci/trigger_policy_spec.rb +++ b/spec/policies/ci/trigger_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::TriggerPolicy do +RSpec.describe Ci::TriggerPolicy do let(:user) { create(:user) } let(:project) { create(:project) } let(:trigger) { create(:ci_trigger, project: project, owner: create(:user)) } diff --git a/spec/policies/clusters/cluster_policy_spec.rb b/spec/policies/clusters/cluster_policy_spec.rb index 26cfc19862ad47236a24484ab1e1f82b12daa3ac..0b931c6f9275e9bb7001a025562a1b6a8d1c0721 100644 --- a/spec/policies/clusters/cluster_policy_spec.rb +++ b/spec/policies/clusters/cluster_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::ClusterPolicy, :models do +RSpec.describe Clusters::ClusterPolicy, :models do let(:cluster) { create(:cluster, :project) } let(:project) { cluster.project } let(:user) { create(:user) } diff --git a/spec/policies/clusters/instance_policy_spec.rb b/spec/policies/clusters/instance_policy_spec.rb index dfe480d7fa4579f16eec5fd6a4c9295ce4116f08..f90841fc31124ca38c7e26a6c298aa9c3ea436d5 100644 --- a/spec/policies/clusters/instance_policy_spec.rb +++ b/spec/policies/clusters/instance_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::InstancePolicy do +RSpec.describe Clusters::InstancePolicy do let(:user) { create(:user) } let(:policy) { described_class.new(user, Clusters::Instance.new) } diff --git a/spec/policies/commit_policy_spec.rb b/spec/policies/commit_policy_spec.rb index 40183f51e9e9f726aad2e4c53cd611d9de648f1e..0d3dcc975659ae9a669b92f2ce5780e2ca8934b4 100644 --- a/spec/policies/commit_policy_spec.rb +++ b/spec/policies/commit_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe CommitPolicy do +RSpec.describe CommitPolicy do describe '#rules' do let(:user) { create(:user) } let(:commit) { project.repository.head_commit } diff --git a/spec/policies/concerns/policy_actor_spec.rb b/spec/policies/concerns/policy_actor_spec.rb index 27db9710a3882b3fef734cd91278735dad54f96c..7271cbb4a9d846ba143a763382e5218332dff9e8 100644 --- a/spec/policies/concerns/policy_actor_spec.rb +++ b/spec/policies/concerns/policy_actor_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe PolicyActor do +RSpec.describe PolicyActor do it 'implements all the methods from user' do methods = subject.instance_methods diff --git a/spec/policies/deploy_key_policy_spec.rb b/spec/policies/deploy_key_policy_spec.rb index 545647e2c67003a1ab74dc20ac2ed2ec53480863..d84b80a8738bb0a9d950185aa714df3fe4668b27 100644 --- a/spec/policies/deploy_key_policy_spec.rb +++ b/spec/policies/deploy_key_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DeployKeyPolicy do +RSpec.describe DeployKeyPolicy do subject { described_class.new(current_user, deploy_key) } describe 'updating a deploy_key' do diff --git a/spec/policies/deploy_keys_project_policy_spec.rb b/spec/policies/deploy_keys_project_policy_spec.rb index 952da86b7a7d1fe2c689761143ab37ab4ecaaf26..3be55e9238cb8ef085dbf5185d4d7be1b40e0dad 100644 --- a/spec/policies/deploy_keys_project_policy_spec.rb +++ b/spec/policies/deploy_keys_project_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DeployKeysProjectPolicy do +RSpec.describe DeployKeysProjectPolicy do subject { described_class.new(current_user, deploy_key.deploy_keys_project_for(project)) } describe 'updating a deploy_keys_project' do diff --git a/spec/policies/deploy_token_policy_spec.rb b/spec/policies/deploy_token_policy_spec.rb index 43e23ee55ac4c65638c189032df6d99c181122b1..f218828052e0c2b77333c429b552f583cfea6a57 100644 --- a/spec/policies/deploy_token_policy_spec.rb +++ b/spec/policies/deploy_token_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DeployTokenPolicy do +RSpec.describe DeployTokenPolicy do let(:current_user) { create(:user) } let(:project) { create(:project) } let(:deploy_token) { create(:deploy_token, projects: [project]) } diff --git a/spec/policies/design_management/design_policy_spec.rb b/spec/policies/design_management/design_policy_spec.rb index a566aecc4b7fc180a444f75ef91061ad20c02f97..5dde5f896c912a6bf83776cefb42557dd7fca4aa 100644 --- a/spec/policies/design_management/design_policy_spec.rb +++ b/spec/policies/design_management/design_policy_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe DesignManagement::DesignPolicy do +RSpec.describe DesignManagement::DesignPolicy do include DesignManagementTestHelpers include_context 'ProjectPolicy context' diff --git a/spec/policies/environment_policy_spec.rb b/spec/policies/environment_policy_spec.rb index 75fca464ec87514da1c1cec145a634f98fe4eb82..649b1a770c06dfebb62756bf940854816f48fbeb 100644 --- a/spec/policies/environment_policy_spec.rb +++ b/spec/policies/environment_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe EnvironmentPolicy do +RSpec.describe EnvironmentPolicy do using RSpec::Parameterized::TableSyntax let(:user) { create(:user) } diff --git a/spec/policies/global_policy_spec.rb b/spec/policies/global_policy_spec.rb index a19ebecac6d673f159ccdf9aaadbfd9644ac0485..4954eafe338cbb0b1e2f68ff63e54301add992c0 100644 --- a/spec/policies/global_policy_spec.rb +++ b/spec/policies/global_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe GlobalPolicy do +RSpec.describe GlobalPolicy do include TermsHelper let_it_be(:project_bot) { create(:user, :project_bot) } diff --git a/spec/policies/group_member_policy_spec.rb b/spec/policies/group_member_policy_spec.rb index a4f3301a06481fbf38b45f7a2397e8f8b796eeb6..4215fa0930141e3887da40797955c8d9e8c9c200 100644 --- a/spec/policies/group_member_policy_spec.rb +++ b/spec/policies/group_member_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe GroupMemberPolicy do +RSpec.describe GroupMemberPolicy do let(:guest) { create(:user) } let(:owner) { create(:user) } let(:group) { create(:group, :private) } diff --git a/spec/policies/group_policy_spec.rb b/spec/policies/group_policy_spec.rb index df398963655b91a2b7620dec908f49e5c38b0423..44f27f55d0cc9e2807524a73dfe04a22ff6a58f5 100644 --- a/spec/policies/group_policy_spec.rb +++ b/spec/policies/group_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe GroupPolicy do +RSpec.describe GroupPolicy do include_context 'GroupPolicy context' context 'public group with no user' do diff --git a/spec/policies/identity_provider_policy_spec.rb b/spec/policies/identity_provider_policy_spec.rb index 52b6d2c89ba716ae5918090990572c8ba15691ab..f6b4e15cff91f95880dcba34db5b88e599e0f77d 100644 --- a/spec/policies/identity_provider_policy_spec.rb +++ b/spec/policies/identity_provider_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe IdentityProviderPolicy do +RSpec.describe IdentityProviderPolicy do subject(:policy) { described_class.new(user, provider) } let(:user) { User.new } diff --git a/spec/policies/issuable_policy_spec.rb b/spec/policies/issuable_policy_spec.rb index 18e35308ecd783a9ad83702ebb272d8a7edf8ceb..20eb09e11c965ab837db24a872ae20f24438a7d3 100644 --- a/spec/policies/issuable_policy_spec.rb +++ b/spec/policies/issuable_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe IssuablePolicy, models: true do +RSpec.describe IssuablePolicy, models: true do let(:user) { create(:user) } let(:project) { create(:project, :public) } let(:issue) { create(:issue, project: project) } diff --git a/spec/policies/issue_policy_spec.rb b/spec/policies/issue_policy_spec.rb index 9d52079e4be8758168d7a2736457988f6d8ad321..b3ca37b17c250222f511a242cb4a5c1c0829843b 100644 --- a/spec/policies/issue_policy_spec.rb +++ b/spec/policies/issue_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe IssuePolicy do +RSpec.describe IssuePolicy do include ExternalAuthorizationServiceHelpers let(:guest) { create(:user) } diff --git a/spec/policies/merge_request_policy_spec.rb b/spec/policies/merge_request_policy_spec.rb index 31ced5db953fd04f0178c1bd2163395b9fb529d8..50ce1b33d171dc957e2a348e1f8374a39346c2c7 100644 --- a/spec/policies/merge_request_policy_spec.rb +++ b/spec/policies/merge_request_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MergeRequestPolicy do +RSpec.describe MergeRequestPolicy do include ExternalAuthorizationServiceHelpers let(:guest) { create(:user) } diff --git a/spec/policies/metrics/dashboard/annotation_policy_spec.rb b/spec/policies/metrics/dashboard/annotation_policy_spec.rb index 4dc5f4cd0b498f2063d89922f4335cb335ce5e61..0c59b39ae3eba1092e154ed152c980524598d3bf 100644 --- a/spec/policies/metrics/dashboard/annotation_policy_spec.rb +++ b/spec/policies/metrics/dashboard/annotation_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Metrics::Dashboard::AnnotationPolicy, :models do +RSpec.describe Metrics::Dashboard::AnnotationPolicy, :models do shared_examples 'metrics dashboard annotation policy' do context 'when guest' do before do diff --git a/spec/policies/namespace/root_storage_statistics_policy_spec.rb b/spec/policies/namespace/root_storage_statistics_policy_spec.rb index 8d53050fffb96b494a40797b38235a8b0ae62da4..e6b58bca4a81f12f2c315b85cceb0847f29306e8 100644 --- a/spec/policies/namespace/root_storage_statistics_policy_spec.rb +++ b/spec/policies/namespace/root_storage_statistics_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Namespace::RootStorageStatisticsPolicy do +RSpec.describe Namespace::RootStorageStatisticsPolicy do using RSpec::Parameterized::TableSyntax describe '#rules' do diff --git a/spec/policies/namespace_policy_spec.rb b/spec/policies/namespace_policy_spec.rb index 01162dc0fc4ce84529884f999df18979f975cd4d..f2f411e48d6987cc89b15d1b0187e979c3258f8a 100644 --- a/spec/policies/namespace_policy_spec.rb +++ b/spec/policies/namespace_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe NamespacePolicy do +RSpec.describe NamespacePolicy do let(:user) { create(:user) } let(:owner) { create(:user) } let(:admin) { create(:admin) } diff --git a/spec/policies/note_policy_spec.rb b/spec/policies/note_policy_spec.rb index 1e3bd0d91474f2e01cb5039e55f660943b2c7e0e..a4cc3a1e9afae23215318204a136efeb835577c0 100644 --- a/spec/policies/note_policy_spec.rb +++ b/spec/policies/note_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe NotePolicy do +RSpec.describe NotePolicy do describe '#rules' do let(:user) { create(:user) } let(:project) { create(:project, :public) } diff --git a/spec/policies/personal_snippet_policy_spec.rb b/spec/policies/personal_snippet_policy_spec.rb index 5fc48717d8640693ea67b36614b7cf6a4e05f28d..d546805ce0198a3459fdeed33f9f7bcbf86a6d49 100644 --- a/spec/policies/personal_snippet_policy_spec.rb +++ b/spec/policies/personal_snippet_policy_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' # Snippet visibility scenarios are included in more details in spec/support/snippet_visibility.rb -describe PersonalSnippetPolicy do +RSpec.describe PersonalSnippetPolicy do let(:regular_user) { create(:user) } let(:external_user) { create(:user, :external) } let(:admin_user) { create(:user, :admin) } diff --git a/spec/policies/project_policy_spec.rb b/spec/policies/project_policy_spec.rb index 9c0bbdf91d5113d5a29db400514bedeb0c5c856e..ea01596a9ecb6c10aa799556cab1b345766478eb 100644 --- a/spec/policies/project_policy_spec.rb +++ b/spec/policies/project_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ProjectPolicy do +RSpec.describe ProjectPolicy do include ExternalAuthorizationServiceHelpers include_context 'ProjectPolicy context' let_it_be(:other_user) { create(:user) } diff --git a/spec/policies/project_snippet_policy_spec.rb b/spec/policies/project_snippet_policy_spec.rb index 3864666f5871c887aed37205276dcf5dcf23651b..bdf9eaedbf18e9dc595dc3109a373738362f1cd0 100644 --- a/spec/policies/project_snippet_policy_spec.rb +++ b/spec/policies/project_snippet_policy_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' # Snippet visibility scenarios are included in more details in spec/support/snippet_visibility.rb -describe ProjectSnippetPolicy do +RSpec.describe ProjectSnippetPolicy do let_it_be(:regular_user) { create(:user) } let_it_be(:other_user) { create(:user) } let_it_be(:external_user) { create(:user, :external) } diff --git a/spec/policies/project_statistics_policy_spec.rb b/spec/policies/project_statistics_policy_spec.rb index 50dfbf7291bcec2a8c19bc0b56903c701cfea111..74630dc38adc18e526330318cc030c63010f2319 100644 --- a/spec/policies/project_statistics_policy_spec.rb +++ b/spec/policies/project_statistics_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ProjectStatisticsPolicy do +RSpec.describe ProjectStatisticsPolicy do using RSpec::Parameterized::TableSyntax describe '#rules' do diff --git a/spec/policies/protected_branch_policy_spec.rb b/spec/policies/protected_branch_policy_spec.rb index ea7fd093e380e1ca572cf39e9937cbcda268b620..bb6dbff18a0ca60b324f329a0c54d72c69bc8cf0 100644 --- a/spec/policies/protected_branch_policy_spec.rb +++ b/spec/policies/protected_branch_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ProtectedBranchPolicy do +RSpec.describe ProtectedBranchPolicy do let(:user) { create(:user) } let(:name) { 'feature' } let(:protected_branch) { create(:protected_branch, name: name) } diff --git a/spec/policies/resource_label_event_policy_spec.rb b/spec/policies/resource_label_event_policy_spec.rb index 4db2390c81869e7b104009653315a4b6f5387fc2..eff2b0e1af54ae445f2c04165fcb471f903a24af 100644 --- a/spec/policies/resource_label_event_policy_spec.rb +++ b/spec/policies/resource_label_event_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ResourceLabelEventPolicy do +RSpec.describe ResourceLabelEventPolicy do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project, :private) } let_it_be(:issue) { create(:issue, project: project) } diff --git a/spec/policies/todo_policy_spec.rb b/spec/policies/todo_policy_spec.rb index be6fecd104584aacb749e347c293ff2bbd08769a..b4876baa50438d55163379bcac8f5289c83ef7b5 100644 --- a/spec/policies/todo_policy_spec.rb +++ b/spec/policies/todo_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe TodoPolicy do +RSpec.describe TodoPolicy do let_it_be(:author) { create(:user) } let_it_be(:user1) { create(:user) } diff --git a/spec/policies/user_policy_spec.rb b/spec/policies/user_policy_spec.rb index 63c4bd058367dfa6e1347f205af146860ba4f28f..1cc3581ebddf9710e55c17ed205cfc29ad81c35c 100644 --- a/spec/policies/user_policy_spec.rb +++ b/spec/policies/user_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe UserPolicy do +RSpec.describe UserPolicy do let(:current_user) { create(:user) } let(:user) { create(:user) } diff --git a/spec/policies/wiki_page_policy_spec.rb b/spec/policies/wiki_page_policy_spec.rb index 0dedccb6e88e26ee2ad5c314177d6537cdfd4091..093db9f8374d12af827573b0eefd06fba4fddd53 100644 --- a/spec/policies/wiki_page_policy_spec.rb +++ b/spec/policies/wiki_page_policy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe WikiPagePolicy, :enable_admin_mode do +RSpec.describe WikiPagePolicy, :enable_admin_mode do include_context 'ProjectPolicyTable context' include ProjectHelpers using RSpec::Parameterized::TableSyntax diff --git a/spec/presenters/award_emoji_presenter_spec.rb b/spec/presenters/award_emoji_presenter_spec.rb index e2ada2a3c93e3603d6cafacf64e1988ef3e0989d..58ee985f1651721b8c35b39b6a93192defffb2ae 100644 --- a/spec/presenters/award_emoji_presenter_spec.rb +++ b/spec/presenters/award_emoji_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AwardEmojiPresenter do +RSpec.describe AwardEmojiPresenter do let(:emoji_name) { 'thumbsup' } let(:award_emoji) { build(:award_emoji, name: emoji_name) } let(:presenter) { described_class.new(award_emoji) } diff --git a/spec/presenters/blob_presenter_spec.rb b/spec/presenters/blob_presenter_spec.rb index ee7bfd1256d98f5d56d6971a793b2d2bb3860cf2..bf926ce62b375e523786a5c5b191bc2f7970f516 100644 --- a/spec/presenters/blob_presenter_spec.rb +++ b/spec/presenters/blob_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe BlobPresenter, :seed_helper do +RSpec.describe BlobPresenter, :seed_helper do let(:repository) { Gitlab::Git::Repository.new('default', TEST_REPO_PATH, '', 'group/project') } let(:git_blob) do diff --git a/spec/presenters/blobs/unfold_presenter_spec.rb b/spec/presenters/blobs/unfold_presenter_spec.rb index 83004809536217078bdb1781ba5b703005e28372..4e9f83e800107527720099106736c9de72d513c6 100644 --- a/spec/presenters/blobs/unfold_presenter_spec.rb +++ b/spec/presenters/blobs/unfold_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Blobs::UnfoldPresenter do +RSpec.describe Blobs::UnfoldPresenter do include FakeBlobHelpers let(:project) { create(:project, :repository) } diff --git a/spec/presenters/ci/bridge_presenter_spec.rb b/spec/presenters/ci/bridge_presenter_spec.rb index 2a4c40a7eaa241e2b0dab0e9210a2220ad124878..6291c3426e28e72bd61fe25b55ced2064b0fb49c 100644 --- a/spec/presenters/ci/bridge_presenter_spec.rb +++ b/spec/presenters/ci/bridge_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::BridgePresenter do +RSpec.describe Ci::BridgePresenter do let_it_be(:project) { create(:project) } let_it_be(:pipeline) { create(:ci_pipeline, project: project) } let_it_be(:bridge) { create(:ci_bridge, pipeline: pipeline, status: :failed) } diff --git a/spec/presenters/ci/build_presenter_spec.rb b/spec/presenters/ci/build_presenter_spec.rb index 9cf6eb45c6318075d20823c7f25d5b81ff7f8710..8d302b242b3c3a1f94a359324098f8df4dec3ab3 100644 --- a/spec/presenters/ci/build_presenter_spec.rb +++ b/spec/presenters/ci/build_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::BuildPresenter do +RSpec.describe Ci::BuildPresenter do let(:project) { create(:project) } let(:pipeline) { create(:ci_pipeline, project: project) } let(:build) { create(:ci_build, pipeline: pipeline) } diff --git a/spec/presenters/ci/build_runner_presenter_spec.rb b/spec/presenters/ci/build_runner_presenter_spec.rb index de199d2bff993fcb6e915d1bebdb47fbac456738..ce4c5a2db7de57484730e23d72b707686d26e6ce 100644 --- a/spec/presenters/ci/build_runner_presenter_spec.rb +++ b/spec/presenters/ci/build_runner_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::BuildRunnerPresenter do +RSpec.describe Ci::BuildRunnerPresenter do let(:presenter) { described_class.new(build) } let(:archive) { { paths: ['sample.txt'] } } diff --git a/spec/presenters/ci/group_variable_presenter_spec.rb b/spec/presenters/ci/group_variable_presenter_spec.rb index 3b81a425f5be1b6f78fe14f32a87bfd1784ce3cf..aaa6410266e17ec71ddd1d73734430a6835b75f2 100644 --- a/spec/presenters/ci/group_variable_presenter_spec.rb +++ b/spec/presenters/ci/group_variable_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::GroupVariablePresenter do +RSpec.describe Ci::GroupVariablePresenter do include Gitlab::Routing.url_helpers let(:group) { create(:group) } diff --git a/spec/presenters/ci/legacy_stage_presenter_spec.rb b/spec/presenters/ci/legacy_stage_presenter_spec.rb index ccf4e48de6e325c59ff7ee582680ef95ba043805..5268ef0f246a3399997c74aa75f7021096bcd187 100644 --- a/spec/presenters/ci/legacy_stage_presenter_spec.rb +++ b/spec/presenters/ci/legacy_stage_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::LegacyStagePresenter do +RSpec.describe Ci::LegacyStagePresenter do let(:legacy_stage) { create(:ci_stage) } let(:presenter) { described_class.new(legacy_stage) } diff --git a/spec/presenters/ci/pipeline_presenter_spec.rb b/spec/presenters/ci/pipeline_presenter_spec.rb index e8b66682b97e2991d9ea362e0d810ca5597a7398..158daad97f546e6e4c44e4fcb763693c815d53a3 100644 --- a/spec/presenters/ci/pipeline_presenter_spec.rb +++ b/spec/presenters/ci/pipeline_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::PipelinePresenter do +RSpec.describe Ci::PipelinePresenter do include Gitlab::Routing let(:user) { create(:user) } diff --git a/spec/presenters/ci/trigger_presenter_spec.rb b/spec/presenters/ci/trigger_presenter_spec.rb index 41cb436f928b3b714008c9c32e7c1bfeda57cb82..bac1c94e0b7957285c8dd60bc8385571adac8383 100644 --- a/spec/presenters/ci/trigger_presenter_spec.rb +++ b/spec/presenters/ci/trigger_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::TriggerPresenter do +RSpec.describe Ci::TriggerPresenter do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project) } diff --git a/spec/presenters/ci/variable_presenter_spec.rb b/spec/presenters/ci/variable_presenter_spec.rb index 70cf2f539b6e80c2e0d2f968ba5df7706b229f3a..30fedf78035ea31bd3b634ed5e9156fe65367e48 100644 --- a/spec/presenters/ci/variable_presenter_spec.rb +++ b/spec/presenters/ci/variable_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::VariablePresenter do +RSpec.describe Ci::VariablePresenter do include Gitlab::Routing.url_helpers let(:project) { create(:project) } diff --git a/spec/presenters/clusterable_presenter_spec.rb b/spec/presenters/clusterable_presenter_spec.rb index 2c0a7f3e9b2d799d156ef1de91f8f4213f064029..d19abd4e4d894fcb36018354ba836d9df347fa95 100644 --- a/spec/presenters/clusterable_presenter_spec.rb +++ b/spec/presenters/clusterable_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ClusterablePresenter do +RSpec.describe ClusterablePresenter do include Gitlab::Routing.url_helpers describe '.fabricate' do diff --git a/spec/presenters/clusters/cluster_presenter_spec.rb b/spec/presenters/clusters/cluster_presenter_spec.rb index 6a1360807b76e96905b46672d5fc9bf1c181fa17..ff9963c3ad1e8d6906067ebeb25b0862b9103676 100644 --- a/spec/presenters/clusters/cluster_presenter_spec.rb +++ b/spec/presenters/clusters/cluster_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::ClusterPresenter do +RSpec.describe Clusters::ClusterPresenter do include Gitlab::Routing.url_helpers let(:cluster) { create(:cluster, :provided_by_gcp, :project) } diff --git a/spec/presenters/commit_presenter_spec.rb b/spec/presenters/commit_presenter_spec.rb index bc749acfa3ac739cb81f38e6114da785a06591a5..bc6be07f41586bc2a9fdb4540f3aba2b120f2862 100644 --- a/spec/presenters/commit_presenter_spec.rb +++ b/spec/presenters/commit_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe CommitPresenter do +RSpec.describe CommitPresenter do let(:project) { create(:project, :repository) } let(:commit) { project.commit } let(:user) { create(:user) } diff --git a/spec/presenters/commit_status_presenter_spec.rb b/spec/presenters/commit_status_presenter_spec.rb index b02497d4c1144d68c8c45eefe249f8deba349241..4b2441d656e6e4dcd14e8ab9adc71b1c4bde9483 100644 --- a/spec/presenters/commit_status_presenter_spec.rb +++ b/spec/presenters/commit_status_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe CommitStatusPresenter do +RSpec.describe CommitStatusPresenter do let(:project) { create(:project) } let(:pipeline) { create(:ci_pipeline, project: project) } let(:build) { create(:ci_build, pipeline: pipeline) } diff --git a/spec/presenters/dev_ops_score/metric_presenter_spec.rb b/spec/presenters/dev_ops_score/metric_presenter_spec.rb index b6eab3f2e7491006015ab01fe526a4ec19ba93f3..8b7b2c88578ccb68746a3fdf2430c10307e33849 100644 --- a/spec/presenters/dev_ops_score/metric_presenter_spec.rb +++ b/spec/presenters/dev_ops_score/metric_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DevOpsScore::MetricPresenter do +RSpec.describe DevOpsScore::MetricPresenter do subject { described_class.new(metric) } let(:metric) { build(:dev_ops_score_metric) } diff --git a/spec/presenters/event_presenter_spec.rb b/spec/presenters/event_presenter_spec.rb index eb94d83837045fd5cf3569dea4359d52ca08efde..2d4872ea29e6a8291f9a4537a52705009cd586d8 100644 --- a/spec/presenters/event_presenter_spec.rb +++ b/spec/presenters/event_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe EventPresenter do +RSpec.describe EventPresenter do include Gitlab::Routing.url_helpers let_it_be(:group) { create(:group) } diff --git a/spec/presenters/group_clusterable_presenter_spec.rb b/spec/presenters/group_clusterable_presenter_spec.rb index d40ca856f7bea6eb9c36e4fc6ba10e79365ea242..3910f4705c561ecd7527c3a8a60ad12a51298000 100644 --- a/spec/presenters/group_clusterable_presenter_spec.rb +++ b/spec/presenters/group_clusterable_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe GroupClusterablePresenter do +RSpec.describe GroupClusterablePresenter do include Gitlab::Routing.url_helpers let(:presenter) { described_class.new(group) } diff --git a/spec/presenters/group_member_presenter_spec.rb b/spec/presenters/group_member_presenter_spec.rb index 382b1881ab7e13185c1ad3848a6337133f2d8cbf..6bd3005fbb678126d8ffd4eeab251501c03bfdf4 100644 --- a/spec/presenters/group_member_presenter_spec.rb +++ b/spec/presenters/group_member_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe GroupMemberPresenter do +RSpec.describe GroupMemberPresenter do let(:user) { double(:user) } let(:group) { double(:group) } let(:group_member) { double(:group_member, source: group) } diff --git a/spec/presenters/instance_clusterable_presenter_spec.rb b/spec/presenters/instance_clusterable_presenter_spec.rb index 4265e2fcb697240b2943bfa637adfb003d302ff3..352b7fc6ea7714d5ac2f9ddb366bb6b10fef374a 100644 --- a/spec/presenters/instance_clusterable_presenter_spec.rb +++ b/spec/presenters/instance_clusterable_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe InstanceClusterablePresenter do +RSpec.describe InstanceClusterablePresenter do include Gitlab::Routing.url_helpers let(:presenter) { described_class.new(instance) } diff --git a/spec/presenters/issue_presenter_spec.rb b/spec/presenters/issue_presenter_spec.rb index 4a4caef9d286875347a6a1d7fd13ec2cba4b3cbe..f08cd0f202658e26074d4dcd37bb7044fa2b852f 100644 --- a/spec/presenters/issue_presenter_spec.rb +++ b/spec/presenters/issue_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe IssuePresenter do +RSpec.describe IssuePresenter do include Gitlab::Routing.url_helpers let(:user) { create(:user) } diff --git a/spec/presenters/label_presenter_spec.rb b/spec/presenters/label_presenter_spec.rb index 9578d017af5a9cfa67c83d99aef452db09c8d4b1..cb6e991bd8e04baec1e49b381b0a44a2bf1b024f 100644 --- a/spec/presenters/label_presenter_spec.rb +++ b/spec/presenters/label_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe LabelPresenter do +RSpec.describe LabelPresenter do include Gitlab::Routing.url_helpers let_it_be(:group) { create(:group) } diff --git a/spec/presenters/merge_request_presenter_spec.rb b/spec/presenters/merge_request_presenter_spec.rb index f184e767f8ce8e9a6defa7fc5e630a11486f419f..e7184d23767123ba891f1f5aa0b0bd02e3e24101 100644 --- a/spec/presenters/merge_request_presenter_spec.rb +++ b/spec/presenters/merge_request_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MergeRequestPresenter do +RSpec.describe MergeRequestPresenter do let(:resource) { create(:merge_request, source_project: project) } let(:project) { create(:project) } let(:user) { create(:user) } diff --git a/spec/presenters/milestone_presenter_spec.rb b/spec/presenters/milestone_presenter_spec.rb index 3d7b3ad6d78e6e6c55ef8256ffab61b04611588c..1f23bb31fda540b6324dbf45c78a438ed74a668a 100644 --- a/spec/presenters/milestone_presenter_spec.rb +++ b/spec/presenters/milestone_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MilestonePresenter do +RSpec.describe MilestonePresenter do let_it_be(:user) { create(:user) } let_it_be(:group) { create(:group) } let_it_be(:milestone) { create(:milestone, group: group) } diff --git a/spec/presenters/pages_domain_presenter_spec.rb b/spec/presenters/pages_domain_presenter_spec.rb index 30ce59b7bfb6f675f259cf51607ae01c286b410a..731279ce5b9a674e43cb78bd850dee2b31301e66 100644 --- a/spec/presenters/pages_domain_presenter_spec.rb +++ b/spec/presenters/pages_domain_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe PagesDomainPresenter do +RSpec.describe PagesDomainPresenter do using RSpec::Parameterized::TableSyntax include LetsEncryptHelpers diff --git a/spec/presenters/project_clusterable_presenter_spec.rb b/spec/presenters/project_clusterable_presenter_spec.rb index b3dad4abde531a8ff6a4236b545b10d656566882..6cd0667059509efdb13f14841ee627d5f4f4ddb9 100644 --- a/spec/presenters/project_clusterable_presenter_spec.rb +++ b/spec/presenters/project_clusterable_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ProjectClusterablePresenter do +RSpec.describe ProjectClusterablePresenter do include Gitlab::Routing.url_helpers let(:presenter) { described_class.new(project) } diff --git a/spec/presenters/project_hook_presenter_spec.rb b/spec/presenters/project_hook_presenter_spec.rb index 773e8ccf51e29edf3af826372f9e4c3370be0592..061ec38ae34d27469650197fa29b4a3949cfd4b2 100644 --- a/spec/presenters/project_hook_presenter_spec.rb +++ b/spec/presenters/project_hook_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ProjectHookPresenter do +RSpec.describe ProjectHookPresenter do let(:web_hook_log) { create(:web_hook_log) } let(:project) { web_hook_log.web_hook.project } let(:web_hook) { web_hook_log.web_hook } diff --git a/spec/presenters/project_member_presenter_spec.rb b/spec/presenters/project_member_presenter_spec.rb index 743c89fc7c2ff710f95c82a340925b180171af19..ad45a23c183da2b98fb86f065bc9a1c7464b48b0 100644 --- a/spec/presenters/project_member_presenter_spec.rb +++ b/spec/presenters/project_member_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ProjectMemberPresenter do +RSpec.describe ProjectMemberPresenter do let(:user) { double(:user) } let(:project) { double(:project) } let(:project_member) { double(:project_member, source: project) } diff --git a/spec/presenters/project_presenter_spec.rb b/spec/presenters/project_presenter_spec.rb index 65ae85ea78fbf84f01b5c0eeae08258530dda823..eb1ff628d14907e5adcbb42cb2eb474792ba898f 100644 --- a/spec/presenters/project_presenter_spec.rb +++ b/spec/presenters/project_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ProjectPresenter do +RSpec.describe ProjectPresenter do let(:user) { create(:user) } let(:project) { create(:project) } let(:presenter) { described_class.new(project, current_user: user) } diff --git a/spec/presenters/projects/import_export/project_export_presenter_spec.rb b/spec/presenters/projects/import_export/project_export_presenter_spec.rb index 052ca36974a97dd10440f31865f1fce499da72f4..8463d01d95bbf35569722c2c473f22ee827f0afb 100644 --- a/spec/presenters/projects/import_export/project_export_presenter_spec.rb +++ b/spec/presenters/projects/import_export/project_export_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Projects::ImportExport::ProjectExportPresenter do +RSpec.describe Projects::ImportExport::ProjectExportPresenter do let_it_be(:group) { create(:group) } let_it_be(:project) { create(:project, group: group) } let_it_be(:user) { create(:user) } diff --git a/spec/presenters/projects/prometheus/alert_presenter_spec.rb b/spec/presenters/projects/prometheus/alert_presenter_spec.rb index 8ee5a4d7b3f6be67a8b6e67bd069c2d25506acda..e558c651734a29e58c3d77b6de0f15c7f6950267 100644 --- a/spec/presenters/projects/prometheus/alert_presenter_spec.rb +++ b/spec/presenters/projects/prometheus/alert_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Projects::Prometheus::AlertPresenter do +RSpec.describe Projects::Prometheus::AlertPresenter do let_it_be(:project, reload: true) { create(:project) } let(:presenter) { described_class.new(alert) } diff --git a/spec/presenters/projects/settings/deploy_keys_presenter_spec.rb b/spec/presenters/projects/settings/deploy_keys_presenter_spec.rb index b9cb60e414f45642d5be8731a978294702f9d190..7a679a03b532e72236637392fc8e8d293a3b9714 100644 --- a/spec/presenters/projects/settings/deploy_keys_presenter_spec.rb +++ b/spec/presenters/projects/settings/deploy_keys_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Projects::Settings::DeployKeysPresenter do +RSpec.describe Projects::Settings::DeployKeysPresenter do let(:project) { create(:project) } let(:user) { create(:user) } diff --git a/spec/presenters/release_presenter_spec.rb b/spec/presenters/release_presenter_spec.rb index 57de99f6a6193b9246699f60a46608f2c1a57f9b..5577b3ad2e886cca44b0237890b6982af540aa5b 100644 --- a/spec/presenters/release_presenter_spec.rb +++ b/spec/presenters/release_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ReleasePresenter do +RSpec.describe ReleasePresenter do include Gitlab::Routing.url_helpers let_it_be(:project) { create(:project, :repository) } diff --git a/spec/presenters/sentry_error_presenter_spec.rb b/spec/presenters/sentry_error_presenter_spec.rb index 5f3f1d33b866515d3580de5c6beced18adcde7dd..af9e7c8a2b2dab9d1da65c542b16827ae3ea9964 100644 --- a/spec/presenters/sentry_error_presenter_spec.rb +++ b/spec/presenters/sentry_error_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SentryErrorPresenter do +RSpec.describe SentryErrorPresenter do let(:error) { build(:detailed_error_tracking_error) } let(:presenter) { described_class.new(error) } diff --git a/spec/presenters/service_hook_presenter_spec.rb b/spec/presenters/service_hook_presenter_spec.rb index bea57768e3e38a58b700210e1a5df18eabbc1c5f..adef34a882b5b4b9de1e276bd23a611e5d743859 100644 --- a/spec/presenters/service_hook_presenter_spec.rb +++ b/spec/presenters/service_hook_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ServiceHookPresenter do +RSpec.describe ServiceHookPresenter do let(:web_hook_log) { create(:web_hook_log, web_hook: service_hook) } let(:service_hook) { create(:service_hook, service: service) } let(:service) { create(:drone_ci_service, project: project) } diff --git a/spec/presenters/snippet_blob_presenter_spec.rb b/spec/presenters/snippet_blob_presenter_spec.rb index eb7621cc5913a3c063c776484bee33d922a5a231..28c86468c78e0147fa5f1e2b8da5417616f39645 100644 --- a/spec/presenters/snippet_blob_presenter_spec.rb +++ b/spec/presenters/snippet_blob_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SnippetBlobPresenter do +RSpec.describe SnippetBlobPresenter do describe '#rich_data' do before do allow_next_instance_of(described_class) do |instance| diff --git a/spec/presenters/snippet_presenter_spec.rb b/spec/presenters/snippet_presenter_spec.rb index 423e9edc2193a42ece423856e7af84af73b445c0..98c291bdd02d9e2f76ae92d931777de272fec8a6 100644 --- a/spec/presenters/snippet_presenter_spec.rb +++ b/spec/presenters/snippet_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SnippetPresenter do +RSpec.describe SnippetPresenter do include Gitlab::Routing.url_helpers let_it_be(:user) { create(:user) } diff --git a/spec/presenters/tree_entry_presenter_spec.rb b/spec/presenters/tree_entry_presenter_spec.rb index 0c29fe3e5ff25fd3540faadd42c1fca182f16947..d29a7a6ab044a8de1c2fa2934c967d0fab1c138a 100644 --- a/spec/presenters/tree_entry_presenter_spec.rb +++ b/spec/presenters/tree_entry_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe TreeEntryPresenter do +RSpec.describe TreeEntryPresenter do include Gitlab::Routing.url_helpers let(:project) { create(:project, :repository) } diff --git a/spec/presenters/web_hook_log_presenter_spec.rb b/spec/presenters/web_hook_log_presenter_spec.rb index 8812a0ba594a37c5aaea3543c4e831a4927b7d64..68c8c6e2a1b4ce8dab5970557f292a97663663b3 100644 --- a/spec/presenters/web_hook_log_presenter_spec.rb +++ b/spec/presenters/web_hook_log_presenter_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe WebHookLogPresenter do +RSpec.describe WebHookLogPresenter do include Gitlab::Routing.url_helpers describe '#details_path' do diff --git a/spec/rack_servers/puma_spec.rb b/spec/rack_servers/puma_spec.rb index a4b37905af30074a568c582870f88bbfd7002931..80595b267fa7526c5af5d378f2d6abb00f61963e 100644 --- a/spec/rack_servers/puma_spec.rb +++ b/spec/rack_servers/puma_spec.rb @@ -5,7 +5,7 @@ require 'fileutils' require 'excon' -describe 'Puma' do +RSpec.describe 'Puma' do before(:all) do project_root = Rails.root.to_s config_lines = File.read(Rails.root.join('config/puma.example.development.rb')) diff --git a/spec/rack_servers/unicorn_spec.rb b/spec/rack_servers/unicorn_spec.rb index 6a02ebcd048ccfbc5c928278f98d513b63f0468e..5887b49d269d12f8e31432719c05154b2100c2ae 100644 --- a/spec/rack_servers/unicorn_spec.rb +++ b/spec/rack_servers/unicorn_spec.rb @@ -6,7 +6,7 @@ require 'spec_helper' -describe 'Unicorn' do +RSpec.describe 'Unicorn' do before(:all) do project_root = File.expand_path('../..', __dir__) diff --git a/spec/requests/api/access_requests_spec.rb b/spec/requests/api/access_requests_spec.rb index 52bc81cff18a2699c2d52e1efd3b75140ff0d2ff..223d740a00434726cc5dff2c091bb92706a70381 100644 --- a/spec/requests/api/access_requests_spec.rb +++ b/spec/requests/api/access_requests_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::AccessRequests do +RSpec.describe API::AccessRequests do let_it_be(:maintainer) { create(:user) } let_it_be(:developer) { create(:user) } let_it_be(:access_requester) { create(:user) } diff --git a/spec/requests/api/admin/ci/variables_spec.rb b/spec/requests/api/admin/ci/variables_spec.rb index 185fde17e1bdb6ea0018d8144f61b758aadfebbb..812ee93ad21417b796c52ab1e38ff7f83d7c51e0 100644 --- a/spec/requests/api/admin/ci/variables_spec.rb +++ b/spec/requests/api/admin/ci/variables_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ::API::Admin::Ci::Variables do +RSpec.describe ::API::Admin::Ci::Variables do let_it_be(:admin) { create(:admin) } let_it_be(:user) { create(:user) } diff --git a/spec/requests/api/admin/sidekiq_spec.rb b/spec/requests/api/admin/sidekiq_spec.rb index 303b62f4436a8a4820de79774598e14f18f4eeda..3c488816bede88a0ae67c45f6da1e8e8452745fc 100644 --- a/spec/requests/api/admin/sidekiq_spec.rb +++ b/spec/requests/api/admin/sidekiq_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Admin::Sidekiq, :clean_gitlab_redis_queues do +RSpec.describe API::Admin::Sidekiq, :clean_gitlab_redis_queues do let_it_be(:admin) { create(:admin) } describe 'DELETE /admin/sidekiq/queues/:queue_name' do diff --git a/spec/requests/api/api_guard/admin_mode_middleware_spec.rb b/spec/requests/api/api_guard/admin_mode_middleware_spec.rb index 7175076e56daf85aa96a36ee955651d9739c852e..4b477f829a72090625d4a587eae2e95545b47cfd 100644 --- a/spec/requests/api/api_guard/admin_mode_middleware_spec.rb +++ b/spec/requests/api/api_guard/admin_mode_middleware_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::APIGuard::AdminModeMiddleware, :do_not_mock_admin_mode, :request_store do +RSpec.describe API::APIGuard::AdminModeMiddleware, :do_not_mock_admin_mode, :request_store do let(:user) { create(:admin) } it 'is loaded' do diff --git a/spec/requests/api/api_spec.rb b/spec/requests/api/api_spec.rb index 201c0d1796c79da8f820cb6995d797d216f34bf6..9284760bf697211e0e3b07826807303a83a3e851 100644 --- a/spec/requests/api/api_spec.rb +++ b/spec/requests/api/api_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::API do +RSpec.describe API::API do include GroupAPIHelpers describe 'Record user last activity in after hook' do diff --git a/spec/requests/api/appearance_spec.rb b/spec/requests/api/appearance_spec.rb index f8c3db70d163e2c1808ae230dc1c686ceb62ba97..69176e18d2e34fe0bda6f92526d6d7e3bb9c0bed 100644 --- a/spec/requests/api/appearance_spec.rb +++ b/spec/requests/api/appearance_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Appearance, 'Appearance' do +RSpec.describe API::Appearance, 'Appearance' do let_it_be(:user) { create(:user) } let_it_be(:admin) { create(:admin) } diff --git a/spec/requests/api/applications_spec.rb b/spec/requests/api/applications_spec.rb index cd341ad134ee010f7d417b905ae2a620fe1a2654..5b2d835f89addd6e90ed95126855d1f5664f9908 100644 --- a/spec/requests/api/applications_spec.rb +++ b/spec/requests/api/applications_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Applications, :api do +RSpec.describe API::Applications, :api do let(:admin_user) { create(:user, admin: true) } let(:user) { create(:user, admin: false) } let!(:application) { create(:application, name: 'another_application', redirect_uri: 'http://other_application.url', scopes: '') } diff --git a/spec/requests/api/avatar_spec.rb b/spec/requests/api/avatar_spec.rb index 45e34b7894b47deceead38cc5f85c2e163a3a7a1..656a086e5506cc507a1d301be0bde6ca94cb6b25 100644 --- a/spec/requests/api/avatar_spec.rb +++ b/spec/requests/api/avatar_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Avatar do +RSpec.describe API::Avatar do let(:gravatar_service) { double('GravatarService') } describe 'GET /avatar' do diff --git a/spec/requests/api/award_emoji_spec.rb b/spec/requests/api/award_emoji_spec.rb index 543fe970abddebb8f158c82796ef7b61dd4f1097..1c825949ae808c9af5a1b39dc0adb064e799d116 100644 --- a/spec/requests/api/award_emoji_spec.rb +++ b/spec/requests/api/award_emoji_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::AwardEmoji do +RSpec.describe API::AwardEmoji do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project) } let_it_be(:issue) { create(:issue, project: project) } diff --git a/spec/requests/api/badges_spec.rb b/spec/requests/api/badges_spec.rb index d7f9b7d010b23e5c8473c9528bf6edbba1b37ff0..99d224cb8e98df60b2810531e2add810ebd845e2 100644 --- a/spec/requests/api/badges_spec.rb +++ b/spec/requests/api/badges_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Badges do +RSpec.describe API::Badges do let(:maintainer) { create(:user, username: 'maintainer_user') } let(:developer) { create(:user) } let(:access_requester) { create(:user) } diff --git a/spec/requests/api/boards_spec.rb b/spec/requests/api/boards_spec.rb index d761b3718211878b999a3f90be037390c1456e6f..f0d3afd0af7245c8fdf4f1b203d72ed08535e998 100644 --- a/spec/requests/api/boards_spec.rb +++ b/spec/requests/api/boards_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Boards do +RSpec.describe API::Boards do let_it_be(:user) { create(:user) } let_it_be(:non_member) { create(:user) } let_it_be(:guest) { create(:user) } diff --git a/spec/requests/api/branches_spec.rb b/spec/requests/api/branches_spec.rb index f2dc5b1c045cdfb03af1bbd43e2ada04e6648c42..db017f8e1af8c9423b9d2b4601a04d46309e7159 100644 --- a/spec/requests/api/branches_spec.rb +++ b/spec/requests/api/branches_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Branches do +RSpec.describe API::Branches do let_it_be(:user) { create(:user) } let(:project) { create(:project, :repository, creator: user, path: 'my.project') } let(:guest) { create(:user).tap { |u| project.add_guest(u) } } diff --git a/spec/requests/api/broadcast_messages_spec.rb b/spec/requests/api/broadcast_messages_spec.rb index 9bfbbe0daab53a007789a87508c096cfcb36755c..b5b6ce106e540d6bd1e18e330085558c97a22d37 100644 --- a/spec/requests/api/broadcast_messages_spec.rb +++ b/spec/requests/api/broadcast_messages_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::BroadcastMessages do +RSpec.describe API::BroadcastMessages do let_it_be(:user) { create(:user) } let_it_be(:admin) { create(:admin) } let_it_be(:message) { create(:broadcast_message) } diff --git a/spec/requests/api/commit_statuses_spec.rb b/spec/requests/api/commit_statuses_spec.rb index 0c0bf8b4df0eb322a70c98fde46ddd1e66f94c86..bec15b788c38bd36d93e2121b7c62900b3113c40 100644 --- a/spec/requests/api/commit_statuses_spec.rb +++ b/spec/requests/api/commit_statuses_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::CommitStatuses do +RSpec.describe API::CommitStatuses do let!(:project) { create(:project, :repository) } let(:commit) { project.repository.commit } let(:guest) { create_user(:guest) } diff --git a/spec/requests/api/commits_spec.rb b/spec/requests/api/commits_spec.rb index a423c92e2fb1289f2d2c976d3b66184165fe796c..724e3177173ded57da6d65c1193181692333ebe3 100644 --- a/spec/requests/api/commits_spec.rb +++ b/spec/requests/api/commits_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' require 'mime/types' -describe API::Commits do +RSpec.describe API::Commits do include ProjectForksHelper let(:user) { create(:user) } diff --git a/spec/requests/api/container_registry_event_spec.rb b/spec/requests/api/container_registry_event_spec.rb index 2cdf2656cb7346d143c526f63818bbf2ee65af72..4d38ddddffd701854a9dd39531f5a169165cc5c6 100644 --- a/spec/requests/api/container_registry_event_spec.rb +++ b/spec/requests/api/container_registry_event_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ContainerRegistryEvent do +RSpec.describe API::ContainerRegistryEvent do let(:secret_token) { 'secret_token' } let(:events) { [{ action: 'push' }] } let(:registry_headers) { { 'Content-Type' => ::API::ContainerRegistryEvent::DOCKER_DISTRIBUTION_EVENTS_V1_JSON } } diff --git a/spec/requests/api/deploy_keys_spec.rb b/spec/requests/api/deploy_keys_spec.rb index e8cc6bc71ae606bcc3fe3d98f4a4937afb8571b8..81cef6537706919889b82148311728a9772ebc76 100644 --- a/spec/requests/api/deploy_keys_spec.rb +++ b/spec/requests/api/deploy_keys_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::DeployKeys do +RSpec.describe API::DeployKeys do let(:user) { create(:user) } let(:maintainer) { create(:user) } let(:admin) { create(:admin) } diff --git a/spec/requests/api/deploy_tokens_spec.rb b/spec/requests/api/deploy_tokens_spec.rb index 499c334d49127778bec142504f7fa4361e4dfeea..0c9cdc41321cf3e7a2b80a86c321ea8c1481b9f0 100644 --- a/spec/requests/api/deploy_tokens_spec.rb +++ b/spec/requests/api/deploy_tokens_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::DeployTokens do +RSpec.describe API::DeployTokens do let_it_be(:user) { create(:user) } let_it_be(:creator) { create(:user) } let_it_be(:project) { create(:project, creator_id: creator.id) } diff --git a/spec/requests/api/deployments_spec.rb b/spec/requests/api/deployments_spec.rb index ef2415a0cde8b800b1396b222c6eb11fff96024e..8113de96ac4263934a7682d62b748569612c6671 100644 --- a/spec/requests/api/deployments_spec.rb +++ b/spec/requests/api/deployments_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Deployments do +RSpec.describe API::Deployments do let(:user) { create(:user) } let(:non_member) { create(:user) } diff --git a/spec/requests/api/discussions_spec.rb b/spec/requests/api/discussions_spec.rb index cb3efb2cf5f4c596ee3020c337945e31f207309c..720ea429c2c4861cc6c47de786ddca161b7a9b67 100644 --- a/spec/requests/api/discussions_spec.rb +++ b/spec/requests/api/discussions_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Discussions do +RSpec.describe API::Discussions do let(:user) { create(:user) } let!(:project) { create(:project, :public, :repository, namespace: user.namespace) } let(:private_user) { create(:user) } diff --git a/spec/requests/api/doorkeeper_access_spec.rb b/spec/requests/api/doorkeeper_access_spec.rb index a25a6485f475e99b04380a3be9192a393850fe1d..f16cd58bb34b4fc46d6e9cb11606fc18c8f2577a 100644 --- a/spec/requests/api/doorkeeper_access_spec.rb +++ b/spec/requests/api/doorkeeper_access_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'doorkeeper access' do +RSpec.describe 'doorkeeper access' do let!(:user) { create(:user) } let!(:application) { Doorkeeper::Application.create!(name: "MyApp", redirect_uri: "https://app.com", owner: user) } let!(:token) { Doorkeeper::AccessToken.create! application_id: application.id, resource_owner_id: user.id, scopes: "api" } diff --git a/spec/requests/api/environments_spec.rb b/spec/requests/api/environments_spec.rb index 91b3dd93433926169029f49764e1eb68074e2fbe..b1ac8f9eeecf35014332b130eda7b4761dba4032 100644 --- a/spec/requests/api/environments_spec.rb +++ b/spec/requests/api/environments_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Environments do +RSpec.describe API::Environments do let(:user) { create(:user) } let(:non_member) { create(:user) } let(:project) { create(:project, :private, :repository, namespace: user.namespace) } diff --git a/spec/requests/api/error_tracking_spec.rb b/spec/requests/api/error_tracking_spec.rb index deed9777025bb168f1641017433d94b2bbf34fdb..8c9ca1b6a9db2ffc98cd8c7ca6925367f8f11cdf 100644 --- a/spec/requests/api/error_tracking_spec.rb +++ b/spec/requests/api/error_tracking_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ErrorTracking do +RSpec.describe API::ErrorTracking do let_it_be(:user) { create(:user) } let(:setting) { create(:project_error_tracking_setting) } let(:project) { setting.project } diff --git a/spec/requests/api/events_spec.rb b/spec/requests/api/events_spec.rb index 0425e0791eb41d6eafdea75bf1a866d019286083..0092fcc3f56e534a91139c3109c89e089ae15e16 100644 --- a/spec/requests/api/events_spec.rb +++ b/spec/requests/api/events_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Events do +RSpec.describe API::Events do let(:user) { create(:user) } let(:non_member) { create(:user) } let(:private_project) { create(:project, :private, creator_id: user.id, namespace: user.namespace) } diff --git a/spec/requests/api/features_spec.rb b/spec/requests/api/features_spec.rb index 59a9ed2f77dac18248cdbc4bb71ab8da40c2bc94..2746e777306445d5e9271bb91dc0de51a382d300 100644 --- a/spec/requests/api/features_spec.rb +++ b/spec/requests/api/features_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Features, stub_feature_flags: false do +RSpec.describe API::Features, stub_feature_flags: false do let_it_be(:user) { create(:user) } let_it_be(:admin) { create(:admin) } diff --git a/spec/requests/api/files_spec.rb b/spec/requests/api/files_spec.rb index a54213a85565bc74572843c36052f8d9c7ba509f..358eecb10c548f9404f001b247d6af9e40bd10e0 100644 --- a/spec/requests/api/files_spec.rb +++ b/spec/requests/api/files_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Files do +RSpec.describe API::Files do include RepoHelpers let(:user) { create(:user) } diff --git a/spec/requests/api/freeze_periods_spec.rb b/spec/requests/api/freeze_periods_spec.rb index 0b7828ebedf0fc338c3bec9c8e4c286ed6165bd0..5589d4d543d8372152f5e3b423e232e81fcda148 100644 --- a/spec/requests/api/freeze_periods_spec.rb +++ b/spec/requests/api/freeze_periods_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::FreezePeriods do +RSpec.describe API::FreezePeriods do let_it_be(:project) { create(:project, :repository, :private) } let_it_be(:user) { create(:user) } let_it_be(:admin) { create(:admin) } diff --git a/spec/requests/api/graphql/boards/board_lists_query_spec.rb b/spec/requests/api/graphql/boards/board_lists_query_spec.rb index 3cc1468be0266d28b7ed1217a1cfb8777c7b75b6..8a89590c85a8af83805df9b86d572f067f182d89 100644 --- a/spec/requests/api/graphql/boards/board_lists_query_spec.rb +++ b/spec/requests/api/graphql/boards/board_lists_query_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'get board lists' do +RSpec.describe 'get board lists' do include GraphqlHelpers let_it_be(:user) { create(:user) } diff --git a/spec/requests/api/graphql/boards/boards_query_spec.rb b/spec/requests/api/graphql/boards/boards_query_spec.rb index a17554aba21f113aa21bacd54756ab88474990e6..50004e5a8a172bce2b935ec6e113f0c388d75469 100644 --- a/spec/requests/api/graphql/boards/boards_query_spec.rb +++ b/spec/requests/api/graphql/boards/boards_query_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'get list of boards' do +RSpec.describe 'get list of boards' do include GraphqlHelpers include_context 'group and project boards query context' diff --git a/spec/requests/api/graphql/current_user/todos_query_spec.rb b/spec/requests/api/graphql/current_user/todos_query_spec.rb index 321e1062a96210ba34a39042c47cc7767c847c64..e298de0df01e9bbec3228f75d0dbe873d5887e63 100644 --- a/spec/requests/api/graphql/current_user/todos_query_spec.rb +++ b/spec/requests/api/graphql/current_user/todos_query_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Query current user todos' do +RSpec.describe 'Query current user todos' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/current_user_query_spec.rb b/spec/requests/api/graphql/current_user_query_spec.rb index 2b38b8e98ab6155d09310cd6f497c576b9ed9538..dc832b42fa562e9fda28c4b4a5965fa0331df846 100644 --- a/spec/requests/api/graphql/current_user_query_spec.rb +++ b/spec/requests/api/graphql/current_user_query_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'getting project information' do +RSpec.describe 'getting project information' do include GraphqlHelpers let(:query) do diff --git a/spec/requests/api/graphql/gitlab_schema_spec.rb b/spec/requests/api/graphql/gitlab_schema_spec.rb index 266c98d6f08171f4f3202ef1c961363df5ae9f75..ee7dba545bef695a017bc76dd9559a71c8861899 100644 --- a/spec/requests/api/graphql/gitlab_schema_spec.rb +++ b/spec/requests/api/graphql/gitlab_schema_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'GitlabSchema configurations' do +RSpec.describe 'GitlabSchema configurations' do include GraphqlHelpers let_it_be(:project) { create(:project) } diff --git a/spec/requests/api/graphql/group/labels_query_spec.rb b/spec/requests/api/graphql/group/labels_query_spec.rb index 6c34cbadf956fd2e6bf11d037a690e12c82dc3ba..31556ffca305e8e1e283c09b269c3b6d7e640922 100644 --- a/spec/requests/api/graphql/group/labels_query_spec.rb +++ b/spec/requests/api/graphql/group/labels_query_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'getting group label information' do +RSpec.describe 'getting group label information' do include GraphqlHelpers let_it_be(:group) { create(:group, :public) } diff --git a/spec/requests/api/graphql/group/milestones_spec.rb b/spec/requests/api/graphql/group/milestones_spec.rb index bad0024e7a3b955dd84e71fddfe296717aa57bca..e85adeb46909e85090545f148b76a22052eaf7f6 100644 --- a/spec/requests/api/graphql/group/milestones_spec.rb +++ b/spec/requests/api/graphql/group/milestones_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Milestones through GroupQuery' do +RSpec.describe 'Milestones through GroupQuery' do include GraphqlHelpers let_it_be(:user) { create(:user) } diff --git a/spec/requests/api/graphql/group_query_spec.rb b/spec/requests/api/graphql/group_query_spec.rb index c7b537a9923df1c188c9e47a511052aea8377c77..d99bff2e3492585cbe616b323286c9dd06e811ca 100644 --- a/spec/requests/api/graphql/group_query_spec.rb +++ b/spec/requests/api/graphql/group_query_spec.rb @@ -4,7 +4,7 @@ # Based on spec/requests/api/groups_spec.rb # Should follow closely in order to ensure all situations are covered -describe 'getting group information', :do_not_mock_admin_mode do +RSpec.describe 'getting group information', :do_not_mock_admin_mode do include GraphqlHelpers include UploadHelpers diff --git a/spec/requests/api/graphql/metadata_query_spec.rb b/spec/requests/api/graphql/metadata_query_spec.rb index 4c56c559cf922d402e3a515336950b21ff0c2c75..6344ec371c81c7e2ed6ac5eb4f603ff540097255 100644 --- a/spec/requests/api/graphql/metadata_query_spec.rb +++ b/spec/requests/api/graphql/metadata_query_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'getting project information' do +RSpec.describe 'getting project information' do include GraphqlHelpers let(:query) { graphql_query_for('metadata', {}, all_graphql_fields_for('Metadata')) } diff --git a/spec/requests/api/graphql/metrics/dashboard/annotations_spec.rb b/spec/requests/api/graphql/metrics/dashboard/annotations_spec.rb index cb35411b7a59db42b87d408f83d212a6b1e7067b..c47920087dc85ec3462be2cc1e4fb4c8c0411f30 100644 --- a/spec/requests/api/graphql/metrics/dashboard/annotations_spec.rb +++ b/spec/requests/api/graphql/metrics/dashboard/annotations_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Getting Metrics Dashboard Annotations' do +RSpec.describe 'Getting Metrics Dashboard Annotations' do include GraphqlHelpers let_it_be(:project) { create(:project) } diff --git a/spec/requests/api/graphql/metrics/dashboard_query_spec.rb b/spec/requests/api/graphql/metrics/dashboard_query_spec.rb index b5ff8e9be76b73101ecae143a06718243749822e..456b0a5dea1c1ff771920254e9ece31e7bae6ebd 100644 --- a/spec/requests/api/graphql/metrics/dashboard_query_spec.rb +++ b/spec/requests/api/graphql/metrics/dashboard_query_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Getting Metrics Dashboard' do +RSpec.describe 'Getting Metrics Dashboard' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/multiplexed_queries_spec.rb b/spec/requests/api/graphql/multiplexed_queries_spec.rb index 9ebb57f6b9cf060742f37890118f7cac77153bb0..f79bac6ae3b01d3116bf3f3029a10a0eb925d26c 100644 --- a/spec/requests/api/graphql/multiplexed_queries_spec.rb +++ b/spec/requests/api/graphql/multiplexed_queries_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe 'Multiplexed queries' do +RSpec.describe 'Multiplexed queries' do include GraphqlHelpers it 'returns responses for multiple queries' do diff --git a/spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb b/spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb index a5159da84f399f78308c2e5c4c281b16a774a515..4ad35e7f0d16eb0f722ef538505639d4c8c50168 100644 --- a/spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb +++ b/spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Deleting Sidekiq jobs', :clean_gitlab_redis_queues do +RSpec.describe 'Deleting Sidekiq jobs', :clean_gitlab_redis_queues do include GraphqlHelpers let_it_be(:admin) { create(:admin) } diff --git a/spec/requests/api/graphql/mutations/alert_management/alerts/create_alert_issue_spec.rb b/spec/requests/api/graphql/mutations/alert_management/alerts/create_alert_issue_spec.rb index 5b5b2ec8788e373840fa2f5b3b9fdc0016fcf5a1..6141a172253b57dacc9dd5127e017e4b05170f30 100644 --- a/spec/requests/api/graphql/mutations/alert_management/alerts/create_alert_issue_spec.rb +++ b/spec/requests/api/graphql/mutations/alert_management/alerts/create_alert_issue_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Create an alert issue from an alert' do +RSpec.describe 'Create an alert issue from an alert' do include GraphqlHelpers let_it_be(:user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/alert_management/alerts/update_alert_status_spec.rb b/spec/requests/api/graphql/mutations/alert_management/alerts/update_alert_status_spec.rb index 2a470bda68902543a8f2caabbc5d261438a5db3f..ff55656a2aeae15c1b94f9c05db606c3d07fb3c6 100644 --- a/spec/requests/api/graphql/mutations/alert_management/alerts/update_alert_status_spec.rb +++ b/spec/requests/api/graphql/mutations/alert_management/alerts/update_alert_status_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Setting the status of an alert' do +RSpec.describe 'Setting the status of an alert' do include GraphqlHelpers let_it_be(:user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/award_emojis/add_spec.rb b/spec/requests/api/graphql/mutations/award_emojis/add_spec.rb index 83dec7dd3e2c1c360eb213c4ac8086a3228a8a12..0caf5ee5926f3b87f4da338d0f7552035f6d9d2e 100644 --- a/spec/requests/api/graphql/mutations/award_emojis/add_spec.rb +++ b/spec/requests/api/graphql/mutations/award_emojis/add_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Adding an AwardEmoji' do +RSpec.describe 'Adding an AwardEmoji' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/award_emojis/remove_spec.rb b/spec/requests/api/graphql/mutations/award_emojis/remove_spec.rb index a2997db6cae7b130a0873daa114fbcb2bf92e210..e8791b5c4935c1d0e27ae752b98817fa67f3cb92 100644 --- a/spec/requests/api/graphql/mutations/award_emojis/remove_spec.rb +++ b/spec/requests/api/graphql/mutations/award_emojis/remove_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Removing an AwardEmoji' do +RSpec.describe 'Removing an AwardEmoji' do include GraphqlHelpers let(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb b/spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb index e1180c85c6ba5ecee565a9c79c98f078c6522137..c80f02eafad3677dec5771d56d245e82eeff501a 100644 --- a/spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb +++ b/spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Toggling an AwardEmoji' do +RSpec.describe 'Toggling an AwardEmoji' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/branches/create_spec.rb b/spec/requests/api/graphql/mutations/branches/create_spec.rb index b3c378ec2bc4b1596bc78f8d888fa5ad5412f604..082b445bf3e97406b82de839fdf647c8daba34e4 100644 --- a/spec/requests/api/graphql/mutations/branches/create_spec.rb +++ b/spec/requests/api/graphql/mutations/branches/create_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Creation of a new branch' do +RSpec.describe 'Creation of a new branch' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/commits/create_spec.rb b/spec/requests/api/graphql/mutations/commits/create_spec.rb index 10a699329487f9f3fcb2ebc7b836e24243f89151..9e4a96700bb07683107e525e466f776b798f31a8 100644 --- a/spec/requests/api/graphql/mutations/commits/create_spec.rb +++ b/spec/requests/api/graphql/mutations/commits/create_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Creation of a new commit' do +RSpec.describe 'Creation of a new commit' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/design_management/delete_spec.rb b/spec/requests/api/graphql/mutations/design_management/delete_spec.rb index 10376305b3e9c6a104ed5188129049aec63ab0ec..e329416faeefe0a4934c12c4e0342c5fc624c7e6 100644 --- a/spec/requests/api/graphql/mutations/design_management/delete_spec.rb +++ b/spec/requests/api/graphql/mutations/design_management/delete_spec.rb @@ -2,7 +2,7 @@ require "spec_helper" -describe "deleting designs" do +RSpec.describe "deleting designs" do include GraphqlHelpers include DesignManagementTestHelpers diff --git a/spec/requests/api/graphql/mutations/design_management/upload_spec.rb b/spec/requests/api/graphql/mutations/design_management/upload_spec.rb index 22adc06440688e1df58c7aaa84ad3c0c217d7d45..9a9c7107b20acde4c757a8cb0e6e68f9c593a39f 100644 --- a/spec/requests/api/graphql/mutations/design_management/upload_spec.rb +++ b/spec/requests/api/graphql/mutations/design_management/upload_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require "spec_helper" -describe "uploading designs" do +RSpec.describe "uploading designs" do include GraphqlHelpers include DesignManagementTestHelpers include WorkhorseHelpers diff --git a/spec/requests/api/graphql/mutations/discussions/toggle_resolve_spec.rb b/spec/requests/api/graphql/mutations/discussions/toggle_resolve_spec.rb index 95e967c039d04fcef5f3b7417d8d6f866ac02141..e83da830935722dc388af3116d889639257359e1 100644 --- a/spec/requests/api/graphql/mutations/discussions/toggle_resolve_spec.rb +++ b/spec/requests/api/graphql/mutations/discussions/toggle_resolve_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Toggling the resolve status of a discussion' do +RSpec.describe 'Toggling the resolve status of a discussion' do include GraphqlHelpers let_it_be(:project) { create(:project, :public, :repository) } diff --git a/spec/requests/api/graphql/mutations/issues/set_confidential_spec.rb b/spec/requests/api/graphql/mutations/issues/set_confidential_spec.rb index 4d0bb59b0302bf862802bfade32f968eca380958..3f804a469924385f61cf316e5cb4b5998736cd44 100644 --- a/spec/requests/api/graphql/mutations/issues/set_confidential_spec.rb +++ b/spec/requests/api/graphql/mutations/issues/set_confidential_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Setting an issue as confidential' do +RSpec.describe 'Setting an issue as confidential' do include GraphqlHelpers let(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/issues/set_due_date_spec.rb b/spec/requests/api/graphql/mutations/issues/set_due_date_spec.rb index 1efa9e16233a3691d7c3e13f25e93814d3670e8c..3dd1225db5ad8d2e71fff272b8513c91cf4f5831 100644 --- a/spec/requests/api/graphql/mutations/issues/set_due_date_spec.rb +++ b/spec/requests/api/graphql/mutations/issues/set_due_date_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Setting Due Date of an issue' do +RSpec.describe 'Setting Due Date of an issue' do include GraphqlHelpers let(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/jira_import/start_spec.rb b/spec/requests/api/graphql/mutations/jira_import/start_spec.rb index 296d33aec5d7a67a9cf7cb8e07497b52d8234c8a..050073f8b98dcb17a25b113bc81ce95b89ca302d 100644 --- a/spec/requests/api/graphql/mutations/jira_import/start_spec.rb +++ b/spec/requests/api/graphql/mutations/jira_import/start_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Starting a Jira Import' do +RSpec.describe 'Starting a Jira Import' do include JiraServiceHelper include GraphqlHelpers diff --git a/spec/requests/api/graphql/mutations/merge_requests/create_spec.rb b/spec/requests/api/graphql/mutations/merge_requests/create_spec.rb index 5c63f655f1d4d43ff93b34f81a11918f61cc552f..d4ac639e226cbffa15d4dcd0a716b16ccbc4648b 100644 --- a/spec/requests/api/graphql/mutations/merge_requests/create_spec.rb +++ b/spec/requests/api/graphql/mutations/merge_requests/create_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Creation of a new merge request' do +RSpec.describe 'Creation of a new merge request' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/merge_requests/set_assignees_spec.rb b/spec/requests/api/graphql/mutations/merge_requests/set_assignees_spec.rb index 8f908b7bf8878c474038ea7f8650005252c51a3e..97873b01338c7136da8d6e508c2eea1f2b7b7d6f 100644 --- a/spec/requests/api/graphql/mutations/merge_requests/set_assignees_spec.rb +++ b/spec/requests/api/graphql/mutations/merge_requests/set_assignees_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Setting assignees of a merge request' do +RSpec.describe 'Setting assignees of a merge request' do include GraphqlHelpers let(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/merge_requests/set_labels_spec.rb b/spec/requests/api/graphql/mutations/merge_requests/set_labels_spec.rb index 2112ff0dc74a4eb7a377e4865dc3e6c9b5c1e265..34d347c76fdb9b888c13c3407f437bad95623e4f 100644 --- a/spec/requests/api/graphql/mutations/merge_requests/set_labels_spec.rb +++ b/spec/requests/api/graphql/mutations/merge_requests/set_labels_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Setting labels of a merge request' do +RSpec.describe 'Setting labels of a merge request' do include GraphqlHelpers let(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/merge_requests/set_locked_spec.rb b/spec/requests/api/graphql/mutations/merge_requests/set_locked_spec.rb index c45da613591d2099874315d1f3e74cc0b2ea5d7d..a1a35bc1dcca2ffdabb654e791270cbfa3f42901 100644 --- a/spec/requests/api/graphql/mutations/merge_requests/set_locked_spec.rb +++ b/spec/requests/api/graphql/mutations/merge_requests/set_locked_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Setting locked status of a merge request' do +RSpec.describe 'Setting locked status of a merge request' do include GraphqlHelpers let(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/merge_requests/set_milestone_spec.rb b/spec/requests/api/graphql/mutations/merge_requests/set_milestone_spec.rb index bd558edf9c56bdb04fb487dcad555d1b0c5915bc..d7e2602bd0a0ce80ced8f1ab015afa8dfe12fe6a 100644 --- a/spec/requests/api/graphql/mutations/merge_requests/set_milestone_spec.rb +++ b/spec/requests/api/graphql/mutations/merge_requests/set_milestone_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Setting milestone of a merge request' do +RSpec.describe 'Setting milestone of a merge request' do include GraphqlHelpers let(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/merge_requests/set_subscription_spec.rb b/spec/requests/api/graphql/mutations/merge_requests/set_subscription_spec.rb index 975735bf2467bee251f1510382e8ccd7dc48e57e..6b3035fbf48044bff030547c5377422714f771de 100644 --- a/spec/requests/api/graphql/mutations/merge_requests/set_subscription_spec.rb +++ b/spec/requests/api/graphql/mutations/merge_requests/set_subscription_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Setting subscribed status of a merge request' do +RSpec.describe 'Setting subscribed status of a merge request' do include GraphqlHelpers let(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/merge_requests/set_wip_spec.rb b/spec/requests/api/graphql/mutations/merge_requests/set_wip_spec.rb index 4492c51dbd79c0410a43b7746c363ab09317169e..b06f7aa2ed9da2759037763150586ad12030efce 100644 --- a/spec/requests/api/graphql/mutations/merge_requests/set_wip_spec.rb +++ b/spec/requests/api/graphql/mutations/merge_requests/set_wip_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Setting WIP status of a merge request' do +RSpec.describe 'Setting WIP status of a merge request' do include GraphqlHelpers let(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/metrics/dashboard/annotations/create_spec.rb b/spec/requests/api/graphql/mutations/metrics/dashboard/annotations/create_spec.rb index 8568dc8ffc06fcd55975f4e5efbdb2b3e4848ef3..0e2da94f0f9bb86a68c398f7070729218228bbc4 100644 --- a/spec/requests/api/graphql/mutations/metrics/dashboard/annotations/create_spec.rb +++ b/spec/requests/api/graphql/mutations/metrics/dashboard/annotations/create_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Mutations::Metrics::Dashboard::Annotations::Create do +RSpec.describe Mutations::Metrics::Dashboard::Annotations::Create do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb b/spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb index 4c535434faa96b699756ab3b2364de155c82b945..e847c46be1bd35de40d6b95da4519f7d2b6aaade 100644 --- a/spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb +++ b/spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Adding a DiffNote' do +RSpec.describe 'Adding a DiffNote' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/notes/create/image_diff_note_spec.rb b/spec/requests/api/graphql/mutations/notes/create/image_diff_note_spec.rb index 0bba3e794343572305165960dd215565b0a1f166..896a398e3085e4a092ddb27cef12a6b03f1181d8 100644 --- a/spec/requests/api/graphql/mutations/notes/create/image_diff_note_spec.rb +++ b/spec/requests/api/graphql/mutations/notes/create/image_diff_note_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Adding an image DiffNote' do +RSpec.describe 'Adding an image DiffNote' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/notes/create/note_spec.rb b/spec/requests/api/graphql/mutations/notes/create/note_spec.rb index 9a78d44245e4facddf28658b4b64751041885fb3..2c34bf1c39b47b32bcc5a5ea1c77af401a3e0a25 100644 --- a/spec/requests/api/graphql/mutations/notes/create/note_spec.rb +++ b/spec/requests/api/graphql/mutations/notes/create/note_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Adding a Note' do +RSpec.describe 'Adding a Note' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/notes/destroy_spec.rb b/spec/requests/api/graphql/mutations/notes/destroy_spec.rb index 337a6e6f6e6cecaf89ee75a9c10296913b13b533..6002a5b5b9d38c16c961be6a923ba8dd28bf99d3 100644 --- a/spec/requests/api/graphql/mutations/notes/destroy_spec.rb +++ b/spec/requests/api/graphql/mutations/notes/destroy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Destroying a Note' do +RSpec.describe 'Destroying a Note' do include GraphqlHelpers let!(:note) { create(:note) } diff --git a/spec/requests/api/graphql/mutations/notes/update/image_diff_note_spec.rb b/spec/requests/api/graphql/mutations/notes/update/image_diff_note_spec.rb index 0362fef2d2e5b01d5823b5568f19b8a309e5cecb..f7be671e5f395cd3066e07afc9425be544eed75a 100644 --- a/spec/requests/api/graphql/mutations/notes/update/image_diff_note_spec.rb +++ b/spec/requests/api/graphql/mutations/notes/update/image_diff_note_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Updating an image DiffNote' do +RSpec.describe 'Updating an image DiffNote' do include GraphqlHelpers using RSpec::Parameterized::TableSyntax diff --git a/spec/requests/api/graphql/mutations/notes/update/note_spec.rb b/spec/requests/api/graphql/mutations/notes/update/note_spec.rb index a5c6b72005ea898f66050783dc308e0ea158937c..38378310d9f566fb0d49d86a69cce661ec3d0c7d 100644 --- a/spec/requests/api/graphql/mutations/notes/update/note_spec.rb +++ b/spec/requests/api/graphql/mutations/notes/update/note_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Updating a Note' do +RSpec.describe 'Updating a Note' do include GraphqlHelpers let!(:note) { create(:note, note: original_body) } diff --git a/spec/requests/api/graphql/mutations/snippets/create_spec.rb b/spec/requests/api/graphql/mutations/snippets/create_spec.rb index 642b5e461095c8ac4883bf6e1f2de5214b9437dd..8894a73874ec98f6b41db3c535edf0cf272dc3c9 100644 --- a/spec/requests/api/graphql/mutations/snippets/create_spec.rb +++ b/spec/requests/api/graphql/mutations/snippets/create_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Creating a Snippet' do +RSpec.describe 'Creating a Snippet' do include GraphqlHelpers let_it_be(:user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/snippets/destroy_spec.rb b/spec/requests/api/graphql/mutations/snippets/destroy_spec.rb index cb9aeea74b27eb977595c49be80a28334fc25cf9..8ade72635afa090714ce51a98f644dfcbf6ffcbf 100644 --- a/spec/requests/api/graphql/mutations/snippets/destroy_spec.rb +++ b/spec/requests/api/graphql/mutations/snippets/destroy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Destroying a Snippet' do +RSpec.describe 'Destroying a Snippet' do include GraphqlHelpers let(:current_user) { snippet.author } diff --git a/spec/requests/api/graphql/mutations/snippets/mark_as_spam_spec.rb b/spec/requests/api/graphql/mutations/snippets/mark_as_spam_spec.rb index 6d4dce3f6f1e9cd7fb81ff0322cc14628a38ca3a..97e6ae8fda8ecddffde04b5c98e2dbc108810258 100644 --- a/spec/requests/api/graphql/mutations/snippets/mark_as_spam_spec.rb +++ b/spec/requests/api/graphql/mutations/snippets/mark_as_spam_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Mark snippet as spam', :do_not_mock_admin_mode do +RSpec.describe 'Mark snippet as spam', :do_not_mock_admin_mode do include GraphqlHelpers let_it_be(:admin) { create(:admin) } diff --git a/spec/requests/api/graphql/mutations/snippets/update_spec.rb b/spec/requests/api/graphql/mutations/snippets/update_spec.rb index de2e309c1b62927f087e86b9c09e9268e9f18261..3b2f9dc0f191a93b6b0bb29f9e01928150d272d4 100644 --- a/spec/requests/api/graphql/mutations/snippets/update_spec.rb +++ b/spec/requests/api/graphql/mutations/snippets/update_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Updating a Snippet' do +RSpec.describe 'Updating a Snippet' do include GraphqlHelpers let_it_be(:original_content) { 'Initial content' } diff --git a/spec/requests/api/graphql/mutations/todos/mark_all_done_spec.rb b/spec/requests/api/graphql/mutations/todos/mark_all_done_spec.rb index 40e085027d706f8cfc6b4f3a386b29dfb0caf08a..ed5552f3e30f66c911e3b2539053502f2ca6f116 100644 --- a/spec/requests/api/graphql/mutations/todos/mark_all_done_spec.rb +++ b/spec/requests/api/graphql/mutations/todos/mark_all_done_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Marking all todos done' do +RSpec.describe 'Marking all todos done' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/todos/mark_done_spec.rb b/spec/requests/api/graphql/mutations/todos/mark_done_spec.rb index fabbb3aeb4988a1841ebdbff5224049166b1ae5c..9c4733f67694b221ca8a21345ca91296cb42e8b9 100644 --- a/spec/requests/api/graphql/mutations/todos/mark_done_spec.rb +++ b/spec/requests/api/graphql/mutations/todos/mark_done_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Marking todos done' do +RSpec.describe 'Marking todos done' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/todos/restore_spec.rb b/spec/requests/api/graphql/mutations/todos/restore_spec.rb index faa36c8273a782404e8a2ccf730c971645692e7d..6dedde56e1356c713a3cd04745d169515dff9b80 100644 --- a/spec/requests/api/graphql/mutations/todos/restore_spec.rb +++ b/spec/requests/api/graphql/mutations/todos/restore_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Restoring Todos' do +RSpec.describe 'Restoring Todos' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/namespace/projects_spec.rb b/spec/requests/api/graphql/namespace/projects_spec.rb index 2a95b99572fbc9343ab23496fc32fc3b663849a5..0b634e6b6892019f56001bf94d3faaa3aac6d4f2 100644 --- a/spec/requests/api/graphql/namespace/projects_spec.rb +++ b/spec/requests/api/graphql/namespace/projects_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'getting projects' do +RSpec.describe 'getting projects' do include GraphqlHelpers let(:group) { create(:group) } diff --git a/spec/requests/api/graphql/namespace/root_storage_statistics_spec.rb b/spec/requests/api/graphql/namespace/root_storage_statistics_spec.rb index f7e28043930b2c3d6e2f681aef8c19b8f875cb23..44e68c592489317ffc366c2bfd6ec0648e45dc51 100644 --- a/spec/requests/api/graphql/namespace/root_storage_statistics_spec.rb +++ b/spec/requests/api/graphql/namespace/root_storage_statistics_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'rendering namespace statistics' do +RSpec.describe 'rendering namespace statistics' do include GraphqlHelpers let(:namespace) { user.namespace } diff --git a/spec/requests/api/graphql/project/alert_management/alert_status_counts_spec.rb b/spec/requests/api/graphql/project/alert_management/alert_status_counts_spec.rb index a0d1ff7efc516d261786e904254607b044237835..b62215f43fb452c8055a556fea34dc0b4064c641 100644 --- a/spec/requests/api/graphql/project/alert_management/alert_status_counts_spec.rb +++ b/spec/requests/api/graphql/project/alert_management/alert_status_counts_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe 'getting Alert Management Alert counts by status' do +RSpec.describe 'getting Alert Management Alert counts by status' do include GraphqlHelpers let_it_be(:project) { create(:project, :repository) } diff --git a/spec/requests/api/graphql/project/alert_management/alerts_spec.rb b/spec/requests/api/graphql/project/alert_management/alerts_spec.rb index c591895f2952613f38ed02df00be0f87d77ba743..4ec11762dc2d213669f6c57668b29bb8ad3a4e49 100644 --- a/spec/requests/api/graphql/project/alert_management/alerts_spec.rb +++ b/spec/requests/api/graphql/project/alert_management/alerts_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe 'getting Alert Management Alerts' do +RSpec.describe 'getting Alert Management Alerts' do include GraphqlHelpers let_it_be(:payload) { { 'custom' => { 'alert' => 'payload' } } } diff --git a/spec/requests/api/graphql/project/base_service_spec.rb b/spec/requests/api/graphql/project/base_service_spec.rb index 8199f331fbf4d776222ddbcdaf89de8346d916a0..4dfc242da80d50a7f52b685947eea6fa13e12b5f 100644 --- a/spec/requests/api/graphql/project/base_service_spec.rb +++ b/spec/requests/api/graphql/project/base_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'query Jira service' do +RSpec.describe 'query Jira service' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/project/container_expiration_policy_spec.rb b/spec/requests/api/graphql/project/container_expiration_policy_spec.rb index d0563f9ff05858ec93d4abe3e8faa5632b2d7947..b064e4d43e98eee5956beb814ce54ccbce868283 100644 --- a/spec/requests/api/graphql/project/container_expiration_policy_spec.rb +++ b/spec/requests/api/graphql/project/container_expiration_policy_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe 'getting a repository in a project' do +RSpec.describe 'getting a repository in a project' do include GraphqlHelpers let_it_be(:project) { create(:project) } diff --git a/spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb b/spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb index a1f9fa1f10c4c6c176d0d80423664fcd0043ad4b..b2b42137acfe49d58245ca482a5cbe91b5bc765d 100644 --- a/spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb +++ b/spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe 'getting a detailed sentry error' do +RSpec.describe 'getting a detailed sentry error' do include GraphqlHelpers let_it_be(:project) { create(:project, :repository) } diff --git a/spec/requests/api/graphql/project/error_tracking/sentry_errors_request_spec.rb b/spec/requests/api/graphql/project/error_tracking/sentry_errors_request_spec.rb index 06a0bfc0d328468cf7f99065850929722c9cbc84..cd84ce9cb96249d1c6de3e7e99e85add1c283766 100644 --- a/spec/requests/api/graphql/project/error_tracking/sentry_errors_request_spec.rb +++ b/spec/requests/api/graphql/project/error_tracking/sentry_errors_request_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe 'sentry errors requests' do +RSpec.describe 'sentry errors requests' do include GraphqlHelpers let_it_be(:project) { create(:project, :repository) } let_it_be(:project_setting) { create(:project_error_tracking_setting, project: project) } diff --git a/spec/requests/api/graphql/project/grafana_integration_spec.rb b/spec/requests/api/graphql/project/grafana_integration_spec.rb index c9bc6c1a68eae6eff9168d120ce2c66b4c941391..688959e622deedf26c568ea610401c8422d537be 100644 --- a/spec/requests/api/graphql/project/grafana_integration_spec.rb +++ b/spec/requests/api/graphql/project/grafana_integration_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe 'Getting Grafana Integration' do +RSpec.describe 'Getting Grafana Integration' do include GraphqlHelpers let_it_be(:project) { create(:project, :repository) } diff --git a/spec/requests/api/graphql/project/issue/design_collection/version_spec.rb b/spec/requests/api/graphql/project/issue/design_collection/version_spec.rb index 04f445b4318bf61eb153f5f59b40cde784784944..1b654e660e369938f205baf12b4f13607abdd875 100644 --- a/spec/requests/api/graphql/project/issue/design_collection/version_spec.rb +++ b/spec/requests/api/graphql/project/issue/design_collection/version_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Query.project(fullPath).issue(iid).designCollection.version(sha)' do +RSpec.describe 'Query.project(fullPath).issue(iid).designCollection.version(sha)' do include GraphqlHelpers include DesignManagementTestHelpers diff --git a/spec/requests/api/graphql/project/issue/design_collection/versions_spec.rb b/spec/requests/api/graphql/project/issue/design_collection/versions_spec.rb index 18787bf925d8b8e706a61364a84782f306fdd0f8..640ac95cd86b482ab91a7d65886d803dc4223fe6 100644 --- a/spec/requests/api/graphql/project/issue/design_collection/versions_spec.rb +++ b/spec/requests/api/graphql/project/issue/design_collection/versions_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Getting versions related to an issue' do +RSpec.describe 'Getting versions related to an issue' do include GraphqlHelpers include DesignManagementTestHelpers diff --git a/spec/requests/api/graphql/project/issue/designs/designs_spec.rb b/spec/requests/api/graphql/project/issue/designs/designs_spec.rb index b6fd0d91bda602dc0339a42a0be03f76d5f86567..e47c025f8b2c0b7fe76fecb174456b49684d7551 100644 --- a/spec/requests/api/graphql/project/issue/designs/designs_spec.rb +++ b/spec/requests/api/graphql/project/issue/designs/designs_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Getting designs related to an issue' do +RSpec.describe 'Getting designs related to an issue' do include GraphqlHelpers include DesignManagementTestHelpers diff --git a/spec/requests/api/graphql/project/issue/designs/notes_spec.rb b/spec/requests/api/graphql/project/issue/designs/notes_spec.rb index 0207bb9123ac8894ee124361f3ed440b18e6f6b3..ae5c8363d0f41f3646288371cfc2425a3da9ca35 100644 --- a/spec/requests/api/graphql/project/issue/designs/notes_spec.rb +++ b/spec/requests/api/graphql/project/issue/designs/notes_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Getting designs related to an issue' do +RSpec.describe 'Getting designs related to an issue' do include GraphqlHelpers include DesignManagementTestHelpers diff --git a/spec/requests/api/graphql/project/issue/notes_spec.rb b/spec/requests/api/graphql/project/issue/notes_spec.rb index bfc89434370d13a7b83acfed53afaef5239f781c..97f5261ef1d7d2ef438abdcc7523a1acb3b66f3b 100644 --- a/spec/requests/api/graphql/project/issue/notes_spec.rb +++ b/spec/requests/api/graphql/project/issue/notes_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'getting notes for an issue' do +RSpec.describe 'getting notes for an issue' do include GraphqlHelpers let(:noteable) { create(:issue) } diff --git a/spec/requests/api/graphql/project/issue_spec.rb b/spec/requests/api/graphql/project/issue_spec.rb index 92d2f9d0d31b27104da2a3331b84191057d8afc5..5f3688331813dd80b14499cbd8a5a36d24b99cfd 100644 --- a/spec/requests/api/graphql/project/issue_spec.rb +++ b/spec/requests/api/graphql/project/issue_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Query.project(fullPath).issue(iid)' do +RSpec.describe 'Query.project(fullPath).issue(iid)' do include GraphqlHelpers let_it_be(:project) { create(:project) } diff --git a/spec/requests/api/graphql/project/issues_spec.rb b/spec/requests/api/graphql/project/issues_spec.rb index 3128f527356d0bcc8d4d980db0c89e0812dbcd51..cdfff2f50d40efcf9a66a6eba8cd58d567506c0b 100644 --- a/spec/requests/api/graphql/project/issues_spec.rb +++ b/spec/requests/api/graphql/project/issues_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'getting an issue list for a project' do +RSpec.describe 'getting an issue list for a project' do include GraphqlHelpers let(:project) { create(:project, :repository, :public) } diff --git a/spec/requests/api/graphql/project/jira_import_spec.rb b/spec/requests/api/graphql/project/jira_import_spec.rb index 7be14696963a16deb995e3b5a9d42f123957c1ee..814965262b60e5dd522b9416c6ec3715abc631b1 100644 --- a/spec/requests/api/graphql/project/jira_import_spec.rb +++ b/spec/requests/api/graphql/project/jira_import_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'query Jira import data' do +RSpec.describe 'query Jira import data' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/project/jira_projects_spec.rb b/spec/requests/api/graphql/project/jira_projects_spec.rb index 4d44d55f2def1814c557e62052cae70bd2128b63..d5f59711ab1e0ce98e0e66f6b409a1445102aaa0 100644 --- a/spec/requests/api/graphql/project/jira_projects_spec.rb +++ b/spec/requests/api/graphql/project/jira_projects_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'query Jira projects' do +RSpec.describe 'query Jira projects' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/project/jira_service_spec.rb b/spec/requests/api/graphql/project/jira_service_spec.rb index 4ac598b789fc24852ab232ed174d5e727e74e425..905a669bf0d96117fb89bef0c58f5a795ca7a269 100644 --- a/spec/requests/api/graphql/project/jira_service_spec.rb +++ b/spec/requests/api/graphql/project/jira_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'query Jira service' do +RSpec.describe 'query Jira service' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/project/labels_query_spec.rb b/spec/requests/api/graphql/project/labels_query_spec.rb index ecc43e0a3db1d5b8c152770f879b27b5e3302ed4..eeaaaaee575087bd33266cf619171840b5577cb5 100644 --- a/spec/requests/api/graphql/project/labels_query_spec.rb +++ b/spec/requests/api/graphql/project/labels_query_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'getting project label information' do +RSpec.describe 'getting project label information' do include GraphqlHelpers let_it_be(:project) { create(:project, :public) } diff --git a/spec/requests/api/graphql/project/merge_request/diff_notes_spec.rb b/spec/requests/api/graphql/project/merge_request/diff_notes_spec.rb index c616310a72cb715b6db6226799ddd8ba00969ce1..dd16b052e0e31ce2893bba3b0d7af9f1f29ce0c2 100644 --- a/spec/requests/api/graphql/project/merge_request/diff_notes_spec.rb +++ b/spec/requests/api/graphql/project/merge_request/diff_notes_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'getting notes for a merge request' do +RSpec.describe 'getting notes for a merge request' do include GraphqlHelpers let_it_be(:noteable) { create(:merge_request) } diff --git a/spec/requests/api/graphql/project/merge_request_spec.rb b/spec/requests/api/graphql/project/merge_request_spec.rb index 643532bf2e29e510a305f900f086c01938cc58b6..f4f1cfaaab5ba5047ee7cf2cb2c15f37e759082f 100644 --- a/spec/requests/api/graphql/project/merge_request_spec.rb +++ b/spec/requests/api/graphql/project/merge_request_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'getting merge request information nested in a project' do +RSpec.describe 'getting merge request information nested in a project' do include GraphqlHelpers let(:project) { create(:project, :repository, :public) } diff --git a/spec/requests/api/graphql/project/merge_requests_spec.rb b/spec/requests/api/graphql/project/merge_requests_spec.rb index 49fdfe2987477fd5780c1e3931bf38fc8bcde827..e2255fdb048d7941fc41cd619ce2f6ed3456e279 100644 --- a/spec/requests/api/graphql/project/merge_requests_spec.rb +++ b/spec/requests/api/graphql/project/merge_requests_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'getting merge request listings nested in a project' do +RSpec.describe 'getting merge request listings nested in a project' do include GraphqlHelpers let_it_be(:project) { create(:project, :repository, :public) } diff --git a/spec/requests/api/graphql/project/project_statistics_spec.rb b/spec/requests/api/graphql/project/project_statistics_spec.rb index 05dd5d36c264d2a27b6e2e994a861a83cf161687..c226b10ab517685d751ff4912c0674a5b9bd9773 100644 --- a/spec/requests/api/graphql/project/project_statistics_spec.rb +++ b/spec/requests/api/graphql/project/project_statistics_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'rendering project statistics' do +RSpec.describe 'rendering project statistics' do include GraphqlHelpers let(:project) { create(:project) } diff --git a/spec/requests/api/graphql/project/release_spec.rb b/spec/requests/api/graphql/project/release_spec.rb index e45193b3c28a1da3bd5eaa4fc1fa99affa80c9fc..bd3e5b5c34054b78eeb04af7266fc191c95c2144 100644 --- a/spec/requests/api/graphql/project/release_spec.rb +++ b/spec/requests/api/graphql/project/release_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Query.project(fullPath).release(tagName)' do +RSpec.describe 'Query.project(fullPath).release(tagName)' do include GraphqlHelpers include Presentable diff --git a/spec/requests/api/graphql/project/repository_spec.rb b/spec/requests/api/graphql/project/repository_spec.rb index 261433a3d6a66f4fc88bb9b05efcfbb8cbe38e38..bd719a69647656caedf659f52480751af85cb40f 100644 --- a/spec/requests/api/graphql/project/repository_spec.rb +++ b/spec/requests/api/graphql/project/repository_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe 'getting a repository in a project' do +RSpec.describe 'getting a repository in a project' do include GraphqlHelpers let(:project) { create(:project, :repository) } diff --git a/spec/requests/api/graphql/project/tree/tree_spec.rb b/spec/requests/api/graphql/project/tree/tree_spec.rb index 94128cc21eefb8eea18398424e31367e6501f3e7..bce63d57c389cadcc6e6a51bcf8977ed4e61b733 100644 --- a/spec/requests/api/graphql/project/tree/tree_spec.rb +++ b/spec/requests/api/graphql/project/tree/tree_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe 'getting a tree in a project' do +RSpec.describe 'getting a tree in a project' do include GraphqlHelpers let(:project) { create(:project, :repository) } diff --git a/spec/requests/api/graphql/project_query_spec.rb b/spec/requests/api/graphql/project_query_spec.rb index 9a88b47eea6f7591aba98756aa784fd851240798..b115030afbc208f2fd6ca25f850aec7fbb47bf26 100644 --- a/spec/requests/api/graphql/project_query_spec.rb +++ b/spec/requests/api/graphql/project_query_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'getting project information' do +RSpec.describe 'getting project information' do include GraphqlHelpers let(:project) { create(:project, :repository) } diff --git a/spec/requests/api/graphql/query_spec.rb b/spec/requests/api/graphql/query_spec.rb index 26b4c6eafd7c834da70936af356c738444ed0646..6bd0703c1216f9eeb15b3063e83c2f11c84ccef8 100644 --- a/spec/requests/api/graphql/query_spec.rb +++ b/spec/requests/api/graphql/query_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Query' do +RSpec.describe 'Query' do include GraphqlHelpers let_it_be(:project) { create(:project) } diff --git a/spec/requests/api/graphql/read_only_spec.rb b/spec/requests/api/graphql/read_only_spec.rb index 1d28a71258d0f8238a67ed9336061e0fbf1697c0..ce8a3f6ef5cedd1f4ffaa26d18e4ecb8758e5f4f 100644 --- a/spec/requests/api/graphql/read_only_spec.rb +++ b/spec/requests/api/graphql/read_only_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Requests on a read-only node' do +RSpec.describe 'Requests on a read-only node' do include GraphqlHelpers before do diff --git a/spec/requests/api/graphql/tasks/task_completion_status_spec.rb b/spec/requests/api/graphql/tasks/task_completion_status_spec.rb index c47406ea534d2d313a7323cd0f8eed578b3b5eca..5f4d2aec718d33e4050e9c3e543dd61cf6cdad67 100644 --- a/spec/requests/api/graphql/tasks/task_completion_status_spec.rb +++ b/spec/requests/api/graphql/tasks/task_completion_status_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'getting task completion status information' do +RSpec.describe 'getting task completion status information' do include GraphqlHelpers description_0_done = '- [ ] task 1\n- [ ] task 2' diff --git a/spec/requests/api/graphql/user_query_spec.rb b/spec/requests/api/graphql/user_query_spec.rb index 5ac94bc73237ae58e40d877c31d7f2adf34e4fe8..7ba1788a9efcb29916ec87daca9657457cd4dd28 100644 --- a/spec/requests/api/graphql/user_query_spec.rb +++ b/spec/requests/api/graphql/user_query_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'getting user information' do +RSpec.describe 'getting user information' do include GraphqlHelpers let(:query) do diff --git a/spec/requests/api/graphql/user_spec.rb b/spec/requests/api/graphql/user_spec.rb index 097c75b354163ef0eab61a377024f4d944a73305..d2d6b1fca668321be925d2d06e0f50188e9e4ddb 100644 --- a/spec/requests/api/graphql/user_spec.rb +++ b/spec/requests/api/graphql/user_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'User' do +RSpec.describe 'User' do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql_spec.rb b/spec/requests/api/graphql_spec.rb index 84be5ab09517855633839b0f1f016f3502a3e789..ff1a5aa1540b6a24559932ae869b301637e7d5a3 100644 --- a/spec/requests/api/graphql_spec.rb +++ b/spec/requests/api/graphql_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe 'GraphQL' do +RSpec.describe 'GraphQL' do include GraphqlHelpers let(:query) { graphql_query_for('echo', 'text' => 'Hello world' ) } diff --git a/spec/requests/api/group_boards_spec.rb b/spec/requests/api/group_boards_spec.rb index a9083f82f25d45795ef5e0f7c8014c58c51847da..6ce8b76680731a16e1c67e2a080d3c630d3f5e06 100644 --- a/spec/requests/api/group_boards_spec.rb +++ b/spec/requests/api/group_boards_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::GroupBoards do +RSpec.describe API::GroupBoards do let_it_be(:user) { create(:user) } let_it_be(:non_member) { create(:user) } let_it_be(:guest) { create(:user) } diff --git a/spec/requests/api/group_clusters_spec.rb b/spec/requests/api/group_clusters_spec.rb index fade54f6b11d6fde0a8330371c72e05f0debc60b..0e695cc64a23e52084038f711b01b418fdd44c79 100644 --- a/spec/requests/api/group_clusters_spec.rb +++ b/spec/requests/api/group_clusters_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::GroupClusters do +RSpec.describe API::GroupClusters do include KubernetesHelpers let(:current_user) { create(:user) } diff --git a/spec/requests/api/group_container_repositories_spec.rb b/spec/requests/api/group_container_repositories_spec.rb index 9f439bb2167ba48f5de2d1725fb304cb56062e53..3128becae6d1bce807d9f5d171b07f509885591b 100644 --- a/spec/requests/api/group_container_repositories_spec.rb +++ b/spec/requests/api/group_container_repositories_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::GroupContainerRepositories do +RSpec.describe API::GroupContainerRepositories do let_it_be(:group) { create(:group, :private) } let_it_be(:project) { create(:project, :private, group: group) } let_it_be(:reporter) { create(:user) } diff --git a/spec/requests/api/group_export_spec.rb b/spec/requests/api/group_export_spec.rb index 9dd7797c768b67ed03a931e45a59a490fe804ae4..8ce8068018bec6e683cacaf08ad84f19015d5526 100644 --- a/spec/requests/api/group_export_spec.rb +++ b/spec/requests/api/group_export_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::GroupExport do +RSpec.describe API::GroupExport do let_it_be(:group) { create(:group) } let_it_be(:user) { create(:user) } diff --git a/spec/requests/api/group_import_spec.rb b/spec/requests/api/group_import_spec.rb index b60a1b3f119622690d41621d82d6139c66981f4c..cf7dc7ede515553f36c94025a365eb06e355e094 100644 --- a/spec/requests/api/group_import_spec.rb +++ b/spec/requests/api/group_import_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::GroupImport do +RSpec.describe API::GroupImport do include WorkhorseHelpers let_it_be(:user) { create(:user) } diff --git a/spec/requests/api/group_labels_spec.rb b/spec/requests/api/group_labels_spec.rb index 715c1255cb371c4bfb96ec3bf9cadf0473d17a27..f965a845bbe3c017b84e77fed89a744a6e574b87 100644 --- a/spec/requests/api/group_labels_spec.rb +++ b/spec/requests/api/group_labels_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::GroupLabels do +RSpec.describe API::GroupLabels do let(:user) { create(:user) } let(:group) { create(:group) } let(:subgroup) { create(:group, parent: group) } diff --git a/spec/requests/api/group_milestones_spec.rb b/spec/requests/api/group_milestones_spec.rb index 3e9b6246434ac132e5c9a7a613508732c5596430..2b361f2b503c970ef219ee84f20a3f5ca25eb987 100644 --- a/spec/requests/api/group_milestones_spec.rb +++ b/spec/requests/api/group_milestones_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::GroupMilestones do +RSpec.describe API::GroupMilestones do let(:user) { create(:user) } let(:group) { create(:group, :private) } let(:project) { create(:project, namespace: group) } diff --git a/spec/requests/api/group_variables_spec.rb b/spec/requests/api/group_variables_spec.rb index a5b48985df5a1b9dd9e121f553ec23ec7ee0898f..c6d6ae1615b06e0bb8215cfaa4f967de039ee4bf 100644 --- a/spec/requests/api/group_variables_spec.rb +++ b/spec/requests/api/group_variables_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::GroupVariables do +RSpec.describe API::GroupVariables do let(:group) { create(:group) } let(:user) { create(:user) } diff --git a/spec/requests/api/groups_spec.rb b/spec/requests/api/groups_spec.rb index 9a4494995760ee78d4041df47068f689c9b91ea9..04bf529b74b9cda32ae41f13f54b2236a733c39b 100644 --- a/spec/requests/api/groups_spec.rb +++ b/spec/requests/api/groups_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Groups do +RSpec.describe API::Groups do include GroupAPIHelpers include UploadHelpers diff --git a/spec/requests/api/helpers_spec.rb b/spec/requests/api/helpers_spec.rb index d65c89f48ea548b63944e1c7cd71971c3f3b21c5..12cd5ace84e994bc769decb4604e1538424c0a41 100644 --- a/spec/requests/api/helpers_spec.rb +++ b/spec/requests/api/helpers_spec.rb @@ -4,7 +4,7 @@ require 'raven/transports/dummy' require_relative '../../../config/initializers/sentry' -describe API::Helpers do +RSpec.describe API::Helpers do include API::APIGuard::HelperMethods include described_class include TermsHelper diff --git a/spec/requests/api/import_github_spec.rb b/spec/requests/api/import_github_spec.rb index ecdb02beeb0defd8c3cc586f95415959cc0a8a49..72f273d7a398fb04e966aa849ca5edfc450c6b0c 100644 --- a/spec/requests/api/import_github_spec.rb +++ b/spec/requests/api/import_github_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ImportGithub do +RSpec.describe API::ImportGithub do let(:token) { "asdasd12345" } let(:provider) { :github } let(:access_params) { { github_access_token: token } } diff --git a/spec/requests/api/internal/base_spec.rb b/spec/requests/api/internal/base_spec.rb index 1d79e9cba13d9e596ef91b82c7b4a0cdbacbf72c..7d219954e9da2bdbd2855b72f66b9faef5af530b 100644 --- a/spec/requests/api/internal/base_spec.rb +++ b/spec/requests/api/internal/base_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Internal::Base do +RSpec.describe API::Internal::Base do let_it_be(:user, reload: true) { create(:user) } let_it_be(:project, reload: true) { create(:project, :repository, :wiki_repo) } let_it_be(:personal_snippet) { create(:personal_snippet, :repository, author: user) } diff --git a/spec/requests/api/internal/pages_spec.rb b/spec/requests/api/internal/pages_spec.rb index fecf15c29c2040eacc83b018c7ff20c0535b6c77..48fc95b6574f30a76b0b9670c14b544c39761fd9 100644 --- a/spec/requests/api/internal/pages_spec.rb +++ b/spec/requests/api/internal/pages_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Internal::Pages do +RSpec.describe API::Internal::Pages do let(:auth_headers) do jwt_token = JWT.encode({ 'iss' => 'gitlab-pages' }, Gitlab::Pages.secret, 'HS256') { Gitlab::Pages::INTERNAL_API_REQUEST_HEADER => jwt_token } diff --git a/spec/requests/api/issues/get_group_issues_spec.rb b/spec/requests/api/issues/get_group_issues_spec.rb index 5c925d2a32ea6df13d3b095dfc1aba736c64e733..b53fac3679dbc5d492ed33d054dc520889114a00 100644 --- a/spec/requests/api/issues/get_group_issues_spec.rb +++ b/spec/requests/api/issues/get_group_issues_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Issues do +RSpec.describe API::Issues do let_it_be(:user2) { create(:user) } let_it_be(:admin) { create(:user, :admin) } let_it_be(:non_member) { create(:user) } diff --git a/spec/requests/api/issues/get_project_issues_spec.rb b/spec/requests/api/issues/get_project_issues_spec.rb index 4a728c812153daf2115321931b9bc95f63059c33..7ff07bf580d066d1dd2ccfce80c2e87da01ecfa7 100644 --- a/spec/requests/api/issues/get_project_issues_spec.rb +++ b/spec/requests/api/issues/get_project_issues_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Issues do +RSpec.describe API::Issues do let_it_be(:user) { create(:user) } let_it_be(:project, reload: true) { create(:project, :public, :repository, creator_id: user.id, namespace: user.namespace) } let_it_be(:private_mrs_project) do diff --git a/spec/requests/api/issues/issues_spec.rb b/spec/requests/api/issues/issues_spec.rb index 315396c89c35be8cead937b8009063faf79d7706..05d14c3cd4db79c62c5d69fc497086f12923872b 100644 --- a/spec/requests/api/issues/issues_spec.rb +++ b/spec/requests/api/issues/issues_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Issues do +RSpec.describe API::Issues do let_it_be(:user) { create(:user) } let_it_be(:project, reload: true) { create(:project, :public, :repository, creator_id: user.id, namespace: user.namespace) } let_it_be(:private_mrs_project) do diff --git a/spec/requests/api/issues/post_projects_issues_spec.rb b/spec/requests/api/issues/post_projects_issues_spec.rb index 2e1e5d3204ed996a05918461c4136b95ed37b602..e2f1bb2cd1aa9e2b5c4d7f0ba698957e2b14b616 100644 --- a/spec/requests/api/issues/post_projects_issues_spec.rb +++ b/spec/requests/api/issues/post_projects_issues_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Issues do +RSpec.describe API::Issues do let_it_be(:user) { create(:user) } let_it_be(:project, reload: true) do create(:project, :public, creator_id: user.id, namespace: user.namespace) diff --git a/spec/requests/api/issues/put_projects_issues_spec.rb b/spec/requests/api/issues/put_projects_issues_spec.rb index 62a4d3b48b2ef2575b5dd624754a9958c18b4e35..dac721cbea0f35ac663fec46e53e715ea0c5f7d3 100644 --- a/spec/requests/api/issues/put_projects_issues_spec.rb +++ b/spec/requests/api/issues/put_projects_issues_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Issues do +RSpec.describe API::Issues do let_it_be(:user) { create(:user) } let_it_be(:owner) { create(:owner) } let(:user2) { create(:user) } diff --git a/spec/requests/api/jobs_spec.rb b/spec/requests/api/jobs_spec.rb index 18b5c00d64fdb3080a4695d0d79873c0bfae5113..a1445e3740a6022ab31e167726a8f6a4d0690751 100644 --- a/spec/requests/api/jobs_spec.rb +++ b/spec/requests/api/jobs_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Jobs do +RSpec.describe API::Jobs do include HttpIOHelpers shared_examples 'a job with artifacts and trace' do |result_is_array: true| diff --git a/spec/requests/api/keys_spec.rb b/spec/requests/api/keys_spec.rb index 089ee22982c4be5afab022ea2588b9c5ae85578f..49b8f4a85208bf0364438370bc01086198c785f0 100644 --- a/spec/requests/api/keys_spec.rb +++ b/spec/requests/api/keys_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Keys do +RSpec.describe API::Keys do let(:user) { create(:user) } let(:admin) { create(:admin) } let(:key) { create(:key, user: user, expires_at: 1.day.from_now) } diff --git a/spec/requests/api/labels_spec.rb b/spec/requests/api/labels_spec.rb index 697f22e5f29418a6f795b3ba7b638c96b2988975..fc674fca9b23e3ea4348e316a0f7340d1e43ed72 100644 --- a/spec/requests/api/labels_spec.rb +++ b/spec/requests/api/labels_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Labels do +RSpec.describe API::Labels do def put_labels_api(route_type, user, spec_params, request_params = {}) if route_type == :deprecated put api("/projects/#{project.id}/labels", user), diff --git a/spec/requests/api/lint_spec.rb b/spec/requests/api/lint_spec.rb index 71c2619d898fc91cae939b006cd25f880745f360..4c60c8bd2a3363dd80ab55b41fb4ecf0c8a7b0bf 100644 --- a/spec/requests/api/lint_spec.rb +++ b/spec/requests/api/lint_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Lint do +RSpec.describe API::Lint do describe 'POST /ci/lint' do context 'with valid .gitlab-ci.yaml content' do let(:yaml_content) do diff --git a/spec/requests/api/markdown_spec.rb b/spec/requests/api/markdown_spec.rb index 53e43430b1fce60cc3b99f8d6b98091ec03761fd..35d91963ac921fa51d588b6000bdd4b330646f3e 100644 --- a/spec/requests/api/markdown_spec.rb +++ b/spec/requests/api/markdown_spec.rb @@ -2,7 +2,7 @@ require "spec_helper" -describe API::Markdown do +RSpec.describe API::Markdown do describe "POST /markdown" do let(:user) {} # No-op. It gets overwritten in the contexts below. diff --git a/spec/requests/api/members_spec.rb b/spec/requests/api/members_spec.rb index 0ecef26c27a07a69b3fb0ee224a566994252f152..db910c6f0978c1c8e874a106c6ce86ae99e95ad0 100644 --- a/spec/requests/api/members_spec.rb +++ b/spec/requests/api/members_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Members do +RSpec.describe API::Members do let(:maintainer) { create(:user, username: 'maintainer_user') } let(:developer) { create(:user) } let(:access_requester) { create(:user) } diff --git a/spec/requests/api/merge_request_diffs_spec.rb b/spec/requests/api/merge_request_diffs_spec.rb index d00bc4a6dde6d2997e677145ba428fe7619b54c7..3f41a7a034df817340cf46b4ff4d1c89366167c6 100644 --- a/spec/requests/api/merge_request_diffs_spec.rb +++ b/spec/requests/api/merge_request_diffs_spec.rb @@ -2,7 +2,7 @@ require "spec_helper" -describe API::MergeRequestDiffs, 'MergeRequestDiffs' do +RSpec.describe API::MergeRequestDiffs, 'MergeRequestDiffs' do let!(:user) { create(:user) } let!(:merge_request) { create(:merge_request, importing: true) } let!(:project) { merge_request.target_project } diff --git a/spec/requests/api/merge_requests_spec.rb b/spec/requests/api/merge_requests_spec.rb index 7a0077f853af5b4ba356671d07b19867ffd82218..803178d590f5290ff2b7bc06a8c349c05ccd8720 100644 --- a/spec/requests/api/merge_requests_spec.rb +++ b/spec/requests/api/merge_requests_spec.rb @@ -2,7 +2,7 @@ require "spec_helper" -describe API::MergeRequests do +RSpec.describe API::MergeRequests do include ProjectForksHelper let(:base_time) { Time.now } diff --git a/spec/requests/api/metrics/dashboard/annotations_spec.rb b/spec/requests/api/metrics/dashboard/annotations_spec.rb index 6377ef2435a0403a7e4883727c866fcc7beab827..07de2925ee2e73f237cfe067be9b0f90837db213 100644 --- a/spec/requests/api/metrics/dashboard/annotations_spec.rb +++ b/spec/requests/api/metrics/dashboard/annotations_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Metrics::Dashboard::Annotations do +RSpec.describe API::Metrics::Dashboard::Annotations do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project, :private, :repository, namespace: user.namespace) } let_it_be(:environment) { create(:environment, project: project) } diff --git a/spec/requests/api/metrics/user_starred_dashboards_spec.rb b/spec/requests/api/metrics/user_starred_dashboards_spec.rb index 8f9394a0e201b70e19f8cc8e0b768e48089e15c8..533dff05f270b4a676c73a479d5b30ea1e4ca523 100644 --- a/spec/requests/api/metrics/user_starred_dashboards_spec.rb +++ b/spec/requests/api/metrics/user_starred_dashboards_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Metrics::UserStarredDashboards do +RSpec.describe API::Metrics::UserStarredDashboards do let_it_be(:user) { create(:user) } let_it_be(:dashboard_yml) { fixture_file('lib/gitlab/metrics/dashboard/sample_dashboard.yml') } let_it_be(:dashboard) { '.gitlab/dashboards/find&seek.yml' } diff --git a/spec/requests/api/namespaces_spec.rb b/spec/requests/api/namespaces_spec.rb index 68fffc638df921d2d05340198d259b64f7b359cf..2ac76d469d552cca604c1f12c5b2c7a8bb069a58 100644 --- a/spec/requests/api/namespaces_spec.rb +++ b/spec/requests/api/namespaces_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Namespaces do +RSpec.describe API::Namespaces do let(:admin) { create(:admin) } let(:user) { create(:user) } let!(:group1) { create(:group, name: 'group.one') } diff --git a/spec/requests/api/notes_spec.rb b/spec/requests/api/notes_spec.rb index 797dd3bb4e285143811b2c1787c61750b4de69ef..1510d31a1a643b47e6a1415df202904aaa41ac47 100644 --- a/spec/requests/api/notes_spec.rb +++ b/spec/requests/api/notes_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Notes do +RSpec.describe API::Notes do let!(:user) { create(:user) } let!(:project) { create(:project, :public) } let(:private_user) { create(:user) } diff --git a/spec/requests/api/notification_settings_spec.rb b/spec/requests/api/notification_settings_spec.rb index 2dfde4c8ec920d5cb1fc31c81bfa13afe0bff7d6..73cb494852497abba1989b19ac9c654bba4493df 100644 --- a/spec/requests/api/notification_settings_spec.rb +++ b/spec/requests/api/notification_settings_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::NotificationSettings do +RSpec.describe API::NotificationSettings do let(:user) { create(:user) } let!(:group) { create(:group) } let!(:project) { create(:project, :public, creator_id: user.id, namespace: group) } diff --git a/spec/requests/api/oauth_tokens_spec.rb b/spec/requests/api/oauth_tokens_spec.rb index 5e775841f12fe21bb3a81a705de9ee3a7d3c9137..f5971054b3cf5fcb6524d257d0c234076c60423f 100644 --- a/spec/requests/api/oauth_tokens_spec.rb +++ b/spec/requests/api/oauth_tokens_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'OAuth tokens' do +RSpec.describe 'OAuth tokens' do include HttpBasicAuthHelpers context 'Resource Owner Password Credentials' do diff --git a/spec/requests/api/pages/internal_access_spec.rb b/spec/requests/api/pages/internal_access_spec.rb index ee55d1c54b7a7765d18c937b9719813d4b4e9230..c894a2d3ca40faac34a11c69bc662fdd19ac3d84 100644 --- a/spec/requests/api/pages/internal_access_spec.rb +++ b/spec/requests/api/pages/internal_access_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe "Internal Project Pages Access" do +RSpec.describe "Internal Project Pages Access" do using RSpec::Parameterized::TableSyntax include AccessMatchers diff --git a/spec/requests/api/pages/pages_spec.rb b/spec/requests/api/pages/pages_spec.rb index 62d43ecff16b2bf380322e8bb47f7d561b7ede00..53e732928ff6428a2ee52fedb367b5a3d0b6c460 100644 --- a/spec/requests/api/pages/pages_spec.rb +++ b/spec/requests/api/pages/pages_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Pages do +RSpec.describe API::Pages do let_it_be(:project) { create(:project, path: 'my.project', pages_https_only: false) } let_it_be(:admin) { create(:admin) } let_it_be(:user) { create(:user) } diff --git a/spec/requests/api/pages/private_access_spec.rb b/spec/requests/api/pages/private_access_spec.rb index 146c6a389f3dc830fa86112dfafda53bc0b228eb..ea5db691b14c64b862c85083ce36dff7c661561a 100644 --- a/spec/requests/api/pages/private_access_spec.rb +++ b/spec/requests/api/pages/private_access_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe "Private Project Pages Access" do +RSpec.describe "Private Project Pages Access" do using RSpec::Parameterized::TableSyntax include AccessMatchers diff --git a/spec/requests/api/pages/public_access_spec.rb b/spec/requests/api/pages/public_access_spec.rb index 7d929e2a287f4e47892bfc7cfa5fa627fd5d585c..ae73cee91d5012ebc0e14fed9bf19237087b8f9e 100644 --- a/spec/requests/api/pages/public_access_spec.rb +++ b/spec/requests/api/pages/public_access_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe "Public Project Pages Access" do +RSpec.describe "Public Project Pages Access" do using RSpec::Parameterized::TableSyntax include AccessMatchers diff --git a/spec/requests/api/pages_domains_spec.rb b/spec/requests/api/pages_domains_spec.rb index 8c411233b27d2725205160d5fbf2aff4cac91be7..b6838a39257138253c17594ab01581866c99eabe 100644 --- a/spec/requests/api/pages_domains_spec.rb +++ b/spec/requests/api/pages_domains_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::PagesDomains do +RSpec.describe API::PagesDomains do let_it_be(:project) { create(:project, path: 'my.project', pages_https_only: false) } let_it_be(:user) { create(:user) } let_it_be(:admin) { create(:admin) } diff --git a/spec/requests/api/pipeline_schedules_spec.rb b/spec/requests/api/pipeline_schedules_spec.rb index 98eaf36b14e2a71053c9370ca9e28e8120d2810d..86f3ff54b836192d18d0526778e4608c867b97ac 100644 --- a/spec/requests/api/pipeline_schedules_spec.rb +++ b/spec/requests/api/pipeline_schedules_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::PipelineSchedules do +RSpec.describe API::PipelineSchedules do let_it_be(:developer) { create(:user) } let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project, :repository, public_builds: false) } diff --git a/spec/requests/api/pipelines_spec.rb b/spec/requests/api/pipelines_spec.rb index b175007ce0dc79ba02e9bc461233847a26c8d3ab..b9bc8eabf2cf27149ab436f633d0fee251a55095 100644 --- a/spec/requests/api/pipelines_spec.rb +++ b/spec/requests/api/pipelines_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Pipelines do +RSpec.describe API::Pipelines do let_it_be(:user) { create(:user) } let_it_be(:non_member) { create(:user) } diff --git a/spec/requests/api/project_clusters_spec.rb b/spec/requests/api/project_clusters_spec.rb index ed899e830e17714b668ae83c33020419063a238e..f01b3bc9d5f723ed8dcc09757e2bf3f028d85106 100644 --- a/spec/requests/api/project_clusters_spec.rb +++ b/spec/requests/api/project_clusters_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ProjectClusters do +RSpec.describe API::ProjectClusters do include KubernetesHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/project_container_repositories_spec.rb b/spec/requests/api/project_container_repositories_spec.rb index 471fc99117b3db2e3bc60a1db504d980abd24a3e..6cf0619cde476997bfb3c3fffdc380c560018a76 100644 --- a/spec/requests/api/project_container_repositories_spec.rb +++ b/spec/requests/api/project_container_repositories_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ProjectContainerRepositories do +RSpec.describe API::ProjectContainerRepositories do include ExclusiveLeaseHelpers let_it_be(:project) { create(:project, :private) } diff --git a/spec/requests/api/project_events_spec.rb b/spec/requests/api/project_events_spec.rb index f65c62f940297d64b2e96e6693f7150b8880eea5..f3e592f9796f9db882b07bc24fa03a2843376a09 100644 --- a/spec/requests/api/project_events_spec.rb +++ b/spec/requests/api/project_events_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ProjectEvents do +RSpec.describe API::ProjectEvents do let(:user) { create(:user) } let(:non_member) { create(:user) } let(:private_project) { create(:project, :private, creator_id: user.id, namespace: user.namespace) } diff --git a/spec/requests/api/project_export_spec.rb b/spec/requests/api/project_export_spec.rb index 58034322a13f5b0d646fb4a6ebe8bf8eb46fe2cd..79c24dfbb6b3052f022f77298c847433a69b7cbe 100644 --- a/spec/requests/api/project_export_spec.rb +++ b/spec/requests/api/project_export_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ProjectExport, :clean_gitlab_redis_cache do +RSpec.describe API::ProjectExport, :clean_gitlab_redis_cache do let_it_be(:project) { create(:project) } let_it_be(:project_none) { create(:project) } let_it_be(:project_started) { create(:project) } diff --git a/spec/requests/api/project_hooks_spec.rb b/spec/requests/api/project_hooks_spec.rb index 4474f2f05779d012e443ee615991b8629550ceb6..8ab90e26a5125b4d8bd9d01f942f90b0bdabf33c 100644 --- a/spec/requests/api/project_hooks_spec.rb +++ b/spec/requests/api/project_hooks_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ProjectHooks, 'ProjectHooks' do +RSpec.describe API::ProjectHooks, 'ProjectHooks' do let(:user) { create(:user) } let(:user3) { create(:user) } let!(:project) { create(:project, creator_id: user.id, namespace: user.namespace) } diff --git a/spec/requests/api/project_import_spec.rb b/spec/requests/api/project_import_spec.rb index 563acd0ece423dd2fe9bce1c98e1e2bb0e20e81a..a6ae636996e7d3e244dea6409b89b79713f1cb83 100644 --- a/spec/requests/api/project_import_spec.rb +++ b/spec/requests/api/project_import_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ProjectImport do +RSpec.describe API::ProjectImport do include WorkhorseHelpers let(:user) { create(:user) } diff --git a/spec/requests/api/project_milestones_spec.rb b/spec/requests/api/project_milestones_spec.rb index c5911d5170669d59554c393b4d0cd3c9c0fd7001..b238949ce47f11d4e70f412382f571b7a6a9f129 100644 --- a/spec/requests/api/project_milestones_spec.rb +++ b/spec/requests/api/project_milestones_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ProjectMilestones do +RSpec.describe API::ProjectMilestones do let(:user) { create(:user) } let!(:project) { create(:project, namespace: user.namespace ) } let!(:closed_milestone) { create(:closed_milestone, project: project, title: 'version1', description: 'closed milestone') } diff --git a/spec/requests/api/project_repository_storage_moves_spec.rb b/spec/requests/api/project_repository_storage_moves_spec.rb index 40966e31d0def522bd59c91f79f31092b25d7bcc..4c9e058ef13dfb37640bfd64aaba53551c14610d 100644 --- a/spec/requests/api/project_repository_storage_moves_spec.rb +++ b/spec/requests/api/project_repository_storage_moves_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ProjectRepositoryStorageMoves do +RSpec.describe API::ProjectRepositoryStorageMoves do include AccessMatchersForRequest let_it_be(:user) { create(:admin) } diff --git a/spec/requests/api/project_snapshots_spec.rb b/spec/requests/api/project_snapshots_spec.rb index a54f317782bf979d41f7aa40bcc7480a76d572c4..f23e374407bac0d69be9b63857a2d4673adcc2e8 100644 --- a/spec/requests/api/project_snapshots_spec.rb +++ b/spec/requests/api/project_snapshots_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ProjectSnapshots do +RSpec.describe API::ProjectSnapshots do include WorkhorseHelpers let(:project) { create(:project) } diff --git a/spec/requests/api/project_snippets_spec.rb b/spec/requests/api/project_snippets_spec.rb index 22189dc3299f9f870af4a7bed55e4887dafc37f3..e1fedd45b0790ce936aadc658ab40fad9befcdeb 100644 --- a/spec/requests/api/project_snippets_spec.rb +++ b/spec/requests/api/project_snippets_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ProjectSnippets do +RSpec.describe API::ProjectSnippets do let_it_be(:project) { create(:project, :public) } let_it_be(:user) { create(:user) } let_it_be(:admin) { create(:admin) } diff --git a/spec/requests/api/project_statistics_spec.rb b/spec/requests/api/project_statistics_spec.rb index 89809a97b960f76c5c5961d2cb70cbe8fae96d0a..5f0cac403aa4bf80f9f88e2323d2096ac59c346f 100644 --- a/spec/requests/api/project_statistics_spec.rb +++ b/spec/requests/api/project_statistics_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ProjectStatistics do +RSpec.describe API::ProjectStatistics do let_it_be(:developer) { create(:user) } let_it_be(:public_project) { create(:project, :public) } diff --git a/spec/requests/api/project_templates_spec.rb b/spec/requests/api/project_templates_spec.rb index caeb465080ec12fbbf393eb426e7c63e68651f9f..59b2b09f0bfad717d35648df1a1ae04bfea20f92 100644 --- a/spec/requests/api/project_templates_spec.rb +++ b/spec/requests/api/project_templates_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ProjectTemplates do +RSpec.describe API::ProjectTemplates do let_it_be(:public_project) { create(:project, :public, path: 'path.with.dot') } let_it_be(:private_project) { create(:project, :private) } let_it_be(:developer) { create(:user) } diff --git a/spec/requests/api/projects_spec.rb b/spec/requests/api/projects_spec.rb index 6f0fe181991b41339ccb9c1c51f2250e850acd8c..a4224bd66d007f24777866c106a6baeee034b910 100644 --- a/spec/requests/api/projects_spec.rb +++ b/spec/requests/api/projects_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -shared_examples 'languages and percentages JSON response' do +RSpec.shared_examples 'languages and percentages JSON response' do let(:expected_languages) { project.repository.languages.map { |language| language.values_at(:label, :value)}.to_h } before do @@ -46,7 +46,7 @@ end end -describe API::Projects do +RSpec.describe API::Projects do include ProjectForksHelper let(:user) { create(:user) } diff --git a/spec/requests/api/protected_branches_spec.rb b/spec/requests/api/protected_branches_spec.rb index 9203e0ec819a0e14f3737400c4e067e8c7284a81..8bcd493eb1f135833849415ca73736ef8dfd449f 100644 --- a/spec/requests/api/protected_branches_spec.rb +++ b/spec/requests/api/protected_branches_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ProtectedBranches do +RSpec.describe API::ProtectedBranches do let(:user) { create(:user) } let!(:project) { create(:project, :repository) } let(:protected_name) { 'feature' } diff --git a/spec/requests/api/protected_tags_spec.rb b/spec/requests/api/protected_tags_spec.rb index 3bc8ecbee739d6c2bf169440a51988fbeab4c11f..cc7261dafc9f866d293289dc5f8f2c1066e93bc7 100644 --- a/spec/requests/api/protected_tags_spec.rb +++ b/spec/requests/api/protected_tags_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ProtectedTags do +RSpec.describe API::ProtectedTags do let(:user) { create(:user) } let!(:project) { create(:project, :repository) } let(:project2) { create(:project, path: 'project2', namespace: user.namespace) } diff --git a/spec/requests/api/release/links_spec.rb b/spec/requests/api/release/links_spec.rb index cf2043ecc7456fb437c035641e99705ea5737703..82d0d64eba4427a6a8691c9ddacbaae378627c6c 100644 --- a/spec/requests/api/release/links_spec.rb +++ b/spec/requests/api/release/links_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Release::Links do +RSpec.describe API::Release::Links do let(:project) { create(:project, :repository, :private) } let(:maintainer) { create(:user) } let(:reporter) { create(:user) } diff --git a/spec/requests/api/releases_spec.rb b/spec/requests/api/releases_spec.rb index f4cb7f25990d779768cfa9933714aa1e513358c1..5e8353d74c3c6f64bb7e97bbc351ef0ac82a73b2 100644 --- a/spec/requests/api/releases_spec.rb +++ b/spec/requests/api/releases_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Releases do +RSpec.describe API::Releases do let(:project) { create(:project, :repository, :private) } let(:maintainer) { create(:user) } let(:reporter) { create(:user) } diff --git a/spec/requests/api/remote_mirrors_spec.rb b/spec/requests/api/remote_mirrors_spec.rb index 3029b8443b04c75642d8e955bb55a6473a42d872..436efb708fdddc1c58ed1abd6d6433db04e16ac7 100644 --- a/spec/requests/api/remote_mirrors_spec.rb +++ b/spec/requests/api/remote_mirrors_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::RemoteMirrors do +RSpec.describe API::RemoteMirrors do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project, :repository, :remote_mirror) } let_it_be(:developer) { create(:user) { |u| project.add_developer(u) } } diff --git a/spec/requests/api/repositories_spec.rb b/spec/requests/api/repositories_spec.rb index 55243e830175b76cbfb6d2b3d55e0985b459a25d..27e6c3d42bb427034984e620705e91aa5ea4108d 100644 --- a/spec/requests/api/repositories_spec.rb +++ b/spec/requests/api/repositories_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' require 'mime/types' -describe API::Repositories do +RSpec.describe API::Repositories do include RepoHelpers include WorkhorseHelpers diff --git a/spec/requests/api/resource_label_events_spec.rb b/spec/requests/api/resource_label_events_spec.rb index 7619399458ae45fe96be2ac7779e791c79a8e4fb..a4a70d898126d98d6782125cde931e78b74ec159 100644 --- a/spec/requests/api/resource_label_events_spec.rb +++ b/spec/requests/api/resource_label_events_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ResourceLabelEvents do +RSpec.describe API::ResourceLabelEvents do let_it_be(:user) { create(:user) } let_it_be(:project, reload: true) { create(:project, :public, namespace: user.namespace) } let_it_be(:label) { create(:label, project: project) } diff --git a/spec/requests/api/resource_milestone_events_spec.rb b/spec/requests/api/resource_milestone_events_spec.rb index b2e92fde5ee33b91f9a0c940cca361fcd2170c6e..5c81c2180d73f776aa984a7d8422834868423b1a 100644 --- a/spec/requests/api/resource_milestone_events_spec.rb +++ b/spec/requests/api/resource_milestone_events_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::ResourceMilestoneEvents do +RSpec.describe API::ResourceMilestoneEvents do let!(:user) { create(:user) } let!(:project) { create(:project, :public, namespace: user.namespace) } let!(:milestone) { create(:milestone, project: project) } diff --git a/spec/requests/api/runner_spec.rb b/spec/requests/api/runner_spec.rb index fc0d4b91aa2d1a50d81e159f5a9fe6368e5a8914..c7d068a1a7888409b74e530b8d564c7bf5ab0a91 100644 --- a/spec/requests/api/runner_spec.rb +++ b/spec/requests/api/runner_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Runner, :clean_gitlab_redis_shared_state do +RSpec.describe API::Runner, :clean_gitlab_redis_shared_state do include StubGitlabCalls include RedisHelpers include WorkhorseHelpers diff --git a/spec/requests/api/runners_spec.rb b/spec/requests/api/runners_spec.rb index 3613cf116a0ccc9f177e19795f9d19148004fc98..0726ab5e3d8584637d3448d02a515e0b574f53d4 100644 --- a/spec/requests/api/runners_spec.rb +++ b/spec/requests/api/runners_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Runners do +RSpec.describe API::Runners do let_it_be(:admin) { create(:user, :admin) } let_it_be(:user) { create(:user) } let_it_be(:user2) { create(:user) } diff --git a/spec/requests/api/search_spec.rb b/spec/requests/api/search_spec.rb index a02d804ee9b0d852dc11bef2a7df23f359c8012b..1a93be98a67953518bf4b34a57e59ec1279a3d02 100644 --- a/spec/requests/api/search_spec.rb +++ b/spec/requests/api/search_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Search do +RSpec.describe API::Search do let_it_be(:user) { create(:user) } let_it_be(:group) { create(:group) } let_it_be(:project, reload: true) { create(:project, :wiki_repo, :public, name: 'awesome project', group: group) } diff --git a/spec/requests/api/services_spec.rb b/spec/requests/api/services_spec.rb index 53265574e6a0a079a4c3a8e81ee3382a6b97d972..5528a0c094f6b26766b262c2952758817b5c8041 100644 --- a/spec/requests/api/services_spec.rb +++ b/spec/requests/api/services_spec.rb @@ -2,7 +2,7 @@ require "spec_helper" -describe API::Services do +RSpec.describe API::Services do let_it_be(:user) { create(:user) } let_it_be(:user2) { create(:user) } diff --git a/spec/requests/api/settings_spec.rb b/spec/requests/api/settings_spec.rb index e6dd1fecb69260d7fb0feb0d3b531f3b476edc05..1df4d7ea9f6f7d6679d39833273e20a3e2b40703 100644 --- a/spec/requests/api/settings_spec.rb +++ b/spec/requests/api/settings_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Settings, 'Settings' do +RSpec.describe API::Settings, 'Settings' do let(:user) { create(:user) } let_it_be(:admin) { create(:admin) } diff --git a/spec/requests/api/sidekiq_metrics_spec.rb b/spec/requests/api/sidekiq_metrics_spec.rb index 705ae29d5d8e94188ec90fa0c5b1d8b91a9e7e82..23ac2ea5c0b6549a9622af92168a23104747efee 100644 --- a/spec/requests/api/sidekiq_metrics_spec.rb +++ b/spec/requests/api/sidekiq_metrics_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::SidekiqMetrics do +RSpec.describe API::SidekiqMetrics do let(:admin) { create(:user, :admin) } describe 'GET sidekiq/*' do diff --git a/spec/requests/api/snippets_spec.rb b/spec/requests/api/snippets_spec.rb index c12c95ae2e07a0483c96916948d4b6413f71c0ae..e5eb9b45f4bce0ee4228ed2c81eb5558c5dfcbb4 100644 --- a/spec/requests/api/snippets_spec.rb +++ b/spec/requests/api/snippets_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Snippets do +RSpec.describe API::Snippets do let_it_be(:user) { create(:user) } describe 'GET /snippets/' do diff --git a/spec/requests/api/statistics_spec.rb b/spec/requests/api/statistics_spec.rb index 5aea5c225a0b874c647a28c84f07da6959e878cb..eab97b6916e38b3c2b9531a454fdb70e93e04d20 100644 --- a/spec/requests/api/statistics_spec.rb +++ b/spec/requests/api/statistics_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Statistics, 'Statistics' do +RSpec.describe API::Statistics, 'Statistics' do include ProjectForksHelper tables_to_analyze = %w[ projects diff --git a/spec/requests/api/submodules_spec.rb b/spec/requests/api/submodules_spec.rb index 2604dc18005e82b4cce8df1bedfde9dc15f2a002..6b141d6d036a2835a84777e71347136323f4b7b5 100644 --- a/spec/requests/api/submodules_spec.rb +++ b/spec/requests/api/submodules_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Submodules do +RSpec.describe API::Submodules do let(:user) { create(:user) } let!(:project) { create(:project, :repository, namespace: user.namespace ) } let(:guest) { create(:user) { |u| project.add_guest(u) } } diff --git a/spec/requests/api/suggestions_spec.rb b/spec/requests/api/suggestions_spec.rb index ffb8c811622abb47bc9ae3764c301fb7c69a77eb..34d3c54d7004efda23c3629823fc38e1f0be7d5c 100644 --- a/spec/requests/api/suggestions_spec.rb +++ b/spec/requests/api/suggestions_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Suggestions do +RSpec.describe API::Suggestions do let(:project) { create(:project, :repository) } let(:user) { create(:user) } diff --git a/spec/requests/api/system_hooks_spec.rb b/spec/requests/api/system_hooks_spec.rb index 609aa615d3313b6d223904ad0210562c937ef150..01b46053d523eccbc51a6d68f2bb793776abd1c8 100644 --- a/spec/requests/api/system_hooks_spec.rb +++ b/spec/requests/api/system_hooks_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::SystemHooks do +RSpec.describe API::SystemHooks do include StubRequests let(:user) { create(:user) } diff --git a/spec/requests/api/tags_spec.rb b/spec/requests/api/tags_spec.rb index 694802ce1b8fa9159037dd6f79c82779064254c0..b029c0f5793817b49307bc05bb8a4bf5b09b2513 100644 --- a/spec/requests/api/tags_spec.rb +++ b/spec/requests/api/tags_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Tags do +RSpec.describe API::Tags do let(:user) { create(:user) } let(:guest) { create(:user).tap { |u| project.add_guest(u) } } let(:project) { create(:project, :repository, creator: user, path: 'my.project') } diff --git a/spec/requests/api/task_completion_status_spec.rb b/spec/requests/api/task_completion_status_spec.rb index 4dd1e27bd4bc426d4c642542a3c5cbe628756399..97ce858ba12409b3614b4e4999b14f326bd4cfcc 100644 --- a/spec/requests/api/task_completion_status_spec.rb +++ b/spec/requests/api/task_completion_status_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'task completion status response' do +RSpec.describe 'task completion status response' do let_it_be(:user) { create(:user) } let_it_be(:project) do create(:project, :public, creator_id: user.id, namespace: user.namespace) diff --git a/spec/requests/api/templates_spec.rb b/spec/requests/api/templates_spec.rb index fae338b4ca3b0573edce16740aa072684ed4cc52..e1c5bfd82c436f6c62e70e4703729dda8c75ca5c 100644 --- a/spec/requests/api/templates_spec.rb +++ b/spec/requests/api/templates_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Templates do +RSpec.describe API::Templates do context 'the Template Entity' do before do get api('/templates/gitignores/Ruby') diff --git a/spec/requests/api/terraform/state_spec.rb b/spec/requests/api/terraform/state_spec.rb index ec9db5566e3e97014d45fa65e2e012af43cbf7ce..2ddbfe6fa9559320101c35bfed21b51b1370adaa 100644 --- a/spec/requests/api/terraform/state_spec.rb +++ b/spec/requests/api/terraform/state_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Terraform::State do +RSpec.describe API::Terraform::State do include HttpBasicAuthHelpers let_it_be(:project) { create(:project) } diff --git a/spec/requests/api/todos_spec.rb b/spec/requests/api/todos_spec.rb index 0bdc71a30e9561ba558fb0ce2ed7c8b9931b630b..dfd0e13d84c748075abf103ebe549f3645273a36 100644 --- a/spec/requests/api/todos_spec.rb +++ b/spec/requests/api/todos_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Todos do +RSpec.describe API::Todos do let_it_be(:group) { create(:group) } let_it_be(:project_1) { create(:project, :repository, group: group) } let_it_be(:project_2) { create(:project) } diff --git a/spec/requests/api/triggers_spec.rb b/spec/requests/api/triggers_spec.rb index 19b01cb79134b6981c593c0d4e361f7916e9fbf3..c51358bf6594f06902ac579d476f8d86b4e28db9 100644 --- a/spec/requests/api/triggers_spec.rb +++ b/spec/requests/api/triggers_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Triggers do +RSpec.describe API::Triggers do let_it_be(:user) { create(:user) } let_it_be(:user2) { create(:user) } diff --git a/spec/requests/api/user_counts_spec.rb b/spec/requests/api/user_counts_spec.rb index 688dfe11115d54e0d15136f310d992c85ff62fb1..94e25d647fc6ff8b6f180d9d7754d0a81556c9f3 100644 --- a/spec/requests/api/user_counts_spec.rb +++ b/spec/requests/api/user_counts_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::UserCounts do +RSpec.describe API::UserCounts do let(:user) { create(:user) } let(:project) { create(:project, :public) } diff --git a/spec/requests/api/users_spec.rb b/spec/requests/api/users_spec.rb index e780f67bcabce95aa5928ceebffa88311c1ab656..bae8e0cdec252f458d7f65db81b57148b0b57637 100644 --- a/spec/requests/api/users_spec.rb +++ b/spec/requests/api/users_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Users, :do_not_mock_admin_mode do +RSpec.describe API::Users, :do_not_mock_admin_mode do let_it_be(:admin) { create(:admin) } let_it_be(:user, reload: true) { create(:user, username: 'user.with.dot') } let_it_be(:key) { create(:key, user: user) } diff --git a/spec/requests/api/variables_spec.rb b/spec/requests/api/variables_spec.rb index f209a1d2e6e8aed3c4f6479db95db9f8ad455d72..0cedfe578e388bcf5a4eaf60a4d14f0ef7a98057 100644 --- a/spec/requests/api/variables_spec.rb +++ b/spec/requests/api/variables_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Variables do +RSpec.describe API::Variables do let(:user) { create(:user) } let(:user2) { create(:user) } let!(:project) { create(:project, creator_id: user.id) } diff --git a/spec/requests/api/version_spec.rb b/spec/requests/api/version_spec.rb index 9eb8c03e2732fb50eeb7c69ce9c5e9a085a37d5d..a0a0f66c8d1b4a271039f434c5eb40b740dc65ef 100644 --- a/spec/requests/api/version_spec.rb +++ b/spec/requests/api/version_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe API::Version do +RSpec.describe API::Version do shared_examples_for 'GET /version' do context 'when unauthenticated' do it 'returns authentication error' do diff --git a/spec/requests/api/wikis_spec.rb b/spec/requests/api/wikis_spec.rb index 43a5cb446bb46a2e3f80b01cc135cf5c4f6ec25a..ea22e4421278c9ed108e100f69cfa7bb80390832 100644 --- a/spec/requests/api/wikis_spec.rb +++ b/spec/requests/api/wikis_spec.rb @@ -12,7 +12,7 @@ # - maintainer # because they are 3 edge cases of using wiki pages. -describe API::Wikis do +RSpec.describe API::Wikis do include WorkhorseHelpers let(:user) { create(:user) } diff --git a/spec/requests/boards/lists_controller_spec.rb b/spec/requests/boards/lists_controller_spec.rb index 7451ad93efd5075647bee3aa46b22a440bd41ed1..4d9f1dace4dd471f720b371ea59da13ad9c557e6 100644 --- a/spec/requests/boards/lists_controller_spec.rb +++ b/spec/requests/boards/lists_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Boards::ListsController do +RSpec.describe Boards::ListsController do describe '#index' do let(:board) { create(:board) } let(:user) { board.project.owner } diff --git a/spec/requests/git_http_spec.rb b/spec/requests/git_http_spec.rb index 183a3545cf296a05597edb77455c11ea9bb88d45..d387c6df4cf1ca8ebedf04e7c83d85658996b193 100644 --- a/spec/requests/git_http_spec.rb +++ b/spec/requests/git_http_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Git HTTP requests' do +RSpec.describe 'Git HTTP requests' do include ProjectForksHelper include TermsHelper include GitHttpHelpers diff --git a/spec/requests/groups/milestones_controller_spec.rb b/spec/requests/groups/milestones_controller_spec.rb index 1c6743dc6781286fbe225f33f58cae91634fb178..2c4d97ec4c3eaef34ddbd8ab6ce32d427c5dcf40 100644 --- a/spec/requests/groups/milestones_controller_spec.rb +++ b/spec/requests/groups/milestones_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Groups::MilestonesController do +RSpec.describe Groups::MilestonesController do context 'N+1 DB queries' do let(:user) { create(:user) } let!(:public_group) { create(:group, :public) } diff --git a/spec/requests/groups/registry/repositories_controller_spec.rb b/spec/requests/groups/registry/repositories_controller_spec.rb index ab59b006be7eae3deff67c63c63e0aa2dc77e602..89cbd3e4100fcd4956545250d61ced259c33819f 100644 --- a/spec/requests/groups/registry/repositories_controller_spec.rb +++ b/spec/requests/groups/registry/repositories_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Groups::Registry::RepositoriesController do +RSpec.describe Groups::Registry::RepositoriesController do let_it_be(:group, reload: true) { create(:group) } let_it_be(:user) { create(:user) } diff --git a/spec/requests/health_controller_spec.rb b/spec/requests/health_controller_spec.rb index 6ee716e0e89b0b795b2c85ea22a8a1e38efc42af..8b0492a27b95bc7bef74a7df909dadc298a99660 100644 --- a/spec/requests/health_controller_spec.rb +++ b/spec/requests/health_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe HealthController do +RSpec.describe HealthController do include StubENV let(:token) { Gitlab::CurrentSettings.health_check_access_token } diff --git a/spec/requests/import/gitlab_groups_controller_spec.rb b/spec/requests/import/gitlab_groups_controller_spec.rb index 35f2bf0c2f7e6352f6d379bdfcc8e64b989b5ef5..1ca1df2998f72720c00e3e845bb2963370304553 100644 --- a/spec/requests/import/gitlab_groups_controller_spec.rb +++ b/spec/requests/import/gitlab_groups_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Import::GitlabGroupsController do +RSpec.describe Import::GitlabGroupsController do include WorkhorseHelpers let(:import_path) { "#{Dir.tmpdir}/gitlab_groups_controller_spec" } diff --git a/spec/requests/import/gitlab_projects_controller_spec.rb b/spec/requests/import/gitlab_projects_controller_spec.rb index f16755e97661c0df56da14c3fdc3ac2b072e2171..c1ac5a9f2c8c8f11938a8ac7e21b269fd85f6f91 100644 --- a/spec/requests/import/gitlab_projects_controller_spec.rb +++ b/spec/requests/import/gitlab_projects_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Import::GitlabProjectsController do +RSpec.describe Import::GitlabProjectsController do include WorkhorseHelpers let(:workhorse_token) { JWT.encode({ 'iss' => 'gitlab-workhorse' }, Gitlab::Workhorse.secret, 'HS256') } diff --git a/spec/requests/jwt_controller_spec.rb b/spec/requests/jwt_controller_spec.rb index 617587e2fa69306e845adb045fa57c7bf9253e4e..fe6c0f0a55669b677378f8f7210256dc201e620f 100644 --- a/spec/requests/jwt_controller_spec.rb +++ b/spec/requests/jwt_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe JwtController do +RSpec.describe JwtController do include_context 'parsed logs' let(:service) { double(execute: {}) } diff --git a/spec/requests/lfs_http_spec.rb b/spec/requests/lfs_http_spec.rb index f3fa5e36fec7531c0d04e40eeac047666acf01bb..f7771c7b0f9130c892a2956eaad455a7e681c601 100644 --- a/spec/requests/lfs_http_spec.rb +++ b/spec/requests/lfs_http_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe 'Git LFS API and storage' do +RSpec.describe 'Git LFS API and storage' do include LfsHttpHelpers include ProjectForksHelper include WorkhorseHelpers diff --git a/spec/requests/lfs_locks_api_spec.rb b/spec/requests/lfs_locks_api_spec.rb index 41cf1a8020550364bd2710e60be9c39dec0f12fb..34e345cb1cfef3b1b2685bf48b5a95b5f820769d 100644 --- a/spec/requests/lfs_locks_api_spec.rb +++ b/spec/requests/lfs_locks_api_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Git LFS File Locking API' do +RSpec.describe 'Git LFS File Locking API' do include WorkhorseHelpers let(:project) { create(:project) } diff --git a/spec/requests/oauth_tokens_spec.rb b/spec/requests/oauth_tokens_spec.rb index bb1c25d686e040e74dae280d9964ffa2fc6a2319..6d944bbc783e96cfe1a3368454b4aa5626ab780e 100644 --- a/spec/requests/oauth_tokens_spec.rb +++ b/spec/requests/oauth_tokens_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'OAuth Tokens requests' do +RSpec.describe 'OAuth Tokens requests' do let(:user) { create :user } let(:application) { create :oauth_application, scopes: 'api' } diff --git a/spec/requests/openid_connect_spec.rb b/spec/requests/openid_connect_spec.rb index 785ab98a3d01e7bae860312a17406ad8e5a7744d..8da64932ddd3ebb2e61a5a59aa9e350e5071084b 100644 --- a/spec/requests/openid_connect_spec.rb +++ b/spec/requests/openid_connect_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'OpenID Connect requests' do +RSpec.describe 'OpenID Connect requests' do let(:user) do create( :user, diff --git a/spec/requests/profiles/notifications_controller_spec.rb b/spec/requests/profiles/notifications_controller_spec.rb index 0b2741677abdf4042b0e6d0e7fb846625c80663d..d60cee00aef944ed3f4f66b5d7412ec3888895bb 100644 --- a/spec/requests/profiles/notifications_controller_spec.rb +++ b/spec/requests/profiles/notifications_controller_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'view user notifications' do +RSpec.describe 'view user notifications' do let(:user) do create(:user) do |user| user.emails.create(email: 'original@example.com', confirmed_at: Time.current) diff --git a/spec/requests/projects/cycle_analytics_events_spec.rb b/spec/requests/projects/cycle_analytics_events_spec.rb index 773f243e73383e2ec6a9395c3423f38bd5656a19..8c3058d405cb291b55b1805e62d32667fd44fe8f 100644 --- a/spec/requests/projects/cycle_analytics_events_spec.rb +++ b/spec/requests/projects/cycle_analytics_events_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'value stream analytics events' do +RSpec.describe 'value stream analytics events' do let(:user) { create(:user) } let(:project) { create(:project, :repository, public_builds: false) } let(:issue) { create(:issue, project: project, created_at: 2.days.ago) } diff --git a/spec/requests/projects/merge_requests/creations_spec.rb b/spec/requests/projects/merge_requests/creations_spec.rb index d192e1bca7fbdb043daecbbaceb0e4e7221c8709..0a3e663444fdbc5c0ae7e8f4d637bb67cc186a61 100644 --- a/spec/requests/projects/merge_requests/creations_spec.rb +++ b/spec/requests/projects/merge_requests/creations_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'merge requests creations' do +RSpec.describe 'merge requests creations' do describe 'GET /:namespace/:project/merge_requests/new' do include ProjectForksHelper diff --git a/spec/requests/projects/merge_requests_discussions_spec.rb b/spec/requests/projects/merge_requests_discussions_spec.rb index 94e9c81bc3b037773b51d072155344e7c4051055..6ec586ed22cfcab218cc0b3f1af264b82ea1fc1b 100644 --- a/spec/requests/projects/merge_requests_discussions_spec.rb +++ b/spec/requests/projects/merge_requests_discussions_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'merge requests discussions' do +RSpec.describe 'merge requests discussions' do # Further tests can be found at merge_requests_controller_spec.rb describe 'GET /:namespace/:project/-/merge_requests/:iid/discussions' do let(:project) { create(:project, :repository) } diff --git a/spec/requests/projects/uploads_spec.rb b/spec/requests/projects/uploads_spec.rb index aca4644289dd4d0b027bd6df41dae29af7d79d3f..de5ef36be7ef37dc7a52ba59c926a0179368ef06 100644 --- a/spec/requests/projects/uploads_spec.rb +++ b/spec/requests/projects/uploads_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'File uploads' do +RSpec.describe 'File uploads' do include WorkhorseHelpers let(:project) { create(:project, :public, :repository) } diff --git a/spec/requests/rack_attack_global_spec.rb b/spec/requests/rack_attack_global_spec.rb index 175c5dd0088685b7a20682292f5c71943345fa22..106515a6b13a8799ce1fa010c73fe06f4848b916 100644 --- a/spec/requests/rack_attack_global_spec.rb +++ b/spec/requests/rack_attack_global_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Rack Attack global throttles' do +RSpec.describe 'Rack Attack global throttles' do include RackAttackSpecHelpers let(:settings) { Gitlab::CurrentSettings.current_application_settings } diff --git a/spec/requests/request_profiler_spec.rb b/spec/requests/request_profiler_spec.rb index 36ccfc6b40090e2914c8280f801a9d1ef30fbd57..7f9999bf3d20612a2432aa4988985d6457e5fe58 100644 --- a/spec/requests/request_profiler_spec.rb +++ b/spec/requests/request_profiler_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Request Profiler' do +RSpec.describe 'Request Profiler' do let(:user) { create(:user) } shared_examples 'profiling a request' do |profile_type, extension| diff --git a/spec/requests/self_monitoring_project_spec.rb b/spec/requests/self_monitoring_project_spec.rb index 6a0258c349fedff6ebe9752c04e85de19191c8dc..5844a27da175be31843bf50346decb8a0e84c2b6 100644 --- a/spec/requests/self_monitoring_project_spec.rb +++ b/spec/requests/self_monitoring_project_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Self-Monitoring project requests' do +RSpec.describe 'Self-Monitoring project requests' do let(:admin) { create(:admin) } describe 'POST #create_self_monitoring_project' do diff --git a/spec/requests/sessions_spec.rb b/spec/requests/sessions_spec.rb index 6697700c37d7649dfc727d4307fcb7d2d136e7ac..95df181b7b03b5ab161f2e5a1ecacf2dbaf19474 100644 --- a/spec/requests/sessions_spec.rb +++ b/spec/requests/sessions_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Sessions' do +RSpec.describe 'Sessions' do context 'authentication', :allow_forgery_protection do let(:user) { create(:user) } diff --git a/spec/requests/user_activity_spec.rb b/spec/requests/user_activity_spec.rb index b24760d475b696fa3fb952bf97f014b719cf77f5..6f0726dbdc93475d6d509d38b56027bbe3142edb 100644 --- a/spec/requests/user_activity_spec.rb +++ b/spec/requests/user_activity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Update of user activity' do +RSpec.describe 'Update of user activity' do let(:user) { create(:user, last_activity_on: nil) } before do diff --git a/spec/requests/user_avatar_spec.rb b/spec/requests/user_avatar_spec.rb index 66c7ce4d5333210a6705f8017d9869d192ba38c0..1397741af18e4cfbd26d2be03d30a9a85fd06120 100644 --- a/spec/requests/user_avatar_spec.rb +++ b/spec/requests/user_avatar_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Loading a user avatar' do +RSpec.describe 'Loading a user avatar' do let(:user) { create(:user, :with_avatar) } context 'when logged in' do diff --git a/spec/requests/user_spoofs_ip_spec.rb b/spec/requests/user_spoofs_ip_spec.rb index 8da15665132f293b3bc7abc5ae448bdd2ad61b86..833dae7852963df53fbfbf50a42862c13314af78 100644 --- a/spec/requests/user_spoofs_ip_spec.rb +++ b/spec/requests/user_spoofs_ip_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'User spoofs their IP' do +RSpec.describe 'User spoofs their IP' do it 'raises a 400 error' do get '/nonexistent', headers: { 'Client-Ip' => '1.2.3.4', 'X-Forwarded-For' => '5.6.7.8' } diff --git a/spec/routing/admin/serverless/domains_controller_routing_spec.rb b/spec/routing/admin/serverless/domains_controller_routing_spec.rb index 18c0db6add1ec8be936a2dd63045b4d7cd4644bd..60b60809f4db7fcb48e752626ce78991a052f1d3 100644 --- a/spec/routing/admin/serverless/domains_controller_routing_spec.rb +++ b/spec/routing/admin/serverless/domains_controller_routing_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Admin::Serverless::DomainsController do +RSpec.describe Admin::Serverless::DomainsController do it 'routes to #index' do expect(get: '/admin/serverless/domains').to route_to('admin/serverless/domains#index') end diff --git a/spec/routing/admin_routing_spec.rb b/spec/routing/admin_routing_spec.rb index 25216b0c7126b303c674ef00c3be33c19d1251d2..13e371ad68aeb02150653a32d654a256c98fd2d4 100644 --- a/spec/routing/admin_routing_spec.rb +++ b/spec/routing/admin_routing_spec.rb @@ -11,7 +11,7 @@ # admin_user GET /admin/users/:id(.:format) admin/users#show # PUT /admin/users/:id(.:format) admin/users#update # DELETE /admin/users/:id(.:format) admin/users#destroy -describe Admin::UsersController, "routing" do +RSpec.describe Admin::UsersController, "routing" do it "to #block" do expect(put("/admin/users/1/block")).to route_to('admin/users#block', id: '1') end @@ -58,7 +58,7 @@ # admin_project GET /admin/projects/:id(.:format) admin/projects#show {id: /[^\/]+/} # PUT /admin/projects/:id(.:format) admin/projects#update {id: /[^\/]+/} # DELETE /admin/projects/:id(.:format) admin/projects#destroy {id: /[^\/]+/} -describe Admin::ProjectsController, "routing" do +RSpec.describe Admin::ProjectsController, "routing" do it "to #index" do expect(get("/admin/projects")).to route_to('admin/projects#index') end @@ -75,7 +75,7 @@ # admin_hook DELETE /admin/hooks/:id(.:format) admin/hooks#destroy # PUT /admin/hooks/:id(.:format) admin/hooks#update # edit_admin_hook GET /admin/hooks/:id(.:format) admin/hooks#edit -describe Admin::HooksController, "routing" do +RSpec.describe Admin::HooksController, "routing" do it "to #test" do expect(post("/admin/hooks/1/test")).to route_to('admin/hooks#test', id: '1') end @@ -103,7 +103,7 @@ # admin_hook_hook_log_retry POST /admin/hooks/:hook_id/hook_logs/:id/retry(.:format) admin/hook_logs#retry # admin_hook_hook_log GET /admin/hooks/:hook_id/hook_logs/:id(.:format) admin/hook_logs#show -describe Admin::HookLogsController, 'routing' do +RSpec.describe Admin::HookLogsController, 'routing' do it 'to #retry' do expect(post('/admin/hooks/1/hook_logs/1/retry')).to route_to('admin/hook_logs#retry', hook_id: '1', id: '1') end @@ -114,27 +114,27 @@ end # admin_background_jobs GET /admin/background_jobs(.:format) admin/background_jobs#show -describe Admin::BackgroundJobsController, "routing" do +RSpec.describe Admin::BackgroundJobsController, "routing" do it "to #show" do expect(get("/admin/background_jobs")).to route_to('admin/background_jobs#show') end end # admin_root /admin(.:format) admin/dashboard#index -describe Admin::DashboardController, "routing" do +RSpec.describe Admin::DashboardController, "routing" do it "to #index" do expect(get("/admin")).to route_to('admin/dashboard#index') end end # admin_health_check GET /admin/health_check(.:format) admin/health_check#show -describe Admin::HealthCheckController, "routing" do +RSpec.describe Admin::HealthCheckController, "routing" do it "to #show" do expect(get("/admin/health_check")).to route_to('admin/health_check#show') end end -describe Admin::GroupsController, "routing" do +RSpec.describe Admin::GroupsController, "routing" do let(:name) { 'complex.group-namegit' } it "to #index" do @@ -151,7 +151,7 @@ end end -describe Admin::SessionsController, "routing" do +RSpec.describe Admin::SessionsController, "routing" do it "to #new" do expect(get("/admin/session/new")).to route_to('admin/sessions#new') end diff --git a/spec/routing/environments_spec.rb b/spec/routing/environments_spec.rb index 46d4f31dd31fe7a496655df299e66e58cb4ffffd..5ba02c384e227613ba46e860f7412ad357b0cb99 100644 --- a/spec/routing/environments_spec.rb +++ b/spec/routing/environments_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'environments routing' do +RSpec.describe 'environments routing' do let(:project) { create(:project) } let(:environment) do diff --git a/spec/routing/git_http_routing_spec.rb b/spec/routing/git_http_routing_spec.rb index af14e5f81cb5fa2e2e6daeef2f956db7133125e6..e5216d99eb961090b1424236d3ef52d74a02c822 100644 --- a/spec/routing/git_http_routing_spec.rb +++ b/spec/routing/git_http_routing_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'git_http routing' do +RSpec.describe 'git_http routing' do include RSpec::Rails::RequestExampleGroup describe 'wiki.git routing', 'routing' do diff --git a/spec/routing/group_routing_spec.rb b/spec/routing/group_routing_spec.rb index 2a8454a276dc7169604c9c187e854333fdd904e2..63193649bc7b2da9cddeb979605d9d77651441ee 100644 --- a/spec/routing/group_routing_spec.rb +++ b/spec/routing/group_routing_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe "Groups", "routing" do +RSpec.describe "Groups", "routing" do let(:group_path) { 'complex.group-namegit' } let!(:group) { create(:group, path: group_path) } diff --git a/spec/routing/import_routing_spec.rb b/spec/routing/import_routing_spec.rb index 7e78a1c0cd25ba29df5678de9e881b064da487d7..0ec418d33d1ba0ae3a432c3b93bb41c3504ffa5a 100644 --- a/spec/routing/import_routing_spec.rb +++ b/spec/routing/import_routing_spec.rb @@ -23,7 +23,7 @@ # let(:actions) { [:index] } # let(:controller) { 'issues' } # end -shared_examples 'importer routing' do +RSpec.shared_examples 'importer routing' do let(:except_actions) { [] } let(:is_realtime) { false } @@ -62,7 +62,7 @@ # realtime_changes_import_github GET /import/github/realtime_changes(.:format) import/github#jobs # import_github POST /import/github(.:format) import/github#create # new_import_github GET /import/github/new(.:format) import/github#new -describe Import::GithubController, 'routing' do +RSpec.describe Import::GithubController, 'routing' do it_behaves_like 'importer routing' do let(:provider) { 'github' } let(:is_realtime) { true } @@ -78,7 +78,7 @@ # realtime_changes_import_gitea GET /import/gitea/realtime_changes(.:format) import/gitea#jobs # import_gitea POST /import/gitea(.:format) import/gitea#create # new_import_gitea GET /import/gitea/new(.:format) import/gitea#new -describe Import::GiteaController, 'routing' do +RSpec.describe Import::GiteaController, 'routing' do it_behaves_like 'importer routing' do let(:except_actions) { [:callback] } let(:provider) { 'gitea' } @@ -94,7 +94,7 @@ # callback_import_gitlab GET /import/gitlab/callback(.:format) import/gitlab#callback # jobs_import_gitlab GET /import/gitlab/jobs(.:format) import/gitlab#jobs # import_gitlab POST /import/gitlab(.:format) import/gitlab#create -describe Import::GitlabController, 'routing' do +RSpec.describe Import::GitlabController, 'routing' do it_behaves_like 'importer routing' do let(:except_actions) { [:new] } let(:provider) { 'gitlab' } @@ -105,7 +105,7 @@ # callback_import_bitbucket GET /import/bitbucket/callback(.:format) import/bitbucket#callback # jobs_import_bitbucket GET /import/bitbucket/jobs(.:format) import/bitbucket#jobs # import_bitbucket POST /import/bitbucket(.:format) import/bitbucket#create -describe Import::BitbucketController, 'routing' do +RSpec.describe Import::BitbucketController, 'routing' do it_behaves_like 'importer routing' do let(:except_actions) { [:new] } let(:provider) { 'bitbucket' } @@ -119,7 +119,7 @@ # create_user_map_import_google_code POST /import/google_code/user_map(.:format) import/google_code#create_user_map # import_google_code POST /import/google_code(.:format) import/google_code#create # new_import_google_code GET /import/google_code/new(.:format) import/google_code#new -describe Import::GoogleCodeController, 'routing' do +RSpec.describe Import::GoogleCodeController, 'routing' do it_behaves_like 'importer routing' do let(:except_actions) { [:callback] } let(:provider) { 'google_code' } @@ -145,7 +145,7 @@ # create_user_map_import_fogbugz POST /import/fogbugz/user_map(.:format) import/fogbugz#create_user_map # import_fogbugz POST /import/fogbugz(.:format) import/fogbugz#create # new_import_fogbugz GET /import/fogbugz/new(.:format) import/fogbugz#new -describe Import::FogbugzController, 'routing' do +RSpec.describe Import::FogbugzController, 'routing' do it_behaves_like 'importer routing' do let(:except_actions) { [:callback] } let(:provider) { 'fogbugz' } @@ -167,7 +167,7 @@ # import_gitlab_project POST /import/gitlab_project(.:format) import/gitlab_projects#create # POST /import/gitlab_project(.:format) import/gitlab_projects#create # new_import_gitlab_project GET /import/gitlab_project/new(.:format) import/gitlab_projects#new -describe Import::GitlabProjectsController, 'routing' do +RSpec.describe Import::GitlabProjectsController, 'routing' do it 'to #create' do expect(post('/import/gitlab_project')).to route_to('import/gitlab_projects#create') end @@ -179,7 +179,7 @@ # new_import_phabricator GET /import/phabricator/new(.:format) import/phabricator#new # import_phabricator POST /import/phabricator(.:format) import/phabricator#create -describe Import::PhabricatorController, 'routing' do +RSpec.describe Import::PhabricatorController, 'routing' do it 'to #create' do expect(post("/import/phabricator")).to route_to("import/phabricator#create") end diff --git a/spec/routing/instance_statistics_routing_spec.rb b/spec/routing/instance_statistics_routing_spec.rb index 48a3ac4695c2aadaa650505d412b4b6f656c0dd2..7793c5cce71ef150234732761693451d7c275190 100644 --- a/spec/routing/instance_statistics_routing_spec.rb +++ b/spec/routing/instance_statistics_routing_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Instance Statistics', 'routing' do +RSpec.describe 'Instance Statistics', 'routing' do include RSpec::Rails::RequestExampleGroup it "routes '/-/instance_statistics' to dev ops score" do diff --git a/spec/routing/notifications_routing_spec.rb b/spec/routing/notifications_routing_spec.rb index 8c2b29aabcbc88681950353ad539fd66dde52c80..f545badcdfab93f64708a0f7a513064206e2eca3 100644 --- a/spec/routing/notifications_routing_spec.rb +++ b/spec/routing/notifications_routing_spec.rb @@ -2,7 +2,7 @@ require "spec_helper" -describe "notifications routing" do +RSpec.describe "notifications routing" do it "routes to #show" do expect(get("/profile/notifications")).to route_to("profiles/notifications#show") end diff --git a/spec/routing/openid_connect_spec.rb b/spec/routing/openid_connect_spec.rb index fc170f8986c6434289137e6245130c407d057a39..b52919537300fbdb64da5358c4ae9bd1eefb0fc8 100644 --- a/spec/routing/openid_connect_spec.rb +++ b/spec/routing/openid_connect_spec.rb @@ -6,7 +6,7 @@ # jwks GET /-/jwks(.:format) doorkeeper/openid_connect/discovery#keys # oauth_discovery_provider GET /.well-known/openid-configuration(.:format) doorkeeper/openid_connect/discovery#provider # oauth_discovery_webfinger GET /.well-known/webfinger(.:format) doorkeeper/openid_connect/discovery#webfinger -describe Doorkeeper::OpenidConnect::DiscoveryController, 'routing' do +RSpec.describe Doorkeeper::OpenidConnect::DiscoveryController, 'routing' do it "to #provider" do expect(get('/.well-known/openid-configuration')).to route_to('doorkeeper/openid_connect/discovery#provider') end @@ -26,7 +26,7 @@ # oauth_userinfo GET /oauth/userinfo(.:format) doorkeeper/openid_connect/userinfo#show # POST /oauth/userinfo(.:format) doorkeeper/openid_connect/userinfo#show -describe Doorkeeper::OpenidConnect::UserinfoController, 'routing' do +RSpec.describe Doorkeeper::OpenidConnect::UserinfoController, 'routing' do it "to #show" do expect(get('/oauth/userinfo')).to route_to('doorkeeper/openid_connect/userinfo#show') end diff --git a/spec/routing/project_routing_spec.rb b/spec/routing/project_routing_spec.rb index 966d6f7b106860b2146629c27ec3c392d5fa92c4..90723faf24129539d96980df25cefbbe9c5578ce 100644 --- a/spec/routing/project_routing_spec.rb +++ b/spec/routing/project_routing_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'project routing' do +RSpec.describe 'project routing' do before do allow(Project).to receive(:find_by_full_path).and_return(false) allow(Project).to receive(:find_by_full_path).with('gitlab/gitlabhq', any_args).and_return(true) diff --git a/spec/routing/routing_spec.rb b/spec/routing/routing_spec.rb index 52e60db1aabf3a18aa7e179dc83d97b3edd1108f..02e930c1cbffb6667c0e9c5e34cccf77f65c8cb0 100644 --- a/spec/routing/routing_spec.rb +++ b/spec/routing/routing_spec.rb @@ -9,7 +9,7 @@ # user_snippets GET /users/:username/snippets(.:format) # user_calendar GET /users/:username/calendar(.:format) # user_calendar_activities GET /users/:username/calendar_activities(.:format) -describe UsersController, "routing" do +RSpec.describe UsersController, "routing" do it "to #show" do allow_any_instance_of(::Constraints::UserUrlConstrainer).to receive(:matches?).and_return(true) @@ -42,7 +42,7 @@ end # search GET /search(.:format) search#show -describe SearchController, "routing" do +RSpec.describe SearchController, "routing" do it "to #show" do expect(get("/search")).to route_to('search#show') end @@ -50,7 +50,7 @@ # gitlab_api /api API::API # /:path Grack -describe "Mounted Apps", "routing" do +RSpec.describe "Mounted Apps", "routing" do it "to API" do expect(get("/api/issues")).to be_routable end @@ -67,7 +67,7 @@ # snippet GET /snippets/:id(.:format) snippets#show # PUT /snippets/:id(.:format) snippets#update # DELETE /snippets/:id(.:format) snippets#destroy -describe SnippetsController, "routing" do +RSpec.describe SnippetsController, "routing" do it "to #raw" do expect(get("/snippets/1/raw")).to route_to('snippets#raw', id: '1') end @@ -109,7 +109,7 @@ # help_page GET /help/*path(.:format) help#show # help_shortcuts GET /help/shortcuts(.:format) help#shortcuts # help_ui GET /help/ui(.:format) help#ui -describe HelpController, "routing" do +RSpec.describe HelpController, "routing" do it "to #index" do expect(get("/help")).to route_to('help#index') end @@ -136,7 +136,7 @@ # profile_token GET /profile/token(.:format) profile#token # profile GET /profile(.:format) profile#show # profile_update PUT /profile/update(.:format) profile#update -describe ProfilesController, "routing" do +RSpec.describe ProfilesController, "routing" do it "to #account" do expect(get("/profile/account")).to route_to('profiles/accounts#show') end @@ -157,7 +157,7 @@ # profile_preferences GET /profile/preferences(.:format) profiles/preferences#show # PATCH /profile/preferences(.:format) profiles/preferences#update # PUT /profile/preferences(.:format) profiles/preferences#update -describe Profiles::PreferencesController, 'routing' do +RSpec.describe Profiles::PreferencesController, 'routing' do it 'to #show' do expect(get('/profile/preferences')).to route_to('profiles/preferences#show') end @@ -174,7 +174,7 @@ # key GET /keys/:id(.:format) keys#show # PUT /keys/:id(.:format) keys#update # DELETE /keys/:id(.:format) keys#destroy -describe Profiles::KeysController, "routing" do +RSpec.describe Profiles::KeysController, "routing" do it "to #index" do expect(get("/profile/keys")).to route_to('profiles/keys#index') end @@ -202,7 +202,7 @@ # emails GET /emails(.:format) emails#index # POST /keys(.:format) emails#create # DELETE /keys/:id(.:format) keys#destroy -describe Profiles::EmailsController, "routing" do +RSpec.describe Profiles::EmailsController, "routing" do it "to #index" do expect(get("/profile/emails")).to route_to('profiles/emails#index') end @@ -217,7 +217,7 @@ end # profile_avatar DELETE /profile/avatar(.:format) profiles/avatars#destroy -describe Profiles::AvatarsController, "routing" do +RSpec.describe Profiles::AvatarsController, "routing" do it "to #destroy" do expect(delete("/profile/avatar")).to route_to('profiles/avatars#destroy') end @@ -226,7 +226,7 @@ # dashboard GET /dashboard(.:format) dashboard#show # dashboard_issues GET /dashboard/issues(.:format) dashboard#issues # dashboard_merge_requests GET /dashboard/merge_requests(.:format) dashboard#merge_requests -describe DashboardController, "routing" do +RSpec.describe DashboardController, "routing" do it "to #index" do expect(get("/dashboard")).to route_to('dashboard/projects#index') end @@ -245,13 +245,13 @@ end # root / root#show -describe RootController, 'routing' do +RSpec.describe RootController, 'routing' do it 'to #index' do expect(get('/')).to route_to('root#index') end end -describe "Authentication", "routing" do +RSpec.describe "Authentication", "routing" do it "GET /users/sign_in" do expect(get("/users/sign_in")).to route_to('sessions#new') end @@ -308,7 +308,7 @@ end end -describe HealthCheckController, 'routing' do +RSpec.describe HealthCheckController, 'routing' do it 'to #index' do expect(get('/health_check')).to route_to('health_check#index') end @@ -318,7 +318,7 @@ end end -describe InvitesController, 'routing' do +RSpec.describe InvitesController, 'routing' do let_it_be(:member) { create(:project_member, :invited) } it 'to #show' do @@ -330,7 +330,7 @@ end end -describe AbuseReportsController, 'routing' do +RSpec.describe AbuseReportsController, 'routing' do let_it_be(:user) { create(:user) } it 'to #new' do @@ -342,14 +342,14 @@ end end -describe SentNotificationsController, 'routing' do +RSpec.describe SentNotificationsController, 'routing' do it 'to #unsubscribe' do expect(get("/-/sent_notifications/4bee17d4a63ed60cf5db53417e9aeb4c/unsubscribe")) .to route_to('sent_notifications#unsubscribe', id: '4bee17d4a63ed60cf5db53417e9aeb4c') end end -describe AutocompleteController, 'routing' do +RSpec.describe AutocompleteController, 'routing' do it 'to #users' do expect(get("/-/autocomplete/users")).to route_to('autocomplete#users') end diff --git a/spec/routing/uploads_routing_spec.rb b/spec/routing/uploads_routing_spec.rb index f94ae81eeb5b857f09492ba2e44f7977312ffe97..d1ddf8a6d6a7692475b9e75656e86869a65fb49b 100644 --- a/spec/routing/uploads_routing_spec.rb +++ b/spec/routing/uploads_routing_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe 'Uploads', 'routing' do +RSpec.describe 'Uploads', 'routing' do it 'allows creating uploads for personal snippets' do expect(post('/uploads/personal_snippet?id=1')).to route_to( controller: 'uploads', diff --git a/spec/rubocop/code_reuse_helpers_spec.rb b/spec/rubocop/code_reuse_helpers_spec.rb index 2720141aad2e16d8f2c3d428256268b4bc189282..44260a1f43f0e851720ebdf11f5fb3180d1b6640 100644 --- a/spec/rubocop/code_reuse_helpers_spec.rb +++ b/spec/rubocop/code_reuse_helpers_spec.rb @@ -5,7 +5,7 @@ require 'parser/current' require_relative '../../rubocop/code_reuse_helpers' -describe RuboCop::CodeReuseHelpers do +RSpec.describe RuboCop::CodeReuseHelpers do def parse_source(source, path = 'foo.rb') buffer = Parser::Source::Buffer.new(path) buffer.source = source diff --git a/spec/rubocop/cop/active_record_association_reload_spec.rb b/spec/rubocop/cop/active_record_association_reload_spec.rb index 82caad51359884300aabc5a03dfb0d3e5dd655d4..79053a79c5a63471f0631acbbac96a158525e9b1 100644 --- a/spec/rubocop/cop/active_record_association_reload_spec.rb +++ b/spec/rubocop/cop/active_record_association_reload_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../rubocop/cop/active_record_association_reload' -describe RuboCop::Cop::ActiveRecordAssociationReload, type: :rubocop do +RSpec.describe RuboCop::Cop::ActiveRecordAssociationReload, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/avoid_break_from_strong_memoize_spec.rb b/spec/rubocop/cop/avoid_break_from_strong_memoize_spec.rb index feb85c354efd7c31fc424b546196cf90c87cd9e1..bc9db9cafecf6148b961e1cfd049c0946243ecbf 100644 --- a/spec/rubocop/cop/avoid_break_from_strong_memoize_spec.rb +++ b/spec/rubocop/cop/avoid_break_from_strong_memoize_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../rubocop/cop/avoid_break_from_strong_memoize' -describe RuboCop::Cop::AvoidBreakFromStrongMemoize do +RSpec.describe RuboCop::Cop::AvoidBreakFromStrongMemoize do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers_spec.rb b/spec/rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers_spec.rb index 0271c85d6a1118a3d019650351340eb3be537a51..851493e004ebdf359bc11945931f610265876b0a 100644 --- a/spec/rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers_spec.rb +++ b/spec/rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers' -describe RuboCop::Cop::AvoidKeywordArgumentsInSidekiqWorkers, type: :rubocop do +RSpec.describe RuboCop::Cop::AvoidKeywordArgumentsInSidekiqWorkers, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/avoid_return_from_blocks_spec.rb b/spec/rubocop/cop/avoid_return_from_blocks_spec.rb index 919cd3d98f30b0ce7302c12c4137fc89a2e93cb6..9e571bf96b90d3cf350f51ef8bab5bbfe73a3249 100644 --- a/spec/rubocop/cop/avoid_return_from_blocks_spec.rb +++ b/spec/rubocop/cop/avoid_return_from_blocks_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../rubocop/cop/avoid_return_from_blocks' -describe RuboCop::Cop::AvoidReturnFromBlocks do +RSpec.describe RuboCop::Cop::AvoidReturnFromBlocks do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/avoid_route_redirect_leading_slash_spec.rb b/spec/rubocop/cop/avoid_route_redirect_leading_slash_spec.rb index 7e526666f8802037de2253fad3936a630523ea88..78bc859beda4822fece3b8b7abcc944b243d1a9b 100644 --- a/spec/rubocop/cop/avoid_route_redirect_leading_slash_spec.rb +++ b/spec/rubocop/cop/avoid_route_redirect_leading_slash_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../rubocop/cop/avoid_route_redirect_leading_slash' -describe RuboCop::Cop::AvoidRouteRedirectLeadingSlash, type: :rubocop do +RSpec.describe RuboCop::Cop::AvoidRouteRedirectLeadingSlash, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/ban_catch_throw_spec.rb b/spec/rubocop/cop/ban_catch_throw_spec.rb index fe2557a8b09d37d1a21ef9a0e9e7d6c31d3ea9f7..1d0ccb6d262d5f0687139bfe61e3f4978a23ac21 100644 --- a/spec/rubocop/cop/ban_catch_throw_spec.rb +++ b/spec/rubocop/cop/ban_catch_throw_spec.rb @@ -7,7 +7,7 @@ require_relative '../../../rubocop/cop/ban_catch_throw' -describe RuboCop::Cop::BanCatchThrow, type: :rubocop do +RSpec.describe RuboCop::Cop::BanCatchThrow, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/code_reuse/active_record_spec.rb b/spec/rubocop/cop/code_reuse/active_record_spec.rb index 0f3d886e4b8de43d03da57ad85c131a1a8b077ce..1ec0fb39ba6b5e4bf6dfc813f26745c1be0e9d30 100644 --- a/spec/rubocop/cop/code_reuse/active_record_spec.rb +++ b/spec/rubocop/cop/code_reuse/active_record_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../../rubocop/cop/code_reuse/active_record' -describe RuboCop::Cop::CodeReuse::ActiveRecord do +RSpec.describe RuboCop::Cop::CodeReuse::ActiveRecord do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/code_reuse/finder_spec.rb b/spec/rubocop/cop/code_reuse/finder_spec.rb index 1488a019f6c9de6ec0b6471a85d72fbbe444c879..1935d825b1995f5e766ab29e4cbb833e762f42d3 100644 --- a/spec/rubocop/cop/code_reuse/finder_spec.rb +++ b/spec/rubocop/cop/code_reuse/finder_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../../rubocop/cop/code_reuse/finder' -describe RuboCop::Cop::CodeReuse::Finder, type: :rubocop do +RSpec.describe RuboCop::Cop::CodeReuse::Finder, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/code_reuse/presenter_spec.rb b/spec/rubocop/cop/code_reuse/presenter_spec.rb index e00095ef40ff8f3e77e7d0f7281d78d619108416..1366018ec12a167c799e577d04be5863c5821c80 100644 --- a/spec/rubocop/cop/code_reuse/presenter_spec.rb +++ b/spec/rubocop/cop/code_reuse/presenter_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../../rubocop/cop/code_reuse/presenter' -describe RuboCop::Cop::CodeReuse::Presenter, type: :rubocop do +RSpec.describe RuboCop::Cop::CodeReuse::Presenter, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/code_reuse/serializer_spec.rb b/spec/rubocop/cop/code_reuse/serializer_spec.rb index df41edcf8c8e3ac40e11dd014a4c9ed798e2e390..d4341cc03675b5b8007e548eadbb26a11db17435 100644 --- a/spec/rubocop/cop/code_reuse/serializer_spec.rb +++ b/spec/rubocop/cop/code_reuse/serializer_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../../rubocop/cop/code_reuse/serializer' -describe RuboCop::Cop::CodeReuse::Serializer, type: :rubocop do +RSpec.describe RuboCop::Cop::CodeReuse::Serializer, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/code_reuse/service_class_spec.rb b/spec/rubocop/cop/code_reuse/service_class_spec.rb index 175c8e36e64a2dbbd7a4c4f33a654a77ad9df7c5..b018e743230f906f773c7744a7a2bf06acf18272 100644 --- a/spec/rubocop/cop/code_reuse/service_class_spec.rb +++ b/spec/rubocop/cop/code_reuse/service_class_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../../rubocop/cop/code_reuse/service_class' -describe RuboCop::Cop::CodeReuse::ServiceClass, type: :rubocop do +RSpec.describe RuboCop::Cop::CodeReuse::ServiceClass, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/code_reuse/worker_spec.rb b/spec/rubocop/cop/code_reuse/worker_spec.rb index ee4cbb3a7643f06f69f903e5ed04027e2a6b78f1..bd1246ceb07df26f48191563902ddc817e9cc7c6 100644 --- a/spec/rubocop/cop/code_reuse/worker_spec.rb +++ b/spec/rubocop/cop/code_reuse/worker_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../../rubocop/cop/code_reuse/worker' -describe RuboCop::Cop::CodeReuse::Worker, type: :rubocop do +RSpec.describe RuboCop::Cop::CodeReuse::Worker, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/destroy_all_spec.rb b/spec/rubocop/cop/destroy_all_spec.rb index b6a3b291e3d6898bfe78742fcbe3fd137bef8fc8..3220d44ea2bd683f5dfb11f3334583b98227a4e6 100644 --- a/spec/rubocop/cop/destroy_all_spec.rb +++ b/spec/rubocop/cop/destroy_all_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../rubocop/cop/destroy_all' -describe RuboCop::Cop::DestroyAll, type: :rubocop do +RSpec.describe RuboCop::Cop::DestroyAll, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/filename_length_spec.rb b/spec/rubocop/cop/filename_length_spec.rb index b1cc845787a13f511bfad85dde621e4ff2b15b17..381218c61edada98ad4b10ff46cbb73ad9429054 100644 --- a/spec/rubocop/cop/filename_length_spec.rb +++ b/spec/rubocop/cop/filename_length_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../rubocop/cop/filename_length' -describe RuboCop::Cop::FilenameLength, type: :rubocop do +RSpec.describe RuboCop::Cop::FilenameLength, type: :rubocop do subject(:cop) { described_class.new } it 'does not flag files with names 100 characters long' do diff --git a/spec/rubocop/cop/gitlab/change_timezone_spec.rb b/spec/rubocop/cop/gitlab/change_timezone_spec.rb index cc311754cac6edf958fc6c8a35165646cc16784c..1ec5f28e8115119db9432f14b34278549ffb2cbd 100644 --- a/spec/rubocop/cop/gitlab/change_timezone_spec.rb +++ b/spec/rubocop/cop/gitlab/change_timezone_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../../rubocop/cop/gitlab/change_timzone' -describe RuboCop::Cop::Gitlab::ChangeTimezone, type: :rubocop do +RSpec.describe RuboCop::Cop::Gitlab::ChangeTimezone, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/gitlab/const_get_inherit_false_spec.rb b/spec/rubocop/cop/gitlab/const_get_inherit_false_spec.rb index ebebe8792d9c91c442314702cbacb5628759887c..97ed6b743f94836b575e2bfe91f5aba50c285cf7 100644 --- a/spec/rubocop/cop/gitlab/const_get_inherit_false_spec.rb +++ b/spec/rubocop/cop/gitlab/const_get_inherit_false_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../../rubocop/cop/gitlab/const_get_inherit_false' -describe RuboCop::Cop::Gitlab::ConstGetInheritFalse, type: :rubocop do +RSpec.describe RuboCop::Cop::Gitlab::ConstGetInheritFalse, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/gitlab/duplicate_spec_location_spec.rb b/spec/rubocop/cop/gitlab/duplicate_spec_location_spec.rb index fb18045b3900f8213ba2523a3853f39bdc833aec..1ed21e442906eaa9bd41ff10a8e244ca9535531c 100644 --- a/spec/rubocop/cop/gitlab/duplicate_spec_location_spec.rb +++ b/spec/rubocop/cop/gitlab/duplicate_spec_location_spec.rb @@ -5,7 +5,7 @@ require_relative '../../../../rubocop/cop/gitlab/duplicate_spec_location' -describe RuboCop::Cop::Gitlab::DuplicateSpecLocation, type: :rubocop do +RSpec.describe RuboCop::Cop::Gitlab::DuplicateSpecLocation, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/gitlab/finder_with_find_by_spec.rb b/spec/rubocop/cop/gitlab/finder_with_find_by_spec.rb index acc05b434b25819d5a677792a4beee6f8b00ae44..30ee422f420d3c7955a1d2c0f024d2795021c9ec 100644 --- a/spec/rubocop/cop/gitlab/finder_with_find_by_spec.rb +++ b/spec/rubocop/cop/gitlab/finder_with_find_by_spec.rb @@ -7,7 +7,7 @@ require_relative '../../../../rubocop/cop/gitlab/finder_with_find_by' -describe RuboCop::Cop::Gitlab::FinderWithFindBy, type: :rubocop do +RSpec.describe RuboCop::Cop::Gitlab::FinderWithFindBy, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/gitlab/httparty_spec.rb b/spec/rubocop/cop/gitlab/httparty_spec.rb index 1585e00730aeac5d193fccca7323196ba959ccfc..379365096ba81f45d3aa3b8fec9de9826937564d 100644 --- a/spec/rubocop/cop/gitlab/httparty_spec.rb +++ b/spec/rubocop/cop/gitlab/httparty_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../../rubocop/cop/gitlab/httparty' -describe RuboCop::Cop::Gitlab::HTTParty, type: :rubocop do # rubocop:disable RSpec/FilePath +RSpec.describe RuboCop::Cop::Gitlab::HTTParty, type: :rubocop do # rubocop:disable RSpec/FilePath include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/gitlab/json_spec.rb b/spec/rubocop/cop/gitlab/json_spec.rb index fbff8c85ca151767e6bf26f9eea4e73d4d0de196..6f5ec07ffb1a3513739aeaf57ddd38a3815eb897 100644 --- a/spec/rubocop/cop/gitlab/json_spec.rb +++ b/spec/rubocop/cop/gitlab/json_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../../rubocop/cop/gitlab/json' -describe RuboCop::Cop::Gitlab::Json, type: :rubocop do +RSpec.describe RuboCop::Cop::Gitlab::Json, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/gitlab/module_with_instance_variables_spec.rb b/spec/rubocop/cop/gitlab/module_with_instance_variables_spec.rb index 1729e196b40824660c08a78810a751b92e2298b0..3d22201c92eed79920c123fe8cd8f9131ddc2cd5 100644 --- a/spec/rubocop/cop/gitlab/module_with_instance_variables_spec.rb +++ b/spec/rubocop/cop/gitlab/module_with_instance_variables_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../../rubocop/cop/gitlab/module_with_instance_variables' -describe RuboCop::Cop::Gitlab::ModuleWithInstanceVariables, type: :rubocop do +RSpec.describe RuboCop::Cop::Gitlab::ModuleWithInstanceVariables, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/gitlab/predicate_memoization_spec.rb b/spec/rubocop/cop/gitlab/predicate_memoization_spec.rb index 3f04b0d636f086cd8172d5b1dd2099cc09822e9f..ebe984b189d7e21b49d40757fcc72e7de2511e0f 100644 --- a/spec/rubocop/cop/gitlab/predicate_memoization_spec.rb +++ b/spec/rubocop/cop/gitlab/predicate_memoization_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../../rubocop/cop/gitlab/predicate_memoization' -describe RuboCop::Cop::Gitlab::PredicateMemoization, type: :rubocop do +RSpec.describe RuboCop::Cop::Gitlab::PredicateMemoization, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/gitlab/rails_logger_spec.rb b/spec/rubocop/cop/gitlab/rails_logger_spec.rb index ed8d20891de43b3849c7e03cd71278cff283d951..0583079136ba17eda8d4e4e07a3c95fe7de8c9f3 100644 --- a/spec/rubocop/cop/gitlab/rails_logger_spec.rb +++ b/spec/rubocop/cop/gitlab/rails_logger_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../../rubocop/cop/gitlab/rails_logger' -describe RuboCop::Cop::Gitlab::RailsLogger, type: :rubocop do +RSpec.describe RuboCop::Cop::Gitlab::RailsLogger, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/gitlab/union_spec.rb b/spec/rubocop/cop/gitlab/union_spec.rb index 593d2bde96d901a31c24c017a9dd37ec9b097ced..571dcc4eeb46df3e33fcfb286acea70f487349f7 100644 --- a/spec/rubocop/cop/gitlab/union_spec.rb +++ b/spec/rubocop/cop/gitlab/union_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../../rubocop/cop/gitlab/union' -describe RuboCop::Cop::Gitlab::Union, type: :rubocop do +RSpec.describe RuboCop::Cop::Gitlab::Union, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/graphql/authorize_types_spec.rb b/spec/rubocop/cop/graphql/authorize_types_spec.rb index ed3b9867a569341e6c36b17b6a98039531a9b211..5d35690c8b70e546b78bdef827aad82323a7af1a 100644 --- a/spec/rubocop/cop/graphql/authorize_types_spec.rb +++ b/spec/rubocop/cop/graphql/authorize_types_spec.rb @@ -5,7 +5,7 @@ require_relative '../../../../rubocop/cop/graphql/authorize_types' -describe RuboCop::Cop::Graphql::AuthorizeTypes, type: :rubocop do +RSpec.describe RuboCop::Cop::Graphql::AuthorizeTypes, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/graphql/descriptions_spec.rb b/spec/rubocop/cop/graphql/descriptions_spec.rb index 245b0c17fb8934dcf03c5a544d3b4f3b8abc7c23..3b29cd2fbeed8df7f34530e26126e35e27ac79e1 100644 --- a/spec/rubocop/cop/graphql/descriptions_spec.rb +++ b/spec/rubocop/cop/graphql/descriptions_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/graphql/descriptions' -describe RuboCop::Cop::Graphql::Descriptions, type: :rubocop do +RSpec.describe RuboCop::Cop::Graphql::Descriptions, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/group_public_or_visible_to_user_spec.rb b/spec/rubocop/cop/group_public_or_visible_to_user_spec.rb index 98d12b119fca526cd32218df7700376eea48be5c..4e725deaafd36057ca05935742841c7625411c00 100644 --- a/spec/rubocop/cop/group_public_or_visible_to_user_spec.rb +++ b/spec/rubocop/cop/group_public_or_visible_to_user_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../rubocop/cop/group_public_or_visible_to_user' -describe RuboCop::Cop::GroupPublicOrVisibleToUser, type: :rubocop do +RSpec.describe RuboCop::Cop::GroupPublicOrVisibleToUser, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/ignored_columns_spec.rb b/spec/rubocop/cop/ignored_columns_spec.rb index 9e51017a3930c41ca7f52ad2ee4f3665535ada08..ec5499bbdff1c9b14d3d372a80a63a9ca7efe031 100644 --- a/spec/rubocop/cop/ignored_columns_spec.rb +++ b/spec/rubocop/cop/ignored_columns_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../rubocop/cop/ignored_columns' -describe RuboCop::Cop::IgnoredColumns, type: :rubocop do +RSpec.describe RuboCop::Cop::IgnoredColumns, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/include_sidekiq_worker_spec.rb b/spec/rubocop/cop/include_sidekiq_worker_spec.rb index ca05e829b4c1b1472d2f52c55294eea1de132496..8d056c6a13e7d9d73f371671190f4b7565284369 100644 --- a/spec/rubocop/cop/include_sidekiq_worker_spec.rb +++ b/spec/rubocop/cop/include_sidekiq_worker_spec.rb @@ -7,7 +7,7 @@ require_relative '../../../rubocop/cop/include_sidekiq_worker' -describe RuboCop::Cop::IncludeSidekiqWorker, type: :rubocop do +RSpec.describe RuboCop::Cop::IncludeSidekiqWorker, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/inject_enterprise_edition_module_spec.rb b/spec/rubocop/cop/inject_enterprise_edition_module_spec.rb index a37c2daa4a668a02b63338a3a0ad21151bdcdb18..767ed9945422819a51995acc87fe23dcf3e6d64b 100644 --- a/spec/rubocop/cop/inject_enterprise_edition_module_spec.rb +++ b/spec/rubocop/cop/inject_enterprise_edition_module_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../rubocop/cop/inject_enterprise_edition_module' -describe RuboCop::Cop::InjectEnterpriseEditionModule, type: :rubocop do +RSpec.describe RuboCop::Cop::InjectEnterpriseEditionModule, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/line_break_around_conditional_block_spec.rb b/spec/rubocop/cop/line_break_around_conditional_block_spec.rb index 3586f3c4708c61c68afaf947485f82d334664024..0a26ef49e359f508145a9bb088a6386ab05ffd61 100644 --- a/spec/rubocop/cop/line_break_around_conditional_block_spec.rb +++ b/spec/rubocop/cop/line_break_around_conditional_block_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../rubocop/cop/line_break_around_conditional_block' -describe RuboCop::Cop::LineBreakAroundConditionalBlock, type: :rubocop do +RSpec.describe RuboCop::Cop::LineBreakAroundConditionalBlock, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/add_column_with_default_spec.rb b/spec/rubocop/cop/migration/add_column_with_default_spec.rb index 3427dd57cebb2722db81e213c771add5975f70d1..50af344e0d454f6fe8eacb94b419ed074ea55a41 100644 --- a/spec/rubocop/cop/migration/add_column_with_default_spec.rb +++ b/spec/rubocop/cop/migration/add_column_with_default_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/add_column_with_default' -describe RuboCop::Cop::Migration::AddColumnWithDefault, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::AddColumnWithDefault, type: :rubocop do include CopHelper let(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/add_columns_to_wide_tables_spec.rb b/spec/rubocop/cop/migration/add_columns_to_wide_tables_spec.rb index b626e79cb9d9fc93ea45c2fe20ca22f3a4f1c8b5..6ae4fb211269ff2ac6455bd8b494abcec1b29c0d 100644 --- a/spec/rubocop/cop/migration/add_columns_to_wide_tables_spec.rb +++ b/spec/rubocop/cop/migration/add_columns_to_wide_tables_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/add_columns_to_wide_tables' -describe RuboCop::Cop::Migration::AddColumnsToWideTables, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::AddColumnsToWideTables, type: :rubocop do include CopHelper let(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/add_concurrent_foreign_key_spec.rb b/spec/rubocop/cop/migration/add_concurrent_foreign_key_spec.rb index efb4869ee93b685ac45a929e8890c4c23ce296e7..b43d44dba65eb705c8a3258711687e634fef0c24 100644 --- a/spec/rubocop/cop/migration/add_concurrent_foreign_key_spec.rb +++ b/spec/rubocop/cop/migration/add_concurrent_foreign_key_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/add_concurrent_foreign_key' -describe RuboCop::Cop::Migration::AddConcurrentForeignKey, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::AddConcurrentForeignKey, type: :rubocop do include CopHelper let(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/add_concurrent_index_spec.rb b/spec/rubocop/cop/migration/add_concurrent_index_spec.rb index b08070d679ee853229ba7d6d99a83545ef654a41..cef5295830cb67b46e2bab22c49fde4192be5dd7 100644 --- a/spec/rubocop/cop/migration/add_concurrent_index_spec.rb +++ b/spec/rubocop/cop/migration/add_concurrent_index_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/add_concurrent_index' -describe RuboCop::Cop::Migration::AddConcurrentIndex, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::AddConcurrentIndex, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/add_index_spec.rb b/spec/rubocop/cop/migration/add_index_spec.rb index 6be2a019fc21b9cb08abe70ebdf0a78dae3e7dc0..6bb78a7f3c7d9dabdda998faa841c623a6081f55 100644 --- a/spec/rubocop/cop/migration/add_index_spec.rb +++ b/spec/rubocop/cop/migration/add_index_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/add_index' -describe RuboCop::Cop::Migration::AddIndex, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::AddIndex, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/add_limit_to_text_columns_spec.rb b/spec/rubocop/cop/migration/add_limit_to_text_columns_spec.rb index 888f9aa6259c0f61108cbf134d657fecacefd5b0..5f0ca419548e5780e762ddef13c10a418d5cdb82 100644 --- a/spec/rubocop/cop/migration/add_limit_to_text_columns_spec.rb +++ b/spec/rubocop/cop/migration/add_limit_to_text_columns_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/add_limit_to_text_columns' -describe RuboCop::Cop::Migration::AddLimitToTextColumns, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::AddLimitToTextColumns, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/add_reference_spec.rb b/spec/rubocop/cop/migration/add_reference_spec.rb index 1bc6782039658075e33873d2f1a2462e7899cf17..fab70d74b550230f9da0c18a09738d76ac9afab1 100644 --- a/spec/rubocop/cop/migration/add_reference_spec.rb +++ b/spec/rubocop/cop/migration/add_reference_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/add_reference' -describe RuboCop::Cop::Migration::AddReference, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::AddReference, type: :rubocop do include CopHelper let(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/add_timestamps_spec.rb b/spec/rubocop/cop/migration/add_timestamps_spec.rb index da4b7d91a5783f852f2fbaa47b2060d5a328e1f4..c18b6b06dedcb5a5059d821ec3799167163c9d32 100644 --- a/spec/rubocop/cop/migration/add_timestamps_spec.rb +++ b/spec/rubocop/cop/migration/add_timestamps_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/add_timestamps' -describe RuboCop::Cop::Migration::AddTimestamps, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::AddTimestamps, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/datetime_spec.rb b/spec/rubocop/cop/migration/datetime_spec.rb index 98ce8ec0666948850c9e4e76f85f730a02a88d2d..c5f6fd503ec7a37f2918b4ecfc26ad943f591118 100644 --- a/spec/rubocop/cop/migration/datetime_spec.rb +++ b/spec/rubocop/cop/migration/datetime_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/datetime' -describe RuboCop::Cop::Migration::Datetime, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::Datetime, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/hash_index_spec.rb b/spec/rubocop/cop/migration/hash_index_spec.rb index 917556a446bcdef0346e5e37f9dba055178f16db..3d26ea41d08cd23ba9b500aaae84b08b36d73ad3 100644 --- a/spec/rubocop/cop/migration/hash_index_spec.rb +++ b/spec/rubocop/cop/migration/hash_index_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/hash_index' -describe RuboCop::Cop::Migration::HashIndex, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::HashIndex, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/prevent_strings_spec.rb b/spec/rubocop/cop/migration/prevent_strings_spec.rb index bcb845cde9d939494a6e315b91901ba2ae1bc4e7..6882dca1926f4c8e49fea081938bcc8babc40318 100644 --- a/spec/rubocop/cop/migration/prevent_strings_spec.rb +++ b/spec/rubocop/cop/migration/prevent_strings_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/prevent_strings' -describe RuboCop::Cop::Migration::PreventStrings, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::PreventStrings, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/remove_column_spec.rb b/spec/rubocop/cop/migration/remove_column_spec.rb index ea9ce89431fdb1a3647be0aae81c3a4839ffa326..7ef5556d8d736bb4942a8ba0fc7af50e3679fd5e 100644 --- a/spec/rubocop/cop/migration/remove_column_spec.rb +++ b/spec/rubocop/cop/migration/remove_column_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/remove_column' -describe RuboCop::Cop::Migration::RemoveColumn, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::RemoveColumn, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/remove_concurrent_index_spec.rb b/spec/rubocop/cop/migration/remove_concurrent_index_spec.rb index 5a71d72be46ef03599e3ea79c474f8dabf7cddde..f70febb571d3b8d3471568ea1e6cef8723d2eaaa 100644 --- a/spec/rubocop/cop/migration/remove_concurrent_index_spec.rb +++ b/spec/rubocop/cop/migration/remove_concurrent_index_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/remove_concurrent_index' -describe RuboCop::Cop::Migration::RemoveConcurrentIndex, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::RemoveConcurrentIndex, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/remove_index_spec.rb b/spec/rubocop/cop/migration/remove_index_spec.rb index 852ff5636657d39ba83caadb85237d475b1d6e6b..cc82306a0f59ef936aafaac6c8c728edb7137dcc 100644 --- a/spec/rubocop/cop/migration/remove_index_spec.rb +++ b/spec/rubocop/cop/migration/remove_index_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/remove_index' -describe RuboCop::Cop::Migration::RemoveIndex, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::RemoveIndex, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/safer_boolean_column_spec.rb b/spec/rubocop/cop/migration/safer_boolean_column_spec.rb index 8c78bbba49044bf83fea5b753a3543a30c23ba13..013f2edc5e9dfa258578c5a1d7877d20cc3a43af 100644 --- a/spec/rubocop/cop/migration/safer_boolean_column_spec.rb +++ b/spec/rubocop/cop/migration/safer_boolean_column_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/safer_boolean_column' -describe RuboCop::Cop::Migration::SaferBooleanColumn, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::SaferBooleanColumn, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/schedule_async_spec.rb b/spec/rubocop/cop/migration/schedule_async_spec.rb index 3453f1c51cc09b80a88aa1d8b6711a56751b8669..a7246dfa73a8ce81bee7218a72640fc019c842e8 100644 --- a/spec/rubocop/cop/migration/schedule_async_spec.rb +++ b/spec/rubocop/cop/migration/schedule_async_spec.rb @@ -7,7 +7,7 @@ require_relative '../../../../rubocop/cop/migration/schedule_async' -describe RuboCop::Cop::Migration::ScheduleAsync do +RSpec.describe RuboCop::Cop::Migration::ScheduleAsync do include CopHelper let(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/timestamps_spec.rb b/spec/rubocop/cop/migration/timestamps_spec.rb index 866e922686f069d0f309442d7714c11010747623..14b3cb36cf87de3d4c850d59e6021ccfc05130cd 100644 --- a/spec/rubocop/cop/migration/timestamps_spec.rb +++ b/spec/rubocop/cop/migration/timestamps_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/timestamps' -describe RuboCop::Cop::Migration::Timestamps, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::Timestamps, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/update_column_in_batches_spec.rb b/spec/rubocop/cop/migration/update_column_in_batches_spec.rb index f72efaf2eb2865ed99b4824b769bcc83e0679259..5d96e8048bf17baa9f20332715371133f00851fc 100644 --- a/spec/rubocop/cop/migration/update_column_in_batches_spec.rb +++ b/spec/rubocop/cop/migration/update_column_in_batches_spec.rb @@ -7,7 +7,7 @@ require_relative '../../../../rubocop/cop/migration/update_column_in_batches' -describe RuboCop::Cop::Migration::UpdateColumnInBatches do +RSpec.describe RuboCop::Cop::Migration::UpdateColumnInBatches do let(:cop) { described_class.new } let(:tmp_rails_root) { Rails.root.join('tmp', 'rails_root') } let(:migration_code) do diff --git a/spec/rubocop/cop/migration/with_lock_retries_disallowed_method_spec.rb b/spec/rubocop/cop/migration/with_lock_retries_disallowed_method_spec.rb index acb583475be36f89ed25d2271cc654f27ed9c8b9..11e4d78461740bce023c620331e191b897687419 100644 --- a/spec/rubocop/cop/migration/with_lock_retries_disallowed_method_spec.rb +++ b/spec/rubocop/cop/migration/with_lock_retries_disallowed_method_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/with_lock_retries_disallowed_method' -describe RuboCop::Cop::Migration::WithLockRetriesDisallowedMethod, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::WithLockRetriesDisallowedMethod, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/migration/with_lock_retries_with_change_spec.rb b/spec/rubocop/cop/migration/with_lock_retries_with_change_spec.rb index 38fe1f510c40db8d16c5b688963a0f9f86ca83e4..93b96f3a20e681976c57ee4209ad090b2d550853 100644 --- a/spec/rubocop/cop/migration/with_lock_retries_with_change_spec.rb +++ b/spec/rubocop/cop/migration/with_lock_retries_with_change_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/migration/with_lock_retries_with_change' -describe RuboCop::Cop::Migration::WithLockRetriesWithChange, type: :rubocop do +RSpec.describe RuboCop::Cop::Migration::WithLockRetriesWithChange, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/performance/ar_count_each_spec.rb b/spec/rubocop/cop/performance/ar_count_each_spec.rb index 2bcc6f4cfd65cea00eb4d1d4e74093fe39341855..33b667dd52fa7f24905c32cc95deb9953ead8977 100644 --- a/spec/rubocop/cop/performance/ar_count_each_spec.rb +++ b/spec/rubocop/cop/performance/ar_count_each_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/performance/ar_count_each.rb' -describe RuboCop::Cop::Performance::ARCountEach, type: :rubocop do +RSpec.describe RuboCop::Cop::Performance::ARCountEach, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/performance/ar_exists_and_present_blank_spec.rb b/spec/rubocop/cop/performance/ar_exists_and_present_blank_spec.rb index b0c260df733ad06229ccbac83cffecb022ec0077..972f3c5215323fd28cf03e14dfb0cceb2e1cb6f3 100644 --- a/spec/rubocop/cop/performance/ar_exists_and_present_blank_spec.rb +++ b/spec/rubocop/cop/performance/ar_exists_and_present_blank_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/performance/ar_exists_and_present_blank.rb' -describe RuboCop::Cop::Performance::ARExistsAndPresentBlank, type: :rubocop do +RSpec.describe RuboCop::Cop::Performance::ARExistsAndPresentBlank, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/performance/readlines_each_spec.rb b/spec/rubocop/cop/performance/readlines_each_spec.rb index aee098b80eb5deeea5e77ef565402bc71e22208b..2f222f1dc0049a6845baaf5cedc03b1ec852fddb 100644 --- a/spec/rubocop/cop/performance/readlines_each_spec.rb +++ b/spec/rubocop/cop/performance/readlines_each_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/performance/readlines_each' -describe RuboCop::Cop::Performance::ReadlinesEach, type: :rubocop do +RSpec.describe RuboCop::Cop::Performance::ReadlinesEach, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/prefer_class_methods_over_module_spec.rb b/spec/rubocop/cop/prefer_class_methods_over_module_spec.rb index d71d95ca6628e01d42ae12421ca42b9a0fd2ab47..bed8d331209150edae00a90a6d1f7107f01deb2d 100644 --- a/spec/rubocop/cop/prefer_class_methods_over_module_spec.rb +++ b/spec/rubocop/cop/prefer_class_methods_over_module_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../rubocop/cop/prefer_class_methods_over_module' -describe RuboCop::Cop::PreferClassMethodsOverModule, type: :rubocop do +RSpec.describe RuboCop::Cop::PreferClassMethodsOverModule, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/project_path_helper_spec.rb b/spec/rubocop/cop/project_path_helper_spec.rb index eab435218731d158f400572109f7dc9134713f42..0e5b0b10ae641f8fe3b230a7b4ca810b834adf39 100644 --- a/spec/rubocop/cop/project_path_helper_spec.rb +++ b/spec/rubocop/cop/project_path_helper_spec.rb @@ -7,7 +7,7 @@ require_relative '../../../rubocop/cop/project_path_helper' -describe RuboCop::Cop::ProjectPathHelper, type: :rubocop do +RSpec.describe RuboCop::Cop::ProjectPathHelper, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/put_group_routes_under_scope_spec.rb b/spec/rubocop/cop/put_group_routes_under_scope_spec.rb index f6213e5316504606afa09865bcf00d398dc32b58..2e577c9c5788fb95a7a60de9af8a8c9734c89ed4 100644 --- a/spec/rubocop/cop/put_group_routes_under_scope_spec.rb +++ b/spec/rubocop/cop/put_group_routes_under_scope_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../rubocop/cop/put_group_routes_under_scope' -describe RuboCop::Cop::PutGroupRoutesUnderScope, type: :rubocop do +RSpec.describe RuboCop::Cop::PutGroupRoutesUnderScope, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/put_project_routes_under_scope_spec.rb b/spec/rubocop/cop/put_project_routes_under_scope_spec.rb index 73f19bffec40839c1505a47a4a4aa9fa768c0796..66e9044c453448042e3b504f23ade822908fd3cf 100644 --- a/spec/rubocop/cop/put_project_routes_under_scope_spec.rb +++ b/spec/rubocop/cop/put_project_routes_under_scope_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../rubocop/cop/put_project_routes_under_scope' -describe RuboCop::Cop::PutProjectRoutesUnderScope, type: :rubocop do +RSpec.describe RuboCop::Cop::PutProjectRoutesUnderScope, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/qa/ambiguous_page_object_name_spec.rb b/spec/rubocop/cop/qa/ambiguous_page_object_name_spec.rb index e760ff66d5a07c8b4e09d068006a8795aded6417..484b5fad4735b7df9c5827f9bba1280280abd9e9 100644 --- a/spec/rubocop/cop/qa/ambiguous_page_object_name_spec.rb +++ b/spec/rubocop/cop/qa/ambiguous_page_object_name_spec.rb @@ -7,7 +7,7 @@ require_relative '../../../../rubocop/cop/qa/ambiguous_page_object_name' -describe RuboCop::Cop::QA::AmbiguousPageObjectName, type: :rubocop do +RSpec.describe RuboCop::Cop::QA::AmbiguousPageObjectName, type: :rubocop do include CopHelper let(:source_file) { 'qa/page.rb' } diff --git a/spec/rubocop/cop/qa/element_with_pattern_spec.rb b/spec/rubocop/cop/qa/element_with_pattern_spec.rb index 6d135cb9ea64b5aefe9b684a8fb5ade61b4aea82..0e59970153176c9fc87a28d5d39d106d80268851 100644 --- a/spec/rubocop/cop/qa/element_with_pattern_spec.rb +++ b/spec/rubocop/cop/qa/element_with_pattern_spec.rb @@ -7,7 +7,7 @@ require_relative '../../../../rubocop/cop/qa/element_with_pattern' -describe RuboCop::Cop::QA::ElementWithPattern, type: :rubocop do +RSpec.describe RuboCop::Cop::QA::ElementWithPattern, type: :rubocop do include CopHelper let(:source_file) { 'qa/page.rb' } diff --git a/spec/rubocop/cop/rspec/any_instance_of_spec.rb b/spec/rubocop/cop/rspec/any_instance_of_spec.rb index 7a4ba93502003153265f2dd13660bd2b2b782613..11c0f1098509842413bf3e9971835b7146ebc488 100644 --- a/spec/rubocop/cop/rspec/any_instance_of_spec.rb +++ b/spec/rubocop/cop/rspec/any_instance_of_spec.rb @@ -4,7 +4,7 @@ require_relative '../../../../rubocop/cop/rspec/any_instance_of' -describe RuboCop::Cop::RSpec::AnyInstanceOf, type: :rubocop do +RSpec.describe RuboCop::Cop::RSpec::AnyInstanceOf, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/rspec/be_success_matcher_spec.rb b/spec/rubocop/cop/rspec/be_success_matcher_spec.rb index f69766676c55f4f2e2814895e1ac6e5dbb01ce58..a16cd8b634fc070466674f752765d23655f9b5a0 100644 --- a/spec/rubocop/cop/rspec/be_success_matcher_spec.rb +++ b/spec/rubocop/cop/rspec/be_success_matcher_spec.rb @@ -4,7 +4,7 @@ require_relative '../../../../rubocop/cop/rspec/be_success_matcher' -describe RuboCop::Cop::RSpec::BeSuccessMatcher, type: :rubocop do +RSpec.describe RuboCop::Cop::RSpec::BeSuccessMatcher, type: :rubocop do include CopHelper let(:source_file) { 'spec/foo_spec.rb' } diff --git a/spec/rubocop/cop/rspec/env_assignment_spec.rb b/spec/rubocop/cop/rspec/env_assignment_spec.rb index 7b8f021a6229b7b5bf128932c10a06330d832631..72ad584dd6f93bc6029e5c84898f138bee25ac43 100644 --- a/spec/rubocop/cop/rspec/env_assignment_spec.rb +++ b/spec/rubocop/cop/rspec/env_assignment_spec.rb @@ -7,7 +7,7 @@ require_relative '../../../../rubocop/cop/rspec/env_assignment' -describe RuboCop::Cop::RSpec::EnvAssignment, type: :rubocop do +RSpec.describe RuboCop::Cop::RSpec::EnvAssignment, type: :rubocop do include CopHelper offense_call_single_quotes_key = %(ENV['FOO'] = 'bar').freeze diff --git a/spec/rubocop/cop/rspec/factories_in_migration_specs_spec.rb b/spec/rubocop/cop/rspec/factories_in_migration_specs_spec.rb index 10de8ee786587792c44bf52d9c7c447b8d3e6ffd..1bb93402a5bf35d1f52a5a166b5980cc4f5d2ad7 100644 --- a/spec/rubocop/cop/rspec/factories_in_migration_specs_spec.rb +++ b/spec/rubocop/cop/rspec/factories_in_migration_specs_spec.rb @@ -7,7 +7,7 @@ require_relative '../../../../rubocop/cop/rspec/factories_in_migration_specs' -describe RuboCop::Cop::RSpec::FactoriesInMigrationSpecs, type: :rubocop do +RSpec.describe RuboCop::Cop::RSpec::FactoriesInMigrationSpecs, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/rspec/have_gitlab_http_status_spec.rb b/spec/rubocop/cop/rspec/have_gitlab_http_status_spec.rb index 4aa45e66ca7e54678a9abfead492969c6ba66158..f6040350dc073608d1454bb6a4532892f0830646 100644 --- a/spec/rubocop/cop/rspec/have_gitlab_http_status_spec.rb +++ b/spec/rubocop/cop/rspec/have_gitlab_http_status_spec.rb @@ -8,7 +8,7 @@ require_relative '../../../../rubocop/cop/rspec/have_gitlab_http_status' -describe RuboCop::Cop::RSpec::HaveGitlabHttpStatus do +RSpec.describe RuboCop::Cop::RSpec::HaveGitlabHttpStatus do include CopHelper using RSpec::Parameterized::TableSyntax diff --git a/spec/rubocop/cop/rspec/modify_sidekiq_middleware_spec.rb b/spec/rubocop/cop/rspec/modify_sidekiq_middleware_spec.rb index 670c70889f2b23dbea6836dec74722e5400049e6..ca47bba42642a2959c5776adfecd8d7ade66ff48 100644 --- a/spec/rubocop/cop/rspec/modify_sidekiq_middleware_spec.rb +++ b/spec/rubocop/cop/rspec/modify_sidekiq_middleware_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/rspec/modify_sidekiq_middleware' -describe RuboCop::Cop::RSpec::ModifySidekiqMiddleware, type: :rubocop do +RSpec.describe RuboCop::Cop::RSpec::ModifySidekiqMiddleware, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/rspec/top_level_describe_path_spec.rb b/spec/rubocop/cop/rspec/top_level_describe_path_spec.rb index f03b75ecc73dddded903af95262dab498982da6d..92a76bde2431294ac6d5ef54061972def917604b 100644 --- a/spec/rubocop/cop/rspec/top_level_describe_path_spec.rb +++ b/spec/rubocop/cop/rspec/top_level_describe_path_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/rspec/top_level_describe_path' -describe RuboCop::Cop::RSpec::TopLevelDescribePath, type: :rubocop do +RSpec.describe RuboCop::Cop::RSpec::TopLevelDescribePath, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/ruby_interpolation_in_translation_spec.rb b/spec/rubocop/cop/ruby_interpolation_in_translation_spec.rb index 481f06c8c33ad91ef34558b04b6e522738663d4b..938ddc7fb6a2391f5656fec7161b8f305904c4cb 100644 --- a/spec/rubocop/cop/ruby_interpolation_in_translation_spec.rb +++ b/spec/rubocop/cop/ruby_interpolation_in_translation_spec.rb @@ -9,7 +9,7 @@ # Disabling interpolation check as we deliberately want to have #{} in strings. # rubocop:disable Lint/InterpolationCheck -describe RuboCop::Cop::RubyInterpolationInTranslation, type: :rubocop do +RSpec.describe RuboCop::Cop::RubyInterpolationInTranslation, type: :rubocop do subject(:cop) { described_class.new } it 'does not add an offence for a regular messages' do diff --git a/spec/rubocop/cop/safe_params_spec.rb b/spec/rubocop/cop/safe_params_spec.rb index 1f52898851f07a845cc0b39a443676c826ac6752..c4f683a41bff7d78874ff365dea1d4fb62500417 100644 --- a/spec/rubocop/cop/safe_params_spec.rb +++ b/spec/rubocop/cop/safe_params_spec.rb @@ -5,7 +5,7 @@ require 'rubocop/rspec/support' require_relative '../../../rubocop/cop/safe_params' -describe RuboCop::Cop::SafeParams, type: :rubocop do +RSpec.describe RuboCop::Cop::SafeParams, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/scalability/bulk_perform_with_context_spec.rb b/spec/rubocop/cop/scalability/bulk_perform_with_context_spec.rb index 5c333aea5cf7165075ab1c655f16d13acfd27d97..48964ab76e07952cef8fdefd61d9cff7a39c2f90 100644 --- a/spec/rubocop/cop/scalability/bulk_perform_with_context_spec.rb +++ b/spec/rubocop/cop/scalability/bulk_perform_with_context_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/scalability/bulk_perform_with_context' -describe RuboCop::Cop::Scalability::BulkPerformWithContext, type: :rubocop do +RSpec.describe RuboCop::Cop::Scalability::BulkPerformWithContext, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/scalability/cron_worker_context_spec.rb b/spec/rubocop/cop/scalability/cron_worker_context_spec.rb index 3add0a44ba48ad8e6ab76f987bae62dd1589975d..4b4ee7258f1f214cc9c7f096ee1eeeb2c1f1aecd 100644 --- a/spec/rubocop/cop/scalability/cron_worker_context_spec.rb +++ b/spec/rubocop/cop/scalability/cron_worker_context_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/scalability/cron_worker_context' -describe RuboCop::Cop::Scalability::CronWorkerContext, type: :rubocop do +RSpec.describe RuboCop::Cop::Scalability::CronWorkerContext, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/scalability/file_uploads_spec.rb b/spec/rubocop/cop/scalability/file_uploads_spec.rb index d3102b2a9615290b8e786d2283677139bdba76eb..ed826728681bff5abf24fcd7f7d096a99866db66 100644 --- a/spec/rubocop/cop/scalability/file_uploads_spec.rb +++ b/spec/rubocop/cop/scalability/file_uploads_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/scalability/file_uploads' -describe RuboCop::Cop::Scalability::FileUploads, type: :rubocop do +RSpec.describe RuboCop::Cop::Scalability::FileUploads, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/scalability/idempotent_worker_spec.rb b/spec/rubocop/cop/scalability/idempotent_worker_spec.rb index 97b1886310ae1e701fdb5de7265059b79a380ffc..9197cc954f5e43f780d331fd4426f6880307596f 100644 --- a/spec/rubocop/cop/scalability/idempotent_worker_spec.rb +++ b/spec/rubocop/cop/scalability/idempotent_worker_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../../../rubocop/cop/scalability/idempotent_worker' -describe RuboCop::Cop::Scalability::IdempotentWorker, type: :rubocop do +RSpec.describe RuboCop::Cop::Scalability::IdempotentWorker, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/sidekiq_options_queue_spec.rb b/spec/rubocop/cop/sidekiq_options_queue_spec.rb index 3dd247ae7966355fbcae1be9981fba0b24373aae..e76265d426c342c621e26a2e1898be970c74e304 100644 --- a/spec/rubocop/cop/sidekiq_options_queue_spec.rb +++ b/spec/rubocop/cop/sidekiq_options_queue_spec.rb @@ -7,7 +7,7 @@ require_relative '../../../rubocop/cop/sidekiq_options_queue' -describe RuboCop::Cop::SidekiqOptionsQueue, type: :rubocop do +RSpec.describe RuboCop::Cop::SidekiqOptionsQueue, type: :rubocop do include CopHelper subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/static_translation_definition_spec.rb b/spec/rubocop/cop/static_translation_definition_spec.rb index b85f9da9b4e5cf737fffef63754cf8fe665f6ac0..2bad10d5e3934851bf56e4ea995df098334da049 100644 --- a/spec/rubocop/cop/static_translation_definition_spec.rb +++ b/spec/rubocop/cop/static_translation_definition_spec.rb @@ -7,7 +7,7 @@ require_relative '../../../rubocop/cop/static_translation_definition' -describe RuboCop::Cop::StaticTranslationDefinition do +RSpec.describe RuboCop::Cop::StaticTranslationDefinition do include CopHelper using RSpec::Parameterized::TableSyntax diff --git a/spec/rubocop/migration_helpers_spec.rb b/spec/rubocop/migration_helpers_spec.rb index 73ced8c58daffab95b98a081d5de95d059c2511a..f0be21c9d708c0a91ef136ea0f12e5a2496bc58c 100644 --- a/spec/rubocop/migration_helpers_spec.rb +++ b/spec/rubocop/migration_helpers_spec.rb @@ -6,7 +6,7 @@ require_relative '../../rubocop/migration_helpers' -describe RuboCop::MigrationHelpers do +RSpec.describe RuboCop::MigrationHelpers do using RSpec::Parameterized::TableSyntax subject(:fake_cop) { Class.new { include RuboCop::MigrationHelpers }.new } diff --git a/spec/rubocop/qa_helpers_spec.rb b/spec/rubocop/qa_helpers_spec.rb index 26e4c1ca6f04180f7d1907cc7f6dcd472b4bc894..6961869ebb73e20466549b497ab8f1e7cf2ff41d 100644 --- a/spec/rubocop/qa_helpers_spec.rb +++ b/spec/rubocop/qa_helpers_spec.rb @@ -4,7 +4,7 @@ require 'rubocop' require_relative '../../rubocop/qa_helpers' -describe RuboCop::QAHelpers do +RSpec.describe RuboCop::QAHelpers do def parse_source(source, path = 'foo.rb') buffer = Parser::Source::Buffer.new(path) buffer.source = source diff --git a/spec/serializers/accessibility_error_entity_spec.rb b/spec/serializers/accessibility_error_entity_spec.rb index e9bfabb7aa8100bf098428e1fe9720d1352fe348..afbff15a19529993b530324b22c2616930e036f4 100644 --- a/spec/serializers/accessibility_error_entity_spec.rb +++ b/spec/serializers/accessibility_error_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AccessibilityErrorEntity do +RSpec.describe AccessibilityErrorEntity do let(:entity) { described_class.new(accessibility_error) } describe '#as_json' do diff --git a/spec/serializers/accessibility_reports_comparer_entity_spec.rb b/spec/serializers/accessibility_reports_comparer_entity_spec.rb index ed2c17de64062616a4c52d37cc4220f5bfed7fa2..3024974710efa593484e23895b3fb4d0d8a112b1 100644 --- a/spec/serializers/accessibility_reports_comparer_entity_spec.rb +++ b/spec/serializers/accessibility_reports_comparer_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AccessibilityReportsComparerEntity do +RSpec.describe AccessibilityReportsComparerEntity do let(:entity) { described_class.new(comparer) } let(:comparer) { Gitlab::Ci::Reports::AccessibilityReportsComparer.new(base_report, head_report) } let(:base_report) { Gitlab::Ci::Reports::AccessibilityReports.new } diff --git a/spec/serializers/accessibility_reports_comparer_serializer_spec.rb b/spec/serializers/accessibility_reports_comparer_serializer_spec.rb index 37dc760fdecb78dcbf401e0cee30a989d9e9bd0c..ef56f5b6b6b0d6413d00bef3607d30ed7d6d72cc 100644 --- a/spec/serializers/accessibility_reports_comparer_serializer_spec.rb +++ b/spec/serializers/accessibility_reports_comparer_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AccessibilityReportsComparerSerializer do +RSpec.describe AccessibilityReportsComparerSerializer do let(:project) { double(:project) } let(:serializer) { described_class.new(project: project).represent(comparer) } let(:comparer) { Gitlab::Ci::Reports::AccessibilityReportsComparer.new(base_report, head_report) } diff --git a/spec/serializers/analytics_build_entity_spec.rb b/spec/serializers/analytics_build_entity_spec.rb index dfa16075d206761701e190fb340f0d8d7c2c8c61..20bd017d1cfa0bbfefe14c723a73584b1d806871 100644 --- a/spec/serializers/analytics_build_entity_spec.rb +++ b/spec/serializers/analytics_build_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AnalyticsBuildEntity do +RSpec.describe AnalyticsBuildEntity do let(:entity) do described_class.new(build, request: double) end diff --git a/spec/serializers/analytics_build_serializer_spec.rb b/spec/serializers/analytics_build_serializer_spec.rb index 04a387fd353af2d45601dd221a97ef17bf7e732c..94a42ba4ffa2fa78ba39c092b277befcb8fba126 100644 --- a/spec/serializers/analytics_build_serializer_spec.rb +++ b/spec/serializers/analytics_build_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AnalyticsBuildSerializer do +RSpec.describe AnalyticsBuildSerializer do let(:resource) { create(:ci_build) } subject { described_class.new.represent(resource) } diff --git a/spec/serializers/analytics_issue_entity_spec.rb b/spec/serializers/analytics_issue_entity_spec.rb index 555efe136e62336d8750b7d74e80bb16e61ecfeb..2518eec8c23546a66a9ec76086bd14ca2b817d07 100644 --- a/spec/serializers/analytics_issue_entity_spec.rb +++ b/spec/serializers/analytics_issue_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AnalyticsIssueEntity do +RSpec.describe AnalyticsIssueEntity do let(:user) { create(:user) } let(:entity_hash) do { diff --git a/spec/serializers/analytics_issue_serializer_spec.rb b/spec/serializers/analytics_issue_serializer_spec.rb index 9b29739a8f231cc00f194661bc1115cdca12e517..5d268fe514bcda2aa9b5b9f56445af6f48c2ccc2 100644 --- a/spec/serializers/analytics_issue_serializer_spec.rb +++ b/spec/serializers/analytics_issue_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AnalyticsIssueSerializer do +RSpec.describe AnalyticsIssueSerializer do subject do described_class .new(entity: :merge_request) diff --git a/spec/serializers/analytics_merge_request_serializer_spec.rb b/spec/serializers/analytics_merge_request_serializer_spec.rb index c82eb28a28b2cf5520e463082c5f88753fc4e798..adf7321c7388c06a8c610850e5a02110d1b09c7b 100644 --- a/spec/serializers/analytics_merge_request_serializer_spec.rb +++ b/spec/serializers/analytics_merge_request_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AnalyticsMergeRequestSerializer do +RSpec.describe AnalyticsMergeRequestSerializer do subject do described_class .new(entity: :merge_request) diff --git a/spec/serializers/analytics_stage_serializer_spec.rb b/spec/serializers/analytics_stage_serializer_spec.rb index 1f1a0180b1fa5edaf72bf8608d69cb94bbf685c9..0f2de2621886ccdef349586c7fdf52d7c4c0eef5 100644 --- a/spec/serializers/analytics_stage_serializer_spec.rb +++ b/spec/serializers/analytics_stage_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AnalyticsStageSerializer do +RSpec.describe AnalyticsStageSerializer do subject do described_class.new.represent(resource) end diff --git a/spec/serializers/analytics_summary_serializer_spec.rb b/spec/serializers/analytics_summary_serializer_spec.rb index ed126720a553662b9749b19ac4665a586d4d0ca0..cd8be07827d38ef9e5ef5ea9c82291834fb06a57 100644 --- a/spec/serializers/analytics_summary_serializer_spec.rb +++ b/spec/serializers/analytics_summary_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AnalyticsSummarySerializer do +RSpec.describe AnalyticsSummarySerializer do subject do described_class.new.represent(resource) end diff --git a/spec/serializers/blob_entity_spec.rb b/spec/serializers/blob_entity_spec.rb index 3cd967ed44c20f0b52424d2ebbb48c2ba718dd7a..b8c8c4c17de82de1bc1e749be60804fef984526e 100644 --- a/spec/serializers/blob_entity_spec.rb +++ b/spec/serializers/blob_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe BlobEntity do +RSpec.describe BlobEntity do let(:user) { create(:user) } let(:project) { create(:project, :repository) } let(:blob) { project.commit('master').diffs.diff_files.first.blob } diff --git a/spec/serializers/board_serializer_spec.rb b/spec/serializers/board_serializer_spec.rb index 8a633e46316bc3c6da04b95ee3b55f91e5507b6c..9e6d5a93d532007ede9c215927308e253a8f4928 100644 --- a/spec/serializers/board_serializer_spec.rb +++ b/spec/serializers/board_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe BoardSerializer do +RSpec.describe BoardSerializer do let(:resource) { create(:board) } let(:json_entity) do described_class.new diff --git a/spec/serializers/build_action_entity_spec.rb b/spec/serializers/build_action_entity_spec.rb index 7cd1fdcda2221bc0932f470d9e0550421cd5ae38..75ae244db83a5476fa443c5671a5255912897a1a 100644 --- a/spec/serializers/build_action_entity_spec.rb +++ b/spec/serializers/build_action_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe BuildActionEntity do +RSpec.describe BuildActionEntity do let(:job) { create(:ci_build, name: 'test_job') } let(:request) { double('request') } let(:user) { create(:user) } diff --git a/spec/serializers/build_artifact_entity_spec.rb b/spec/serializers/build_artifact_entity_spec.rb index afa2aa3d2548c7c86b2da54330da7bdafe049595..02c172d723f410a3c2e30de97eda8eedd84af722 100644 --- a/spec/serializers/build_artifact_entity_spec.rb +++ b/spec/serializers/build_artifact_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe BuildArtifactEntity do +RSpec.describe BuildArtifactEntity do let(:job) { create(:ci_build) } let(:artifact) { create(:ci_job_artifact, :codequality, expire_at: 1.hour.from_now, job: job) } diff --git a/spec/serializers/build_details_entity_spec.rb b/spec/serializers/build_details_entity_spec.rb index 92917f6ea2517fdd2792e0d0060f28b281480de9..ef6472e07a0289fe954973d8a36ae81f8f51fe5b 100644 --- a/spec/serializers/build_details_entity_spec.rb +++ b/spec/serializers/build_details_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe BuildDetailsEntity do +RSpec.describe BuildDetailsEntity do include ProjectForksHelper let_it_be(:user) { create(:admin) } diff --git a/spec/serializers/build_serializer_spec.rb b/spec/serializers/build_serializer_spec.rb index c7bb68643619144feac1a3a025850e33ee76ef4c..f3584beb39b19d5eadf72a2f7f75a6d50d9475f4 100644 --- a/spec/serializers/build_serializer_spec.rb +++ b/spec/serializers/build_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe BuildSerializer do +RSpec.describe BuildSerializer do let(:user) { create(:user) } let(:serializer) do diff --git a/spec/serializers/build_trace_entity_spec.rb b/spec/serializers/build_trace_entity_spec.rb index bafead04a5121472d2052b91714bb19f18a0409c..3d967c62f99520ba68e0173237c16b5d8cbff607 100644 --- a/spec/serializers/build_trace_entity_spec.rb +++ b/spec/serializers/build_trace_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe BuildTraceEntity do +RSpec.describe BuildTraceEntity do let(:build) { build_stubbed(:ci_build) } let(:request) { double('request') } diff --git a/spec/serializers/ci/dag_job_entity_spec.rb b/spec/serializers/ci/dag_job_entity_spec.rb index eaaf39d6bfc37fd14a1f370fff73e09b07bccf06..fbfd1d1c77a098bed558d67b10bc44ad354a88cb 100644 --- a/spec/serializers/ci/dag_job_entity_spec.rb +++ b/spec/serializers/ci/dag_job_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::DagJobEntity do +RSpec.describe Ci::DagJobEntity do let_it_be(:request) { double(:request) } let(:job) { create(:ci_build, name: 'dag_job') } diff --git a/spec/serializers/ci/dag_job_group_entity_spec.rb b/spec/serializers/ci/dag_job_group_entity_spec.rb index a25723894fdf8ce9890f7d86fc95d7e077e96641..5a761919e22d589dc0f2de82756b8fcee9c9783a 100644 --- a/spec/serializers/ci/dag_job_group_entity_spec.rb +++ b/spec/serializers/ci/dag_job_group_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::DagJobGroupEntity do +RSpec.describe Ci::DagJobGroupEntity do let_it_be(:request) { double(:request) } let_it_be(:pipeline) { create(:ci_pipeline) } let_it_be(:stage) { create(:ci_stage, pipeline: pipeline) } diff --git a/spec/serializers/ci/dag_pipeline_entity_spec.rb b/spec/serializers/ci/dag_pipeline_entity_spec.rb index fab8798effca0243fe0656c0f3a6f737fdd25440..9878826a3f3638b1d77bf83942b0395690fa759f 100644 --- a/spec/serializers/ci/dag_pipeline_entity_spec.rb +++ b/spec/serializers/ci/dag_pipeline_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::DagPipelineEntity do +RSpec.describe Ci::DagPipelineEntity do let_it_be(:request) { double(:request) } let(:pipeline) { create(:ci_pipeline) } diff --git a/spec/serializers/ci/dag_pipeline_serializer_spec.rb b/spec/serializers/ci/dag_pipeline_serializer_spec.rb index abf895c3e77781dd12139d123b5e4f2f3032ff12..35fa10ecf475aef0361995f6830e466cf593d7bb 100644 --- a/spec/serializers/ci/dag_pipeline_serializer_spec.rb +++ b/spec/serializers/ci/dag_pipeline_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::DagPipelineSerializer do +RSpec.describe Ci::DagPipelineSerializer do describe '#represent' do subject { described_class.new.represent(pipeline) } diff --git a/spec/serializers/ci/dag_stage_entity_spec.rb b/spec/serializers/ci/dag_stage_entity_spec.rb index 5c6aa7faee4edb98e84b61358a3f22e4bc8b11b4..ccc922d62e304b101c23b40b9699adcae0e6feac 100644 --- a/spec/serializers/ci/dag_stage_entity_spec.rb +++ b/spec/serializers/ci/dag_stage_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::DagStageEntity do +RSpec.describe Ci::DagStageEntity do let_it_be(:pipeline) { create(:ci_pipeline) } let_it_be(:request) { double(:request) } diff --git a/spec/serializers/cluster_application_entity_spec.rb b/spec/serializers/cluster_application_entity_spec.rb index b81bdaa0d729adf7be7baa49e16544f75face582..aa2bb25b17c852f96f3f37937175a1af9c5065e1 100644 --- a/spec/serializers/cluster_application_entity_spec.rb +++ b/spec/serializers/cluster_application_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ClusterApplicationEntity do +RSpec.describe ClusterApplicationEntity do describe '#as_json' do let(:application) { build(:clusters_applications_helm, version: '0.1.1') } diff --git a/spec/serializers/cluster_entity_spec.rb b/spec/serializers/cluster_entity_spec.rb index 16247eef655ef5536ed5892bd7a2ba7bd06a3c04..6c692dbdbfc90007ca0d498129c5f7b764f7c367 100644 --- a/spec/serializers/cluster_entity_spec.rb +++ b/spec/serializers/cluster_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ClusterEntity do +RSpec.describe ClusterEntity do describe '#as_json' do subject { described_class.new(cluster).as_json } diff --git a/spec/serializers/cluster_serializer_spec.rb b/spec/serializers/cluster_serializer_spec.rb index b7d7307d40b3f26f0cf92a52b2692295709e5378..8034edbe5994a40d3936c59ac13d49ddc5e6cc32 100644 --- a/spec/serializers/cluster_serializer_spec.rb +++ b/spec/serializers/cluster_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ClusterSerializer do +RSpec.describe ClusterSerializer do let(:cluster) { create(:cluster, :project, provider_type: :user) } describe '#represent_list' do diff --git a/spec/serializers/commit_entity_spec.rb b/spec/serializers/commit_entity_spec.rb index 6abe8504b937197ae8934bba19d0b264a704eb3b..e2ea63893a45985e4d996b65696c9a13b268bec9 100644 --- a/spec/serializers/commit_entity_spec.rb +++ b/spec/serializers/commit_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe CommitEntity do +RSpec.describe CommitEntity do let(:signature_html) { 'TEST' } let(:entity) do diff --git a/spec/serializers/container_repositories_serializer_spec.rb b/spec/serializers/container_repositories_serializer_spec.rb index 382778389b33c170c79dd72602059376fe602522..a0d08a8ba445affb69d1e09587c5b7745e5d9e74 100644 --- a/spec/serializers/container_repositories_serializer_spec.rb +++ b/spec/serializers/container_repositories_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ContainerRepositoriesSerializer do +RSpec.describe ContainerRepositoriesSerializer do let(:user) { create(:user) } let(:project) { create(:project) } let(:resource) { create(:container_repository, name: 'image', project: project) } diff --git a/spec/serializers/container_repository_entity_spec.rb b/spec/serializers/container_repository_entity_spec.rb index 1f85c6e6a46b029e1015d796196232a244e56cde..43969c63471c125fdb2e6309af0b200b6acdf581 100644 --- a/spec/serializers/container_repository_entity_spec.rb +++ b/spec/serializers/container_repository_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ContainerRepositoryEntity do +RSpec.describe ContainerRepositoryEntity do let_it_be(:project) { create(:project) } let_it_be(:user) { create(:user) } let_it_be(:repository) { create(:container_repository, project: project) } diff --git a/spec/serializers/container_tag_entity_spec.rb b/spec/serializers/container_tag_entity_spec.rb index 8440e56f08fffa13b6f43af405621a30671c66c0..8e47a6269bcbacf76ae1ed2a3b49c54cd06140f5 100644 --- a/spec/serializers/container_tag_entity_spec.rb +++ b/spec/serializers/container_tag_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ContainerTagEntity do +RSpec.describe ContainerTagEntity do let_it_be(:project) { create(:project) } let_it_be(:user) { create(:user) } let_it_be(:repository) { create(:container_repository, name: 'image', project: project) } diff --git a/spec/serializers/deploy_key_entity_spec.rb b/spec/serializers/deploy_key_entity_spec.rb index 0dbbf0de59bdfbb254e030d225266a9c6106e3b0..3354db5cf8de02ac13819ccb24ebe644f451aac0 100644 --- a/spec/serializers/deploy_key_entity_spec.rb +++ b/spec/serializers/deploy_key_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DeployKeyEntity do +RSpec.describe DeployKeyEntity do include RequestAwareEntity let(:user) { create(:user) } diff --git a/spec/serializers/deployment_cluster_entity_spec.rb b/spec/serializers/deployment_cluster_entity_spec.rb index b22a93fcec70c4778dc174585f573fb6f052e301..95f2f8ce6fcd042a0fad090150bee222bec4568f 100644 --- a/spec/serializers/deployment_cluster_entity_spec.rb +++ b/spec/serializers/deployment_cluster_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DeploymentClusterEntity do +RSpec.describe DeploymentClusterEntity do describe '#as_json' do subject { described_class.new(deployment, request: request).as_json } diff --git a/spec/serializers/deployment_entity_spec.rb b/spec/serializers/deployment_entity_spec.rb index 7abe74fae8f9a6a600ffdec3effc0b83706473a7..27673b905d35ed32712b938e0a8b5c773bdd46ac 100644 --- a/spec/serializers/deployment_entity_spec.rb +++ b/spec/serializers/deployment_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DeploymentEntity do +RSpec.describe DeploymentEntity do let(:user) { developer } let(:developer) { create(:user) } let(:reporter) { create(:user) } diff --git a/spec/serializers/deployment_serializer_spec.rb b/spec/serializers/deployment_serializer_spec.rb index 67fccaa3f25142355e3906585f6bec72da052633..cfd43227b18b8eb8c3fe3b1cc42abe701e6a7fbe 100644 --- a/spec/serializers/deployment_serializer_spec.rb +++ b/spec/serializers/deployment_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DeploymentSerializer do +RSpec.describe DeploymentSerializer do let_it_be(:project) { create(:project, :repository) } let_it_be(:user) { create(:user, email: project.commit.author_email) } let(:resource) { create(:deployment, project: project, sha: project.commit.id) } diff --git a/spec/serializers/detailed_status_entity_spec.rb b/spec/serializers/detailed_status_entity_spec.rb index a4b51f1e02e63860ec603c8ae4a96ad4875ec475..33ecb4572a8c42bf66eb1c95dd9c5394c4707a68 100644 --- a/spec/serializers/detailed_status_entity_spec.rb +++ b/spec/serializers/detailed_status_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DetailedStatusEntity do +RSpec.describe DetailedStatusEntity do let(:entity) { described_class.new(status) } let(:status) do diff --git a/spec/serializers/diff_file_base_entity_spec.rb b/spec/serializers/diff_file_base_entity_spec.rb index 1fd697970ded30446331831c2068d1e3ced47512..2624465bcac15a6cead773633385caef5e3a0659 100644 --- a/spec/serializers/diff_file_base_entity_spec.rb +++ b/spec/serializers/diff_file_base_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DiffFileBaseEntity do +RSpec.describe DiffFileBaseEntity do let(:project) { create(:project, :repository) } let(:repository) { project.repository } let(:entity) { described_class.new(diff_file, options).as_json } diff --git a/spec/serializers/diff_file_entity_spec.rb b/spec/serializers/diff_file_entity_spec.rb index e3ecd72b275a4aca14328293630c53554785e570..bebe2e2dfb59831d0b280179ee45df555fbe3aa8 100644 --- a/spec/serializers/diff_file_entity_spec.rb +++ b/spec/serializers/diff_file_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DiffFileEntity do +RSpec.describe DiffFileEntity do include RepoHelpers let_it_be(:project) { create(:project, :repository) } diff --git a/spec/serializers/diff_line_entity_spec.rb b/spec/serializers/diff_line_entity_spec.rb index 2549f64bcd3bd3a8b88d6dd337ed492cc019fc5a..862b06c800acde7d6c78773ccb0ba08c61ce922f 100644 --- a/spec/serializers/diff_line_entity_spec.rb +++ b/spec/serializers/diff_line_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DiffLineEntity do +RSpec.describe DiffLineEntity do include RepoHelpers let(:code) { 'hello world' } diff --git a/spec/serializers/diff_line_serializer_spec.rb b/spec/serializers/diff_line_serializer_spec.rb index bdfcb8e245950e6b05bac6c38b871cce0989b900..b91f15211dee89508ca3fa034e50721284e3a66e 100644 --- a/spec/serializers/diff_line_serializer_spec.rb +++ b/spec/serializers/diff_line_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DiffLineSerializer do +RSpec.describe DiffLineSerializer do let(:line) { Gitlab::Diff::Line.new('hello world', 'new', 1, nil, 1) } let(:serializer) { described_class.new.represent(line) } diff --git a/spec/serializers/diff_viewer_entity_spec.rb b/spec/serializers/diff_viewer_entity_spec.rb index 76d2728c597e1f7e91da804d49f51d4691733c92..53601fcff6171b33890084c26cbff67acab89fc3 100644 --- a/spec/serializers/diff_viewer_entity_spec.rb +++ b/spec/serializers/diff_viewer_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DiffViewerEntity do +RSpec.describe DiffViewerEntity do include RepoHelpers let(:project) { create(:project, :repository) } diff --git a/spec/serializers/diffs_entity_spec.rb b/spec/serializers/diffs_entity_spec.rb index 435d8a6aff288e0ec6c9a88255300e2665ca28ca..7c59e4aed83783df0a599a9bac2f7077636b1321 100644 --- a/spec/serializers/diffs_entity_spec.rb +++ b/spec/serializers/diffs_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DiffsEntity do +RSpec.describe DiffsEntity do let(:user) { create(:user) } let(:project) { create(:project, :repository) } let(:request) { EntityRequest.new(project: project, current_user: user) } diff --git a/spec/serializers/diffs_metadata_entity_spec.rb b/spec/serializers/diffs_metadata_entity_spec.rb index 3ed2b7c945293465cec7a870d1e4256262513c84..8ed47569b75b9da9fc983418a44f0a53a586ab8f 100644 --- a/spec/serializers/diffs_metadata_entity_spec.rb +++ b/spec/serializers/diffs_metadata_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DiffsMetadataEntity do +RSpec.describe DiffsMetadataEntity do let(:user) { create(:user) } let(:project) { create(:project, :repository) } let(:request) { EntityRequest.new(project: project, current_user: user) } diff --git a/spec/serializers/discussion_diff_file_entity_spec.rb b/spec/serializers/discussion_diff_file_entity_spec.rb index 101ac918a982428b26083176ac63497123ce49ad..05438450d783313d8a694d162d1d58b75ade37f2 100644 --- a/spec/serializers/discussion_diff_file_entity_spec.rb +++ b/spec/serializers/discussion_diff_file_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DiscussionDiffFileEntity do +RSpec.describe DiscussionDiffFileEntity do include RepoHelpers let(:project) { create(:project, :repository) } diff --git a/spec/serializers/discussion_entity_spec.rb b/spec/serializers/discussion_entity_spec.rb index b441fd08b98a594773c3e62061bbef4d7640157e..306a4fa43a9f2ed857e0534fd4fb90c2f1ab914d 100644 --- a/spec/serializers/discussion_entity_spec.rb +++ b/spec/serializers/discussion_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DiscussionEntity do +RSpec.describe DiscussionEntity do include RepoHelpers let(:user) { create(:user) } diff --git a/spec/serializers/entity_date_helper_spec.rb b/spec/serializers/entity_date_helper_spec.rb index 6f99074c3a22589aa779bb1f7a9755d651bb4275..a8c338675e2245bea0e3cdef5e3353c7e8b8c427 100644 --- a/spec/serializers/entity_date_helper_spec.rb +++ b/spec/serializers/entity_date_helper_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe EntityDateHelper do +RSpec.describe EntityDateHelper do let(:date_helper_class) { Class.new { include EntityDateHelper }.new } it 'converts 0 seconds' do diff --git a/spec/serializers/entity_request_spec.rb b/spec/serializers/entity_request_spec.rb index 947c4b165d3e888498f9b2e3ad0dea762fee648f..43a53b57c971d11117eae17cfcb7e2a818bf7c10 100644 --- a/spec/serializers/entity_request_spec.rb +++ b/spec/serializers/entity_request_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe EntityRequest do +RSpec.describe EntityRequest do subject do described_class.new(user: 'user', project: 'some project') end diff --git a/spec/serializers/environment_entity_spec.rb b/spec/serializers/environment_entity_spec.rb index 36e971c467a52ff47891e758f642bf07d61573df..6232a0d2973e3fda2016ff99c29634f270899a07 100644 --- a/spec/serializers/environment_entity_spec.rb +++ b/spec/serializers/environment_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe EnvironmentEntity do +RSpec.describe EnvironmentEntity do include Gitlab::Routing.url_helpers let(:request) { double('request') } diff --git a/spec/serializers/environment_serializer_spec.rb b/spec/serializers/environment_serializer_spec.rb index 304457d83a10df1bae9a77d356b5825932ff700b..1e3980b7720fba314aa0c828d8746288ab59cfc6 100644 --- a/spec/serializers/environment_serializer_spec.rb +++ b/spec/serializers/environment_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe EnvironmentSerializer do +RSpec.describe EnvironmentSerializer do let(:user) { create(:user) } let(:project) { create(:project) } diff --git a/spec/serializers/environment_status_entity_spec.rb b/spec/serializers/environment_status_entity_spec.rb index 11455c57677db0cbe3804572c66db8b6bff9e9f3..a940c4b465e970eaee841a64f59b7bc941f39cf3 100644 --- a/spec/serializers/environment_status_entity_spec.rb +++ b/spec/serializers/environment_status_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe EnvironmentStatusEntity do +RSpec.describe EnvironmentStatusEntity do let(:user) { create(:user) } let(:request) { double('request', project: project) } diff --git a/spec/serializers/evidences/evidence_entity_spec.rb b/spec/serializers/evidences/evidence_entity_spec.rb index fa13bd21eddf3c0ec11caf3f364f31071ba41c8f..8ec0422fea2d7052a2995ca5abf1f46d9165fd6d 100644 --- a/spec/serializers/evidences/evidence_entity_spec.rb +++ b/spec/serializers/evidences/evidence_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Evidences::EvidenceEntity do +RSpec.describe Evidences::EvidenceEntity do let_it_be(:project) { create(:project) } let(:release) { create(:release, project: project) } let(:evidence) { build(:evidence, release: release) } diff --git a/spec/serializers/evidences/evidence_serializer_spec.rb b/spec/serializers/evidences/evidence_serializer_spec.rb index 5322f6a43fcb7068f484deeb1438d889cfbeb983..73d0700b7cf79a63b2129dbd0d17949ca481636a 100644 --- a/spec/serializers/evidences/evidence_serializer_spec.rb +++ b/spec/serializers/evidences/evidence_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Evidences::EvidenceSerializer do +RSpec.describe Evidences::EvidenceSerializer do it 'represents an EvidenceEntity entity' do expect(described_class.entity_class).to eq(Evidences::EvidenceEntity) end diff --git a/spec/serializers/evidences/issue_entity_spec.rb b/spec/serializers/evidences/issue_entity_spec.rb index 915df9868878a88f7d5100fa027a649468082d5e..71392d0abd9b1020f169c6c68390ba30eb4f2110 100644 --- a/spec/serializers/evidences/issue_entity_spec.rb +++ b/spec/serializers/evidences/issue_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Evidences::IssueEntity do +RSpec.describe Evidences::IssueEntity do let(:entity) { described_class.new(build(:issue)) } subject { entity.as_json } diff --git a/spec/serializers/evidences/milestone_entity_spec.rb b/spec/serializers/evidences/milestone_entity_spec.rb index 68eb12093daa1e1dde2a32e7d367f29dd510ee85..337ce96676359cfa464c612a920735965b9eb3d3 100644 --- a/spec/serializers/evidences/milestone_entity_spec.rb +++ b/spec/serializers/evidences/milestone_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Evidences::MilestoneEntity do +RSpec.describe Evidences::MilestoneEntity do let(:milestone) { build(:milestone) } let(:entity) { described_class.new(milestone) } diff --git a/spec/serializers/evidences/project_entity_spec.rb b/spec/serializers/evidences/project_entity_spec.rb index 01c160425a80ddc7183506323989bf163db5e7d0..d5cb1a53a7e118b7fbee7c907b55675935a3bb86 100644 --- a/spec/serializers/evidences/project_entity_spec.rb +++ b/spec/serializers/evidences/project_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Evidences::ProjectEntity do +RSpec.describe Evidences::ProjectEntity do let(:entity) { described_class.new(build(:project)) } subject { entity.as_json } diff --git a/spec/serializers/evidences/release_entity_spec.rb b/spec/serializers/evidences/release_entity_spec.rb index 8e2be7481695bf560bf8fc1f144859dc20736aae..63e25efc65f799ef0032802c20a36e27f7d593a6 100644 --- a/spec/serializers/evidences/release_entity_spec.rb +++ b/spec/serializers/evidences/release_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Evidences::ReleaseEntity do +RSpec.describe Evidences::ReleaseEntity do let(:release) { build(:release) } let(:entity) { described_class.new(release) } diff --git a/spec/serializers/evidences/release_serializer_spec.rb b/spec/serializers/evidences/release_serializer_spec.rb index a0dbf50137c0798ac7618097f75387e4d87828e5..c93e0cd7c19aefe87af0960d992131bc21132f13 100644 --- a/spec/serializers/evidences/release_serializer_spec.rb +++ b/spec/serializers/evidences/release_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Evidences::ReleaseSerializer do +RSpec.describe Evidences::ReleaseSerializer do it 'represents an Evidence::ReleaseEntity entity' do expect(described_class.entity_class).to eq(Evidences::ReleaseEntity) end diff --git a/spec/serializers/group_child_entity_spec.rb b/spec/serializers/group_child_entity_spec.rb index cae263e7fd5a2ee17c2b9a4c371c36c7647ab77a..7f330da44a76fb5b965174a1932dc500e462a79d 100644 --- a/spec/serializers/group_child_entity_spec.rb +++ b/spec/serializers/group_child_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe GroupChildEntity do +RSpec.describe GroupChildEntity do include ExternalAuthorizationServiceHelpers include Gitlab::Routing.url_helpers diff --git a/spec/serializers/group_child_serializer_spec.rb b/spec/serializers/group_child_serializer_spec.rb index 92f083ed23eaa4de14ba8289daef84dab7e0849a..63582019d32bc2690840daec9a3da7be5216c20f 100644 --- a/spec/serializers/group_child_serializer_spec.rb +++ b/spec/serializers/group_child_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe GroupChildSerializer do +RSpec.describe GroupChildSerializer do let(:request) { double('request') } let(:user) { create(:user) } diff --git a/spec/serializers/group_variable_entity_spec.rb b/spec/serializers/group_variable_entity_spec.rb index e6b51e0d626db8e918f95d7eed3da1a78bcbf241..17efe2d20227fdc7fb8c399c5ed5ff31bc5666aa 100644 --- a/spec/serializers/group_variable_entity_spec.rb +++ b/spec/serializers/group_variable_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe GroupVariableEntity do +RSpec.describe GroupVariableEntity do let(:variable) { create(:ci_group_variable) } let(:entity) { described_class.new(variable) } diff --git a/spec/serializers/issuable_sidebar_extras_entity_spec.rb b/spec/serializers/issuable_sidebar_extras_entity_spec.rb index a1a7c554b4934abe7e5370801b9619ebc1421a35..f49b9acfd5d1009d7394b9bf694115dd13a2145d 100644 --- a/spec/serializers/issuable_sidebar_extras_entity_spec.rb +++ b/spec/serializers/issuable_sidebar_extras_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe IssuableSidebarExtrasEntity do +RSpec.describe IssuableSidebarExtrasEntity do let(:user) { create(:user) } let(:project) { create(:project, :repository) } let(:resource) { create(:issue, project: project) } diff --git a/spec/serializers/issue_board_entity_spec.rb b/spec/serializers/issue_board_entity_spec.rb index d013b27369b82411e6ad4a50315dc418f70783a4..e60a063b9ebb5d1edd664ed352336d5c2687160d 100644 --- a/spec/serializers/issue_board_entity_spec.rb +++ b/spec/serializers/issue_board_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe IssueBoardEntity do +RSpec.describe IssueBoardEntity do let_it_be(:project) { create(:project) } let_it_be(:resource) { create(:issue, project: project) } let_it_be(:user) { create(:user) } diff --git a/spec/serializers/issue_entity_spec.rb b/spec/serializers/issue_entity_spec.rb index a1868b2631b4e20764950730ed6482cc48c84d3a..5c5ac184778f19e121d1738b025980d61d016217 100644 --- a/spec/serializers/issue_entity_spec.rb +++ b/spec/serializers/issue_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe IssueEntity do +RSpec.describe IssueEntity do let(:project) { create(:project) } let(:resource) { create(:issue, project: project) } let(:user) { create(:user) } diff --git a/spec/serializers/issue_serializer_spec.rb b/spec/serializers/issue_serializer_spec.rb index e25becc4709e960a6f7215c3a4d4bf70469a6b52..a51297d6d80ac14e5432f2eeef4d8e712bac98c8 100644 --- a/spec/serializers/issue_serializer_spec.rb +++ b/spec/serializers/issue_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe IssueSerializer do +RSpec.describe IssueSerializer do let(:resource) { create(:issue) } let(:user) { create(:user) } let(:json_entity) do diff --git a/spec/serializers/job_artifact_report_entity_spec.rb b/spec/serializers/job_artifact_report_entity_spec.rb index 3cd12f0e9fe9f69b2955ebe3c4aad46265f6bfaa..1aaaad544ba92c38296e94fec9a4f82edf425f68 100644 --- a/spec/serializers/job_artifact_report_entity_spec.rb +++ b/spec/serializers/job_artifact_report_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe JobArtifactReportEntity do +RSpec.describe JobArtifactReportEntity do let(:report) { create(:ci_job_artifact, :codequality) } let(:entity) { described_class.new(report, request: double) } diff --git a/spec/serializers/job_entity_spec.rb b/spec/serializers/job_entity_spec.rb index 60843f1a5992d54d0cf7cb7de38f599a3f73d25d..02262be951145378d6d96c9a73d00ac39165896e 100644 --- a/spec/serializers/job_entity_spec.rb +++ b/spec/serializers/job_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe JobEntity do +RSpec.describe JobEntity do let(:user) { create(:user) } let(:job) { create(:ci_build) } let(:project) { job.project } diff --git a/spec/serializers/label_serializer_spec.rb b/spec/serializers/label_serializer_spec.rb index 7e1bb2cc12720a164c835c0328797211b36e567d..ae1466b16e5d303e0a4b84d2a1af2c1022262d23 100644 --- a/spec/serializers/label_serializer_spec.rb +++ b/spec/serializers/label_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe LabelSerializer do +RSpec.describe LabelSerializer do let(:user) { create(:user) } let(:serializer) do diff --git a/spec/serializers/lfs_file_lock_entity_spec.rb b/spec/serializers/lfs_file_lock_entity_spec.rb index 4ffffad7d5aaa35597fbf85585dab3c001f38ac5..5869941c9201f1f38ce9d45cbecfdec9cdc52ecb 100644 --- a/spec/serializers/lfs_file_lock_entity_spec.rb +++ b/spec/serializers/lfs_file_lock_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe LfsFileLockEntity do +RSpec.describe LfsFileLockEntity do let(:user) { create(:user) } let(:resource) { create(:lfs_file_lock, user: user) } diff --git a/spec/serializers/merge_request_basic_entity_spec.rb b/spec/serializers/merge_request_basic_entity_spec.rb index 53ba66a79ac237a1fd67796e5e5a8f48c0d540b5..1cddd87e91732c3c4b38d463bc480c79306880ea 100644 --- a/spec/serializers/merge_request_basic_entity_spec.rb +++ b/spec/serializers/merge_request_basic_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MergeRequestBasicEntity do +RSpec.describe MergeRequestBasicEntity do let(:resource) { build(:merge_request) } subject do diff --git a/spec/serializers/merge_request_diff_entity_spec.rb b/spec/serializers/merge_request_diff_entity_spec.rb index 2e3b0d092fedfdb97b5196a50b49f11e6c5a18bf..542ef6cb3c3fb68c08f578264613bdb0140773d7 100644 --- a/spec/serializers/merge_request_diff_entity_spec.rb +++ b/spec/serializers/merge_request_diff_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MergeRequestDiffEntity do +RSpec.describe MergeRequestDiffEntity do let_it_be(:project) { create(:project, :repository) } let(:request) { EntityRequest.new(project: project) } let(:merge_request) { create(:merge_request_with_diffs, target_project: project, source_project: project) } diff --git a/spec/serializers/merge_request_for_pipeline_entity_spec.rb b/spec/serializers/merge_request_for_pipeline_entity_spec.rb index b39fbce8c3a36cc59d1e6feef67865a9d718f8dc..ed66716974a7dc6a4cf26f5720705497abe6a3fc 100644 --- a/spec/serializers/merge_request_for_pipeline_entity_spec.rb +++ b/spec/serializers/merge_request_for_pipeline_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MergeRequestForPipelineEntity do +RSpec.describe MergeRequestForPipelineEntity do let(:project) { create(:project, :repository) } let(:user) { create(:user) } let(:request) { EntityRequest.new(project: project) } diff --git a/spec/serializers/merge_request_poll_cached_widget_entity_spec.rb b/spec/serializers/merge_request_poll_cached_widget_entity_spec.rb index 9f96e5711a4e0e4099b5fe48bf6e07827a615d1b..1357f7cf624276808957194cc1b65110d4519b68 100644 --- a/spec/serializers/merge_request_poll_cached_widget_entity_spec.rb +++ b/spec/serializers/merge_request_poll_cached_widget_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MergeRequestPollCachedWidgetEntity do +RSpec.describe MergeRequestPollCachedWidgetEntity do include ProjectForksHelper let(:project) { create :project, :repository } diff --git a/spec/serializers/merge_request_poll_widget_entity_spec.rb b/spec/serializers/merge_request_poll_widget_entity_spec.rb index 4b3bfc99c88ca085867d64948c41c6826432f85c..2b6159e883d46280a1839419b7c10e94b47c3380 100644 --- a/spec/serializers/merge_request_poll_widget_entity_spec.rb +++ b/spec/serializers/merge_request_poll_widget_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MergeRequestPollWidgetEntity do +RSpec.describe MergeRequestPollWidgetEntity do include ProjectForksHelper let(:project) { create :project, :repository } diff --git a/spec/serializers/merge_request_serializer_spec.rb b/spec/serializers/merge_request_serializer_spec.rb index 90b3efae41290014c0874fbbf21b0e3bbfd76091..a2ce1ed4ac255060efb4cdb01b7f1198696bff1f 100644 --- a/spec/serializers/merge_request_serializer_spec.rb +++ b/spec/serializers/merge_request_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MergeRequestSerializer do +RSpec.describe MergeRequestSerializer do let_it_be(:user) { create(:user) } let_it_be(:resource) { create(:merge_request, description: "Description") } diff --git a/spec/serializers/merge_request_sidebar_basic_entity_spec.rb b/spec/serializers/merge_request_sidebar_basic_entity_spec.rb index b2db57801eadeef57397af6997b6dff5e53c9c6c..e950e6d6592a77352a45453169f2ce93d1a8d316 100644 --- a/spec/serializers/merge_request_sidebar_basic_entity_spec.rb +++ b/spec/serializers/merge_request_sidebar_basic_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MergeRequestSidebarBasicEntity do +RSpec.describe MergeRequestSidebarBasicEntity do let(:project) { create :project, :repository } let(:merge_request) { create(:merge_request, source_project: project, target_project: project) } let(:user) { create(:user) } diff --git a/spec/serializers/merge_request_user_entity_spec.rb b/spec/serializers/merge_request_user_entity_spec.rb index 47b9b0a57ab6ada510b04c4856538501c9098f82..8d6f066481e13ab86fface9f6a25735d59a8298e 100644 --- a/spec/serializers/merge_request_user_entity_spec.rb +++ b/spec/serializers/merge_request_user_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MergeRequestUserEntity do +RSpec.describe MergeRequestUserEntity do let(:user) { create(:user) } let(:project) { create(:project, :repository) } let(:request) { EntityRequest.new(project: project, current_user: user) } diff --git a/spec/serializers/merge_request_widget_commit_entity_spec.rb b/spec/serializers/merge_request_widget_commit_entity_spec.rb index ce83978c49a1759817ea0044272f6c5d308b92b2..0d13308f27d1f65de6e502e6a1abb7b66db793e9 100644 --- a/spec/serializers/merge_request_widget_commit_entity_spec.rb +++ b/spec/serializers/merge_request_widget_commit_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MergeRequestWidgetCommitEntity do +RSpec.describe MergeRequestWidgetCommitEntity do let(:project) { create(:project, :repository) } let(:commit) { project.commit } let(:request) { double('request') } diff --git a/spec/serializers/merge_request_widget_entity_spec.rb b/spec/serializers/merge_request_widget_entity_spec.rb index 76d4e8d9feaae43eb643192310117a45c2bafb64..37645f778d98a7eb07aaea28c93f019d0b482fbb 100644 --- a/spec/serializers/merge_request_widget_entity_spec.rb +++ b/spec/serializers/merge_request_widget_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MergeRequestWidgetEntity do +RSpec.describe MergeRequestWidgetEntity do include ProjectForksHelper let(:project) { create :project, :repository } diff --git a/spec/serializers/move_to_project_entity_spec.rb b/spec/serializers/move_to_project_entity_spec.rb index ac495eadb6802a50576815e5f6de640f324f8d88..a14bc3ae622624d5f0ca31cbc955db516491cb1d 100644 --- a/spec/serializers/move_to_project_entity_spec.rb +++ b/spec/serializers/move_to_project_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MoveToProjectEntity do +RSpec.describe MoveToProjectEntity do describe '#as_json' do let(:project) { build(:project, id: 1) } diff --git a/spec/serializers/move_to_project_serializer_spec.rb b/spec/serializers/move_to_project_serializer_spec.rb index 841ac969eeb84ad31bebaa032f09b7f8088577fb..60bcca3269f6a604bb7eca48d0cde857554063b1 100644 --- a/spec/serializers/move_to_project_serializer_spec.rb +++ b/spec/serializers/move_to_project_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MoveToProjectSerializer do +RSpec.describe MoveToProjectSerializer do describe '#represent' do it 'includes the name and name with namespace' do project = build(:project, id: 1) diff --git a/spec/serializers/namespace_basic_entity_spec.rb b/spec/serializers/namespace_basic_entity_spec.rb index d3d666d57aa9a96701e5f107198480121350edef..8b69af5696aeb66c5be4f730784bc2af6d276c37 100644 --- a/spec/serializers/namespace_basic_entity_spec.rb +++ b/spec/serializers/namespace_basic_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe NamespaceBasicEntity do +RSpec.describe NamespaceBasicEntity do let_it_be(:group) { create(:group) } let(:entity) do described_class.represent(group) diff --git a/spec/serializers/namespace_serializer_spec.rb b/spec/serializers/namespace_serializer_spec.rb index 6e5bdd8c52d1748aae37886dd48a534e8b346d72..0c4b099ef600dd1991378db36a6b842196595c9b 100644 --- a/spec/serializers/namespace_serializer_spec.rb +++ b/spec/serializers/namespace_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe NamespaceSerializer do +RSpec.describe NamespaceSerializer do it 'represents NamespaceBasicEntity entities' do expect(described_class.entity_class).to eq(NamespaceBasicEntity) end diff --git a/spec/serializers/note_entity_spec.rb b/spec/serializers/note_entity_spec.rb index f37fffb50485f2b6da23286e26a1571887189ace..19438e69a1038b543f36e7c2187102578f493a20 100644 --- a/spec/serializers/note_entity_spec.rb +++ b/spec/serializers/note_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe NoteEntity do +RSpec.describe NoteEntity do include Gitlab::Routing let(:request) { double('request', current_user: user, noteable: note.noteable) } diff --git a/spec/serializers/paginated_diff_entity_spec.rb b/spec/serializers/paginated_diff_entity_spec.rb index a6b83cb4286cdc19ac2075fd7b000e528fe4992e..30360b00537cc30962de84ccc9b7e93561772790 100644 --- a/spec/serializers/paginated_diff_entity_spec.rb +++ b/spec/serializers/paginated_diff_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe PaginatedDiffEntity do +RSpec.describe PaginatedDiffEntity do let(:user) { create(:user) } let(:request) { double('request', current_user: user) } let(:merge_request) { create(:merge_request, :with_diffs) } diff --git a/spec/serializers/pipeline_details_entity_spec.rb b/spec/serializers/pipeline_details_entity_spec.rb index 849dab102c2d7be324eb6ca4026d028e889afed0..55bb97209576e312f7a1aed638b899a677f0a69a 100644 --- a/spec/serializers/pipeline_details_entity_spec.rb +++ b/spec/serializers/pipeline_details_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe PipelineDetailsEntity do +RSpec.describe PipelineDetailsEntity do let_it_be(:user) { create(:user) } let(:request) { double('request') } diff --git a/spec/serializers/pipeline_entity_spec.rb b/spec/serializers/pipeline_entity_spec.rb index 914f42054bd6d2580beb9647b1da1b0b2d7a7e55..41b34825699501350762ec454f4b92ab02618d72 100644 --- a/spec/serializers/pipeline_entity_spec.rb +++ b/spec/serializers/pipeline_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe PipelineEntity do +RSpec.describe PipelineEntity do include Gitlab::Routing let_it_be(:project) { create(:project) } diff --git a/spec/serializers/pipeline_serializer_spec.rb b/spec/serializers/pipeline_serializer_spec.rb index c8f25423f855b8330368a2fd4bb8e806cd67fead..c3a0766e6f7aeeb684e25a93fa46c1ffce032864 100644 --- a/spec/serializers/pipeline_serializer_spec.rb +++ b/spec/serializers/pipeline_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe PipelineSerializer do +RSpec.describe PipelineSerializer do let_it_be(:project) { create(:project, :repository) } let_it_be(:user) { create(:user) } diff --git a/spec/serializers/project_import_entity_spec.rb b/spec/serializers/project_import_entity_spec.rb index 9ccae798091043b493df01547dffc98ba225e85b..1481d4122aee20053277e97f2a34c1555a8b8bff 100644 --- a/spec/serializers/project_import_entity_spec.rb +++ b/spec/serializers/project_import_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ProjectImportEntity do +RSpec.describe ProjectImportEntity do include ImportHelper let_it_be(:project) { create(:project, import_status: :started, import_source: 'namespace/project') } diff --git a/spec/serializers/project_mirror_entity_spec.rb b/spec/serializers/project_mirror_entity_spec.rb index 0d64199ecf6d5b5bd2a77c4cebbefb07f407aa59..7ed530ed9e89c6cdbe1023f21967af1b61305517 100644 --- a/spec/serializers/project_mirror_entity_spec.rb +++ b/spec/serializers/project_mirror_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ProjectMirrorEntity do +RSpec.describe ProjectMirrorEntity do let(:project) { create(:project, :repository, :remote_mirror) } let(:entity) { described_class.new(project) } diff --git a/spec/serializers/project_mirror_serializer_spec.rb b/spec/serializers/project_mirror_serializer_spec.rb index b50c2267ced38a715b8ae3b798a1c13fae136cad..0d83e25e27bf49e2251b9e36bf185859d0dc46a4 100644 --- a/spec/serializers/project_mirror_serializer_spec.rb +++ b/spec/serializers/project_mirror_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ProjectMirrorSerializer do +RSpec.describe ProjectMirrorSerializer do it 'represents ProjectMirror entities' do expect(described_class.entity_class).to eq(ProjectMirrorEntity) end diff --git a/spec/serializers/project_note_entity_spec.rb b/spec/serializers/project_note_entity_spec.rb index 469bf2b86deb55cb55cdb683cc3d97665af7aa49..aaf7764a123c61c03d4cd93ac54dfd44fe0798d8 100644 --- a/spec/serializers/project_note_entity_spec.rb +++ b/spec/serializers/project_note_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ProjectNoteEntity do +RSpec.describe ProjectNoteEntity do include Gitlab::Routing let(:request) { double('request', current_user: user, noteable: note.noteable) } diff --git a/spec/serializers/project_serializer_spec.rb b/spec/serializers/project_serializer_spec.rb index ef3dd1dc15e37501a03ef2617c0b06868084ba26..4bf0657129f04c7193ecff527fc314fb5cbb4196 100644 --- a/spec/serializers/project_serializer_spec.rb +++ b/spec/serializers/project_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ProjectSerializer do +RSpec.describe ProjectSerializer do let_it_be(:project) { create(:project) } let(:provider_url) { 'http://provider.com' } diff --git a/spec/serializers/prometheus_alert_entity_spec.rb b/spec/serializers/prometheus_alert_entity_spec.rb index 2b6d8b62c4d0459492d12253bf92f7871c76ef79..aeee8de2a5bf6a324a2f8db97b9901abc0f85f07 100644 --- a/spec/serializers/prometheus_alert_entity_spec.rb +++ b/spec/serializers/prometheus_alert_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe PrometheusAlertEntity do +RSpec.describe PrometheusAlertEntity do let(:user) { create(:user) } let(:prometheus_alert) { create(:prometheus_alert) } let(:request) { double('prometheus_alert', current_user: user) } diff --git a/spec/serializers/remote_mirror_entity_spec.rb b/spec/serializers/remote_mirror_entity_spec.rb index 27472c4643696a8f473a2b3838161a7e174ab0f3..4cbf87e4d6707559fa710485d1da7d7465156b7c 100644 --- a/spec/serializers/remote_mirror_entity_spec.rb +++ b/spec/serializers/remote_mirror_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe RemoteMirrorEntity do +RSpec.describe RemoteMirrorEntity do let(:project) { create(:project, :repository, :remote_mirror, url: "https://test:password@gitlab.com") } let(:remote_mirror) { project.remote_mirrors.first } let(:entity) { described_class.new(remote_mirror) } diff --git a/spec/serializers/request_aware_entity_spec.rb b/spec/serializers/request_aware_entity_spec.rb index 8ddb35f5f61645cf251f7295648c86417ba5fca0..d5e87f0a6182cff81cd81d59a914fb0090de5b61 100644 --- a/spec/serializers/request_aware_entity_spec.rb +++ b/spec/serializers/request_aware_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe RequestAwareEntity do +RSpec.describe RequestAwareEntity do subject do Class.new.include(described_class).new end diff --git a/spec/serializers/review_app_setup_entity_spec.rb b/spec/serializers/review_app_setup_entity_spec.rb index 19949fa92826ac4326a81591354fbe610b13973b..0893d7ee47f69d395bf2d8fdc34f35b8d0893e27 100644 --- a/spec/serializers/review_app_setup_entity_spec.rb +++ b/spec/serializers/review_app_setup_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ReviewAppSetupEntity do +RSpec.describe ReviewAppSetupEntity do let_it_be(:user) { create(:admin) } let(:project) { create(:project) } let(:presenter) { ProjectPresenter.new(project, current_user: user) } diff --git a/spec/serializers/runner_entity_spec.rb b/spec/serializers/runner_entity_spec.rb index 11a6aba431b319ca6c13fdfcac1904a7f467e4f6..84c7d1720e2adec472d071b3d365b783acb2d108 100644 --- a/spec/serializers/runner_entity_spec.rb +++ b/spec/serializers/runner_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe RunnerEntity do +RSpec.describe RunnerEntity do let(:project) { create(:project) } let(:runner) { create(:ci_runner, :project, projects: [project]) } let(:entity) { described_class.new(runner, request: request, current_user: user) } diff --git a/spec/serializers/serverless/domain_entity_spec.rb b/spec/serializers/serverless/domain_entity_spec.rb index bdf0ccb176c1e16d50e4c6110081aa64e5270a0b..4d73a0f651a966252f74ef88dacf936b6c99c0f4 100644 --- a/spec/serializers/serverless/domain_entity_spec.rb +++ b/spec/serializers/serverless/domain_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Serverless::DomainEntity do +RSpec.describe Serverless::DomainEntity do describe '#as_json' do let(:domain) { create(:pages_domain, :instance_serverless) } diff --git a/spec/serializers/service_event_entity_spec.rb b/spec/serializers/service_event_entity_spec.rb index fc11263807b709857f20499322f682d3155452d3..09bb8bca43b6c4c3181f1308324fa8284007b585 100644 --- a/spec/serializers/service_event_entity_spec.rb +++ b/spec/serializers/service_event_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ServiceEventEntity do +RSpec.describe ServiceEventEntity do let(:request) { double('request') } subject { described_class.new(event, request: request, service: service).as_json } diff --git a/spec/serializers/service_field_entity_spec.rb b/spec/serializers/service_field_entity_spec.rb index 277890d143a93ec104c5b4d5db82f714300c99d5..39f8d27e9637b30068ebdcb847934a82617a41c5 100644 --- a/spec/serializers/service_field_entity_spec.rb +++ b/spec/serializers/service_field_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ServiceFieldEntity do +RSpec.describe ServiceFieldEntity do let(:request) { double('request') } subject { described_class.new(field, request: request, service: service).as_json } diff --git a/spec/serializers/stage_entity_spec.rb b/spec/serializers/stage_entity_spec.rb index fb08d6994aeab594acbff7b4a2fe0d064ac27abc..b977d5d33aab0e7885e11d42ec7a987889079ced 100644 --- a/spec/serializers/stage_entity_spec.rb +++ b/spec/serializers/stage_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe StageEntity do +RSpec.describe StageEntity do let(:pipeline) { create(:ci_pipeline) } let(:request) { double('request') } let(:user) { create(:user) } diff --git a/spec/serializers/stage_serializer_spec.rb b/spec/serializers/stage_serializer_spec.rb index aae17cfbcb954bca156e2e74090f360c0c480387..0b5e87dc95b57e0c91bbbdc69838a82050334104 100644 --- a/spec/serializers/stage_serializer_spec.rb +++ b/spec/serializers/stage_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe StageSerializer do +RSpec.describe StageSerializer do let(:project) { create(:project, :repository) } let(:user) { create(:user) } let(:resource) { create(:ci_stage_entity) } diff --git a/spec/serializers/suggestion_entity_spec.rb b/spec/serializers/suggestion_entity_spec.rb index d282a7f9c7abac2317a915998561d5e6417a9390..0f336bdc60447187f8a43daf1292b543e95187d2 100644 --- a/spec/serializers/suggestion_entity_spec.rb +++ b/spec/serializers/suggestion_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SuggestionEntity do +RSpec.describe SuggestionEntity do include RepoHelpers let(:user) { create(:user) } diff --git a/spec/serializers/test_case_entity_spec.rb b/spec/serializers/test_case_entity_spec.rb index 9f1822ff581c97a77ef0d5e5f5b6f4765b804792..bd2a1b0fb987a365afd7ed2577cc10e3e85d2879 100644 --- a/spec/serializers/test_case_entity_spec.rb +++ b/spec/serializers/test_case_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe TestCaseEntity do +RSpec.describe TestCaseEntity do include TestReportsHelper let(:entity) { described_class.new(test_case) } diff --git a/spec/serializers/test_report_entity_spec.rb b/spec/serializers/test_report_entity_spec.rb index 5913d1c020817fac814659db97fc57fb5e97b037..549b14c04dc2b52ea533db8ad68be6fa72da5104 100644 --- a/spec/serializers/test_report_entity_spec.rb +++ b/spec/serializers/test_report_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe TestReportEntity do +RSpec.describe TestReportEntity do let(:pipeline) { create(:ci_pipeline, :with_test_reports) } let(:entity) { described_class.new(pipeline.test_reports) } diff --git a/spec/serializers/test_reports_comparer_entity_spec.rb b/spec/serializers/test_reports_comparer_entity_spec.rb index e7dabc673257a55edfcddd471e10020d96fb2c6e..3f88438ccdeb2bb0861caa9aff9fe07c82afde9c 100644 --- a/spec/serializers/test_reports_comparer_entity_spec.rb +++ b/spec/serializers/test_reports_comparer_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe TestReportsComparerEntity do +RSpec.describe TestReportsComparerEntity do include TestReportsHelper let(:entity) { described_class.new(comparer) } diff --git a/spec/serializers/test_reports_comparer_serializer_spec.rb b/spec/serializers/test_reports_comparer_serializer_spec.rb index 0d833afe9e48bb41acf657d33327946822d4e081..f9c37f4903996ee00b7e443a0df3ee0eca391bf3 100644 --- a/spec/serializers/test_reports_comparer_serializer_spec.rb +++ b/spec/serializers/test_reports_comparer_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe TestReportsComparerSerializer do +RSpec.describe TestReportsComparerSerializer do include TestReportsHelper let(:project) { double(:project) } diff --git a/spec/serializers/test_suite_comparer_entity_spec.rb b/spec/serializers/test_suite_comparer_entity_spec.rb index 9790777a570ec1906e5776b687c5e6226ddfd7a6..882991a6208887d80f51e0934adc97495301f492 100644 --- a/spec/serializers/test_suite_comparer_entity_spec.rb +++ b/spec/serializers/test_suite_comparer_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe TestSuiteComparerEntity do +RSpec.describe TestSuiteComparerEntity do include TestReportsHelper let(:entity) { described_class.new(comparer) } diff --git a/spec/serializers/trigger_variable_entity_spec.rb b/spec/serializers/trigger_variable_entity_spec.rb index f5a21f943d8098bc62319c84176bb4732a923040..e90bfc24f9f14f105f061ea6ffca322d4c239d82 100644 --- a/spec/serializers/trigger_variable_entity_spec.rb +++ b/spec/serializers/trigger_variable_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe TriggerVariableEntity do +RSpec.describe TriggerVariableEntity do let(:project) { create(:project) } let(:request) { double('request') } let(:user) { create(:user) } diff --git a/spec/serializers/user_entity_spec.rb b/spec/serializers/user_entity_spec.rb index 71107daf6ac907b0b76834a7649ef59a86a90be2..e9d86fe728236a30c35db3de7ff9780f9692a98f 100644 --- a/spec/serializers/user_entity_spec.rb +++ b/spec/serializers/user_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe UserEntity do +RSpec.describe UserEntity do include Gitlab::Routing let(:entity) { described_class.new(user) } diff --git a/spec/serializers/user_serializer_spec.rb b/spec/serializers/user_serializer_spec.rb index 2e4a8c644fe79672d3f56c4d79a20c8f072493a3..d54f33b6a239f75c49c638d9701717f838e0e940 100644 --- a/spec/serializers/user_serializer_spec.rb +++ b/spec/serializers/user_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe UserSerializer do +RSpec.describe UserSerializer do let(:user1) { create(:user) } let(:user2) { create(:user) } diff --git a/spec/serializers/variable_entity_spec.rb b/spec/serializers/variable_entity_spec.rb index 3cb18dab3146168eab4d60a052d5711e8339171b..0b20207d815b0494a4a88ca2d666b6aa5419a3e2 100644 --- a/spec/serializers/variable_entity_spec.rb +++ b/spec/serializers/variable_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe VariableEntity do +RSpec.describe VariableEntity do let(:variable) { create(:ci_variable) } let(:entity) { described_class.new(variable) } diff --git a/spec/serializers/web_ide_terminal_entity_spec.rb b/spec/serializers/web_ide_terminal_entity_spec.rb index e163afa14edd14fe8274ca7f0e29f1b1a4282ce8..a6f108bf25e4f68b61d1ae8419a63bcbe6c1ec69 100644 --- a/spec/serializers/web_ide_terminal_entity_spec.rb +++ b/spec/serializers/web_ide_terminal_entity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe WebIdeTerminalEntity do +RSpec.describe WebIdeTerminalEntity do let(:build) { create(:ci_build) } let(:entity) { described_class.new(WebIdeTerminal.new(build)) } diff --git a/spec/serializers/web_ide_terminal_serializer_spec.rb b/spec/serializers/web_ide_terminal_serializer_spec.rb index 01133deaf84399ff15450d66b0bd5e8151deca78..7ddc4bfedc8fd85e791464dbf74007b29fa5ef6e 100644 --- a/spec/serializers/web_ide_terminal_serializer_spec.rb +++ b/spec/serializers/web_ide_terminal_serializer_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe WebIdeTerminalSerializer do +RSpec.describe WebIdeTerminalSerializer do let(:build) { create(:ci_build) } subject { described_class.new.represent(WebIdeTerminal.new(build)) } diff --git a/spec/services/access_token_validation_service_spec.rb b/spec/services/access_token_validation_service_spec.rb index b2a8da6c4c6386f44da5deac94b0233a291e9cef..2bf74d64dc9e329ac161028c8ab0fbda6d9f183c 100644 --- a/spec/services/access_token_validation_service_spec.rb +++ b/spec/services/access_token_validation_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AccessTokenValidationService do +RSpec.describe AccessTokenValidationService do describe ".include_any_scope?" do let(:request) { double("request") } diff --git a/spec/services/alert_management/update_alert_status_service_spec.rb b/spec/services/alert_management/update_alert_status_service_spec.rb index b287d0d1614b79c33f77f5ef5b8dbbe5317c6d82..6883591282f92777b5e2a0ec5ebb0c9a6600c73c 100644 --- a/spec/services/alert_management/update_alert_status_service_spec.rb +++ b/spec/services/alert_management/update_alert_status_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AlertManagement::UpdateAlertStatusService do +RSpec.describe AlertManagement::UpdateAlertStatusService do let(:project) { alert.project } let_it_be(:user) { build(:user) } diff --git a/spec/services/application_settings/update_service_spec.rb b/spec/services/application_settings/update_service_spec.rb index 3a37cbc3522c1529e62ec317bf7944ad79206d30..e5060fa2eebf93c76e697e829101ebe3db3fa0b6 100644 --- a/spec/services/application_settings/update_service_spec.rb +++ b/spec/services/application_settings/update_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ApplicationSettings::UpdateService do +RSpec.describe ApplicationSettings::UpdateService do include ExternalAuthorizationServiceHelpers let(:application_settings) { create(:application_setting) } diff --git a/spec/services/applications/create_service_spec.rb b/spec/services/applications/create_service_spec.rb index c8134087fa1aad8c3719daf309cb497ad491a718..58ac723ee55083ddf029159c2ec2d6009a501eb3 100644 --- a/spec/services/applications/create_service_spec.rb +++ b/spec/services/applications/create_service_spec.rb @@ -2,7 +2,7 @@ require "spec_helper" -describe ::Applications::CreateService do +RSpec.describe ::Applications::CreateService do include TestRequestHelpers let(:user) { create(:user) } diff --git a/spec/services/audit_event_service_spec.rb b/spec/services/audit_event_service_spec.rb index dc86735805c48a5539121f336eac4fc707454f50..206ef280349db6719ef98d01e1be2ef5c737a54a 100644 --- a/spec/services/audit_event_service_spec.rb +++ b/spec/services/audit_event_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AuditEventService do +RSpec.describe AuditEventService do let(:project) { create(:project) } let(:user) { create(:user, :with_sign_ins) } let(:project_member) { create(:project_member, user: user) } diff --git a/spec/services/auth/container_registry_authentication_service_spec.rb b/spec/services/auth/container_registry_authentication_service_spec.rb index 70eb35f0826941393edcf0d1a2a301326a97b545..8d58c4b27e195a584b48e6ccdb7ee9e13a91251b 100644 --- a/spec/services/auth/container_registry_authentication_service_spec.rb +++ b/spec/services/auth/container_registry_authentication_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Auth::ContainerRegistryAuthenticationService do +RSpec.describe Auth::ContainerRegistryAuthenticationService do let(:current_project) { nil } let(:current_user) { nil } let(:current_params) { {} } diff --git a/spec/services/authorized_project_update/project_create_service_spec.rb b/spec/services/authorized_project_update/project_create_service_spec.rb index 5b3e36af76616805c22a291e7531659a47325b1d..891800bfb87f2136be5a9329cc1446b42ca40544 100644 --- a/spec/services/authorized_project_update/project_create_service_spec.rb +++ b/spec/services/authorized_project_update/project_create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AuthorizedProjectUpdate::ProjectCreateService do +RSpec.describe AuthorizedProjectUpdate::ProjectCreateService do let_it_be(:group_parent) { create(:group, :private) } let_it_be(:group) { create(:group, :private, parent: group_parent) } let_it_be(:group_child) { create(:group, :private, parent: group) } diff --git a/spec/services/auto_merge/base_service_spec.rb b/spec/services/auto_merge/base_service_spec.rb index e08e1d670bffc6c5ad27b37ccb604d054fb1449d..9673a65344d2e1c2805fa1149499ed1b913eaabe 100644 --- a/spec/services/auto_merge/base_service_spec.rb +++ b/spec/services/auto_merge/base_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AutoMerge::BaseService do +RSpec.describe AutoMerge::BaseService do let(:project) { create(:project) } let(:user) { create(:user) } let(:service) { described_class.new(project, user, params) } diff --git a/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb b/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb index b6e8d3c636aa70efac10e81391c3de809e39fe76..092742276d3d4fc9c54c2e5c0c2206d67ca344e1 100644 --- a/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb +++ b/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AutoMerge::MergeWhenPipelineSucceedsService do +RSpec.describe AutoMerge::MergeWhenPipelineSucceedsService do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project, :repository) } diff --git a/spec/services/auto_merge_service_spec.rb b/spec/services/auto_merge_service_spec.rb index bab69fb4aa32b37f171e930a1a1133c1521f9c19..eab95973e1be65293b506b128a070740fde974cc 100644 --- a/spec/services/auto_merge_service_spec.rb +++ b/spec/services/auto_merge_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AutoMergeService do +RSpec.describe AutoMergeService do let_it_be(:project) { create(:project, :repository) } let_it_be(:user) { create(:user) } let(:service) { described_class.new(project, user) } diff --git a/spec/services/award_emojis/add_service_spec.rb b/spec/services/award_emojis/add_service_spec.rb index 4bcb5fa039f3dd63f6f4a11752fbcd3ca579f98f..85c390156146845cb242c39925f98b1e1af06b7d 100644 --- a/spec/services/award_emojis/add_service_spec.rb +++ b/spec/services/award_emojis/add_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AwardEmojis::AddService do +RSpec.describe AwardEmojis::AddService do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project) } let_it_be(:awardable) { create(:note, project: project) } diff --git a/spec/services/award_emojis/collect_user_emoji_service_spec.rb b/spec/services/award_emojis/collect_user_emoji_service_spec.rb index a0dea31b403efd777cb34e2e77058b8629d66312..bf5aa0eb9effe4ba59d00c32ad47847a1d3c50ce 100644 --- a/spec/services/award_emojis/collect_user_emoji_service_spec.rb +++ b/spec/services/award_emojis/collect_user_emoji_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AwardEmojis::CollectUserEmojiService do +RSpec.describe AwardEmojis::CollectUserEmojiService do describe '#execute' do it 'returns an Array containing the awarded emoji names' do user = create(:user) diff --git a/spec/services/award_emojis/destroy_service_spec.rb b/spec/services/award_emojis/destroy_service_spec.rb index f411345560e58eb608d76e264d8266e0d9b64009..2aba078b63885e98f745a21d9d4d3cdec8868b9d 100644 --- a/spec/services/award_emojis/destroy_service_spec.rb +++ b/spec/services/award_emojis/destroy_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AwardEmojis::DestroyService do +RSpec.describe AwardEmojis::DestroyService do let_it_be(:user) { create(:user) } let_it_be(:awardable) { create(:note) } let_it_be(:project) { awardable.project } diff --git a/spec/services/award_emojis/toggle_service_spec.rb b/spec/services/award_emojis/toggle_service_spec.rb index 069bdfcb99f8288e19fe8d30f74b9a9a0b0e87fd..a7feeed50c6de260d0d27a083311c5877eb2da56 100644 --- a/spec/services/award_emojis/toggle_service_spec.rb +++ b/spec/services/award_emojis/toggle_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe AwardEmojis::ToggleService do +RSpec.describe AwardEmojis::ToggleService do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project, :public) } let_it_be(:awardable) { create(:note, project: project) } diff --git a/spec/services/base_container_service_spec.rb b/spec/services/base_container_service_spec.rb index 47cfb387e2572bb4fac6a598fbfe921dd8f5142f..1de79eec70213c11313217158d3cce0745e18c92 100644 --- a/spec/services/base_container_service_spec.rb +++ b/spec/services/base_container_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe BaseContainerService do +RSpec.describe BaseContainerService do let(:project) { Project.new } let(:user) { User.new } diff --git a/spec/services/base_count_service_spec.rb b/spec/services/base_count_service_spec.rb index 275bec9982db4f9b3dc355a58a7e71da6114a4ff..18cab2e8e9ac756a4ec7d5f6e0f83594c9cc799a 100644 --- a/spec/services/base_count_service_spec.rb +++ b/spec/services/base_count_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe BaseCountService, :use_clean_rails_memory_store_caching do +RSpec.describe BaseCountService, :use_clean_rails_memory_store_caching do let(:service) { described_class.new } describe '#relation_for_count' do diff --git a/spec/services/boards/create_service_spec.rb b/spec/services/boards/create_service_spec.rb index 7d4fb04c6c05494f95f6afdfa5df089071dea8e8..f6a9f0903ce5ce6690111e3a466a754331a6d7a2 100644 --- a/spec/services/boards/create_service_spec.rb +++ b/spec/services/boards/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Boards::CreateService do +RSpec.describe Boards::CreateService do describe '#execute' do context 'when board parent is a project' do let(:parent) { create(:project) } diff --git a/spec/services/boards/issues/create_service_spec.rb b/spec/services/boards/issues/create_service_spec.rb index 3520630dd83d19b7aa436386dfcee4beabb9b2f2..9a6b48c13bfefaa35f4f40ed599a2579ef0ffea7 100644 --- a/spec/services/boards/issues/create_service_spec.rb +++ b/spec/services/boards/issues/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Boards::Issues::CreateService do +RSpec.describe Boards::Issues::CreateService do describe '#execute' do let(:project) { create(:project) } let(:board) { create(:board, project: project) } diff --git a/spec/services/boards/issues/list_service_spec.rb b/spec/services/boards/issues/list_service_spec.rb index c46ab004af69c35049fbe0af81133e6b4b28cfd7..29b49db42f9bfec7bc56fb69e7a4bfcb11c8e54f 100644 --- a/spec/services/boards/issues/list_service_spec.rb +++ b/spec/services/boards/issues/list_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Boards::Issues::ListService do +RSpec.describe Boards::Issues::ListService do describe '#execute' do context 'when parent is a project' do let(:user) { create(:user) } diff --git a/spec/services/boards/issues/move_service_spec.rb b/spec/services/boards/issues/move_service_spec.rb index b9ebbc30c1a3bf17bd1032c2c9a55695dfb2c14f..01a3ec729878070600519d785d055a56ab833155 100644 --- a/spec/services/boards/issues/move_service_spec.rb +++ b/spec/services/boards/issues/move_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Boards::Issues::MoveService do +RSpec.describe Boards::Issues::MoveService do describe '#execute' do context 'when parent is a project' do let(:user) { create(:user) } diff --git a/spec/services/boards/list_service_spec.rb b/spec/services/boards/list_service_spec.rb index 4eb023907fa4a72b0df8fdcf678a80d5258c0a14..7c94332a78d596299c8baf2d4b33865f65ad720b 100644 --- a/spec/services/boards/list_service_spec.rb +++ b/spec/services/boards/list_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Boards::ListService do +RSpec.describe Boards::ListService do describe '#execute' do context 'when board parent is a project' do let(:parent) { create(:project) } diff --git a/spec/services/boards/lists/create_service_spec.rb b/spec/services/boards/lists/create_service_spec.rb index 295ec2c81565201047f1a6386b769aa94a6f7d94..f3d4e62eeca90faa78ab0c6fc9be60953e7f0734 100644 --- a/spec/services/boards/lists/create_service_spec.rb +++ b/spec/services/boards/lists/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Boards::Lists::CreateService do +RSpec.describe Boards::Lists::CreateService do describe '#execute' do shared_examples 'creating board lists' do let(:user) { create(:user) } diff --git a/spec/services/boards/lists/destroy_service_spec.rb b/spec/services/boards/lists/destroy_service_spec.rb index b936ef3837fbd68cc230fa1a31c938220f45fc3b..4c512b9606579c1e14fa7e10bda71a2f1dc922eb 100644 --- a/spec/services/boards/lists/destroy_service_spec.rb +++ b/spec/services/boards/lists/destroy_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Boards::Lists::DestroyService do +RSpec.describe Boards::Lists::DestroyService do describe '#execute' do context 'when board parent is a project' do let(:project) { create(:project) } diff --git a/spec/services/boards/lists/generate_service_spec.rb b/spec/services/boards/lists/generate_service_spec.rb index 77b42392470c60c4ea2deb21a828cac79e638273..9597c8e0f545a1ce4e0595e9dd08c0e856a3ae59 100644 --- a/spec/services/boards/lists/generate_service_spec.rb +++ b/spec/services/boards/lists/generate_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Boards::Lists::GenerateService do +RSpec.describe Boards::Lists::GenerateService do describe '#execute' do let(:project) { create(:project) } let(:board) { create(:board, project: project) } diff --git a/spec/services/boards/lists/list_service_spec.rb b/spec/services/boards/lists/list_service_spec.rb index 2535f339495ab2bc6af653793ed96d7c426485f3..3d71c467e96b2b256a2dd439b4ab7f1c32ea1746 100644 --- a/spec/services/boards/lists/list_service_spec.rb +++ b/spec/services/boards/lists/list_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Boards::Lists::ListService do +RSpec.describe Boards::Lists::ListService do let(:user) { create(:user) } describe '#execute' do diff --git a/spec/services/boards/lists/move_service_spec.rb b/spec/services/boards/lists/move_service_spec.rb index f8fc70ef2d680233e3bc93e0ebfb1ef45ef77ac9..2861fc48b4d4823f901d19a680bf215dfbc56080 100644 --- a/spec/services/boards/lists/move_service_spec.rb +++ b/spec/services/boards/lists/move_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Boards::Lists::MoveService do +RSpec.describe Boards::Lists::MoveService do describe '#execute' do context 'when board parent is a project' do let(:project) { create(:project) } diff --git a/spec/services/boards/lists/update_service_spec.rb b/spec/services/boards/lists/update_service_spec.rb index 243e0fc50ad46c7acc33781e3191569067f6e248..cdc7784469afc2997973caedf4b67d425971c6aa 100644 --- a/spec/services/boards/lists/update_service_spec.rb +++ b/spec/services/boards/lists/update_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Boards::Lists::UpdateService do +RSpec.describe Boards::Lists::UpdateService do let(:user) { create(:user) } let!(:list) { create(:list, board: board, position: 0) } diff --git a/spec/services/boards/visits/create_service_spec.rb b/spec/services/boards/visits/create_service_spec.rb index 203c287f396dac140153e0bf6ae5dbaf752626f3..a9a8754825be0c4284f27069a058d9823adeb6b2 100644 --- a/spec/services/boards/visits/create_service_spec.rb +++ b/spec/services/boards/visits/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Boards::Visits::CreateService do +RSpec.describe Boards::Visits::CreateService do describe '#execute' do let(:user) { create(:user) } diff --git a/spec/services/branches/create_service_spec.rb b/spec/services/branches/create_service_spec.rb index 072a86d17fceb79011d49961276df27efcf2e228..b682a3f26ecd008f714377e18b086e773a53a107 100644 --- a/spec/services/branches/create_service_spec.rb +++ b/spec/services/branches/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Branches::CreateService do +RSpec.describe Branches::CreateService do subject(:service) { described_class.new(project, user) } let_it_be(:project) { create(:project_empty_repo) } diff --git a/spec/services/branches/delete_merged_service_spec.rb b/spec/services/branches/delete_merged_service_spec.rb index 5c87f156ec7b90cdb5b05806fe629ebc9201d45a..2cf0f53c8c3a989e09c60f760774b47c8ea017f1 100644 --- a/spec/services/branches/delete_merged_service_spec.rb +++ b/spec/services/branches/delete_merged_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Branches::DeleteMergedService do +RSpec.describe Branches::DeleteMergedService do include ProjectForksHelper subject(:service) { described_class.new(project, project.owner) } diff --git a/spec/services/branches/delete_service_spec.rb b/spec/services/branches/delete_service_spec.rb index 2219416d94d3f73b41bed52658b5220521cf9ab7..b57817e9f59890f3ce3476553478c01942b0d8b3 100644 --- a/spec/services/branches/delete_service_spec.rb +++ b/spec/services/branches/delete_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Branches::DeleteService do +RSpec.describe Branches::DeleteService do let(:project) { create(:project, :repository) } let(:repository) { project.repository } let(:user) { create(:user) } diff --git a/spec/services/branches/diverging_commit_counts_service_spec.rb b/spec/services/branches/diverging_commit_counts_service_spec.rb index 370da773ab2f61cb95df1de4b9a56ea7a32e5b78..34a2b81c831783de8d8ba12044ba4a822cadca28 100644 --- a/spec/services/branches/diverging_commit_counts_service_spec.rb +++ b/spec/services/branches/diverging_commit_counts_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Branches::DivergingCommitCountsService do +RSpec.describe Branches::DivergingCommitCountsService do let(:project) { create(:project, :repository) } let(:repository) { project.repository } diff --git a/spec/services/branches/validate_new_service_spec.rb b/spec/services/branches/validate_new_service_spec.rb index 6d5078d3ccb717e4a2439acab48da7d3fb7663b7..02127c8c10d7ef8ccd4f5cef7146984ea52b041d 100644 --- a/spec/services/branches/validate_new_service_spec.rb +++ b/spec/services/branches/validate_new_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Branches::ValidateNewService do +RSpec.describe Branches::ValidateNewService do let(:project) { create(:project, :repository) } subject(:service) { described_class.new(project) } diff --git a/spec/services/bulk_push_event_payload_service_spec.rb b/spec/services/bulk_push_event_payload_service_spec.rb index 661c3540aa0b4ad1d6c75d04db7351b36add8262..381c735c0033ef6c49ab30ac6a5552e96729e098 100644 --- a/spec/services/bulk_push_event_payload_service_spec.rb +++ b/spec/services/bulk_push_event_payload_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe BulkPushEventPayloadService do +RSpec.describe BulkPushEventPayloadService do let(:event) { create(:push_event) } let(:push_data) do diff --git a/spec/services/chat_names/authorize_user_service_spec.rb b/spec/services/chat_names/authorize_user_service_spec.rb index 7f32948daad21d6525d85f1f289b155abc58d08c..b0bb741564da54c71bf48f78b9f4b0a5d294217b 100644 --- a/spec/services/chat_names/authorize_user_service_spec.rb +++ b/spec/services/chat_names/authorize_user_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ChatNames::AuthorizeUserService do +RSpec.describe ChatNames::AuthorizeUserService do describe '#execute' do subject { described_class.new(service, params) } diff --git a/spec/services/chat_names/find_user_service_spec.rb b/spec/services/chat_names/find_user_service_spec.rb index 9d26f98cd56c6284cd0ccf7719d66d5c83b55456..a29b243ad2c5800fd1f35393f04c527ea05b593c 100644 --- a/spec/services/chat_names/find_user_service_spec.rb +++ b/spec/services/chat_names/find_user_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ChatNames::FindUserService, :clean_gitlab_redis_shared_state do +RSpec.describe ChatNames::FindUserService, :clean_gitlab_redis_shared_state do describe '#execute' do let(:service) { create(:service) } diff --git a/spec/services/ci/archive_trace_service_spec.rb b/spec/services/ci/archive_trace_service_spec.rb index ba94013b5740af208feae8de2ffab2772bef3f86..07ea314debc5149abd56f3b0d5d96411558320e5 100644 --- a/spec/services/ci/archive_trace_service_spec.rb +++ b/spec/services/ci/archive_trace_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::ArchiveTraceService, '#execute' do +RSpec.describe Ci::ArchiveTraceService, '#execute' do subject { described_class.new.execute(job, worker_name: ArchiveTraceWorker.name) } context 'when job is finished' do diff --git a/spec/services/ci/build_report_result_service_spec.rb b/spec/services/ci/build_report_result_service_spec.rb index dbdfc774314f10af809313d1ef185c67ba70ca27..3c1ef5301fcbb1f7957af15899113565c9927a9d 100644 --- a/spec/services/ci/build_report_result_service_spec.rb +++ b/spec/services/ci/build_report_result_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::BuildReportResultService do +RSpec.describe Ci::BuildReportResultService do describe "#execute" do subject(:build_report_result) { described_class.new.execute(build) } diff --git a/spec/services/ci/cancel_user_pipelines_service_spec.rb b/spec/services/ci/cancel_user_pipelines_service_spec.rb index b18bf48a50af3501dcae09a4f09ae83f6503e2b3..12117051b64cfe5d8a7e54a9fc73ea604285dda1 100644 --- a/spec/services/ci/cancel_user_pipelines_service_spec.rb +++ b/spec/services/ci/cancel_user_pipelines_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::CancelUserPipelinesService do +RSpec.describe Ci::CancelUserPipelinesService do describe '#execute' do let(:user) { create(:user) } diff --git a/spec/services/ci/compare_accessibility_reports_service_spec.rb b/spec/services/ci/compare_accessibility_reports_service_spec.rb index aee1fd14bc5a60372ae58d8bbeec4ea399fc7b2f..6903a633eeb0411b17bae05f619cbbf7aafba658 100644 --- a/spec/services/ci/compare_accessibility_reports_service_spec.rb +++ b/spec/services/ci/compare_accessibility_reports_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::CompareAccessibilityReportsService do +RSpec.describe Ci::CompareAccessibilityReportsService do let(:service) { described_class.new(project) } let(:project) { create(:project, :repository) } diff --git a/spec/services/ci/compare_test_reports_service_spec.rb b/spec/services/ci/compare_test_reports_service_spec.rb index 46f4d2d42ff79d130b08c2b6409b74d74c034f6d..7d31db73b6aa5c99b3771d445c34171d611c8c9c 100644 --- a/spec/services/ci/compare_test_reports_service_spec.rb +++ b/spec/services/ci/compare_test_reports_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::CompareTestReportsService do +RSpec.describe Ci::CompareTestReportsService do let(:service) { described_class.new(project) } let(:project) { create(:project, :repository) } diff --git a/spec/services/ci/create_cross_project_pipeline_service_spec.rb b/spec/services/ci/create_cross_project_pipeline_service_spec.rb index 9e2497854bcef8e30242588bdbe0489a936e6787..1aabdb85afda300ad70cc1e3fe3c6ac4d4e8cc02 100644 --- a/spec/services/ci/create_cross_project_pipeline_service_spec.rb +++ b/spec/services/ci/create_cross_project_pipeline_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::CreateCrossProjectPipelineService, '#execute' do +RSpec.describe Ci::CreateCrossProjectPipelineService, '#execute' do let_it_be(:user) { create(:user) } let(:upstream_project) { create(:project, :repository) } let_it_be(:downstream_project) { create(:project, :repository) } diff --git a/spec/services/ci/create_job_artifacts_service_spec.rb b/spec/services/ci/create_job_artifacts_service_spec.rb index 4d49923a18466a16f7d83553cc7e3088482b81e2..e431cfd0117ee4a4c094bb00d5d9410327d042c1 100644 --- a/spec/services/ci/create_job_artifacts_service_spec.rb +++ b/spec/services/ci/create_job_artifacts_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::CreateJobArtifactsService do +RSpec.describe Ci::CreateJobArtifactsService do let_it_be(:project) { create(:project) } let(:service) { described_class.new(project) } let(:job) { create(:ci_build, project: project) } diff --git a/spec/services/ci/create_pipeline_service/cache_spec.rb b/spec/services/ci/create_pipeline_service/cache_spec.rb index 4e0567132ff77fb38c15aee0a398d074f178c3cf..614e46f1b1a580788d55daaafa13a0b17cae8db5 100644 --- a/spec/services/ci/create_pipeline_service/cache_spec.rb +++ b/spec/services/ci/create_pipeline_service/cache_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::CreatePipelineService do +RSpec.describe Ci::CreatePipelineService do context 'cache' do let(:user) { create(:admin) } let(:ref) { 'refs/heads/master' } diff --git a/spec/services/ci/create_pipeline_service/custom_config_content_spec.rb b/spec/services/ci/create_pipeline_service/custom_config_content_spec.rb index 5980260a08aa414c56a24c2d5bd49c979ad80456..122870e0f3a7e03824be8a3cd5bf44925b370b86 100644 --- a/spec/services/ci/create_pipeline_service/custom_config_content_spec.rb +++ b/spec/services/ci/create_pipeline_service/custom_config_content_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe Ci::CreatePipelineService do +RSpec.describe Ci::CreatePipelineService do let_it_be(:project) { create(:project, :repository) } let_it_be(:user) { create(:admin) } let(:ref) { 'refs/heads/master' } diff --git a/spec/services/ci/create_pipeline_service/needs_spec.rb b/spec/services/ci/create_pipeline_service/needs_spec.rb index 17b9cf80cc1379322ed9fcb992c8043a5d8b4626..915dc46d6641d4bfc4d59f721b4579455d22f30a 100644 --- a/spec/services/ci/create_pipeline_service/needs_spec.rb +++ b/spec/services/ci/create_pipeline_service/needs_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::CreatePipelineService do +RSpec.describe Ci::CreatePipelineService do context 'needs' do let_it_be(:user) { create(:admin) } let_it_be(:project) { create(:project, :repository, creator: user) } diff --git a/spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb b/spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb index a76e83f2d605142b5f976b2616c24f02202e805c..016a5dfd18b62f252ac58891db596354329abe88 100644 --- a/spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb +++ b/spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::CreatePipelineService, '#execute' do +RSpec.describe Ci::CreatePipelineService, '#execute' do let_it_be(:project) { create(:project, :repository) } let_it_be(:user) { create(:user) } let(:ref_name) { 'master' } diff --git a/spec/services/ci/create_pipeline_service/pre_post_stages_spec.rb b/spec/services/ci/create_pipeline_service/pre_post_stages_spec.rb index 2b11b98f58c338e87cd6070e2ecc551b072cf379..00a2dd749688465caec8bde265e29b6b93f51b2d 100644 --- a/spec/services/ci/create_pipeline_service/pre_post_stages_spec.rb +++ b/spec/services/ci/create_pipeline_service/pre_post_stages_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe Ci::CreatePipelineService do +RSpec.describe Ci::CreatePipelineService do describe '.pre/.post stages' do let_it_be(:user) { create(:admin) } let_it_be(:project) { create(:project, :repository, creator: user) } diff --git a/spec/services/ci/create_pipeline_service/rules_spec.rb b/spec/services/ci/create_pipeline_service/rules_spec.rb index 713d230731b1ac1e0e75b19e8374527d1955703b..1a1fa6e8f5d94691a273fa77170b1eb08cb0c244 100644 --- a/spec/services/ci/create_pipeline_service/rules_spec.rb +++ b/spec/services/ci/create_pipeline_service/rules_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe Ci::CreatePipelineService do +RSpec.describe Ci::CreatePipelineService do let(:user) { create(:admin) } let(:ref) { 'refs/heads/master' } let(:source) { :push } diff --git a/spec/services/ci/create_pipeline_service_spec.rb b/spec/services/ci/create_pipeline_service_spec.rb index b9456d5fcd47495651806e3cb0d9234e67451ed5..1e8ee37bec41258787976da95328b583003508ce 100644 --- a/spec/services/ci/create_pipeline_service_spec.rb +++ b/spec/services/ci/create_pipeline_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::CreatePipelineService do +RSpec.describe Ci::CreatePipelineService do include ProjectForksHelper let_it_be(:project, reload: true) { create(:project, :repository) } diff --git a/spec/services/ci/create_web_ide_terminal_service_spec.rb b/spec/services/ci/create_web_ide_terminal_service_spec.rb index 2cc67c7cd1ddde37ebb932ecb5487a5c9d4f8b7a..c1c94e30018361429903ac0f5a5bf036bef97442 100644 --- a/spec/services/ci/create_web_ide_terminal_service_spec.rb +++ b/spec/services/ci/create_web_ide_terminal_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::CreateWebIdeTerminalService do +RSpec.describe Ci::CreateWebIdeTerminalService do let_it_be(:project) { create(:project, :repository) } let_it_be(:user) { create(:user) } let(:ref) { 'master' } diff --git a/spec/services/ci/daily_build_group_report_result_service_spec.rb b/spec/services/ci/daily_build_group_report_result_service_spec.rb index f0b72b8fd866e5132df0c24cb82ec4b9120e3df0..7d181a5c2ba39b76584319c7cbbe624f904d35a4 100644 --- a/spec/services/ci/daily_build_group_report_result_service_spec.rb +++ b/spec/services/ci/daily_build_group_report_result_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::DailyBuildGroupReportResultService, '#execute' do +RSpec.describe Ci::DailyBuildGroupReportResultService, '#execute' do let!(:pipeline) { create(:ci_pipeline, created_at: '2020-02-06 00:01:10') } let!(:rspec_job) { create(:ci_build, pipeline: pipeline, name: '3/3 rspec', coverage: 80) } let!(:karma_job) { create(:ci_build, pipeline: pipeline, name: '2/2 karma', coverage: 90) } diff --git a/spec/services/ci/destroy_expired_job_artifacts_service_spec.rb b/spec/services/ci/destroy_expired_job_artifacts_service_spec.rb index 4b9f12d8fdfb85700c41ed25f3b2fe10b948c8d7..1ec9e8df8006881cb99f9894c841cd145b0f3c33 100644 --- a/spec/services/ci/destroy_expired_job_artifacts_service_spec.rb +++ b/spec/services/ci/destroy_expired_job_artifacts_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::DestroyExpiredJobArtifactsService, :clean_gitlab_redis_shared_state do +RSpec.describe Ci::DestroyExpiredJobArtifactsService, :clean_gitlab_redis_shared_state do include ExclusiveLeaseHelpers describe '.execute' do diff --git a/spec/services/ci/destroy_pipeline_service_spec.rb b/spec/services/ci/destroy_pipeline_service_spec.rb index bff2b3179fbd9115f4222af90a3152a54322227e..23cbe683d2f83a5b2a24a1b8ec86bec9edbcaec6 100644 --- a/spec/services/ci/destroy_pipeline_service_spec.rb +++ b/spec/services/ci/destroy_pipeline_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ::Ci::DestroyPipelineService do +RSpec.describe ::Ci::DestroyPipelineService do let(:project) { create(:project, :repository) } let!(:pipeline) { create(:ci_pipeline, :success, project: project, sha: project.commit.id) } diff --git a/spec/services/ci/ensure_stage_service_spec.rb b/spec/services/ci/ensure_stage_service_spec.rb index 8a270d77bae214e69e042f5e8c941aee4274b881..3ede214cdd43fe0dfae2cb3b9848bbfb10311428 100644 --- a/spec/services/ci/ensure_stage_service_spec.rb +++ b/spec/services/ci/ensure_stage_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::EnsureStageService, '#execute' do +RSpec.describe Ci::EnsureStageService, '#execute' do let_it_be(:project) { create(:project) } let_it_be(:user) { create(:user) } diff --git a/spec/services/ci/expire_pipeline_cache_service_spec.rb b/spec/services/ci/expire_pipeline_cache_service_spec.rb index 2962e9dd31edecf5f75ef014dbd463f9bbd76954..b5d664947de2264ba73a837beb1fc71c54e17f19 100644 --- a/spec/services/ci/expire_pipeline_cache_service_spec.rb +++ b/spec/services/ci/expire_pipeline_cache_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::ExpirePipelineCacheService do +RSpec.describe Ci::ExpirePipelineCacheService do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project) } let_it_be(:pipeline) { create(:ci_pipeline, project: project) } diff --git a/spec/services/ci/external_pull_requests/create_pipeline_service_spec.rb b/spec/services/ci/external_pull_requests/create_pipeline_service_spec.rb index 5048f2b71b349ee2b15cbfbd0959491247f5af3e..e2bdfae27f09a5465500f5918df421ff9b6494b8 100644 --- a/spec/services/ci/external_pull_requests/create_pipeline_service_spec.rb +++ b/spec/services/ci/external_pull_requests/create_pipeline_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::ExternalPullRequests::CreatePipelineService do +RSpec.describe Ci::ExternalPullRequests::CreatePipelineService do describe '#execute' do let_it_be(:project) { create(:project, :auto_devops, :repository) } let_it_be(:user) { create(:user) } diff --git a/spec/services/ci/extract_sections_from_build_trace_service_spec.rb b/spec/services/ci/extract_sections_from_build_trace_service_spec.rb index 03c67c611fe5ee1c558ffcaa20326bf10b031e8d..c6ffcdcc6a8aacbde0da3b3ba9a363b427d2dcfb 100644 --- a/spec/services/ci/extract_sections_from_build_trace_service_spec.rb +++ b/spec/services/ci/extract_sections_from_build_trace_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::ExtractSectionsFromBuildTraceService, '#execute' do +RSpec.describe Ci::ExtractSectionsFromBuildTraceService, '#execute' do let(:user) { create(:user) } let(:project) { create(:project) } let(:build) { create(:ci_build, project: project) } diff --git a/spec/services/ci/find_exposed_artifacts_service_spec.rb b/spec/services/ci/find_exposed_artifacts_service_spec.rb index 16e23253c344538dd07d761d8b6a949d5af50690..287f5c4b92901545f9b4068e3d4723d6be876159 100644 --- a/spec/services/ci/find_exposed_artifacts_service_spec.rb +++ b/spec/services/ci/find_exposed_artifacts_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::FindExposedArtifactsService do +RSpec.describe Ci::FindExposedArtifactsService do include Gitlab::Routing let(:metadata) do diff --git a/spec/services/ci/generate_coverage_reports_service_spec.rb b/spec/services/ci/generate_coverage_reports_service_spec.rb index b64b682a00b5f57632993a956173ba8d8c78a301..a3ed2eec71307c35ecce793ea5941681d102db49 100644 --- a/spec/services/ci/generate_coverage_reports_service_spec.rb +++ b/spec/services/ci/generate_coverage_reports_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::GenerateCoverageReportsService do +RSpec.describe Ci::GenerateCoverageReportsService do let(:service) { described_class.new(project) } let(:project) { create(:project, :repository) } diff --git a/spec/services/ci/generate_terraform_reports_service_spec.rb b/spec/services/ci/generate_terraform_reports_service_spec.rb index 008ecf17b3e47ca9d25e2bdc11594d00921eaeb7..07bc89a7f5eb8c88030aaaef973433a40d7c4417 100644 --- a/spec/services/ci/generate_terraform_reports_service_spec.rb +++ b/spec/services/ci/generate_terraform_reports_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::GenerateTerraformReportsService do +RSpec.describe Ci::GenerateTerraformReportsService do let_it_be(:project) { create(:project, :repository) } describe '#execute' do diff --git a/spec/services/ci/parse_dotenv_artifact_service_spec.rb b/spec/services/ci/parse_dotenv_artifact_service_spec.rb index fc4131d262baa3f35961a74f293a7f0c15a38d3a..a5f01187a83d9726865db6954698272e795f3adf 100644 --- a/spec/services/ci/parse_dotenv_artifact_service_spec.rb +++ b/spec/services/ci/parse_dotenv_artifact_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::ParseDotenvArtifactService do +RSpec.describe Ci::ParseDotenvArtifactService do let_it_be(:project) { create(:project) } let_it_be(:pipeline) { create(:ci_pipeline, project: project) } let(:build) { create(:ci_build, pipeline: pipeline, project: project) } diff --git a/spec/services/ci/pipeline_bridge_status_service_spec.rb b/spec/services/ci/pipeline_bridge_status_service_spec.rb index 7e79d22234917dadcd2ae846e409e6bec75de1f7..584b23bb3aa018e17115715e48946a88f653faf2 100644 --- a/spec/services/ci/pipeline_bridge_status_service_spec.rb +++ b/spec/services/ci/pipeline_bridge_status_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::PipelineBridgeStatusService do +RSpec.describe Ci::PipelineBridgeStatusService do let(:user) { build(:user) } let_it_be(:project) { create(:project) } let(:pipeline) { build(:ci_pipeline, project: project) } diff --git a/spec/services/ci/pipeline_processing/atomic_processing_service/status_collection_spec.rb b/spec/services/ci/pipeline_processing/atomic_processing_service/status_collection_spec.rb index de3c7713ac8ca8a647a551ca79cbbc610a642ac8..7868629d34dee85da87635c3c413119c5b5d4d5f 100644 --- a/spec/services/ci/pipeline_processing/atomic_processing_service/status_collection_spec.rb +++ b/spec/services/ci/pipeline_processing/atomic_processing_service/status_collection_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::PipelineProcessing::AtomicProcessingService::StatusCollection do +RSpec.describe Ci::PipelineProcessing::AtomicProcessingService::StatusCollection do using RSpec::Parameterized::TableSyntax let_it_be(:pipeline) { create(:ci_pipeline) } diff --git a/spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb b/spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb index 3b66ecff196b7b40047b4b22bd4243c426db0a1b..a10a333b46206e884abbc3c8946bb49d5be38d33 100644 --- a/spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb +++ b/spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb @@ -4,7 +4,7 @@ require_relative 'shared_processing_service.rb' require_relative 'shared_processing_service_tests_with_yaml.rb' -describe Ci::PipelineProcessing::AtomicProcessingService do +RSpec.describe Ci::PipelineProcessing::AtomicProcessingService do before do stub_feature_flags(ci_atomic_processing: true) diff --git a/spec/services/ci/pipeline_processing/legacy_processing_service_spec.rb b/spec/services/ci/pipeline_processing/legacy_processing_service_spec.rb index fd491bf461b5bae76c9fb3b1734694c1ee56cecd..569a6d62dc193f6fcdcb7d1160acc870c266329e 100644 --- a/spec/services/ci/pipeline_processing/legacy_processing_service_spec.rb +++ b/spec/services/ci/pipeline_processing/legacy_processing_service_spec.rb @@ -4,7 +4,7 @@ require_relative 'shared_processing_service.rb' require_relative 'shared_processing_service_tests_with_yaml.rb' -describe Ci::PipelineProcessing::LegacyProcessingService do +RSpec.describe Ci::PipelineProcessing::LegacyProcessingService do before do stub_feature_flags(ci_atomic_processing: false) end diff --git a/spec/services/ci/pipeline_processing/shared_processing_service.rb b/spec/services/ci/pipeline_processing/shared_processing_service.rb index 29fa43001aebe4928f8d2bcb83e05648461e04b9..224066885b64d865192a516a05b1146a4463a530 100644 --- a/spec/services/ci/pipeline_processing/shared_processing_service.rb +++ b/spec/services/ci/pipeline_processing/shared_processing_service.rb @@ -1,6 +1,6 @@ # frozen_string_literal: true -shared_examples 'Pipeline Processing Service' do +RSpec.shared_examples 'Pipeline Processing Service' do let(:user) { create(:user) } let(:project) { create(:project) } diff --git a/spec/services/ci/pipeline_processing/shared_processing_service_tests_with_yaml.rb b/spec/services/ci/pipeline_processing/shared_processing_service_tests_with_yaml.rb index 93f83f0ea3bbad851340c11b0cfcf092bc60a810..17d254ba48e1f2d72e74a2bcd9c915614b4fbc11 100644 --- a/spec/services/ci/pipeline_processing/shared_processing_service_tests_with_yaml.rb +++ b/spec/services/ci/pipeline_processing/shared_processing_service_tests_with_yaml.rb @@ -1,6 +1,6 @@ # frozen_string_literal: true -shared_context 'Pipeline Processing Service Tests With Yaml' do +RSpec.shared_context 'Pipeline Processing Service Tests With Yaml' do where(:test_file_path) do Dir.glob(Rails.root.join('spec/services/ci/pipeline_processing/test_cases/*.yml')) end diff --git a/spec/services/ci/pipeline_schedule_service_spec.rb b/spec/services/ci/pipeline_schedule_service_spec.rb index 867ed0acc0dbe41dafe31dc2aff8eb31b6b82907..65bbd13c5e77a7f6ea79c8fe6b75cbb1c16f1298 100644 --- a/spec/services/ci/pipeline_schedule_service_spec.rb +++ b/spec/services/ci/pipeline_schedule_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::PipelineScheduleService do +RSpec.describe Ci::PipelineScheduleService do let(:project) { create(:project) } let(:user) { create(:user) } let(:service) { described_class.new(project, user) } diff --git a/spec/services/ci/pipeline_trigger_service_spec.rb b/spec/services/ci/pipeline_trigger_service_spec.rb index 44ce1ff699b562f21e1199d4780a4c10572ccc28..18fab9623ec8f5d2d90e1f1268fdafcf1dd3fc09 100644 --- a/spec/services/ci/pipeline_trigger_service_spec.rb +++ b/spec/services/ci/pipeline_trigger_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::PipelineTriggerService do +RSpec.describe Ci::PipelineTriggerService do let(:project) { create(:project, :repository) } before do diff --git a/spec/services/ci/play_build_service_spec.rb b/spec/services/ci/play_build_service_spec.rb index cf39f3da4fe22f84160eb8db99e780fcd31c4d4e..c9ecbad316786f95a71845b188ccdd1305e38c09 100644 --- a/spec/services/ci/play_build_service_spec.rb +++ b/spec/services/ci/play_build_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::PlayBuildService, '#execute' do +RSpec.describe Ci::PlayBuildService, '#execute' do let(:user) { create(:user, developer_projects: [project]) } let(:project) { create(:project) } let(:pipeline) { create(:ci_pipeline, project: project) } diff --git a/spec/services/ci/play_manual_stage_service_spec.rb b/spec/services/ci/play_manual_stage_service_spec.rb index e2946111a1397b5c4a308a51dd4fbcc6ff310b24..e30ec8bfda571a35ffe8484c93de286f97840176 100644 --- a/spec/services/ci/play_manual_stage_service_spec.rb +++ b/spec/services/ci/play_manual_stage_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::PlayManualStageService, '#execute' do +RSpec.describe Ci::PlayManualStageService, '#execute' do let(:current_user) { create(:user) } let(:pipeline) { create(:ci_pipeline, user: current_user) } let(:project) { pipeline.project } diff --git a/spec/services/ci/prepare_build_service_spec.rb b/spec/services/ci/prepare_build_service_spec.rb index 02928b58ff8b3f69d5156c628ddaff034ec339d9..f75cb322fe9fad07c18b8c18c18377296a31c4d3 100644 --- a/spec/services/ci/prepare_build_service_spec.rb +++ b/spec/services/ci/prepare_build_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::PrepareBuildService do +RSpec.describe Ci::PrepareBuildService do describe '#execute' do let(:build) { create(:ci_build, :preparing) } diff --git a/spec/services/ci/process_build_service_spec.rb b/spec/services/ci/process_build_service_spec.rb index abc5c18a523e47206351fe793959af34e04656cf..a6e8732f5ff1ea02c72759006cf9925289f1e7ac 100644 --- a/spec/services/ci/process_build_service_spec.rb +++ b/spec/services/ci/process_build_service_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe Ci::ProcessBuildService, '#execute' do +RSpec.describe Ci::ProcessBuildService, '#execute' do let(:user) { create(:user) } let(:project) { create(:project) } diff --git a/spec/services/ci/process_pipeline_service_spec.rb b/spec/services/ci/process_pipeline_service_spec.rb index 40ae1c4029b36241bc7376868fa62456dbe19a92..6ebb3188f00a6bfec2d3f962107317b63db63a9b 100644 --- a/spec/services/ci/process_pipeline_service_spec.rb +++ b/spec/services/ci/process_pipeline_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::ProcessPipelineService do +RSpec.describe Ci::ProcessPipelineService do let(:user) { create(:user) } let(:project) { create(:project) } diff --git a/spec/services/ci/register_job_service_spec.rb b/spec/services/ci/register_job_service_spec.rb index c0f854df9b707f0371e9e39138bbf989995db92a..5727f3df8573246f8c2f400ddc996bb594f0e47e 100644 --- a/spec/services/ci/register_job_service_spec.rb +++ b/spec/services/ci/register_job_service_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' module Ci - describe RegisterJobService do + RSpec.describe RegisterJobService do let_it_be(:group) { create(:group) } let_it_be(:project, reload: true) { create(:project, group: group, shared_runners_enabled: false, group_runners_enabled: false) } let_it_be(:pipeline) { create(:ci_pipeline, project: project) } diff --git a/spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb b/spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb index 50d312647ae6ab1fd268712518b70a0bc9ee746c..6c69a7f3b117fcf62a35b277e8d557c11c42374e 100644 --- a/spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb +++ b/spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::ResourceGroups::AssignResourceFromResourceGroupService do +RSpec.describe Ci::ResourceGroups::AssignResourceFromResourceGroupService do let_it_be(:project) { create(:project) } let_it_be(:user) { create(:user) } let(:service) { described_class.new(project, user) } diff --git a/spec/services/ci/retry_build_service_spec.rb b/spec/services/ci/retry_build_service_spec.rb index 90c53d4a34616ea3b06d4f763d1c5cf160eeb140..93f64336cad5cb4a6dd90be8e07476dc823b1d7a 100644 --- a/spec/services/ci/retry_build_service_spec.rb +++ b/spec/services/ci/retry_build_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::RetryBuildService do +RSpec.describe Ci::RetryBuildService do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project, :repository) } let_it_be(:pipeline) do diff --git a/spec/services/ci/retry_pipeline_service_spec.rb b/spec/services/ci/retry_pipeline_service_spec.rb index 8e85e68d4fc28fa0609462adb6c3bdcfee7c27bd..fa46d6c4d1d2d25be88dabc2f74a9bdda379d9e4 100644 --- a/spec/services/ci/retry_pipeline_service_spec.rb +++ b/spec/services/ci/retry_pipeline_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::RetryPipelineService, '#execute' do +RSpec.describe Ci::RetryPipelineService, '#execute' do include ProjectForksHelper let(:user) { create(:user) } diff --git a/spec/services/ci/run_scheduled_build_service_spec.rb b/spec/services/ci/run_scheduled_build_service_spec.rb index 43d110cbc8fce42c7b40bede5024446191254d99..27d25e8894481430119d2b48701edc1c5245dafe 100644 --- a/spec/services/ci/run_scheduled_build_service_spec.rb +++ b/spec/services/ci/run_scheduled_build_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::RunScheduledBuildService do +RSpec.describe Ci::RunScheduledBuildService do let(:user) { create(:user) } let(:project) { create(:project) } let(:pipeline) { create(:ci_pipeline, project: project) } diff --git a/spec/services/ci/stop_environments_service_spec.rb b/spec/services/ci/stop_environments_service_spec.rb index ebbe6c37b87c7f93a6358e91a3b4b49112e9c3bb..5a0b7f23556708889867b2c3bbf0acb65de1551b 100644 --- a/spec/services/ci/stop_environments_service_spec.rb +++ b/spec/services/ci/stop_environments_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::StopEnvironmentsService do +RSpec.describe Ci::StopEnvironmentsService do include CreateEnvironmentsHelpers let(:project) { create(:project, :private, :repository) } diff --git a/spec/services/ci/update_build_queue_service_spec.rb b/spec/services/ci/update_build_queue_service_spec.rb index 522dd1ba1c282c658f0c2e834a476ad2aaa35a05..0f4c0fa5ecb2dd459231408481be7960e37be6ce 100644 --- a/spec/services/ci/update_build_queue_service_spec.rb +++ b/spec/services/ci/update_build_queue_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::UpdateBuildQueueService do +RSpec.describe Ci::UpdateBuildQueueService do let(:project) { create(:project, :repository) } let(:build) { create(:ci_build, pipeline: pipeline) } let(:pipeline) { create(:ci_pipeline, project: project) } diff --git a/spec/services/ci/update_instance_variables_service_spec.rb b/spec/services/ci/update_instance_variables_service_spec.rb index 93f6e5d3ea8967cde82369c00b3e60a5175baa28..f235d006e34d06c7927fac8e5a9901abb474f14a 100644 --- a/spec/services/ci/update_instance_variables_service_spec.rb +++ b/spec/services/ci/update_instance_variables_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::UpdateInstanceVariablesService do +RSpec.describe Ci::UpdateInstanceVariablesService do let(:params) { { variables_attributes: variables_attributes } } subject { described_class.new(params) } diff --git a/spec/services/ci/update_runner_service_spec.rb b/spec/services/ci/update_runner_service_spec.rb index abe575eebc8bfbdd578171d3b0d2397d4e3c3788..cad9e893335f0385a3c66e62209b3b552bfd26cf 100644 --- a/spec/services/ci/update_runner_service_spec.rb +++ b/spec/services/ci/update_runner_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::UpdateRunnerService do +RSpec.describe Ci::UpdateRunnerService do let(:runner) { create(:ci_runner) } describe '#update' do diff --git a/spec/services/ci/web_ide_config_service_spec.rb b/spec/services/ci/web_ide_config_service_spec.rb index 7522103ccb7585f370ed53bae12b7cde80257672..437b468cec8f1dce3c910dc6cce4aa3fe20fad1b 100644 --- a/spec/services/ci/web_ide_config_service_spec.rb +++ b/spec/services/ci/web_ide_config_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Ci::WebIdeConfigService do +RSpec.describe Ci::WebIdeConfigService do let_it_be(:project) { create(:project, :repository) } let_it_be(:user) { create(:user) } let(:sha) { 'sha' } diff --git a/spec/services/clusters/applications/check_ingress_ip_address_service_spec.rb b/spec/services/clusters/applications/check_ingress_ip_address_service_spec.rb index 84bca76e69b9c1093e9666b3aadcc07a29ee6373..605d9e67ab641ee4374b2a1a8cf5173a6894701c 100644 --- a/spec/services/clusters/applications/check_ingress_ip_address_service_spec.rb +++ b/spec/services/clusters/applications/check_ingress_ip_address_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Applications::CheckIngressIpAddressService do +RSpec.describe Clusters::Applications::CheckIngressIpAddressService do include ExclusiveLeaseHelpers let(:application) { create(:clusters_applications_ingress, :installed) } diff --git a/spec/services/clusters/applications/check_installation_progress_service_spec.rb b/spec/services/clusters/applications/check_installation_progress_service_spec.rb index 4b8db405101e1e776932c24fbe512aa588c8f22a..13f7cd620028a4ee0e2a54711974a7f5f50f23f9 100644 --- a/spec/services/clusters/applications/check_installation_progress_service_spec.rb +++ b/spec/services/clusters/applications/check_installation_progress_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Applications::CheckInstallationProgressService, '#execute' do +RSpec.describe Clusters::Applications::CheckInstallationProgressService, '#execute' do RESCHEDULE_PHASES = Gitlab::Kubernetes::Pod::PHASES - [Gitlab::Kubernetes::Pod::SUCCEEDED, Gitlab::Kubernetes::Pod::FAILED].freeze let(:application) { create(:clusters_applications_helm, :installing) } diff --git a/spec/services/clusters/applications/check_uninstall_progress_service_spec.rb b/spec/services/clusters/applications/check_uninstall_progress_service_spec.rb index 9dede1947f8f3ede904d695123be766b200137f2..4b8893429cfaeac8e5e608705a7cc442d8ef4fbc 100644 --- a/spec/services/clusters/applications/check_uninstall_progress_service_spec.rb +++ b/spec/services/clusters/applications/check_uninstall_progress_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Applications::CheckUninstallProgressService do +RSpec.describe Clusters::Applications::CheckUninstallProgressService do reschedule_phases = Gitlab::Kubernetes::Pod::PHASES - [Gitlab::Kubernetes::Pod::SUCCEEDED, Gitlab::Kubernetes::Pod::FAILED].freeze let(:application) { create(:clusters_applications_prometheus, :uninstalling) } diff --git a/spec/services/clusters/applications/check_upgrade_progress_service_spec.rb b/spec/services/clusters/applications/check_upgrade_progress_service_spec.rb index 29ee897454a4fefc33ea97c332e45b46007df4fe..dbde8cec9b9ace171b6d4e47aa27b529bc35fc3d 100644 --- a/spec/services/clusters/applications/check_upgrade_progress_service_spec.rb +++ b/spec/services/clusters/applications/check_upgrade_progress_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Applications::CheckUpgradeProgressService do +RSpec.describe Clusters::Applications::CheckUpgradeProgressService do reschedule_phashes = ::Gitlab::Kubernetes::Pod::PHASES - [::Gitlab::Kubernetes::Pod::SUCCEEDED, ::Gitlab::Kubernetes::Pod::FAILED, ::Gitlab].freeze diff --git a/spec/services/clusters/applications/create_service_spec.rb b/spec/services/clusters/applications/create_service_spec.rb index 0b48af408e1da139f7f02a08e05d6732f579ec8b..f93ae2c62f32bc92d76cd394c3a2d49e2ca2041a 100644 --- a/spec/services/clusters/applications/create_service_spec.rb +++ b/spec/services/clusters/applications/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Applications::CreateService do +RSpec.describe Clusters::Applications::CreateService do include TestRequestHelpers let(:cluster) { create(:cluster, :project, :provided_by_gcp) } diff --git a/spec/services/clusters/applications/destroy_service_spec.rb b/spec/services/clusters/applications/destroy_service_spec.rb index 8d9dc6a0f1125eb6a17d7d6d0bf2de6fb12f74dd..7306256e68eff990daa7a6ae3d5d5bb2e9adbc94 100644 --- a/spec/services/clusters/applications/destroy_service_spec.rb +++ b/spec/services/clusters/applications/destroy_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Applications::DestroyService, '#execute' do +RSpec.describe Clusters::Applications::DestroyService, '#execute' do let(:cluster) { create(:cluster, :project, :provided_by_gcp) } let(:user) { create(:user) } let(:params) { { application: 'prometheus' } } diff --git a/spec/services/clusters/applications/install_service_spec.rb b/spec/services/clusters/applications/install_service_spec.rb index 2441cc595a3a00e867757fe6f5dfc5c29cd0ab7d..d34b4dd943cde8d389347852883c43ce39847da7 100644 --- a/spec/services/clusters/applications/install_service_spec.rb +++ b/spec/services/clusters/applications/install_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Applications::InstallService do +RSpec.describe Clusters::Applications::InstallService do describe '#execute' do let(:application) { create(:clusters_applications_helm, :scheduled) } let!(:install_command) { application.install_command } diff --git a/spec/services/clusters/applications/patch_service_spec.rb b/spec/services/clusters/applications/patch_service_spec.rb index dc9843a5116a454ee3aa3b3de80d0da5a666008c..281da62b80bf30d83d576eef5700d93bfd691aba 100644 --- a/spec/services/clusters/applications/patch_service_spec.rb +++ b/spec/services/clusters/applications/patch_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Applications::PatchService do +RSpec.describe Clusters::Applications::PatchService do describe '#execute' do let(:application) { create(:clusters_applications_knative, :scheduled) } let!(:update_command) { application.update_command } diff --git a/spec/services/clusters/applications/prometheus_config_service_spec.rb b/spec/services/clusters/applications/prometheus_config_service_spec.rb index b9032e665ecd075819f1ff5ed327bbb2a24d0118..7399f25024816fdd5709932654a892d34087b564 100644 --- a/spec/services/clusters/applications/prometheus_config_service_spec.rb +++ b/spec/services/clusters/applications/prometheus_config_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Applications::PrometheusConfigService do +RSpec.describe Clusters::Applications::PrometheusConfigService do include Gitlab::Routing.url_helpers let_it_be(:project) { create(:project) } diff --git a/spec/services/clusters/applications/prometheus_health_check_service_spec.rb b/spec/services/clusters/applications/prometheus_health_check_service_spec.rb index 5c4127e493849e646e1511b7c08f8477a7bbd16a..fc5a80688e6f574568d04c4a9ad6048a11389b07 100644 --- a/spec/services/clusters/applications/prometheus_health_check_service_spec.rb +++ b/spec/services/clusters/applications/prometheus_health_check_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Applications::PrometheusHealthCheckService, '#execute' do +RSpec.describe Clusters::Applications::PrometheusHealthCheckService, '#execute' do let(:service) { described_class.new(cluster) } subject { service.execute } diff --git a/spec/services/clusters/applications/prometheus_update_service_spec.rb b/spec/services/clusters/applications/prometheus_update_service_spec.rb index 078b01d2777c78fb1b643751ea58501a3d3a8d68..076ff0210c9836e955124fd6dee9eb2ea21df855 100644 --- a/spec/services/clusters/applications/prometheus_update_service_spec.rb +++ b/spec/services/clusters/applications/prometheus_update_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Applications::PrometheusUpdateService do +RSpec.describe Clusters::Applications::PrometheusUpdateService do describe '#execute' do let(:project) { create(:project) } let(:environment) { create(:environment, project: project) } diff --git a/spec/services/clusters/applications/schedule_update_service_spec.rb b/spec/services/clusters/applications/schedule_update_service_spec.rb index eb1006ce8e00eb8b8fa147931ff179cb4e9470d8..f559fb1b7aa939f595a09b9def7d5ec79023f079 100644 --- a/spec/services/clusters/applications/schedule_update_service_spec.rb +++ b/spec/services/clusters/applications/schedule_update_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Applications::ScheduleUpdateService do +RSpec.describe Clusters::Applications::ScheduleUpdateService do describe '#execute' do let(:project) { create(:project) } diff --git a/spec/services/clusters/applications/uninstall_service_spec.rb b/spec/services/clusters/applications/uninstall_service_spec.rb index 6d7f0478b2093e8ca98ba8299061b6e3d1987153..50d7e82c47ece57a18aa0947af3ae2175c66f327 100644 --- a/spec/services/clusters/applications/uninstall_service_spec.rb +++ b/spec/services/clusters/applications/uninstall_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Applications::UninstallService, '#execute' do +RSpec.describe Clusters::Applications::UninstallService, '#execute' do let(:application) { create(:clusters_applications_prometheus, :scheduled) } let(:service) { described_class.new(application) } let(:helm_client) { instance_double(Gitlab::Kubernetes::Helm::API) } diff --git a/spec/services/clusters/applications/update_service_spec.rb b/spec/services/clusters/applications/update_service_spec.rb index 4676951faff123768a7c6bb43d1aa9dffffb6283..4c05a12a4a1a79f04a386305ac274d8c68446af2 100644 --- a/spec/services/clusters/applications/update_service_spec.rb +++ b/spec/services/clusters/applications/update_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Applications::UpdateService do +RSpec.describe Clusters::Applications::UpdateService do include TestRequestHelpers let(:cluster) { create(:cluster, :project, :provided_by_gcp) } diff --git a/spec/services/clusters/applications/upgrade_service_spec.rb b/spec/services/clusters/applications/upgrade_service_spec.rb index 86fb06375f189cbe212c01ccbe1a91523972023d..22fbb7ca6e30e01174818a456d4766ffc9881a03 100644 --- a/spec/services/clusters/applications/upgrade_service_spec.rb +++ b/spec/services/clusters/applications/upgrade_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Applications::UpgradeService do +RSpec.describe Clusters::Applications::UpgradeService do describe '#execute' do let(:application) { create(:clusters_applications_helm, :scheduled) } let!(:install_command) { application.install_command } diff --git a/spec/services/clusters/aws/authorize_role_service_spec.rb b/spec/services/clusters/aws/authorize_role_service_spec.rb index 3ef332558a2eb070364c65366fd3bbd80fce1a09..530268340b7eaca42abdd2d02e7928d6c6019227 100644 --- a/spec/services/clusters/aws/authorize_role_service_spec.rb +++ b/spec/services/clusters/aws/authorize_role_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Aws::AuthorizeRoleService do +RSpec.describe Clusters::Aws::AuthorizeRoleService do let(:user) { create(:user) } let(:credentials) { instance_double(Aws::Credentials) } let(:credentials_service) { instance_double(Clusters::Aws::FetchCredentialsService, execute: credentials) } diff --git a/spec/services/clusters/aws/fetch_credentials_service_spec.rb b/spec/services/clusters/aws/fetch_credentials_service_spec.rb index 9194947c67f5fca8f5bfb9fb1830c7b4d4de415a..a0e63d96a5cd1e52cd6ea13cdc8fbc995ea967ab 100644 --- a/spec/services/clusters/aws/fetch_credentials_service_spec.rb +++ b/spec/services/clusters/aws/fetch_credentials_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Aws::FetchCredentialsService do +RSpec.describe Clusters::Aws::FetchCredentialsService do describe '#execute' do let(:user) { create(:user) } let(:provider) { create(:cluster_provider_aws, region: 'ap-southeast-2') } diff --git a/spec/services/clusters/aws/finalize_creation_service_spec.rb b/spec/services/clusters/aws/finalize_creation_service_spec.rb index 8d7341483e30955478016b41f3fd10ef20e967d0..6b0cb86eff035a404a23fd3f46dc0076c2cdaca7 100644 --- a/spec/services/clusters/aws/finalize_creation_service_spec.rb +++ b/spec/services/clusters/aws/finalize_creation_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Aws::FinalizeCreationService do +RSpec.describe Clusters::Aws::FinalizeCreationService do describe '#execute' do let(:provider) { create(:cluster_provider_aws, :creating) } let(:platform) { provider.cluster.platform_kubernetes } diff --git a/spec/services/clusters/aws/provision_service_spec.rb b/spec/services/clusters/aws/provision_service_spec.rb index 15571c64e13bf0ab942e290cfe602ffa666e2d9e..529e1d26575f7b8d0d034880bfbdbb78a3060b66 100644 --- a/spec/services/clusters/aws/provision_service_spec.rb +++ b/spec/services/clusters/aws/provision_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Aws::ProvisionService do +RSpec.describe Clusters::Aws::ProvisionService do describe '#execute' do let(:provider) { create(:cluster_provider_aws) } diff --git a/spec/services/clusters/aws/verify_provision_status_service_spec.rb b/spec/services/clusters/aws/verify_provision_status_service_spec.rb index b62b0875bf32d19c3f91324e8bf490a9314e6c76..b9a58b97842ff338815843347e2c9ab815916c3e 100644 --- a/spec/services/clusters/aws/verify_provision_status_service_spec.rb +++ b/spec/services/clusters/aws/verify_provision_status_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Aws::VerifyProvisionStatusService do +RSpec.describe Clusters::Aws::VerifyProvisionStatusService do describe '#execute' do let(:provider) { create(:cluster_provider_aws) } diff --git a/spec/services/clusters/build_kubernetes_namespace_service_spec.rb b/spec/services/clusters/build_kubernetes_namespace_service_spec.rb index 36c0546954251a30e7108185a5d8b5ce3b2e3fab..4ee933374f63bb28b33469cb4ed538a8a1cedd06 100644 --- a/spec/services/clusters/build_kubernetes_namespace_service_spec.rb +++ b/spec/services/clusters/build_kubernetes_namespace_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::BuildKubernetesNamespaceService do +RSpec.describe Clusters::BuildKubernetesNamespaceService do let(:cluster) { create(:cluster, :project, :provided_by_gcp) } let(:environment) { create(:environment) } let(:project) { environment.project } diff --git a/spec/services/clusters/build_service_spec.rb b/spec/services/clusters/build_service_spec.rb index f3e852726f4ca67a4d7b364bc4a421750e1af9f7..c7a64435d3b2b1bd9c71bddfb5ee615bd83c39a9 100644 --- a/spec/services/clusters/build_service_spec.rb +++ b/spec/services/clusters/build_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::BuildService do +RSpec.describe Clusters::BuildService do describe '#execute' do subject { described_class.new(cluster_subject).execute } diff --git a/spec/services/clusters/cleanup/app_service_spec.rb b/spec/services/clusters/cleanup/app_service_spec.rb index 14bfca02fee2b7129df543c298aca85b8933b80c..ba1be7448a4412537fe1f5692d311589f5bc87d8 100644 --- a/spec/services/clusters/cleanup/app_service_spec.rb +++ b/spec/services/clusters/cleanup/app_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Cleanup::AppService do +RSpec.describe Clusters::Cleanup::AppService do describe '#execute' do let!(:cluster) { create(:cluster, :project, :cleanup_uninstalling_applications, provider_type: :gcp) } let(:service) { described_class.new(cluster) } diff --git a/spec/services/clusters/cleanup/project_namespace_service_spec.rb b/spec/services/clusters/cleanup/project_namespace_service_spec.rb index 22e29cc57d1c109de6e4469d4a9aa6eb7c839cbd..761ad8dd8c8bc85b21f65d7f04a00ccd5cf7c87c 100644 --- a/spec/services/clusters/cleanup/project_namespace_service_spec.rb +++ b/spec/services/clusters/cleanup/project_namespace_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Cleanup::ProjectNamespaceService do +RSpec.describe Clusters::Cleanup::ProjectNamespaceService do describe '#execute' do subject { service.execute } diff --git a/spec/services/clusters/cleanup/service_account_service_spec.rb b/spec/services/clusters/cleanup/service_account_service_spec.rb index ecaf0da9fa3f8abd0830401173a32c6d7322a505..6fe3d0c286eebfaa8a596b0f795d52c197df934b 100644 --- a/spec/services/clusters/cleanup/service_account_service_spec.rb +++ b/spec/services/clusters/cleanup/service_account_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Cleanup::ServiceAccountService do +RSpec.describe Clusters::Cleanup::ServiceAccountService do describe '#execute' do subject { service.execute } diff --git a/spec/services/clusters/create_service_spec.rb b/spec/services/clusters/create_service_spec.rb index 3dd25be2a3d78c9e968f51cc0e36b5e546c9d323..d45749b52d082e964dd6157f427a9fbfce35cbc2 100644 --- a/spec/services/clusters/create_service_spec.rb +++ b/spec/services/clusters/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::CreateService do +RSpec.describe Clusters::CreateService do let(:access_token) { 'xxx' } let(:project) { create(:project) } let(:user) { create(:user) } diff --git a/spec/services/clusters/destroy_service_spec.rb b/spec/services/clusters/destroy_service_spec.rb index 43ebf8f499e32e6cd729d6fe42052fdcd6a5fc97..76d9cc34b5d16908ed0beca8eed8179051f41d34 100644 --- a/spec/services/clusters/destroy_service_spec.rb +++ b/spec/services/clusters/destroy_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::DestroyService do +RSpec.describe Clusters::DestroyService do describe '#execute' do subject { described_class.new(cluster.user, params).execute(cluster) } diff --git a/spec/services/clusters/gcp/fetch_operation_service_spec.rb b/spec/services/clusters/gcp/fetch_operation_service_spec.rb index 23da8004a7d273e0c933356439552547c03c458d..990cc7453826f766704c32bcdd9ea8007f9d88ea 100644 --- a/spec/services/clusters/gcp/fetch_operation_service_spec.rb +++ b/spec/services/clusters/gcp/fetch_operation_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Gcp::FetchOperationService do +RSpec.describe Clusters::Gcp::FetchOperationService do include GoogleApi::CloudPlatformHelpers describe '#execute' do diff --git a/spec/services/clusters/gcp/finalize_creation_service_spec.rb b/spec/services/clusters/gcp/finalize_creation_service_spec.rb index 4d1548c9786602d678f87c7b96e87e5472e9d891..be362dc6e23c8e4edae4c0fc700f7f5047544947 100644 --- a/spec/services/clusters/gcp/finalize_creation_service_spec.rb +++ b/spec/services/clusters/gcp/finalize_creation_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Gcp::FinalizeCreationService, '#execute' do +RSpec.describe Clusters::Gcp::FinalizeCreationService, '#execute' do include GoogleApi::CloudPlatformHelpers include KubernetesHelpers diff --git a/spec/services/clusters/gcp/provision_service_spec.rb b/spec/services/clusters/gcp/provision_service_spec.rb index dfd15690a1f535a6e7b418628cc3a6ed0c713213..c5778db6001b72fa895495810beb0f14310f0c7e 100644 --- a/spec/services/clusters/gcp/provision_service_spec.rb +++ b/spec/services/clusters/gcp/provision_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Gcp::ProvisionService do +RSpec.describe Clusters::Gcp::ProvisionService do include GoogleApi::CloudPlatformHelpers describe '#execute' do diff --git a/spec/services/clusters/gcp/verify_provision_status_service_spec.rb b/spec/services/clusters/gcp/verify_provision_status_service_spec.rb index 584f9b8367ff77a0e4c1d8c674373286d5d52977..ccb4b3b6c15a546db4347542815b98a814275357 100644 --- a/spec/services/clusters/gcp/verify_provision_status_service_spec.rb +++ b/spec/services/clusters/gcp/verify_provision_status_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Gcp::VerifyProvisionStatusService do +RSpec.describe Clusters::Gcp::VerifyProvisionStatusService do include GoogleApi::CloudPlatformHelpers describe '#execute' do diff --git a/spec/services/clusters/kubernetes/configure_istio_ingress_service_spec.rb b/spec/services/clusters/kubernetes/configure_istio_ingress_service_spec.rb index e9f7f01529378fedfb9861959a893ddf336b0aa3..b4402aadc88a7f0f61749615375d43bbdbfa180b 100644 --- a/spec/services/clusters/kubernetes/configure_istio_ingress_service_spec.rb +++ b/spec/services/clusters/kubernetes/configure_istio_ingress_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Kubernetes::ConfigureIstioIngressService, '#execute' do +RSpec.describe Clusters::Kubernetes::ConfigureIstioIngressService, '#execute' do include KubernetesHelpers let(:cluster) { create(:cluster, :project, :provided_by_gcp) } diff --git a/spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb b/spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb index 6d8b1617c17686712fabba2ff098c8b436634a16..ee10c59390e09dbb2b51b239e915c3a67d6f5482 100644 --- a/spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb +++ b/spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Kubernetes::CreateOrUpdateNamespaceService, '#execute' do +RSpec.describe Clusters::Kubernetes::CreateOrUpdateNamespaceService, '#execute' do include KubernetesHelpers let(:cluster) { create(:cluster, :project, :provided_by_gcp) } diff --git a/spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb b/spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb index 4bcd5c6933e7c6d3e5e6a49b46a446144bc3389e..f3fa6c2c0bbec7ffcd938747ea082c7f8f48de91 100644 --- a/spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb +++ b/spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe Clusters::Kubernetes::CreateOrUpdateServiceAccountService do +RSpec.describe Clusters::Kubernetes::CreateOrUpdateServiceAccountService do include KubernetesHelpers let(:api_url) { 'http://111.111.111.111' } diff --git a/spec/services/clusters/kubernetes/fetch_kubernetes_token_service_spec.rb b/spec/services/clusters/kubernetes/fetch_kubernetes_token_service_spec.rb index fa4b6e497e5345bcd04351713e3af090f819ef20..c4daae9dbf03fb13f91f6b144531a315e5ef9693 100644 --- a/spec/services/clusters/kubernetes/fetch_kubernetes_token_service_spec.rb +++ b/spec/services/clusters/kubernetes/fetch_kubernetes_token_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Kubernetes::FetchKubernetesTokenService do +RSpec.describe Clusters::Kubernetes::FetchKubernetesTokenService do include KubernetesHelpers describe '#execute' do diff --git a/spec/services/clusters/kubernetes_spec.rb b/spec/services/clusters/kubernetes_spec.rb index 09cc304debefe29d92e0e6b65c56db2e0a992187..12af63890fc0738a5539ea370d543e42c2ea4329 100644 --- a/spec/services/clusters/kubernetes_spec.rb +++ b/spec/services/clusters/kubernetes_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Kubernetes do +RSpec.describe Clusters::Kubernetes do it { is_expected.to be_const_defined(:GITLAB_SERVICE_ACCOUNT_NAME) } it { is_expected.to be_const_defined(:GITLAB_SERVICE_ACCOUNT_NAMESPACE) } it { is_expected.to be_const_defined(:GITLAB_ADMIN_TOKEN_NAME) } diff --git a/spec/services/clusters/management/create_project_service_spec.rb b/spec/services/clusters/management/create_project_service_spec.rb index b7764b7840c8309bd1937276e6d7ed56fb57250e..5d8cc71faa426467c3687ea9b68c074dea7f4906 100644 --- a/spec/services/clusters/management/create_project_service_spec.rb +++ b/spec/services/clusters/management/create_project_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Management::CreateProjectService do +RSpec.describe Clusters::Management::CreateProjectService do let(:cluster) { create(:cluster, :project) } let(:current_user) { create(:user) } diff --git a/spec/services/clusters/management/validate_management_project_permissions_service_spec.rb b/spec/services/clusters/management/validate_management_project_permissions_service_spec.rb index 1bcebe2e2ac051da769195a03f0e43c9d2273680..a21c378d3d157f2438545e9efd9edb1159ac2d45 100644 --- a/spec/services/clusters/management/validate_management_project_permissions_service_spec.rb +++ b/spec/services/clusters/management/validate_management_project_permissions_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::Management::ValidateManagementProjectPermissionsService do +RSpec.describe Clusters::Management::ValidateManagementProjectPermissionsService do describe '#execute' do subject { described_class.new(user).execute(cluster, management_project_id) } diff --git a/spec/services/clusters/parse_cluster_applications_artifact_service_spec.rb b/spec/services/clusters/parse_cluster_applications_artifact_service_spec.rb index bb0b107eba631cf6cab16ea64331395d200aa623..f13aa73554e55291f161b9673fbb2c6b9f810558 100644 --- a/spec/services/clusters/parse_cluster_applications_artifact_service_spec.rb +++ b/spec/services/clusters/parse_cluster_applications_artifact_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::ParseClusterApplicationsArtifactService do +RSpec.describe Clusters::ParseClusterApplicationsArtifactService do let_it_be(:project) { create(:project) } let_it_be(:user) { create(:user) } diff --git a/spec/services/clusters/update_service_spec.rb b/spec/services/clusters/update_service_spec.rb index 5a7726eded84adc43b64cc4d7ac61703493baf78..e496ccd5c234a03da7e88295d32ae9a734c9a466 100644 --- a/spec/services/clusters/update_service_spec.rb +++ b/spec/services/clusters/update_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Clusters::UpdateService do +RSpec.describe Clusters::UpdateService do include KubernetesHelpers describe '#execute' do diff --git a/spec/services/cohorts_service_spec.rb b/spec/services/cohorts_service_spec.rb index b2f82a1153cf6394207557438d2eebc78aae7a0a..dce8d4f80f2009f71bd0fbe27408ea3b7a3ec671 100644 --- a/spec/services/cohorts_service_spec.rb +++ b/spec/services/cohorts_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe CohortsService do +RSpec.describe CohortsService do describe '#execute' do def month_start(months_ago) months_ago.months.ago.beginning_of_month.to_date diff --git a/spec/services/commits/cherry_pick_service_spec.rb b/spec/services/commits/cherry_pick_service_spec.rb index 3b797b8ac02232d6bf5aa93db6df1095e4e3abd1..8fad5164b77733763aa820437491da7b55905f7e 100644 --- a/spec/services/commits/cherry_pick_service_spec.rb +++ b/spec/services/commits/cherry_pick_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Commits::CherryPickService do +RSpec.describe Commits::CherryPickService do let(:project) { create(:project, :repository) } # * ddd0f15ae83993f5cb66a927a28673882e99100b (HEAD -> master, origin/master, origin/HEAD) Merge branch 'po-fix-test-en # |\ diff --git a/spec/services/commits/commit_patch_service_spec.rb b/spec/services/commits/commit_patch_service_spec.rb index f4fcec2fbc227c2205cd1cd071ebf19d3d2befa9..c8c0cbe23b29903f10503030b918df47629b91cd 100644 --- a/spec/services/commits/commit_patch_service_spec.rb +++ b/spec/services/commits/commit_patch_service_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe Commits::CommitPatchService do +RSpec.describe Commits::CommitPatchService do describe '#execute' do let(:patches) do patches_folder = Rails.root.join('spec/fixtures/patchfiles') diff --git a/spec/services/commits/tag_service_spec.rb b/spec/services/commits/tag_service_spec.rb index 82377a8dace73b185e941b261326a6f099594fd5..dd742ebe469c77e2a8e5b21069da44757cb6f016 100644 --- a/spec/services/commits/tag_service_spec.rb +++ b/spec/services/commits/tag_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Commits::TagService do +RSpec.describe Commits::TagService do let(:project) { create(:project, :repository) } let(:user) { create(:user) } diff --git a/spec/services/compare_service_spec.rb b/spec/services/compare_service_spec.rb index f6d8eb348d02820618c71c294b06c238431cdcbd..e96a7f2f4f46077e277e2342aa51df05f41ae9ba 100644 --- a/spec/services/compare_service_spec.rb +++ b/spec/services/compare_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe CompareService do +RSpec.describe CompareService do let(:project) { create(:project, :repository) } let(:user) { create(:user) } let(:service) { described_class.new(project, 'feature') } diff --git a/spec/services/concerns/merge_requests/assigns_merge_params_spec.rb b/spec/services/concerns/merge_requests/assigns_merge_params_spec.rb index 9cf7f354191d468c3015ca10cafb5ec3d380c3a6..5b1e8fca31b5f110b4c7a3798a03425293ce308f 100644 --- a/spec/services/concerns/merge_requests/assigns_merge_params_spec.rb +++ b/spec/services/concerns/merge_requests/assigns_merge_params_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe MergeRequests::AssignsMergeParams do +RSpec.describe MergeRequests::AssignsMergeParams do it 'raises an error when used from an instance that does not respond to #current_user' do define_class = -> { Class.new { include MergeRequests::AssignsMergeParams }.new } diff --git a/spec/services/container_expiration_policy_service_spec.rb b/spec/services/container_expiration_policy_service_spec.rb index 97715b990efe8881fac95f5fed31aa88215a4bf5..dfce51d73add54041b322004b2a4c0f8cddb59f8 100644 --- a/spec/services/container_expiration_policy_service_spec.rb +++ b/spec/services/container_expiration_policy_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe ContainerExpirationPolicyService do +RSpec.describe ContainerExpirationPolicyService do let_it_be(:user) { create(:user) } let_it_be(:container_expiration_policy) { create(:container_expiration_policy, :runnable) } let(:project) { container_expiration_policy.project } diff --git a/spec/services/deploy_keys/create_service_spec.rb b/spec/services/deploy_keys/create_service_spec.rb index a55f1561194aff4d56be5e67cdddd811cb939b39..2e3318236f50c344c91a6d956ad91b3f91f2d0d4 100644 --- a/spec/services/deploy_keys/create_service_spec.rb +++ b/spec/services/deploy_keys/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DeployKeys::CreateService do +RSpec.describe DeployKeys::CreateService do let(:user) { create(:user) } let(:params) { attributes_for(:deploy_key) } diff --git a/spec/services/deployments/after_create_service_spec.rb b/spec/services/deployments/after_create_service_spec.rb index 5a69ffd8b9cb0951129a0e9c125d30f3000e82a3..3287eed03b7cd9dbf24adf93a911e10c2760442a 100644 --- a/spec/services/deployments/after_create_service_spec.rb +++ b/spec/services/deployments/after_create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Deployments::AfterCreateService do +RSpec.describe Deployments::AfterCreateService do let(:user) { create(:user) } let(:project) { create(:project, :repository) } let(:options) { { name: 'production' } } diff --git a/spec/services/deployments/create_service_spec.rb b/spec/services/deployments/create_service_spec.rb index 6ab1f8635f7b3d33568f49e0d7ee89d6c4af42ab..d1f977c28d3c995e5041178b85895717d3b689a9 100644 --- a/spec/services/deployments/create_service_spec.rb +++ b/spec/services/deployments/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Deployments::CreateService do +RSpec.describe Deployments::CreateService do let(:user) { create(:user) } describe '#execute' do diff --git a/spec/services/deployments/link_merge_requests_service_spec.rb b/spec/services/deployments/link_merge_requests_service_spec.rb index aa2cecbf89741f2972cb19fe9bd915b3fe55b049..e2ac2273b8c9e5cdb0ef411ce7204fe1ad883698 100644 --- a/spec/services/deployments/link_merge_requests_service_spec.rb +++ b/spec/services/deployments/link_merge_requests_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Deployments::LinkMergeRequestsService do +RSpec.describe Deployments::LinkMergeRequestsService do let(:project) { create(:project, :repository) } # * ddd0f15 Merge branch 'po-fix-test-env-path' into 'master' diff --git a/spec/services/deployments/older_deployments_drop_service_spec.rb b/spec/services/deployments/older_deployments_drop_service_spec.rb index 4c9bcf90533e554201ebdad0695237943b1c359a..6152a95cc3cc28416f071d359cfadfb7172204ab 100644 --- a/spec/services/deployments/older_deployments_drop_service_spec.rb +++ b/spec/services/deployments/older_deployments_drop_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Deployments::OlderDeploymentsDropService do +RSpec.describe Deployments::OlderDeploymentsDropService do let(:environment) { create(:environment) } let(:deployment) { create(:deployment, environment: environment) } let(:service) { described_class.new(deployment) } diff --git a/spec/services/deployments/update_service_spec.rb b/spec/services/deployments/update_service_spec.rb index 471e90de4676f2ef29425d946b137726b50c5218..16b24d0dee849e4e3afd8b94edab79acd8cf088c 100644 --- a/spec/services/deployments/update_service_spec.rb +++ b/spec/services/deployments/update_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Deployments::UpdateService do +RSpec.describe Deployments::UpdateService do let(:deploy) { create(:deployment) } describe '#execute' do diff --git a/spec/services/design_management/delete_designs_service_spec.rb b/spec/services/design_management/delete_designs_service_spec.rb index bf5d6b443e6fb4c5c9b8455c29469ea20a2e2b92..ace63b6e59c4fdd0a906a288414969e4a38bea13 100644 --- a/spec/services/design_management/delete_designs_service_spec.rb +++ b/spec/services/design_management/delete_designs_service_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'spec_helper' -describe DesignManagement::DeleteDesignsService do +RSpec.describe DesignManagement::DeleteDesignsService do include DesignManagementTestHelpers let_it_be(:project) { create(:project) } diff --git a/spec/services/design_management/design_user_notes_count_service_spec.rb b/spec/services/design_management/design_user_notes_count_service_spec.rb index 62211a4dd0fa1888ddb13ed920be73c8a73de3a3..37806d3461c8e1d8ea7a642c6dde629f74b1d201 100644 --- a/spec/services/design_management/design_user_notes_count_service_spec.rb +++ b/spec/services/design_management/design_user_notes_count_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe DesignManagement::DesignUserNotesCountService, :use_clean_rails_memory_store_caching do +RSpec.describe DesignManagement::DesignUserNotesCountService, :use_clean_rails_memory_store_caching do let_it_be(:design) { create(:design, :with_file) } subject { described_class.new(design) }