From dbaf7621ee1db8856e8d5dc0a5d29465434ec2b7 Mon Sep 17 00:00:00 2001
From: Anshul Riyal <anshulriyal00@gmail.com>
Date: Mon, 9 May 2022 00:23:34 +0530
Subject: [PATCH] Move Performance/CollectionLiteralInLoop into separate TODO
file
Changelog: other
---
.rubocop_todo.yml | 5 ---
.../collection_literal_in_loop.yml | 38 +++++++++++++++++++
2 files changed, 38 insertions(+), 5 deletions(-)
create mode 100644 .rubocop_todo/performance/collection_literal_in_loop.yml
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index e4db93d1602b2..836cf511219c4 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -11,11 +11,6 @@ Gitlab/PolicyRuleBoolean:
Exclude:
- 'ee/app/policies/ee/identity_provider_policy.rb'
-# Offense count: 29
-# Configuration parameters: MinSize.
-Performance/CollectionLiteralInLoop:
- Enabled: false
-
# Offense count: 41
# Cop supports --auto-correct.
Performance/ConstantRegexp:
diff --git a/.rubocop_todo/performance/collection_literal_in_loop.yml b/.rubocop_todo/performance/collection_literal_in_loop.yml
new file mode 100644
index 0000000000000..4b012bf664576
--- /dev/null
+++ b/.rubocop_todo/performance/collection_literal_in_loop.yml
@@ -0,0 +1,38 @@
+---
+Performance/CollectionLiteralInLoop:
+ # Offense count: 45
+ # Temporarily disabled due to too many offenses
+ Enabled: false
+ Exclude:
+ - 'config/application.rb'
+ - 'config/initializers/1_settings.rb'
+ - 'ee/app/models/ee/merge_request.rb'
+ - 'ee/spec/features/admin/admin_settings_spec.rb'
+ - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb'
+ - 'ee/spec/workers/app_sec/dast/profile_schedule_worker_spec.rb'
+ - 'ee/spec/workers/security/orchestration_policy_rule_schedule_worker_spec.rb'
+ - 'lib/gitlab/fake_application_settings.rb'
+ - 'lib/gitlab/otp_key_rotator.rb'
+ - 'lib/gitlab/reference_extractor.rb'
+ - 'lib/gitlab/sidekiq_middleware/server_metrics.rb'
+ - 'lib/gitlab/tracking/incident_management.rb'
+ - 'lib/quality/seeders/issues.rb'
+ - 'lib/tasks/gitlab/seed/group_seed.rake'
+ - 'spec/bin/sidekiq_cluster_spec.rb'
+ - 'spec/controllers/groups_controller_spec.rb'
+ - 'spec/lib/banzai/reference_parser/base_parser_spec.rb'
+ - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb'
+ - 'spec/lib/gitlab/file_detector_spec.rb'
+ - 'spec/lib/gitlab/search/abuse_detection_spec.rb'
+ - 'spec/lib/gitlab/utils/markdown_spec.rb'
+ - 'spec/models/analytics/cycle_analytics/aggregation_spec.rb'
+ - 'spec/models/ci/build_spec.rb'
+ - 'spec/models/ci/pipeline_spec.rb'
+ - 'spec/models/namespace_statistics_spec.rb'
+ - 'spec/presenters/ci/build_runner_presenter_spec.rb'
+ - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb'
+ - 'spec/presenters/packages/nuget/service_index_presenter_spec.rb'
+ - 'spec/requests/api/ci/pipelines_spec.rb'
+ - 'spec/requests/api/integrations_spec.rb'
+ - 'spec/requests/api/project_container_repositories_spec.rb'
+ - 'spec/support/shared_examples/models/email_format_shared_examples.rb'
--
GitLab