diff --git a/scripts/frontend/quarantined_vue3_specs.txt b/scripts/frontend/quarantined_vue3_specs.txt index 0c6343a2682a99cc12f6d118f80b6a91ca08983b..a32b468c0bce2083af19b92da271ebdbafc3057f 100644 --- a/scripts/frontend/quarantined_vue3_specs.txt +++ b/scripts/frontend/quarantined_vue3_specs.txt @@ -166,7 +166,6 @@ spec/frontend/ml/model_registry/apps/show_ml_model_spec.js spec/frontend/ml/model_registry/components/candidate_detail_spec.js spec/frontend/ml/model_registry/components/model_edit_spec.js spec/frontend/ml/model_registry/components/model_version_create_spec.js -spec/frontend/notebook/cells/markdown_spec.js spec/frontend/notes/components/discussion_notes_spec.js spec/frontend/packages_and_registries/container_registry/explorer/components/list_page/image_list_row_spec.js spec/frontend/packages_and_registries/dependency_proxy/app_spec.js diff --git a/spec/frontend/notebook/cells/markdown_spec.js b/spec/frontend/notebook/cells/markdown_spec.js index ff1b59158e51ff93949cedeea312e11fc0590cc0..f7211b2343b53885eb4cb705bc462490585184e5 100644 --- a/spec/frontend/notebook/cells/markdown_spec.js +++ b/spec/frontend/notebook/cells/markdown_spec.js @@ -80,26 +80,26 @@ describe('Markdown component', () => { expect(wrapper.vm.$el.querySelector('.markdown h1')).not.toBeNull(); }); - it('sanitizes Markdown output', async () => { - Object.assign(cell, { + it('sanitizes Markdown output', () => { + wrapper = buildCellComponent({ + cell_type: 'markdown', source: [ '[XSS](data:text/html;base64,PHNjcmlwdD5hbGVydChkb2N1bWVudC5kb21haW4pPC9zY3JpcHQ+Cg==)\n', ], }); - await nextTick(); - expect(wrapper.vm.$el.querySelector('a').getAttribute('href')).toBeNull(); + expect(wrapper.find('a').attributes('href')).toBeUndefined(); }); - it('sanitizes HTML', async () => { - const findLink = () => wrapper.vm.$el.querySelector('.xss-link'); - Object.assign(cell, { + it('sanitizes HTML', () => { + wrapper = buildCellComponent({ + cell_type: 'markdown', source: ['<a href="test.js" data-remote=true data-type="script" class="xss-link">XSS</a>\n'], }); - await nextTick(); - expect(findLink().dataset.remote).toBeUndefined(); - expect(findLink().dataset.type).toBeUndefined(); + const sanitizedLinkAttributes = wrapper.find('.xss-link').attributes(); + expect(sanitizedLinkAttributes['data-remote']).toBeUndefined(); + expect(sanitizedLinkAttributes['data-type']).toBeUndefined(); }); describe('When parsing images', () => {