From daf5913c94d07522942ca54e2ce6f0bcf4b4d9a6 Mon Sep 17 00:00:00 2001
From: Jay McCure <jmccure@gitlab.com>
Date: Tue, 6 Feb 2024 15:52:48 +1000
Subject: [PATCH] E2E test: [PROMOTE TO BLOCKING] Create Push Rules
---
.../3_create/repository/push_rules_spec.rb | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb b/qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb
index 3ab38448edfdb..bded64661572b 100644
--- a/qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb
@@ -29,11 +29,11 @@ module QA
end
end
- it 'allows an unrestricted push', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347790' do
+ it 'allows an unrestricted push', :blocking, testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347790' do
expect_no_error_on_push(file: standard_file)
end
- it 'restricts files by name and size', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347784' do
+ it 'restricts files by name and size', :blocking, testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347784' do
# Note: The file size limits in this test should be lower than the limits in
# browser_ui/3_create/repository/push_over_http_file_size_spec to prevent
# the limit set in that test from triggering in this test (which can happen
@@ -67,14 +67,14 @@ module QA
error: Regexp.escape("Committer's email '#{gitlab_user.email}' does not follow the pattern '#{@authors_email_limitation}'"))
end
- it 'restricts branches by branch name', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347781' do
+ it 'restricts branches by branch name', :blocking, testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347781' do
expect_error_on_push(
file: standard_file,
branch: 'forbidden_branch',
error: Regexp.escape("Branch name 'forbidden_branch' does not follow the pattern '#{@branch_name_limitation}'"))
end
- it 'restricts commit by message format', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347780' do
+ it 'restricts commit by message format', :blocking, testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347780' do
expect_no_error_on_push(file: standard_file, commit_message: @needed_phrase_limitation)
expect_error_on_push(
file: standard_file,
@@ -86,7 +86,7 @@ module QA
error: Regexp.escape("Commit message contains the forbidden pattern '#{@deny_message_phrase_limitation}'"))
end
- it 'restricts committing files with secrets', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347779' do
+ it 'restricts committing files with secrets', :blocking, testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347779' do
secret_file = [{
name: 'id_rsa',
content: SecureRandom.hex(100)
@@ -116,7 +116,7 @@ module QA
end
end
- it 'rejects non-member users', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347812' do
+ it 'rejects non-member users', :blocking, testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347812' do
non_member_user = build(:user,
username: '',
password: '',
--
GitLab