From d419ad11cc4f97570b094469cb40ead3c124d4d0 Mon Sep 17 00:00:00 2001 From: syasonik <syasonik@gitlab.com> Date: Fri, 31 Jan 2025 12:55:55 -0500 Subject: [PATCH] Add default category for shared example --- .../internal_event_instrumentation/quick_start.md | 1 + scripts/internal_events/cli/flows/usage_viewer.rb | 1 + spec/scripts/internal_events/cli/flows/usage_viewer_spec.rb | 4 ++++ 3 files changed, 6 insertions(+) diff --git a/doc/development/internal_analytics/internal_event_instrumentation/quick_start.md b/doc/development/internal_analytics/internal_event_instrumentation/quick_start.md index 319cdda910f8..174fd48b73e8 100644 --- a/doc/development/internal_analytics/internal_event_instrumentation/quick_start.md +++ b/doc/development/internal_analytics/internal_event_instrumentation/quick_start.md @@ -197,6 +197,7 @@ you can use the `internal_event_tracking` shared example. ```ruby it_behaves_like 'internal event tracking' do let(:event) { 'update_issue_severity' } + let(:category) { described_class.name } let(:project) { issue.project } let(:user) { issue.author } let(:additional_properties) { { label: issue.issueable_severity } } diff --git a/scripts/internal_events/cli/flows/usage_viewer.rb b/scripts/internal_events/cli/flows/usage_viewer.rb index e131bbf4ffa3..d7752e828b8d 100755 --- a/scripts/internal_events/cli/flows/usage_viewer.rb +++ b/scripts/internal_events/cli/flows/usage_viewer.rb @@ -157,6 +157,7 @@ def rspec_examples it_behaves_like 'internal event tracking' do let(:event) { '#{action}' } + let(:category) { described_class.name } #{args}end #{divider} diff --git a/spec/scripts/internal_events/cli/flows/usage_viewer_spec.rb b/spec/scripts/internal_events/cli/flows/usage_viewer_spec.rb index b474498ce2ae..919a927a6778 100644 --- a/spec/scripts/internal_events/cli/flows/usage_viewer_spec.rb +++ b/spec/scripts/internal_events/cli/flows/usage_viewer_spec.rb @@ -53,6 +53,7 @@ it_behaves_like 'internal event tracking' do let(:event) { 'internal_events_cli_used' } + let(:category) { described_class.name } let(:project) { create(:project) } let(:user) { create(:user) } end @@ -156,6 +157,7 @@ it_behaves_like 'internal event tracking' do let(:event) { 'internal_events_cli_used' } + let(:category) { described_class.name } let(:project) { create(:project) } let(:user) { create(:user) } end @@ -257,6 +259,7 @@ it_behaves_like 'internal event tracking' do let(:event) { 'internal_events_cli_opened' } + let(:category) { described_class.name } end -------------------------------------------------- @@ -557,6 +560,7 @@ it_behaves_like 'internal event tracking' do let(:event) { 'internal_events_cli_used' } + let(:category) { described_class.name } let(:project) { create(:project) } let(:user) { create(:user) } let(:additional_properties) do -- GitLab