From d0f23dd0f8b5d9bdc1a0d98bc1aa83719d93cd01 Mon Sep 17 00:00:00 2001 From: Dylan Griffith <dyl.griffith@gmail.com> Date: Wed, 17 Jul 2024 16:20:12 +1000 Subject: [PATCH] Do not link to housekeeper feedback issue anymore instead use label This updates the default commit message and MR description for housekeeper MRs to no longer include a link to the feedback issue. This linked feedback issue has become too difficult to load as it has hundreds of mentions. It's not really serving it's purpose and a label and a ping is likely to be just as good for communicating feedback. --- .../lib/gitlab/housekeeper/change.rb | 4 ++-- .../spec/gitlab/housekeeper/change_spec.rb | 16 ++++++++-------- .../spec/gitlab/housekeeper/git_spec.rb | 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/gems/gitlab-housekeeper/lib/gitlab/housekeeper/change.rb b/gems/gitlab-housekeeper/lib/gitlab/housekeeper/change.rb index be00d69903084..3170162b34330 100644 --- a/gems/gitlab-housekeeper/lib/gitlab/housekeeper/change.rb +++ b/gems/gitlab-housekeeper/lib/gitlab/housekeeper/change.rb @@ -43,8 +43,8 @@ def mr_description [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the #{keep_class} keep. - To provide feedback on your experience with `gitlab-housekeeper` please comment in - <https://gitlab.com/gitlab-org/gitlab/-/issues/442003>. + To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the + label ~"GitLab Housekeeper" and consider pinging the author of this keep. MARKDOWN end diff --git a/gems/gitlab-housekeeper/spec/gitlab/housekeeper/change_spec.rb b/gems/gitlab-housekeeper/spec/gitlab/housekeeper/change_spec.rb index 8f87733c52af6..85a18d24285bd 100644 --- a/gems/gitlab-housekeeper/spec/gitlab/housekeeper/change_spec.rb +++ b/gems/gitlab-housekeeper/spec/gitlab/housekeeper/change_spec.rb @@ -50,8 +50,8 @@ [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Object keep. - To provide feedback on your experience with `gitlab-housekeeper` please comment in - <https://gitlab.com/gitlab-org/gitlab/-/issues/442003>. + To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the + label ~"GitLab Housekeeper" and consider pinging the author of this keep. MARKDOWN ) end @@ -83,8 +83,8 @@ [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Object keep. - To provide feedback on your experience with `gitlab-housekeeper` please comment in - <https://gitlab.com/gitlab-org/gitlab/-/issues/442003>. + To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the + label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other @@ -108,8 +108,8 @@ [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Object keep. - To provide feedback on your experience with `gitlab-housekeeper` please comment in - <https://gitlab.com/gitlab-org/gitlab/-/issues/442003>. + To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the + label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: removed @@ -135,8 +135,8 @@ [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Object keep. - To provide feedback on your experience with `gitlab-housekeeper` please comment in - <https://gitlab.com/gitlab-org/gitlab/-/issues/442003>. + To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the + label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other diff --git a/gems/gitlab-housekeeper/spec/gitlab/housekeeper/git_spec.rb b/gems/gitlab-housekeeper/spec/gitlab/housekeeper/git_spec.rb index 64588aad85ee3..39bed06a68c5a 100644 --- a/gems/gitlab-housekeeper/spec/gitlab/housekeeper/git_spec.rb +++ b/gems/gitlab-housekeeper/spec/gitlab/housekeeper/git_spec.rb @@ -95,8 +95,8 @@ def setup_and_checkout_another_branch [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Object keep. - To provide feedback on your experience with `gitlab-housekeeper` please comment in - <https://gitlab.com/gitlab-org/gitlab/-/issues/442003>. + To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the + label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other -- GitLab