From d0b07b25845ca1e3b8b8f8da57874a364a4f27e8 Mon Sep 17 00:00:00 2001 From: Zehua Zhang <zhzhang@jihulab.com> Date: Mon, 18 Jul 2022 15:22:32 +0800 Subject: [PATCH] Rename CI_TEMPLATE_REGISTRY_HOST to TEMPLATE_REGISTRY_HOST --- .../ci/templates/Jobs/Dependency-Scanning.gitlab-ci.yml | 4 ++-- lib/gitlab/ci/templates/Jobs/License-Scanning.gitlab-ci.yml | 4 ++-- lib/gitlab/ci/templates/Jobs/SAST-IaC.gitlab-ci.yml | 4 ++-- lib/gitlab/ci/templates/Jobs/SAST-IaC.latest.gitlab-ci.yml | 4 ++-- lib/gitlab/ci/templates/Jobs/SAST.gitlab-ci.yml | 4 ++-- lib/gitlab/ci/templates/Jobs/SAST.latest.gitlab-ci.yml | 4 ++-- lib/gitlab/ci/templates/Jobs/Secret-Detection.gitlab-ci.yml | 4 ++-- .../ci/templates/Jobs/Secret-Detection.latest.gitlab-ci.yml | 4 ++-- lib/gitlab/ci/templates/Security/API-Fuzzing.gitlab-ci.yml | 4 ++-- .../ci/templates/Security/API-Fuzzing.latest.gitlab-ci.yml | 4 ++-- lib/gitlab/ci/templates/Security/DAST-API.gitlab-ci.yml | 4 ++-- .../ci/templates/Security/DAST-API.latest.gitlab-ci.yml | 4 ++-- .../templates/Security/DAST-On-Demand-API-Scan.gitlab-ci.yml | 4 ++-- .../ci/templates/Security/DAST-On-Demand-Scan.gitlab-ci.yml | 4 ++-- lib/gitlab/ci/templates/Security/DAST.gitlab-ci.yml | 4 ++-- lib/gitlab/ci/templates/Security/DAST.latest.gitlab-ci.yml | 4 ++-- .../ci/templates/Security/Secure-Binaries.gitlab-ci.yml | 4 ++-- spec/graphql/types/project_type_spec.rb | 4 ++-- .../security/ci_configuration/sast_parser_service_spec.rb | 2 +- 19 files changed, 37 insertions(+), 37 deletions(-) diff --git a/lib/gitlab/ci/templates/Jobs/Dependency-Scanning.gitlab-ci.yml b/lib/gitlab/ci/templates/Jobs/Dependency-Scanning.gitlab-ci.yml index f7ec80e6ba40..db53b32a7769 100644 --- a/lib/gitlab/ci/templates/Jobs/Dependency-Scanning.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Jobs/Dependency-Scanning.gitlab-ci.yml @@ -11,8 +11,8 @@ variables: # Setting this variable will affect all Security templates # (SAST, Dependency Scanning, ...) - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" DS_EXCLUDED_ANALYZERS: "" DS_EXCLUDED_PATHS: "spec, test, tests, tmp" DS_MAJOR_VERSION: 3 diff --git a/lib/gitlab/ci/templates/Jobs/License-Scanning.gitlab-ci.yml b/lib/gitlab/ci/templates/Jobs/License-Scanning.gitlab-ci.yml index 468de1e210c9..40c05ffe92ae 100644 --- a/lib/gitlab/ci/templates/Jobs/License-Scanning.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Jobs/License-Scanning.gitlab-ci.yml @@ -11,8 +11,8 @@ variables: # Setting this variable will affect all Security templates # (SAST, Dependency Scanning, ...) - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" LICENSE_MANAGEMENT_SETUP_CMD: '' # If needed, specify a command to setup your environment with a custom package manager. LICENSE_MANAGEMENT_VERSION: 4 diff --git a/lib/gitlab/ci/templates/Jobs/SAST-IaC.gitlab-ci.yml b/lib/gitlab/ci/templates/Jobs/SAST-IaC.gitlab-ci.yml index 556f6e8fd9cf..0015032ed63c 100644 --- a/lib/gitlab/ci/templates/Jobs/SAST-IaC.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Jobs/SAST-IaC.gitlab-ci.yml @@ -6,8 +6,8 @@ variables: # Setting this variable will affect all Security templates # (SAST, Dependency Scanning, ...) - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" SAST_IMAGE_SUFFIX: "" SAST_EXCLUDED_PATHS: "spec, test, tests, tmp" diff --git a/lib/gitlab/ci/templates/Jobs/SAST-IaC.latest.gitlab-ci.yml b/lib/gitlab/ci/templates/Jobs/SAST-IaC.latest.gitlab-ci.yml index 556f6e8fd9cf..0015032ed63c 100644 --- a/lib/gitlab/ci/templates/Jobs/SAST-IaC.latest.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Jobs/SAST-IaC.latest.gitlab-ci.yml @@ -6,8 +6,8 @@ variables: # Setting this variable will affect all Security templates # (SAST, Dependency Scanning, ...) - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" SAST_IMAGE_SUFFIX: "" SAST_EXCLUDED_PATHS: "spec, test, tests, tmp" diff --git a/lib/gitlab/ci/templates/Jobs/SAST.gitlab-ci.yml b/lib/gitlab/ci/templates/Jobs/SAST.gitlab-ci.yml index 882f2547705c..91cbccbe3a7a 100644 --- a/lib/gitlab/ci/templates/Jobs/SAST.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Jobs/SAST.gitlab-ci.yml @@ -6,8 +6,8 @@ variables: # Setting this variable will affect all Security templates # (SAST, Dependency Scanning, ...) - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" SAST_IMAGE_SUFFIX: "" SAST_EXCLUDED_ANALYZERS: "" diff --git a/lib/gitlab/ci/templates/Jobs/SAST.latest.gitlab-ci.yml b/lib/gitlab/ci/templates/Jobs/SAST.latest.gitlab-ci.yml index 48152310cdf0..96fbbc67d8ee 100644 --- a/lib/gitlab/ci/templates/Jobs/SAST.latest.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Jobs/SAST.latest.gitlab-ci.yml @@ -6,8 +6,8 @@ variables: # Setting this variable will affect all Security templates # (SAST, Dependency Scanning, ...) - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" SAST_IMAGE_SUFFIX: "" SAST_EXCLUDED_ANALYZERS: "" diff --git a/lib/gitlab/ci/templates/Jobs/Secret-Detection.gitlab-ci.yml b/lib/gitlab/ci/templates/Jobs/Secret-Detection.gitlab-ci.yml index e74aed3c9e5c..25fc2388f9ef 100644 --- a/lib/gitlab/ci/templates/Jobs/Secret-Detection.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Jobs/Secret-Detection.gitlab-ci.yml @@ -5,8 +5,8 @@ # How to set: https://docs.gitlab.com/ee/ci/yaml/#variables variables: - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" SECRET_DETECTION_IMAGE_SUFFIX: "" SECRETS_ANALYZER_VERSION: "4" diff --git a/lib/gitlab/ci/templates/Jobs/Secret-Detection.latest.gitlab-ci.yml b/lib/gitlab/ci/templates/Jobs/Secret-Detection.latest.gitlab-ci.yml index 4109ccee10ea..ebf464074f89 100644 --- a/lib/gitlab/ci/templates/Jobs/Secret-Detection.latest.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Jobs/Secret-Detection.latest.gitlab-ci.yml @@ -5,8 +5,8 @@ # How to set: https://docs.gitlab.com/ee/ci/yaml/#variables variables: - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" SECRET_DETECTION_IMAGE_SUFFIX: "" SECRETS_ANALYZER_VERSION: "4" SECRET_DETECTION_EXCLUDED_PATHS: "" diff --git a/lib/gitlab/ci/templates/Security/API-Fuzzing.gitlab-ci.yml b/lib/gitlab/ci/templates/Security/API-Fuzzing.gitlab-ci.yml index c0518e155b26..38fb3394c957 100644 --- a/lib/gitlab/ci/templates/Security/API-Fuzzing.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Security/API-Fuzzing.gitlab-ci.yml @@ -24,8 +24,8 @@ variables: # Setting this variable affects all Security templates # (SAST, Dependency Scanning, ...) - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" # FUZZAPI_VERSION: "2" FUZZAPI_IMAGE_SUFFIX: "" diff --git a/lib/gitlab/ci/templates/Security/API-Fuzzing.latest.gitlab-ci.yml b/lib/gitlab/ci/templates/Security/API-Fuzzing.latest.gitlab-ci.yml index 09af3a3ab640..1cbce8aaddda 100644 --- a/lib/gitlab/ci/templates/Security/API-Fuzzing.latest.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Security/API-Fuzzing.latest.gitlab-ci.yml @@ -24,8 +24,8 @@ variables: # Setting this variable affects all Security templates # (SAST, Dependency Scanning, ...) - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" # FUZZAPI_VERSION: "2" FUZZAPI_IMAGE_SUFFIX: "" diff --git a/lib/gitlab/ci/templates/Security/DAST-API.gitlab-ci.yml b/lib/gitlab/ci/templates/Security/DAST-API.gitlab-ci.yml index d74d8b5b8b55..ca9c64fac475 100644 --- a/lib/gitlab/ci/templates/Security/DAST-API.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Security/DAST-API.gitlab-ci.yml @@ -24,8 +24,8 @@ variables: # Setting this variable affects all Security templates # (SAST, Dependency Scanning, ...) - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" # DAST_API_VERSION: "2" DAST_API_IMAGE_SUFFIX: "" diff --git a/lib/gitlab/ci/templates/Security/DAST-API.latest.gitlab-ci.yml b/lib/gitlab/ci/templates/Security/DAST-API.latest.gitlab-ci.yml index 25a4a3c80474..e13d3e0f270d 100644 --- a/lib/gitlab/ci/templates/Security/DAST-API.latest.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Security/DAST-API.latest.gitlab-ci.yml @@ -24,8 +24,8 @@ variables: # Setting this variable affects all Security templates # (SAST, Dependency Scanning, ...) - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" # DAST_API_VERSION: "2" DAST_API_IMAGE_SUFFIX: "" diff --git a/lib/gitlab/ci/templates/Security/DAST-On-Demand-API-Scan.gitlab-ci.yml b/lib/gitlab/ci/templates/Security/DAST-On-Demand-API-Scan.gitlab-ci.yml index 7e69e3b1979e..8543ee90297e 100644 --- a/lib/gitlab/ci/templates/Security/DAST-On-Demand-API-Scan.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Security/DAST-On-Demand-API-Scan.gitlab-ci.yml @@ -10,8 +10,8 @@ stages: - dast variables: - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" DAST_API_VERSION: "2" DAST_API_IMAGE_SUFFIX: "" DAST_API_IMAGE: api-security diff --git a/lib/gitlab/ci/templates/Security/DAST-On-Demand-Scan.gitlab-ci.yml b/lib/gitlab/ci/templates/Security/DAST-On-Demand-Scan.gitlab-ci.yml index 84bed08efac2..17961b49a30c 100644 --- a/lib/gitlab/ci/templates/Security/DAST-On-Demand-Scan.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Security/DAST-On-Demand-Scan.gitlab-ci.yml @@ -13,8 +13,8 @@ variables: DAST_VERSION: 3 # Setting this variable will affect all Security templates # (SAST, Dependency Scanning, ...) - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" dast: stage: dast diff --git a/lib/gitlab/ci/templates/Security/DAST.gitlab-ci.yml b/lib/gitlab/ci/templates/Security/DAST.gitlab-ci.yml index 60669112308f..7359c108f133 100644 --- a/lib/gitlab/ci/templates/Security/DAST.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Security/DAST.gitlab-ci.yml @@ -25,8 +25,8 @@ variables: DAST_VERSION: 3 # Setting this variable will affect all Security templates # (SAST, Dependency Scanning, ...) - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" dast: stage: dast diff --git a/lib/gitlab/ci/templates/Security/DAST.latest.gitlab-ci.yml b/lib/gitlab/ci/templates/Security/DAST.latest.gitlab-ci.yml index e003a8d76438..cd2e5089b785 100644 --- a/lib/gitlab/ci/templates/Security/DAST.latest.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Security/DAST.latest.gitlab-ci.yml @@ -25,8 +25,8 @@ variables: DAST_VERSION: 3 # Setting this variable will affect all Security templates # (SAST, Dependency Scanning, ...) - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" dast: stage: dast diff --git a/lib/gitlab/ci/templates/Security/Secure-Binaries.gitlab-ci.yml b/lib/gitlab/ci/templates/Security/Secure-Binaries.gitlab-ci.yml index 9ce30143d278..edc59d0194e6 100644 --- a/lib/gitlab/ci/templates/Security/Secure-Binaries.gitlab-ci.yml +++ b/lib/gitlab/ci/templates/Security/Secure-Binaries.gitlab-ci.yml @@ -16,8 +16,8 @@ variables: # Setting this variable will affect all Security templates # (SAST, Dependency Scanning, ...) - CI_TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' - SECURE_ANALYZERS_PREFIX: "$CI_TEMPLATE_REGISTRY_HOST/security-products" + TEMPLATE_REGISTRY_HOST: 'registry.gitlab.com' + SECURE_ANALYZERS_PREFIX: "$TEMPLATE_REGISTRY_HOST/security-products" SECURE_BINARIES_ANALYZERS: >- bandit, brakeman, gosec, spotbugs, flawfinder, phpcs-security-audit, security-code-scan, nodejs-scan, eslint, secrets, sobelow, pmd-apex, kics, kubesec, semgrep, gemnasium, gemnasium-maven, gemnasium-python, license-finder, diff --git a/spec/graphql/types/project_type_spec.rb b/spec/graphql/types/project_type_spec.rb index 435546b461c0..686dddaa2f7a 100644 --- a/spec/graphql/types/project_type_spec.rb +++ b/spec/graphql/types/project_type_spec.rb @@ -194,8 +194,8 @@ expect(secure_analyzers['type']).to eq('string') expect(secure_analyzers['field']).to eq('SECURE_ANALYZERS_PREFIX') expect(secure_analyzers['label']).to eq('Image prefix') - expect(secure_analyzers['defaultValue']).to eq('$CI_TEMPLATE_REGISTRY_HOST/security-products') - expect(secure_analyzers['value']).to eq('$CI_TEMPLATE_REGISTRY_HOST/security-products') + expect(secure_analyzers['defaultValue']).to eq('$TEMPLATE_REGISTRY_HOST/security-products') + expect(secure_analyzers['value']).to eq('$TEMPLATE_REGISTRY_HOST/security-products') expect(secure_analyzers['size']).to eq('LARGE') expect(secure_analyzers['options']).to be_nil end diff --git a/spec/services/security/ci_configuration/sast_parser_service_spec.rb b/spec/services/security/ci_configuration/sast_parser_service_spec.rb index 1fd196cdcee8..b11f31a9086c 100644 --- a/spec/services/security/ci_configuration/sast_parser_service_spec.rb +++ b/spec/services/security/ci_configuration/sast_parser_service_spec.rb @@ -16,7 +16,7 @@ let(:bandit) { configuration['analyzers'][0] } let(:brakeman) { configuration['analyzers'][1] } let(:sast_brakeman_level) { brakeman['variables'][0] } - let(:secure_analyzers_prefix) { '$CI_TEMPLATE_REGISTRY_HOST/security-products' } + let(:secure_analyzers_prefix) { '$TEMPLATE_REGISTRY_HOST/security-products' } it 'parses the configuration for SAST' do expect(secure_analyzers['default_value']).to eql(secure_analyzers_prefix) -- GitLab