From cdfbc217efb8dd0d6683b5b5f34b2653676358f2 Mon Sep 17 00:00:00 2001
From: Adie Po <avpfestin@gitlab.com>
Date: Mon, 13 Nov 2023 08:26:39 +0100
Subject: [PATCH] Remove feature flag: use_repository_list_tags_on_graphql
Changelog: changed
---
.../resolvers/container_repository_tags_resolver.rb | 2 +-
.../development/use_repository_list_tags_on_graphql.yml | 8 --------
.../resolvers/container_repository_tags_resolver_spec.rb | 8 --------
3 files changed, 1 insertion(+), 17 deletions(-)
delete mode 100644 config/feature_flags/development/use_repository_list_tags_on_graphql.yml
diff --git a/app/graphql/resolvers/container_repository_tags_resolver.rb b/app/graphql/resolvers/container_repository_tags_resolver.rb
index bc5006ae06cf..50adf98fa076 100644
--- a/app/graphql/resolvers/container_repository_tags_resolver.rb
+++ b/app/graphql/resolvers/container_repository_tags_resolver.rb
@@ -17,7 +17,7 @@ class ContainerRepositoryTagsResolver < BaseResolver
alias_method :container_repository, :object
def resolve(sort:, **filters)
- if container_repository.migrated? && Feature.enabled?(:use_repository_list_tags_on_graphql, container_repository.project)
+ if container_repository.migrated?
page_size = [filters[:first], filters[:last]].map(&:to_i).max
result = container_repository.tags_page(
diff --git a/config/feature_flags/development/use_repository_list_tags_on_graphql.yml b/config/feature_flags/development/use_repository_list_tags_on_graphql.yml
deleted file mode 100644
index 926d952e6f98..000000000000
--- a/config/feature_flags/development/use_repository_list_tags_on_graphql.yml
+++ /dev/null
@@ -1,8 +0,0 @@
----
-name: use_repository_list_tags_on_graphql
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/132716
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/426358
-milestone: '16.5'
-type: development
-group: group::container registry
-default_enabled: false
diff --git a/spec/graphql/resolvers/container_repository_tags_resolver_spec.rb b/spec/graphql/resolvers/container_repository_tags_resolver_spec.rb
index 48be1c29184c..5f12e8649b73 100644
--- a/spec/graphql/resolvers/container_repository_tags_resolver_spec.rb
+++ b/spec/graphql/resolvers/container_repository_tags_resolver_spec.rb
@@ -114,14 +114,6 @@
expect(resolver(args)).is_a? Gitlab::Graphql::ExternallyPaginatedArray
end
-
- context 'when feature use_repository_list_tags_on_graphql is disabled' do
- before do
- stub_feature_flags(use_repository_list_tags_on_graphql: false)
- end
-
- it_behaves_like 'fetching via tags and filter in place'
- end
end
context 'when Gitlab API is not supported' do
--
GitLab