From ccb0d47c3587ddbe5aa3a9dc01ceb113b4117851 Mon Sep 17 00:00:00 2001 From: Lee Tickett <ltickett@gitlab.com> Date: Wed, 3 Apr 2024 10:38:34 +0000 Subject: [PATCH] Refactor achievements app to leverage uniqBy --- .../achievements/components/achievements_app.vue | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/achievements/components/achievements_app.vue b/app/assets/javascripts/achievements/components/achievements_app.vue index dc85b8699e79f..d3e2cdf974152 100644 --- a/app/assets/javascripts/achievements/components/achievements_app.vue +++ b/app/assets/javascripts/achievements/components/achievements_app.vue @@ -7,7 +7,7 @@ import { GlKeysetPagination, GlLoadingIcon, } from '@gitlab/ui'; -import { groupBy } from 'lodash'; +import { uniqBy } from 'lodash'; import { s__ } from '~/locale'; import UserAvatarList from '~/vue_shared/components/user_avatar/user_avatar_list.vue'; import { NEW_ROUTE_NAME } from '../constants'; @@ -103,9 +103,7 @@ export default { }; }, uniqueRecipients(userAchievements) { - return Object.entries(groupBy(userAchievements, 'user.id')).map(([, values]) => { - return values[0].user; - }); + return uniqBy(userAchievements, 'user.id').map(({ user }) => user); }, }, i18n: { -- GitLab