diff --git a/app/workers/all_queues.yml b/app/workers/all_queues.yml index f8aa06943eec486ae5015da5dee2d723a6e2ffae..c0e01448b0123aa1f10c7a6f90586e2a1977256a 100644 --- a/app/workers/all_queues.yml +++ b/app/workers/all_queues.yml @@ -318,15 +318,6 @@ :weight: 1 :idempotent: false :tags: [] -- :name: cronjob:clusters_integrations_check_prometheus_health - :worker_name: Clusters::Integrations::CheckPrometheusHealthWorker - :feature_category: :incident_management - :has_external_dependencies: true - :urgency: :low - :resource_boundary: :unknown - :weight: 1 - :idempotent: true - :tags: [] - :name: cronjob:container_expiration_policy :worker_name: ContainerExpirationPolicyWorker :feature_category: :container_registry @@ -561,15 +552,6 @@ :weight: 1 :idempotent: false :tags: [] -- :name: cronjob:metrics_dashboard_schedule_annotations_prune - :worker_name: Metrics::Dashboard::ScheduleAnnotationsPruneWorker - :feature_category: :metrics - :has_external_dependencies: false - :urgency: :low - :resource_boundary: :unknown - :weight: 1 - :idempotent: true - :tags: [] - :name: cronjob:metrics_global_metrics_update :worker_name: Metrics::GlobalMetricsUpdateWorker :feature_category: :metrics @@ -3072,24 +3054,6 @@ :weight: 1 :idempotent: true :tags: [] -- :name: metrics_dashboard_prune_old_annotations - :worker_name: Metrics::Dashboard::PruneOldAnnotationsWorker - :feature_category: :metrics - :has_external_dependencies: false - :urgency: :low - :resource_boundary: :unknown - :weight: 1 - :idempotent: true - :tags: [] -- :name: metrics_dashboard_sync_dashboards - :worker_name: Metrics::Dashboard::SyncDashboardsWorker - :feature_category: :metrics - :has_external_dependencies: false - :urgency: :low - :resource_boundary: :unknown - :weight: 1 - :idempotent: true - :tags: [] - :name: migrate_external_diffs :worker_name: MigrateExternalDiffsWorker :feature_category: :code_review_workflow diff --git a/app/workers/clusters/integrations/check_prometheus_health_worker.rb b/app/workers/clusters/integrations/check_prometheus_health_worker.rb deleted file mode 100644 index b65b3424c3a4ddfabbd05eabb524270650eaf1bf..0000000000000000000000000000000000000000 --- a/app/workers/clusters/integrations/check_prometheus_health_worker.rb +++ /dev/null @@ -1,24 +0,0 @@ -# frozen_string_literal: true - -module Clusters - module Integrations - class CheckPrometheusHealthWorker - include ApplicationWorker - - data_consistency :always - - # rubocop:disable Scalability/CronWorkerContext - # This worker does not perform work scoped to a context - include CronjobQueue - # rubocop:enable Scalability/CronWorkerContext - - feature_category :incident_management - urgency :low - - idempotent! - worker_has_external_dependencies! - - def perform; end - end - end -end diff --git a/app/workers/metrics/dashboard/prune_old_annotations_worker.rb b/app/workers/metrics/dashboard/prune_old_annotations_worker.rb deleted file mode 100644 index 5b34f85606dcbc67bddc97c1b31956efa0f4bec1..0000000000000000000000000000000000000000 --- a/app/workers/metrics/dashboard/prune_old_annotations_worker.rb +++ /dev/null @@ -1,22 +0,0 @@ -# frozen_string_literal: true - -module Metrics - module Dashboard - class PruneOldAnnotationsWorker - include ApplicationWorker - - data_consistency :always - - sidekiq_options retry: 3 - - DELETE_LIMIT = 10_000 - DEFAULT_CUT_OFF_PERIOD = 2.weeks - - feature_category :metrics - - idempotent! # in the scope of 24 hours - - def perform; end - end - end -end diff --git a/app/workers/metrics/dashboard/schedule_annotations_prune_worker.rb b/app/workers/metrics/dashboard/schedule_annotations_prune_worker.rb deleted file mode 100644 index fe002ffa4a0a743b32fdc9717913fae7be222b18..0000000000000000000000000000000000000000 --- a/app/workers/metrics/dashboard/schedule_annotations_prune_worker.rb +++ /dev/null @@ -1,22 +0,0 @@ -# frozen_string_literal: true - -module Metrics - module Dashboard - class ScheduleAnnotationsPruneWorker - include ApplicationWorker - - data_consistency :always - - # rubocop:disable Scalability/CronWorkerContext - # This worker does not perform work scoped to a context - include CronjobQueue - # rubocop:enable Scalability/CronWorkerContext - - feature_category :metrics - - idempotent! # PruneOldAnnotationsWorker worker is idempotent in the scope of 24 hours - - def perform; end - end - end -end diff --git a/app/workers/metrics/dashboard/sync_dashboards_worker.rb b/app/workers/metrics/dashboard/sync_dashboards_worker.rb deleted file mode 100644 index 668542e51a5ca17540a65ce527af8a6e5c1c40bc..0000000000000000000000000000000000000000 --- a/app/workers/metrics/dashboard/sync_dashboards_worker.rb +++ /dev/null @@ -1,19 +0,0 @@ -# frozen_string_literal: true - -module Metrics - module Dashboard - class SyncDashboardsWorker - include ApplicationWorker - - data_consistency :always - - sidekiq_options retry: 3 - - feature_category :metrics - - idempotent! - - def perform(project_id); end - end - end -end diff --git a/config/sidekiq_queues.yml b/config/sidekiq_queues.yml index dc0b77ef99a903949c3dde6a1cd9b8da8455f9af..2e643f8e977a41fef32ab3d96b77112ba2f9538b 100644 --- a/config/sidekiq_queues.yml +++ b/config/sidekiq_queues.yml @@ -373,10 +373,6 @@ - 1 - - merge_requests_update_head_pipeline - 1 -- - metrics_dashboard_prune_old_annotations - - 1 -- - metrics_dashboard_sync_dashboards - - 1 - - migrate_external_diffs - 1 - - ml_experiment_tracking_associate_ml_candidate_to_package diff --git a/db/migrate/20230622093921_remove_deprecated_metric_worker_instances.rb b/db/migrate/20230622093921_remove_deprecated_metric_worker_instances.rb new file mode 100644 index 0000000000000000000000000000000000000000..ac2bc02ec3f28b2c3c3db66445ce7c9e9df95799 --- /dev/null +++ b/db/migrate/20230622093921_remove_deprecated_metric_worker_instances.rb @@ -0,0 +1,20 @@ +# frozen_string_literal: true + +class RemoveDeprecatedMetricWorkerInstances < Gitlab::Database::Migration[2.1] + DEPRECATED_JOB_CLASSES = %w[ + Clusters::Integrations::CheckPrometheusHealthWorker + Metrics::Dashboard::PruneOldAnnotationsWorker + Metrics::Dashboard::ScheduleAnnotationsPruneWorker + Metrics::Dashboard::SyncDashboardsWorker + ] + + disable_ddl_transaction! + + def up + sidekiq_remove_jobs(job_klasses: DEPRECATED_JOB_CLASSES) + end + + def down + # This migration removes any instances of deprecated workers and cannot be undone. + end +end diff --git a/db/schema_migrations/20230622093921 b/db/schema_migrations/20230622093921 new file mode 100644 index 0000000000000000000000000000000000000000..696104cce80f12d5e273c15ae0a9ce117668505f --- /dev/null +++ b/db/schema_migrations/20230622093921 @@ -0,0 +1 @@ +1947fe30ac91f67fc863879e4adbc46dbe6ef84c9daa7de8133a81a15eb0e6ce \ No newline at end of file diff --git a/spec/commands/sidekiq_cluster/cli_spec.rb b/spec/commands/sidekiq_cluster/cli_spec.rb index 085be1ceac2e4957634ec564f0e73736a0fe55b7..a63e7158c2a26b10e9e9072a946de36214747126 100644 --- a/spec/commands/sidekiq_cluster/cli_spec.rb +++ b/spec/commands/sidekiq_cluster/cli_spec.rb @@ -247,13 +247,13 @@ expected_workers = if Gitlab.ee? [ - %w[cronjob:clusters_integrations_check_prometheus_health incident_management_close_incident status_page_publish] + described_class::DEFAULT_QUEUES, + %w[incident_management_close_incident status_page_publish] + described_class::DEFAULT_QUEUES, %w[bulk_imports_pipeline bulk_imports_relation_export project_export projects_import_export_parallel_project_export projects_import_export_relation_export repository_import project_template_export] + described_class::DEFAULT_QUEUES ] else [ - %w[cronjob:clusters_integrations_check_prometheus_health incident_management_close_incident] + described_class::DEFAULT_QUEUES, + %w[incident_management_close_incident] + described_class::DEFAULT_QUEUES, %w[bulk_imports_pipeline bulk_imports_relation_export project_export projects_import_export_parallel_project_export projects_import_export_relation_export repository_import] + described_class::DEFAULT_QUEUES ] diff --git a/spec/workers/every_sidekiq_worker_spec.rb b/spec/workers/every_sidekiq_worker_spec.rb index cf1667cb0ff36648ddd1cb7a810d536274f8d3ca..710845e5073429c749970783dcfc79e61fa0ab49 100644 --- a/spec/workers/every_sidekiq_worker_spec.rb +++ b/spec/workers/every_sidekiq_worker_spec.rb @@ -366,8 +366,6 @@ 'MergeRequests::SyncCodeOwnerApprovalRulesWorker' => 3, 'MergeTrains::RefreshWorker' => 3, 'MergeWorker' => 3, - 'Metrics::Dashboard::PruneOldAnnotationsWorker' => 3, - 'Metrics::Dashboard::SyncDashboardsWorker' => 3, 'MigrateExternalDiffsWorker' => 3, 'Onboarding::IssueCreatedWorker' => 3, 'Onboarding::PipelineCreatedWorker' => 3,