From c558fa5676dc34903087e1acf97c4db87cdc4ccb Mon Sep 17 00:00:00 2001
From: Ahmed Hemdan <ahemdan@gitlab.com>
Date: Tue, 5 Dec 2023 11:24:17 +0100
Subject: [PATCH] Fix non-nullable engineName for code quality degradations
---
.../security/codequality_reports_comparer/degradation_type.rb | 2 +-
doc/api/graphql/reference/index.md | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/graphql/types/security/codequality_reports_comparer/degradation_type.rb b/app/graphql/types/security/codequality_reports_comparer/degradation_type.rb
index 7dd47611a2e9f..d4aca0a379253 100644
--- a/app/graphql/types/security/codequality_reports_comparer/degradation_type.rb
+++ b/app/graphql/types/security/codequality_reports_comparer/degradation_type.rb
@@ -35,7 +35,7 @@ class DegradationType < BaseObject
description: 'URL to the file along with line number.'
field :engine_name, GraphQL::Types::String,
- null: false,
+ null: true,
description: 'Code quality plugin that reported the degradation.'
end
# rubocop: enable Graphql/AuthorizeTypes
diff --git a/doc/api/graphql/reference/index.md b/doc/api/graphql/reference/index.md
index d5e80e0549f6e..f587b6ca31de5 100644
--- a/doc/api/graphql/reference/index.md
+++ b/doc/api/graphql/reference/index.md
@@ -15980,7 +15980,7 @@ Represents a degradation on the compared codequality report.
| Name | Type | Description |
| ---- | ---- | ----------- |
| <a id="codequalityreportscomparerreportdegradationdescription"></a>`description` | [`String!`](#string) | Description of the code quality degradation. |
-| <a id="codequalityreportscomparerreportdegradationenginename"></a>`engineName` | [`String!`](#string) | Code quality plugin that reported the degradation. |
+| <a id="codequalityreportscomparerreportdegradationenginename"></a>`engineName` | [`String`](#string) | Code quality plugin that reported the degradation. |
| <a id="codequalityreportscomparerreportdegradationfilepath"></a>`filePath` | [`String!`](#string) | Relative path to the file containing the code quality degradation. |
| <a id="codequalityreportscomparerreportdegradationfingerprint"></a>`fingerprint` | [`String!`](#string) | Unique fingerprint to identify the code quality degradation. For example, an MD5 hash. |
| <a id="codequalityreportscomparerreportdegradationline"></a>`line` | [`Int!`](#int) | Line on which the code quality degradation occurred. |
--
GitLab