From c52ac5c82e33aeb536e9509a19f37810a9684910 Mon Sep 17 00:00:00 2001 From: Artur Fedorov <afedorov@gitlab.com> Date: Tue, 4 Mar 2025 11:53:41 +0000 Subject: [PATCH] Fix Vue 3 spec Add additional nextTick --- scripts/frontend/quarantined_vue3_specs.txt | 1 - .../sessions/new/components/email_verification_spec.js | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/scripts/frontend/quarantined_vue3_specs.txt b/scripts/frontend/quarantined_vue3_specs.txt index 85b00dea9a7ce..f9da68757a3dd 100644 --- a/scripts/frontend/quarantined_vue3_specs.txt +++ b/scripts/frontend/quarantined_vue3_specs.txt @@ -214,7 +214,6 @@ spec/frontend/repository/components/table/index_spec.js spec/frontend/repository/components/table/row_spec.js spec/frontend/search/sidebar/components/checkbox_filter_spec.js spec/frontend/search/topbar/components/app_spec.js -spec/frontend/sessions/new/components/email_verification_spec.js spec/frontend/set_status_modal/set_status_modal_wrapper_spec.js spec/frontend/set_status_modal/user_profile_set_status_wrapper_spec.js spec/frontend/sidebar/components/assignees/sidebar_assignees_widget_spec.js diff --git a/spec/frontend/sessions/new/components/email_verification_spec.js b/spec/frontend/sessions/new/components/email_verification_spec.js index 2ee8bc4b14b59..1521363e430fa 100644 --- a/spec/frontend/sessions/new/components/email_verification_spec.js +++ b/spec/frontend/sessions/new/components/email_verification_spec.js @@ -1,8 +1,8 @@ import { GlForm, GlFormInput } from '@gitlab/ui'; import axios from 'axios'; import MockAdapter from 'axios-mock-adapter'; -import { nextTick } from 'vue'; import { mountExtended } from 'helpers/vue_test_utils_helper'; +import waitForPromises from 'helpers/wait_for_promises'; import { createAlert, VARIANT_SUCCESS } from '~/alert'; import { HTTP_STATUS_NOT_FOUND, HTTP_STATUS_OK } from '~/lib/utils/http_status'; import EmailVerification from '~/sessions/new/components/email_verification.vue'; @@ -324,7 +324,7 @@ describe('EmailVerification', () => { findSecondaryEmailForm().vm.$emit('submit-email', secondaryEmail); - await nextTick(); + await waitForPromises(); expect(findSecondaryEmailForm().exists()).toBe(false); expect(wrapper.text()).toContain(secondaryEmail); @@ -340,7 +340,7 @@ describe('EmailVerification', () => { findSecondaryEmailForm().vm.$emit('cancel'); - await nextTick(); + await waitForPromises(); expect(findSecondaryEmailForm().exists()).toBe(false); expect(findCodeInput().element.value).toBe(''); -- GitLab