diff --git a/app/finders/ci/pipelines_finder.rb b/app/finders/ci/pipelines_finder.rb index 6ba2ae91d6c79d6a18a3bbf9feede37cc62b3c94..9be9d6418937ee469d1d7d9c1c1550b7031029a8 100644 --- a/app/finders/ci/pipelines_finder.rb +++ b/app/finders/ci/pipelines_finder.rb @@ -149,9 +149,7 @@ def by_yaml_errors(items) # rubocop: enable CodeReuse/ActiveRecord def by_name(items) - return items unless - Feature.enabled?(:pipeline_name_search, project) && - params[:name].present? + return items unless params[:name].present? items.for_name(params[:name]) end diff --git a/config/feature_flags/development/pipeline_name_search.yml b/config/feature_flags/development/pipeline_name_search.yml deleted file mode 100644 index ccf4f4a6c9cf5aacf1e1539a04cccdb616d71733..0000000000000000000000000000000000000000 --- a/config/feature_flags/development/pipeline_name_search.yml +++ /dev/null @@ -1,8 +0,0 @@ ---- -name: pipeline_name_search -introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/107086 -rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/385864 -milestone: '15.7' -type: development -group: group::delivery -default_enabled: false diff --git a/doc/api/pipelines.md b/doc/api/pipelines.md index 1b75a3f74b558e88797bc44ef674b690b53bc32a..d07a63cde1e1c491ebeb0a65ad23e6a2c2077744 100644 --- a/doc/api/pipelines.md +++ b/doc/api/pipelines.md @@ -19,12 +19,7 @@ Read more on [pagination](rest/index.md#pagination). > - `name` in response [introduced](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/115310) in GitLab 15.11 [with a flag](../administration/feature_flags.md) named `pipeline_name_in_api`. Disabled by default. > - `name` in request [introduced](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/115310) in 15.11 [with a flag](../administration/feature_flags.md) named `pipeline_name_search`. Disabled by default. > - `name` in response [generally available](https://gitlab.com/gitlab-org/gitlab/-/issues/398131) in GitLab 16.3. Feature flag `pipeline_name_in_api` removed. - -FLAG: -On self-managed GitLab, by default the `name` field in a request is ignored. -To make it available, an administrator can [enable the feature flag](../administration/feature_flags.md) -named `pipeline_name_search`. -On GitLab.com, this feature is available. +> - `name` in request [generally available](https://gitlab.com/gitlab-org/gitlab/-/issues/385864) in GitLab 16.9. Feature flag `pipeline_name_search` removed. List pipelines in a project. Child pipelines are not included in the results, but you can [get child pipeline](pipelines.md#get-a-single-pipeline) individually. diff --git a/spec/finders/ci/pipelines_finder_spec.rb b/spec/finders/ci/pipelines_finder_spec.rb index 8773fbccdfcb0e432e789af8ebca4aefb7b82576..e6984d2f0bc8cbf5d970da3eb831218a6af32ce7 100644 --- a/spec/finders/ci/pipelines_finder_spec.rb +++ b/spec/finders/ci/pipelines_finder_spec.rb @@ -259,16 +259,6 @@ is_expected.to be_empty end end - - context 'when pipeline_name_search feature flag is off' do - before do - stub_feature_flags(pipeline_name_search: false) - end - - it 'ignores name parameter' do - is_expected.to contain_exactly(pipeline, pipeline_other) - end - end end describe 'ordering' do