From c2d9d2ad92d22a97ee5fe24bfc5ae3e5d8372d36 Mon Sep 17 00:00:00 2001 From: Peter Leitzen <pleitzen@gitlab.com> Date: Thu, 1 Feb 2024 13:52:37 +0100 Subject: [PATCH] Danger: Make Reviewer Roulette message more concise Link to documentation page to provide in-depth information about Reviewer Roulette. --- danger/roulette/Dangerfile | 18 +++--------------- doc/development/code_review.md | 2 ++ 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/danger/roulette/Dangerfile b/danger/roulette/Dangerfile index ba0efcc720ed..2f70212e9087 100644 --- a/danger/roulette/Dangerfile +++ b/danger/roulette/Dangerfile @@ -6,10 +6,6 @@ MARKDOWN CATEGORY_TABLE = <<MARKDOWN -Changes that require review have been detected! - -Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category: - | Category | Reviewer | Maintainer | | -------- | -------- | ---------- | MARKDOWN @@ -20,19 +16,11 @@ POST_TABLE_MESSAGE = <<MARKDOWN -  Reviewer is available! -  Reviewer is unavailable! -Feel free to [override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab) -if you think someone else would be better-suited -or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) +Please refer to [documentation page](https://docs.gitlab.com/ee/development/code_review.html#reviewer-roulette) +for guidance on how you can benefit from the Reviewer Roulette, or use the +[GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers. -To read more on how to use the reviewer roulette, please take a look at the -[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics) -and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html). -Please consider assigning a reviewer or maintainer who is a -[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request. - -Once you've decided who will review this merge request, assign them as a reviewer! -Danger does not automatically notify them for you. MARKDOWN NO_SUGGESTIONS = <<MARKDOWN diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 9722ad3b2297..91f31be35994 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -108,6 +108,8 @@ each area of the codebase that your merge request seems to touch. It makes **recommendations** for developer reviewers and you should override it if you think someone else is a better fit. +[Approval Guidelines](#approval-guidelines) can help to pick [domain experts](#domain-experts). + We only do UX reviews for MRs from teams that include a Product Designer. User-facing changes from these teams are required to have a UX review, even if it's behind a feature flag. Default to the recommended UX reviewer suggested. It picks reviewers and maintainers from the list at the -- GitLab