diff --git a/app/assets/javascripts/vue_merge_request_widget/components/merge_checks.vue b/app/assets/javascripts/vue_merge_request_widget/components/merge_checks.vue index 89095a55a117f1f1b5cc071df165c604692563ad..9afed170097ed6e82a881f99baec528ba0a20aaa 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/merge_checks.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/merge_checks.vue @@ -99,15 +99,11 @@ export default { return this.state.mergeabilityChecks || []; }, sortedChecks() { - return [...this.checks] - .sort((a, b) => { - if (a.status === 'FAILED' && b.status !== 'FAILED') return -1; - if (a.status === 'SUCCESS' && b.status !== 'SUCCESS') - return b.status === 'FAILED' ? 1 : -1; + const order = ['FAILED', 'SUCCESS']; - return 0; - }) - .filter((s) => s.status !== 'INACTIVE'); + return [...this.checks] + .filter((s) => s.status !== 'INACTIVE') + .sort((a, b) => order.indexOf(a.status) - order.indexOf(b.status)); }, failedChecks() { return this.checks.filter((c) => c.status.toLowerCase() === 'failed');