From bb7ab192935d88e3cf532400003cab03c57cb1d4 Mon Sep 17 00:00:00 2001
From: Phil Hughes <me@iamphill.com>
Date: Thu, 18 Jul 2024 11:06:31 +0100
Subject: [PATCH] Fixes commit diff expansion
Fixes a bug where diff expansion on commits was incorrectly rendering the expanded
section of the diff. This was caused by an extra element added in for the old
rendering instead of just the rapid diffs rendering.
---
app/helpers/diff_helper.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/helpers/diff_helper.rb b/app/helpers/diff_helper.rb
index ad9bdc57e170a..c081931dd8635 100644
--- a/app/helpers/diff_helper.rb
+++ b/app/helpers/diff_helper.rb
@@ -72,7 +72,7 @@ def diff_match_line(old_pos, new_pos, text: '', view: :inline, bottom: false)
spinner = render(Pajamas::SpinnerComponent.new(size: :sm, class: 'gl-display-none gl-text-align-right', data: { visible_when_loading: true }))
expand_html = content_tag(:div, [expand_button, spinner].join.html_safe, data: { expand_wrapper: true })
else
- expand_html = content_tag(:div, '...', data: { visible_when_loading: false, **expand_data })
+ expand_html = '...'
end
if old_pos
--
GitLab