From b3734e7bcd0a894d4cc87513ce1bd22c9993227d Mon Sep 17 00:00:00 2001
From: Stan Hu <stanhu@gmail.com>
Date: Fri, 18 Mar 2022 22:39:26 -0700
Subject: [PATCH] Upgrade rack-proxy to v0.7.2
This fixes a bug that manifested with the `webpack-dev-server` and the
`thin` Web server.
When a chunked transfer is proxied from rack-proxy, the proxied HTTP
response would contain the original `Transfer-Encoding: chunked` HTTP
header. However, the body would be stripped of the chunked encoding
headers. As a result, Workhorse would fail to parse the body with the
error:
```
httputil: ReverseProxy read error during body copy: invalid byte in
chunk length
```
This occurred because the Golang chunked decoder expected to parse a
length represented as an ASCII number followed by a `\r\n`. Instead,
the first byte was a binary character from the gzipped data.
This does not occur with Puma because Puma initiates a request with an
HTTP/1.0 header and explicitly disables chunked transfers.
https://github.com/ncr/rack-proxy/pull/59 fixes this problem by
dropping the `Transfer-Encoding: chunked` header so that Workhorse
won't handle the HTTP response as a chunked transfer.
See https://gitlab.com/gitlab-org/gitlab-development-kit/-/issues/1443
for more details.
Changelog: fixed
---
Gemfile | 2 +-
Gemfile.lock | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Gemfile b/Gemfile
index ed18ae383182..ac5b5517f228 100644
--- a/Gemfile
+++ b/Gemfile
@@ -285,7 +285,7 @@ gem 'fast_blank'
gem 'gitlab-chronic', '~> 0.10.5'
gem 'gitlab_chronic_duration', '~> 0.10.6.2'
-gem 'rack-proxy', '~> 0.6.0'
+gem 'rack-proxy', '~> 0.7.2'
gem 'sassc-rails', '~> 2.1.0'
gem 'autoprefixer-rails', '10.2.5.1'
diff --git a/Gemfile.lock b/Gemfile.lock
index 2b0057d353d2..dbffdd3835cc 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -968,7 +968,7 @@ GEM
httpclient
json-jwt (>= 1.11.0)
rack (>= 2.1.0)
- rack-proxy (0.6.0)
+ rack-proxy (0.7.2)
rack
rack-test (1.1.0)
rack (>= 1.0, < 3)
@@ -1605,7 +1605,7 @@ DEPENDENCIES
rack-attack (~> 6.3.0)
rack-cors (~> 1.0.6)
rack-oauth2 (~> 1.16.0)
- rack-proxy (~> 0.6.0)
+ rack-proxy (~> 0.7.2)
rack-timeout (~> 0.5.1)
rails (~> 6.1.4.6)
rails-controller-testing
--
GitLab