From ade624bcfe0009c0f27ca8a536bf843e2004d9e3 Mon Sep 17 00:00:00 2001
From: mo khan <mo@mokhan.ca>
Date: Mon, 11 Dec 2023 17:11:03 +0000
Subject: [PATCH] Use `.default_select_columns` instead of `*`
Co-Authored-By: Aboobacker MK <akarakath@gitlab.com>
---
ee/app/models/members/member_role.rb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ee/app/models/members/member_role.rb b/ee/app/models/members/member_role.rb
index 44057015044c..14931975083f 100644
--- a/ee/app/models/members/member_role.rb
+++ b/ee/app/models/members/member_role.rb
@@ -87,7 +87,8 @@ class MemberRole < ApplicationRecord # rubocop:disable Gitlab/NamespacedClass
scope :with_members_count, -> do
left_outer_joins(:members)
.group(:id)
- .select('member_roles.*, COUNT(members.id) AS members_count')
+ .select(MemberRole.default_select_columns)
+ .select('COUNT(members.id) AS members_count')
end
before_destroy :prevent_delete_after_member_associated
--
GitLab