diff --git a/app/assets/javascripts/achievements/components/achievements_form.vue b/app/assets/javascripts/achievements/components/achievements_form.vue index 49c162e9ce09a1ffcf7780dc23c55b09cb5b993a..48223460a0a2a3c6f3a75d2f2c368007949c9916 100644 --- a/app/assets/javascripts/achievements/components/achievements_form.vue +++ b/app/assets/javascripts/achievements/components/achievements_form.vue @@ -265,7 +265,7 @@ export default { type="file" accept="image/*" name="avatar_file" - class="gl-display-none" + class="gl-hidden" @change="selectFile" /> </div> diff --git a/app/assets/javascripts/admin/application_settings/network_outbound.js b/app/assets/javascripts/admin/application_settings/network_outbound.js index ad7ed85131c90687183ba69537c458d68e348793..ad9a474f2297488a311257abeddf80802558e89e 100644 --- a/app/assets/javascripts/admin/application_settings/network_outbound.js +++ b/app/assets/javascripts/admin/application_settings/network_outbound.js @@ -11,9 +11,9 @@ export default () => { const denyAllRequestsWarning = document.querySelector('.js-deny-all-requests-warning'); if (denyAll) { - denyAllRequestsWarning.classList.remove('gl-display-none'); + denyAllRequestsWarning.classList.remove('gl-hidden'); } else { - denyAllRequestsWarning.classList.add('gl-display-none'); + denyAllRequestsWarning.classList.add('gl-hidden'); } allowLocalRequests.forEach((allowLocalRequest) => { diff --git a/app/assets/javascripts/blob/csv/csv_viewer.vue b/app/assets/javascripts/blob/csv/csv_viewer.vue index 7231d02302401ff8dff976b0a615484fe0daaab3..dc98ca429e0794a8ae151c0f2f1f5f6627ec3437 100644 --- a/app/assets/javascripts/blob/csv/csv_viewer.vue +++ b/app/assets/javascripts/blob/csv/csv_viewer.vue @@ -80,7 +80,7 @@ export default { :items="items" :fields="$options.fields" show-empty - thead-class="gl-display-none" + thead-class="gl-hidden" /> <div v-if="isTooLarge" diff --git a/app/assets/javascripts/blob/legacy_template_selector.js b/app/assets/javascripts/blob/legacy_template_selector.js index b712cc63fc9edaa3e5c5e1c0c8afd8f716d42a06..1d116df99372ba515c74d0375d4f30e70d9c9886 100644 --- a/app/assets/javascripts/blob/legacy_template_selector.js +++ b/app/assets/javascripts/blob/legacy_template_selector.js @@ -10,7 +10,7 @@ export default class LegacyTemplateSelector { this.$dropdownContainer = wrapper; this.$filenameInput = $input || $('#file_name'); this.dropdownIcon = dropdown[0].querySelector('.dropdown-menu-toggle-icon'); - this.loadingIcon = loadingIconForLegacyJS({ classes: ['gl-display-none'] }); + this.loadingIcon = loadingIconForLegacyJS({ classes: ['gl-hidden'] }); this.dropdownIcon.parentNode.insertBefore(this.loadingIcon, this.dropdownIcon.nextSibling); this.initDropdown(dropdown, data); @@ -99,12 +99,12 @@ export default class LegacyTemplateSelector { } startLoadingSpinner() { - this.loadingIcon.classList.remove('gl-display-none'); - this.dropdownIcon.classList.add('gl-display-none'); + this.loadingIcon.classList.remove('gl-hidden'); + this.dropdownIcon.classList.add('gl-hidden'); } stopLoadingSpinner() { - this.loadingIcon.classList.add('gl-display-none'); - this.dropdownIcon.classList.remove('gl-display-none'); + this.loadingIcon.classList.add('gl-hidden'); + this.dropdownIcon.classList.remove('gl-hidden'); } } diff --git a/app/assets/javascripts/blob_edit/blob_bundle.js b/app/assets/javascripts/blob_edit/blob_bundle.js index 60831fd8cc44974a2c34e22ec36e93ed6c40b7a0..730ea9fe80125da4869b2f3bca73bddc62485e93 100644 --- a/app/assets/javascripts/blob_edit/blob_bundle.js +++ b/app/assets/javascripts/blob_edit/blob_bundle.js @@ -42,8 +42,8 @@ export default () => { }); commitButton.on('click', () => { - commitButton.addClass('gl-display-none'); - commitButtonLoading.removeClass('gl-display-none'); + commitButton.addClass('gl-hidden'); + commitButtonLoading.removeClass('gl-hidden'); window.onbeforeunload = null; }); diff --git a/app/assets/javascripts/boards/components/board_list_header.vue b/app/assets/javascripts/boards/components/board_list_header.vue index 7ad31683bd007bebab45323e88c25a955c01c999..a453b4fe9664358cfe190eb08fe7cfdf996adaec 100644 --- a/app/assets/javascripts/boards/components/board_list_header.vue +++ b/app/assets/javascripts/boards/components/board_list_header.vue @@ -373,7 +373,7 @@ export default { <div class="board-title-text" :class="{ - 'gl-display-none': list.collapsed && isSwimlanesHeader, + 'gl-hidden': list.collapsed && isSwimlanesHeader, 'gl-flex-grow-0 gl-my-3 gl-mx-0': list.collapsed, 'gl-flex-grow-1': !list.collapsed, 'gl-rotate-90': list.collapsed, diff --git a/app/assets/javascripts/ci/pipeline_editor/components/file_tree/file_item.vue b/app/assets/javascripts/ci/pipeline_editor/components/file_tree/file_item.vue index 786d483b5b93ee5c9043563c48e9930b5280635a..8322f8fea78b2518acf1c0080fbd869bda4d2473 100644 --- a/app/assets/javascripts/ci/pipeline_editor/components/file_tree/file_item.vue +++ b/app/assets/javascripts/ci/pipeline_editor/components/file_tree/file_item.vue @@ -40,6 +40,6 @@ export default { <file-icon class="file-row-icon" :file-name="fileName" /> <span>{{ fileName }}</span> </span> - <gl-icon class="gl-display-none gl-relative gl-text-gray-500" name="external-link" /> + <gl-icon class="gl-hidden gl-relative gl-text-gray-500" name="external-link" /> </gl-link> </template> diff --git a/app/assets/javascripts/ci/pipelines_page/components/failure_widget/pipeline_failed_jobs_widget.vue b/app/assets/javascripts/ci/pipelines_page/components/failure_widget/pipeline_failed_jobs_widget.vue index d9df07f2a39f334b6e5b6905ee2b9cab679037ab..f9086b6efd503ceae4313f1b414c6f5071e68ece 100644 --- a/app/assets/javascripts/ci/pipelines_page/components/failure_widget/pipeline_failed_jobs_widget.vue +++ b/app/assets/javascripts/ci/pipelines_page/components/failure_widget/pipeline_failed_jobs_widget.vue @@ -45,7 +45,7 @@ export default { }, computed: { bodyClasses() { - return this.isExpanded ? '' : 'gl-display-none'; + return this.isExpanded ? '' : 'gl-hidden'; }, failedJobsCountText() { return sprintf(this.$options.i18n.failedJobsLabel, { count: this.currentFailedJobsCount }); diff --git a/app/assets/javascripts/ci/runner/admin_runners/admin_runners_app.vue b/app/assets/javascripts/ci/runner/admin_runners/admin_runners_app.vue index db5cf99684b9e9ba991e35f3766194f5831a61d4..1f2ed45950c30d16388da10c6b3011982cda1305 100644 --- a/app/assets/javascripts/ci/runner/admin_runners/admin_runners_app.vue +++ b/app/assets/javascripts/ci/runner/admin_runners/admin_runners_app.vue @@ -233,7 +233,7 @@ export default { :count-scope="$options.INSTANCE_TYPE" :count-variables="countVariables" class="gl-w-full" - content-class="gl-display-none" + content-class="gl-hidden" nav-class="gl-border-none!" /> </div> diff --git a/app/assets/javascripts/ci/runner/group_runners/group_runners_app.vue b/app/assets/javascripts/ci/runner/group_runners/group_runners_app.vue index d81670dd28a69e06b56e648a8f531bf01781708f..77150f5ef400cb38e8c067cd349cf31ff301a2b2 100644 --- a/app/assets/javascripts/ci/runner/group_runners/group_runners_app.vue +++ b/app/assets/javascripts/ci/runner/group_runners/group_runners_app.vue @@ -248,7 +248,7 @@ export default { :count-variables="countVariables" :runner-types="$options.TABS_RUNNER_TYPES" class="gl-w-full" - content-class="gl-display-none" + content-class="gl-hidden" nav-class="gl-border-none!" /> </div> diff --git a/app/assets/javascripts/commit/image_file.js b/app/assets/javascripts/commit/image_file.js index 580db871f5f56e29a904f2238825e316d758d42c..0294f1aa0491a43bed975d361f689dadaa0d4c56 100644 --- a/app/assets/javascripts/commit/image_file.js +++ b/app/assets/javascripts/commit/image_file.js @@ -22,7 +22,7 @@ export default class ImageFile { initViewModes() { const viewMode = viewModes[0]; - $('.view-modes', this.file).removeClass('gl-display-none'); + $('.view-modes', this.file).removeClass('gl-hidden'); $('.view-modes-menu', this.file).on('click', 'li', (event) => { if (!$(event.currentTarget).hasClass('active')) { return this.activateViewMode(event.currentTarget.className); @@ -37,8 +37,8 @@ export default class ImageFile { .filter(`.${viewMode}`) .addClass('active'); - $(`.view:visible:not(.${viewMode})`, this.file).addClass('gl-display-none'); - $(`.view.${viewMode}`, this.file).removeClass('gl-display-none'); + $(`.view:visible:not(.${viewMode})`, this.file).addClass('gl-hidden'); + $(`.view.${viewMode}`, this.file).removeClass('gl-hidden'); return this.initView(viewMode); } @@ -111,7 +111,7 @@ export default class ImageFile { return this.requestImageInfo($('img', wrap), (width, height) => { $('.image-info .meta-width', wrap).text(`${width}px`); $('.image-info .meta-height', wrap).text(`${height}px`); - return $('.image-info', wrap).removeClass('gl-display-none'); + return $('.image-info', wrap).removeClass('gl-hidden'); }); }); }, diff --git a/app/assets/javascripts/confidential_merge_request/components/project_form_group.vue b/app/assets/javascripts/confidential_merge_request/components/project_form_group.vue index 97762ff549bd159600be5f185f793924cfbb8d14..0289ec6cca199559de126de3559e4519e8688f9a 100644 --- a/app/assets/javascripts/confidential_merge_request/components/project_form_group.vue +++ b/app/assets/javascripts/confidential_merge_request/components/project_form_group.vue @@ -88,7 +88,7 @@ export default { }, showWarning() { if (this.warningText) { - this.warningText.classList.remove('gl-display-none'); + this.warningText.classList.remove('gl-hidden'); } }, }, diff --git a/app/assets/javascripts/content_editor/components/bubble_menus/media_bubble_menu.vue b/app/assets/javascripts/content_editor/components/bubble_menus/media_bubble_menu.vue index dacf1af6bfc3b40c61b6712e787dac9a5556170f..bba5b45a7e150fb3b1138270b4e426d7091658ff 100644 --- a/app/assets/javascripts/content_editor/components/bubble_menus/media_bubble_menu.vue +++ b/app/assets/javascripts/content_editor/components/bubble_menus/media_bubble_menu.vue @@ -237,7 +237,7 @@ export default { type="file" name="content_editor_image" :accept="$options.acceptedMimes[mediaType]" - class="gl-display-none" + class="gl-hidden" @change="onFileSelect" /> <gl-link diff --git a/app/assets/javascripts/content_editor/components/toolbar_attachment_button.vue b/app/assets/javascripts/content_editor/components/toolbar_attachment_button.vue index 501d131eed4eb1193e08cb57541b2da1f3441d35..0c8e5a9b444d7b4657ab26416a3337b56c5f5608 100644 --- a/app/assets/javascripts/content_editor/components/toolbar_attachment_button.vue +++ b/app/assets/javascripts/content_editor/components/toolbar_attachment_button.vue @@ -56,7 +56,7 @@ export default { type="file" multiple name="content_editor_image" - class="gl-display-none" + class="gl-hidden" :aria-label="$options.i18n.inputLabel" data-testid="file-upload-field" @change="onFileSelect" diff --git a/app/assets/javascripts/deprecated_notes.js b/app/assets/javascripts/deprecated_notes.js index 94e1ed7ea6ea479d92ac6e9f26160a397832f1aa..c259b8c346d50c2b0eceff4fffffffb14b1f0ce7 100644 --- a/app/assets/javascripts/deprecated_notes.js +++ b/app/assets/javascripts/deprecated_notes.js @@ -1360,8 +1360,8 @@ export default class Notes { const $svgChevronUpElement = $element.find('svg.js-chevron-up'); const $svgChevronDownElement = $element.find('svg.js-chevron-down'); - $svgChevronUpElement.toggleClass('gl-display-none'); - $svgChevronDownElement.toggleClass('gl-display-none'); + $svgChevronUpElement.toggleClass('gl-hidden'); + $svgChevronDownElement.toggleClass('gl-hidden'); $closestSystemCommitList.toggleClass('hide-shade'); } diff --git a/app/assets/javascripts/design_management/components/upload/button.vue b/app/assets/javascripts/design_management/components/upload/button.vue index e03f2668f7591813140de2c2d8757520fdea72bc..b795c8fa05e5f6dede10ad90624a42906610b60e 100644 --- a/app/assets/javascripts/design_management/components/upload/button.vue +++ b/app/assets/javascripts/design_management/components/upload/button.vue @@ -52,7 +52,7 @@ export default { type="file" name="design_file" :accept="$options.VALID_DESIGN_FILE_MIMETYPE.mimetype" - class="gl-display-none" + class="gl-hidden" multiple @change="onFileUploadChange" /> diff --git a/app/assets/javascripts/environments/folder/environments_folder_view.vue b/app/assets/javascripts/environments/folder/environments_folder_view.vue index 5139286b0beae36c8d33abfa4d23496ac663ce20..6a558af67b27cbf44bbe42b8d927a864b0bdba81 100644 --- a/app/assets/javascripts/environments/folder/environments_folder_view.vue +++ b/app/assets/javascripts/environments/folder/environments_folder_view.vue @@ -51,7 +51,7 @@ export default { <b>{{ folderName }}</b> </h4> - <gl-tabs v-if="!isLoading" scope="environments" content-class="gl-display-none"> + <gl-tabs v-if="!isLoading" scope="environments" content-class="gl-hidden"> <gl-tab v-for="(tab, i) in tabs" :key="`${tab.name}-${i}`" diff --git a/app/assets/javascripts/ide/components/repo_editor.vue b/app/assets/javascripts/ide/components/repo_editor.vue index d2375078820fc14aa3227f65ca948d3faee1f73b..fdf383ccf5909c53bfa384d0db16642bc501d77a 100644 --- a/app/assets/javascripts/ide/components/repo_editor.vue +++ b/app/assets/javascripts/ide/components/repo_editor.vue @@ -489,7 +489,7 @@ export default { <template> <div id="ide" class="blob-viewer-container blob-editor-container"> - <gl-tabs v-if="showTabs" content-class="gl-display-none"> + <gl-tabs v-if="showTabs" content-class="gl-hidden"> <gl-tab :title="__('Edit')" data-testid="edit-tab" diff --git a/app/assets/javascripts/integrations/index/components/integrations_table.vue b/app/assets/javascripts/integrations/index/components/integrations_table.vue index e850bfb5f2498a084fd394cc316dc5a9bf44f0c4..017c500b281bd26397258860c28198850e5a8f85 100644 --- a/app/assets/javascripts/integrations/index/components/integrations_table.vue +++ b/app/assets/javascripts/integrations/index/components/integrations_table.vue @@ -72,9 +72,8 @@ export default { fields.push({ key: 'updated_at', label: this.showUpdatedAt ? __('Last updated') : '', - thClass: 'gl-display-none d-sm-table-cell gl-text-right', - tdClass: - 'gl-border-bottom-0! gl-text-right gl-display-none d-sm-table-cell !gl-align-middle', + thClass: 'gl-hidden d-sm-table-cell gl-text-right', + tdClass: 'gl-border-bottom-0! gl-text-right gl-hidden d-sm-table-cell !gl-align-middle', }); } diff --git a/app/assets/javascripts/labels/labels_select.js b/app/assets/javascripts/labels/labels_select.js index ce3f74fbc21f0168ccdbea747af98942c87a7b99..813d94cf7ce82737211dcf4ba2a66b0b26317e1d 100644 --- a/app/assets/javascripts/labels/labels_select.js +++ b/app/assets/javascripts/labels/labels_select.js @@ -41,7 +41,7 @@ export default class LabelsSelect { const $form = $dropdown.closest('form, .js-issuable-update'); const $sidebarCollapsedValue = $block.find('.sidebar-collapsed-icon span'); const $value = $block.find('.value'); - const $loading = $block.find('.block-loading').addClass('gl-display-none'); + const $loading = $block.find('.block-loading').addClass('gl-hidden'); const fieldName = $dropdown.data('fieldName'); let initialSelected = $selectbox .find(`input[name="${$dropdown.data('fieldName')}"]`) @@ -78,13 +78,13 @@ export default class LabelsSelect { if (!selected.length) { data[abilityName].label_ids = ['']; } - $loading.removeClass('gl-display-none'); + $loading.removeClass('gl-hidden'); $dropdown.trigger('loading.gl.dropdown'); axios .put(issueUpdateURL, data) .then(({ data }) => { let template; - $loading.addClass('gl-display-none'); + $loading.addClass('gl-hidden'); $dropdown.trigger('loaded.gl.dropdown'); $selectbox.hide(); data.issueUpdateURL = issueUpdateURL; diff --git a/app/assets/javascripts/mirrors/ssh_mirror.js b/app/assets/javascripts/mirrors/ssh_mirror.js index 68b18a34ded289d7b2fb975e6ca6cd903c332c18..e3165e01df82a53d4e3e168621b728e71051b2be 100644 --- a/app/assets/javascripts/mirrors/ssh_mirror.js +++ b/app/assets/javascripts/mirrors/ssh_mirror.js @@ -77,7 +77,7 @@ export default class SSHMirror { // Disable button while we make request this.$btnDetectHostKeys.disable(); - $btnLoadSpinner.removeClass('gl-display-none'); + $btnLoadSpinner.removeClass('gl-hidden'); // Make backOff polling to get data backOff((next, stop) => { @@ -102,7 +102,7 @@ export default class SSHMirror { .catch(stop); }) .then((res) => { - $btnLoadSpinner.addClass('gl-display-none'); + $btnLoadSpinner.addClass('gl-hidden'); // Once data is received, we show verification info along with Host keys and fingerprints this.$hostKeysInformation .find('.js-fingerprint-verification') diff --git a/app/assets/javascripts/packages_and_registries/shared/components/package_tags.vue b/app/assets/javascripts/packages_and_registries/shared/components/package_tags.vue index 41b7825736f1dbe2e88444c331d2c32f79b78cd4..f2292b96b3694f30359b55a096730ae06f1a2769 100644 --- a/app/assets/javascripts/packages_and_registries/shared/components/package_tags.vue +++ b/app/assets/javascripts/packages_and_registries/shared/components/package_tags.vue @@ -56,7 +56,7 @@ export default { methods: { tagBadgeClass(index) { return { - 'gl-display-none': true, + 'gl-hidden': true, 'gl-display-flex': this.tagCount === 1, 'md:!gl-flex': this.tagCount > 1, 'gl-mr-2': index !== this.tagsToRender.length - 1, diff --git a/app/assets/javascripts/pages/admin/application_settings/payload_previewer.js b/app/assets/javascripts/pages/admin/application_settings/payload_previewer.js index 418627891858c6a69acceb52621e5e1ef63fd7a7..8c4287712909b106fed6af0413f72dbb5fe6fbe7 100644 --- a/app/assets/javascripts/pages/admin/application_settings/payload_previewer.js +++ b/app/assets/javascripts/pages/admin/application_settings/payload_previewer.js @@ -51,13 +51,13 @@ export default class PayloadPreviewer { hidePayload() { this.isVisible = false; - this.getContainer().classList.add('gl-display-none'); + this.getContainer().classList.add('gl-hidden'); this.text.textContent = __('Preview payload'); } showPayload() { this.isVisible = true; - this.getContainer().classList.remove('gl-display-none'); + this.getContainer().classList.remove('gl-hidden'); this.text.textContent = __('Hide payload'); } diff --git a/app/assets/javascripts/projects/commit_box/info/init_details_button.js b/app/assets/javascripts/projects/commit_box/info/init_details_button.js index 520b20fcb86d09e1411394d8224e003af2d5136b..cc1ecce5fe073b23c7e79e70c49e0744c40028ea 100644 --- a/app/assets/javascripts/projects/commit_box/info/init_details_button.js +++ b/app/assets/javascripts/projects/commit_box/info/init_details_button.js @@ -11,7 +11,7 @@ export const initDetailsButton = () => { if (contentEl) { contentEl.classList.remove('hide'); - btn.classList.add('gl-display-none'); + btn.classList.add('gl-hidden'); } }); }; diff --git a/app/assets/javascripts/projects/project_new.js b/app/assets/javascripts/projects/project_new.js index 2919a8afa672c7abfd66a0f9153c130dcbaa114e..3f0771efcdb8937656841edf6edf898d25fb98bb 100644 --- a/app/assets/javascripts/projects/project_new.js +++ b/app/assets/javascripts/projects/project_new.js @@ -81,11 +81,11 @@ const validateGroupNamespaceDropdown = (e) => { e.preventDefault(); dropdownButton().classList.add(invalidDropdownClass); namespaceButton().classList.add(invalidDropdownClass); - namespaceError().classList.remove('gl-display-none'); + namespaceError().classList.remove('gl-hidden'); } else { dropdownButton().classList.remove(invalidDropdownClass); namespaceButton().classList.remove(invalidDropdownClass); - namespaceError().classList.add('gl-display-none'); + namespaceError().classList.add('gl-hidden'); } }; @@ -96,11 +96,11 @@ const checkProjectName = (projectNameInput) => { if (!projectNameError) return; if (msg) { projectNameError.innerText = msg; - projectNameError.classList.remove('gl-display-none'); - projectNameDescription.classList.add('gl-display-none'); + projectNameError.classList.remove('gl-hidden'); + projectNameDescription.classList.add('gl-hidden'); } else { - projectNameError.classList.add('gl-display-none'); - projectNameDescription.classList.remove('gl-display-none'); + projectNameError.classList.add('gl-hidden'); + projectNameDescription.classList.remove('gl-hidden'); } }; @@ -123,7 +123,7 @@ const setProjectNamePathHandlers = ($projectNameInput, $projectPathInput) => { hasUserDefinedProjectPath = $projectPathInput.value.trim().length > 0; specialRepo.classList.toggle( - 'gl-display-none', + 'gl-hidden', $projectPathInput.value !== $projectPathInput.dataset.username, ); }; diff --git a/app/assets/javascripts/read_more.js b/app/assets/javascripts/read_more.js index 736dc91dc5a0126f8b94eff7f84f2bfa0cc06be2..bdeae665d78972fd71990fc65b6e2126adb32a5d 100644 --- a/app/assets/javascripts/read_more.js +++ b/app/assets/javascripts/read_more.js @@ -63,7 +63,7 @@ export default function initReadMore(triggerSelector = '.js-read-more-trigger') return; } - triggerEl.classList.remove('gl-display-none'); + triggerEl.classList.remove('gl-hidden'); } triggerEl.addEventListener( diff --git a/app/assets/javascripts/search_settings/constants.js b/app/assets/javascripts/search_settings/constants.js index a49351dc7b0c2e94522db2ac6e22261bd5b670f0..009a6eb8d515ad473a54a30ff327bb460bbceefd 100644 --- a/app/assets/javascripts/search_settings/constants.js +++ b/app/assets/javascripts/search_settings/constants.js @@ -2,7 +2,7 @@ export const EXCLUDED_NODES = ['OPTION']; // Used to hide the sections that do not match * the search term -export const HIDE_CLASS = 'gl-display-none'; +export const HIDE_CLASS = 'gl-hidden'; // used to highlight the text that matches the * search term export const HIGHLIGHT_CLASS = 'gl-bg-orange-100'; diff --git a/app/assets/javascripts/settings_panels.js b/app/assets/javascripts/settings_panels.js index c3ca6d563c62ea1ce3f32aed6f95dd8968331cdb..49961f39d4abe21766e1f7cff5dcd03230be60a8 100644 --- a/app/assets/javascripts/settings_panels.js +++ b/app/assets/javascripts/settings_panels.js @@ -71,11 +71,11 @@ function initGlobalProtectionOptions() { globalProtectionProtectedOption.forEach((option) => { const isProtected = parseBoolean(option.value); option.addEventListener('change', () => { - protectionSettingsSection.classList.toggle('gl-display-none', !isProtected); + protectionSettingsSection.classList.toggle('gl-hidden', !isProtected); }); if (option.checked) { - protectionSettingsSection.classList.toggle('gl-display-none', !isProtected); + protectionSettingsSection.classList.toggle('gl-hidden', !isProtected); } }); } diff --git a/app/assets/javascripts/single_file_diff.js b/app/assets/javascripts/single_file_diff.js index a3b10f3a77b8a2028419e706789dcbb079b90b03..729fc7518e3edcfe1a18fea5dc48e0308fc8f238 100644 --- a/app/assets/javascripts/single_file_diff.js +++ b/app/assets/javascripts/single_file_diff.js @@ -42,11 +42,11 @@ export default class SingleFileDiff { this.loadingContent = $(WRAPPER).addClass('loading').html(LOADING_HTML).hide(); this.content = null; this.collapsedContent.after(this.loadingContent); - this.$chevronRightIcon.removeClass('gl-display-none'); + this.$chevronRightIcon.removeClass('gl-hidden'); } else { this.collapsedContent = $(WRAPPER).html(COLLAPSED_HTML).hide(); this.content.after(this.collapsedContent); - this.$chevronDownIcon.removeClass('gl-display-none'); + this.$chevronDownIcon.removeClass('gl-hidden'); } $('.js-file-title', this.file).on('click', (e) => { @@ -67,17 +67,17 @@ export default class SingleFileDiff { this.isOpen = !this.isOpen; if (!this.isOpen && !this.hasError) { this.content.hide(); - this.$chevronRightIcon.removeClass('gl-display-none'); - this.$chevronDownIcon.addClass('gl-display-none'); + this.$chevronRightIcon.removeClass('gl-hidden'); + this.$chevronDownIcon.addClass('gl-hidden'); this.collapsedContent.show(); } else if (this.content) { this.collapsedContent.hide(); this.content.show(); - this.$chevronDownIcon.removeClass('gl-display-none'); - this.$chevronRightIcon.addClass('gl-display-none'); + this.$chevronDownIcon.removeClass('gl-hidden'); + this.$chevronRightIcon.addClass('gl-hidden'); } else { - this.$chevronDownIcon.removeClass('gl-display-none'); - this.$chevronRightIcon.addClass('gl-display-none'); + this.$chevronDownIcon.removeClass('gl-hidden'); + this.$chevronRightIcon.addClass('gl-hidden'); return this.getContentHTML(cb); // eslint-disable-line consistent-return } } diff --git a/app/assets/javascripts/super_sidebar/components/super_sidebar.vue b/app/assets/javascripts/super_sidebar/components/super_sidebar.vue index 53fca64013d7cf8466032708b26e9efa225a9268..56120d6f34889b06535cf279bacb1058f031e72d 100644 --- a/app/assets/javascripts/super_sidebar/components/super_sidebar.vue +++ b/app/assets/javascripts/super_sidebar/components/super_sidebar.vue @@ -284,7 +284,7 @@ export default { :key="shortcutLink.href" :href="shortcutLink.href" :class="shortcutLink.css_class" - class="gl-display-none" + class="gl-hidden" > {{ shortcutLink.title }} </a> diff --git a/app/assets/javascripts/token_access/components/token_access_table.vue b/app/assets/javascripts/token_access/components/token_access_table.vue index 9f619d32debf6404b8f35fbe3e032627bd7a41a7..a1c4a5eec8e6b04ab1e639b6cc6eb085bc812347 100644 --- a/app/assets/javascripts/token_access/components/token_access_table.vue +++ b/app/assets/javascripts/token_access/components/token_access_table.vue @@ -52,7 +52,7 @@ export default { :items="items" :fields="$options.fields" :tbody-tr-attr="{ 'data-testid': 'token-access-table-row' }" - thead-class="gl-display-none" + thead-class="gl-hidden" class="gl-mb-0" fixed > diff --git a/app/assets/javascripts/usage_quotas/storage/project/components/project_storage_app.vue b/app/assets/javascripts/usage_quotas/storage/project/components/project_storage_app.vue index 4de5b7f1df90ea8b649736dac09d82ad8760c39f..99017f74cdaf57df453ab4bc2063ded3046d7013 100644 --- a/app/assets/javascripts/usage_quotas/storage/project/components/project_storage_app.vue +++ b/app/assets/javascripts/usage_quotas/storage/project/components/project_storage_app.vue @@ -174,7 +174,7 @@ export default { await updateRepositorySize(this.projectPath); this.loadingRecalculateSize = false; - alertEl?.classList.remove('gl-display-none'); + alertEl?.classList.remove('gl-hidden'); }, }, usageQuotasHelpPaths, diff --git a/app/assets/javascripts/work_items/components/widget_wrapper.vue b/app/assets/javascripts/work_items/components/widget_wrapper.vue index 55b0d770ab2a68167adc0b6782308b4d948272e8..90fa122569a4bf5d3fb94e92991005ca1e8bc644 100644 --- a/app/assets/javascripts/work_items/components/widget_wrapper.vue +++ b/app/assets/javascripts/work_items/components/widget_wrapper.vue @@ -69,7 +69,7 @@ export default { <div aria-hidden="true"> <gl-link :id="anchorLinkId" - class="gl-text-decoration-none gl-display-none" + class="gl-text-decoration-none gl-hidden" :href="anchorLink" /> </div> diff --git a/app/helpers/diff_helper.rb b/app/helpers/diff_helper.rb index c081931dd8635aa04768d624a03e853391014e9f..7fd3b2edc8e28d9057312106ab3106d41b4343df 100644 --- a/app/helpers/diff_helper.rb +++ b/app/helpers/diff_helper.rb @@ -69,7 +69,7 @@ def diff_match_line(old_pos, new_pos, text: '', view: :inline, bottom: false) if rapid_diffs? expand_button = content_tag(:button, '...', class: 'gl-bg-none gl-border-0 gl-p-0', data: { visible_when_loading: false, **expand_data }) - spinner = render(Pajamas::SpinnerComponent.new(size: :sm, class: 'gl-display-none gl-text-align-right', data: { visible_when_loading: true })) + spinner = render(Pajamas::SpinnerComponent.new(size: :sm, class: 'gl-hidden gl-text-align-right', data: { visible_when_loading: true })) expand_html = content_tag(:div, [expand_button, spinner].join.html_safe, data: { expand_wrapper: true }) else expand_html = '...' diff --git a/app/views/admin/application_settings/_outbound.html.haml b/app/views/admin/application_settings/_outbound.html.haml index ed7ed99e841054dffe81f494e376972cc2736fb8..8f2c0b818fdabff147bdaeaa4a58f84f58e25a9e 100644 --- a/app/views/admin/application_settings/_outbound.html.haml +++ b/app/views/admin/application_settings/_outbound.html.haml @@ -10,7 +10,7 @@ checkbox_options: { class: 'js-deny-all-requests' } = render Pajamas::AlertComponent.new(variant: :warning, dismissible: false, - alert_options: { class: "gl-mb-3 js-deny-all-requests-warning #{'gl-display-none' unless deny_all_requests}" }) do |c| + alert_options: { class: "gl-mb-3 js-deny-all-requests-warning #{'gl-hidden' unless deny_all_requests}" }) do |c| - c.with_body do = s_('OutboundRequests|Webhooks and integrations might not work properly. GitLab Duo will not work unless `cloud.gitlab.com` is in the following allowlist.') = f.gitlab_ui_checkbox_component :allow_local_requests_from_web_hooks_and_services, diff --git a/app/views/admin/application_settings/_usage.html.haml b/app/views/admin/application_settings/_usage.html.haml index bdaef614033d4af01b6365fc48460edd71eeac3a..c0929a457c3f0e96f913f383be8d996073386d8a 100644 --- a/app/views/admin/application_settings/_usage.html.haml +++ b/app/views/admin/application_settings/_usage.html.haml @@ -24,12 +24,12 @@ .form-text.gl-pl-6.gl-mb-6 - if @service_ping_data.present? = render Pajamas::ButtonComponent.new(button_options: { class: 'js-payload-preview-trigger gl-mr-2', data: { payload_selector: ".#{payload_class}" } }) do - = gl_loading_icon(css_class: 'js-spinner gl-display-none', inline: true) + = gl_loading_icon(css_class: 'js-spinner gl-hidden', inline: true) %span.js-text.gl-display-inline= s_('AdminSettings|Preview payload') = render Pajamas::ButtonComponent.new(button_options: { class: 'js-payload-download-trigger gl-mr-2', data: { endpoint: usage_data_admin_application_settings_path(format: :json) } }) do - = gl_loading_icon(css_class: 'js-spinner gl-display-none', inline: true) + = gl_loading_icon(css_class: 'js-spinner gl-hidden', inline: true) %span.js-text.gl-display-inline= s_('AdminSettings|Download payload') - %pre.js-syntax-highlight.code.highlight.gl-mt-2.gl-display-none{ class: payload_class, data: { endpoint: usage_data_admin_application_settings_path(format: :html) } } + %pre.js-syntax-highlight.code.highlight.gl-mt-2.gl-hidden{ class: payload_class, data: { endpoint: usage_data_admin_application_settings_path(format: :html) } } - else = render Pajamas::AlertComponent.new(variant: :warning, dismissible: false, diff --git a/app/views/admin/impersonation_tokens/index.html.haml b/app/views/admin/impersonation_tokens/index.html.haml index 37dd0a68f474b527bff0ec35698ed234eb0c9364..40140e2c4ba4a3932f1bb611377aff6a28a55ea3 100644 --- a/app/views/admin/impersonation_tokens/index.html.haml +++ b/app/views/admin/impersonation_tokens/index.html.haml @@ -22,7 +22,7 @@ = render Pajamas::ButtonComponent.new(size: :small, button_options: { class: 'js-toggle-button js-toggle-content', data: { testid: 'add-new-token-button' } }) do = _('Add new token') - c.with_body do - .gl-new-card-add-form.gl-mt-3.gl-display-none.js-toggle-content.js-add-new-token-form + .gl-new-card-add-form.gl-mt-3.gl-hidden.js-toggle-content.js-add-new-token-form = render 'shared/access_tokens/form', ajax: true, type: type, diff --git a/app/views/groups/settings/access_tokens/index.html.haml b/app/views/groups/settings/access_tokens/index.html.haml index 907633aa6f9c7fef16c2e5df5c1750b728b619c4..d6f89063cb557c06e1575afb01753c345dc01cc1 100644 --- a/app/views/groups/settings/access_tokens/index.html.haml +++ b/app/views/groups/settings/access_tokens/index.html.haml @@ -40,7 +40,7 @@ = _('Add new token') - c.with_body do - if current_user.can?(:create_resource_access_tokens, @group) - .gl-new-card-add-form.gl-mt-3.gl-display-none.js-toggle-content.js-add-new-token-form + .gl-new-card-add-form.gl-mt-3.gl-hidden.js-toggle-content.js-add-new-token-form = render 'shared/access_tokens/form', ajax: true, type: type, diff --git a/app/views/projects/_commit_button.html.haml b/app/views/projects/_commit_button.html.haml index afb241dba7c8b3cac6724bd8e32c80ae93106854..0373f74bcb1d27ed4ecee08d80bc2b5ed2492cb9 100644 --- a/app/views/projects/_commit_button.html.haml +++ b/app/views/projects/_commit_button.html.haml @@ -2,7 +2,7 @@ - submit_button_options = { type: :submit, variant: :confirm, button_options: { id: 'commit-changes', class: 'js-commit-button', data: { testid: 'commit-button' } } } = render Pajamas::ButtonComponent.new(**submit_button_options) do = _('Commit changes') - = render Pajamas::ButtonComponent.new(loading: true, disabled: true, **submit_button_options.merge({ button_options: { class: 'js-commit-button-loading gl-display-none' } })) do + = render Pajamas::ButtonComponent.new(loading: true, disabled: true, **submit_button_options.merge({ button_options: { class: 'js-commit-button-loading gl-hidden' } })) do = _('Commit changes') = render Pajamas::ButtonComponent.new(href: cancel_path, button_options: { class: 'gl-ml-3', id: 'cancel-changes', aria: { label: _('Discard changes') }, data: { confirm: leave_edit_message, confirm_btn_variant: "danger" } }) do diff --git a/app/views/projects/_new_project_fields.html.haml b/app/views/projects/_new_project_fields.html.haml index ede7dbdadd64d8c6f8b429aa11d600aa39bc4355..492867005038ee4cb81264b57c3b0e7619cc010b 100644 --- a/app/views/projects/_new_project_fields.html.haml +++ b/app/views/projects/_new_project_fields.html.haml @@ -13,7 +13,7 @@ = f.text_field :name, placeholder: "My awesome project", class: "form-control gl-form-input input-lg", data: { testid: 'project-name', track_label: "#{track_label}", track_action: "activate_form_input", track_property: "project_name", track_value: "" }, required: true, aria: { required: true } %small#js-project-name-description.form-text.gl-text-secondary = s_("ProjectsNew|Must start with a lowercase or uppercase letter, digit, emoji, or underscore. Can also contain dots, pluses, dashes, or spaces.") - #js-project-name-error.gl-field-error.gl-mt-2.gl-display-none + #js-project-name-error.gl-field-error.gl-mt-2.gl-hidden .form-group.gl-form-group.gl-w-full.gl-display-flex.gl-flex-wrap .form-group.project-path.col-sm-6.gl-pr-0 = f.label :namespace_id, class: 'label-bold' do @@ -38,9 +38,9 @@ = f.label :path, class: 'label-bold' do %span= _("Project slug") = f.text_field :path, placeholder: "my-awesome-project", class: "form-control gl-form-input", required: true, aria: { required: true }, data: { testid: 'project-path', username: current_user.username } - .js-group-namespace-error.gl-my-3.gl-text-red-500.gl-display-none.col-12 + .js-group-namespace-error.gl-my-3.gl-text-red-500.gl-hidden.col-12 = s_('ProjectsNew|Pick a group or namespace where you want to create this project.') - .js-user-readme-repo.gl-my-3.gl-display-none.col-12 + .js-user-readme-repo.gl-my-3.gl-hidden.col-12 = render Pajamas::AlertComponent.new(dismissible: false, variant: :success) do |c| - c.with_body do diff --git a/app/views/projects/_sidebar.html.haml b/app/views/projects/_sidebar.html.haml index 351625a48961583f03a49ed268230327a66603e1..74ccde0119eb381d528aa973925dc69da092d63b 100644 --- a/app/views/projects/_sidebar.html.haml +++ b/app/views/projects/_sidebar.html.haml @@ -13,7 +13,7 @@ .home-panel-description-markdown.read-more-container{ itemprop: 'description', data: { 'read-more-height': 320 } } .read-more-content.read-more-content--has-scrim = markdown_field(@project, :description) - .js-read-more-trigger.gl-display-none.gl-w-full.gl-h-8.gl-absolute.gl-bottom-0.gl-z-2.gl-bg-default + .js-read-more-trigger.gl-hidden.gl-w-full.gl-h-8.gl-absolute.gl-bottom-0.gl-z-2.gl-bg-default = render Pajamas::ButtonComponent.new(variant: :link, button_options: { 'aria-label': _("Expand project information") }) do = sprite_icon('chevron-down', size: 14) = _("Read more") diff --git a/app/views/projects/diffs/_file_header.html.haml b/app/views/projects/diffs/_file_header.html.haml index cf2275e6cc7ca9fabb3e8b9554ce91b13c9fc942..e822192690472e34fd1549933db6acd0572d700f 100644 --- a/app/views/projects/diffs/_file_header.html.haml +++ b/app/views/projects/diffs/_file_header.html.haml @@ -1,7 +1,7 @@ - if local_assigns.fetch(:show_toggle, true) %span.diff-toggle-caret - = sprite_icon('chevron-right', css_class: 'chevron-right gl-display-none') - = sprite_icon('chevron-down', css_class: 'chevron-down gl-display-none') + = sprite_icon('chevron-right', css_class: 'chevron-right gl-hidden') + = sprite_icon('chevron-down', css_class: 'chevron-down gl-hidden') - if diff_file.submodule? %span diff --git a/app/views/projects/diffs/_replaced_image_diff.html.haml b/app/views/projects/diffs/_replaced_image_diff.html.haml index 1f9533ade832fe24edd9847b2d6cab203f6af9c2..fac338fbc58a9cc7ab6358f52b966172629ba08c 100644 --- a/app/views/projects/diffs/_replaced_image_diff.html.haml +++ b/app/views/projects/diffs/_replaced_image_diff.html.haml @@ -14,7 +14,7 @@ .wrap .frame.deleted = image_tag(old_blob_raw_url, alt: diff_file.old_path, lazy: false) - %p.image-info.gl-display-none + %p.image-info.gl-hidden %span.meta-filesize= number_to_human_size(old_blob.size) | %strong W: @@ -24,7 +24,7 @@ %span.meta-height .wrap = render partial: "projects/diffs/image_diff_frame", locals: { class_name: "added js-image-frame #{class_name}", position: position, note_type: DiffNote.name, image_path: blob_raw_url, alt: diff_file.new_path } - %p.image-info.gl-display-none + %p.image-info.gl-hidden %span.meta-filesize= number_to_human_size(blob.size) | %strong W: @@ -33,7 +33,7 @@ %strong H: %span.meta-height - .swipe.view.gl-display-none + .swipe.view.gl-hidden .swipe-frame .frame.deleted.old-diff = image_tag(old_blob_raw_url, alt: diff_file.old_path, lazy: false) @@ -43,7 +43,7 @@ %span.top-handle %span.bottom-handle - .onion-skin.view.gl-display-none + .onion-skin.view.gl-hidden .onion-skin-frame .frame.deleted = image_tag(old_blob_raw_url, alt: diff_file.old_path, lazy: false) @@ -54,7 +54,7 @@ .dragger{ :style => "left: 0px;" } .opaque -.view-modes.gl-display-none +.view-modes.gl-hidden %ul.view-modes-menu %li.two-up{ data: { mode: 'two-up' } } 2-up %li.swipe{ data: { mode: 'swipe' } } Swipe diff --git a/app/views/projects/mirrors/_ssh_host_keys.html.haml b/app/views/projects/mirrors/_ssh_host_keys.html.haml index cd9580d15e9d0b7705c97f6b4002a249e01419ac..110c2b68b9f7d3716f0b4b3a6433bf9f2078bd1d 100644 --- a/app/views/projects/mirrors/_ssh_host_keys.html.haml +++ b/app/views/projects/mirrors/_ssh_host_keys.html.haml @@ -4,7 +4,7 @@ .form-group.js-ssh-host-keys-section{ class: ('collapse' unless mirror.ssh_mirror_url?) } = render Pajamas::ButtonComponent.new(button_options: { class: 'js-detect-host-keys gl-mr-3', data: { testid: 'detect-host-keys' } }) do - = gl_loading_icon(inline: true, css_class: 'js-spinner gl-display-none gl-mr-2') + = gl_loading_icon(inline: true, css_class: 'js-spinner gl-hidden gl-mr-2') = _('Detect host keys') .fingerprint-ssh-info.js-fingerprint-ssh-info.gl-mt-3.gl-mb-3{ class: ('collapse' unless mirror.ssh_mirror_url?) } %label.label-bold diff --git a/app/views/projects/settings/access_tokens/index.html.haml b/app/views/projects/settings/access_tokens/index.html.haml index 12202578cfe0e3ba8c2d940ee7d8dd83adecaf86..99061dc5a5327c74f2022f9510e4f3df8f72b16c 100644 --- a/app/views/projects/settings/access_tokens/index.html.haml +++ b/app/views/projects/settings/access_tokens/index.html.haml @@ -39,7 +39,7 @@ = _('Add new token') - c.with_body do - if current_user.can?(:create_resource_access_tokens, @project) - .gl-new-card-add-form.gl-mt-3.gl-display-none.js-toggle-content.js-add-new-token-form + .gl-new-card-add-form.gl-mt-3.gl-hidden.js-toggle-content.js-add-new-token-form = render_if_exists 'projects/settings/access_tokens/form', type: type #js-access-token-table-app{ data: { access_token_type: type, access_token_type_plural: type_plural, initial_active_access_tokens: @active_access_tokens.to_json, no_active_tokens_message: _('This project has no active access tokens.'), show_role: true } } diff --git a/app/views/shared/_integration_settings.html.haml b/app/views/shared/_integration_settings.html.haml index 46ef655033554719e2af3bc870ba9ee42cba6ef8..54c34ca7cd578eaee12a39b04c757d057a421254 100644 --- a/app/views/shared/_integration_settings.html.haml +++ b/app/views/shared/_integration_settings.html.haml @@ -4,7 +4,7 @@ - if @default_integration .js-vue-default-integration-settings{ data: integration_form_data(@default_integration, group: @group, project: @project) } .js-vue-integration-settings{ data: integration_form_data(integration, group: @group, project: @project) } - .js-integration-help-html.gl-display-none + .js-integration-help-html.gl-hidden -# All content below will be repositioned in Vue - if lookup_context.template_exists?('help', "shared/integrations/#{integration.to_param}", true) = render "shared/integrations/#{integration.to_param}/help", integration: integration diff --git a/app/views/shared/blob/_markdown_buttons.html.haml b/app/views/shared/blob/_markdown_buttons.html.haml index 16bffaca810466d05c4719cb513b49a6c7919f57..9c615d52a661b6f9ca8931b3516ba0a9dc124d9c 100644 --- a/app/views/shared/blob/_markdown_buttons.html.haml +++ b/app/views/shared/blob/_markdown_buttons.html.haml @@ -29,11 +29,11 @@ = markdown_toolbar_button({ icon: "list-numbered", css_class: 'haml-markdown-button gl-mr-3', data: { "md-tag" => "1. ", "md-prepend" => true }, title: _("Add a numbered list") }) = markdown_toolbar_button({ icon: "list-task", css_class: 'haml-markdown-button gl-mr-3', data: { "md-tag" => "- [ ] ", "md-prepend" => true }, title: _("Add a checklist") }) = markdown_toolbar_button({ icon: "list-indent", - css_class: 'gl-display-none gl-mr-3', + css_class: 'gl-hidden gl-mr-3', data: { "md-command" => 'indentLines', "md-shortcuts": '["mod+]"]' }, title: sprintf(s_("MarkdownEditor|Indent line (%{modifier_key}])") % { modifier_key: modifier_key }) }) = markdown_toolbar_button({ icon: "list-outdent", - css_class: 'gl-display-none gl-mr-3', + css_class: 'gl-hidden gl-mr-3', data: { "md-command" => 'outdentLines', "md-shortcuts": '["mod+["]' }, title: sprintf(s_("MarkdownEditor|Outdent line (%{modifier_key}[)") % { modifier_key: modifier_key }) }) = markdown_toolbar_button({ icon: "details-block", diff --git a/app/views/shared/members/_member.html.haml b/app/views/shared/members/_member.html.haml index 15de82e0ea384abc4c6884ec9e52495c80af71d4..ff1e72b17e248f1ba188b47e46d8ebe83b1584f1 100644 --- a/app/views/shared/members/_member.html.haml +++ b/app/views/shared/members/_member.html.haml @@ -41,7 +41,7 @@ = _("Requested %{time_ago}").html_safe % { time_ago: time_ago_with_tooltip(member.requested_at) } - else = _("Given access %{time_ago}").html_safe % { time_ago: time_ago_with_tooltip(member.created_at) } - %span.js-expires-in{ class: ('gl-display-none' unless member.expires?) } + %span.js-expires-in{ class: ('gl-hidden' unless member.expires?) } · %span.js-expires-in-text{ class: "has-tooltip#{' text-warning' if member.expires_soon?}", title: (member.expires_at.to_time.in_time_zone.to_fs(:medium) if member.expires?) } - if member.expires? diff --git a/app/views/shared/notes/_note.html.haml b/app/views/shared/notes/_note.html.haml index b2d25f8b3c4f33f6a3795533a846bbce96533252..01a270e6f2250baf2035db0ed8cbfdce1c691acf 100644 --- a/app/views/shared/notes/_note.html.haml +++ b/app/views/shared/notes/_note.html.haml @@ -68,7 +68,7 @@ .system-note-commit-list-toggler.hide = _("Toggle commit list") = sprite_icon('chevron-down', css_class: 'js-chevron-down gl-ml-1 gl-vertical-align-text-bottom') - = sprite_icon('chevron-up', css_class: 'js-chevron-up gl-ml-1 gl-vertical-align-text-bottom gl-display-none') + = sprite_icon('chevron-up', css_class: 'js-chevron-up gl-ml-1 gl-vertical-align-text-bottom gl-hidden') - if note.attachment.url .note-attachment - if note.attachment.image? diff --git a/app/views/user_settings/personal_access_tokens/index.html.haml b/app/views/user_settings/personal_access_tokens/index.html.haml index dc87407adc7d26918c34684c69216dcea317a8a1..90c58b2afa899f44c522903cb79382408de1d2b1 100644 --- a/app/views/user_settings/personal_access_tokens/index.html.haml +++ b/app/views/user_settings/personal_access_tokens/index.html.haml @@ -28,7 +28,7 @@ = render Pajamas::ButtonComponent.new(size: :small, button_options: { class: 'js-toggle-button js-toggle-content', data: { testid: 'add-new-token-button' } }) do = _('Add new token') - c.with_body do - .gl-new-card-add-form.gl-mt-3.gl-display-none.js-toggle-content.js-add-new-token-form + .gl-new-card-add-form.gl-mt-3.gl-hidden.js-toggle-content.js-add-new-token-form = render 'shared/access_tokens/form', ajax: true, type: type, diff --git a/app/views/user_settings/ssh_keys/index.html.haml b/app/views/user_settings/ssh_keys/index.html.haml index 8477d87a5873fcbf74a56c1fddf897dc6a4573a2..662cf69ee939e5ab5bd70500903f52e6cc538bf3 100644 --- a/app/views/user_settings/ssh_keys/index.html.haml +++ b/app/views/user_settings/ssh_keys/index.html.haml @@ -1,8 +1,8 @@ - page_title _('SSH Keys') - add_page_specific_style 'page_bundles/profile' - @force_desktop_expanded_sidebar = true -- add_form_class = 'gl-display-none' if !form_errors(@key) -- hide_class = 'gl-display-none' if form_errors(@key) +- add_form_class = 'gl-hidden' if !form_errors(@key) +- hide_class = 'gl-hidden' if form_errors(@key) .settings-section.js-search-settings-section .settings-sticky-header diff --git a/ee/app/assets/javascripts/admin/subscriptions/show/components/subscription_details_table.vue b/ee/app/assets/javascripts/admin/subscriptions/show/components/subscription_details_table.vue index 081cd05a568217e9197bfd3797bc438438e7fca8..eb0255575a40890f5d3d7778bed7a055c66e74db 100644 --- a/ee/app/assets/javascripts/admin/subscriptions/show/components/subscription_details_table.vue +++ b/ee/app/assets/javascripts/admin/subscriptions/show/components/subscription_details_table.vue @@ -98,7 +98,7 @@ export default { :fields="$options.fields" :items="details" class="gl-m-0!" - thead-class="gl-display-none" + thead-class="gl-hidden" :tbody-tr-attr="rowAttr" :tbody-tr-class="rowClass" > diff --git a/ee/app/assets/javascripts/compliance_dashboard/components/violations_report/report.vue b/ee/app/assets/javascripts/compliance_dashboard/components/violations_report/report.vue index f5850bcee1453b47b5afe717862dc40e1e60d19a..4a88b5641e3285be3068b67add6dbf8456bc9a1a 100644 --- a/ee/app/assets/javascripts/compliance_dashboard/components/violations_report/report.vue +++ b/ee/app/assets/javascripts/compliance_dashboard/components/violations_report/report.vue @@ -220,7 +220,7 @@ export default { { key: 'viewDetails', label: '', - thClass: 'gl-display-none', + thClass: 'gl-hidden', tdClass: 'md:gl-hidden view-details', }, ], diff --git a/ee/app/assets/javascripts/domain_verification/index.js b/ee/app/assets/javascripts/domain_verification/index.js index a3049334fa0d8721e2b96b72240a31d1ff70a614..324e2825300a3a17885684365daebfd0f23066a0 100644 --- a/ee/app/assets/javascripts/domain_verification/index.js +++ b/ee/app/assets/javascripts/domain_verification/index.js @@ -4,10 +4,10 @@ export function initRemoveButtonBehavior() { function removeRowSuccessCallback() { this.closest('tr').classList.add('!gl-hidden'); - const labelsCount = document.querySelectorAll('.js-domain-row:not(.gl-display-none\\!)').length; + const labelsCount = document.querySelectorAll('.js-domain-row:not(.gl-hidden\\!)').length; if (labelsCount < 1 && emptyState) { - emptyState.classList.remove('gl-display-none'); + emptyState.classList.remove('gl-hidden'); } } diff --git a/ee/app/assets/javascripts/on_demand_scans/components/tabs/saved.vue b/ee/app/assets/javascripts/on_demand_scans/components/tabs/saved.vue index 6d0f43e379f66fb5705b253a8a549c87452bf5ba..9f0990d2f41448d3ff7e1d017bacba1ce2303726 100644 --- a/ee/app/assets/javascripts/on_demand_scans/components/tabs/saved.vue +++ b/ee/app/assets/javascripts/on_demand_scans/components/tabs/saved.vue @@ -286,7 +286,7 @@ export default { :title="$options.i18n.deleteModalTitle" :ok-title="$options.i18n.deleteButtonLabel" ok-variant="danger" - body-class="gl-display-none" + body-class="gl-hidden" lazy @ok="deleteProfile" @cancel="cancelDeletion" diff --git a/ee/app/assets/javascripts/pages/admin/identities/ee_toggle_provider_id.js b/ee/app/assets/javascripts/pages/admin/identities/ee_toggle_provider_id.js index ba7644ed58e7dc04ed46a078e746a38dc886b115..273c0b7188afb4fa5795790b742b05ff3dcad576 100644 --- a/ee/app/assets/javascripts/pages/admin/identities/ee_toggle_provider_id.js +++ b/ee/app/assets/javascripts/pages/admin/identities/ee_toggle_provider_id.js @@ -1,6 +1,6 @@ function toggleGroupVisibility(providerValue) { const show = providerValue === 'group_saml'; - document.querySelector('.js-providerId-group').classList.toggle('gl-display-none', !show); + document.querySelector('.js-providerId-group').classList.toggle('gl-hidden', !show); } export function toggleProviderIdGroup() { diff --git a/ee/app/assets/javascripts/saml_providers/saml_settings_form.js b/ee/app/assets/javascripts/saml_providers/saml_settings_form.js index 12f157795916d09a78cdd2510edb0f4fefb382fa..e9603212e19a9d40470fc6df37de6791fb000ef9 100644 --- a/ee/app/assets/javascripts/saml_providers/saml_settings_form.js +++ b/ee/app/assets/javascripts/saml_providers/saml_settings_form.js @@ -21,9 +21,9 @@ function getCallout(el) { function toggleElementVisibility(el, show) { if (show) { - el?.classList.remove('gl-display-none'); + el?.classList.remove('gl-hidden'); } else { - el?.classList.add('gl-display-none'); + el?.classList.add('gl-hidden'); } } diff --git a/ee/app/assets/javascripts/security_configuration/corpus_management/components/columns/actions.vue b/ee/app/assets/javascripts/security_configuration/corpus_management/components/columns/actions.vue index 2b28bb00ced3e227759ba8472094fc315eccdd25..6ce69e4ab08a931dfeb7ee323c627bab379987f0 100644 --- a/ee/app/assets/javascripts/security_configuration/corpus_management/components/columns/actions.vue +++ b/ee/app/assets/javascripts/security_configuration/corpus_management/components/columns/actions.vue @@ -65,7 +65,7 @@ export default { <gl-modal header-class="gl-border-b-initial" - body-class="gl-display-none" + body-class="gl-hidden" size="sm" :title="$options.i18n.deleteCorpusMessage" :modal-id="directiveName" diff --git a/ee/app/assets/javascripts/security_configuration/corpus_management/components/corpus_upload_form.vue b/ee/app/assets/javascripts/security_configuration/corpus_management/components/corpus_upload_form.vue index f306ba563b293ea32e5884492b5b68d1ca55cb51..d3e8cb87ea8a8ee6f0b2efecc32349eb6c907d10 100644 --- a/ee/app/assets/javascripts/security_configuration/corpus_management/components/corpus_upload_form.vue +++ b/ee/app/assets/javascripts/security_configuration/corpus_management/components/corpus_upload_form.vue @@ -182,7 +182,7 @@ export default { type="file" name="corpus_file" :accept="$options.VALID_CORPUS_MIMETYPE.mimetype" - class="gl-display-none" + class="gl-hidden" @change="onFileUploadChange" /> </gl-form-group> diff --git a/ee/app/assets/javascripts/security_configuration/dast_profiles/components/dast_profiles_list.vue b/ee/app/assets/javascripts/security_configuration/dast_profiles/components/dast_profiles_list.vue index 5501451eecce070268989745d71a660cede6cf93..fef909730e3a8dd70d64bfd762fbe4e203a938fb 100644 --- a/ee/app/assets/javascripts/security_configuration/dast_profiles/components/dast_profiles_list.vue +++ b/ee/app/assets/javascripts/security_configuration/dast_profiles/components/dast_profiles_list.vue @@ -310,7 +310,7 @@ export default { :static="true" :lazy="true" ok-variant="danger" - body-class="gl-display-none" + body-class="gl-hidden" @ok="handleDelete" @cancel="handleCancel" /> diff --git a/ee/app/assets/javascripts/vulnerabilities/components/new_vulnerability/section_details.vue b/ee/app/assets/javascripts/vulnerabilities/components/new_vulnerability/section_details.vue index 1c9f20c0be530e612c325402fd367340413bb4ed..885d20c99bb9324bf47d2d020d64cecf62fc3736 100644 --- a/ee/app/assets/javascripts/vulnerabilities/components/new_vulnerability/section_details.vue +++ b/ee/app/assets/javascripts/vulnerabilities/components/new_vulnerability/section_details.vue @@ -145,7 +145,7 @@ export default { <gl-form-group :label="$options.i18n.detectionMethod.label" label-for="form-detection-method" - class="gl-mb-6 gl-display-none" + class="gl-mb-6 gl-hidden" > <gl-collapsible-listbox id="form-detection-method" diff --git a/ee/app/assets/javascripts/vulnerabilities/components/related_jira_issues.vue b/ee/app/assets/javascripts/vulnerabilities/components/related_jira_issues.vue index 4150972690a4559dec1c4cfd8583c3e38402b061..7b05ff29ea85a8fb75c695d78cb3e83cf35c446c 100644 --- a/ee/app/assets/javascripts/vulnerabilities/components/related_jira_issues.vue +++ b/ee/app/assets/javascripts/vulnerabilities/components/related_jira_issues.vue @@ -127,7 +127,7 @@ export default { 'gl-align-items-center', { 'gl-border-b-0': !shouldShowIssuesBody }, ]" - :body-class="['gl-bg-gray-10', { 'gl-display-none': !shouldShowIssuesBody }]" + :body-class="['gl-bg-gray-10', { 'gl-hidden': !shouldShowIssuesBody }]" > <template #header> <h3 class="h5 gl-m-0">{{ $options.i18n.cardHeading }}</h3> diff --git a/ee/app/assets/javascripts/workspaces/common/components/workspaces_list/base_workspaces_list.vue b/ee/app/assets/javascripts/workspaces/common/components/workspaces_list/base_workspaces_list.vue index f63c0406778ae4e99779b7d27f9679090f8e3a39..62aeedfdc68b94339e8c23eb39684ad4f375de16 100644 --- a/ee/app/assets/javascripts/workspaces/common/components/workspaces_list/base_workspaces_list.vue +++ b/ee/app/assets/javascripts/workspaces/common/components/workspaces_list/base_workspaces_list.vue @@ -65,7 +65,7 @@ export default { class="gl-display-flex gl-align-items-center gl-flex-direction-column gl-md-flex-direction-row" > <gl-link - class="gl-mr-5 workspace-list-link gl-display-none gl-sm-display-block" + class="gl-mr-5 workspace-list-link gl-hidden gl-sm-display-block" :href="$options.workspacesHelpPath" >{{ $options.i18n.learnMoreHelpLink }}</gl-link > diff --git a/ee/app/helpers/ee/groups_helper.rb b/ee/app/helpers/ee/groups_helper.rb index ddf4c6adcbe17d42d0fa63b16d00c000bb93e5ab..ee5bfa264e716237f549fe7a6e8b2bb29483ae96 100644 --- a/ee/app/helpers/ee/groups_helper.rb +++ b/ee/app/helpers/ee/groups_helper.rb @@ -158,7 +158,7 @@ def show_usage_quotas_tab?(group, tab) end def saml_sso_settings_generate_helper_text(display_none:, text:) - content_tag(:span, text, class: ['js-helper-text', 'gl-clearfix', ('gl-display-none' if display_none)]) + content_tag(:span, text, class: ['js-helper-text', 'gl-clearfix', ('gl-hidden' if display_none)]) end def group_transfer_app_data(group) diff --git a/ee/app/views/admin/ai/self_hosted_models/index.html.haml b/ee/app/views/admin/ai/self_hosted_models/index.html.haml index 5b9ef246d2073ebacc0b23d2c4e5eddc277e4d72..fda216dd02ef811854f0ee1e0397b88bff7417ac 100644 --- a/ee/app/views/admin/ai/self_hosted_models/index.html.haml +++ b/ee/app/views/admin/ai/self_hosted_models/index.html.haml @@ -22,7 +22,7 @@ - c.with_body do %ul.manage-labels-list.js-other-labels.gl-px-3 = render partial: 'self_hosted_model', collection: @self_hosted_models, as: :self_hosted_model - .js-admin-labels-empty-state{ class: ('gl-display-none' if @self_hosted_models.present?) } + .js-admin-labels-empty-state{ class: ('gl-hidden' if @self_hosted_models.present?) } = render Pajamas::EmptyStateComponent.new(svg_path: 'illustrations/empty-state/empty-labels-md.svg', title: s_('AdminSelfHostedModels|Define your set of self-hosted models'), primary_button_text: s_('AdminSelfHostedModels|New self-hosted model'), diff --git a/ee/app/views/admin/identities/_provider_id.html.haml b/ee/app/views/admin/identities/_provider_id.html.haml index f1b921279cc73bf0e50bea745f212a8624e74e3d..536a08ba723be93353bf9bdc1e6289cf3e9213b3 100644 --- a/ee/app/views/admin/identities/_provider_id.html.haml +++ b/ee/app/views/admin/identities/_provider_id.html.haml @@ -1,4 +1,4 @@ -.form-group.row.js-providerId-group.gl-display-none +.form-group.row.js-providerId-group.gl-hidden .col-sm-2.col-form-label = f.label :saml_provider_id, _("Provider ID") .col-sm-10 diff --git a/ee/app/views/groups/saml_providers/_form.html.haml b/ee/app/views/groups/saml_providers/_form.html.haml index 30955d37f0ac6e52cf239998d45026aaac9386ff..6df7bf961601c96e2bbcadaa2e6306eaac1ebf0c 100644 --- a/ee/app/views/groups/saml_providers/_form.html.haml +++ b/ee/app/views/groups/saml_providers/_form.html.haml @@ -7,7 +7,7 @@ - enable_saml_help_text = s_('GroupSAML|Before enforcing SSO, enable SAML authentication.') - web_activity_warning_link_start = '<a href="%{url}" target="_blank" rel="noopener noreferrer">'.html_safe % { url: help_page_path('user/group/saml_sso/index', anchor: 'sso-enforcement') } - web_activity_warning_text = html_escape(s_('GroupSAML|%{strongOpen}Warning%{strongClose} - Enable %{linkStart}SSO enforcement%{linkEnd} to reduce security risks.')) % { strongOpen: '<strong>'.html_safe, strongClose: '</strong>'.html_safe, linkStart: web_activity_warning_link_start, linkEnd: '</a>'.html_safe } - - web_activity_warning_tag = '<span class="js-warning %{class}">%{text}</span>'.html_safe % { class: saml_provider.enforced_sso? && 'gl-display-none', text: web_activity_warning_text } + - web_activity_warning_tag = '<span class="js-warning %{class}">%{text}</span>'.html_safe % { class: saml_provider.enforced_sso? && 'gl-hidden', text: web_activity_warning_text } - web_activity_help_text = '%{enable_saml_help_text_tag}%{web_activity_warning_tag}'.html_safe % { enable_saml_help_text_tag: saml_sso_settings_generate_helper_text(display_none: saml_provider.enabled?, text: enable_saml_help_text), web_activity_warning_tag: web_activity_warning_tag } = f.gitlab_ui_checkbox_component :enforced_sso, s_('GroupSAML|Enforce SSO-only authentication for web activity for this group'), help_text: web_activity_help_text, checkbox_options: { checked: saml_provider.new_record? || saml_provider.enforced_sso?, class: 'js-group-saml-enforced-sso-input', data: { testid: 'enforced-sso-checkbox' } } diff --git a/ee/app/views/groups/saml_providers/_test_button.html.haml b/ee/app/views/groups/saml_providers/_test_button.html.haml index ff34c98e84cc5c7793e10f3ca44223800b18865d..978c3117f63642e27fa1de143466236f0658d0d5 100644 --- a/ee/app/views/groups/saml_providers/_test_button.html.haml +++ b/ee/app/views/groups/saml_providers/_test_button.html.haml @@ -1,5 +1,5 @@ = return unless saml_provider.persisted? = saml_link_for_provider _('Verify SAML Configuration'), saml_provider, redirect: ::OmniAuth::Strategies::GroupSaml::VERIFY_SAML_RESPONSE, data: { testid: 'saml-settings-test-button' } -= render Pajamas::ButtonComponent.new(button_options: { class: 'gl-display-none', disabled: true }) do += render Pajamas::ButtonComponent.new(button_options: { class: 'gl-hidden', disabled: true }) do = _('Verify SAML Configuration') diff --git a/ee/app/views/groups/settings/domain_verification/_certificate.html.haml b/ee/app/views/groups/settings/domain_verification/_certificate.html.haml index 25337ec37b95e4bfc23c816a5bc5622f1e0843af..fafb1ec941c56a0abbfe64a24c32ff7cd1d3c4d4 100644 --- a/ee/app/views/groups/settings/domain_verification/_certificate.html.haml +++ b/ee/app/views/groups/settings/domain_verification/_certificate.html.haml @@ -23,7 +23,7 @@ s_("DomainVerification|Manually enter certificate information"), radio_options: { checked: !auto_ssl_available_and_enabled } -.js-shown-unless-auto-ssl.custom-control.gl-pl-0{ class: ("gl-display-none" if auto_ssl_available_and_enabled) } +.js-shown-unless-auto-ssl.custom-control.gl-pl-0{ class: ("gl-hidden" if auto_ssl_available_and_enabled) } - if domain_presenter.user_defined_certificate? .form-group.gl-form-group.gl-max-w-80 = render Pajamas::CardComponent.new(body_options: { class: 'gl-display-flex gl-align-items-center gl-justify-content-space-between gl-p-5' }) do |c| diff --git a/ee/app/views/groups/settings/domain_verification/_lets_encrypt_callout.html.haml b/ee/app/views/groups/settings/domain_verification/_lets_encrypt_callout.html.haml index 7f08f94a97fc5a2980c0b2bb56d62c504426035e..87c33ef2d2d098e9a5c3e6fe24b3485b632460c5 100644 --- a/ee/app/views/groups/settings/domain_verification/_lets_encrypt_callout.html.haml +++ b/ee/app/views/groups/settings/domain_verification/_lets_encrypt_callout.html.haml @@ -1,18 +1,18 @@ - if domain_presenter.enabled? - if domain_presenter.auto_ssl_enabled - if domain_presenter.show_auto_ssl_failed_warning? - .form-group.gl-form-group.js-shown-if-auto-ssl{ class: ("gl-display-none" unless auto_ssl_available_and_enabled) } + .form-group.gl-form-group.js-shown-if-auto-ssl{ class: ("gl-hidden" unless auto_ssl_available_and_enabled) } = render Pajamas::AlertComponent.new(variant: :warning, dismissible: false) do |c| - c.with_body do = _("Something went wrong while obtaining the Let's Encrypt certificate.") - c.with_actions do = link_button_to _('Retry'), retry_auto_ssl_group_settings_domain_verification_path(group, domain_presenter), method: :post, variant: :confirm - .form-group.gl-form-group.js-shown-if-auto-ssl{ class: ("gl-display-none" unless auto_ssl_available_and_enabled) } + .form-group.gl-form-group.js-shown-if-auto-ssl{ class: ("gl-hidden" unless auto_ssl_available_and_enabled) } = render Pajamas::AlertComponent.new(dismissible: false) do |c| - c.with_body do = _("GitLab is obtaining a Let's Encrypt SSL certificate for this domain. This process can take some time. Please try again later.") - else - .form-group.gl-form-group.js-shown-if-auto-ssl{ class: ("gl-display-none" unless auto_ssl_available_and_enabled) } + .form-group.gl-form-group.js-shown-if-auto-ssl{ class: ("gl-hidden" unless auto_ssl_available_and_enabled) } = render Pajamas::AlertComponent.new(variant: :warning, dismissible: false) do |c| - c.with_body do = _("A Let's Encrypt SSL certificate can not be obtained until your domain is verified.") diff --git a/ee/app/views/groups/sso/saml.html.haml b/ee/app/views/groups/sso/saml.html.haml index fe8c2023982973b78cb086a4d8b6ceebda5128fd..1d72144ec5f0b1fb68c98a6a1923b0eb9c01d167 100644 --- a/ee/app/views/groups/sso/saml.html.haml +++ b/ee/app/views/groups/sso/saml.html.haml @@ -7,7 +7,7 @@ = gl_loading_icon(size: 'lg') .gl-text-center.gl-mt-7 %h4= _('Reauthenticating with SAML provider.') - = saml_link _('Sign in with single sign-on'), @group_path, id: 'js-auto-redirect-to-provider', html_class: 'gl-display-none', redirect: @redirect_path + = saml_link _('Sign in with single sign-on'), @group_path, id: 'js-auto-redirect-to-provider', html_class: 'gl-hidden', redirect: @redirect_path - else = render 'devise/shared/tab_single', tab_title: _('SAML single sign-on') - if user_signed_in? diff --git a/ee/app/views/projects/settings/subscriptions/_table.html.haml b/ee/app/views/projects/settings/subscriptions/_table.html.haml index d3d66f4be752e11295213e6da51b2ac5794e35bd..9fa84bb5d2bb71b20f578c45108e5fce5c969767 100644 --- a/ee/app/views/projects/settings/subscriptions/_table.html.haml +++ b/ee/app/views/projects/settings/subscriptions/_table.html.haml @@ -3,8 +3,8 @@ - count = is_upstream_mode ? @project.upstream_projects_count : @project.downstream_projects_count - subscriptions = is_upstream_mode ? @project.upstream_project_subscriptions : @project.downstream_project_subscriptions - empty_text = is_upstream_mode ? _("This project is not subscribed to any project pipelines.") : _("No project subscribes to the pipelines in this project.") -- add_form_class = 'gl-display-none' if !form_errors(@project) -- hide_class = 'gl-display-none' if form_errors(@project) +- add_form_class = 'gl-hidden' if !form_errors(@project) +- hide_class = 'gl-hidden' if form_errors(@project) = render Pajamas::CardComponent.new(card_options: { class: 'gl-new-card js-toggle-container', data: { testid: "#{mode}-project-subscriptions" } }, header_options: { class: 'gl-new-card-header' }, body_options: { class: 'gl-new-card-body gl-px-0' }) do |c| - c.with_header do diff --git a/ee/app/views/registrations/groups/new.html.haml b/ee/app/views/registrations/groups/new.html.haml index b38f11625485a8cdf20456e20f16aa2cf49580ed..1850564b681dfb52ff87032ddace43498d03ffb6 100644 --- a/ee/app/views/registrations/groups/new.html.haml +++ b/ee/app/views/registrations/groups/new.html.haml @@ -60,7 +60,7 @@ root_url: root_url } } = hidden_field_tag :import_url, nil, class: 'js-import-url' - = submit_tag nil, class: 'gl-display-none' + = submit_tag nil, class: 'gl-hidden' .js-import-project-buttons = render 'projects/import_project_pane', destination_namespace_id: @namespace&.id diff --git a/ee/spec/frontend/saml_providers/saml_settings_form_spec.js b/ee/spec/frontend/saml_providers/saml_settings_form_spec.js index 62cba53d397fb5b010557233230900fc212429e4..6566169db76b6116ecc8caec1ae9d4b7deef0fb3 100644 --- a/ee/spec/frontend/saml_providers/saml_settings_form_spec.js +++ b/ee/spec/frontend/saml_providers/saml_settings_form_spec.js @@ -44,12 +44,12 @@ describe('SamlSettingsForm', () => { }; const expectTestButtonDisabled = () => { - expect(samlSettingsForm.testButtonDisabled.classList.contains('gl-display-none')).toBe(false); - expect(samlSettingsForm.testButton.classList.contains('gl-display-none')).toBe(true); + expect(samlSettingsForm.testButtonDisabled.classList.contains('gl-hidden')).toBe(false); + expect(samlSettingsForm.testButton.classList.contains('gl-hidden')).toBe(true); }; const expectTestButtonEnabled = () => { - expect(samlSettingsForm.testButtonDisabled.classList.contains('gl-display-none')).toBe(true); - expect(samlSettingsForm.testButton.classList.contains('gl-display-none')).toBe(false); + expect(samlSettingsForm.testButtonDisabled.classList.contains('gl-hidden')).toBe(true); + expect(samlSettingsForm.testButton.classList.contains('gl-hidden')).toBe(false); }; describe('updateView', () => { @@ -76,21 +76,21 @@ describe('SamlSettingsForm', () => { it('correctly disables dependent toggle and shows helper text', () => { expect(findEnforcedSsoSetting().el.hasAttribute('disabled')).toBe(false); - expect(findEnforcedSsoSetting().helperText.classList.contains('gl-display-none')).toBe(true); + expect(findEnforcedSsoSetting().helperText.classList.contains('gl-hidden')).toBe(true); uncheckSetting(findGroupSamlSetting()); expect(findEnforcedSsoSetting().el.hasAttribute('disabled')).toBe(true); - expect(findEnforcedSsoSetting().helperText.classList.contains('gl-display-none')).toBe(false); + expect(findEnforcedSsoSetting().helperText.classList.contains('gl-hidden')).toBe(false); expect(findEnforcedSsoSetting().value).toBe(true); }); it('correctly shows warning text when checkbox is unchecked', () => { - expect(findEnforcedSsoSetting().warning.classList.contains('gl-display-none')).toBe(true); + expect(findEnforcedSsoSetting().warning.classList.contains('gl-hidden')).toBe(true); uncheckSetting(findEnforcedSsoSetting()); - expect(findEnforcedSsoSetting().warning.classList.contains('gl-display-none')).toBe(false); + expect(findEnforcedSsoSetting().warning.classList.contains('gl-hidden')).toBe(false); }); it('correctly disables multiple dependent toggles', () => { diff --git a/ee/spec/helpers/ee/groups_helper_spec.rb b/ee/spec/helpers/ee/groups_helper_spec.rb index 706d3ccbbe862d541a5b51c78a7566d4cbe1af70..44be6ed7e5a37df6ade688492c6aa5078120a422 100644 --- a/ee/spec/helpers/ee/groups_helper_spec.rb +++ b/ee/spec/helpers/ee/groups_helper_spec.rb @@ -644,7 +644,7 @@ let(:result) { "<span class=\"js-helper-text gl-clearfix\">#{text}</span>" } specify { expect(helper.saml_sso_settings_generate_helper_text(display_none: false, text: text)).to eq result } - specify { expect(helper.saml_sso_settings_generate_helper_text(display_none: true, text: text)).to include('gl-display-none') } + specify { expect(helper.saml_sso_settings_generate_helper_text(display_none: true, text: text)).to include('gl-hidden') } end describe '#group_transfer_app_data' do diff --git a/spec/frontend/admin/application_settings/network_outbound_spec.js b/spec/frontend/admin/application_settings/network_outbound_spec.js index 2c06a3fd67fc0aa887f01dba9056e3059f8fa249..b14e4bbc9e3d3b6d2ee137bc12afe53a9f1d6103 100644 --- a/spec/frontend/admin/application_settings/network_outbound_spec.js +++ b/spec/frontend/admin/application_settings/network_outbound_spec.js @@ -15,7 +15,7 @@ describe('initNetworkOutbound', () => { <input class="js-deny-all-requests" type="checkbox" name="application_setting[deny_all_requests_except_allowed]" ${ denyAll ? 'checked="checked"' : '' }/> - <div class="js-deny-all-requests-warning ${denyAll ? '' : 'gl-display-none'}"></div> + <div class="js-deny-all-requests-warning ${denyAll ? '' : 'gl-hidden'}"></div> <input class="js-allow-local-requests" type="checkbox" name="application_setting[allow_local_requests_from_web_hooks_and_services]" /> <input class="js-allow-local-requests" type="checkbox" name="application_setting[allow_local_requests_from_system_hooks]" /> `); @@ -33,12 +33,12 @@ describe('initNetworkOutbound', () => { it('shows banner and disables allow checkboxes on change', () => { expect(findDenyCheckbox().checked).toBe(false); - expect(findWarningBanner().classList).toContain('gl-display-none'); + expect(findWarningBanner().classList).toContain('gl-hidden'); clickDenyCheckbox(); expect(findDenyCheckbox().checked).toBe(true); - expect(findWarningBanner().classList).not.toContain('gl-display-none'); + expect(findWarningBanner().classList).not.toContain('gl-hidden'); const allowCheckboxes = findAllowCheckboxes(); allowCheckboxes.forEach((checkbox) => { expect(checkbox.checked).toBe(false); @@ -55,12 +55,12 @@ describe('initNetworkOutbound', () => { it('hides banner and enables allow checkboxes on change', () => { expect(findDenyCheckbox().checked).toBe(true); - expect(findWarningBanner().classList).not.toContain('gl-display-none'); + expect(findWarningBanner().classList).not.toContain('gl-hidden'); clickDenyCheckbox(); expect(findDenyCheckbox().checked).toBe(false); - expect(findWarningBanner().classList).toContain('gl-display-none'); + expect(findWarningBanner().classList).toContain('gl-hidden'); const allowCheckboxes = findAllowCheckboxes(); allowCheckboxes.forEach((checkbox) => { expect(checkbox.disabled).toBe(false); diff --git a/spec/frontend/blob_edit/blob_bundle_spec.js b/spec/frontend/blob_edit/blob_bundle_spec.js index cc13d42ec1d1190087b7d68e662c29b2fb3a3bb3..ca75cb00fbd367437fe03d18a7265cd8b8dbbbcf 100644 --- a/spec/frontend/blob_edit/blob_bundle_spec.js +++ b/spec/frontend/blob_edit/blob_bundle_spec.js @@ -93,14 +93,14 @@ describe('BlobBundle', () => { setHTMLFixture( `<div class="js-edit-blob-form"> <button class="js-commit-button"></button> - <button class="js-commit-button-loading gl-display-none"></button> + <button class="js-commit-button-loading gl-hidden"></button> </div>`, ); blobBundle(); findCommitButton().click(); - expect(findCommitButton().classList).toContain('gl-display-none'); - expect(findCommitLoadingButton().classList).not.toContain('gl-display-none'); + expect(findCommitButton().classList).toContain('gl-hidden'); + expect(findCommitLoadingButton().classList).not.toContain('gl-hidden'); }); }); }); diff --git a/spec/frontend/design_management/components/upload/__snapshots__/button_spec.js.snap b/spec/frontend/design_management/components/upload/__snapshots__/button_spec.js.snap index e6a74c49d50df6f36309f890e9bcc92068f600e0..74dd2d6c6f184ee0191064642994445e34a7afb1 100644 --- a/spec/frontend/design_management/components/upload/__snapshots__/button_spec.js.snap +++ b/spec/frontend/design_management/components/upload/__snapshots__/button_spec.js.snap @@ -16,7 +16,7 @@ exports[`Design management upload button component renders inverted upload desig </gl-button-stub> <input accept="image/*" - class="gl-display-none" + class="gl-hidden" multiple="" name="design_file" type="file" @@ -38,7 +38,7 @@ exports[`Design management upload button component renders upload design button </gl-button-stub> <input accept="image/*" - class="gl-display-none" + class="gl-hidden" multiple="" name="design_file" type="file" diff --git a/spec/frontend/packages_and_registries/shared/components/package_tags_spec.js b/spec/frontend/packages_and_registries/shared/components/package_tags_spec.js index ce948667d460a7a933e33db3f1aa25b1eb1f545b..b760ffdfc4e18e7fca8e5111636715add15edbbe 100644 --- a/spec/frontend/packages_and_registries/shared/components/package_tags_spec.js +++ b/spec/frontend/packages_and_registries/shared/components/package_tags_spec.js @@ -64,7 +64,7 @@ describe('PackageTags', () => { }); describe('tagBadgeStyle', () => { - const defaultStyle = ['badge', 'badge-info', 'gl-display-none']; + const defaultStyle = ['badge', 'badge-info', 'gl-hidden']; it('shows tag badge when there is only one', () => { createComponent([mockTags[0]]); diff --git a/spec/frontend/projects/commit_box/info/init_details_button_spec.js b/spec/frontend/projects/commit_box/info/init_details_button_spec.js index bf9c6a4c998de0edc72f89447a695846487a647b..cb60fc525a8cad55259988c1f01c0779e421c43b 100644 --- a/spec/frontend/projects/commit_box/info/init_details_button_spec.js +++ b/spec/frontend/projects/commit_box/info/init_details_button_spec.js @@ -24,10 +24,10 @@ describe('~/projects/commit_box/info/init_details_button', () => { expect(findContent().classList).not.toContain('hide'); }); - it('hides the expand button by adding the `gl-display-none` class', () => { - expect(findExpandButton().classList).not.toContain('gl-display-none'); + it('hides the expand button by adding the `gl-hidden` class', () => { + expect(findExpandButton().classList).not.toContain('gl-hidden'); findExpandButton().click(); - expect(findExpandButton().classList).toContain('gl-display-none'); + expect(findExpandButton().classList).toContain('gl-hidden'); }); }); @@ -38,10 +38,10 @@ describe('~/projects/commit_box/info/init_details_button', () => { expect(findContent().classList).not.toContain('hide'); }); - it('hides the expand button by adding the `gl-display-none` class', () => { - expect(findExpandButton().classList).not.toContain('gl-display-none'); + it('hides the expand button by adding the `gl-hidden` class', () => { + expect(findExpandButton().classList).not.toContain('gl-hidden'); findExpandSubElement().click(); - expect(findExpandButton().classList).toContain('gl-display-none'); + expect(findExpandButton().classList).toContain('gl-hidden'); }); }); }); diff --git a/spec/frontend/projects/project_new_spec.js b/spec/frontend/projects/project_new_spec.js index 7f6b5d1f7c80f02a9d94e1c7ba4ff63342a73346..362da50f31779e9058cc6fd8d19e152bc1f90e5a 100644 --- a/spec/frontend/projects/project_new_spec.js +++ b/spec/frontend/projects/project_new_spec.js @@ -35,7 +35,7 @@ describe('New Project', () => { </div> <input id="project_name" /> <small id="js-project-name-description" /> - <div class="gl-field-error gl-display-none" id="js-project-name-error" /> + <div class="gl-field-error gl-hidden" id="js-project-name-error" /> <input id="project_path" /> </div> <div class="js-user-readme-repo"></div> @@ -103,7 +103,7 @@ describe('New Project', () => { }); it('no error message by default', () => { - expect($projectNameError.classList.contains('gl-display-none')).toBe(true); + expect($projectNameError.classList.contains('gl-hidden')).toBe(true); }); it('show error message if name is validate', () => { @@ -113,8 +113,8 @@ describe('New Project', () => { expect($projectNameError.innerText).toBe( 'Name must start with a letter, digit, emoji, or underscore.', ); - expect($projectNameError.classList.contains('gl-display-none')).toBe(false); - expect($projectNameDescription.classList.contains('gl-display-none')).toBe(true); + expect($projectNameError.classList.contains('gl-hidden')).toBe(false); + expect($projectNameDescription.classList.contains('gl-hidden')).toBe(true); }); }); diff --git a/spec/frontend/super_sidebar/components/super_sidebar_spec.js b/spec/frontend/super_sidebar/components/super_sidebar_spec.js index 82338628276645aabaef88144767ed9aa8255f13..91b6ca42b880f2e01fd78e45295d14a245ff76e0 100644 --- a/spec/frontend/super_sidebar/components/super_sidebar_spec.js +++ b/spec/frontend/super_sidebar/components/super_sidebar_spec.js @@ -184,7 +184,7 @@ describe('SuperSidebar component', () => { expect(link.exists()).toBe(true); expect(link.attributes('href')).toBe(linkAttrs.href); - expect(link.attributes('class')).toContain('gl-display-none'); + expect(link.attributes('class')).toContain('gl-hidden'); }); it('sets up the sidebar toggle shortcut', () => {