From ab9e7060be76291ff8ba26ac2db67d6691c4bf05 Mon Sep 17 00:00:00 2001 From: lmeckley <lmeckley@gitlab.com> Date: Mon, 17 Jul 2023 10:42:45 -0600 Subject: [PATCH] Link to tech debt docs in review guidelines --- doc/development/code_review.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 95d2c8c66bb0..6aedb18c15d9 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -400,6 +400,8 @@ Maintainers are the DRI of assuring that the acceptance criteria of a merge requ In general, [quality is everyone's responsibility](https://about.gitlab.com/handbook/engineering/quality/), but maintainers of an MR are held responsible for **ensuring** that an MR meets those general quality standards. +This includes [avoiding the creation of technical debt in follow-up issues](contributing/issue_workflow.md#technical-debt-in-follow-up-issues). + If a maintainer feels that an MR is substantial enough, or requires a [domain expert](#domain-experts), maintainers have the discretion to request a review from another reviewer, or maintainer. Here are some examples of maintainers proactively doing this during review: -- GitLab