From a770b6b42a1f32665908fce2d30f00cf876388ec Mon Sep 17 00:00:00 2001 From: drew <dscimino@gmail.com> Date: Tue, 23 Apr 2024 11:29:31 -0400 Subject: [PATCH] Remove unnecessary rubocop annotations --- .rubocop_todo/style/inline_disable_annotation.yml | 1 - lib/gitlab/ci/badge/pipeline/status.rb | 2 -- 2 files changed, 3 deletions(-) diff --git a/.rubocop_todo/style/inline_disable_annotation.yml b/.rubocop_todo/style/inline_disable_annotation.yml index 19c4db69bbbac..0a0837283550a 100644 --- a/.rubocop_todo/style/inline_disable_annotation.yml +++ b/.rubocop_todo/style/inline_disable_annotation.yml @@ -2276,7 +2276,6 @@ Style/InlineDisableAnnotation: - 'lib/gitlab/checks/matching_merge_request.rb' - 'lib/gitlab/ci/ansi2html.rb' - 'lib/gitlab/ci/ansi2json/parser.rb' - - 'lib/gitlab/ci/badge/pipeline/status.rb' - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb' - 'lib/gitlab/ci/charts.rb' - 'lib/gitlab/ci/components/instance_path.rb' diff --git a/lib/gitlab/ci/badge/pipeline/status.rb b/lib/gitlab/ci/badge/pipeline/status.rb index 4fe1c01ac3af8..a8a39fa08fdab 100644 --- a/lib/gitlab/ci/badge/pipeline/status.rb +++ b/lib/gitlab/ci/badge/pipeline/status.rb @@ -23,13 +23,11 @@ def entity 'pipeline' end - # rubocop: disable CodeReuse/ActiveRecord def status pipelines = @project.ci_pipelines.for_ref(@ref).order_id_desc pipelines = pipelines.without_statuses([:skipped]) if @ignore_skipped pipelines.pick(:status) || 'unknown' end - # rubocop: enable CodeReuse/ActiveRecord def metadata @metadata ||= Pipeline::Metadata.new(self) -- GitLab