diff --git a/qa/qa/support/knapsack_report.rb b/qa/qa/support/knapsack_report.rb index 8114e838eded09ea410025c8d338f8a5d533ccb0..659b8f10e0a3cf990745a528007c5433bcba6bd3 100644 --- a/qa/qa/support/knapsack_report.rb +++ b/qa/qa/support/knapsack_report.rb @@ -98,7 +98,7 @@ def upload_report(glob) # # @return [void] def setup_logger! - Knapsack.logger = QA::Runtime::Logger.logger + Knapsack.logger = logger end # Set knapsack environment variables @@ -112,9 +112,9 @@ def setup_environment! # Logger instance # - # @return [Logger] + # @return [ActiveSupport::Logger] def logger - @logger ||= Knapsack.logger + QA::Runtime::Logger.logger end # GCS client diff --git a/qa/qa/support/parallel_pipeline_jobs.rb b/qa/qa/support/parallel_pipeline_jobs.rb index c37958267de105f90fe26b028cbec168f1310e4e..a551bf9978b37ee301f695d204f400bd65dfa296 100644 --- a/qa/qa/support/parallel_pipeline_jobs.rb +++ b/qa/qa/support/parallel_pipeline_jobs.rb @@ -5,7 +5,7 @@ module Support # Helper utility to fetch parallel job names in a given pipelines stage # class ParallelPipelineJobs - include Support::API + include API PARALLEL_JOB_NAME_PATTERN = %r{^\S+ \d+/\d+$}.freeze @@ -60,6 +60,8 @@ def parallel_jobs # @return [Hash, Array] def api_get(path) response = get("#{api_url}/#{path}", { headers: { "PRIVATE-TOKEN" => access_token } }) + raise "Failed to fetch pipeline jobs: '#{response.body}'" unless response.code == API::HTTP_STATUS_OK + parse_body(response) end