From a06b79889c84d6522526f873d4e1b28d182bd06c Mon Sep 17 00:00:00 2001 From: Markus Koller <mkoller@gitlab.com> Date: Thu, 11 Feb 2021 15:42:12 +0100 Subject: [PATCH] Fix Style/FrozenStringLiteralComment violations in rubocop Auto-corrected with Rubocop --- .rubocop_manual_todo.yml | 20 ------------------- ...id_keyword_arguments_in_sidekiq_workers.rb | 2 ++ rubocop/cop/gitlab/finder_with_find_by.rb | 2 ++ .../cop/gitlab/keys-first-and-values-first.rb | 2 ++ .../migration/add_concurrent_foreign_key.rb | 2 ++ rubocop/cop/migration/add_concurrent_index.rb | 2 ++ rubocop/cop/migration/add_index.rb | 2 ++ rubocop/cop/migration/add_timestamps.rb | 2 ++ rubocop/cop/migration/datetime.rb | 2 ++ rubocop/cop/migration/hash_index.rb | 2 ++ rubocop/cop/migration/remove_column.rb | 2 ++ .../cop/migration/remove_concurrent_index.rb | 2 ++ rubocop/cop/migration/remove_index.rb | 2 ++ rubocop/cop/migration/safer_boolean_column.rb | 2 ++ rubocop/cop/migration/timestamps.rb | 2 ++ .../cop/migration/update_column_in_batches.rb | 2 ++ rubocop/cop/project_path_helper.rb | 2 ++ rubocop/migration_helpers.rb | 2 ++ rubocop/qa_helpers.rb | 2 ++ 19 files changed, 36 insertions(+), 20 deletions(-) diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index f675b785b9cd0..57c17da243fdd 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -2505,26 +2505,6 @@ Style/FrozenStringLiteralComment: - 'qa/qa/fixtures/auto_devops_rack/Rakefile' - 'qa/qa/fixtures/auto_devops_rack/config.ru' - 'qa/qa/page/page_concern.rb' - - 'rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb' - - 'rubocop/cop/gitlab/finder_with_find_by.rb' - - 'rubocop/cop/gitlab/keys-first-and-values-first.rb' - - 'rubocop/cop/gitlab/module_with_instance_variables.rb' - - 'rubocop/cop/gitlab/predicate_memoization.rb' - - 'rubocop/cop/migration/add_concurrent_foreign_key.rb' - - 'rubocop/cop/migration/add_concurrent_index.rb' - - 'rubocop/cop/migration/add_index.rb' - - 'rubocop/cop/migration/add_timestamps.rb' - - 'rubocop/cop/migration/datetime.rb' - - 'rubocop/cop/migration/hash_index.rb' - - 'rubocop/cop/migration/remove_column.rb' - - 'rubocop/cop/migration/remove_concurrent_index.rb' - - 'rubocop/cop/migration/remove_index.rb' - - 'rubocop/cop/migration/safer_boolean_column.rb' - - 'rubocop/cop/migration/timestamps.rb' - - 'rubocop/cop/migration/update_column_in_batches.rb' - - 'rubocop/cop/project_path_helper.rb' - - 'rubocop/migration_helpers.rb' - - 'rubocop/qa_helpers.rb' - 'scripts/flaky_examples/detect-new-flaky-examples' - 'scripts/flaky_examples/prune-old-flaky-examples' - 'scripts/gather-test-memory-data' diff --git a/rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb b/rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb index eba38c1630f48..e1c6a984e751f 100644 --- a/rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb +++ b/rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module RuboCop module Cop # Cop that blacklists keyword arguments usage in Sidekiq workers diff --git a/rubocop/cop/gitlab/finder_with_find_by.rb b/rubocop/cop/gitlab/finder_with_find_by.rb index 764a5073143ca..8fa9fe4a2f953 100644 --- a/rubocop/cop/gitlab/finder_with_find_by.rb +++ b/rubocop/cop/gitlab/finder_with_find_by.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module RuboCop module Cop module Gitlab diff --git a/rubocop/cop/gitlab/keys-first-and-values-first.rb b/rubocop/cop/gitlab/keys-first-and-values-first.rb index 544f980030412..e9bf266cdd73a 100644 --- a/rubocop/cop/gitlab/keys-first-and-values-first.rb +++ b/rubocop/cop/gitlab/keys-first-and-values-first.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module RuboCop module Cop module Gitlab diff --git a/rubocop/cop/migration/add_concurrent_foreign_key.rb b/rubocop/cop/migration/add_concurrent_foreign_key.rb index 31cf426b2d4ce..957bd30af63d4 100644 --- a/rubocop/cop/migration/add_concurrent_foreign_key.rb +++ b/rubocop/cop/migration/add_concurrent_foreign_key.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/add_concurrent_index.rb b/rubocop/cop/migration/add_concurrent_index.rb index a2e4ac7256509..510f98ce37345 100644 --- a/rubocop/cop/migration/add_concurrent_index.rb +++ b/rubocop/cop/migration/add_concurrent_index.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/add_index.rb b/rubocop/cop/migration/add_index.rb index 4aea3c0cce30a..7415880e554c2 100644 --- a/rubocop/cop/migration/add_index.rb +++ b/rubocop/cop/migration/add_index.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/add_timestamps.rb b/rubocop/cop/migration/add_timestamps.rb index ba32d6a9960a3..d16e8b1f45bac 100644 --- a/rubocop/cop/migration/add_timestamps.rb +++ b/rubocop/cop/migration/add_timestamps.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/datetime.rb b/rubocop/cop/migration/datetime.rb index 5a6cdc74ca45d..51e0c3e5a2270 100644 --- a/rubocop/cop/migration/datetime.rb +++ b/rubocop/cop/migration/datetime.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/hash_index.rb b/rubocop/cop/migration/hash_index.rb index 3206b73bd3dfe..dba202ef0e320 100644 --- a/rubocop/cop/migration/hash_index.rb +++ b/rubocop/cop/migration/hash_index.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require 'set' require_relative '../../migration_helpers' diff --git a/rubocop/cop/migration/remove_column.rb b/rubocop/cop/migration/remove_column.rb index fffb4ab7fabe0..f63df71467cbe 100644 --- a/rubocop/cop/migration/remove_column.rb +++ b/rubocop/cop/migration/remove_column.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/remove_concurrent_index.rb b/rubocop/cop/migration/remove_concurrent_index.rb index 2328740cf36d3..8c2c6fb157e7e 100644 --- a/rubocop/cop/migration/remove_concurrent_index.rb +++ b/rubocop/cop/migration/remove_concurrent_index.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/remove_index.rb b/rubocop/cop/migration/remove_index.rb index 4df3b1ba756fe..15c2f37b4b0c8 100644 --- a/rubocop/cop/migration/remove_index.rb +++ b/rubocop/cop/migration/remove_index.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/safer_boolean_column.rb b/rubocop/cop/migration/safer_boolean_column.rb index 22d5d37a83dcb..06bb24707bd38 100644 --- a/rubocop/cop/migration/safer_boolean_column.rb +++ b/rubocop/cop/migration/safer_boolean_column.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/timestamps.rb b/rubocop/cop/migration/timestamps.rb index 6cf5648b99676..5584d49ee8c6b 100644 --- a/rubocop/cop/migration/timestamps.rb +++ b/rubocop/cop/migration/timestamps.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/update_column_in_batches.rb b/rubocop/cop/migration/update_column_in_batches.rb index b1c43393f6a90..d23e0d283800a 100644 --- a/rubocop/cop/migration/update_column_in_batches.rb +++ b/rubocop/cop/migration/update_column_in_batches.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/project_path_helper.rb b/rubocop/cop/project_path_helper.rb index f3810622eb1a8..bc2454e5b1f94 100644 --- a/rubocop/cop/project_path_helper.rb +++ b/rubocop/cop/project_path_helper.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module RuboCop module Cop class ProjectPathHelper < RuboCop::Cop::Cop diff --git a/rubocop/migration_helpers.rb b/rubocop/migration_helpers.rb index dffceb2b2c867..63b3766e12681 100644 --- a/rubocop/migration_helpers.rb +++ b/rubocop/migration_helpers.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module RuboCop # Module containing helper methods for writing migration cops. module MigrationHelpers diff --git a/rubocop/qa_helpers.rb b/rubocop/qa_helpers.rb index f4adf7f4e9f0c..9d6396e412e6a 100644 --- a/rubocop/qa_helpers.rb +++ b/rubocop/qa_helpers.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module RuboCop # Module containing helper methods for writing QA cops. module QAHelpers -- GitLab