diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index f675b785b9cd07820333337e53af3898857be6c7..57c17da243fdddc3d92855a7e2e7780885cfd24f 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -2505,26 +2505,6 @@ Style/FrozenStringLiteralComment: - 'qa/qa/fixtures/auto_devops_rack/Rakefile' - 'qa/qa/fixtures/auto_devops_rack/config.ru' - 'qa/qa/page/page_concern.rb' - - 'rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb' - - 'rubocop/cop/gitlab/finder_with_find_by.rb' - - 'rubocop/cop/gitlab/keys-first-and-values-first.rb' - - 'rubocop/cop/gitlab/module_with_instance_variables.rb' - - 'rubocop/cop/gitlab/predicate_memoization.rb' - - 'rubocop/cop/migration/add_concurrent_foreign_key.rb' - - 'rubocop/cop/migration/add_concurrent_index.rb' - - 'rubocop/cop/migration/add_index.rb' - - 'rubocop/cop/migration/add_timestamps.rb' - - 'rubocop/cop/migration/datetime.rb' - - 'rubocop/cop/migration/hash_index.rb' - - 'rubocop/cop/migration/remove_column.rb' - - 'rubocop/cop/migration/remove_concurrent_index.rb' - - 'rubocop/cop/migration/remove_index.rb' - - 'rubocop/cop/migration/safer_boolean_column.rb' - - 'rubocop/cop/migration/timestamps.rb' - - 'rubocop/cop/migration/update_column_in_batches.rb' - - 'rubocop/cop/project_path_helper.rb' - - 'rubocop/migration_helpers.rb' - - 'rubocop/qa_helpers.rb' - 'scripts/flaky_examples/detect-new-flaky-examples' - 'scripts/flaky_examples/prune-old-flaky-examples' - 'scripts/gather-test-memory-data' diff --git a/rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb b/rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb index eba38c1630f481a1ffe1b6e02fbf9fefc6df7f7f..e1c6a984e751fe1b9c6c438ef37aa5e12475f1b8 100644 --- a/rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb +++ b/rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module RuboCop module Cop # Cop that blacklists keyword arguments usage in Sidekiq workers diff --git a/rubocop/cop/gitlab/finder_with_find_by.rb b/rubocop/cop/gitlab/finder_with_find_by.rb index 764a5073143ca0cfbd2a57a54c344b67b9ef5129..8fa9fe4a2f953c3e7525e0e7974f6537668ff19a 100644 --- a/rubocop/cop/gitlab/finder_with_find_by.rb +++ b/rubocop/cop/gitlab/finder_with_find_by.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module RuboCop module Cop module Gitlab diff --git a/rubocop/cop/gitlab/keys-first-and-values-first.rb b/rubocop/cop/gitlab/keys-first-and-values-first.rb index 544f980030412a7f798b84877902764908aa82cb..e9bf266cdd73ad038a34e30e72970605069fe311 100644 --- a/rubocop/cop/gitlab/keys-first-and-values-first.rb +++ b/rubocop/cop/gitlab/keys-first-and-values-first.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module RuboCop module Cop module Gitlab diff --git a/rubocop/cop/migration/add_concurrent_foreign_key.rb b/rubocop/cop/migration/add_concurrent_foreign_key.rb index 31cf426b2d4ceaa636358241210e4acb7a120bf2..957bd30af63d4a9da3d82890a6e1b936945de2b1 100644 --- a/rubocop/cop/migration/add_concurrent_foreign_key.rb +++ b/rubocop/cop/migration/add_concurrent_foreign_key.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/add_concurrent_index.rb b/rubocop/cop/migration/add_concurrent_index.rb index a2e4ac72565098d42543cb968fc7aff7457a10c0..510f98ce3734598606af5b4c186a6375213cc38a 100644 --- a/rubocop/cop/migration/add_concurrent_index.rb +++ b/rubocop/cop/migration/add_concurrent_index.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/add_index.rb b/rubocop/cop/migration/add_index.rb index 4aea3c0cce30adc70603b92ccf8dbfa14b289b9b..7415880e554c28be9529e9583b725b7ea7516c19 100644 --- a/rubocop/cop/migration/add_index.rb +++ b/rubocop/cop/migration/add_index.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/add_timestamps.rb b/rubocop/cop/migration/add_timestamps.rb index ba32d6a9960a391112e38157ecfca5c362035c3a..d16e8b1f45bac65f094af89c1d59e52a1cff6ff8 100644 --- a/rubocop/cop/migration/add_timestamps.rb +++ b/rubocop/cop/migration/add_timestamps.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/datetime.rb b/rubocop/cop/migration/datetime.rb index 5a6cdc74ca45d03d0fdac8ab0981d2a517cd5686..51e0c3e5a22707e384d8afefdad1e953aa4684d0 100644 --- a/rubocop/cop/migration/datetime.rb +++ b/rubocop/cop/migration/datetime.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/hash_index.rb b/rubocop/cop/migration/hash_index.rb index 3206b73bd3dfe2785ad0821051eca43efd5d8fc6..dba202ef0e320f47d09056855d17d2f283b353ae 100644 --- a/rubocop/cop/migration/hash_index.rb +++ b/rubocop/cop/migration/hash_index.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require 'set' require_relative '../../migration_helpers' diff --git a/rubocop/cop/migration/remove_column.rb b/rubocop/cop/migration/remove_column.rb index fffb4ab7fabe07291bc07c9397331ca32dfbfd07..f63df71467cbe76ca10dfa484ae2f244992865fe 100644 --- a/rubocop/cop/migration/remove_column.rb +++ b/rubocop/cop/migration/remove_column.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/remove_concurrent_index.rb b/rubocop/cop/migration/remove_concurrent_index.rb index 2328740cf36d3f28f48649d38268e29609fcecf3..8c2c6fb157e7e5d38b72ec62a099bf4a49c791b3 100644 --- a/rubocop/cop/migration/remove_concurrent_index.rb +++ b/rubocop/cop/migration/remove_concurrent_index.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/remove_index.rb b/rubocop/cop/migration/remove_index.rb index 4df3b1ba756fea455a28d47826d4836479caf917..15c2f37b4b0c8d906a9c37bd1972c0e4961c8634 100644 --- a/rubocop/cop/migration/remove_index.rb +++ b/rubocop/cop/migration/remove_index.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/safer_boolean_column.rb b/rubocop/cop/migration/safer_boolean_column.rb index 22d5d37a83dcb88efe41f22df95d6146973f3d2a..06bb24707bd38afcd6071bffc1a3c20f36b9cb6c 100644 --- a/rubocop/cop/migration/safer_boolean_column.rb +++ b/rubocop/cop/migration/safer_boolean_column.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/timestamps.rb b/rubocop/cop/migration/timestamps.rb index 6cf5648b9967629df443c9019b70cbc672e151ed..5584d49ee8c6b8073c12f2529c99858477280e54 100644 --- a/rubocop/cop/migration/timestamps.rb +++ b/rubocop/cop/migration/timestamps.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/migration/update_column_in_batches.rb b/rubocop/cop/migration/update_column_in_batches.rb index b1c43393f6a907e92b243d6aaedec3286f81bb57..d23e0d283800a31f649001b32817e506fbbad007 100644 --- a/rubocop/cop/migration/update_column_in_batches.rb +++ b/rubocop/cop/migration/update_column_in_batches.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative '../../migration_helpers' module RuboCop diff --git a/rubocop/cop/project_path_helper.rb b/rubocop/cop/project_path_helper.rb index f3810622eb1a8e4bd9aed740927093e5ef51f091..bc2454e5b1f947e4f952f763a225ee44e71b6158 100644 --- a/rubocop/cop/project_path_helper.rb +++ b/rubocop/cop/project_path_helper.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module RuboCop module Cop class ProjectPathHelper < RuboCop::Cop::Cop diff --git a/rubocop/migration_helpers.rb b/rubocop/migration_helpers.rb index dffceb2b2c867ea180b7072f0dea3c942e541674..63b3766e12681776f06ea1349053d3ed9eb952de 100644 --- a/rubocop/migration_helpers.rb +++ b/rubocop/migration_helpers.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module RuboCop # Module containing helper methods for writing migration cops. module MigrationHelpers diff --git a/rubocop/qa_helpers.rb b/rubocop/qa_helpers.rb index f4adf7f4e9f0ce9e44c82ea531ac32f0fad67da8..9d6396e412e6aaa2ec1294b3a8fa0b2e0a772a62 100644 --- a/rubocop/qa_helpers.rb +++ b/rubocop/qa_helpers.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module RuboCop # Module containing helper methods for writing QA cops. module QAHelpers