From 9e22a038dda206da801d4783522d1efcd3ee31c2 Mon Sep 17 00:00:00 2001 From: Auto-quarantining bot <gitlab-auto-quarantine-bot@gitlab.com> Date: Thu, 25 Jul 2024 03:14:51 +0000 Subject: [PATCH] Quarantine a flaky test The `` Gitlab::Llm::Chain::Tools::SummarizeComments::ExecutorOld#execute when issue is identified when user has permission to read resource when resource has comments to summarize with raw_ai_response: true returns content when no block is given `` test has either ~"flakiness::1" or ~"flakiness::2" label set, which means the number of reported failures is at or above 95 percentile, indicating unusually high failure count. This MR quarantines the test. This is a discussion starting point to let the responsible group know about the flakiness so that they can take action: - accept the merge request and schedule the associated issue to improve the test - close the merge request in favor of another merge request to delete the test Please follow the [Flaky tests management process](https://handbook.gitlab.com/handbook/engineering/infrastructure/engineering-productivity/flaky-tests-management-and-processes/#flaky-tests-management-process) to help us increase `master` stability. Please let us know your feedback in the [Engineering Productivity issue tracker](https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues). Related to https://gitlab.com/gitlab-org/gitlab/-/issues/472968. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::QuarantineFlakyTests keep. To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other --- .../llm/chain/tools/summarize_comments/executor_old_spec.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ee/spec/lib/gitlab/llm/chain/tools/summarize_comments/executor_old_spec.rb b/ee/spec/lib/gitlab/llm/chain/tools/summarize_comments/executor_old_spec.rb index 9b651bd46c538..2d9e52fc41827 100644 --- a/ee/spec/lib/gitlab/llm/chain/tools/summarize_comments/executor_old_spec.rb +++ b/ee/spec/lib/gitlab/llm/chain/tools/summarize_comments/executor_old_spec.rb @@ -110,7 +110,8 @@ expect { |b| tool.execute(&b) }.to yield_successive_args("some", " response") end - it 'returns content when no block is given' do + it 'returns content when no block is given', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/472968' do expect(tool).to receive(:request).and_return('some response') expect(tool.execute.content).to eq('some response') -- GitLab