From 9c5d5dcbb051c5fe82f9581e53538d348023b59a Mon Sep 17 00:00:00 2001
From: Roy Zwambag <rzwambag@gitlab.com>
Date: Thu, 10 Feb 2022 16:34:23 +0100
Subject: [PATCH] Move memoryReportPath to a computed property and remove
brackets
---
.../performance_bar/components/performance_bar_app.vue | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/assets/javascripts/performance_bar/components/performance_bar_app.vue b/app/assets/javascripts/performance_bar/components/performance_bar_app.vue
index 20fdd98cf3c5f..710f49b833c89 100644
--- a/app/assets/javascripts/performance_bar/components/performance_bar_app.vue
+++ b/app/assets/javascripts/performance_bar/components/performance_bar_app.vue
@@ -124,6 +124,9 @@ export default {
const fileName = this.requests[0].truncatedUrl;
return `${fileName}_perf_bar_${Date.now()}.json`;
},
+ memoryReportPath() {
+ return mergeUrlParams({ performance_bar: 'memory' }, window.location.href);
+ },
},
mounted() {
this.currentRequest = this.requestId;
@@ -138,9 +141,6 @@ export default {
window.location.href,
);
},
- memoryReportPath() {
- return mergeUrlParams({ performance_bar: 'memory' }, window.location.href);
- },
},
safeHtmlConfig: { ADD_TAGS: ['gl-emoji'] },
};
@@ -190,7 +190,7 @@ export default {
id="peek-memory-report"
class="view"
>
- <a class="gl-text-blue-200" :href="memoryReportPath()">{{
+ <a class="gl-text-blue-200" :href="memoryReportPath">{{
s__('PerformanceBar|Memory report')
}}</a>
</div>
--
GitLab