From 94fc293a4c28fce78be849d68c48588195b71381 Mon Sep 17 00:00:00 2001
From: Tan Le <tle@gitlab.com>
Date: Mon, 11 Sep 2023 23:41:56 +1000
Subject: [PATCH] Fix Rubocop Style/PercentLiteralDelimiters offence
- `config/**`
- `ee/app/**`
---
.../style/percent_literal_delimiters.yml | 67 -------------------
config/application.rb | 26 +++----
config/boot.rb | 2 +-
config/environments/production.rb | 2 +-
config/initializers/1_settings.rb | 4 +-
.../initializers/content_security_policy.rb | 2 +-
config/initializers/doorkeeper.rb | 2 +-
config/initializers/enumerator_next_patch.rb | 4 +-
config/initializers/fog_core_patch.rb | 2 +-
.../forbid_sidekiq_in_transactions.rb | 4 +-
config/initializers/health_check.rb | 4 +-
config/initializers/invisible_captcha.rb | 2 +-
config/initializers/lograge.rb | 2 +-
config/initializers/rspec_profiling.rb | 4 +-
.../000_inflections.rb | 4 +-
config/object_store_settings.rb | 8 +--
config/spring.rb | 4 +-
.../admin/application_settings_controller.rb | 2 +-
.../ee/projects/service_desk_controller.rb | 2 +-
.../git_http_client_controller.rb | 4 +-
.../protected_environments_controller.rb | 2 +-
.../integrations/jira/issues_controller.rb | 2 +-
.../protected_environments_controller.rb | 2 +-
ee/app/finders/iterations_finder.rb | 2 +-
.../oncall_rotation_date_input_type.rb | 2 +-
.../helpers/credentials_inventory_helper.rb | 2 +-
ee/app/helpers/ee/auth_helper.rb | 6 +-
ee/app/helpers/ee/dashboard_helper.rb | 12 ++--
ee/app/helpers/ee/integrations_helper.rb | 4 +-
ee/app/helpers/ee/issues_helper.rb | 2 +-
ee/app/helpers/ee/labels_helper.rb | 2 +-
ee/app/helpers/ee/nav_helper.rb | 2 +-
.../ci_minutes_usage_mailer_preview.rb | 4 +-
.../namespace_storage_usage_mailer_preview.rb | 4 +-
.../previews/license_mailer_preview.rb | 2 +-
.../app_sec/fuzzing/api/scan_profile.rb | 2 +-
.../models/app_sec/fuzzing/coverage/corpus.rb | 2 +-
.../concerns/ee/issue_available_features.rb | 8 +--
ee/app/models/ee/audit_event.rb | 2 +-
ee/app/models/ee/description_version.rb | 2 +-
ee/app/models/ee/groups/feature_setting.rb | 2 +-
ee/app/models/ee/issue.rb | 2 +-
ee/app/models/ee/project_feature.rb | 10 +--
ee/app/models/ee/resource_label_event.rb | 2 +-
ee/app/models/ee/resource_state_event.rb | 2 +-
ee/app/models/ee/user.rb | 2 +-
ee/app/models/ee/vulnerability.rb | 4 +-
ee/app/models/geo/project_registry.rb | 2 +-
ee/app/models/geo/secondary_usage_data.rb | 4 +-
ee/app/models/geo_node_status.rb | 4 +-
.../issuable_resource_link.rb | 2 +-
ee/app/models/integrations/github.rb | 2 +-
.../merge_requests/status_check_response.rb | 2 +-
ee/app/models/saml_provider.rb | 6 +-
.../orchestration_policy_configuration.rb | 2 +-
ee/app/models/software_license_policy.rb | 2 +-
ee/app/models/storage_shard.rb | 2 +-
.../services/approval_rules/create_service.rb | 2 +-
.../boards/epic_boards/update_service.rb | 4 +-
ee/app/services/ee/boards/update_service.rb | 2 +-
ee/app/services/ee/search/group_service.rb | 2 +-
ee/app/services/ee/search/project_service.rb | 2 +-
ee/app/services/epics/tree_reorder_service.rb | 2 +-
ee/app/services/iterations/update_service.rb | 2 +-
ee/app/services/jira/jql_builder_service.rb | 18 ++---
.../configuration/save_auto_fix_service.rb | 2 +-
.../security/dependency_list_service.rb | 8 +--
.../tasks/update_vulnerability_uuids.rb | 2 +-
68 files changed, 124 insertions(+), 191 deletions(-)
diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml
index 1aedbdb170417..c123e7ebcfab7 100644
--- a/.rubocop_todo/style/percent_literal_delimiters.yml
+++ b/.rubocop_todo/style/percent_literal_delimiters.yml
@@ -2,73 +2,6 @@
# Cop supports --autocorrect.
Style/PercentLiteralDelimiters:
Exclude:
- - 'config/application.rb'
- - 'config/boot.rb'
- - 'config/environments/production.rb'
- - 'config/initializers/1_settings.rb'
- - 'config/initializers/content_security_policy.rb'
- - 'config/initializers/doorkeeper.rb'
- - 'config/initializers/enumerator_next_patch.rb'
- - 'config/initializers/fog_core_patch.rb'
- - 'config/initializers/forbid_sidekiq_in_transactions.rb'
- - 'config/initializers/health_check.rb'
- - 'config/initializers/invisible_captcha.rb'
- - 'config/initializers/lograge.rb'
- - 'config/initializers/rspec_profiling.rb'
- - 'config/initializers_before_autoloader/000_inflections.rb'
- - 'config/object_store_settings.rb'
- - 'config/spring.rb'
- - 'ee/app/controllers/ee/admin/application_settings_controller.rb'
- - 'ee/app/controllers/ee/projects/service_desk_controller.rb'
- - 'ee/app/controllers/ee/repositories/git_http_client_controller.rb'
- - 'ee/app/controllers/groups/protected_environments_controller.rb'
- - 'ee/app/controllers/projects/integrations/jira/issues_controller.rb'
- - 'ee/app/controllers/projects/protected_environments_controller.rb'
- - 'ee/app/finders/iterations_finder.rb'
- - 'ee/app/graphql/types/incident_management/oncall_rotation_date_input_type.rb'
- - 'ee/app/helpers/credentials_inventory_helper.rb'
- - 'ee/app/helpers/ee/auth_helper.rb'
- - 'ee/app/helpers/ee/dashboard_helper.rb'
- - 'ee/app/helpers/ee/integrations_helper.rb'
- - 'ee/app/helpers/ee/issues_helper.rb'
- - 'ee/app/helpers/ee/labels_helper.rb'
- - 'ee/app/helpers/ee/nav_helper.rb'
- - 'ee/app/mailers/previews/ci_minutes_usage_mailer_preview.rb'
- - 'ee/app/mailers/previews/emails/namespace_storage_usage_mailer_preview.rb'
- - 'ee/app/mailers/previews/license_mailer_preview.rb'
- - 'ee/app/models/app_sec/fuzzing/api/scan_profile.rb'
- - 'ee/app/models/app_sec/fuzzing/coverage/corpus.rb'
- - 'ee/app/models/concerns/ee/issue_available_features.rb'
- - 'ee/app/models/ee/audit_event.rb'
- - 'ee/app/models/ee/description_version.rb'
- - 'ee/app/models/ee/groups/feature_setting.rb'
- - 'ee/app/models/ee/issue.rb'
- - 'ee/app/models/ee/project_feature.rb'
- - 'ee/app/models/ee/resource_label_event.rb'
- - 'ee/app/models/ee/resource_state_event.rb'
- - 'ee/app/models/ee/user.rb'
- - 'ee/app/models/ee/vulnerability.rb'
- - 'ee/app/models/geo/project_registry.rb'
- - 'ee/app/models/geo/secondary_usage_data.rb'
- - 'ee/app/models/geo_node_status.rb'
- - 'ee/app/models/incident_management/issuable_resource_link.rb'
- - 'ee/app/models/integrations/github.rb'
- - 'ee/app/models/merge_requests/status_check_response.rb'
- - 'ee/app/models/saml_provider.rb'
- - 'ee/app/models/security/orchestration_policy_configuration.rb'
- - 'ee/app/models/software_license_policy.rb'
- - 'ee/app/models/storage_shard.rb'
- - 'ee/app/services/approval_rules/create_service.rb'
- - 'ee/app/services/boards/epic_boards/update_service.rb'
- - 'ee/app/services/ee/boards/update_service.rb'
- - 'ee/app/services/ee/search/group_service.rb'
- - 'ee/app/services/ee/search/project_service.rb'
- - 'ee/app/services/epics/tree_reorder_service.rb'
- - 'ee/app/services/iterations/update_service.rb'
- - 'ee/app/services/jira/jql_builder_service.rb'
- - 'ee/app/services/security/configuration/save_auto_fix_service.rb'
- - 'ee/app/services/security/dependency_list_service.rb'
- - 'ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb'
- 'ee/lib/api/status_checks.rb'
- 'ee/lib/api/visual_review_discussions.rb'
- 'ee/lib/ee/api/helpers/members_helpers.rb'
diff --git a/config/application.rb b/config/application.rb
index 3f095ee0e1038..8c85e028ada1f 100644
--- a/config/application.rb
+++ b/config/application.rb
@@ -213,7 +213,7 @@ class Application < Rails::Application
/^title$/,
/^hook$/
]
- config.filter_parameters += %i(
+ config.filter_parameters += %i[
certificate
encrypted_key
import_url
@@ -230,7 +230,7 @@ class Application < Rails::Application
sharedSecret
redirect
question
- )
+ ]
# This config option can be removed after Rails 7.1 by https://gitlab.com/gitlab-org/gitlab/-/issues/416270
config.active_support.use_rfc4122_namespaced_uuids = true
@@ -460,30 +460,30 @@ class Application < Rails::Application
allow do
origins { |source, env| source == Gitlab::CurrentSettings.jira_connect_proxy_url }
- resource '/-/jira_connect/oauth_application_id', headers: :any, credentials: false, methods: %i(get options)
+ resource '/-/jira_connect/oauth_application_id', headers: :any, credentials: false, methods: %i[get options]
end
allow do
origins { |source, env| source == Gitlab::CurrentSettings.jira_connect_proxy_url }
- resource '/-/jira_connect/subscriptions.json', headers: :any, credentials: false, methods: %i(get options)
+ resource '/-/jira_connect/subscriptions.json', headers: :any, credentials: false, methods: %i[get options]
end
allow do
origins { |source, env| source == Gitlab::CurrentSettings.jira_connect_proxy_url }
- resource '/-/jira_connect/subscriptions/*', headers: :any, credentials: false, methods: %i(delete options)
+ resource '/-/jira_connect/subscriptions/*', headers: :any, credentials: false, methods: %i[delete options]
end
# Cross-origin requests must be enabled for the Authorization code with PKCE OAuth flow when used from a browser.
- %w(/oauth/token /oauth/revoke).each do |oauth_path|
+ %w[/oauth/token /oauth/revoke].each do |oauth_path|
allow do
origins '*'
resource oauth_path,
# These headers are added as defaults to axios.
# See: https://gitlab.com/gitlab-org/gitlab/-/blob/dd1e70d3676891025534dc4a1e89ca9383178fe7/app/assets/javascripts/lib/utils/axios_utils.js#L8)
# It's added to declare that this is a XHR request and add the CSRF token without which Rails may reject the request from the frontend.
- headers: %w(Authorization X-CSRF-Token X-Requested-With),
+ headers: %w[Authorization X-CSRF-Token X-Requested-With],
credentials: false,
- methods: %i(post options)
+ methods: %i[post options]
end
end
@@ -492,17 +492,17 @@ class Application < Rails::Application
allow do
origins '*'
resource '/oauth/userinfo',
- headers: %w(Authorization),
+ headers: %w[Authorization],
credentials: false,
- methods: %i(get head post options)
+ methods: %i[get head post options]
end
- %w(/oauth/discovery/keys /.well-known/openid-configuration /.well-known/webfinger).each do |openid_path|
+ %w[/oauth/discovery/keys /.well-known/openid-configuration /.well-known/webfinger].each do |openid_path|
allow do
origins '*'
resource openid_path,
credentials: false,
- methods: %i(get head)
+ methods: %i[get head]
end
end
@@ -512,7 +512,7 @@ class Application < Rails::Application
origins 'https://*.web-ide.gitlab-static.net'
resource '/assets/webpack/*',
credentials: false,
- methods: %i(get head)
+ methods: %i[get head]
end
end
diff --git a/config/boot.rb b/config/boot.rb
index ec9470bc5062e..1b3f2935e3f90 100644
--- a/config/boot.rb
+++ b/config/boot.rb
@@ -3,4 +3,4 @@
require_relative 'bundler_setup'
enable_bootsnap_default_value = ENV['RAILS_ENV'] != 'production' ? '1' : '0'
-require 'bootsnap/setup' if %w(1 yes true).include?(ENV.fetch('ENABLE_BOOTSNAP', enable_bootsnap_default_value))
+require 'bootsnap/setup' if %w[1 yes true].include?(ENV.fetch('ENABLE_BOOTSNAP', enable_bootsnap_default_value))
diff --git a/config/environments/production.rb b/config/environments/production.rb
index 8372331024f4c..931677b4ad707 100644
--- a/config/environments/production.rb
+++ b/config/environments/production.rb
@@ -43,7 +43,7 @@
# Suppress 'Rendered template ...' messages in the log
# source: http://stackoverflow.com/a/16369363
- %w{render_template render_partial render_collection}.each do |event|
+ %w[render_template render_partial render_collection].each do |event|
ActiveSupport::Notifications.unsubscribe "#{event}.action_view"
end
diff --git a/config/initializers/1_settings.rb b/config/initializers/1_settings.rb
index bf6db9895156e..4b074a2925db0 100644
--- a/config/initializers/1_settings.rb
+++ b/config/initializers/1_settings.rb
@@ -121,7 +121,7 @@
Settings.omniauth.providers.delete_if { |p| p.name == 'kerberos' }
kerberos_spnego['name'] = 'kerberos'
- omniauth_keys = %w(allow_single_sign_on auto_link_user external_providers sync_profile_from_provider allow_bypass_two_factor)
+ omniauth_keys = %w[allow_single_sign_on auto_link_user external_providers sync_profile_from_provider allow_bypass_two_factor]
omniauth_keys.each do |key|
next unless Settings.omniauth[key].is_a?(Array)
@@ -1086,7 +1086,7 @@
Settings['rack_attack'] ||= {}
Settings.rack_attack['git_basic_auth'] ||= {}
Settings.rack_attack.git_basic_auth['enabled'] = false if Settings.rack_attack.git_basic_auth['enabled'].nil?
-Settings.rack_attack.git_basic_auth['ip_whitelist'] ||= %w{127.0.0.1}
+Settings.rack_attack.git_basic_auth['ip_whitelist'] ||= %w[127.0.0.1]
Settings.rack_attack.git_basic_auth['maxretry'] ||= 10
Settings.rack_attack.git_basic_auth['findtime'] ||= 1.minute
Settings.rack_attack.git_basic_auth['bantime'] ||= 1.hour
diff --git a/config/initializers/content_security_policy.rb b/config/initializers/content_security_policy.rb
index f7c3f4e98b55c..4ab94797f26f1 100644
--- a/config/initializers/content_security_policy.rb
+++ b/config/initializers/content_security_policy.rb
@@ -15,5 +15,5 @@
Rails.application.config.content_security_policy_report_only = csp_settings['report_only']
Rails.application.config.content_security_policy_nonce_generator = ->(request) { SecureRandom.base64(16) }
- Rails.application.config.content_security_policy_nonce_directives = %w(script-src)
+ Rails.application.config.content_security_policy_nonce_directives = %w[script-src]
end
diff --git a/config/initializers/doorkeeper.rb b/config/initializers/doorkeeper.rb
index 73608a367d844..9c553b018c533 100644
--- a/config/initializers/doorkeeper.rb
+++ b/config/initializers/doorkeeper.rb
@@ -101,7 +101,7 @@
# "password" => Resource Owner Password Credentials Grant Flow
# "client_credentials" => Client Credentials Grant Flow
#
- grant_flows %w(authorization_code password client_credentials)
+ grant_flows %w[authorization_code password client_credentials]
# Under some circumstances you might want to have applications auto-approved,
# so that the user skips the authorization step.
diff --git a/config/initializers/enumerator_next_patch.rb b/config/initializers/enumerator_next_patch.rb
index e1fc04731ae5c..3771864fb918e 100644
--- a/config/initializers/enumerator_next_patch.rb
+++ b/config/initializers/enumerator_next_patch.rb
@@ -4,7 +4,7 @@
# when an error is raised from within a Fiber.
# https://bugs.ruby-lang.org/issues/16829
module EnumeratorNextPatch
- %w(next next_values peek peek_values).each do |name|
+ %w[next next_values peek peek_values].each do |name|
define_method(name) do |*args|
gitlab_patch_backtrace_marker { super(*args) }
rescue Exception => err # rubocop: disable Lint/RescueException
@@ -27,7 +27,7 @@ def gitlab_patch_backtrace_marker
# #gitlab_patch_backtrace_marker calls a block, which in turn calls #next.) If it's generated
# by the Fiber that #next invokes, then it won't contain this marker.
def has_gitlab_patch_backtrace_marker?(backtrace)
- match = %r(^(.*):[0-9]+:in `gitlab_patch_backtrace_marker'$).match(backtrace[2])
+ match = %r{^(.*):[0-9]+:in `gitlab_patch_backtrace_marker'$}.match(backtrace[2])
!!match && match[1] == __FILE__
end
diff --git a/config/initializers/fog_core_patch.rb b/config/initializers/fog_core_patch.rb
index f7d81f26be5c9..d0868116a7a3d 100644
--- a/config/initializers/fog_core_patch.rb
+++ b/config/initializers/fog_core_patch.rb
@@ -31,7 +31,7 @@
module Fog
module ServicesMixin
# Gems that have not yet updated with the new fog-core namespace
- LEGACY_FOG_PROVIDERS = %w(google aliyun).freeze
+ LEGACY_FOG_PROVIDERS = %w[google aliyun].freeze
# rubocop:disable Gitlab/ConstGetInheritFalse
def service_provider_constant(service_name, provider_name)
diff --git a/config/initializers/forbid_sidekiq_in_transactions.rb b/config/initializers/forbid_sidekiq_in_transactions.rb
index c96524b824d60..6dd12c285151c 100644
--- a/config/initializers/forbid_sidekiq_in_transactions.rb
+++ b/config/initializers/forbid_sidekiq_in_transactions.rb
@@ -36,7 +36,7 @@ def self.raise_inside_transaction_exception(cause:)
module ClassMethods
module NoEnqueueingFromTransactions
- %i(perform_async perform_at perform_in).each do |name|
+ %i[perform_async perform_at perform_in].each do |name|
define_method(name) do |*args|
if Sidekiq::Worker.raise_exception_for_being_inside_a_transaction?
begin
@@ -65,7 +65,7 @@ module NoEnqueueingFromTransactions
module ActiveJob
module QueueAdapters
module NoEnqueueingFromTransactions
- %i(enqueue enqueue_at).each do |name|
+ %i[enqueue enqueue_at].each do |name|
define_method(name) do |*args|
if Sidekiq::Worker.raise_exception_for_being_inside_a_transaction?
begin
diff --git a/config/initializers/health_check.rb b/config/initializers/health_check.rb
index 0b35aaf115b4b..a35c757c6fa83 100644
--- a/config/initializers/health_check.rb
+++ b/config/initializers/health_check.rb
@@ -1,8 +1,8 @@
# frozen_string_literal: true
HealthCheck.setup do |config|
- config.standard_checks = %w(database migrations cache)
- config.full_checks = %w(database migrations cache)
+ config.standard_checks = %w[database migrations cache]
+ config.full_checks = %w[database migrations cache]
Gitlab.ee do
config.add_custom_check('geo') do
diff --git a/config/initializers/invisible_captcha.rb b/config/initializers/invisible_captcha.rb
index 5177c73059636..499217a6d56af 100644
--- a/config/initializers/invisible_captcha.rb
+++ b/config/initializers/invisible_captcha.rb
@@ -1,7 +1,7 @@
# frozen_string_literal: true
InvisibleCaptcha.setup do |config|
- config.honeypots = %w(firstname lastname)
+ config.honeypots = %w[firstname lastname]
config.timestamp_enabled = true
config.timestamp_threshold = 4
end
diff --git a/config/initializers/lograge.rb b/config/initializers/lograge.rb
index 5ea3b55371324..6ed3fff7f46e7 100644
--- a/config/initializers/lograge.rb
+++ b/config/initializers/lograge.rb
@@ -23,7 +23,7 @@
# Remove empty hashes to prevent type mismatches
# These are set to empty hashes in Lograge's ActionCable subscriber
# https://github.com/roidrage/lograge/blob/v0.11.2/lib/lograge/log_subscribers/action_cable.rb#L14-L16
- %i(method path format).each do |key|
+ %i[method path format].each do |key|
data[key] = nil if data[key] == {}
end
diff --git a/config/initializers/rspec_profiling.rb b/config/initializers/rspec_profiling.rb
index 7cc2d6afb0f60..b0b7ea85caee3 100644
--- a/config/initializers/rspec_profiling.rb
+++ b/config/initializers/rspec_profiling.rb
@@ -5,8 +5,8 @@
module RspecProfilingExt
module Collectors
class CSVWithTimestamps < ::RspecProfiling::Collectors::CSV
- TIMESTAMP_FIELDS = %w(created_at updated_at).freeze
- METADATA_FIELDS = %w(feature_category).freeze
+ TIMESTAMP_FIELDS = %w[created_at updated_at].freeze
+ METADATA_FIELDS = %w[feature_category].freeze
HEADERS = (::RspecProfiling::Collectors::CSV::HEADERS + TIMESTAMP_FIELDS + METADATA_FIELDS).freeze
def insert(attributes)
diff --git a/config/initializers_before_autoloader/000_inflections.rb b/config/initializers_before_autoloader/000_inflections.rb
index e4f1c48b0b4c2..6f73dbb4d8a70 100644
--- a/config/initializers_before_autoloader/000_inflections.rb
+++ b/config/initializers_before_autoloader/000_inflections.rb
@@ -12,7 +12,7 @@
# end
#
ActiveSupport::Inflector.inflections do |inflect|
- inflect.uncountable %w(
+ inflect.uncountable %w[
custom_emoji
award_emoji
ci_secure_file_registry
@@ -40,7 +40,7 @@
terraform_state_version_registry
vulnerabilities_feedback
vulnerability_feedback
- )
+ ]
inflect.acronym 'CDN'
inflect.acronym 'EE'
inflect.acronym 'JH'
diff --git a/config/object_store_settings.rb b/config/object_store_settings.rb
index 4e8e950c797ab..283cd952c043f 100644
--- a/config/object_store_settings.rb
+++ b/config/object_store_settings.rb
@@ -2,19 +2,19 @@
# Set default values for object_store settings
class ObjectStoreSettings
- SUPPORTED_TYPES = %w(artifacts external_diffs lfs uploads packages dependency_proxy terraform_state pages).freeze
- ALLOWED_OBJECT_STORE_OVERRIDES = %w(bucket enabled proxy_download cdn).freeze
+ SUPPORTED_TYPES = %w[artifacts external_diffs lfs uploads packages dependency_proxy terraform_state pages].freeze
+ ALLOWED_OBJECT_STORE_OVERRIDES = %w[bucket enabled proxy_download cdn].freeze
# To ensure the one Workhorse credential matches the Rails config, we
# enforce consolidated settings on those accelerated
# endpoints. Technically dependency_proxy and terraform_state fall
# into this category, but they will likely be handled by Workhorse in
# the future.
- WORKHORSE_ACCELERATED_TYPES = SUPPORTED_TYPES - %w(pages)
+ WORKHORSE_ACCELERATED_TYPES = SUPPORTED_TYPES - %w[pages]
# pages may be enabled but use legacy disk storage
# we don't need to raise an error in that case
- ALLOWED_INCOMPLETE_TYPES = %w(pages).freeze
+ ALLOWED_INCOMPLETE_TYPES = %w[pages].freeze
attr_accessor :settings
diff --git a/config/spring.rb b/config/spring.rb
index f06a707111ccf..8fb1ae1669de5 100644
--- a/config/spring.rb
+++ b/config/spring.rb
@@ -1,11 +1,11 @@
# frozen_string_literal: true
-%w(
+%w[
.ruby-version
.rbenv-vars
tmp/restart.txt
tmp/caching-dev.txt
-).each { |path| Spring.watch(path) }
+].each { |path| Spring.watch(path) }
Spring.after_fork do
if ENV['DEBUGGER_STORED_RUBYLIB']
diff --git a/ee/app/controllers/ee/admin/application_settings_controller.rb b/ee/app/controllers/ee/admin/application_settings_controller.rb
index ce7fdb91610b1..9e8ef640cb844 100644
--- a/ee/app/controllers/ee/admin/application_settings_controller.rb
+++ b/ee/app/controllers/ee/admin/application_settings_controller.rb
@@ -76,7 +76,7 @@ def scim_token
end
end
- EE_VALID_SETTING_PANELS = %w(advanced_search templates security_and_compliance namespace_storage).freeze
+ EE_VALID_SETTING_PANELS = %w[advanced_search templates security_and_compliance namespace_storage].freeze
EE_VALID_SETTING_PANELS.each do |action|
define_method(action) { perform_update if submitted? }
diff --git a/ee/app/controllers/ee/projects/service_desk_controller.rb b/ee/app/controllers/ee/projects/service_desk_controller.rb
index 09f534ca2ebdb..0c17f5856788a 100644
--- a/ee/app/controllers/ee/projects/service_desk_controller.rb
+++ b/ee/app/controllers/ee/projects/service_desk_controller.rb
@@ -9,7 +9,7 @@ module ServiceDeskController
override :allowed_update_attributes
def allowed_update_attributes
- super + %i(file_template_project_id)
+ super + %i[file_template_project_id]
end
override :service_desk_attributes
diff --git a/ee/app/controllers/ee/repositories/git_http_client_controller.rb b/ee/app/controllers/ee/repositories/git_http_client_controller.rb
index f23520c860445..e3309d129abe0 100644
--- a/ee/app/controllers/ee/repositories/git_http_client_controller.rb
+++ b/ee/app/controllers/ee/repositories/git_http_client_controller.rb
@@ -59,8 +59,8 @@ class GeoRouteHelper
attr_reader :controller_name, :action_name
CONTROLLER_AND_ACTIONS_TO_REDIRECT = {
- 'git_http' => %w{git_receive_pack},
- 'lfs_locks_api' => %w{create unlock verify}
+ 'git_http' => %w[git_receive_pack],
+ 'lfs_locks_api' => %w[create unlock verify]
}.freeze
def initialize(project, controller_name, action_name, service)
diff --git a/ee/app/controllers/groups/protected_environments_controller.rb b/ee/app/controllers/groups/protected_environments_controller.rb
index 40a15a874cd8b..793999d888a83 100644
--- a/ee/app/controllers/groups/protected_environments_controller.rb
+++ b/ee/app/controllers/groups/protected_environments_controller.rb
@@ -59,7 +59,7 @@ def protected_environment_params
end
def deploy_access_level_attributes
- %i(id _destroy group_id)
+ %i[id _destroy group_id]
end
def authorize_admin_protected_environment!
diff --git a/ee/app/controllers/projects/integrations/jira/issues_controller.rb b/ee/app/controllers/projects/integrations/jira/issues_controller.rb
index 6ead608701874..0a024083a1cae 100644
--- a/ee/app/controllers/projects/integrations/jira/issues_controller.rb
+++ b/ee/app/controllers/projects/integrations/jira/issues_controller.rb
@@ -13,7 +13,7 @@ class IssuesController < Projects::ApplicationController
name: 'i_ecosystem_jira_service_list_issues',
action: Integration::SNOWPLOW_EVENT_ACTION,
label: Integration::SNOWPLOW_EVENT_LABEL,
- destinations: %i(redis_hll snowplow)
+ destinations: %i[redis_hll snowplow]
before_action :check_feature_enabled!
diff --git a/ee/app/controllers/projects/protected_environments_controller.rb b/ee/app/controllers/projects/protected_environments_controller.rb
index 69b685d7cedda..5044edd869f44 100644
--- a/ee/app/controllers/projects/protected_environments_controller.rb
+++ b/ee/app/controllers/projects/protected_environments_controller.rb
@@ -61,7 +61,7 @@ def protected_environment_params
end
def deploy_access_level_attributes
- %i(access_level id user_id _destroy group_id)
+ %i[access_level id user_id _destroy group_id]
end
def search_params
diff --git a/ee/app/finders/iterations_finder.rb b/ee/app/finders/iterations_finder.rb
index 1d36c6bd98984..d6f2082f6ec30 100644
--- a/ee/app/finders/iterations_finder.rb
+++ b/ee/app/finders/iterations_finder.rb
@@ -16,7 +16,7 @@ class IterationsFinder
include TimeFrameFilter
include UpdatedAtFilter
- SEARCHABLE_FIELDS = %i(title cadence_title).freeze
+ SEARCHABLE_FIELDS = %i[title cadence_title].freeze
attr_reader :params, :current_user
diff --git a/ee/app/graphql/types/incident_management/oncall_rotation_date_input_type.rb b/ee/app/graphql/types/incident_management/oncall_rotation_date_input_type.rb
index 416506ee2f064..1a57f0a4fd9d1 100644
--- a/ee/app/graphql/types/incident_management/oncall_rotation_date_input_type.rb
+++ b/ee/app/graphql/types/incident_management/oncall_rotation_date_input_type.rb
@@ -15,7 +15,7 @@ class OncallRotationDateInputType < BaseInputObject
description: 'Time component of the date in 24hr HH:MM format.'
DATE_FORMAT = %r[^\d{4}-[0123]\d-\d{2}$]
- TIME_FORMAT = %r[^(0\d|1\d|2[0-3]):[0-5]\d$]
+ TIME_FORMAT = %r{^(0\d|1\d|2[0-3]):[0-5]\d$}
def prepare
raise Gitlab::Graphql::Errors::ArgumentError, 'Date given is invalid' unless DATE_FORMAT.match?(date)
diff --git a/ee/app/helpers/credentials_inventory_helper.rb b/ee/app/helpers/credentials_inventory_helper.rb
index c43d97804a0bd..fe93cbcc02b8c 100644
--- a/ee/app/helpers/credentials_inventory_helper.rb
+++ b/ee/app/helpers/credentials_inventory_helper.rb
@@ -1,7 +1,7 @@
# frozen_string_literal: true
module CredentialsInventoryHelper
- VALID_FILTERS = %w(ssh_keys personal_access_tokens gpg_keys resource_access_tokens).freeze
+ VALID_FILTERS = %w[ssh_keys personal_access_tokens gpg_keys resource_access_tokens].freeze
def show_personal_access_tokens?
return true if params[:filter] == 'personal_access_tokens'
diff --git a/ee/app/helpers/ee/auth_helper.rb b/ee/app/helpers/ee/auth_helper.rb
index 40c6c317dca3f..b1b6315453788 100644
--- a/ee/app/helpers/ee/auth_helper.rb
+++ b/ee/app/helpers/ee/auth_helper.rb
@@ -4,10 +4,10 @@ module EE
module AuthHelper
extend ::Gitlab::Utils::Override
- PROVIDERS_WITH_ICONS = %w(
+ PROVIDERS_WITH_ICONS = %w[
kerberos
- ).freeze
- GROUP_LEVEL_PROVIDERS = %i(group_saml).freeze
+ ].freeze
+ GROUP_LEVEL_PROVIDERS = %i[group_saml].freeze
override :display_providers_on_profile?
def display_providers_on_profile?
diff --git a/ee/app/helpers/ee/dashboard_helper.rb b/ee/app/helpers/ee/dashboard_helper.rb
index 952302f08d233..7b36f6679e958 100644
--- a/ee/app/helpers/ee/dashboard_helper.rb
+++ b/ee/app/helpers/ee/dashboard_helper.rb
@@ -7,17 +7,17 @@ module DashboardHelper
def controller_action_to_child_dashboards(controller = controller_name, action = action_name)
case "#{controller}##{action}"
when 'projects#index', 'root#index', 'projects#starred', 'projects#trending'
- %w(projects)
+ %w[projects]
when 'dashboard#activity'
- %w(starred_project_activity project_activity)
+ %w[starred_project_activity project_activity]
when 'groups#index'
- %w(groups)
+ %w[groups]
when 'todos#index'
- %w(todos)
+ %w[todos]
when 'dashboard#issues'
- %w(issues)
+ %w[issues]
when 'dashboard#merge_requests'
- %w(merge_requests)
+ %w[merge_requests]
else
[]
end
diff --git a/ee/app/helpers/ee/integrations_helper.rb b/ee/app/helpers/ee/integrations_helper.rb
index b95df04ad46b0..c1d19a60400e3 100644
--- a/ee/app/helpers/ee/integrations_helper.rb
+++ b/ee/app/helpers/ee/integrations_helper.rb
@@ -79,8 +79,8 @@ def external_issue_breadcrumb_link(img, text, href, options = {})
class: 'gl-display-flex gl-align-items-center gl-white-space-nowrap'
)
),
- tags: %w(a img),
- attributes: %w(target href src loading rel class width height)
+ tags: %w[a img],
+ attributes: %w[target href src loading rel class width height]
)
[icon, link].join.html_safe
diff --git a/ee/app/helpers/ee/issues_helper.rb b/ee/app/helpers/ee/issues_helper.rb
index f0a44c9b81a5c..495f325342393 100644
--- a/ee/app/helpers/ee/issues_helper.rb
+++ b/ee/app/helpers/ee/issues_helper.rb
@@ -7,7 +7,7 @@ module IssuesHelper
def issue_in_subepic?(issue, epic_id)
# This helper is used if a list of issues are filtered by epic id
return false if epic_id.blank?
- return false if %w(any none).include?(epic_id)
+ return false if %w[any none].include?(epic_id)
return false if issue.epic_issue.nil?
# An issue is member of a subepic when its epic id is different
diff --git a/ee/app/helpers/ee/labels_helper.rb b/ee/app/helpers/ee/labels_helper.rb
index a9e0d1da0f25b..4d3c782f47f25 100644
--- a/ee/app/helpers/ee/labels_helper.rb
+++ b/ee/app/helpers/ee/labels_helper.rb
@@ -25,7 +25,7 @@ def render_colored_label(label, suffix: '')
def wrap_label_html(label_html, small:, label:)
return super unless label.scoped_label?
- wrapper_classes = %w(gl-label gl-label-scoped)
+ wrapper_classes = %w[gl-label gl-label-scoped]
wrapper_classes << 'gl-label-sm' if small
border_width = small ? '1px' : '2px'
diff --git a/ee/app/helpers/ee/nav_helper.rb b/ee/app/helpers/ee/nav_helper.rb
index 8873d3b3f8468..b058723091b75 100644
--- a/ee/app/helpers/ee/nav_helper.rb
+++ b/ee/app/helpers/ee/nav_helper.rb
@@ -11,7 +11,7 @@ def page_has_markdown?
override :admin_monitoring_nav_links
def admin_monitoring_nav_links
- controllers = %w(audit_logs)
+ controllers = %w[audit_logs]
super.concat(controllers)
end
end
diff --git a/ee/app/mailers/previews/ci_minutes_usage_mailer_preview.rb b/ee/app/mailers/previews/ci_minutes_usage_mailer_preview.rb
index dddd2790a0420..47bb147b03baa 100644
--- a/ee/app/mailers/previews/ci_minutes_usage_mailer_preview.rb
+++ b/ee/app/mailers/previews/ci_minutes_usage_mailer_preview.rb
@@ -2,10 +2,10 @@
class CiMinutesUsageMailerPreview < ActionMailer::Preview
def out_of_minutes
- ::CiMinutesUsageMailer.notify(Group.last, %w(bob@example.com))
+ ::CiMinutesUsageMailer.notify(Group.last, %w[bob@example.com])
end
def limit_warning
- ::CiMinutesUsageMailer.notify_limit(Group.last, %w(bob@example.com), 30)
+ ::CiMinutesUsageMailer.notify_limit(Group.last, %w[bob@example.com], 30)
end
end
diff --git a/ee/app/mailers/previews/emails/namespace_storage_usage_mailer_preview.rb b/ee/app/mailers/previews/emails/namespace_storage_usage_mailer_preview.rb
index dfed86c75664d..35e9136b22451 100644
--- a/ee/app/mailers/previews/emails/namespace_storage_usage_mailer_preview.rb
+++ b/ee/app/mailers/previews/emails/namespace_storage_usage_mailer_preview.rb
@@ -5,7 +5,7 @@ class NamespaceStorageUsageMailerPreview < ActionMailer::Preview
def out_of_storage
::Emails::NamespaceStorageUsageMailer.notify_out_of_storage(
namespace: Group.last,
- recipients: %w(bob@example.com),
+ recipients: %w[bob@example.com],
usage_values: {
current_size: 101.megabytes,
limit: 100.megabytes,
@@ -16,7 +16,7 @@ def out_of_storage
def limit_warning
::Emails::NamespaceStorageUsageMailer.notify_limit_warning(
namespace: Group.last,
- recipients: %w(bob@example.com),
+ recipients: %w[bob@example.com],
usage_values: {
current_size: 74.megabytes,
limit: 100.megabytes,
diff --git a/ee/app/mailers/previews/license_mailer_preview.rb b/ee/app/mailers/previews/license_mailer_preview.rb
index cddee4b9bfdab..a9e3529c4279b 100644
--- a/ee/app/mailers/previews/license_mailer_preview.rb
+++ b/ee/app/mailers/previews/license_mailer_preview.rb
@@ -2,6 +2,6 @@
class LicenseMailerPreview < ActionMailer::Preview
def approaching_active_user_count_limit
- ::LicenseMailer.approaching_active_user_count_limit(%w(admin@example.com))
+ ::LicenseMailer.approaching_active_user_count_limit(%w[admin@example.com])
end
end
diff --git a/ee/app/models/app_sec/fuzzing/api/scan_profile.rb b/ee/app/models/app_sec/fuzzing/api/scan_profile.rb
index 2832633d8c910..378fdc66616a8 100644
--- a/ee/app/models/app_sec/fuzzing/api/scan_profile.rb
+++ b/ee/app/models/app_sec/fuzzing/api/scan_profile.rb
@@ -4,7 +4,7 @@ module AppSec
module Fuzzing
module API
class ScanProfile
- NAMES = %w(Quick-10 Medium-20 Medium-50 Long-100).freeze
+ NAMES = %w[Quick-10 Medium-20 Medium-50 Long-100].freeze
DESCRIPTIONS = {
'Quick-10' => 'Fuzzing 10 times per parameter',
diff --git a/ee/app/models/app_sec/fuzzing/coverage/corpus.rb b/ee/app/models/app_sec/fuzzing/coverage/corpus.rb
index 597e33913917e..83d69afc4ceb8 100644
--- a/ee/app/models/app_sec/fuzzing/coverage/corpus.rb
+++ b/ee/app/models/app_sec/fuzzing/coverage/corpus.rb
@@ -6,7 +6,7 @@ module Coverage
class Corpus < ApplicationRecord
self.table_name = 'coverage_fuzzing_corpuses'
- ACCEPTED_FORMATS = %w(.zip).freeze
+ ACCEPTED_FORMATS = %w[.zip].freeze
belongs_to :package, class_name: 'Packages::Package'
belongs_to :user, optional: true
diff --git a/ee/app/models/concerns/ee/issue_available_features.rb b/ee/app/models/concerns/ee/issue_available_features.rb
index c49923a3ca429..8dd30670dbf9f 100644
--- a/ee/app/models/concerns/ee/issue_available_features.rb
+++ b/ee/app/models/concerns/ee/issue_available_features.rb
@@ -12,10 +12,10 @@ module IssueAvailableFeatures
def available_features_for_issue_types
strong_memoize(:available_features_for_issue_types) do
super.tap do |available_features|
- available_features[:epics] = %w(issue)
- available_features[:sla] = %w(incident)
- available_features[:confidentiality] += %w(test_case)
- available_features[:move_and_clone] += %w(test_case)
+ available_features[:epics] = %w[issue]
+ available_features[:sla] = %w[incident]
+ available_features[:confidentiality] += %w[test_case]
+ available_features[:move_and_clone] += %w[test_case]
end
end
end
diff --git a/ee/app/models/ee/audit_event.rb b/ee/app/models/ee/audit_event.rb
index 19ef1c7459991..604a95bd7601d 100644
--- a/ee/app/models/ee/audit_event.rb
+++ b/ee/app/models/ee/audit_event.rb
@@ -71,7 +71,7 @@ def stream_to_external_destinations(use_json: false, event_name: 'audit_operatio
end
def entity_is_group_or_project?
- %w(Group Project).include?(entity_type)
+ %w[Group Project].include?(entity_type)
end
private
diff --git a/ee/app/models/ee/description_version.rb b/ee/app/models/ee/description_version.rb
index 7fee44dc6ae95..131d9fc7d1cee 100644
--- a/ee/app/models/ee/description_version.rb
+++ b/ee/app/models/ee/description_version.rb
@@ -14,7 +14,7 @@ module DescriptionVersion
class_methods do
def issuable_attrs
- (super + %i(epic)).freeze
+ (super + %i[epic]).freeze
end
end
diff --git a/ee/app/models/ee/groups/feature_setting.rb b/ee/app/models/ee/groups/feature_setting.rb
index a3c0e4bee1b2d..ea8845646e4d4 100644
--- a/ee/app/models/ee/groups/feature_setting.rb
+++ b/ee/app/models/ee/groups/feature_setting.rb
@@ -5,7 +5,7 @@ module Groups
module FeatureSetting
extend ActiveSupport::Concern
- EE_FEATURES = %i(wiki).freeze
+ EE_FEATURES = %i[wiki].freeze
prepended do
set_available_features(EE_FEATURES)
diff --git a/ee/app/models/ee/issue.rb b/ee/app/models/ee/issue.rb
index 0f613b21a9ffe..cd32f9ddf0693 100644
--- a/ee/app/models/ee/issue.rb
+++ b/ee/app/models/ee/issue.rb
@@ -10,7 +10,7 @@ module Issue
WEIGHT_ALL = 'Everything'
WEIGHT_ANY = 'Any'
WEIGHT_NONE = 'None'
- ELASTICSEARCH_PERMISSION_TRACKED_FIELDS = %w(assignee_ids author_id confidential).freeze
+ ELASTICSEARCH_PERMISSION_TRACKED_FIELDS = %w[assignee_ids author_id confidential].freeze
include Elastic::ApplicationVersionedSearch
include UsageStatistics
diff --git a/ee/app/models/ee/project_feature.rb b/ee/app/models/ee/project_feature.rb
index d3dbef16ef137..46b71cdcd0d89 100644
--- a/ee/app/models/ee/project_feature.rb
+++ b/ee/app/models/ee/project_feature.rb
@@ -5,18 +5,18 @@ module ProjectFeature
extend ActiveSupport::Concern
# When updating this array, make sure to update rubocop/cop/gitlab/feature_available_usage.rb as well.
- EE_FEATURES = %i(requirements).freeze
- NOTES_PERMISSION_TRACKED_FIELDS = %w(
+ EE_FEATURES = %i[requirements].freeze
+ NOTES_PERMISSION_TRACKED_FIELDS = %w[
issues_access_level
repository_access_level
merge_requests_access_level
snippets_access_level
- ).freeze
+ ].freeze
- MILESTONE_PERMISSION_TRACKED_FIELDS = %w(
+ MILESTONE_PERMISSION_TRACKED_FIELDS = %w[
issues_access_level
merge_requests_access_level
- ).freeze
+ ].freeze
prepended do
set_available_features(EE_FEATURES)
diff --git a/ee/app/models/ee/resource_label_event.rb b/ee/app/models/ee/resource_label_event.rb
index 4aeec48e24132..ed11fd6f27c0e 100644
--- a/ee/app/models/ee/resource_label_event.rb
+++ b/ee/app/models/ee/resource_label_event.rb
@@ -11,7 +11,7 @@ module ResourceLabelEvent
class_methods do
def issuable_attrs
- %i(epic).freeze + super
+ %i[epic].freeze + super
end
end
diff --git a/ee/app/models/ee/resource_state_event.rb b/ee/app/models/ee/resource_state_event.rb
index 0c05150beb062..496cb1db13a6c 100644
--- a/ee/app/models/ee/resource_state_event.rb
+++ b/ee/app/models/ee/resource_state_event.rb
@@ -15,7 +15,7 @@ module ResourceStateEvent
class_methods do
def issuable_attrs
- %i(epic).freeze + super
+ %i[epic].freeze + super
end
end
diff --git a/ee/app/models/ee/user.rb b/ee/app/models/ee/user.rb
index a8cf5d435b950..24398a7014e32 100644
--- a/ee/app/models/ee/user.rb
+++ b/ee/app/models/ee/user.rb
@@ -250,7 +250,7 @@ def access_level
def access_level=(new_level)
new_level = new_level.to_s
- return unless %w(admin auditor regular).include?(new_level)
+ return unless %w[admin auditor regular].include?(new_level)
self.admin = (new_level == 'admin')
self.auditor = (new_level == 'auditor')
diff --git a/ee/app/models/ee/vulnerability.rb b/ee/app/models/ee/vulnerability.rb
index ce1e897a0a20b..d935584ca3b23 100644
--- a/ee/app/models/ee/vulnerability.rb
+++ b/ee/app/models/ee/vulnerability.rb
@@ -22,8 +22,8 @@ module Vulnerability
TooManyDaysError = Class.new(StandardError)
MAX_DAYS_OF_HISTORY = 10
- ACTIVE_STATES = %w(detected confirmed).freeze
- PASSIVE_STATES = %w(dismissed resolved).freeze
+ ACTIVE_STATES = %w[detected confirmed].freeze
+ PASSIVE_STATES = %w[dismissed resolved].freeze
SUMMARY_DELIMITER = '|'
REGEX_CAPTURING_STATUS = /\A[\w+\s]+to\s(?<status>\w+)/
diff --git a/ee/app/models/geo/project_registry.rb b/ee/app/models/geo/project_registry.rb
index 5b123ae144816..cf3327d009086 100644
--- a/ee/app/models/geo/project_registry.rb
+++ b/ee/app/models/geo/project_registry.rb
@@ -9,7 +9,7 @@ class Geo::ProjectRegistry < Geo::BaseRegistry
MODEL_CLASS = ::Project
MODEL_FOREIGN_KEY = :project_id
- REGISTRY_TYPES = %i{repository wiki}.freeze
+ REGISTRY_TYPES = %i[repository wiki].freeze
sha_attribute :repository_verification_checksum_sha
sha_attribute :repository_verification_checksum_mismatched
diff --git a/ee/app/models/geo/secondary_usage_data.rb b/ee/app/models/geo/secondary_usage_data.rb
index d493a03151933..e482a5f30d33a 100644
--- a/ee/app/models/geo/secondary_usage_data.rb
+++ b/ee/app/models/geo/secondary_usage_data.rb
@@ -14,12 +14,12 @@ class Geo::SecondaryUsageData < Geo::TrackingBase
# from the metric yaml files that include something
# like `run_on_secondary: true`, but for now we'll
# just enumerate them.
- PAYLOAD_COUNT_FIELDS = %w(
+ PAYLOAD_COUNT_FIELDS = %w[
git_fetch_event_count_weekly
git_push_event_count_weekly
proxy_remote_requests_event_count_weekly
proxy_local_requests_event_count_weekly
- ).freeze
+ ].freeze
store_accessor :payload, *PAYLOAD_COUNT_FIELDS
validate :payload_schema_is_valid
diff --git a/ee/app/models/geo_node_status.rb b/ee/app/models/geo_node_status.rb
index e128d0583ca2c..0af6db9563f37 100644
--- a/ee/app/models/geo_node_status.rb
+++ b/ee/app/models/geo_node_status.rb
@@ -77,7 +77,7 @@ def self.usage_data_fields
Geo::SecondaryUsageData::PAYLOAD_COUNT_FIELDS
end
- RESOURCE_STATUS_FIELDS = (%w(
+ RESOURCE_STATUS_FIELDS = (%w[
repository_verification_enabled
repositories_replication_enabled
repositories_synced_count
@@ -93,7 +93,7 @@ def self.usage_data_fields
repositories_retrying_verification_count
projects_count
container_repositories_replication_enabled
- ) + replicator_class_status_fields + usage_data_fields).freeze
+ ] + replicator_class_status_fields + usage_data_fields).freeze
# Why are disabled classes included? See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/38959#note_402656534
def self.replicator_class_prometheus_metrics
diff --git a/ee/app/models/incident_management/issuable_resource_link.rb b/ee/app/models/incident_management/issuable_resource_link.rb
index 8413637e2e28f..7f5198032d63b 100644
--- a/ee/app/models/incident_management/issuable_resource_link.rb
+++ b/ee/app/models/incident_management/issuable_resource_link.rb
@@ -11,7 +11,7 @@ class IssuableResourceLink < ApplicationRecord
enum link_type: { general: 0, zoom: 1, slack: 2, pagerduty: 3 } # 'general' is the default type
validates :issue, presence: true
- validates :link, presence: true, length: { maximum: 2200 }, addressable_url: { schemes: %w(http https) }
+ validates :link, presence: true, length: { maximum: 2200 }, addressable_url: { schemes: %w[http https] }
validates :link_text, length: { maximum: 255 }
scope :order_by_created_at_asc, -> { reorder(created_at: :asc) }
diff --git a/ee/app/models/integrations/github.rb b/ee/app/models/integrations/github.rb
index e3aac8819af69..5c79c2b6e2acf 100644
--- a/ee/app/models/integrations/github.rb
+++ b/ee/app/models/integrations/github.rb
@@ -69,7 +69,7 @@ def self.token_field_help
end
def self.supported_events
- %w(pipeline)
+ %w[pipeline]
end
def testable?
diff --git a/ee/app/models/merge_requests/status_check_response.rb b/ee/app/models/merge_requests/status_check_response.rb
index dd69d8c9bcbfc..e661520cac150 100644
--- a/ee/app/models/merge_requests/status_check_response.rb
+++ b/ee/app/models/merge_requests/status_check_response.rb
@@ -11,7 +11,7 @@ class StatusCheckResponse < ApplicationRecord
belongs_to :merge_request
belongs_to :external_status_check, class_name: 'MergeRequests::ExternalStatusCheck'
- enum status: %w(passed failed)
+ enum status: %w[passed failed]
validates :merge_request, presence: true
validates :external_status_check, presence: true
diff --git a/ee/app/models/saml_provider.rb b/ee/app/models/saml_provider.rb
index b2e20fde126a6..d7a24ea96606c 100644
--- a/ee/app/models/saml_provider.rb
+++ b/ee/app/models/saml_provider.rb
@@ -2,13 +2,13 @@
class SamlProvider < ApplicationRecord
include IgnorableColumns
- USER_ATTRIBUTES_LOCKED_FOR_MANAGED_ACCOUNTS = %i(email public_email commit_email notification_email).freeze
+ USER_ATTRIBUTES_LOCKED_FOR_MANAGED_ACCOUNTS = %i[email public_email commit_email notification_email].freeze
belongs_to :group
has_many :identities
validates :group, presence: true, top_level_group: true
- validates :sso_url, presence: true, addressable_url: { schemes: %w(https), ascii_only: true }
+ validates :sso_url, presence: true, addressable_url: { schemes: %w[https], ascii_only: true }
validates :certificate_fingerprint, presence: true, certificate_fingerprint: true
validates :default_membership_role, presence: true
validate :git_check_enforced_allowed
@@ -27,7 +27,7 @@ def settings
defaults.to_h.merge(
idp_cert_fingerprint: certificate_fingerprint,
idp_sso_target_url: sso_url,
- attribute_statements: { nickname: %w(username nickname) }
+ attribute_statements: { nickname: %w[username nickname] }
)
end
diff --git a/ee/app/models/security/orchestration_policy_configuration.rb b/ee/app/models/security/orchestration_policy_configuration.rb
index 825c815762084..55871dc6ce13b 100644
--- a/ee/app/models/security/orchestration_policy_configuration.rb
+++ b/ee/app/models/security/orchestration_policy_configuration.rb
@@ -15,7 +15,7 @@ class OrchestrationPolicyConfiguration < ApplicationRecord
# json_schemer computes an $id fallback property for schemas lacking one.
# But this schema is kept anonymous on purpose, so the $id is stripped.
POLICY_SCHEMA_JSON = POLICY_SCHEMA.as_json['root'].except('$id')
- AVAILABLE_POLICY_TYPES = %i{scan_execution_policy scan_result_policy}.freeze
+ AVAILABLE_POLICY_TYPES = %i[scan_execution_policy scan_result_policy].freeze
JSON_SCHEMA_VALIDATION_TIMEOUT = 5.seconds
belongs_to :project, inverse_of: :security_orchestration_policy_configuration, optional: true
diff --git a/ee/app/models/software_license_policy.rb b/ee/app/models/software_license_policy.rb
index ad404f2594dac..d0bc56bc08b9f 100644
--- a/ee/app/models/software_license_policy.rb
+++ b/ee/app/models/software_license_policy.rb
@@ -60,7 +60,7 @@ class SoftwareLicensePolicy < ApplicationRecord
delegate :name, :spdx_identifier, to: :software_license
def self.approval_status_values
- %w(allowed denied)
+ %w[allowed denied]
end
def approval_status
diff --git a/ee/app/models/storage_shard.rb b/ee/app/models/storage_shard.rb
index c51491af73031..7eb4b7e9096a4 100644
--- a/ee/app/models/storage_shard.rb
+++ b/ee/app/models/storage_shard.rb
@@ -26,7 +26,7 @@ def self.all
end
def self.allowed_params
- %i(name).freeze
+ %i[name].freeze
end
def self.build_digest
diff --git a/ee/app/services/approval_rules/create_service.rb b/ee/app/services/approval_rules/create_service.rb
index 061b9f6c070dc..89a4d9358e0d6 100644
--- a/ee/app/services/approval_rules/create_service.rb
+++ b/ee/app/services/approval_rules/create_service.rb
@@ -60,7 +60,7 @@ def approvers_set?
end
def approvers_present?
- %i(user_ids group_ids users groups usernames).any? { |key| @params[key].present? }
+ %i[user_ids group_ids users groups usernames].any? { |key| @params[key].present? }
end
def track_onboarding_progress
diff --git a/ee/app/services/boards/epic_boards/update_service.rb b/ee/app/services/boards/epic_boards/update_service.rb
index a64a0e831eed9..7e19f176bb49f 100644
--- a/ee/app/services/boards/epic_boards/update_service.rb
+++ b/ee/app/services/boards/epic_boards/update_service.rb
@@ -20,11 +20,11 @@ def permitted_params
permitted = PERMITTED_PARAMS
if parent.feature_available?(:scoped_issue_board)
- permitted += %i(labels label_ids)
+ permitted += %i[labels label_ids]
end
if Feature.enabled?(:epic_color_highlight, parent)
- permitted += %i(display_colors)
+ permitted += %i[display_colors]
end
permitted
diff --git a/ee/app/services/ee/boards/update_service.rb b/ee/app/services/ee/boards/update_service.rb
index 2000ea6d011ba..8b5aaaac4b405 100644
--- a/ee/app/services/ee/boards/update_service.rb
+++ b/ee/app/services/ee/boards/update_service.rb
@@ -20,7 +20,7 @@ def permitted_params
permitted = super
if parent.feature_available?(:scoped_issue_board)
- permitted += %i(milestone_id iteration_id iteration_cadence_id assignee_id weight labels label_ids)
+ permitted += %i[milestone_id iteration_id iteration_cadence_id assignee_id weight labels label_ids]
end
permitted
diff --git a/ee/app/services/ee/search/group_service.rb b/ee/app/services/ee/search/group_service.rb
index 31dae5b02ff9e..fe13d0770e764 100644
--- a/ee/app/services/ee/search/group_service.rb
+++ b/ee/app/services/ee/search/group_service.rb
@@ -53,7 +53,7 @@ def allowed_scopes
return super unless group.licensed_feature_available?(:epics)
strong_memoize(:ee_group_allowed_scopes) do
- super + %w(epics)
+ super + %w[epics]
end
end
end
diff --git a/ee/app/services/ee/search/project_service.rb b/ee/app/services/ee/search/project_service.rb
index c80f3bd12e2c8..0109bc46c6ced 100644
--- a/ee/app/services/ee/search/project_service.rb
+++ b/ee/app/services/ee/search/project_service.rb
@@ -7,7 +7,7 @@ module ProjectService
include ::Search::Elasticsearchable
include ::Search::ZoektSearchable
- SCOPES_THAT_SUPPORT_BRANCHES = %w(wiki_blobs commits blobs).freeze
+ SCOPES_THAT_SUPPORT_BRANCHES = %w[wiki_blobs commits blobs].freeze
override :execute
def execute
diff --git a/ee/app/services/epics/tree_reorder_service.rb b/ee/app/services/epics/tree_reorder_service.rb
index 37fde403b83d3..8c8ac7c22e0ef 100644
--- a/ee/app/services/epics/tree_reorder_service.rb
+++ b/ee/app/services/epics/tree_reorder_service.rb
@@ -93,7 +93,7 @@ def supported_types?
end
def valid_relative_position?
- %w(before after).include?(params[:relative_position])
+ %w[before after].include?(params[:relative_position])
end
def different_epic_parent?
diff --git a/ee/app/services/iterations/update_service.rb b/ee/app/services/iterations/update_service.rb
index f718fbe43e861..db10260cbc173 100644
--- a/ee/app/services/iterations/update_service.rb
+++ b/ee/app/services/iterations/update_service.rb
@@ -4,7 +4,7 @@ module Iterations
class UpdateService
include Gitlab::Allowable
- IGNORED_KEYS = %i(group_path id state_enum state).freeze
+ IGNORED_KEYS = %i[group_path id state_enum state].freeze
attr_accessor :parent, :current_user, :params
diff --git a/ee/app/services/jira/jql_builder_service.rb b/ee/app/services/jira/jql_builder_service.rb
index 17f0d23b142c2..6d8aae2fe5af5 100644
--- a/ee/app/services/jira/jql_builder_service.rb
+++ b/ee/app/services/jira/jql_builder_service.rb
@@ -55,19 +55,19 @@ def by_summary_and_description
end
def by_project
- %[project = "#{escape_quotes(jira_project_key)}"]
+ %(project = "#{escape_quotes(jira_project_key)}")
end
def by_labels
return if labels.blank?
- labels.map { |label| %[labels = "#{escape_quotes(label)}"] }.join(' AND ')
+ labels.map { |label| %(labels = "#{escape_quotes(label)}") }.join(' AND ')
end
def by_status
return if status.blank?
- %[status = "#{escape_quotes(status)}"]
+ %(status = "#{escape_quotes(status)}")
end
def order_by
@@ -77,13 +77,13 @@ def order_by
def by_reporter
return if reporter.blank?
- %[reporter = "#{escape_quotes(reporter)}"]
+ %(reporter = "#{escape_quotes(reporter)}")
end
def by_assignee
return if assignee.blank?
- %[assignee = "#{escape_quotes(assignee)}"]
+ %(assignee = "#{escape_quotes(assignee)}")
end
def by_open_and_closed
@@ -91,9 +91,9 @@ def by_open_and_closed
case state
when 'opened'
- %q[statusCategory != Done]
+ %q(statusCategory != Done)
when 'closed'
- %q[statusCategory = Done]
+ %q(statusCategory = Done)
end
end
@@ -101,7 +101,7 @@ def by_vulnerability_ids
return if vulnerability_ids.blank?
vulnerability_ids
- .map { |vulnerability_id| %[description ~ "/-/security/vulnerabilities/#{escape_quotes(vulnerability_id.to_s)}"] }
+ .map { |vulnerability_id| %(description ~ "/-/security/vulnerabilities/#{escape_quotes(vulnerability_id.to_s)}") }
.join(' OR ')
.then { |query| "(#{query})" }
end
@@ -110,7 +110,7 @@ def by_issue_ids
return if issue_ids.blank?
issue_ids
- .map { |issue_id| %[id = #{escape_quotes(issue_id.to_s)}] }
+ .map { |issue_id| %(id = #{escape_quotes(issue_id.to_s)}) }
.join(' OR ')
.then { |query| "(#{query})" }
end
diff --git a/ee/app/services/security/configuration/save_auto_fix_service.rb b/ee/app/services/security/configuration/save_auto_fix_service.rb
index 11e3e803b9093..524e5f541c38b 100644
--- a/ee/app/services/security/configuration/save_auto_fix_service.rb
+++ b/ee/app/services/security/configuration/save_auto_fix_service.rb
@@ -3,7 +3,7 @@
module Security
module Configuration
class SaveAutoFixService
- SUPPORTED_SCANNERS = %w(container_scanning dependency_scanning all).freeze
+ SUPPORTED_SCANNERS = %w[container_scanning dependency_scanning all].freeze
# @param project [Project]
# @param ['dependency_scanning', 'container_scanning', 'all'] feature Type of scanner to apply auto_fix
diff --git a/ee/app/services/security/dependency_list_service.rb b/ee/app/services/security/dependency_list_service.rb
index 0babd566387aa..c98da9f197502 100644
--- a/ee/app/services/security/dependency_list_service.rb
+++ b/ee/app/services/security/dependency_list_service.rb
@@ -2,10 +2,10 @@
module Security
class DependencyListService
- SORT_BY_VALUES = %w(name packager severity).freeze
- SORT_VALUES = %w(asc desc).freeze
- FILTER_PACKAGE_MANAGERS_VALUES = %w(bundler yarn npm pnpm maven composer pip conan go nuget sbt gradle pipenv setuptools).freeze
- FILTER_VALUES = %w(all vulnerable).freeze
+ SORT_BY_VALUES = %w[name packager severity].freeze
+ SORT_VALUES = %w[asc desc].freeze
+ FILTER_PACKAGE_MANAGERS_VALUES = %w[bundler yarn npm pnpm maven composer pip conan go nuget sbt gradle pipenv setuptools].freeze
+ FILTER_VALUES = %w[all vulnerable].freeze
# @param pipeline [Ci::Pipeline]
# @param [Hash] params to sort and filter dependencies
diff --git a/ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb b/ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb
index 8e09446cd2a6a..10c24ebffcd97 100644
--- a/ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb
+++ b/ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb
@@ -56,7 +56,7 @@ def update_uuids
UpdateVulnerabilityUuids::VulnerabilityReads.new(uuid_hash_lookup, project).execute
end
- IDENTIFIER_TYPES_TO_NOT_TAKEOVER = %w(semgrep_id cwe owasp).freeze
+ IDENTIFIER_TYPES_TO_NOT_TAKEOVER = %w[semgrep_id cwe owasp].freeze
delegate :project, to: :pipeline, private: true
--
GitLab