diff --git a/ee/app/models/package_metadata/package.rb b/ee/app/models/package_metadata/package.rb index f1bad8e288f3b2d037c38722b10fb2d69417d44b..70528e0b006b3d60be40b7d8ec0329aecc6578fc 100644 --- a/ee/app/models/package_metadata/package.rb +++ b/ee/app/models/package_metadata/package.rb @@ -104,21 +104,8 @@ def version_in_default_licenses_range?(input_version) range.add(SemverDialects::IntervalParser.parse(type, ">#{highest_version.delete_prefix('v')}")) if highest_version !range.overlaps_with?(interval) - rescue SemverDialects::InvalidConstraintError => err - track_exception(err, input_version) - + rescue SemverDialects::InvalidConstraintError false end - - def track_exception(err, input_version) - ::Gitlab::ErrorTracking.track_exception(err, id: id, - package_name: name, - purl_type: purl_type, - version: input_version, - lowest_version: lowest_version, - highest_version: highest_version, - message: "semver_dialects parse error", error: err.message - ) - end end end diff --git a/ee/spec/models/package_metadata/package_spec.rb b/ee/spec/models/package_metadata/package_spec.rb index 1808326c64028ac911d371364c87b901c4077f24..f2d435794ae87d8ece582dae8b2816dd7dd14ac0 100644 --- a/ee/spec/models/package_metadata/package_spec.rb +++ b/ee/spec/models/package_metadata/package_spec.rb @@ -94,22 +94,7 @@ subject(:license_ids) { package.license_ids_for(version: input_version) } - it 'tracks the exception' do - log_params = { - id: package.id, - package_name: 'cliui', - purl_type: 'npm', - version: input_version, lowest_version: lowest, highest_version: highest, - message: "semver_dialects parse error", - error: a_string_including("invalid constraint") - } - - expect(Gitlab::ErrorTracking).to receive(:track_exception) - .with(an_instance_of(SemverDialects::InvalidConstraintError), **log_params) - .and_call_original - - license_ids - end + specify { expect(license_ids).to eq([]) } end end