From 93a84ed39299445dfcd591bc00bd93cd5dd4801d Mon Sep 17 00:00:00 2001
From: Vijay Hawoldar <vhawoldar@gitlab.com>
Date: Tue, 14 Nov 2023 10:23:42 +0000
Subject: [PATCH] Resolves rubocop map violation in statistics specs
Switches from blocks to using a symbol proc to resolve
rubocop violations
---
.rubocop_todo/style/symbol_proc.yml | 2 --
spec/models/namespace/root_storage_statistics_spec.rb | 2 +-
spec/models/project_statistics_spec.rb | 4 ++--
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml
index cae9839060b9..2d8698cf9cfd 100644
--- a/.rubocop_todo/style/symbol_proc.yml
+++ b/.rubocop_todo/style/symbol_proc.yml
@@ -203,9 +203,7 @@ Style/SymbolProc:
- 'spec/lib/gitlab/usage/metrics/instrumentations/database_metric_spec.rb'
- 'spec/lib/omni_auth/strategies/jwt_spec.rb'
- 'spec/models/merge_request_diff_spec.rb'
- - 'spec/models/namespace/root_storage_statistics_spec.rb'
- 'spec/models/operations/feature_flags/strategy_spec.rb'
- - 'spec/models/project_statistics_spec.rb'
- 'spec/models/repository_spec.rb'
- 'spec/models/user_spec.rb'
- 'spec/presenters/projects/import_export/project_export_presenter_spec.rb'
diff --git a/spec/models/namespace/root_storage_statistics_spec.rb b/spec/models/namespace/root_storage_statistics_spec.rb
index 4b66b7532a7a..9a66b4745c0c 100644
--- a/spec/models/namespace/root_storage_statistics_spec.rb
+++ b/spec/models/namespace/root_storage_statistics_spec.rb
@@ -12,7 +12,7 @@
describe '.for_namespace_ids' do
it 'returns only requested namespaces' do
stats = create_list(:namespace_root_storage_statistics, 3)
- namespace_ids = stats[0..1].map { |s| s.namespace_id }
+ namespace_ids = stats[0..1].map(&:namespace_id)
requested_stats = described_class.for_namespace_ids(namespace_ids).pluck(:namespace_id)
diff --git a/spec/models/project_statistics_spec.rb b/spec/models/project_statistics_spec.rb
index dd7989244d44..211ac257c53a 100644
--- a/spec/models/project_statistics_spec.rb
+++ b/spec/models/project_statistics_spec.rb
@@ -15,8 +15,8 @@
describe '.for_project_ids' do
it 'returns only requested projects' do
stats = create_list(:project_statistics, 3)
- project_ids = stats[0..1].map { |s| s.project_id }
- expected_ids = stats[0..1].map { |s| s.id }
+ project_ids = stats[0..1].map(&:project_id)
+ expected_ids = stats[0..1].map(&:id)
requested_stats = described_class.for_project_ids(project_ids).pluck(:id)
--
GitLab