From 9103ced153fa5c901deae045c14b5451ed5957d4 Mon Sep 17 00:00:00 2001
From: Gerardo Navarro <gerardo@b310.de>
Date: Tue, 20 Feb 2024 17:14:31 +0000
Subject: [PATCH] test: Fix wrong param for shared example 'error service
response'
- Fixing the wrong usage of
shared example 'returning an error service response',
see https://gitlab.com/gitlab-community/gitlab/-/blob/fdf61409f4e8ad44118cd82e987ad76045ef37a6/spec/support/shared_examples/services/service_response_shared_examples.rb#L3
- Currently in the test file `Pypi::CreatePackageService`,
the assertion is ignored because the param `:message`
is passed in the wrong way
Changelog: other
---
spec/services/packages/pypi/create_package_service_spec.rb | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/spec/services/packages/pypi/create_package_service_spec.rb b/spec/services/packages/pypi/create_package_service_spec.rb
index 4c6ccac3e9a3..d0f2a26d61c9 100644
--- a/spec/services/packages/pypi/create_package_service_spec.rb
+++ b/spec/services/packages/pypi/create_package_service_spec.rb
@@ -113,7 +113,8 @@
context 'with an invalid metadata' do
let(:requires_python) { 'x' * 256 }
- it_behaves_like 'returning an error service response', /Pypi package metadata invalid/ do
+ it_behaves_like 'returning an error service response',
+ message: 'Validation failed: Required python is too long (maximum is 255 characters)' do
it { is_expected.to have_attributes(reason: :invalid_parameter) }
end
end
@@ -142,7 +143,8 @@
params[:md5_digest] = md5
end
- it_behaves_like 'returning an error service response', /File name has already been taken/ do
+ it_behaves_like 'returning an error service response',
+ message: 'Validation failed: File name has already been taken' do
it { is_expected.to have_attributes(reason: :invalid_parameter) }
end
--
GitLab