From 90bae399576ccbf2f37d76f4cf874feec2efa80d Mon Sep 17 00:00:00 2001 From: Daniele Rossetti <drossetti@gitlab.com> Date: Wed, 1 Mar 2023 15:57:29 +0100 Subject: [PATCH] Updating injected query param when embedding GOUI --- .../javascripts/behaviors/markdown/render_observability.js | 2 +- ee/spec/features/markdown/observability_spec.rb | 2 +- spec/features/markdown/observability_spec.rb | 2 +- spec/frontend/behaviors/markdown/render_observability_spec.js | 4 +++- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/behaviors/markdown/render_observability.js b/app/assets/javascripts/behaviors/markdown/render_observability.js index 704d85cf22e61..85aae6f53c467 100644 --- a/app/assets/javascripts/behaviors/markdown/render_observability.js +++ b/app/assets/javascripts/behaviors/markdown/render_observability.js @@ -3,7 +3,7 @@ import { darkModeEnabled } from '~/lib/utils/color_utils'; import { setUrlParams } from '~/lib/utils/url_utility'; export function getFrameSrc(url) { - return `${setUrlParams({ theme: darkModeEnabled() ? 'dark' : 'light' }, url)}&kiosk`; + return `${setUrlParams({ theme: darkModeEnabled() ? 'dark' : 'light' }, url)}&kiosk=inline-embed`; } const mountVueComponent = (element) => { diff --git a/ee/spec/features/markdown/observability_spec.rb b/ee/spec/features/markdown/observability_spec.rb index df931ea480a48..d7617d209b979 100644 --- a/ee/spec/features/markdown/observability_spec.rb +++ b/ee/spec/features/markdown/observability_spec.rb @@ -10,7 +10,7 @@ let_it_be(:observable_url) { "https://observe.gitlab.com/#{group.id}/some-dashboard" } let_it_be(:expected) do - %(<iframe src="#{observable_url}?theme=light&kiosk" frameborder="0") + %(<iframe src="#{observable_url}?theme=light&kiosk=inline-embed" frameborder="0") end before do diff --git a/spec/features/markdown/observability_spec.rb b/spec/features/markdown/observability_spec.rb index e57bfafe05e84..0c5aba5326f19 100644 --- a/spec/features/markdown/observability_spec.rb +++ b/spec/features/markdown/observability_spec.rb @@ -9,7 +9,7 @@ let_it_be(:observable_url) { "https://observe.gitlab.com/#{group.id}/some-dashboard" } let_it_be(:expected) do - %(<iframe src="#{observable_url}?theme=light&kiosk" frameborder="0") + %(<iframe src="#{observable_url}?theme=light&kiosk=inline-embed" frameborder="0") end before do diff --git a/spec/frontend/behaviors/markdown/render_observability_spec.js b/spec/frontend/behaviors/markdown/render_observability_spec.js index c87d11742dca4..7ca426d8cd61e 100644 --- a/spec/frontend/behaviors/markdown/render_observability_spec.js +++ b/spec/frontend/behaviors/markdown/render_observability_spec.js @@ -3,7 +3,9 @@ import * as ColorUtils from '~/lib/utils/color_utils'; describe('Observability iframe renderer', () => { const findObservabilityIframes = (theme = 'light') => - document.querySelectorAll(`iframe[src="https://observe.gitlab.com/?theme=${theme}&kiosk"]`); + document.querySelectorAll( + `iframe[src="https://observe.gitlab.com/?theme=${theme}&kiosk=inline-embed"]`, + ); const renderEmbeddedObservability = () => { renderObservability([...document.querySelectorAll('.js-render-observability')]); -- GitLab