From 8ef1b16fecd58ceb94acdd7e27d621ef9bbfe299 Mon Sep 17 00:00:00 2001
From: dfrazao-gitlab <dfrazao@gitlab.com>
Date: Fri, 10 Sep 2021 12:05:46 +0100
Subject: [PATCH] Remove PreventIndexCreation rule for ci_builds_metadata
events taggings
Related to https://gitlab.com/gitlab-org/gitlab/-/issues/339281
---
rubocop/cop/migration/prevent_index_creation.rb | 2 +-
spec/rubocop/cop/migration/prevent_index_creation_spec.rb | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/rubocop/cop/migration/prevent_index_creation.rb b/rubocop/cop/migration/prevent_index_creation.rb
index aeeec36ecf0f..c383466f73bf 100644
--- a/rubocop/cop/migration/prevent_index_creation.rb
+++ b/rubocop/cop/migration/prevent_index_creation.rb
@@ -8,7 +8,7 @@ module Migration
class PreventIndexCreation < RuboCop::Cop::Cop
include MigrationHelpers
- FORBIDDEN_TABLES = %i[ci_builds taggings ci_builds_metadata events].freeze
+ FORBIDDEN_TABLES = %i[ci_builds].freeze
MSG = "Adding new index to #{FORBIDDEN_TABLES.join(", ")} is forbidden, see https://gitlab.com/gitlab-org/gitlab/-/issues/332886"
diff --git a/spec/rubocop/cop/migration/prevent_index_creation_spec.rb b/spec/rubocop/cop/migration/prevent_index_creation_spec.rb
index b5bb770553a3..ed7c8974d8dd 100644
--- a/spec/rubocop/cop/migration/prevent_index_creation_spec.rb
+++ b/spec/rubocop/cop/migration/prevent_index_creation_spec.rb
@@ -6,7 +6,7 @@
RSpec.describe RuboCop::Cop::Migration::PreventIndexCreation do
subject(:cop) { described_class.new }
- let(:forbidden_tables) { %w(ci_builds taggings ci_builds_metadata events) }
+ let(:forbidden_tables) { %w(ci_builds) }
let(:forbidden_tables_list) { forbidden_tables.join(', ') }
context 'when in migration' do
--
GitLab